[Qemu-devel] [PATCH v6 08/13] sm501: Fix hardware cursor

2017-04-21 Thread BALATON Zoltan
Rework HWC handling to simplify it and fix cursor not updating on screen as needed. Previously cursor was not updated because checking for changes in a line overrode the update flag set for the cursor but fixing this is not enough because the cursor should also be updated if its shape or location c

[Qemu-devel] [PATCH v6 00/13] Improvements for SM501 display controller emulation

2017-04-21 Thread BALATON Zoltan
This version just adds some more explanation to patch #7 and Reviewed/Acked by tags for the last patches. BALATON Zoltan (13): sm501: Fixed code style and a few typos in comments sm501: Use defined constants instead of literal values where available sm501: Add missing arbitration control reg

[Qemu-devel] [PATCH v6 06/13] sm501: Add emulation of chip connected via PCI

2017-04-21 Thread BALATON Zoltan
Only the display controller part is created automatically on PCI Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off removing dependency on base address to separate patch v3: Added reset function and PCI ID constant definitions in pci_ids.h v4: Return error for invalid VR

[Qemu-devel] [PATCH v6 05/13] sm501: Get rid of base address in draw_hwc_line

2017-04-21 Thread BALATON Zoltan
Do not use the base address to access data in local memory. This is in preparation to allow chip connected via PCI where base address depends on where the BAR is mapped so it will be unknown. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 6 ++ hw

[Qemu-devel] [PATCH v6 04/13] sm501: QOMify

2017-04-21 Thread BALATON Zoltan
Adding vmstate saving is not in this patch because the state structure will be changed in further patches, then another patch will add vmstate descriptor after those changes. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Add memory regions to device state instead of allocatin

[Qemu-devel] [PATCH v6 09/13] sm501: Misc clean ups

2017-04-21 Thread BALATON Zoltan
- Rename a variable - Move variable declarations out of loop to the beginning in draw_hwc_line Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 10 +- hw/display/sm501_template.h | 10 -- 2 files changed, 9 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Peter Lieven
Am 21.04.2017 um 12:04 schrieb Anton Nefedov: > On error path (like i/o error in one of the coroutines), it's required to > - wait for coroutines completion before cleaning the common structures > - reenter dependent coroutines so they ever finish > > Introduced in 2d9187bc65. > > Signed-off-by

[Qemu-devel] [PATCH v6 12/13] sm501: Add vmstate descriptor

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too hw/display/sm501.c | 100 - 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/hw/display/sm

[Qemu-devel] [PATCH v6 02/13] sm501: Use defined constants instead of literal values where available

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Fix initial value of misc_control register as Peter Maydell suggested Also use M_BYTE constant from cutils.h hw/display/sm501.c | 29 +++-- hw/display/sm501_template.h | 2 +- 2 files changed

[Qemu-devel] [PATCH v6 03/13] sm501: Add missing arbitration control register

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6b72964..6e74200 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -474,6 +474,7 @@ typedef struct S

[Qemu-devel] [PATCH v6 11/13] sm501: Add some more missing registers

2017-04-21 Thread BALATON Zoltan
This is to allow clients to initialise these without failing as long as no 2D engine function is called that would use the written value. Saved values are not used yet (may get used when more of 2D engine is added sometimes) and clients normally only write to most of these registers, nothing is kno

[Qemu-devel] [PATCH v6 01/13] sm501: Fixed code style and a few typos in comments

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 1132 ++- hw/display/sm501_template.h | 52 +- 2 files changed, 594 insertions(+), 590 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 040

[Qemu-devel] [PATCH] migration: setup bi-directional I/O channel for exec: protocol

2017-04-21 Thread Daniel P. Berrange
Historically the migration data channel has only needed to be unidirectional. Thus the 'exec:' protocol was requesting an I/O channel with O_RDONLY on incoming side, and O_WRONLY on the outgoing side. This is fine for classic migration, but if you then try to run TLS over it, this fails because th

Re: [Qemu-devel] [PATCH v6 08/13] sm501: Fix hardware cursor

2017-04-21 Thread Aurelien Jarno
On 2017-04-21 12:31, BALATON Zoltan wrote: > Rework HWC handling to simplify it and fix cursor not updating on > screen as needed. Previously cursor was not updated because checking > for changes in a line overrode the update flag set for the cursor but > fixing this is not enough because the curso

Re: [Qemu-devel] [PATCH v6 00/13] Improvements for SM501 display controller emulation

2017-04-21 Thread Aurelien Jarno
On 2017-04-21 12:31, BALATON Zoltan wrote: > This version just adds some more explanation to patch #7 and > Reviewed/Acked by tags for the last patches. > > BALATON Zoltan (13): > sm501: Fixed code style and a few typos in comments > sm501: Use defined constants instead of literal values where

Re: [Qemu-devel] Help needed: Sparc 64, kernel panic

2017-04-21 Thread Mark Cave-Ayland
On 21/04/17 12:37, Siavash Katebzadeh wrote: > Hi, > > I can reproduce this panic using debian-7.8.0 image. I’m getting this > segmentation fault: > > [ 24.846406] busybox[1]: segfault at f78a000c ip f77ab0ac (rpc > f77ab090) sp ffd95a50 error 30001 in > libc.so.6[f7

Re: [Qemu-devel] [PATCH v2 for-2.10 01/18] crypto: cipher: introduce context free function

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 01/18] crypto: cipher: intro

[Qemu-devel] [PULL 02/65] ram: Rename flush_page_queue() to migration_page_queue_free()

2017-04-21 Thread Juan Quintela
It reflects better what it does. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +- migration/migration.c | 2 +- migration/ram.c | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PULL 07/65] ram: Move start time into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Renamed start_time to time_last_bitmap_sync(peterx suggestion) --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ra

[Qemu-devel] [PULL 28/65] ram: Move migration_bitmap_rcu into RAMState

2017-04-21 Thread Juan Quintela
Once there, rename the type to be shorter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 86 +++-- 1 file changed, 47 insertions(+), 39 deletions(-) diff --git a/migration/ram.c

Re: [Qemu-devel] [PATCH] migration: setup bi-directional I/O channel for exec: protocol

2017-04-21 Thread Juan Quintela
"Daniel P. Berrange" wrote: > Historically the migration data channel has only needed to be > unidirectional. Thus the 'exec:' protocol was requesting an > I/O channel with O_RDONLY on incoming side, and O_WRONLY on > the outgoing side. > > This is fine for classic migration, but if you then try t

[Qemu-devel] [PULL 10/65] ram: Move num_dirty_pages_period into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index d13674f..d6cf032 100644 --- a/migration/ram.c +++ b/migrat

[Qemu-devel] [PULL 03/65] ram: Rename block_name to rbname

2017-04-21 Thread Juan Quintela
So all places are consistent on the naming of a block name parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 356f8ce..776f8

[Qemu-devel] [PULL 30/65] ram: Use the RAMState bytes_transferred parameter

2017-04-21 Thread Juan Quintela
Somewhere it was passed by reference, just use it from RAMState. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 75 + 1 file changed, 27 insertions(+), 48 deletions(-) diff --

Re: [Qemu-devel] [PATCH v2 for-2.10 02/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 02/18] crypto: cipher: intr

[Qemu-devel] [PULL 11/65] ram: Change num_dirty_pages_period type to uint64_t

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/exec/ram_addr.h | 2 +- migration/ram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index b05dc84..9aadc5c 1006

[Qemu-devel] [PULL 05/65] ram: Add dirty_rate_high_cnt to RAMState

2017-04-21 Thread Juan Quintela
We need to add a parameter to several functions to make this work. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/

Re: [Qemu-devel] [PATCH v2 for-2.10 03/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 03/18] crypto: cipher: intr

[Qemu-devel] [PULL 35/65] ram: Remove dirty_bytes_rate

2017-04-21 Thread Juan Quintela
It can be recalculated from dirty_pages_rate. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Dave was the one that reviewed it O:-) --- include/migration/migration.h | 1 - migration/migration.c | 6 +++--- migration/ram.c | 1

[Qemu-devel] [PULL 06/65] ram: Move bitmap_sync_count into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index a59140b..935311d 100644 --- a/migration/ram.c +++ b/mi

[Qemu-devel] [PULL 09/65] ram: Change byte_xfer_{prev, now} type to uint64_t

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index aeef563..d13674f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -158,

[Qemu-devel] [PULL 36/65] ram: Move dirty_pages_rate to RAMState

2017-04-21 Thread Juan Quintela
Treat it like the rest of ram stats counters. Export its value the same way. As an added bonus, no more MigrationState used in migration_bitmap_sync(); Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Again, dave was the one reviewing it --- include

[Qemu-devel] [PULL 00/65] Migration pull request

2017-04-21 Thread Juan Quintela
QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170421 for you to fetch changes up to 2c02468c9b1750aaa5fbeee49cdb55f101608c6a: hmp: info migrate_parameters format tunes (2017-04-21

[Qemu-devel] [PULL 13/65] ram: Move iterations_prev into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 32b1cbb..5b6fef8 100644 --- a/migration/ram.c +++ b/

[Qemu-devel] [PULL 16/65] ram: Remove unused pages_skipped variable

2017-04-21 Thread Juan Quintela
For compatibility, we need to still send a value, but just specify it and comment the fact. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 -- migration/migration.c | 3 ++- migration/ram.c |

[Qemu-devel] [PULL 46/65] ram: ram_discard_range() don't use the mis parameter

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 3 +-- migration/postcopy-ram.c | 6 ++ migration/ram.c | 9 +++-- migration/savevm.c| 3 +-- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/include/migr

[Qemu-devel] [PULL 01/65] ram: Update all functions comments

2017-04-21 Thread Juan Quintela
Added doc comments for existing functions comment and rewrite them in a common style. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Fix Peter Xu comments Improve postcopy comments as per reviews. --- migration/ram.c | 348 1 fil

[Qemu-devel] [PULL 14/65] ram: Move dup_pages into RAMState

2017-04-21 Thread Juan Quintela
Once there rename it to its actual meaning, zero_pages. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram

[Qemu-devel] [PULL 15/65] ram: Remove unused dup_mig_bytes_transferred()

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 1 - migration/ram.c | 5 - 2 files changed, 6 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 24487be..f07

[Qemu-devel] [PULL 04/65] ram: Create RAMState

2017-04-21 Thread Juan Quintela
We create a struct where to put all the ram state Start with the following fields: last_seen_block, last_sent_block, last_offset, last_version and ram_bulk_stage are globals that are really related together. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu

[Qemu-devel] [PULL 47/65] ram: reorganize last_sent_block

2017-04-21 Thread Juan Quintela
We were setting it far away of when we changed it. Now everything is done inside save_page_header. Once there, reorganize code to pass RAMState. We also set CONTINUE flag in a single place. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/

[Qemu-devel] [PULL 17/65] ram: Move norm_pages to RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 78c7f3d..587e2c7 100644 --- a/migration/ram.c +++ b

[Qemu-devel] [PULL 18/65] ram: Remove norm_mig_bytes_transferred

2017-04-21 Thread Juan Quintela
Its value can be calculated by other exported. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 - migration/migration.c | 3 ++- migration/ram.c | 5 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a

[Qemu-devel] [PULL 08/65] ram: Move bytes_xfer_prev into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 53a547c..aeef563 100644 --- a/migration/ram.c +++ b/migration/ram.

[Qemu-devel] [PULL 49/65] ram: Remember last_page instead of last_offset

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé -- Improve comment Fix typo --- migration/ram.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 52ab14b..d501040 1006

[Qemu-devel] [PULL 20/65] ram: Move xbzrle_bytes into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 3e500ae..4dc7869 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -172,6 +172,8 @@ struct

[Qemu-devel] [PULL 19/65] ram: Move iterations into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 85d66ea..3e500ae 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -170,6 +170,8 @@ struct RAMState

[Qemu-devel] [PULL 50/65] ram: Change offset field in PageSearchStatus to page

2017-04-21 Thread Juan Quintela
We are moving everything to work on pages, not addresses. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 51 ++- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/migration/ram.c b/migration/ra

[Qemu-devel] [PULL 21/65] ram: Move xbzrle_pages into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Comment why we need bytes and pages --- migration/ram.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 4dc7869..cf6681c 100644 ---

Re: [Qemu-devel] [PATCH v2 for-2.10 04/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 04/18] crypto: cipher: intr

[Qemu-devel] [PULL 24/65] ram: Move xbzrle_overflows into RAMState

2017-04-21 Thread Juan Quintela
Once there, remove the now unused AccountingInfo struct and var. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/migration/ram.c b/migration/ram

[Qemu-devel] [PULL 12/65] ram: Move xbzrle_cache_miss_prev into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9a82355..32b1cbb 100644 --- a/migration/ram.c +++ b/migra

[Qemu-devel] [PULL 52/65] ram: rename last_ram_offset() last_ram_pages()

2017-04-21 Thread Juan Quintela
We always use it as pages anyways. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- exec.c | 6 +++--- include/exec/ram_addr.h | 2 +- migration/ram.c | 11 +-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c

[Qemu-devel] [PULL 37/65] ram: Move postcopy_requests into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 6 ++ migration/migration.c | 5 ++--- migration/ram.c | 13 + 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/include/migration/migration.h b/include/m

[Qemu-devel] [PULL 22/65] ram: Move xbzrle_cache_miss into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cf6681c..b70db68 100644 --- a/migration/ram.c +++ b/migration/ram.c

[Qemu-devel] [PULL 56/65] qdev: Export qdev_hot_removed

2017-04-21 Thread Juan Quintela
I need to move qdev_unplug to qdev-monitor in the following patch, and it needs access to this variable. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang --- hw/core/qdev.c | 2 +- include/hw/qdev-core.h | 1 + 2 files changed, 2 insertions(+), 1 deletion

[Qemu-devel] [PULL 23/65] ram: Move xbzrle_cache_miss_rate into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b70db68..09f9eff 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -

[Qemu-devel] [PULL 38/65] ram: Add QEMUFile to RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b9f415c..62b44cf 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -165,6 +165,8

[Qemu-devel] [PULL 25/65] ram: Move migration_dirty_pages to RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 88392e4..71f8ef3 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -183,6 +183

[Qemu-devel] [PULL 26/65] ram: Everything was init to zero, so use memset

2017-04-21 Thread Juan Quintela
And then init only things that are not zero by default. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/migration/ram.c b/migration/ram.c in

[Qemu-devel] [PULL 58/65] migration: Disable hotplug/unplug during migration

2017-04-21 Thread Juan Quintela
Until we have reviewed what can/can't be hotplugged during migration, disable it. We can enable it later for the things that we know that work. For instance, memory hotplug during postcopy doesn't work currently. Signed-off-by: Juan Quintela Reviewed-by: zhanghailiang -- - Fix typo. Thanks

[Qemu-devel] [PULL 40/65] ram: Remove compression_switch and inline its logic

2017-04-21 Thread Juan Quintela
We can calculate its value, so we don't create a variable for it. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- After Peter and Dave review, I dropped the variable and just inlined the condition. Fix typo --- migration/ram.c | 12 1 file changed, 8 insertio

Re: [Qemu-devel] [PULL 0/4] qdev patches for 2017-04-21

2017-04-21 Thread Peter Maydell
On 21 April 2017 at 06:40, Markus Armbruster wrote: > The following changes since commit 359c41abe32638adad503e386969fa428cecff52: > > Update version for v2.9.0 release (2017-04-20 15:31:34 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-qdev-2

[Qemu-devel] [PULL 27/65] ram: Move migration_bitmap_mutex into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 42bb82f..23819cd 100644 --- a/migration/ram.c +++ b/migration/ra

[Qemu-devel] [PULL 31/65] ram: Remove ram_save_remaining

2017-04-21 Thread Juan Quintela
Just unfold it. Move ram_bytes_remaining() with the rest of exported functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b

[Qemu-devel] [PULL 41/65] migration: Remove MigrationState from migration_in_postcopy

2017-04-21 Thread Juan Quintela
We need to call for the migrate_get_current() in more that half of the uses, so call that inside. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +- migration/migration.c | 6 -- migration/ram.c

[Qemu-devel] [PULL 29/65] ram: Move bytes_transferred into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f6ae17f..7fbaa52 100644 --- a/migration/ra

[Qemu-devel] [PULL 42/65] ram: We don't need MigrationState parameter anymore

2017-04-21 Thread Juan Quintela
Remove it from callers and callees. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 289d7eb..fe01

[Qemu-devel] [PULL 57/65] qdev: Move qdev_unplug() to qdev-monitor.c

2017-04-21 Thread Juan Quintela
It is not used by linux-user, otherwise I need to to create one stub for migration_is_idle() on following patch. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang Reviewed-by: Markus Armbruster --- hw/core/qdev.c | 34 -- qdev-moni

[Qemu-devel] [PULL 32/65] ram: Move last_req_rb to RAMState

2017-04-21 Thread Juan Quintela
It was on MigrationState when it is only used inside ram.c for postcopy. Problem is that we need to access it without being able to pass it RAMState directly. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 2 -- migration/migration.c | 1 - migra

[Qemu-devel] [PULL 43/65] ram: Rename qemu_target_page_bits() to qemu_target_page_size()

2017-04-21 Thread Juan Quintela
It was used as a size in all cases except one. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- exec.c | 4 ++-- include/sysemu/sysemu.h | 2 +- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 8 migration/savevm.c | 8

[Qemu-devel] [PULL 60/65] migration: don't close a file descriptor while it can be in use

2017-04-21 Thread Juan Quintela
From: Laurent Vivier If we close the QEMUFile descriptor in process_incoming_migration_co() while it has been stopped by an error, the postcopy_ram_listen_thread() can try to continue to use it. And as the memory has been freed it is working with an invalid pointer and crashes. Fix this by relea

[Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting

2017-04-21 Thread Fam Zheng
These are patches to: 1) reorder the function parameters so that Error **errp comes last. Error pointer in the middle of a function parameter list is very uncommon, and does caused mistakes, thus is not a good style. Change to the usual way. 2) apply the error_propagate_null.cocci semantics patc

[Qemu-devel] [PULL 33/65] ram: Move src_page_req* to RAMState

2017-04-21 Thread Juan Quintela
This are the last postcopy fields still at MigrationState. Once there Move MigrationSrcPageRequest to ram.c and remove MigrationState parameters where appropiate. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 17 +--- migration/migration.c

[Qemu-devel] [PULL 44/65] ram: Add page-size to output in 'info migrate'

2017-04-21 Thread Juan Quintela
From: Chao Fan The number of dirty pages is output in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian Reviewed-by: Eric Blake Signed-off-by: Juan Quintela --- hmp.c | 3

[Qemu-devel] [PULL 64/65] hmp: info migrate_capability format tunes

2017-04-21 Thread Juan Quintela
From: Peter Xu Dump the info in a single line is hard to read. Do it one per line. Also, the first "capabilities:" didn't help much. Let's remove it. CC: "Dr. David Alan Gilbert" Signed-off-by: Peter Xu Reviewed-by: "Dr. David Alan Gilbert" Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ju

[Qemu-devel] [PATCH 02/14] socket: Make errp the last parameter of inet_connect_saddr

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/ssh.c| 2 +- include/qemu/sockets.h | 5 +++-- util/qemu-sockets.c| 9 + 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 471ba8a..df09f6c 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -681,7

[Qemu-devel] [PULL 34/65] ram: Create ram_dirty_sync_count()

2017-04-21 Thread Juan Quintela
This is a ram field that was inside MigrationState. Move it to RAMState and make it the same that the other ram stats. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +- migration/migration.c | 3 +-- migration/ram.c | 6 +- 3

Re: [Qemu-devel] [PATCH 4/6] migration: calculate downtime on dst side

2017-04-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch provides downtime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach just keeps tree with page fault addr as a key, > and t1-t2 interval of pagefault time and page copy time, with > affect

[Qemu-devel] [PATCH 03/14] socket: Make errp the last parameter of unix_connect_saddr

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- util/qemu-sockets.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 8e11349..0fe5f13 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -911,8 +911,9 @@ err: return -1;

[Qemu-devel] [PULL 53/65] ram: Use RAMBitmap type for coherence

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f972882..2af8080 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1451,7 +1451,7 @@ vo

[Qemu-devel] [PULL 39/65] ram: Move QEMUFile into RAMState

2017-04-21 Thread Juan Quintela
We receive the file from save_live operations and we don't use it until 3 or 4 levels of calls down. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 84 + 1 file changed, 37 insertions(+), 47 deletion

[Qemu-devel] [PATCH 07/14] mirror: Make errp the last parameter of mirror_start_job

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/mirror.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 164438f..0c1a56c 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1112,10 +1112,11 @@ static void mirror_start_job(const char *jo

Re: [Qemu-devel] KVM call for agenda for 2017-04-25

2017-04-21 Thread Juan Quintela
Juan Quintela wrote: > Hi Gently reminder that call is on next Tuesday. Later, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Su

[Qemu-devel] [PULL 54/65] migration: Remove MigrationState parameter from migration_is_idle()

2017-04-21 Thread Juan Quintela
Only user don't have a MigrationState handly. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 +- migration/migration.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/migration/migration.h b/inc

[Qemu-devel] [PULL 45/65] ram: Pass RAMBlock to bitmap_sync

2017-04-21 Thread Juan Quintela
We change the meaning of start to be the offset from the beggining of the block. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/exec/ram_addr.h | 2 ++ migration/ram.c | 8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/exec

Re: [Qemu-devel] [PATCH v2 for-2.10 12/18] crypto: introduce some common functions for af_alg backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 12/18] crypto: introduce som

[Qemu-devel] [PULL 59/65] ram: Remove migration_bitmap_extend()

2017-04-21 Thread Juan Quintela
We have disabled memory hotplug, so we don't need to handle migration_bitamp there. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: zhanghailiang --- exec.c | 1 - include/exec/ram_addr.h | 2 -- migration/ram.c | 34

[Qemu-devel] [PULL 48/65] ram: Use page number instead of an address for the bitmap operations

2017-04-21 Thread Juan Quintela
We use an unsigned long for the page number. Notice that our bitmaps already got that for the index, so we have that limit. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- rename page to page_abs everywhere. fix trace types for pages --- migration/ram.c| 76 ++

Re: [Qemu-devel] [PATCH v2] qga: Add support network interface statistics in guest-network-get-interfaces command

2017-04-21 Thread Eric Blake
On 04/20/2017 08:14 AM, Eric Blake wrote: >> @@ -648,7 +673,8 @@ >> { 'struct': 'GuestNetworkInterface', >>'data': {'name': 'str', >> '*hardware-address': 'str', >> - '*ip-addresses': ['GuestIpAddress'] } } >> + '*ip-addresses': ['GuestIpAddress'], >> +

[Qemu-devel] [PULL 61/65] virtio-rng: stop virtqueue while the CPU is stopped

2017-04-21 Thread Juan Quintela
From: Laurent Vivier If we modify the virtio-rng virqueue while the vmstate is already migrated we can have some inconsistencies between the virtqueue state and the memory content. To avoid this, stop the virtqueue while the CPU is stopped. Signed-off-by: Laurent Vivier Reviewed-by: Amit Shah

[Qemu-devel] [PULL 51/65] ram: Use ramblock and page offset instead of absolute offset

2017-04-21 Thread Juan Quintela
This removes the needto pass also the absolute offset. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 65 - 1 file changed, 27 insertions(+), 38 deletions(-) diff --git a/migration/ram.c b/migration

[Qemu-devel] [PATCH 04/14] socket: Make errp the last parameter of vsock_connect_saddr

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- util/qemu-sockets.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 0fe5f13..8188d9a 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -728,9 +728,10 @@ static int vsock_connec

[Qemu-devel] [PULL 62/65] migration: set current_active_state once

2017-04-21 Thread Juan Quintela
From: Peter Xu We set it right above this one. No need to set it twice. CC: Juan Quintela CC: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migra

[Qemu-devel] [PULL 55/65] qdev: qdev_hotplug is really a bool

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: zhanghailiang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 4 ++-- include/hw/qdev-core.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 1e7fb33..

[Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block.c | 4 ++-- blockdev.c | 10 +- include/block/block.h| 2 +- qemu-img.c | 2 +- tests/test-replication.c | 8 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c

[Qemu-devel] [PULL 65/65] hmp: info migrate_parameters format tunes

2017-04-21 Thread Juan Quintela
From: Peter Xu Do the same (one per line) to the parameter list. CC: "Dr. David Alan Gilbert" Signed-off-by: Peter Xu Reviewed-by: "Dr. David Alan Gilbert" Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- hmp.c | 22 ++ 1

[Qemu-devel] [PULL 63/65] migration: rename max_size to threshold_size

2017-04-21 Thread Juan Quintela
From: Peter Xu In migration codes (especially in migration_thread()), max_size is used in many place for the threshold value that we will start to do the final flush and jump to the next stage to dump the whole rest things to destination. However its name is confusing to first readers. Let's rena

[Qemu-devel] [PATCH 08/14] block: Make errp the last parameter of commit_active_start

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/mirror.c| 4 ++-- block/replication.c | 2 +- blockdev.c| 2 +- include/block/block_int.h | 6 +++--- qemu-img.c| 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/block/mirror.c b/block/mirror

[Qemu-devel] [PATCH 11/14] scsi: Make errp the last parameter of virtio_scsi_common_realize

2017-04-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/scsi/vhost-scsi.c| 6 -- hw/scsi/virtio-scsi.c | 11 +++ include/hw/virtio/virtio-scsi.h | 8 +--- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index c491ece..f53

<    1   2   3   4   >