Re: [Qemu-devel] is qemu able to run multiple system emulation simultaneously

2017-04-07 Thread Jiahuan Zhang
On 7 April 2017 at 08:26, Jiahuan Zhang wrote: > On 6 April 2017 at 19:58, G 3 wrote: > >> >> On Apr 6, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote: >> >> Dear QEMU developers, >>> >>> I need multiple ARM-based hardware emulation runing simultaneously in one >>> PC. >>> I wander if QE

Re: [Qemu-devel] [PATCH 2/2] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-07 Thread Fam Zheng
On Thu, 04/06 21:15, jemmy858...@gmail.com wrote: > From: Lidong Chen > > BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, > this maybe cause the qcow2 file size is bigger after migration. > This patch check each cluster, use blk_pwrite_zeroes for each > zero cluster. > > Signed-

Re: [Qemu-devel] [PATCH for-2.9 0/2] commit: Fix commit_top_bs problems

2017-04-07 Thread Fam Zheng
On Thu, 04/06 19:14, Kevin Wolf wrote: > The same problem that Fam's patch "mirror: Fix aio context of > mirror_top_bs" fixes for the mirror block job also exists for the > commit block job and the 'commit' HMP command. While comparing the > respective places in mirror.c and commit.c, I also notice

Re: [Qemu-devel] [PATCH 2/2] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-07 Thread 858585 jemmy
On Fri, Apr 7, 2017 at 3:08 PM, Fam Zheng wrote: > On Thu, 04/06 21:15, jemmy858...@gmail.com wrote: >> From: Lidong Chen >> >> BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, >> this maybe cause the qcow2 file size is bigger after migration. >> This patch check each cluster, use

[Qemu-devel] [PATCH 2/3] vnc: simple clean up

2017-04-07 Thread weiqi
From: Wei Qi It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment. Signed-off-by: Wei Qi --- ui/vnc-enc-zrle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c index 5489870..fd63d4f 100644 -

[Qemu-devel] [PATCH 1/3] vhost: simple clean up

2017-04-07 Thread weiqi
From: Wei Qi It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused after assignment, so remove it. Signed-off-by: Wei Qi --- hw/virtio/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 613494d..5c57983 100644 --- a/hw

[Qemu-devel] [PATCH 3/3] esp-pci: simple clean up

2017-04-07 Thread weiqi
From: Wei Qi It is unnecessary to assign variable 'size' here, because 'size' unused after assignment. Signed-off-by: Wei Qi --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index e295d88..1f5980e 100644 --- a/hw/scsi/esp-pci.c +++

[Qemu-devel] [PATCH 0/3] some simple cleanups

2017-04-07 Thread weiqi
From: Wei Qi This patchset cleanups some unused/unnecessary variables assignment. Wei Qi (3): vhost: simple clean up vnc: simple clean up esp-pci: simple clean up hw/scsi/esp-pci.c | 1 - hw/virtio/vhost.c | 1 - ui/vnc-enc-zrle.c | 1 - 3 files changed, 3 deletions(-) -- 1.8.3.1

Re: [Qemu-devel] [PATCH for-2.9 3/5] block: Quiesce old aio context during bdrv_set_aio_context

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 01:44 hat Fam Zheng geschrieben: > On Thu, 04/06 17:17, Kevin Wolf wrote: > > Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben: > > > The fact that the bs->aio_context is changing can confuse the dataplane > > > iothread, because of the now fine granularity aio context lock. > > >

Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration

2017-04-07 Thread 858585 jemmy
On Fri, Apr 7, 2017 at 9:30 AM, 858585 jemmy wrote: > On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote: >> On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote: >>> From: Lidong Chen >>> >>> when migration with high speed, mig_save_device_bulk invoke >>> bdrv_is_allocated

Re: [Qemu-devel] [PATCH for-2.9 5/5] coroutine: Explicitly specify AioContext when creating coroutine

2017-04-07 Thread Fam Zheng
On Thu, 04/06 18:20, Kevin Wolf wrote: > For example, another case where this happens is that block jobs follow > their nodes if the AioContext changes and even implement > .attached_aio_context callbacks when they need to drag additional nodes > into the new context. With your change, the job coro

Re: [Qemu-devel] [PATCH 1/3] vhost: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
On Fri, Apr 07, 2017 at 02:58:46PM +0800, weiqi wrote: > From: Wei Qi > > It is unnecessary to assign 'hdev->nvqs' to 'i', because 'hdev->nvqs' unused > after assignment, so remove it. nit: The line should not be longer than 76 characters [0]. [0] http://wiki.qemu-project.org/Contribute/Submi

Re: [Qemu-devel] [PATCH 2/3] vnc: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
On Fri, Apr 07, 2017 at 02:58:58PM +0800, weiqi wrote: > From: Wei Qi > > It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because > 'estimated_bytes' unused after assignment. > > Signed-off-by: Wei Qi > --- > ui/vnc-enc-zrle.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-

[Qemu-devel] [PATCH v2] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-07 Thread jemmy858585
From: Lidong Chen BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, this maybe cause the qcow2 file size is bigger after migration. This patch check each cluster, use blk_pwrite_zeroes for each zero cluster. Signed-off-by: Lidong Chen --- migration/block.c | 37 +

Re: [Qemu-devel] [PATCH 3/3] esp-pci: simple clean up

2017-04-07 Thread Sahid Orentino Ferdjaoui
On Fri, Apr 07, 2017 at 02:59:08PM +0800, weiqi wrote: > From: Wei Qi > > It is unnecessary to assign variable 'size' here, because 'size' unused after > assignment. > > Signed-off-by: Wei Qi > --- > hw/scsi/esp-pci.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-By: Sahid Orentino Ferdjao

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Alberto Garcia
On Thu 06 Apr 2017 06:40:41 PM CEST, Eric Blake wrote: >> This e-mail is the formal presentation of my proposal to extend the >> on-disk qcow2 format. As you can see this is still an RFC. Due to the >> nature of the changes I would like to get as much feedback as >> possible before going forward.

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Andrew Jones
On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: > Our current ACPI table generation code limits the placement of ACPI > tables to 32-bit addressable memory, in order to be able to emit the > root pointer (RSDP) and root table (RSDT) using table types from the > ACPI 1.0 days. > > S

[Qemu-devel] [PATCH] vhost: skip RAM device memory sections

2017-04-07 Thread Wang guang
From: ZhiPeng Lu A RAM device represents a mapping to a physical device, such as to a PCI * MMIO BAR of an vfio-pci assigned device. Vhost listens to this region,and increases the region's reference count while passthrough?for?network adapters (Physical Function, PF or Virtual Function, VF). Aft

[Qemu-devel] [PATCH] Set QIO_CHANNEL_FEATURE_SHUTDOWN in colo_process_incoming_thread

2017-04-07 Thread Wang guang
From: Guang Wang Due to Signed-off-by: Wang guang --- migration/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/socket.c b/migration/socket.c index 13966f1..193ed22 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -149,6 +149,7 @@ static gboolean socket_accept

Re: [Qemu-devel] [PATCH v3 05/13] qobject: Drop useless QObject casts

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:47:33PM -0500, Eric Blake wrote: > We have macros in place to make it less verbose to add a subtype > of QObject to both QDict and QList. While we have made cleanups > like this in the past (see commit fcfcd8ffc, for example), having > it be automated by Coccinelle makes

Re: [Qemu-devel] [PATCH v3 07/13] block: Use simpler QDict/QList scalar insertion macros

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:47:35PM -0500, Eric Blake wrote: > We now have macros in place to make it less verbose to add a scalar > to QDict and QList, so use them. > > Patch created mechanically via: > spatch --sp-file scripts/coccinelle/qobject.cocci \ > --macro-file scripts/cocci-macro-fi

Re: [Qemu-devel] [PATCH for-2.10 1/9] block: add bdrv_set_read_only() helper function

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:43PM -0400, Jeff Cody wrote: > We have a helper wrapper for checking for the BDS read_only flag, > add a helper wrapper to set the read_only flag as well. > > Signed-off-by: Jeff Cody > --- > block.c | 5 + > block/bochs.c | 2 +- > block/c

[Qemu-devel] [PATCH] vhost: skip RAM device memory sections

2017-04-07 Thread ZhiPeng Lu
A RAM device represents a mapping to a physical device, such as to a PCI * MMIO BAR of an vfio-pci assigned device. Vhost listens to this region,and increases the region's reference count while passthrough?for?network adapters (Physical Function, PF or Virtual Function, VF). After detaching netw

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Laszlo Ersek
On 04/07/17 10:55, Andrew Jones wrote: > On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: >> Our current ACPI table generation code limits the placement of ACPI >> tables to 32-bit addressable memory, in order to be able to emit the >> root pointer (RSDP) and root table (RSDT) using

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread Dr. David Alan Gilbert
I can see a bunch of similar looking failures in Fedora's automatic backtrace stats system -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339 Title: qxl_pre_save assertion failure on vm "save"

Re: [Qemu-devel] [PATCH for-2.10 2/9] block: do not set BDS read_only if copy_on_read enabled

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:44PM -0400, Jeff Cody wrote: Minor comments but: Reviewed-by: Stefan Hajnoczi > diff --git a/block.c b/block.c > index 7b4c7ef..f60d5ea 100644 > --- a/block.c > +++ b/block.c > @@ -192,9 +192,17 @@ void path_combine(char *dest, int dest_size, > } > } > > -v

Re: [Qemu-devel] [PATCH for-2.10 4/9] block: code movement

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:46PM -0400, Jeff Cody wrote: > Move bdrv_is_read_only() up with its friends. > > Signed-off-by: Jeff Cody > --- > block.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH for-2.10 5/9] block: introduce bdrv_try_set_read_only()

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 08:23:12PM -0400, Jeff Cody wrote: > On Wed, Apr 05, 2017 at 04:28:44PM -0400, John Snow wrote: > > On 04/05/2017 02:28 PM, Jeff Cody wrote: > > > diff --git a/include/block/block.h b/include/block/block.h > > > index beb563a..0049b57 100644 > > > --- a/include/block/block.h

Re: [Qemu-devel] [PATCH] kvm: pass the virtual SEI syndrome to guest OS

2017-04-07 Thread Laszlo Ersek
On 04/07/17 04:52, gengdongjiu wrote: > > On 2017/4/7 2:55, Laszlo Ersek wrote: >> I'm unsure if, by "not fixed", you are saying >> >> the number of CPER entries that fits in Error Status Data Block N is >> not *uniform* across 0 <= N <= 10 [1] >> >> or >> >> the number of CPER entries that

Re: [Qemu-devel] [PATCH 02/54] ram: Rename flush_page_queue() to migration_page_queue_free()

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It reflects better what it does. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 2 +- > migration/migration.c | 2 +- > migration/ram.c | 5 +++-- > 3 files chang

Re: [Qemu-devel] [PATCH] Set QIO_CHANNEL_FEATURE_SHUTDOWN in colo_process_incoming_thread

2017-04-07 Thread Daniel P. Berrange
On Sat, Apr 08, 2017 at 09:16:22AM +0800, Wang guang wrote: > From: Guang Wang > > Due to > > Signed-off-by: Wang guang > --- > migration/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/migration/socket.c b/migration/socket.c > index 13966f1..193ed22 100644 > --- a/migration

Re: [Qemu-devel] [PATCH] event: Add signal information to SHUTDOWN

2017-04-07 Thread Daniel P. Berrange
On Thu, Apr 06, 2017 at 04:09:17PM -0500, Eric Blake wrote: > qemu_kill_report() is already able to tell whether a shutdown > was triggered by guest action (no output) or by a host signal > (a message about termination is printed via error_report); but > this information is then lost. Libvirt woul

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Phil Dennis-Jordan
On 7 April 2017 at 21:11, Laszlo Ersek wrote: > On 04/07/17 10:55, Andrew Jones wrote: >> On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: >>> Our current ACPI table generation code limits the placement of ACPI >>> tables to 32-bit addressable memory, in order to be able to emit the

Re: [Qemu-devel] [PATCH 09/54] ram: Change byte_xfer_now type to uint64_t

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela OK, subject is a bit misleading since it also does _prev, but yes: Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration/ra

Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/exec/ram_addr.h | 2 +- > migration/ram.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h > index b05dc84..9aadc5c 100

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Ard Biesheuvel
On 7 April 2017 at 10:36, Phil Dennis-Jordan wrote: > On 7 April 2017 at 21:11, Laszlo Ersek wrote: >> On 04/07/17 10:55, Andrew Jones wrote: >>> On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: Our current ACPI table generation code limits the placement of ACPI tables to

Re: [Qemu-devel] [PATCH for-2.10 2/9] block: do not set BDS read_only if copy_on_read enabled

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:44PM -0400, Jeff Cody wrote: > @@ -1173,7 +1171,18 @@ static int vvfat_open(BlockDriverState *bs, QDict > *options, int flags, > if (ret < 0) { > goto fail; > } > -bdrv_set_read_only(bs, false); > +ret = bdrv_set_read_onl

Re: [Qemu-devel] [PATCH 40/54] ram: Remove compression_switch and inline its logic

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We can calculate its value, so not create a varible for it. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > -- > > After Peter and Dave review, I dropped the variable and just inlined > the condition. > > Later, Juan. > >

Re: [Qemu-devel] [PATCH for-2.10 7/9] block/rbd - update variable names to more apt names

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:49PM -0400, Jeff Cody wrote: > Update 'clientname' to be 'user', which tracks better with both > the QAPI and rados viarable naming. > > Update 'name' to be 'image_name', as it indicates the rbd image. > Naming it 'image' would have been ideal, but we are using that f

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Phil Dennis-Jordan
On Fri, Apr 7, 2017 at 9:44 PM, Ard Biesheuvel wrote: > On 7 April 2017 at 10:36, Phil Dennis-Jordan wrote: >> On 7 April 2017 at 21:11, Laszlo Ersek wrote: >>> On 04/07/17 10:55, Andrew Jones wrote: On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: > Our current ACPI tabl

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Laszlo Ersek
On 04/07/17 11:36, Phil Dennis-Jordan wrote: > On 7 April 2017 at 21:11, Laszlo Ersek wrote: >> On 04/07/17 10:55, Andrew Jones wrote: >>> On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: Our current ACPI table generation code limits the placement of ACPI tables to 32-bit

Re: [Qemu-devel] [PATCH for-2.10 8/9] block/rbd: do not blindly set bs->read_only

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:50PM -0400, Jeff Cody wrote: > We do not want to just blindly set bs->read_only. The only time > we need to set it with the current rbd driver, is if we are using an > rbd snapshot. In that case, we must set it to read-only. > > Signed-off-by: Jeff Cody > --- > bl

Re: [Qemu-devel] [PATCH for-2.10 9/9] block/rbd: Add support for reopen()

2017-04-07 Thread Stefan Hajnoczi
On Wed, Apr 05, 2017 at 02:28:51PM -0400, Jeff Cody wrote: > This adds support for reopen in rbd, for changing between r/w and r/o. > > Note, that this is only a flag change, but we will block a change from > r/o to r/w if we are using an RBD internal snapshot. > > Signed-off-by: Jeff Cody > ---

Re: [Qemu-devel] [PATCH] hw/arm/virt: generate 64-bit addressable ACPI objects

2017-04-07 Thread Laszlo Ersek
On 04/07/17 11:44, Ard Biesheuvel wrote: > On 7 April 2017 at 10:36, Phil Dennis-Jordan wrote: >> On 7 April 2017 at 21:11, Laszlo Ersek wrote: >>> On 04/07/17 10:55, Andrew Jones wrote: On Thu, Apr 06, 2017 at 10:22:09PM +0100, Ard Biesheuvel wrote: > @@ -712,7 +712,7 @@ static void bu

Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine

2017-04-07 Thread Fam Zheng
On Fri, 04/07 14:54, Fam Zheng wrote: > > main loopiothread > --- > blockdev_snapshot > aio_context_acquire(bs->ctx) > bdrv_flush(bs) > bdrv_co_flush(bs) > ... > qe

Re: [Qemu-devel] [PATCH 45/54] ram: Pass RAMBlock to bitmap_sync

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We change the meaning of start to be the offset from the beggining of > the block. > > Signed-off-by: Juan Quintela Still a little nervous about whether we want to pass RB all the way down to cpu_* but OK. Reviewed-by: Dr. David Alan Gilbert > -

Re: [Qemu-devel] [PATCH v2] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-07 Thread Fam Zheng
On Fri, 04/07 16:44, jemmy858...@gmail.com wrote: > From: Lidong Chen > > BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, > this maybe cause the qcow2 file size is bigger after migration. > This patch check each cluster, use blk_pwrite_zeroes for each > zero cluster. > > Signed-

Re: [Qemu-devel] [PULL for-2.9 0/1] VFIO fixes 2017-04-06

2017-04-07 Thread Peter Maydell
On 6 April 2017 at 23:11, Alex Williamson wrote: > The following changes since commit 54d689988c847271d87b3eb113712147129fb811: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-04-06 09:27:49 +0100) > > are available in the git repository at: > > > git:

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-07 Thread Kevin Wolf
Am 06.04.2017 um 23:29 hat Richard W.M. Jones geschrieben: > On Thu, Apr 06, 2017 at 04:23:19PM -0500, Eric Blake wrote: > > On 04/06/2017 04:15 PM, Richard W.M. Jones wrote: > > > > +++ b/block/io.c > > @@ -945,6 +945,8 @@ static int coroutine_fn > > bdrv_co_do_copy_on_readv(BdrvC

Re: [Qemu-devel] [PATCH 48/54] ram: Use page number instead of an address for the bitmap operations

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We use an unsigned long for the page number. Notice that our bitmaps > already got that for the index, so we have that limit. > > Signed-off-by: Juan Quintela see below > -- > > rename page to page_abs everywhere. > fix trace types for pages

Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups

2017-04-07 Thread Gerd Hoffmann
On Mi, 2017-04-05 at 09:35 +0100, Mark Cave-Ayland wrote: > This started as part of the work on Gerd's thread-safe display patches > but ended up turning into something a lot more comprehensive. It contains > lots of cleanupm and fixes for display invalidation (particularly on 24-bit > TCX) exposed

Re: [Qemu-devel] [PATCH] virtio-gpu: replace PIXMAN_* by PIXMAN_BE_*

2017-04-07 Thread Gerd Hoffmann
On Mo, 2017-04-03 at 13:40 +0200, Laurent Vivier wrote: > This avoids a "#ifdef HOST_WORDS_BIGENDIAN" and this is the purpose > of PIXMAN_BE_* macros. Added to vga queue (for 2.10). thanks, Gerd

Re: [Qemu-devel] [PATCH 0/3] Fix incoming migration regression of QXL in VGA mode

2017-04-07 Thread Gerd Hoffmann
On Do, 2017-04-06 at 14:05 +0200, Marc-André Lureau wrote: > Hi, > > Commit cd958edb1fae85d introduced a migration regression in QXL VGA > mode. The last patch fixes it. The first two patches helped me reason > about the related console code. > > Marc-André Lureau (3): > console: add same surfa

[Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Kevin Wolf
The assertion is currently failing. We can't require callers to have write permissions when all they are doing is a read, so comment it out. Add a FIXME comment in the code so that the check is re-enabled when copy on read is refactored into its own filter driver. Reported-by: Richard W.M. Jones

Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups

2017-04-07 Thread Mark Cave-Ayland
On 07/04/17 11:28, Gerd Hoffmann wrote: > On Mi, 2017-04-05 at 09:35 +0100, Mark Cave-Ayland wrote: >> This started as part of the work on Gerd's thread-safe display patches >> but ended up turning into something a lot more comprehensive. It contains >> lots of cleanupm and fixes for display inval

Re: [Qemu-devel] [PATCH 49/54] ram: Remember last_page instead of last_offset

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > > -- > > Improve comment > Fix typo > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c

Re: [Qemu-devel] [PATCH for-2.9] block: Don't check permissions for copy on read

2017-04-07 Thread Richard W.M. Jones
On Fri, Apr 07, 2017 at 12:32:45PM +0200, Kevin Wolf wrote: > The assertion is currently failing. We can't require callers to have > write permissions when all they are doing is a read, so comment it out. > Add a FIXME comment in the code so that the check is re-enabled when > copy on read is refac

[Qemu-devel] [PATCH] 9pfs: xattr: fix memory leak in v9fs_list_xattr

2017-04-07 Thread Li Qiang
Free 'orig_value' in error path. Signed-off-by: Li Qiang --- hw/9pfs/9p-xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/9p-xattr.c b/hw/9pfs/9p-xattr.c index eec160b..d05c1a1 100644 --- a/hw/9pfs/9p-xattr.c +++ b/hw/9pfs/9p-xattr.c @@ -108,6 +108,7 @@ ssize_t v9fs_list_xattr(

Re: [Qemu-devel] [PATCH 51/54] ram: Use ramblock and page offset instead of absolute offset

2017-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This removes the needto pass also the absolute offset. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 65 > - > 1 file changed, 27 insertions

[Qemu-devel] [PATCH v9 0/9] VT-d: vfio enablement and misc enhances

2017-04-07 Thread Peter Xu
This is v9 of vt-d vfio enablement series. v9: - add r-b for Eric on patch 1,2,4,5 - add r-b for mst on all patches - add a-b for Alex on patch 1 - add commit message in patch 2 (it was empty) [Eric] - fix English errors [Eric] v8 - remove patches 1-9 since merged already - add David's r-b for al

Re: [Qemu-devel] [PATCH 00/14] TCX/CG3 adapter cleanups

2017-04-07 Thread Gerd Hoffmann
Hi, > Yes, I can do. I think it makes sense to merge them before your display > thread-safety series, so if that still works for you I'll send a pull > request early on when the tree opens for 2.10 to clear the way for your > updates. Sounds good. Maybe I split the series anyway, first merge t

[Qemu-devel] [PATCH v9 3/9] memory: provide iommu_replay_all()

2017-04-07 Thread Peter Xu
This is an "global" version of existing memory_region_iommu_replay() - we announce the translations to all the registered notifiers, instead of a specific one. Reviewed-by: David Gibson Reviewed-by: \"Michael S. Tsirkin\" Signed-off-by: Peter Xu --- include/exec/memory.h | 8 memory.c

[Qemu-devel] [PATCH v9 6/9] intel_iommu: use the correct memory region for device IOTLB notification

2017-04-07 Thread Peter Xu
From: Jason Wang We have a specific memory region for DMAR now, so it's wrong to trigger the notifier with the root region. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Jason Wang Reviewed-by: Peter Xu Reviewed-by: \"Michael S. Tsirkin\"

[Qemu-devel] [PATCH v9 7/9] intel_iommu: provide its own replay() callback

2017-04-07 Thread Peter Xu
The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally consumes a lot of time (which looks like a dead loop). The solution is simple - we don't walk over all the regions. Instead, we jump over the regions

[Qemu-devel] [PATCH v9 1/9] memory: add section range info for IOMMU notifier

2017-04-07 Thread Peter Xu
In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check the notification type (MAP|UNMAP), but also check whether the notified iova range overlaps with the range of specific IOMMU notifier, and skip th

[Qemu-devel] [PATCH v9 2/9] memory: provide IOMMU_NOTIFIER_FOREACH macro

2017-04-07 Thread Peter Xu
A new macro is provided to iterate all the IOMMU notifiers hooked under specific IOMMU memory region. Reviewed-by: David Gibson Reviewed-by: Eric Auger Reviewed-by: \"Michael S. Tsirkin\" Signed-off-by: Peter Xu --- include/exec/memory.h | 3 +++ memory.c | 4 ++-- 2 files change

[Qemu-devel] [PATCH v9 9/9] intel_iommu: enable remote IOTLB

2017-04-07 Thread Peter Xu
This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead of translate() every page for iotlb invalid

[Qemu-devel] [PATCH v9 4/9] memory: introduce memory_region_notify_one()

2017-04-07 Thread Peter Xu
Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Reviewed-by: David Gibson Reviewed-by: Eric Auger Reviewed-by: \"Michael S. Tsirkin\" Signed-off-by: Peter Xu --- include/exec/memory.h |

[Qemu-devel] [PATCH v9 5/9] memory: add MemoryRegionIOMMUOps.replay() callback

2017-04-07 Thread Peter Xu
Originally we have one memory_region_iommu_replay() function, which is the default behavior to replay the translations of the whole IOMMU region. However, on some platform like x86, we may want our own replay logic for IOMMU regions. This patch adds one more hook for IOMMUOps for the callback, and

[Qemu-devel] [PATCH v9 8/9] intel_iommu: allow dynamic switch of IOMMU region

2017-04-07 Thread Peter Xu
This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU address space, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to m

[Qemu-devel] [PATCH v2 for-2.10 0/8] s390x: Basic support for 3270 devices

2017-04-07 Thread Cornelia Huck
Next version of the 3270 support patch set, originally sent in February. Rebased on top of the current s390-next branch. See http://wiki.qemu-project.org/Features/3270 for some information on features, limitations and how to set this up. I'd still like some acks for the first patch. Changes v1 -

[Qemu-devel] [PATCH v2 for-2.10 1/8] chardev: Basic support for TN3270

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces basic support for TN3270, which needs to negotiate three Telnet options during handshake: - End of Record - Binary Transmission - Terminal-Type As a basic implementation, this simply ignores NOP and Interrupt Process(IP) commands. More work should be done for

[Qemu-devel] [PATCH v2 for-2.10 4/8] s390x/3270: Add emulated terminal3270 device

2017-04-07 Thread Cornelia Huck
From: Yang Chen This is a basic implementation of the emulated ccw-attached 3270 called x-terminal3270, which provides visibility of the device in the qemu monitor and guest. The x prefix indicates that this is just an experimental implementation for the current stage. This device will not be com

[Qemu-devel] [PATCH v2 for-2.10 2/8] s390x/css: Add an algorithm to find a free chpid

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces a function named css_find_free_chpid() to find a free channel path. Because virtio-ccw device used zero as its channel path number, it would be sensible to skip the reserved one and search upwards. Signed-off-by: Jing Liu Reviewed-by: QingFeng Hao Reviewed-by: Do

[Qemu-devel] [PATCH v2 for-2.10 3/8] s390x/3270: Add abstract emulated ccw-attached 3270 device

2017-04-07 Thread Cornelia Huck
From: Yang Chen This introduces the infrastructure for the emulated 3270 devices, which will be attached to the virtual-css-bus. Signed-off-by: Yang Chen Signed-off-by: Jing Liu Reviewed-by: QingFeng Hao Reviewed-by: Dong Jia Shi Signed-off-by: Cornelia Huck --- hw/s390x/3270-ccw.c

[Qemu-devel] [PATCH v2 for-2.10 5/8] s390x/3270: 3270 data stream handling

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces the input and output handlers for 3270 device, setting up the data tunnel among guest kernel, qemu and the 3270 client. After the client connected and TN3270 handshake done, signal the not-ready to ready status by an unsolicited device-end interrupt, and then the 3

[Qemu-devel] [PATCH v2 for-2.10 8/8] s390x/3270: Mark non-migratable and enable the device

2017-04-07 Thread Cornelia Huck
From: Jing Liu Mark 3270 as non-migratable for the experimental stage. Enable the 3270 device so that we can use x3270 client to operate the guest. Run qemu with the arguments: -chardev socket,id=char3270_0,host=0.0.0.0,port=23,nowait,server,tn3270 \ -device x-terminal3270,chardev=char32

[Qemu-devel] [PATCH v2 for-2.10 6/8] s390x/3270: Add the TCP socket events handler for 3270

2017-04-07 Thread Cornelia Huck
From: Jing Liu This introduces a chr_event handler to handle the 3270 connection and disconnection events. Signed-off-by: Jing Liu Reviewed-by: QingFeng Hao Reviewed-by: Dong Jia Shi Signed-off-by: Cornelia Huck --- hw/char/terminal3270.c | 28 +++- 1 file changed, 2

[Qemu-devel] [PATCH v2 for-2.10 7/8] s390x/3270: Detect for continued presence of a 3270 client

2017-04-07 Thread Cornelia Huck
From: Jing Liu To ensure that we do not keep any 3270 sockets where the client is not connected anymore, we send a packet with the timing mark option after ten minutes of client inactivity. If the client does not answer it, then the socket will be closed automatically. This helps to ensure that

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-07 Thread Pavel Dovgalyuk
> From: mttcg-requ...@listserver.greensocs.com > [mailto:mttcg-requ...@listserver.greensocs.com] > On 04/04/2017 07:37, Pavel Dovgalyuk wrote: > >> -icount -= (cpu->icount_decr.u16.low + cpu->icount_extra); > >> +/* Take into account what has run */ > >> +icount += cpu_get_

Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 09:30:33AM +0800, 858585 jemmy wrote: > On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote: > >> From: Lidong Chen > >> > >> when migration with high speed, mig_save_device_bulk invoke > >> bdrv

[Qemu-devel] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-07 Thread Vladimir Sementsov-Ogievskiy
Do not do extra call to _get_block_status() Signed-off-by: Vladimir Sementsov-Ogievskiy --- Also, I'm not sure about last line: s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA; (which is equal to old code) may be, it should be s->status = s->target_has_backing ? BLK_BACKING_FIL

Re: [Qemu-devel] [PATCH v3] migration/block:limit the time used for block migration

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 09:30:33AM +0800, 858585 jemmy wrote: > On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote: > > > > A proper solution is to refactor the synchronous code to make it > > asynchronous. This might

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > On 05/04/2017 15:25, Alex Bennée wrote: >> This ensures each time the vCPU thread reads the icount we update the >> master timer_state.qemu_icount field. This way as long as updates are >> in BQL protected sections (which they should be) the main-loop can >> never come to

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Paolo Bonzini
- Original Message - > From: "Alex Bennée" > To: "Paolo Bonzini" > Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" > , qemu-devel@nongnu.org, > mt...@greensocs.com, "fred konrad" , "a rigo" > , > c...@braap.org, "bobby prani" , > nik...@linux.vnet.ibm.com, "Peter Crosthwait

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Stefan Hajnoczi
On Thu, Apr 06, 2017 at 06:01:48PM +0300, Alberto Garcia wrote: > Here are the results (subcluster size in brackets): > > |-++-+---| > | cluster size | subclusters=on | subclusters=off | Max L2 cache size | > |-+---

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Alberto Garcia
On Fri 07 Apr 2017 02:20:21 PM CEST, Stefan Hajnoczi wrote: >> Here are the results when writing to an empty 40GB qcow2 image with no >> backing file. The numbers are of course different but as you can see >> the patterns are similar: >> >> |-++-+---

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Kevin Wolf
Am 06.04.2017 um 18:40 hat Eric Blake geschrieben: > On 04/06/2017 10:01 AM, Alberto Garcia wrote: > > I thought of three alternatives for storing the subcluster bitmaps. I > > haven't made my mind completely about which one is the best one, so > > I'd like to present all three for discussion. Here

Re: [Qemu-devel] [PATCH v2 0/6] block: Fixes regarding dataplane and management operations

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 08:54 hat Fam Zheng geschrieben: > v2: - Drop patch 4 in v1. A second thought made me feel neither it nor Kevin's > suggestion to move the BH process to bdrv_drain_recurse/BDRV_POLL_WHILE > is a complete fix. So leave it for a separate patch. > - Add rev-by to patch

Re: [Qemu-devel] [PATCH v2 4/6] block: Quiesce old aio context during bdrv_set_aio_context

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:12PM +0800, Fam Zheng wrote: > @@ -4413,6 +4416,10 @@ void bdrv_set_aio_context(BlockDriverState *bs, > AioContext *new_context) > aio_context_acquire(new_context); > bdrv_attach_aio_context(bs, new_context); > aio_context_release(new_context); > +i

Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation

2017-04-07 Thread Kevin Wolf
Am 07.04.2017 um 14:20 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 06, 2017 at 06:01:48PM +0300, Alberto Garcia wrote: > > Here are the results (subcluster size in brackets): > > > > |-++-+---| > > | cluster size | subclusters=o

Re: [Qemu-devel] is qemu able to run multiple system emulation simultaneously

2017-04-07 Thread G 3
On Apr 7, 2017, at 3:08 AM, Jiahuan Zhang wrote: On 7 April 2017 at 08:26, Jiahuan Zhang wrote: On 6 April 2017 at 19:58, G 3 wrote: On Apr 6, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote: Dear QEMU developers, I need multiple ARM-based hardware emulation runing simultaneous

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > - Original Message - >> From: "Alex Bennée" >> To: "Paolo Bonzini" >> Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" >> , qemu-devel@nongnu.org, >> mt...@greensocs.com, "fred konrad" , "a rigo" >> , >> c...@braap.org, "bobby prani" , >> nik...@linu

Re: [Qemu-devel] [PATCH v2 1/6] block: Fix unpaired aio_disable_external in external snapshot

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:09PM +0800, Fam Zheng wrote: > bdrv_replace_child_noperm tries to hand over the quiesce_counter state > from old bs to the new one, but if they are not on the same aio context > this causes unbalance. > > Fix this by setting the correct aio context before calling > bd

Re: [Qemu-devel] [PATCH v2 2/6] block: Assert attached child node has right aio context

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:10PM +0800, Fam Zheng wrote: > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > block.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 3/6] mirror: Fix aio context of mirror_top_bs

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:11PM +0800, Fam Zheng wrote: > It should be moved to the same context as source, before inserting to the > graph. > > Reviewed-by: Eric Blake > Reviewed-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > block/mirror.c | 1 + > 1 file changed, 1 insertion(+) Revie

Re: [Qemu-devel] [PATCH v2 5/6] coroutine: Explicitly specify AioContext when entering coroutine

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:13PM +0800, Fam Zheng wrote: > Coroutine in block layer should always be waken up in bs->aio_context > rather than the "current" context where it is entered. They differ when > the main loop is doing QMP tasks. > > Race conditions happen without this patch, because th

Re: [Qemu-devel] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn

2017-04-07 Thread Stefan Hajnoczi
On Fri, Apr 07, 2017 at 02:54:14PM +0800, Fam Zheng wrote: > Previously, before test_block_job_start returns, the job can already > complete, as a result, the transactional state of other jobs added to > the same txn later cannot be handled correctly. > > Move the block_job_start() calls to caller

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-07 Thread Gerd Hoffmann
I put my money on that one: https://cgit.freedesktop.org/spice/win32/qxl-wddm- dod/commit/?id=f6e099db39e7d0787f294d5fd0dce328b5210faa commit f6e099db39e7d0787f294d5fd0dce328b5210faa Author: Sameeh Jubran Date: Sun Sep 11 16:05:24 2016 +0300 Use the second bar (VRAM) for qxl command buffe

[Qemu-devel] [Bug 1013714] Re: Data corruption after block migration (LV->LV)

2017-04-07 Thread Thomas Huth
Closing according to comment #3 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013714 Title: Data corruption after block migration (LV->LV)

  1   2   3   >