Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-04 Thread Alexander Graf
On 04.04.17 08:58, Thomas Huth wrote: On 04.04.2017 08:53, Alexander Graf wrote: On 03.04.17 23:00, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: On 03.04.17 22:10, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wr

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-04 Thread Thomas Huth
On 03.04.2017 22:05, Eduardo Habkost wrote: > On Mon, Apr 03, 2017 at 08:42:12PM +0100, Peter Maydell wrote: >> On 3 April 2017 at 19:30, Eduardo Habkost wrote: >>> On Mon, Apr 03, 2017 at 03:08:06PM +0100, Peter Maydell wrote: On 3 April 2017 at 14:54, Eduardo Habkost wrote: > This, on

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-04 Thread Alexander Graf
> Am 04.04.2017 um 09:05 schrieb Thomas Huth : > >> On 03.04.2017 22:05, Eduardo Habkost wrote: >>> On Mon, Apr 03, 2017 at 08:42:12PM +0100, Peter Maydell wrote: On 3 April 2017 at 19:30, Eduardo Habkost wrote: > On Mon, Apr 03, 2017 at 03:08:06PM +0100, Peter Maydell wrote: >> On

Re: [Qemu-devel] [RfC PATCH 0/4] make display updates thread safe.

2017-04-04 Thread Mark Cave-Ayland
On 04/04/17 07:12, Gerd Hoffmann wrote: > Hi, > >> -unsigned long align = 1 << (TARGET_PAGE_BITS + BITS_PER_LEVEL); >> +unsigned long align = 1UL << (TARGET_PAGE_BITS + BITS_PER_LEVEL); > >> There were 2 issues here: without the UL suffix on align I was getting >> incorrect first/last

Re: [Qemu-devel] [PATCH v2 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands

2017-04-04 Thread Thomas Huth
On 03.04.2017 21:09, John Snow wrote: > > > On 03/30/2017 03:50 AM, Thomas Huth wrote: >> When running certain HMP commands (like "device_del") via QMP, we >> can sometimes get a QMP event in the response first, so that the >> "g_assert(ret)" statement in qtest_hmp() triggers and the test >> fail

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-04 Thread Dr. David Alan Gilbert
* Patrick Ohly (patrick.o...@intel.com) wrote: > On Mon, 2017-04-03 at 18:38 +0100, Dr. David Alan Gilbert wrote: > > Or you could just remove the spawning code and use existing sockets; less > > code! > > That would be harder to use reliably in the automated testing that this > feature is target

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread ciprian . barbu
Hi, On 03.04.2017 21:52, Kashyap Chamarthy wrote: On Fri, Mar 31, 2017 at 05:49:52PM +, Ciprian Barbu wrote: Hi, [...] We also use libvirt v1.3.4, which might be a problem, but at least we want to understand if the commit in question introduced an obvious problem or if it's all in the d

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread ciprian . barbu
Hi, On 03.04.2017 22:44, Eric Blake wrote: On 04/03/2017 07:39 AM, Max Reitz wrote: As for just allowing the NBD server write access to the device... To me that appears pretty difficult from an implementation perspective. We assert that nobody can write without having requested write access and

[Qemu-devel] qemu_savevm_state_header()

2017-04-04 Thread ali saeedi
Hi I am new in qemu vm live migration. what does 'qemu_savevm_state_header()' fuction do? thanks

Re: [Qemu-devel] [Bug 1679358] [NEW] ARM: SCTLR fields not being preserved

2017-04-04 Thread Peter Maydell
On 3 April 2017 at 23:17, Yifan wrote: > There are fields in SCTLR that are RAO/SBOP or WI or in the case of the > RR field, accessible only in secure mode. Currently it seems that qemu > just propagates any write to SCTLR to the register and this screwed up > in a bootloader that I am debugging.

Re: [Qemu-devel] [RFC PATCH v1 0/9] MTTCG and record/replay fixes for rc3

2017-04-04 Thread Alex Bennée
Paolo Bonzini writes: > On 03/04/2017 14:45, Alex Bennée wrote: >> cpus: check cpu->running in cpu_get_icount_raw() >> >> I'm not sure the race happens and once outside of cpu->running the >> icount counters should be zero. However it seems a sensible >> precaution. > > Yeah, I think thi

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Alex Bennée
Pavel Dovgalyuk writes: > I guess you are trying to fix the sympthoms of the case > when iothread is trying to access instruction count. In theory the main-loop should be sequenced before or after vCPU events because of the BQL. I'm not sure why this is not currently the case. > Maybe the solu

Re: [Qemu-devel] [PATCH v4 0/4] X86/HMP: Expose x86 model specific registers via human monitor

2017-04-04 Thread Julian Kirsch
ping I kindly request your comments. On 29.03.2017 20:30, Julian Kirsch wrote: > Provide read/write access to x86 model specific registers (MSRs) by means of > two new HMP commands "msr_get" and "msr_set". The rationale behind this > is to improve introspection capabilities for system virtualizat

Re: [Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-04-04 Thread Sameeh Jubran
I have tested the patch on Windows 2012 R2 Reviewed-by: Sameeh Jubran Tested-by: Sameeh Jubran On Thu, Mar 23, 2017 at 2:39 PM, Vinzenz 'evilissimo' Feenstra < vfeen...@redhat.com> wrote: > From: Vinzenz Feenstra > > Adds a new command `guest-get-timezone` reporting the currently > configured

Re: [Qemu-devel] [PATCH v1 2/3] applesmc: consolidate port i/o into single contiguous region

2017-04-04 Thread Alexander Graf
On 04/04/2017 02:04 AM, Gabriel L. Somlo wrote: On Mon, Apr 03, 2017 at 12:27:15PM +0200, Paolo Bonzini wrote: On 03/04/2017 11:32, Alexander Graf wrote: Newer AppleSMC revisions support an error status (read) port in addition to the data and command ports currently supported. Register the fu

Re: [Qemu-devel] [PATCH v3 1/1] slirp: add SOCKS5 support

2017-04-04 Thread Philippe Mathieu-Daudé
Hi Laurent, I waited this feature for long and excited to try it soon :) Please find some comments inline. On 04/03/2017 08:56 PM, Laurent Vivier wrote: When the VM is used behind a firewall, This allows the use of a SOCKS5 proxy server to connect the VM IP stack directly to the Internet. Thi

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 07:37, Pavel Dovgalyuk wrote: >> -icount -= (cpu->icount_decr.u16.low + cpu->icount_extra); >> +/* Take into account what has run */ >> +icount += cpu_get_icount_executed(cpu); >> } >> return icount; > As far, as I understand, this one will return t

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/28/2017 10:47 AM, Peter Maydell wrote: On 28 March 2017 at 14:44, Philippe Mathieu-Daudé wrote: Hi Saurav, you should read the QEMU Coding Style and replace your tabs by 4 spaces. Er, in review comments on v3 we said not to do that... oops I missed Stefan comment in v2, sorry! tha

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/20/2017 02:38 PM, Saurav Sachidanand wrote: Change malloc/strdup/free to g_malloc/g_strdup/g_free in util/envlist.c. Remove NULL checks for pointers returned from g_malloc and g_strdup as they exit in case of failure. Also, update calls to envlist_create to reflect this. Free array and ar

[Qemu-devel] [PATCH 04/10] vga: make display updates thread safe.

2017-04-04 Thread Gerd Hoffmann
The vga code clears the dirty bits *after* reading the framebuffer memory. So if the guest framebuffer updates hits the race window between vga reading the framebuffer and vga clearing the dirty bits vga will miss that update Fix it by using the new memory_region_copy_and_clear_dirty() memory_reg

[Qemu-devel] [PATCH 06/10] cg3: fix up size parameter for memory_region_get_dirty()

2017-04-04 Thread Gerd Hoffmann
From: Mark Cave-Ayland The code was incorrectly calculating the end address rather than the size of the required region. Signed-off-by: Mark Cave-Ayland --- hw/display/cg3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index e05ca92..6

[Qemu-devel] [PATCH 01/10] bitmap: add bitmap_copy_and_clear_atomic

2017-04-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/bitmap.h | 2 ++ util/bitmap.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 63ea2d0..c318da1 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitmap.h @@ -220,6 +22

[Qemu-devel] [PATCH 10/10] [testing] console: remove do_safe_dpy_refresh

2017-04-04 Thread Gerd Hoffmann
Drop the temporary workaround for the broken display updates. TODO: before actually merging this we have to fix all display adapters ... Converted so far: vga, cg3, tcx. Signed-off-by: Gerd Hoffmann --- ui/console.c | 25 + 1 file changed, 1 insertion(+), 24 delet

[Qemu-devel] [PATCH 02/10] memory: add support getting and using a dirty bitmap copy.

2017-04-04 Thread Gerd Hoffmann
This patch adds support for getting and using a local copy of the dirty bitmap. memory_region_copy_and_clear_dirty() will create a copy of the dirty bitmap for the specified range, clear the dirty bitmap and return the copy. The returned bitmap can be a bit larger than requested, the range is exp

[Qemu-devel] [PATCH 03/10] vga: add vga_scanline_invalidated helper

2017-04-04 Thread Gerd Hoffmann
Add vga_scanline_invalidated helper to check whenever a scanline was invalidated. Add a sanity check to fix OOB read access for display heights larger than 2048. Only cirrus uses this, for hardware cursor rendering, so having this work properly for the first 2048 scanlines only shouldn't be a pro

Re: [Qemu-devel] qemu_savevm_state_header()

2017-04-04 Thread Dr. David Alan Gilbert
* ali saeedi (ali.saeed...@gmail.com) wrote: > Hi > I am new in qemu vm live migration. what does 'qemu_savevm_state_header()' > fuction do? It stores the header that goes at the beginning of the migration stream. Dave > thanks -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[Qemu-devel] [PATCH 05/10] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection

2017-04-04 Thread Gerd Hoffmann
From: Mark Cave-Ayland This was an artifact from very early versions of the code from before the memory API and is no longer needed. Signed-off-by: Mark Cave-Ayland --- hw/display/cg3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c

[Qemu-devel] [PATCH 00/10] make display updates thread safe.

2017-04-04 Thread Gerd Hoffmann
Hi, Second round. Helper API should be solid now, after patch discussions and initial testing. API is documented now in the header file. Additionally to vga the sparc display adapters (cg3, tcx) are converted too. Still quite some work until we've got them all converted. Still enough progres

[Qemu-devel] [PATCH 07/10] cg3: make display updates thread safe

2017-04-04 Thread Gerd Hoffmann
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland --- hw/display/cg3.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 6e19da0..9996567 100644 --- a/hw/display/cg3.c +++ b/hw/display/cg3.c

[Qemu-devel] [PATCH 09/10] tcx: make display updates thread safe

2017-04-04 Thread Gerd Hoffmann
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland --- hw/display/tcx.c | 85 +++- 1 file changed, 29 insertions(+), 56 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 15172f0..a890e49 100644 --- a/hw/display/tcx.c +++

Re: [Qemu-devel] [PATCH 02/10] memory: add support getting and using a dirty bitmap copy.

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 12:23, Gerd Hoffmann wrote: > > memory_region_copy_and_clear_dirty() will create a copy of the dirty > bitmap for the specified range, clear the dirty bitmap and return the > copy. The returned bitmap can be a bit larger than requested, the range > is expanded so the code can copy

[Qemu-devel] [PATCH v2 5/7] tmp backend: Add new api to read backend tpm options

2017-04-04 Thread Amarnath Valluri
TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new tpm backend api, tpm_backend_get_tpm_options() to read the backend configured options. Added new method, ge

[Qemu-devel] [PATCH 08/10] tcx: introduce tcx_check_dirty() function

2017-04-04 Thread Gerd Hoffmann
From: Mark Cave-Ayland This is similar to the existing tcx24_check_dirty() function and will aid with the transition to thread-safe updates. Signed-off-by: Mark Cave-Ayland --- hw/display/tcx.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/display/tcx.c b/hw/d

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Alex Bennée
Alex Bennée writes: > Pavel Dovgalyuk writes: > >> I guess you are trying to fix the sympthoms of the case >> when iothread is trying to access instruction count. > > In theory the main-loop should be sequenced before or after vCPU events > because of the BQL. I'm not sure why this is not curre

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 12:46, Alex Bennée wrote: >> In theory the main-loop should be sequenced before or after vCPU events >> because of the BQL. I'm not sure why this is not currently the case. > > It seems cpu_handle_exception doesn't take the BQL until > replay_exception() has done its thing. This is

Re: [Qemu-devel] [PATCH 2/7] tpm-backend: Move thread handling inside TPMBackend

2017-04-04 Thread Marc-André Lureau
Hi On Fri, Mar 31, 2017 at 5:04 PM Amarnath Valluri wrote: > Move thread handling inside TPMBackend, this way backend implementations > need > not to maintain their own thread life cycle, instead they needs to > implement > 'handle_request()' class method that always been called from a thread. >

Re: [Qemu-devel] [PATCH v3 1/1] slirp: add SOCKS5 support

2017-04-04 Thread Laurent Vivier
Le 04/04/2017 à 12:05, Philippe Mathieu-Daudé a écrit : > Hi Laurent, Hi Philippe, > I waited this feature for long and excited to try it soon :) > > Please find some comments inline. > > On 04/03/2017 08:56 PM, Laurent Vivier wrote: >> When the VM is used behind a firewall, This allows >> the

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 10:17, ciprian.barbu wrote: >> >> but we do NOT make any guarantees of supporting >> >> new qemu, old libvirt > > Sounds reasonable enough, I guess we didn't look at it this way. Yes, but usually it's "new qemu, very old libvirt", like several years old. I think this should be tr

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Daniel P. Berrange
On Tue, Apr 04, 2017 at 01:00:08PM +0200, Paolo Bonzini wrote: > > > On 04/04/2017 10:17, ciprian.barbu wrote: > >> > >> but we do NOT make any guarantees of supporting > >> > >> new qemu, old libvirt > > > > Sounds reasonable enough, I guess we didn't look at it this way. > > Yes, but usually

Re: [Qemu-devel] [PATCH 2/7] tpm-backend: Move thread handling inside TPMBackend

2017-04-04 Thread Amarnath Valluri
On 04.04.2017 13:56, Marc-André Lureau wrote: Hi On Fri, Mar 31, 2017 at 5:04 PM Amarnath Valluri mailto:amarnath.vall...@intel.com>> wrote: Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they ne

Re: [Qemu-devel] [PULL 0/6] Misc patches for QEMU 2.9.0-rc3

2017-04-04 Thread Peter Maydell
On 3 April 2017 at 20:44, Paolo Bonzini wrote: > The following changes since commit 95b31d709ba343ad237c3630047ee7438bac4065: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20170331.0' into staging (2017-03-31 > 18:06:13 +0100) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v2] hw/arm/boot: take Linux/arm64 TEXT_OFFSET header field into account

2017-04-04 Thread Peter Maydell
On 20 March 2017 at 11:13, Peter Maydell wrote: > On 13 March 2017 at 14:17, Ard Biesheuvel wrote: >> The arm64 boot protocol stipulates that the kernel must be loaded >> TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET >> could be any 4 KB multiple between 0 and 2 MB, and

Re: [Qemu-devel] [PATCH v3 0/3] hw/arm/exynos: Minor cleanups

2017-04-04 Thread Peter Maydell
On 13 March 2017 at 18:47, Krzysztof Kozlowski wrote: > Hi, > > Minor cleanups, no dependencies. > > Changes since v1 > > 1. Patch 1/3: Address missed Philippe's comments about error reporting >verbosity. > > Changes since v2 > > 1. Patch 1/3: Address Eric's c

Re: [Qemu-devel] [PATCH 0/7] Provide support for the software TPM emulator

2017-04-04 Thread Stefan Berger
On 04/03/2017 01:07 PM, Daniel P. Berrange wrote: On Fri, Mar 31, 2017 at 04:10:09PM +0300, Amarnath Valluri wrote: Briefly, Theses set of patches introduces: - new TPM backend driver to support software TPM emulators(swtpm(1)). - and few supported fixes/enhancements/cleanup to existing tpm

Re: [Qemu-devel] [PATCH v2] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-04-04 Thread Peter Maydell
On 18 March 2017 at 19:25, Krzysztof Kozlowski wrote: > Add emulation for Exynos4210 Pseudo Random Number Generator which could > work on fixed seeds or with seeds provided by True Random Number > Generator block inside the SoC. > > Implement only the fixed seeds part of it in polling mode (no > i

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Kevin Wolf
Am 03.04.2017 um 15:50 hat Peter Krempa geschrieben: > On Mon, Apr 03, 2017 at 15:00:41 +0200, Kevin Wolf wrote: > > If I understand correctly, this is a case of incoming live migration, > > i.e. the virtio-blk device which is blocking the writes to the image > > doesn't really belong to a running

[Qemu-devel] Qemu VM Live Migration Code

2017-04-04 Thread ali saeedi
Hello I am a student who is interested in vm live migration. I want to understand vm live migration code in qemu. so I tried to understand the code that is available in 'migration.c' but it is very difficult for me to understand (I have started from migration_thread function). I also has studied mi

Re: [Qemu-devel] [PATCH RFC 1/2] Increased the size of requester_id field from MemTxAttrs

2017-04-04 Thread Peter Maydell
On 23 March 2017 at 13:36, Diana Craciun wrote: > The PCI requester ID field is 16 bits. The requester_id field > from MemTxAttrs is used for MSIs to specify the device ID for > the platforms where this device ID is needed (e.g virt machine + GICv3 > ITS). However, if more entities that uses MSIs

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Alex Bennée
Paolo Bonzini writes: > On 04/04/2017 12:46, Alex Bennée wrote: >>> In theory the main-loop should be sequenced before or after vCPU events >>> because of the BQL. I'm not sure why this is not currently the case. >> >> It seems cpu_handle_exception doesn't take the BQL until >> replay_exception(

[Qemu-devel] bytes_xfer and xfer_limit

2017-04-04 Thread ali saeedi
Hi What are the variables 'bytes_xfer' and 'xfer_limit' in qemu-file.c ? what does the function 'qemu_file_rate_limit' do? thanks

Re: [Qemu-devel] [PATCH 06/10] cg3: fix up size parameter for memory_region_get_dirty()

2017-04-04 Thread Mark Cave-Ayland
On 04/04/17 11:23, Gerd Hoffmann wrote: > From: Mark Cave-Ayland > > The code was incorrectly calculating the end address rather than the size of > the required region. > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/cg3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 14:31, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 04/04/2017 12:46, Alex Bennée wrote: In theory the main-loop should be sequenced before or after vCPU events because of the BQL. I'm not sure why this is not currently the case. >>> >>> It seems cpu_handle_exce

Re: [Qemu-devel] [PATCH 09/10] tcx: make display updates thread safe

2017-04-04 Thread Mark Cave-Ayland
On 04/04/17 11:23, Gerd Hoffmann wrote: > From: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/tcx.c | 85 > +++- > 1 file changed, 29 insertions(+), 56 deletions(-) > > diff --git a/hw/display/tcx.c b/hw/display/tc

Re: [Qemu-devel] [PATCH 00/10] make display updates thread safe.

2017-04-04 Thread Mark Cave-Ayland
On 04/04/17 11:23, Gerd Hoffmann wrote: > Hi, > > Second round. Helper API should be solid now, after patch discussions > and initial testing. API is documented now in the header file. > Additionally to vga the sparc display adapters (cg3, tcx) are converted > too. Still quite some work unti

Re: [Qemu-devel] [PATCH 3/7] tpm-backend: Initialize and free data members in it's own methods

2017-04-04 Thread Marc-André Lureau
Hi On Fri, Mar 31, 2017 at 5:01 PM Amarnath Valluri wrote: > Initialize and free TPMBackend data members in it's own instance_init() and > instance_finalize methods. > > Took the opportunity to fix object cleanup in tpm_backend_destroy() method > > Signed-off-by: Amarnath Valluri > --- > backe

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-04 Thread Eduardo Habkost
On Tue, Apr 04, 2017 at 09:02:28AM +0200, Alexander Graf wrote: > > > On 04.04.17 08:58, Thomas Huth wrote: > > On 04.04.2017 08:53, Alexander Graf wrote: > > > > > > > > > On 03.04.17 23:00, Eduardo Habkost wrote: > > > > On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: > > > >

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-04 Thread Eduardo Habkost
On Tue, Apr 04, 2017 at 08:53:43AM +0200, Alexander Graf wrote: > > > On 03.04.17 23:00, Eduardo Habkost wrote: > > On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: > > > > > > > > > On 03.04.17 22:10, Eduardo Habkost wrote: > > > > On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-04 Thread Alexander Graf
On 04/04/2017 02:59 PM, Eduardo Habkost wrote: On Tue, Apr 04, 2017 at 09:02:28AM +0200, Alexander Graf wrote: On 04.04.17 08:58, Thomas Huth wrote: On 04.04.2017 08:53, Alexander Graf wrote: On 03.04.17 23:00, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf

Re: [Qemu-devel] [PATCH] slirp: tftp, copy sockaddr_size

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/23/2017 08:31 AM, Marc-André Lureau wrote: ASAN detects an "unknown-crash" when running pxe-test: /ppc64/pxe/spapr-vlan: = ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at pc 0x55e22218830d bp 0x7f

Re: [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag

2017-04-04 Thread Eduardo Habkost
On Tue, Apr 04, 2017 at 09:12:59AM +0200, Alexander Graf wrote: > > > > Am 04.04.2017 um 09:05 schrieb Thomas Huth : > > > >> On 03.04.2017 22:05, Eduardo Habkost wrote: > >>> On Mon, Apr 03, 2017 at 08:42:12PM +0100, Peter Maydell wrote: > On 3 April 2017 at 19:30, Eduardo Habkost wrote:

Re: [Qemu-devel] [PATCH 1/7] tpm-backend: Remove unneeded member variable from backend class

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/31/2017 10:10 AM, Amarnath Valluri wrote: TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-

Re: [Qemu-devel] [PATCH 4/7] tpm-backend: Call interface methods only if backend implements them

2017-04-04 Thread Marc-André Lureau
Hi On Fri, Mar 31, 2017 at 4:57 PM Amarnath Valluri wrote: > This allows backend implementations left optional interface methods. > > Does that make sense to make them optional? instead I would add asserts. Signed-off-by: Amarnath Valluri > --- > backends/tpm.c | 22 ++--

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Kevin Wolf
Am 03.04.2017 um 14:51 hat Peter Krempa geschrieben: > On Mon, Apr 03, 2017 at 10:15:42 +0200, Kevin Wolf wrote: > > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > > On 31.03.2017 18:03, Ciprian Barbu wrote: > > [...] > > > > So this doesn't work: > > > > > > $ x86_64-softmmu/qemu-system-

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Peter Krempa
On Tue, Apr 04, 2017 at 15:19:02 +0200, Kevin Wolf wrote: > Am 03.04.2017 um 14:51 hat Peter Krempa geschrieben: > > On Mon, Apr 03, 2017 at 10:15:42 +0200, Kevin Wolf wrote: > > > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > > > On 31.03.2017 18:03, Ciprian Barbu wrote: [...] > > > Pete

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-04 Thread Kashyap Chamarthy
On Mon, Apr 03, 2017 at 03:38:36PM -0500, Eric Blake wrote: > On 04/03/2017 03:29 PM, John Snow wrote: > > On 03/24/2017 08:34 AM, Kashyap Chamarthy wrote: [...] > >> "[...] There may be potential improvements to the snapshot code to > >> exploit block copy over multiple disks all at one

Re: [Qemu-devel] [RFC PATCH v1 7/9] cpus: move icount preparation out of tcg_exec_cpu

2017-04-04 Thread Alex Bennée
Paolo Bonzini writes: > On 04/04/2017 14:31, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> On 04/04/2017 12:46, Alex Bennée wrote: > In theory the main-loop should be sequenced before or after vCPU events > because of the BQL. I'm not sure why this is not currently the case. >>>

Re: [Qemu-devel] [PATCH v2 5/7] tmp backend: Add new api to read backend tpm options

2017-04-04 Thread Marc-André Lureau
Hi On Tue, Apr 4, 2017 at 12:32 PM Amarnath Valluri wrote: > TPM configuration options are backend implementation details and shall not > be > part of base TPMBackend object, and these shall not be accessed directly > outside > of the class, hence added a new tpm backend api, > tpm_backend_get_t

Re: [Qemu-devel] [PATCH RFC] hw/pvrdma: Proposal of a new pvrdma device

2017-04-04 Thread Marcel Apfelbaum
On 04/03/2017 09:23 AM, Leon Romanovsky wrote: On Fri, Mar 31, 2017 at 06:45:43PM +0300, Marcel Apfelbaum wrote: On 03/30/2017 11:28 PM, Doug Ledford wrote: On 3/30/17 9:13 AM, Leon Romanovsky wrote: On Thu, Mar 30, 2017 at 02:12:21PM +0300, Marcel Apfelbaum wrote: From: Yuval Shaia Hi,

Re: [Qemu-devel] [PATCH v2] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-04-04 Thread Krzysztof Kozlowski
On Tue, Apr 04, 2017 at 01:09:08PM +0100, Peter Maydell wrote: > On 18 March 2017 at 19:25, Krzysztof Kozlowski wrote: > > Add emulation for Exynos4210 Pseudo Random Number Generator which could > > work on fixed seeds or with seeds provided by True Random Number > > Generator block inside the SoC

Re: [Qemu-devel] [PATCH v5 untested] kvm: better MWAIT emulation for guests

2017-04-04 Thread Radim Krčmář
[Cc qemu-devel as we've gone off-topic] 2017-04-04 15:15+0200, Alexander Graf: > On 04/04/2017 03:13 PM, Radim Krčmář wrote: >> 2017-04-04 14:51+0200, Alexander Graf: >> > Please see my patch to force enable CPUID bits ;). >> Nice. MWAIT could also use setting of arbitrary values for its leaf, >>

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Eric Blake
On 04/04/2017 07:16 AM, Kevin Wolf wrote: > > Now the big question is how to implement this. Just not requesting the > write permission initially if runstate_check(RUN_STATE_INMIGRATE) is > easy. But we need to find a place to actually request it later, after > the mirror has completed, and befor

Re: [Qemu-devel] [PATCH 6/7] tpm-passthrough: move reusable code to utils

2017-04-04 Thread Marc-André Lureau
Hi On Fri, Mar 31, 2017 at 4:57 PM Amarnath Valluri wrote: > Signed-off-by: Amarnath Valluri > Nothing really controversial here. You could point out in the commit message that those functions will be used in the new backend perhaps. > --- > hw/tpm/tpm_passthrough.c | 77 > -

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Kevin Wolf
Am 04.04.2017 um 15:27 hat Peter Krempa geschrieben: > On Tue, Apr 04, 2017 at 15:19:02 +0200, Kevin Wolf wrote: > > Am 03.04.2017 um 14:51 hat Peter Krempa geschrieben: > > > On Mon, Apr 03, 2017 at 10:15:42 +0200, Kevin Wolf wrote: > > > > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > > >

Re: [Qemu-devel] [Qemu-block] Making QMP 'block-job-cancel' transactionable

2017-04-04 Thread Eric Blake
On 04/04/2017 08:28 AM, Kashyap Chamarthy wrote: >> Minor or not, it is a useful viewpoint. Either way, as long as the new >> way of getting a transactional non-pivot successful completion is >> something that libvirt can learn via introspection, > > Can you elaborate a little more on the above,

Re: [Qemu-devel] hitting intermittent issue with live migration from qemu-kvm-ev 2.3.0 to qemu-kvm-ev 2.6.0

2017-04-04 Thread Ladi Prosek
On Mon, Apr 3, 2017 at 9:11 PM, Stefan Hajnoczi wrote: > On Fri, Mar 31, 2017 at 02:12:36PM -0600, Chris Friesen wrote: >> I'm running into an issue with live-migrating a guest from a host running >> qemu-kvm-ev 2.3.0-31 to a host running qemu-kvm-ev 2.6.0-27.1. This is a >> libvirt-tunnelled mig

[Qemu-devel] [Bug 1131757] Re: QEMU 1.4.0 fails to boot sparc64 linux image

2017-04-04 Thread Thomas Huth
** Information type changed from Private to Public -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1131757 Title: QEMU 1.4.0 fails to boot sparc64 linux image Status in QEMU: Invalid Bug descript

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 14:16, Kevin Wolf wrote: > Just not requesting the > write permission initially if runstate_check(RUN_STATE_INMIGRATE) is > easy. But we need to find a place to actually request it later, after > the mirror has completed, and before the VM is running. Isn't there already a bdrv_inv

Re: [Qemu-devel] [PATCH v2] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-04-04 Thread Peter Maydell
On 4 April 2017 at 14:44, Krzysztof Kozlowski wrote: > On Tue, Apr 04, 2017 at 01:09:08PM +0100, Peter Maydell wrote: >> On 18 March 2017 at 19:25, Krzysztof Kozlowski wrote: >> > Add emulation for Exynos4210 Pseudo Random Number Generator which could >> > work on fixed seeds or with seeds provid

Re: [Qemu-devel] [Qemu-block] New iotest repros failures on virtio external snapshot with iothread

2017-04-04 Thread Alex Bennée
Stefan Hajnoczi writes: > On Wed, Mar 29, 2017 at 07:01:38PM -0700, Ed Swierk wrote: >> Parts of qemu's block code have changed a lot in recent months but are >> not well exercised by current tests. > > 4. How to automate tests with real Linux guests? This is a complex > topic and probably wha

Re: [Qemu-devel] hitting intermittent issue with live migration from qemu-kvm-ev 2.3.0 to qemu-kvm-ev 2.6.0

2017-04-04 Thread Chris Friesen
On 04/04/2017 07:56 AM, Ladi Prosek wrote: On Mon, Apr 3, 2017 at 9:11 PM, Stefan Hajnoczi wrote: On Fri, Mar 31, 2017 at 02:12:36PM -0600, Chris Friesen wrote: Initially we have a bunch of guests running on compute-2 (which is running qemu-kvm-ev 2.3.0). We then started live-migrating them

Re: [Qemu-devel] [PATCH v2] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-04-04 Thread Krzysztof Kozlowski
On Tue, Apr 04, 2017 at 03:05:09PM +0100, Peter Maydell wrote: > On 4 April 2017 at 14:44, Krzysztof Kozlowski wrote: > > On Tue, Apr 04, 2017 at 01:09:08PM +0100, Peter Maydell wrote: > >> On 18 March 2017 at 19:25, Krzysztof Kozlowski wrote: > >> > Add emulation for Exynos4210 Pseudo Random Num

Re: [Qemu-devel] [PATCH v1 2/3] applesmc: consolidate port i/o into single contiguous region

2017-04-04 Thread Gabriel L. Somlo
On Tue, Apr 04, 2017 at 11:44:29AM +0200, Alexander Graf wrote: > On 04/04/2017 02:04 AM, Gabriel L. Somlo wrote: > > On Mon, Apr 03, 2017 at 12:27:15PM +0200, Paolo Bonzini wrote: > > > > > > On 03/04/2017 11:32, Alexander Graf wrote: > > > > > Newer AppleSMC revisions support an error status (re

Re: [Qemu-devel] [PATCH v2 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands

2017-04-04 Thread John Snow
On 04/04/2017 03:31 AM, Thomas Huth wrote: > On 03.04.2017 21:09, John Snow wrote: >> >> >> On 03/30/2017 03:50 AM, Thomas Huth wrote: >>> When running certain HMP commands (like "device_del") via QMP, we >>> can sometimes get a QMP event in the response first, so that the >>> "g_assert(ret)" sta

Re: [Qemu-devel] [RFC PATCH v1 8/9] cpus: don't credit executed instructions before they have run

2017-04-04 Thread Paolo Bonzini
On 03/04/2017 14:45, Alex Bennée wrote: > Outside of the vCPU thread icount time will only be tracked against > timers_state.qemu_icount. We no longer credit cycles until they have > completed the run. Inside the vCPU thread we adjust for passage of > time by looking at how many have run so far.

Re: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

2017-04-04 Thread Eduardo Habkost
On Tue, Apr 04, 2017 at 03:06:30PM +0200, Alexander Graf wrote: > On 04/04/2017 02:59 PM, Eduardo Habkost wrote: > > On Tue, Apr 04, 2017 at 09:02:28AM +0200, Alexander Graf wrote: > > > > > > On 04.04.17 08:58, Thomas Huth wrote: > > > > On 04.04.2017 08:53, Alexander Graf wrote: > > > > > > > >

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Kevin Wolf
Am 04.04.2017 um 16:04 hat Paolo Bonzini geschrieben: > On 04/04/2017 14:16, Kevin Wolf wrote: > > Just not requesting the > > write permission initially if runstate_check(RUN_STATE_INMIGRATE) is > > easy. But we need to find a place to actually request it later, after > > the mirror has completed,

Re: [Qemu-devel] hitting intermittent issue with live migration from qemu-kvm-ev 2.3.0 to qemu-kvm-ev 2.6.0

2017-04-04 Thread Ladi Prosek
On Tue, Apr 4, 2017 at 4:28 PM, Chris Friesen wrote: > On 04/04/2017 07:56 AM, Ladi Prosek wrote: >> >> On Mon, Apr 3, 2017 at 9:11 PM, Stefan Hajnoczi >> wrote: >>> >>> On Fri, Mar 31, 2017 at 02:12:36PM -0600, Chris Friesen wrote: > > Initially we have a bunch of guests running on compute-

Re: [Qemu-devel] [PATCH v3 01/21] char: remove qemu_chr_be_generic_open

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/16/2017 06:21 AM, Marc-André Lureau wrote: The function simply alias and hides the real event function. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- include/sysemu/char.h | 1 - chardev/char-pty.c| 2 +- chardev/char-socket.

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

2017-04-04 Thread Paolo Bonzini
On 04/04/2017 16:53, Kevin Wolf wrote: >> The big question is how this fits into release management. We have >> another important regression from the op blocker work and only a week >> to go before the last rc. Are we going to delay 2.9 arbitrarily? Are >> we going to shorten the 2.10 developm

[Qemu-devel] [Bug 1679358] Re: ARM: SCTLR fields not being preserved

2017-04-04 Thread Yifan
So there won't be a fix in the future? I'm working with debugging a proprietary bootloader that I do not have the source code for. I wonder if this becomes an issue for any other platform targets. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH v3 02/21] mux: simplfy muxes_realize_done

2017-04-04 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 03/16/2017 06:21 AM, Marc-André Lureau wrote: mux_chr_event() already send events to all backends, rename it, export it, and use it from muxes_realize_done. This should help abstract away mux implementation. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- chard

Re: [Qemu-devel] [PATCH v3 03/21] xen: use a better chardev type check

2017-04-04 Thread Philippe Mathieu-Daudé
On 03/16/2017 06:21 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- xen-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen-common.c b/xen-common.c index fd2c92847e..d46685ef4e 10064

[Qemu-devel] [PULL v1 2/2] io: fix FD socket handling in DNS lookup

2017-04-04 Thread Daniel P. Berrange
The qio_dns_resolver_lookup_sync() method is required to be a no-op for socket kinds that don't require name resolution. Thus the KIND_FD handling should not return an error. Signed-off-by: Daniel P. Berrange --- io/dns-resolver.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff -

[Qemu-devel] [PULL v1 0/2] Merge qio 2017/04/04 v1

2017-04-04 Thread Daniel P. Berrange
The following changes since commit 87cc4c61020addea6a001b94b662596b1896d1b3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-04-04 11:40:55 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-04-04-1 for you t

[Qemu-devel] [PULL v1 1/2] io: fix incoming client socket initialization

2017-04-04 Thread Daniel P. Berrange
From: Wang guang The channel socket was initialized manually, but forgot to set QIO_CHANNEL_FEATURE_SHUTDOWN. Thus, the colo_process_incoming_thread would hang at recvmsg. This patch just call qio_channel_socket_new to get channel, Which set QIO_CHANNEL_FEATURE_SHUTDOWN already. Signed-off-by: W

[Qemu-devel] [Bug 1679358] Re: ARM: SCTLR fields not being preserved

2017-04-04 Thread Peter Maydell
Well, I wouldn't object to a patch to fix it (it would have to correctly handle the various different versions of the CPU architecture we implement, etc), but I'm not planning on writing one today myself. -- You received this bug notification because you are a member of qemu- devel-ml, which is s

[Qemu-devel] PCI regression in 2.9

2017-04-04 Thread Jeff Cody
I ran into this while running qemu iotests, and it looks like it is a regression from 2.8. Here is the reproducer: $ ./x86_64-softmmu/qemu-system-x86_64 -drive if=virtio qemu-system-x86_64: qemu-kvm/memory.c:2078: memory_region_del_subregion: Assertion `subregion->container == mr' failed Aborte

Re: [Qemu-devel] PCI regression in 2.9

2017-04-04 Thread Michael S. Tsirkin
On Tue, Apr 04, 2017 at 11:30:13AM -0400, Jeff Cody wrote: > > I ran into this while running qemu iotests, and it looks like it is a > regression from 2.8. > > Here is the reproducer: > > $ ./x86_64-softmmu/qemu-system-x86_64 -drive if=virtio > qemu-system-x86_64: qemu-kvm/memory.c:2078: memory_

[Qemu-devel] [PULL 1/1] pci: Only unmap bus_master_enabled_region if was added previously

2017-04-04 Thread Michael S. Tsirkin
From: Alexey Kardashevskiy Normally pci_init_bus_master() would be called either via bus->machine_done.notify or directly from do_pci_register_device(). However if a device's realize() failed, pci_init_bus_master() is not called, and do_pci_unregister_device() fails on memory_region_del_subregio

[Qemu-devel] [RFC PATCH for-2.9] block: Ignore guest dev permissions during incoming migration

2017-04-04 Thread Kevin Wolf
Usually guest devices don't like other writers to the same image, so they use blk_set_perm() to prevent this from happening. In the migration phase before the VM is actually running, though, they don't have a problem with writes to the image. On the other hand, storage migration needs to be able to

  1   2   >