[Qemu-devel] Changes since v2 -qga: Add `guest-get-timezone` command

Updated the documentation according to comments of eblake

[Qemu-devel] [PATCH v2] qga: Add `guest-get-timezone` command

From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This c

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

On Wed, Mar 22, 2017 at 11:34:05AM +0100, Andrew Jones wrote: > > You should have CC'ed me, considering this version is addressing my > review comments, but whatever, I usually skim the list so I found it... > > On Wed, Mar 22, 2017 at 05:32:46PM +0800, He Chen wrote: > > Current, QEMU does not p

Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

On Wed, Mar 22, 2017 at 01:13:44PM +0100, Paolo Bonzini wrote: > This reverts commit 07bfa354772f2de67008dc66c201b627acff0106. > The global variable is only read as part of a > > apic_reset_irq_delivered(); > qemu_irq_raise(s->irq); > if (!apic_get_irq_delivered

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On Wed, 2017-03-22 at 16:29 +0100, Laszlo Ersek wrote: > > I'm not. I'm using QMP to change the index dynamically. > >  > Wait, if you are already changing the "bootindex" property > dynamically (do I understand that right?) No, I'm not changing "bootindex" dynamically. I'm changing "bootonceindex

Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

This value is used by mc146818rtc. Therefore it affects the vitrual machine state. I've encountered the cases when replay was broken without migrating of this variable. ⁣Отправлено с помощью BlueMail ​ На 22 Мар 2017 г., 15:13, в 15:13, Paolo Bonzini написал:>This reverts commit 07bfa354772f2d

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

Hi, > > +if (len == 0) { > > +return; > > Correct only if messages without data always have the same meaning as no > message. Gerd? Not a ccid expert, but looking through the code it seems writing a (reply) data block with status and without payload (data = NULL and len = 0) is pe

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

On Thu, Mar 23, 2017 at 03:23:35PM +0800, He Chen wrote: > > > > And maybe should also point out how to set an unreachable node with 255. > > > Thanks for your careful review. Regarding setting unreachable node, > which way is good? Set exact 255 as distance or distance that is larger > than 255

[Qemu-devel] What is the best commit for record-replay?

Hi, I'm trying to use the deterministic record/replay feature, and I would like to know which commit I should take to get it work. In RC0 it seems to be broken. I tried pre-MTTCG commit 2421f381dc, as mentioned here: http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02657.html with this p

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

Hi On Thu, Mar 23, 2017 at 11:44 AM Gerd Hoffmann wrote: > Hi, > > > > +if (len == 0) { > > > +return; > > > > Correct only if messages without data always have the same meaning as no > > message. Gerd? > > Not a ccid expert, but looking through the code it seems writing a > (repl

Re: [Qemu-devel] Minimum RAM size for PC machines?

On Mi, 2017-03-22 at 11:19 +0100, David Hildenbrand wrote: > On 22.03.2017 11:03, Thomas Huth wrote: > > On 22.03.2017 10:08, Markus Armbruster wrote: > > [...] > >> Are we now ready to accept a simple & stupid patch that actually helps > >> users, say letting boards that care declare minimum and m

Re: [Qemu-devel] [PATCH v2 5/8] ppc/pnv: create the ICP and ICS objects under the machine

On 03/23/2017 05:16 AM, David Gibson wrote: > On Thu, Mar 16, 2017 at 03:35:09PM +0100, Cédric Le Goater wrote: >> Like this is done for the sPAPR machine, we use a simple array under >> the PowerNV machine to store the Interrupt Control Presenters (ICP) >> objects, one for each vCPU. This array is

Re: [Qemu-devel] [Xen-devel] [PATCH v4 0/8] xen/9pfs: introduce the Xen 9pfs backend

On Wed, 22 Mar 2017 11:32:22 -0700 (PDT) Stefano Stabellini wrote: > On Wed, 22 Mar 2017, Greg Kurz wrote: > > On Tue, 21 Mar 2017 13:14:02 -0700 (PDT) > > Stefano Stabellini wrote: > > > > > On Tue, 21 Mar 2017, Greg Kurz wrote: > > > > On Mon, 20 Mar 2017 11:18:46 -0700 (PDT) > > > > Stef

Re: [Qemu-devel] [PATCH] MAINTAINERS: update mail address for NVDIMM

On Tue, Mar 21, 2017 at 01:33:57PM +0800, Xiao Guangrong wrote: > From: Xiao Guangrong > > My Intel mail account will be disabled soon, update the mail info > to my private mail > > Signed-off-by: Xiao Guangrong > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Revie

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c

On Mon, Mar 20, 2017 at 05:38:28PM +, Saurav Sachidanand wrote: > Change malloc/strdup/free to g_malloc/g_strdup/g_free in > util/envlist.c. > > Remove NULL checks for pointers returned from g_malloc and g_strdup > as they exit in case of failure. Also, update calls to envlist_create > to refl

Re: [Qemu-devel] [PATCH] MAINTAINERS: update mail address for NVDIMM

On Tue, Mar 21, 2017 at 01:33:57PM +0800, Xiao Guangrong wrote: > My Intel mail account will be disabled soon, update the mail info > to my private mail Is someone else taking over QEMU NVDIMM development work at Intel? Thanks, Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH for-2.10 05/23] numa: move source of default CPUs to NUMA node mapping into boards

On Thu, 23 Mar 2017 11:40:29 +0530 Bharata B Rao wrote: > On Wed, Mar 22, 2017 at 7:02 PM, Igor Mammedov wrote: > > > diff --git a/numa.c b/numa.c > > index e01cb54..b6e71bc 100644 > > --- a/numa.c > > +++ b/numa.c > > @@ -294,9 +294,10 @@ static void validate_numa_cpus(void) > > g_free(se

[Qemu-devel] [PATCH] 9pfs: fix file descriptor leak

In v9fs_create/lcreate dispatch handler, the fidp's fid_type is not checked before used. As these function will set the fid_type, if the guest call more than once them, it will leak the fidp. This can cause some other issue, such as memory leak. Check the fid_type before using them. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands

On Tue, Mar 21, 2017 at 11:39:50AM +0100, Thomas Huth wrote: > When running certain HMP commands (like "device_del") via QMP, we > can sometimes get a QMP event in the response first, so that the > "g_assert(ret)" statement in qtest_hmp() triggers and the test > fails. So ignore such QMP events whe

Re: [Qemu-devel] [PATCH 2/3] libqtest: Add a generic function to run a callback function for every machine

On Tue, Mar 21, 2017 at 11:39:51AM +0100, Thomas Huth wrote: > Some tests need to run single tests for every available machine of the > current QEMU binary. To avoid code duplication, let's extract this > code that deals with 'query-machines' into a separate function. > > Signed-off-by: Thomas Hut

Re: [Qemu-devel] [PATCH 3/3] tests: Add a tester for HMP commands

On Tue, Mar 21, 2017 at 11:39:52AM +0100, Thomas Huth wrote: > HMP commands do not get any automatic testing yet, so on certain > QEMU machines, some HMP commands were causing crashes in the past. > Thus we should test HMP commands in our test suite, too, to avoid > that such problems creep in agai

Re: [Qemu-devel] [PATCH] configure: Fix cut-n-paste errors in OS deprecation warning

On Tue, Mar 21, 2017 at 06:08:49PM +, Peter Maydell wrote: > Fix some cut-and-paste errors in the OS deprecation warning > pointed out by Thomas Huth. > > Reported-by: Thomas Huth > Signed-off-by: Peter Maydell > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) R

Re: [Qemu-devel] [PATCH 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands

On 23.03.2017 09:52, Stefan Hajnoczi wrote: > On Tue, Mar 21, 2017 at 11:39:50AM +0100, Thomas Huth wrote: >> When running certain HMP commands (like "device_del") via QMP, we >> can sometimes get a QMP event in the response first, so that the >> "g_assert(ret)" statement in qtest_hmp() triggers an

[Qemu-devel] [PATCH v6] vfio error recovery: kernel support

From: "Michael S. Tsirkin" 0. What happens now (PCIE AER only) Fatal errors cause a link reset. Non fatal errors don't. All errors stop the QEMU guest eventually, but not immediately, because it's detected and reported asynchronously. Interrupts are forwarded as usual. Correctable

[Qemu-devel] [PATCH v3 1/3] pcie aer: verify if AER functionality is available

For devices which support AER function, verify it can work or not in the system: 1. AER capable device is a PCIe device, it can't be plugged into PCI bus 2. If root port doesn't support AER, then there is no need to expose the AER capability Signed-off-by: Dou Liyang Signed-off-by: Cao jin --

[Qemu-devel] [PATCH v3 3/3] vfio-pci: process non fatal error of AER

Make use of the non fatal error eventfd that the kernel module provide to process the AER non fatal error. Fatal error still goes into the legacy way which results in VM stop. Register the handler, wait for notification. Construct aer message and pass it to root port on notification. Root port wil

[Qemu-devel] [PATCH v3 0/3] vfio-pci: support recovery of AER non fatal error

v3 changelog: 1. Address all comments from MST in patch 3, include remove the flag pci_aer_non_fatal & passive_reset, also the boilerplate code. The corresponding kernel patch is v6. Test: Test with func1 passthroughed while func0 doesn't have user. Cao jin (3): pcie aer: verify if AER fu

[Qemu-devel] [PATCH v3 2/3] vfio pci: new function to init AER capability

Signed-off-by: Dou Liyang Signed-off-by: Cao jin --- hw/vfio/pci.c | 41 - hw/vfio/pci.h | 1 + 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 332f41d..3d0d005 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/p

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

On Wed, Mar 22, 2017 at 02:37:21PM +0100, Paolo Bonzini wrote: > > > On 22/03/2017 03:03, Xu, Anthony wrote: > > When building target x86_64-softmmu, all other architectures' trace.o are > > linked into > > x86_64-softmmu/qemu-system-x86_64, like hw/arm/trace.o, hw/mips/trace.o > > etc., > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: update mail address for NVDIMM

Sure, Haozhong will take the work for the new requirements raised from Intel. 2017-03-23 16:39 GMT+08:00 Stefan Hajnoczi : > On Tue, Mar 21, 2017 at 01:33:57PM +0800, Xiao Guangrong wrote: > > My Intel mail account will be disabled soon, update the mail info > > to my private mail > > Is someone

Re: [Qemu-devel] [PATCH] e1000: disable debug by default

On Wed, Mar 22, 2017 at 11:07:32AM +0800, Jason Wang wrote: > Disable debug output by default, the information were not needed for > release. > > Cc: Peter Maydell > Cc: Stefan Hajnoczi > Cc: Leonid Bloch > Cc: Dmitry Fleytman > Cc: qemu-sta...@nongnu.org > Signed-off-by: Jason Wang > --- >

Re: [Qemu-devel] [PATCH] doc: fix function spelling

On Wed, Mar 22, 2017 at 03:52:41PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/io/channel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On 03/23/17 07:53, Janne Huttunen wrote: > On Wed, 2017-03-22 at 16:29 +0100, Laszlo Ersek wrote: >>> I'm not. I'm using QMP to change the index dynamically. >>> >> Wait, if you are already changing the "bootindex" property >> dynamically (do I understand that right?) > > No, I'm not changing "b

Re: [Qemu-devel] Minimum RAM size for PC machines?

On 23.03.2017 09:19, Gerd Hoffmann wrote: > On Mi, 2017-03-22 at 11:19 +0100, David Hildenbrand wrote: >> On 22.03.2017 11:03, Thomas Huth wrote: >>> On 22.03.2017 10:08, Markus Armbruster wrote: >>> [...] Are we now ready to accept a simple & stupid patch that actually helps users, say l

[Qemu-devel] [PATCH qemu-ga v2] qga: Make qemu-ga compile statically for Windows

Attempting to compile qemu-ga statically as follows for Windows causes the following error: Compilation: ./configure --disable-docs --target-list=x86_64-softmmu \ --cross-prefix=x86_64-w64-mingw32- --static \ --enable-guest-agent-msi --with-vss-sdk=/path/to/VSSSDK72 make -j8 qemu-

Re: [Qemu-devel] rawhide gcc failures [was: Proposal for deprecating unsupported host OSes & architecutures]

Peter Maydell writes: > On 22 March 2017 at 19:07, Eric Blake wrote: >> Tangentially-related: do we officially support bleeding-edge OS builds? >> For example, current rawhide has a new-enough gcc that gives some >> (possibly-useful) new warnings (-Werror=format-truncation) > > Depends what you

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

On Wed, 22 Mar 2017 17:32:46 +0800 He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create a guest that has 4 vNUMA n

[Qemu-devel] [Bug 1675332] [NEW] qemu-system crashes when use sheepdog driver

Public bug reported: Already solved. ** Affects: qemu Importance: Undecided Status: New ** Tags: sheepdog ** Attachment added: "i have fixed." https://bugs.launchpad.net/bugs/1675332/+attachment/4843175/+files/sheepdog.c -- You received this bug notification because you are

[Qemu-devel] [Bug 1675333] [NEW] qemu-system crashes when use sheepdog driver

Public bug reported: Already solved. ** Affects: qemu Importance: Undecided Status: New ** Tags: sheepdog ** Attachment added: "i have fixed." https://bugs.launchpad.net/bugs/1675333/+attachment/4843176/+files/sheepdog.c -- You received this bug notification because you are

[Qemu-devel] [PULL for-2.9 2/2] cryptodev: fix asserting single queue

From: Halil Pasic We already check for queues == 1 in cryptodev_builtin_init and when that is not true raise an error. But before that error is reported the assertion in cryptodev_builtin_cleanup kicks in (because object is being finalized and freed). Let's remove assert(queues == 1) form crypto

[Qemu-devel] [PULL for-2.9 0/2] cryptodev patches 20170323

The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: https://github.com/gongleiarei/qemu.git tags/cryptodev-next-20170323 for you to fetch changes up to

[Qemu-devel] [PULL for-2.9 1/2] cryptodev: setiv only when really need

From: "Longpeng(Mike)" ECB mode cipher doesn't need IV, if we setiv for it then qemu crypto API would report "Expected IV size 0 not **", so we should setiv only when the cipher algos really need. Signed-off-by: Longpeng(Mike) Signed-off-by: Gonglei --- backends/cryptodev-builtin.c | 10 +

Re: [Qemu-devel] help please how to use qemu.

Richard Odell writes: > step by step instructions please https://qemu.weilnetz.de/doc/qemu-doc.html -- Alex Bennée

Re: [Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

On 22 March 2017 at 17:26, Brendan Shanks wrote: > Public bug reported: > > Commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5 ("ui/console: ensure > graphic updates don't race with TCG vCPUs") causes the graphic update to > run on a non-main thread, which Cocoa is not happy with. It crashes > immedi

Re: [Qemu-devel] [PATCH] 9pfs: fix file descriptor leak

On Thu, 23 Mar 2017 01:52:13 -0700 Li Qiang wrote: > In v9fs_create/lcreate dispatch handler, the fidp's fid_type is not checked > before used. As these function will set the fid_type, if the guest call > more than once them, it will leak the fidp. This can cause some other Not leak the fidp but

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

Hi, > oops, there are hard-coded calls with NULL/0. I suppose to fix clang > warning, it would need to check if data != null for memcpy. I'd check for len > 0, and in that if branch we can also assert on data == NULL and thereby check that len and data are consistent. cheers, Gerd

[Qemu-devel] [PULL for-2.9 1/1] target/s390x: Fix broken user mode

From: Stefan Weil Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. Signed-off-by: Stefan Weil Reviewed-by: David Hildenbrand Message-Id: <20170130131517.8092-1...@weilnetz.de> Cc: qemu-sta...@nongnu.org Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL for-2.9 0/1] another s390x bugfix

The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20170323 for you to fetch changes up to

[Qemu-devel] [PATCH] spapr: fix buffer-overflow

Running postcopy-test with ASAN produces the following error: QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/postcopy-test ... = ==23641==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7f155660 at pc 0x55b8e

[Qemu-devel] [PATCH] xen-platform: separate unplugging of NVMe disks

Commit 090fa1c8 "add support for unplugging NVMe disks..." extended the existing disk unplug flag to cover NVMe disks as well as IDE and SCSI. The cecent thread on the xen-devel mailing list [1] have highlighted that this is not desirable behaviour: PV frontends should be able to distinguish NVMe

[Qemu-devel] [PULL 1/1] numa, spapr: align default numa node memory size to 256MB

From: Laurent Vivier Since commit 224245b ("spapr: Add LMB DR connectors"), NUMA node memory size must be aligned to 256MB (SPAPR_MEMORY_BLOCK_SIZE). But when "-numa" option is provided without "mem" parameter, the memory is equally divided between nodes, but 8MB aligned. This can be not valid f

[Qemu-devel] [PULL 0/1] ppc-for-2.9 queue 20170323

The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.9-20170323 for you to fetch changes up to

Re: [Qemu-devel] Guest application reading from pl011 without device driver

On 22 March 2017 at 12:27, Paolo Bonzini wrote: > > > On 22/03/2017 11:28, Jiahuan Zhang wrote: > > > > A function that lets a process sleep until data is available on the > > socket. The solution is to rewrite Windows chardev handling in QEMU > to > > use threads or overlapped I/O.

Re: [Qemu-devel] [PATCH] xen-platform: separate unplugging of NVMe disks

> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 23 March 2017 10:10 > To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; Stefano Stabellini > ; Anthony Perard > Subject: [PATCH] xen-platform: separate unplugging of NVMe disks

[Qemu-devel] [PATCH v2] xen-platform: separate unplugging of NVMe disks

Commit 090fa1c8 "add support for unplugging NVMe disks..." extended the existing disk unplug flag to cover NVMe disks as well as IDE and SCSI. The recent thread on the xen-devel mailing list [1] has highlighted that this is not desirable behaviour: PV frontends should be able to distinguish NVMe d

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On 22/03/2017 21:01, Richard Henderson wrote: >> >> Ah, OK. Thanks for the explanation. May be we should check the size of >> the instruction while decoding the prefixes and error out once we >> exceed the limit. We would not generate any IR code. > > Yes. > > It would not enforce a true limit

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 22/03/2017 14:09, Peter Maydell wrote: > On 22 March 2017 at 12:51, Alex Bennée wrote: >> Peter Maydell writes: >>> ...unfortunately the gcc compile farm mips board (1) is very slow >>> and (2) has very little disk space free in /tmp, which means that >>> it can't pass "make check" because f

Re: [Qemu-devel] Guest application reading from pl011 without device driver

On 23/03/2017 11:12, Jiahuan Zhang wrote: > > It's Windows that doesn't support it (the Windows function name is > WaitForSingleObject). > > > Hi, I have checked the Windows chardev implimentation in QEMU. > I learned from char-win-stdio.c to using thread and WaitForSingleObject > for

[Qemu-devel] [PATCH for-2.9 5/5] rbd: Reject options server.*.{numeric, to, ipv4, ipv6}

We use InetSocketAddress in the QAPI schema. However, the code doesn't use inet_connect_saddr(), but formats "host" and "port" into a configuration string for rados_conf_set(). Thus, members "numeric", "to", "ipv4" and "ipv6" are silently ignored. Not nice. Factor a suitable InetSocketAddressBa

[Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

BlockdevOptionsRbd member auth-supported is a list of struct RbdAuthMethod, whose only member is enum RbdAuthSupport. There is no reason for wrapping the enum in a struct. Delete the wrapper, and rename the enum. Signed-off-by: Markus Armbruster --- block/rbd.c | 2 +- qapi/block-cor

[Qemu-devel] [PATCH for-2.9 1/5] rbd: Clean up runtime_opts

runtime_opts is used for three different purposes: * qemu_rbd_open() uses it to accept options it recognizes, such as "pool" and "image". Other .bdrv_open() methods do it similarly. * qemu_rbd_open() accepts additional list-valued options auth-supported and server, with the help of qemu_rbd_

[Qemu-devel] [PATCH for-2.9 0/5] rbd: Clean up API and code

These API cleanups need to go into 2.9. Markus Armbruster (5): rbd: Clean up runtime_opts rbd: Clean up qemu_rbd_create()'s detour through QemuOpts rbd: Rewrite the code to extract list-valued options rbd: Peel off redundant RbdAuthMethod wrapper struct rbd: Reject options server.*.{nume

[Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

We have two list-values options: * "server" is a list of InetSocketAddress. We use members "host" and "port", and silently ignore the rest. * "auth-supported" is a list of RbdAuthMethod. We use its only member "auth". Since qemu_rbd_open() takes options as a flattened QDict, options has ke

[Qemu-devel] [PATCH for-2.9 2/5] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

The conversion from QDict to QemuOpts is pointless. Simply get the stuff straight from the QDict. Signed-off-by: Markus Armbruster --- block/rbd.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 6562fbd..59c822a 100644 --

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 23 March 2017 at 10:33, Paolo Bonzini wrote: > I own a MIPS Creator ci20 board (donated by Imagination Technologies). > I cannot give it a public IP address, but I can try and use it to do > builds every now and then. I think our best bet is probably to fix our test suite's overreliance on /tm

Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches

On 22 March 2017 at 12:54, Stefan Hajnoczi wrote: > The following changes since commit 940a8ce075e3408742a4edcabfd6c2a15e2539eb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-03-20 16:34:26 +) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

Peter Maydell writes: > On 22 March 2017 at 17:26, Brendan Shanks wrote: >> Public bug reported: >> >> Commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5 ("ui/console: ensure >> graphic updates don't race with TCG vCPUs") causes the graphic update to >> run on a non-main thread, which Cocoa is not

Re: [Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

On 23 March 2017 at 11:13, Alex Bennée wrote: > Technically its not a random thread its the vCPU context (which ensures > the vCPU isn't updating while the display is being updated). But I guess > the Cocoa is limited to not being able to update from an arbitrary > thread? Yes. It's very common f

[Qemu-devel] [PATCH for-2.9] sockets: Fix socket_address_to_string() hostname truncation

We first snprintf() to a fixed buffer, then g_strdup() the result *boggle*. Worse, the size of the fixed buffer INET6_ADDRSTRLEN + 5 + 4 is bogus: the 4 correctly accounts for '[', ']', ':' and '\0', but INET6_ADDRSTRLEN is not a suitable limit for inet->host, and 5 is not one for inet->port! The

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: > Add a new debug attribute, the attribute should be set when guest memory > accesses are performed for debug purposes. > The attribute will be used in SEV guest, where we need to distinguish normal > vs debug access to guest memory. In

Re: [Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

Peter Maydell writes: > On 23 March 2017 at 11:13, Alex Bennée wrote: >> Technically its not a random thread its the vCPU context (which ensures >> the vCPU isn't updating while the display is being updated). But I guess >> the Cocoa is limited to not being able to update from an arbitrary >> t

[Qemu-devel] [PATCH] slirp: tftp, copy sockaddr_size

ASAN detects an "unknown-crash" when running pxe-test: /ppc64/pxe/spapr-vlan: = ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at pc 0x55e22218830d bp 0x7f6dcd2989e0 sp 0x7f6dcd2989d0 READ of size 128 at 0x

Re: [Qemu-devel] [RFC PATCH v4 06/20] core: add new security-policy object

On Wed, Mar 08, 2017 at 03:52:09PM -0500, Brijesh Singh wrote: > The object can be used to define global security policy for the guest. "security-policy" is very vague. Lots of parts of QEMU have security related options (e.g. VNC display, networking, etc). I'd prefer a -machine memory-encryptio

Re: [Qemu-devel] [PULL 0/4] virtio, pc: fixes

On 22 March 2017 at 16:01, Michael S. Tsirkin wrote: > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qe

Re: [Qemu-devel] [PATCH for-2.9] sockets: Fix socket_address_to_string() hostname truncation

On 23/03/2017 12:23, Markus Armbruster wrote: > We first snprintf() to a fixed buffer, then g_strdup() the result > *boggle*. > > Worse, the size of the fixed buffer INET6_ADDRSTRLEN + 5 + 4 is bogus: > the 4 correctly accounts for '[', ']', ':' and '\0', but > INET6_ADDRSTRLEN is not a suitable

Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

On 23/03/2017 08:34, Pavel Dovgalyuk wrote: > This value is used by mc146818rtc. > Therefore it affects the vitrual machine state. It is used indeed, but it should not be used across virtual machine migration or savevm. The value doesn't matter as soon as apic_get_irq_delivered is called, becau

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

On Fri, 17 Mar 2017, Dong Jia Shi wrote: > For future code reuse purpose, this decouples the cio code with > the ccw device specific parts from ccw_device_cancel_halt_clear, > and makes a new common I/O interface named cio_cancel_halt_clear. > > Reviewed-by: Pierre Morel > Signed-off-by: Dong Jia

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

On Fri, 17 Mar 2017, Dong Jia Shi wrote: > Export the common I/O interfaces those are needed by an I/O > subchannel driver to actually talk to the subchannel. > > Reviewed-by: Pierre Morel > Signed-off-by: Dong Jia Shi > Cc: Sebastian Ott > Cc: Peter Oberparleiter > --- Acked-by: Sebastian Ot

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

On 3/21/2017 1:06 PM, Greg Kurz wrote: On Tue, 21 Mar 2017 10:44:32 +0100 Pradeep Jagadeesh wrote: Hi Eric, Thanks for having a look at the patch. My answers are inline. On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: This patchset enables qmp interfaces for the 9pfs devices (fsdev).This

[Qemu-devel] [PATCH 1/2 v1] fsdev: QMP interface for throttling

This patchset enables qmp interfaces for the 9pfs devices (fsdev). This provides two interfaces one for querying all the 9pfs devices info. The second one to set the IO limits for the required 9pfs device. Signed-off-by: Pradeep Jagadeesh --- Makefile| 5 ++- fsdev/qemu-fs

[Qemu-devel] [PATCH 2/2 v1] throttle: factor out the redundant code

This patchset removes the throttle redundant code that was present in block and fsdev files. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 106 --- fsdev/Makefile.objs | 1 + fsdev/qemu-fsdev-throttle.c | 94 +---

Re: [Qemu-devel] [PULL for-2.9 0/4] Block patches

On 22 March 2017 at 17:30, Jeff Cody wrote: > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) > > are available in the git repository at: > > https://github.com/codyprime/qemu-kvm-jtc.git tags/bl

Re: [Qemu-devel] [PATCH v2] qga: Add `guest-get-timezone` command

I have tested the patch on Windows 2012 R2 and it seems to be working good. Please see some comments inline. On 3/22/2017 7:16 PM, Vinzenz 'evilissimo' Feenstra wrote: From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. Th

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

Gerd Hoffmann writes: > Hi, > >> oops, there are hard-coded calls with NULL/0. I suppose to fix clang >> warning, it would need to check if data != null for memcpy. > > I'd check for len > 0, and in that if branch we can also assert on data > == NULL and thereby check that len and data are con

[Qemu-devel] [PATCH for-2.9] disas/microblaze: Remove unused REG_PC define

The REG_PC define in disas/microblaze.c clashes with a define in the Linux SPARC system headers: /home/pm215/qemu/disas/microblaze.c:162:0: error: "REG_PC" redefined [-Werror] #define REG_PC 32 /* PC */ In file included from /usr/include/signal.h:326:0, from /home/pm215/qemu/in

Re: [Qemu-devel] [PATCH v2] qga: Add `guest-get-timezone` command

Hi On Thu, Mar 23, 2017 at 4:41 PM sameeh jubran wrote: > I have tested the patch on Windows 2012 R2 and it seems to be working good. > > Please see some comments inline. > > > On 3/22/2017 7:16 PM, Vinzenz 'evilissimo' Feenstra wrote: > > From: Vinzenz Feenstra > > > > Adds a new command `gues

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

On Mon, 20 Mar 2017 11:19:05 -0700 Stefano Stabellini wrote: > Do not use the ring.h header installed on the system. Instead, import > the header into the QEMU codebase. This avoids problems when QEMU is > built against a Xen version too old to provide all the ring macros. > > Signed-off-by: Ste

Re: [Qemu-devel] [PATCH for-2.10 15/23] QMP: include CpuInstanceProperties into query_cpus output output

On 03/22/2017 08:32 AM, Igor Mammedov wrote: > if board supports CpuInstanceProperties, report them for > each CPU thread listed. Main motivation for this is to > provide these properties introspection via QMP interface > for using in test cases to verify numa node to cpu mapping, > which includes

Re: [Qemu-devel] [PATCH] slirp: tftp, copy sockaddr_size

Marc-André Lureau, on jeu. 23 mars 2017 15:31:56 +0400, wrote: > ASAN detects an "unknown-crash" when running pxe-test: > > /ppc64/pxe/spapr-vlan: > = > ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at > p

Re: [Qemu-devel] [PATCH for-2.10 22/23] numa: add '-numa cpu, ...' option for property based node mapping

On 03/22/2017 08:32 AM, Igor Mammedov wrote: > legacy cpu to node mapping is using cpu index values to map > VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' > option. However cpu index is internal concept and QEMU users > have to guess /reimplement qemu's logic/ to map it to > a concr

Re: [Qemu-devel] [PATCH v2] qga: Add `guest-get-timezone` command

> On Mar 23, 2017, at 1:51 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Mar 23, 2017 at 4:41 PM sameeh jubran > wrote: > I have tested the patch on Windows 2012 R2 and it seems to be working good. > > Please see some comments inline. > > > On 3/22/2017 7:16 P

[Qemu-devel] [RFC 1/1] qcow2: add ZSTD compression feature

ZSDT compression algorithm consumes 3-5 times less CPU power with a comparable comression ratio with zlib. It would be wise to use it for data compression f.e. for backups. The patch adds incompatible ZSDT feature into QCOW2 header that indicates that compressed clusters must be decoded using ZSTD

Re: [Qemu-devel] [PULL v3 for-2.9 00/17] QAPI patches for 2017-03-22

On 22 March 2017 at 18:36, Markus Armbruster wrote: > v3 (third time's a charm) > * Actually squash it into 16/17, not 17/17 > v2: > * Leak fix squashed into 16/17 > > The following changes since commit 940a8ce075e3408742a4edcabfd6c2a15e2539eb: > > Merge remote-tracking branch 'remotes/bonzini/t

Re: [Qemu-devel] (no subject)

On 03/16/2017 09:50 AM, Vinzenz 'evilissimo' Feenstra wrote: > In this version: When sending a v2, it's best to send it as a new top-level thread instead of burying it in-reply-to an older thread. Also, don't forget the subject line on the header message. > > - Changed the use of strdup to g_str

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

On 03/23/2017 02:23 AM, He Chen wrote: >>> -numa dist,src=1,dst=0,val=21 \ >> >> And maybe should also point out how to set an unreachable node with 255. >> > Thanks for your careful review. Regarding setting unreachable node, > which way is good? Set exact 255 as distance or distance that is lar

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

On 23/03/17 14:00, Greg Kurz wrote: > On Mon, 20 Mar 2017 11:19:05 -0700 > Stefano Stabellini wrote: > >> Do not use the ring.h header installed on the system. Instead, import >> the header into the QEMU codebase. This avoids problems when QEMU is >> built against a Xen version too old to provide

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

On Do, 2017-03-23 at 13:41 +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> oops, there are hard-coded calls with NULL/0. I suppose to fix clang > >> warning, it would need to check if data != null for memcpy. > > > > I'd check for len > 0, and in that if branch we ca

Re: [Qemu-devel] [PATCH] slirp: tftp, copy sockaddr_size

On 23.03.2017 12:31, Marc-André Lureau wrote: > ASAN detects an "unknown-crash" when running pxe-test: > > /ppc64/pxe/spapr-vlan: > = > ==7143==ERROR: AddressSanitizer: unknown-crash on address 0x7f6dcd298d30 at > pc 0x55e22218830d

Re: [Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

Gerd Hoffmann writes: > On Do, 2017-03-23 at 13:41 +0100, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >> > Hi, >> > >> >> oops, there are hard-coded calls with NULL/0. I suppose to fix clang >> >> warning, it would need to check if data != null for memcpy. >> > >> > I'd check for le

[Qemu-devel] [PATCH v3] qga: Add `guest-get-timezone` command

From: Vinzenz Feenstra Changes since v2: - Changed offset from reporting minutes to reporting seconds like it is returned from the used glib API - Applied more checks and better error handling in the implementation Vinzenz Feenstra (1): qga: Add `guest-get-timezone` command qga/commands.c

  1   2   3   >