[Qemu-devel] [PATCH 1/2] ich9: add tco reset

2017-03-17 Thread Gerd Hoffmann
Without that the nmi watchdog fires after reboot and the linux kernel is confused where the nmi comes from: Uhhuh. NMI received for unknown reason 20 on CPU 0. Do you have a strange power saving mode enabled? Dazed and confused, but trying to continue Signed-off-by: Gerd Hoffmann --- h

[Qemu-devel] [PATCH] cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16

2017-03-17 Thread Gerd Hoffmann
The switch from pointers to addresses (commit 026aeffcb4752054830ba203020ed6eb05bcaba8 and ffaf857778286ca54e3804432a2369a279e73aa7) added a off-by-one bug to 16bit backward blits. Fix. Reported-by: 李强 Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga_rop.h | 2 +- 1 file changed, 1 inser

Re: [Qemu-devel] [PATCH 1/2] ich9: add tco reset

2017-03-17 Thread Gerd Hoffmann
On Fr, 2017-03-17 at 08:09 +0100, Gerd Hoffmann wrote: > Without that the nmi watchdog fires after reboot and the > linux kernel is confused where the nmi comes from: > >Uhhuh. NMI received for unknown reason 20 on CPU 0. >Do you have a strange power saving mode enabled? >Dazed and con

[Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Gerd Hoffmann
Unfortunaly switching to getPlatformDisplayEXT isn't as easy as implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the longish comment for the complete story. Cc: Frediano Ziglio Suggested-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 53 +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 48/77] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge

2017-03-17 Thread Cédric Le Goater
Ben, Quick question, > +/* This is called whenever the PHB LSI, MSI source ID register or > + * the PBCQ irq filters are written. > + */ > +void pnv_phb3_remap_irqs(PnvPhb3State *phb) > +{ > +uint32_t local, global, count, mask, comp; > +uint64_t baren; > + > +/* First check if we are

Re: [Qemu-devel] [PATCH for-2.10 6/8] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2017-03-17 Thread Cédric Le Goater
On 03/17/2017 03:00 AM, David Gibson wrote: > On Thu, Mar 16, 2017 at 02:52:17PM +0100, Cédric Le Goater wrote: >> On 03/15/2017 07:16 AM, David Gibson wrote: >>> On Wed, Mar 08, 2017 at 11:52:49AM +0100, Cédric Le Goater wrote: From: Benjamin Herrenschmidt The PSI (Processor Servic

Re: [Qemu-devel] [PATCH] cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16

2017-03-17 Thread 李强
> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+liqiang6-s=360...@nongnu.org] On Behalf Of > Gerd Hoffmann > Sent: Friday, March 17, 2017 3:22 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [PATCH] cirrus: fix off-by-one in > cirrus_bitblt_

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Marc-André Lureau
On Fri, Mar 17, 2017 at 12:12 PM Gerd Hoffmann wrote: > Unfortunaly switching to getPlatformDisplayEXT isn't as easy as > implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the > longish comment for the complete story. > > Cc: Frediano Ziglio > Suggested-by: Hans de Goede > Signed-of

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Mar 16, 2017 at 03:55:13PM +, Peter Maydell wrote: >> On 16 March 2017 at 15:46, Daniel P. Berrange wrote: >> > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: >> >> OK, here's a concrete proposal for deprecating/dropping out of >> >> dat

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Thomas Huth
On 16.03.2017 17:52, Paolo Bonzini wrote: > > > On 16/03/2017 16:55, Peter Maydell wrote: >>> IOW, I think there is a reasonable 3 tier set here >>> >>> 1. Stuff we actively test builds & thus guarantee will work for >>> any QEMU release going forward. >>> >>> 2. Stuff we don't actively tes

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > For future code reuse purpose, this decouples the cio code with > the ccw device specific parts from ccw_device_cancel_halt_clear, > and makes a new common I/O interface named cio_cancel_halt_clear. What would the user of cio_cancel_halt_clear be? Sebast

[Qemu-devel] [PATCH] vnc: fix a qio-channel leak

2017-03-17 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc.c b/ui/vnc.c index 8bfb1e0685..6e93b883b5 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd, qio_channel_s

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > Export the common I/O interfaces those are needed by an I/O > subchannel driver to actually talk to the subchannel. Which I/O subchannel driver are you talking about? I know of just one and it can't be build as a module. Sebastian

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

2017-03-17 Thread Alberto Garcia
On Fri 17 Mar 2017 02:56:30 AM CET, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block.c b/block.c > index cb57370..6621167 100644 > --- a/block.c > +++ b/block.c > @@ -2025,6 +2025,7 @@ int bdrv_open_backing_file(BlockDriver

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-17 Thread Dong Jia Shi
* Sebastian Ott [2017-03-17 10:26:51 +0100]: > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > For future code reuse purpose, this decouples the cio code with > > the ccw device specific parts from ccw_device_cancel_halt_clear, > > and makes a new common I/O interface named cio_cancel_halt_clear. >

Re: [Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-17 Thread Stefan Hajnoczi
On Thu, Mar 16, 2017 at 05:36:40PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process forks

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

2017-03-17 Thread Dong Jia Shi
* Sebastian Ott [2017-03-17 10:29:31 +0100]: > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > Export the common I/O interfaces those are needed by an I/O > > subchannel driver to actually talk to the subchannel. > > Which I/O subchannel driver are you talking about? I know of just one > and it can

Re: [Qemu-devel] [PATCH] qemu-img: show help for invalid global options

2017-03-17 Thread Stefan Hajnoczi
On Thu, Mar 16, 2017 at 03:07:29AM +0100, Max Reitz wrote: > On 13.03.2017 06:11, Stefan Hajnoczi wrote: > > The qemu-img sub-command executes regardless of invalid global options: > > > > $ qemu-img --foo info test.img > > qemu-img: unrecognized option '--foo' > > image: test.img > > ...

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-17 Thread Sebastian Ott
On Fri, 17 Mar 2017, Dong Jia Shi wrote: > * Sebastian Ott [2017-03-17 10:26:51 +0100]: > > > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > > For future code reuse purpose, this decouples the cio code with > > > the ccw device specific parts from ccw_device_cancel_halt_clear, > > > and makes a new

Re: [Qemu-devel] [PATCH 23/31] ram: Move migration_bitmap_rcu into RAMState

2017-03-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Once there, rename the type to be shorter. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 79 > ++--- > 1 file changed, 42 insertions(+), 37 deletions(-) > > diff --git a/migration/ra

Re: [Qemu-devel] [PATCH 25/31] ram: Use the RAMState bytes_transferred parameter

2017-03-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Somewhere it was passed by reference, just use it from RAMState. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 77 > - > 1 file changed, 27

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Peter Maydell
On 16 March 2017 at 18:59, Dr. David Alan Gilbert wrote: > I build-test the FreeBSD when I do migration pulls; given it's > just a VM it's not too hard; my main reason is that I use it as > a proxy that gives it a good chance to get past your MacOS build. Yeah, I have no in principle objection to

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Daniel P. Berrange
On Fri, Mar 17, 2017 at 10:09:51AM +0100, Thomas Huth wrote: > On 16.03.2017 17:52, Paolo Bonzini wrote: > > > > > > On 16/03/2017 16:55, Peter Maydell wrote: > >>> IOW, I think there is a reasonable 3 tier set here > >>> > >>> 1. Stuff we actively test builds & thus guarantee will work for > >>

Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak

2017-03-17 Thread Daniel P. Berrange
On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote: > Spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > ui/vnc.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange > diff --git a/ui/vnc.c b/ui/vnc.c > index 8bfb1e0685..6e93b883b5 100644 > --- a/

Re: [Qemu-devel] [PATCH 27/31] ram: Move last_req_rb to RAMState

2017-03-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It was on MigrationState when it is only used inside ram.c for > postcopy. Problem is that we need to access it without being able to > pass it RAMState directly. > > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 2 -- > migr

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 10:12, Daniel P. Berrange wrote: > In the mail thread two months back Sean Bruno did suggest he might like > to just start over with bsd-user: > > https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00171.html > > So perhaps someone should just ping him to see if he obje

[Qemu-devel] [Bug 1672365] Re: nested 9pfs read fail

2017-03-17 Thread Leo Gaspard
Hmm, actually it looks like a kernel in kernel panic always takes 100% CPU (just got another unrelated one), so I guess it's not necessarily a qemu bug but can arise from anywhere in the stack. I'm marking the bug as invalid as a consequence. ** Changed in: qemu Status: New => Invalid --

Re: [Qemu-devel] [PATCH 29/31] ram: Remove dirty_bytes_rate

2017-03-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It can be recalculated from dirty_pages_rate. > > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 - > migration/migration.c | 5 ++--- > migration/ram.c | 1 - > 3 files changed, 2 insertions(+), 5 delet

Re: [Qemu-devel] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

2017-03-17 Thread Kevin Wolf
Am 17.03.2017 um 02:56 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Thomas Huth
On 17.03.2017 11:15, Peter Maydell wrote: > On 17 March 2017 at 10:12, Daniel P. Berrange wrote: >> In the mail thread two months back Sean Bruno did suggest he might like >> to just start over with bsd-user: >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00171.html >> >> So perh

[Qemu-devel] [PATCH for-2.9] configure: Warn that the support for ia64 is going to be removed

2017-03-17 Thread Thomas Huth
Access to an ia64 machine is hard to get these days, and we lack a machine for continuous integration testing, so it is very likely that we remove support for the ia64 TCG backend soon. Signed-off-by: Thomas Huth --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/

[Qemu-devel] [PATCH] checkpatch: allow longer lines for logging functions

2017-03-17 Thread Greg Kurz
Commit f1e155bbf863a removed a bunch of stuff that really don't make sense outside the linux kernel. An exception though is logging functions: it is convenient to be able to grep error messages in the code. For this to work, error strings mustn't be broken down on multiple lines, and therefore are

[Qemu-devel] [PATCH v2] 9pfs: don't try to flush self and avoid QEMU hang on reset

2017-03-17 Thread Greg Kurz
According to the 9P spec [*], when a client wants to cancel a pending I/O request identified by a given tag (uint16), it must send a Tflush message and wait for the server to respond with a Rflush message before reusing this tag for another I/O. The server may still send a completion message for th

Re: [Qemu-devel] [PATCH 30/31] ram: move dirty_pages_rate to RAMState

2017-03-17 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Treat it like the rest of ram stats counters. Export its value the > same way. As an added bonus, no more MigrationState used in > migration_bitmap_sync(); > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/mig

[Qemu-devel] [PATCH v2 0/3] qemu-img: improve qemu-img getopt error messages

2017-03-17 Thread Stefan Hajnoczi
v2: * Print short help to avoid obscuring error messages [Max] This series improves getopt error messages. Unrecognized global options were skipped rather than causing qemu-img to exit as expected. Also avoid printing the full help text because it obscures the actual error message. Stefan Hajn

[Qemu-devel] [PATCH v2 2/3] qemu-img: fix switch indentation in img_amend()

2017-03-17 Thread Stefan Hajnoczi
QEMU coding style indents 'case' to the same level as the 'switch' statement: switch (foo) { case 1: Fix this coding style violation so checkpatch.pl doesn't complain about the next patch. Signed-off-by: Stefan Hajnoczi --- qemu-img.c | 82 +++---

[Qemu-devel] [PATCH v2 1/3] qemu-img: show help for invalid global options

2017-03-17 Thread Stefan Hajnoczi
The qemu-img sub-command executes regardless of invalid global options: $ qemu-img --foo info test.img qemu-img: unrecognized option '--foo' image: test.img ... The unrecognized option warning may be missed by the user. This can hide incorrect command-lines in scripts and confuse users.

[Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Peter Lieven
Hi, I tried to debug why qemu-img convert with a VMDK source laying on a tmpfs is horrible slow. For some reason a lseek on a tmpfs is slow. Strictly speaking the lseek in find_allocation in file-posix.c is slow. When qemu-img convert iterates over all sectors of a VMDK file to check their

[Qemu-devel] [PATCH v2 3/3] qemu-img: print short help on getopt failure

2017-03-17 Thread Stefan Hajnoczi
Printing the full help output obscures the error message for an invalid command-line option or missing argument. Before this patch: $ ./qemu-img --foo ...pages of output... After this patch: $ ./qemu-img --foo qemu-img: unrecognized option '--foo' Try 'qemu-img --help' for more inform

Re: [Qemu-devel] [PATCH] checkpatch: allow longer lines for logging functions

2017-03-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 148974701986.29545.5414999102981738774.stgit@bahia Subject: [Qemu-devel] [PATCH] checkpatch: allow longer lines for logging functions Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 10:30, Thomas Huth wrote: > On 17.03.2017 11:15, Peter Maydell wrote: >> On 17 March 2017 at 10:12, Daniel P. Berrange wrote: >>> In the mail thread two months back Sean Bruno did suggest he might like >>> to just start over with bsd-user: >>> >>> https://lists.gnu.org/archi

Re: [Qemu-devel] [PATCH for-2.9] configure: Warn that the support for ia64 is going to be removed

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 10:34, Thomas Huth wrote: > Access to an ia64 machine is hard to get these days, and we lack a > machine for continuous integration testing, so it is very likely > that we remove support for the ia64 TCG backend soon. > > Signed-off-by: Thomas Huth > --- > configure | 5 +

Re: [Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 10:41, Stefan Hajnoczi wrote: >> Luckily, qemu-nbd also got socket activation code, and its copy does >> support LISTEN_PID. Some extra fixups are needed to ensure that the >> code can be used for both, but that's what this patch does. The >> main change is to replace get_listen_f

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 11:45, Peter Lieven wrote: > Hi, > > > I tried to debug why qemu-img convert with a VMDK source laying on a tmpfs is > horrible slow. > > For some reason a lseek on a tmpfs is slow. Strictly speaking the lseek in > find_allocation in file-posix.c > > is slow. > > > When qemu

[Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
We plan to drop support in a future QEMU release for host OSes and host architectures for which we have no test machine where we can build and run tests. For the 2.9 release, make configure print a warning if it is run on such a host, so that the user has some warning of the plans and can volunteer

Re: [Qemu-devel] [PATCH v3 1/9] xen: do not build backends for targets that do not support xen

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:50 -0700 Stefano Stabellini wrote: > Change Makefile.objs to use CONFIG_XEN instead of CONFIG_XEN_BACKEND, so > that the Xen backends are only built for targets that support Xen. > > Set CONFIG_XEN in the toplevel Makefile to ensure that files that are > built only once

Re: [Qemu-devel] [PATCH v3 1/9] xen: do not build backends for targets that do not support xen

2017-03-17 Thread Paolo Bonzini
On 16/03/2017 21:01, Stefano Stabellini wrote: > Change Makefile.objs to use CONFIG_XEN instead of CONFIG_XEN_BACKEND, so > that the Xen backends are only built for targets that support Xen. > > Set CONFIG_XEN in the toplevel Makefile to ensure that files that are > built only once pick up Xen s

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Peter Lieven
Am 17.03.2017 um 11:59 schrieb Paolo Bonzini: > > On 17/03/2017 11:45, Peter Lieven wrote: >> Hi, >> >> >> I tried to debug why qemu-img convert with a VMDK source laying on a tmpfs >> is horrible slow. >> >> For some reason a lseek on a tmpfs is slow. Strictly speaking the lseek in >> find_alloc

Re: [Qemu-devel] [PATCH v3 2/9] xen: import ring.h from xen

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:51 -0700 Stefano Stabellini wrote: > Do not use the ring.h header installed on the system. Instead, import > the header into the QEMU codebase. This avoids problems when QEMU is > built against a Xen version too old to provide all the ring macros. > > Signed-off-by: Ste

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 12:11, Peter Lieven wrote: >>> like VMDK or QCOW2 shouldn't we trust the information from the l2 tables in >>> the VMDK or QCOW2? >> It provides additional information, for example it works better with >> prealloc=metadata. > Okay, understood. Can you imagine of a away to condition

Re: [Qemu-devel] [PATCH v3 3/9] 9p: introduce a type for the 9p header

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:52 -0700 Stefano Stabellini wrote: > Use the new type in virtio-9p-device. > > Signed-off-by: Stefano Stabellini > CC: anthony.per...@citrix.com > CC: jgr...@suse.com > CC: Aneesh Kumar K.V > CC: Greg Kurz > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.h

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Peter Lieven
Am 17.03.2017 um 12:16 schrieb Paolo Bonzini: > > On 17/03/2017 12:11, Peter Lieven wrote: like VMDK or QCOW2 shouldn't we trust the information from the l2 tables in the VMDK or QCOW2? >>> It provides additional information, for example it works better with >>> prealloc=metadata. >> Oka

Re: [Qemu-devel] callout to *file in bdrv_co_get_block_status

2017-03-17 Thread Fam Zheng
On Fri, 03/17 12:16, Paolo Bonzini wrote: > > > On 17/03/2017 12:11, Peter Lieven wrote: > >>> like VMDK or QCOW2 shouldn't we trust the information from the l2 tables > >>> in the VMDK or QCOW2? > >> It provides additional information, for example it works better with > >> prealloc=metadata. >

Re: [Qemu-devel] [PATCH] checkpatch: allow longer lines for logging functions

2017-03-17 Thread Greg Kurz
On Fri, 17 Mar 2017 03:45:56 -0700 (PDT) no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 148974701986.29545.5414999102981738774.stgit@bahia > Subject: [Qemu-devel] [PATCH] checkpatch: allow longe

[Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Fam Zheng
For one thing we shouldn't continue if an error happened, for the other two steps failing can cause an abort() in error_setg because we reuse the same errp blindly. Add error handling checks to fix both issues. Signed-off-by: Fam Zheng --- hw/virtio/virtio-bus.c | 18 -- 1 file

[Qemu-devel] [RFC PATCH 1/4] I440: Allow adding sysbus devices with -device on I440

2017-03-17 Thread Lan Tianyu
From: Chao Gao xen-viommu will be a sysbus device and the device model will be enabled via "-device" parameter. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a07dc81..3289

[Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

2017-03-17 Thread Lan Tianyu
This patchset is to add Xen vIOMMU device model and handle irq remapping stuffs. Xen vIOMMU emulation is in the Xen hypervisor and the new device module in Qemu works as hypercall wrappers to create and destroy vIOMMU in hypervisor. Xen only supports emulated I440 and so we enable vIOMMU with emul

[Qemu-devel] [RFC PATCH 3/4] xen-pt: bind/unbind interrupt remapping format MSI

2017-03-17 Thread Lan Tianyu
From: Chao Gao If a vIOMMU is exposed to guest, guest will configure the msi to remapping format. The original code isn't suitable to the new format. A new pair bind/unbind interfaces are added for this usage. This patch recognizes this case and use new interfaces to bind/unbind msi. Signed-off-

[Qemu-devel] [RFC PATCH 2/4] Xen: add a dummy vIOMMU to create/destroy vIOMMU in Xen

2017-03-17 Thread Lan Tianyu
From: Chao Gao Since adding a dynamic sysbus device is forbidden, so choose TYPE_DEVICE as parent class. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu --- hw/xen/Makefile.objs | 1 + hw/xen/xen_viommu.c | 116 +++ 2 files changed, 117 ins

[Qemu-devel] [RFC PATCH 4/4] msi: taking interrupt format into consideration during judging a pirq is binded with a event channel

2017-03-17 Thread Lan Tianyu
From: Chao Gao As remapping format interrupt has been introduced, the vector in msi remapping format can also be 0, same as a interrupt is binded with a event channel. So we can't just use whether vector is 0 or not to judge a msi is binded to a event channel or not. This patch takes the msi int

Re: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support

2017-03-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1489750157-17401-1-git-send-email-tianyu@intel.com Subject: [Qemu-devel] [RFC PATCH 0/4] Qemu: Add Xen vIOMMU support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Daniel P. Berrange
On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: > We plan to drop support in a future QEMU release for host OSes > and host architectures for which we have no test machine where > we can build and run tests. For the 2.9 release, make configure > print a warning if it is run on such a

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 11:49, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: >> We plan to drop support in a future QEMU release for host OSes >> and host architectures for which we have no test machine where >> we can build and run tests. For the 2.9 relea

Re: [Qemu-devel] [PATCH for-2.9] thread-pool: add missing qemu_bh_cancel in completion function

2017-03-17 Thread Kevin Wolf
Am 16.03.2017 um 17:02 hat Peter Lieven geschrieben: > commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. > > However, the rescheduling of the completion BH introcuded unnecessary spinning > in the main-loop. On very fast file backends this can even lead to the > "WARNING

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Cornelia Huck
On Fri, 17 Mar 2017 19:33:53 +0800 Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Daniel P. Berrange
On Fri, Mar 17, 2017 at 11:52:01AM +, Peter Maydell wrote: > On 17 March 2017 at 11:49, Daniel P. Berrange wrote: > > On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: > >> We plan to drop support in a future QEMU release for host OSes > >> and host architectures for which we have

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > > Signed-off-by

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Cornelia Huck
On Fri, 17 Mar 2017 13:18:16 +0100 Andrew Jones wrote: > On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > > For one thing we shouldn't continue if an error happened, for the other > > two steps failing can cause an abort() in error_setg because we reuse > > the same errp blindly. > >

Re: [Qemu-devel] [PATCH for-2.9] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Fam Zheng
On Fri, 03/17 13:18, Andrew Jones wrote: > On Fri, Mar 17, 2017 at 07:33:53PM +0800, Fam Zheng wrote: > > For one thing we shouldn't continue if an error happened, for the other > > two steps failing can cause an abort() in error_setg because we reuse > > the same errp blindly. > > > > Add error h

[Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Fam Zheng
For one thing we shouldn't continue if an error happened, for the other two steps failing can cause an abort() in error_setg because we reuse the same errp blindly. Add error handling checks to fix both issues. Signed-off-by: Fam Zheng --- v2: Don't forget the last errp -> &local_err. [Drew] -

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 11:49:53AM +, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: > > This list is definitely too all-encompassing, and we should > > move at least some of the BSDs into "not-deprecated". > > I'm posting the patch for the moment for

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Cornelia Huck
On Fri, 17 Mar 2017 20:32:42 +0800 Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio: Fix error handling in virtio_bus_device_plugged

2017-03-17 Thread Andrew Jones
On Fri, Mar 17, 2017 at 08:32:42PM +0800, Fam Zheng wrote: > For one thing we shouldn't continue if an error happened, for the other > two steps failing can cause an abort() in error_setg because we reuse > the same errp blindly. > > Add error handling checks to fix both issues. > > Signed-off-by

Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

2017-03-17 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 13/03/2017 13:44, Juan Quintela wrote: > > case RAM_SAVE_FLAG_MULTIFD_PAGE: > > fd_num = qemu_get_be16(f); > > -if (fd_num != 0) { > > -/* this is yet an unused variable, changed later */ > > -

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-17 Thread James Hanley
Thanks - that seemed to resolve the issue. Will the synchronization scripts be updated for all repositories? I was also seeing the same issue when references for submodules roms/SLOF and roms/seabios were updated. -Jim On Wed, Mar 15, 2017 at 1:02 PM, Jeff Cody wrote: > On Wed, Mar 15, 2017 at

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Andrea Bolognani
On Fri, 2017-03-17 at 11:56 +, Daniel P. Berrange wrote: > > Yeah. I'm just struggling with setting up a FreeBSD VM so we > > can compile test that. Interesting that GNU/kFreeBSD has users. >  > I wouldn't go so far as to say GNU/kFreeBSD has users. It had a few people > who have noticed bits o

[Qemu-devel] [PULL 3/8] file-posix: Don't leak fd in hdev_get_max_segments

2017-03-17 Thread Kevin Wolf
From: Fam Zheng This fixes a leaked fd introduced in commit 9103f1ce. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/file-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index ac6bd9f..53febd3 100644

[Qemu-devel] [PULL 4/8] block: Always call bdrv_child_check_perm first

2017-03-17 Thread Kevin Wolf
From: Fam Zheng bdrv_child_set_perm alone is not very usable because the caller must call bdrv_child_check_perm first. This is already encapsulated conveniently in bdrv_child_try_set_perm, so remove the other prototypes from the header and fix the one wrong caller, block/mirror.c. Signed-off-by:

[Qemu-devel] [PULL 6/8] block: Propagate error in bdrv_open_backing_file

2017-03-17 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index a77e8a0..e538084 100644 --- a/block.c +++ b/block.c @@ -2030,6 +2030,7 @@ int bdrv_open_backing_file(BlockDriv

[Qemu-devel] [PULL 7/8] thread-pool: add missing qemu_bh_cancel in completion function

2017-03-17 Thread Kevin Wolf
From: Peter Lieven commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. However, the rescheduling of the completion BH introcuded unnecessary spinning in the main-loop. On very fast file backends this can even lead to the "WARNING: I/O thread spun for 1000 iterations" mes

Re: [Qemu-devel] [PATCH v3 5/9] xen/9pfs: connect to the frontend

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:54 -0700 Stefano Stabellini wrote: > Write the limits of the backend to xenstore. Connect to the frontend. > Upon connection, allocate the rings according to the protocol > specification. > > Initialize a QEMUBH to schedule work upon receiving an event channel > notific

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Thomas Huth
On 17.03.2017 12:52, Peter Maydell wrote: > On 17 March 2017 at 11:49, Daniel P. Berrange wrote: >> On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: >>> We plan to drop support in a future QEMU release for host OSes >>> and host architectures for which we have no test machine where >

[Qemu-devel] [PULL 2/8] replication: clarify permissions

2017-03-17 Thread Kevin Wolf
From: Changlong Xie Even if hidden_disk, secondary_disk are backing files, they all need write permissions in replication scenario. Otherwise we will encouter below exceptions on secondary side during adding nbd server: {'execute': 'nbd-server-add', 'arguments': {'device': 'colo-disk', 'writable

[Qemu-devel] [PULL 1/8] file-posix: clean up max_segments buffer termination

2017-03-17 Thread Kevin Wolf
From: Stefan Hajnoczi The following pattern is unsafe: char buf[32]; ret = read(fd, buf, sizeof(buf)); ... buf[ret] = 0; If read(2) returns 32 then a byte beyond the end of the buffer is zeroed. In practice this buffer overflow does not occur because the sysfs max_segments file only co

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:19, Thomas Huth wrote: > On 17.03.2017 12:52, Peter Maydell wrote: >> On 17 March 2017 at 11:49, Daniel P. Berrange wrote: >>> On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: We plan to drop support in a future QEMU release for host OSes and host ar

Re: [Qemu-devel] [PATCH v2 2/3] qemu-img: fix switch indentation in img_amend()

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 07:45 AM, Stefan Hajnoczi wrote: QEMU coding style indents 'case' to the same level as the 'switch' statement: switch (foo) { case 1: Fix this coding style violation so checkpatch.pl doesn't complain about the next patch. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philipp

[Qemu-devel] [PULL 5/8] blockdev: fix bitmap clear undo

2017-03-17 Thread Kevin Wolf
From: John Snow Only undo the action if we actually prepared the action. Signed-off-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index f1f49bd..c5b2c2c 100644 ---

[Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1

2017-03-17 Thread Kevin Wolf
The following changes since commit 272d7dee5951f926fad1911f2f072e5915cdcba0: Merge remote-tracking branch 'remotes/kraxel/tags/pull-cirrus-20170316-1' into staging (2017-03-16 16:40:44 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-devel] [PULL 8/8] block: quiesce AioContext when detaching from it

2017-03-17 Thread Kevin Wolf
From: Paolo Bonzini While it is true that bdrv_set_aio_context only works on a single BlockDriverState subtree (see commit message for 53ec73e, "block: Use bdrv_drain to replace uncessary bdrv_drain_all", 2015-07-07), it works at the AioContext level rather than the BlockDriverState level. There

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:19, Thomas Huth wrote: > So could you maybe change your patch that it does not warn when the user > has run configure with the "--enable-tcg-interpreter" option? Nope. I specifically don't want to enable support for TCI on random who-knows-what-this-is architectures. It eat

Re: [Qemu-devel] [PULL 0/2] submodule-update queue 20170303

2017-03-17 Thread Jeff Cody
On Fri, Mar 17, 2017 at 09:06:20AM -0400, James Hanley wrote: >Thanks - that seemed to resolve the issue.  Will the synchronization >scripts be updated for all repositories? I was also seeing the same issue >when references for submodules roms/SLOF and roms/seabios were updated. >-J

Re: [Qemu-devel] [PATCH v3 7/9] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-03-17 Thread Greg Kurz
On Thu, 16 Mar 2017 13:01:56 -0700 Stefano Stabellini wrote: > Implement xen_9pfs_init_in/out_iov_from_pdu and > xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the > data on the ring. > > This is safe as we only handle one request per ring at any given time. > > Signed-off-by:

[Qemu-devel] [PATCH] xen: use libxendevice model to restrict operations

2017-03-17 Thread Paul Durrant
This patch adds a command-line option (-xen-domid-restrict) which will use the new libxendevicemodel API to restrict devicemodel operations to the specified domid. This patch also adds a tracepoint to allow successful enabling of the restriction to be monitored. Signed-off-by: Paul Durrant --- C

Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts

2017-03-17 Thread Thomas Huth
On 17.03.2017 14:22, Peter Maydell wrote: > On 17 March 2017 at 13:19, Thomas Huth wrote: >> On 17.03.2017 12:52, Peter Maydell wrote: >>> On 17 March 2017 at 11:49, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 11:08:22AM +, Peter Maydell wrote: > We plan to drop support in a fu

Re: [Qemu-devel] [PULL 0/8] Block layer fixes for 2.9.0-rc1

2017-03-17 Thread Peter Maydell
On 17 March 2017 at 13:15, Kevin Wolf wrote: > The following changes since commit 272d7dee5951f926fad1911f2f072e5915cdcba0: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-cirrus-20170316-1' > into staging (2017-03-16 16:40:44 +) > > are available in the git repository at: > > >

[Qemu-devel] [Bug 1673722] [NEW] Reading register at offset. It is not fully implemented warning make VM impossible to use

2017-03-17 Thread Julien Duponchelle
Public bug reported: Hi, Since this commit: https://github.com/qemu/qemu/commit/bc0f0674f037a01f2ce0870ad6270a356a7a8347 We can no longer use the IOSvL2 image from Cisco. The problem is we got a lot of warning message saying: e1000: Reading register at offset: 0x2410. It is not fully implem

Re: [Qemu-devel] [PATCH] qemu: Fix -version with configure --with-pkgversion

2017-03-17 Thread Thomas Huth
On 16.03.2017 10:00, Jordan Justen wrote: > This appears to have regressed in 67a1de0d19. > > When the configure --with-pkgversion=foo option is used, the output > from -version will look like: > > QEMU emulator version 2.8.90(foo) > Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project de

Re: [Qemu-devel] [PATCH] vnc: fix a qio-channel leak

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 07:14 AM, Daniel P. Berrange wrote: On Fri, Mar 17, 2017 at 01:28:02PM +0400, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Philippe Mathieu-Daudé
On 03/17/2017 05:53 AM, Marc-André Lureau wrote: On Fri, Mar 17, 2017 at 12:12 PM Gerd Hoffmann wrote: Unfortunaly switching to getPlatformDisplayEXT isn't as easy as implemented by 0ea1523fb6703aa0dcd65e66b59e96fec028e60a. See the longish comment for the complete story. Cc: Frediano Ziglio

Re: [Qemu-devel] [PATCH] qemu: Fix -version with configure --with-pkgversion

2017-03-17 Thread Peter Maydell
On 16 March 2017 at 09:00, Jordan Justen wrote: > This appears to have regressed in 67a1de0d19. > > When the configure --with-pkgversion=foo option is used, the output > from -version will look like: > > QEMU emulator version 2.8.90(foo) > Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Proje

  1   2   >