> > - Does this approach make sense? Any better ideas?
>
> What is the use case?
The short answer: emulating real hardware.
Since real HW has this capability, there exist certain
auxiliary systems that are built on it. Having similar
semantics available in QEMU allows me to build a virtual
m
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> Rename intermediate qemu-qapi.texi to qemu-qmp-qapi.texi to match its
>> user qemu-qmp-ref.texi, just like qemu-ga-qapi.texi matches
>> qemu-ga-ref.texi.
>>
>> Build the intermediate .texi next to the sources and the final
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> The new test case shows off qapi.py choking on an empty union base.
>
> We're still finding ways to choke the parser ;)
At least we're not finding dozens of ways without having to look hard
anymore :)
>> Signed-off-by: Mar
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> qapi2texi.py already conjures up ArgSections for undocumented
>> enumeration values, in texi_enum). Drop that, and conjure them up for
>
> Missing '('?
Or extra ')'. I'll clean it up.
>> all kinds of "arguments" (enumera
On Tue, Mar 14, 2017 at 11:04 AM, David Gibson
wrote:
> This patch implements hypercalls allowing a PAPR guest to resize its own
> hash page table. This will eventually allow for more flexible memory
> hotplug.
>
> The implementation is partially asynchronous, handled in a special thread
> runni
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> qapi2texi works with schema expression trees. Such a tight coupling
>> to schema language syntax is not a good idea. Convert it to the visitor
>> interface the other generators use.
>>
>> No change to generated documentat
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> We traditionally mark optional members #optional in the doc comment.
>> Before commit 3313b61, this was entirely manual.
>>
>> Commit 3313b61 added some automation because its qapi2texi.py relied
>> on #optional to determin
14 Мар 2017 г. 19:58 пользователь "Gerd Hoffmann"
написал:
Hi,
> - Does this approach make sense? Any better ideas?
What is the use case?
Sometimes I'm wondering why we actually need the "once" thing. Looks
like people use it for installs, but I fail to see why. I usually
configure my gu
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> We traditionally mark optional members #optional in the doc comment.
>> Before commit 3313b61, this was entirely manual.
>>
>> Commit 3313b61 added some automation because its qapi2texi.py relied
>> on #optional to determin
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> This replaces manual references like "For the arguments, see the
>> documentation of ..." by a generated reference "Arguments: the members
>> of ...".
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> qapi-schema.json
Hi,
> The short answer: emulating real hardware.
>
> Since real HW has this capability, there exist certain
> auxiliary systems that are built on it. Having similar
> semantics available in QEMU allows me to build a virtual
> machine that works with these systems without modifying
> them in an
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> The generated documentation doesn't mention object type members
>> inherited from a base type. Fix that.
>>
>> Example change (qemu-qmp-ref.txt):
>>
>> -- Struct: VncServerInfo
>>
>> The network connection inform
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> A flat union's branch brings in the members of another type. Generate
>> a suitable reference to that type.
>>
>> Example change (qemu-qmp-ref.txt):
>>
>> -- Flat Union: QCryptoBlockOpenOptions
>>
>> The options
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> This fixes the errors uncovered by the previous commit.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>
>>
>> expr = self.get_expr(False)
>> if 'include' in expr:
>> +self.reject
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> Move the check whether the doc matches the expression name from
>> check_definition_doc() to check_exprs(). This changes the error
>> location from the comment to the expression. Makes sense as the
>> message talks about t
On 14/03/2017 21:23, Stefano Stabellini wrote:
> On Tue, 14 Mar 2017, Stefano Stabellini wrote:
>>> Then you add to Makefile:
>>>
>>> CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y)
>>> CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y)
>>> +CONFIG_XEN := $(CONFIG_XEN_BACK
Eric Blake writes:
> On 03/13/2017 01:23 AM, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>>> Results in a more precise error location, but the real reason is
>>> emptying out check_docs() step by step.
>>>
>>> Signed-off-by: Markus Armbruster
>>
>> Perhaps we should simply drop t
Eric Blake writes:
> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>> check_definition_doc() checks for member documentation without a
>> matching member. It laboriously second-guesses what members
>> QAPISchema._def_exprs() will create. That's a stupid game.
>>
>> Move the check into QAPIS
Paolo Bonzini writes:
> When more complexity was added to facilitate inlining, Coverity
> lost the ability to use the address_space_rw model for
> address_space_read/write.
Got the commit hash of the change?
> This causes false positive defects when Coverity sees
> a length-8 write in address_s
On Mon, 13 Mar 2017 16:55:53 -0700
Stefano Stabellini wrote:
> Do not use the ring.h header installed on the system. Instead, import
> the header into the QEMU codebase. This avoids problems when QEMU is
> built against a Xen version too old to provide all the ring macros.
>
What kind of proble
Krzysztof Kozlowski writes:
> On Tue, Mar 14, 2017 at 06:24:33PM +, Alex Bennée wrote:
>> That means you're on a pre-mttcg tree so that's not the reason.
>
> I managed to build it on current master (v2.8.0-2182-g5e2fb7c598c6). It
> behaves the same (with "-accel tcg,thread=single": cannot re
On 15/03/2017 14:39, Yang Zhong wrote:
> Since cpu-memory and memory have same address space,one malloced
> memory is enough. This patch will skip memory malloc for memory
> address space,which will reduce around 3M physical memory in heap.
>
> Signed-off-by: Yang Zhong
> ---
> memory.c | 2 +-
On 15/03/2017 08:56, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> When more complexity was added to facilitate inlining, Coverity
>> lost the ability to use the address_space_rw model for
>> address_space_read/write.
>
> Got the commit hash of the change?
>
>> This causes false posit
Commit eb7eeb8 ("memory: split address_space_read and
address_space_write", 2015-12-17) made address_space_rw
dispatch to one of address_space_read or address_space_write,
rather than vice versa.
For callers of address_space_read and address_space_write this
causes false positive defects when Cove
Hello Paolo&peter,
Maybe below patch is much more better, I also did the verification. Please all
of you give some comments, many thanks!
diff --git a/memory.c b/memory.c
index 64b0a60..230f2cb 100644
--- a/memory.c
+++ b/memory.c
@@ -2422,7 +2422,7 @@ AddressSpace *address_space_init_shareable(
hi
hi
im trying to trace Translation bloks and i guess that this function its the
responsible for print the trace informations
qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc, "Trace %p [%d: " TARGET_FMT_lx "]
%s\n", itb->tc_ptr, cpu->cpu_index, itb->pc, lookup_symbol(itb->pc));
but really i didn't u
Triaging old bug tickets ... can you still reproduce this problem with
the latest version of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/7
On Di, 2017-03-14 at 17:29 +, Dr. David Alan Gilbert wrote:
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > On 14 March 2017 at 17:01, Dr. David Alan Gilbert
> > wrote:
> > > I also do a FreeBSD VM
> >
> > Do you have repro instructions for how to conveniently set
> > this up?
>
> N
On 14/03/2017 22:23, Xu, Anthony wrote:
>> flatview_unref can call object_unref and thus reach:
>
> Okay, flatview_unref is the one you worried about,
>
> Flatview_unref is registered as a RCU callback only in
> address_space_update_topology,
> Strangely, it is registered as a RCU callback, a
On 03/14/2017 11:56 AM, Peter Maydell wrote:
> On 14 March 2017 at 09:59, Juan Quintela wrote:
>> Peter Maydell wrote:
>>> On 14 March 2017 at 09:13, Stefan Hajnoczi wrote:
On Mon, Mar 13, 2017 at 11:02:01AM +0100, Peter Maydell wrote:
The minimum requirements for the new language:
>>>
am testing QEMU COLO feature described here [QEMU
Wiki](http://wiki.qemu-project.org/Features/COLO).
When the Primary Node panic,the Secondary Node qemu hang.
hang at recvmsg in qio_channel_socket_readv.
And I run { 'execute': 'nbd-server-stop' } and { "execute":
"x-colo-lost-heartbeat" } in
On Mon, 13 Mar 2017 16:55:54 -0700
Stefano Stabellini wrote:
> It uses the new ring.h macros to declare rings and interfaces.
>
> Signed-off-by: Stefano Stabellini
> CC: anthony.per...@citrix.com
> CC: jgr...@suse.com
> ---
> hw/9pfs/xen_9pfs.h | 20
> 1 file changed, 20 i
RFCv2:
* Publishing RFC again to discuss the new user-visible interfaces. Code has
changed quite a bit, I have not kept any Reviewed-by tags.
* Rename qemu-img sub-command "measure" and API bdrv_measure() [Nir]
* Report both "required bytes" and "fully allocated bytes" to handle the empty
bdrv_measure() provides a conservative maximum for the size of a new
image. This information is handy if storage needs to be allocated (e.g.
a SAN or an LVM volume) ahead of time.
Signed-off-by: Stefan Hajnoczi
---
qapi/block-core.json | 19 +++
include/block/block.h |
The image creation options parsed by qcow2_create() are also needed to
implement .bdrv_measure(). Extract the parsing code, including input
validation.
Signed-off-by: Stefan Hajnoczi
---
block/qcow2.c | 109 +++---
1 file changed, 73 insertion
Maximum size calculation is trivial for the raw format: it's just the
requested image size (because there is no metadata).
Signed-off-by: Stefan Hajnoczi
---
block/raw-format.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/block/raw-format.c b/block/raw-format.c
ind
The measure subcommand calculates the size required by a new image file.
This can be used by users or management tools that need to allocate
space on an LVM volume, SAN LUN, etc before creating or converting an
image file.
Suggested-by: Maor Lipchuk
Signed-off-by: Stefan Hajnoczi
---
qemu-img.c
Calculating the preallocated image size will be needed to implement
.bdrv_measure(). Extract the code out into a separate function.
Signed-off-by: Stefan Hajnoczi
---
block/qcow2.c | 134 +-
1 file changed, 76 insertions(+), 58 deletions(-
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/178 | 75
tests/qemu-iotests/178.out.qcow2 | 33 ++
tests/qemu-iotests/178.out.raw | 33 ++
tests/qemu-iotests/group | 1 +
4 files changed, 142 inse
Use qcow2_calc_prealloc_size() to get the required file size.
Signed-off-by: Stefan Hajnoczi
---
TODO:
* Query block status and only count allocated clusters if in_bs != NULL
* Exclude backing file clusters if in_bs != NULL and -o backing_file=
is given
---
block/qcow2.c | 53 ++
Some tests produce format-dependent output. Either the difference is
filtered out and ignored, or the test case is format-specific so we
don't need to worry about per-format output differences.
There is a third case: the test script is the same for all image formats
and the format-dependent outpu
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> "Daniel P. Berrange" writes:
> >>
> >> > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote:
> >> >> On 03/01/2017 06:32 AM, Daniel P. Berrange wro
On Wed, 2017-03-15 at 17:16 +1100, David Gibson wrote:
> It might be cleaner to just revaluate the irq level from scratch
> here,
> and set the level, rather than doing this complicated dance to work
> out if it has changed.
Hrm... there was a reason I did it this way but I can't quite remember
wh
On Wed, Mar 15, 2017 at 07:09:55AM +1000, Richard Henderson wrote:
> On 03/15/2017 03:07 AM, Peter Maydell wrote:
> > On 14 March 2017 at 17:54, Thomas Huth wrote:
> > > Our ia64 host backend in QEMU (tcg/ia64) is still marked as maintained
> > > ... so it's maybe not as dead as you think? Or shou
On Wed, Mar 15, 2017 at 12:13:58PM +0800, Chao Fan wrote:
> On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote:
> >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote:
> >> Chao Fan wrote:
> >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate.
> >> > It's
On Mon, 13 Mar 2017 16:55:56 -0700
Stefano Stabellini wrote:
> Write the limits of the backend to xenstore. Connect to the frontend.
> Upon connection, allocate the rings according to the protocol
> specification.
>
> Initialize a QEMUBH to schedule work upon receiving an event channel
> notific
On 15.03.2017 10:40, Daniel P. Berrange wrote:
> On Wed, Mar 15, 2017 at 07:09:55AM +1000, Richard Henderson wrote:
>> On 03/15/2017 03:07 AM, Peter Maydell wrote:
>>> On 14 March 2017 at 17:54, Thomas Huth wrote:
Our ia64 host backend in QEMU (tcg/ia64) is still marked as maintained
...
On 03/15/2017 05:53 AM, David Gibson wrote:
> On Tue, Mar 14, 2017 at 06:00:43PM +0100, Cédric Le Goater wrote:
>> On 03/14/2017 06:38 AM, David Gibson wrote:
>>> On Wed, Mar 08, 2017 at 11:52:44AM +0100, Cédric Le Goater wrote:
This helper will be used to translate the server number of the XI
On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> On 03/09/2017 09:25 PM, Eric Blake wrote:
> > [adding Stefan in cc, as trace maintainer]
> >
> > On 03/09/2017 09:15 PM, Eric Blake wrote:
> >
> > Perhaps I should update the subject to mention trace?
> >
> >> trace-events lists the p
Am 15.03.2017 um 04:37 hat Lidong Chen geschrieben:
> Increase bmds->cur_dirty after submit io, so reduce the frequency
> involve into blk_drain, and improve the performance obviously
> when block migration.
>
> The performance test result of this patch:
>
> During the block dirty save phase, thi
On Wed, Mar 15, 2017 at 06:18:35PM +0800, Stefan Hajnoczi wrote:
> On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> > And here's where I'm stuck: the makefiles are broken. Touching
> > scripts/tracetool/format/h.py does NOT cause tracetool to be re-run by a
> > mere 'make'; I've had t
On Tue, 14 Mar 2017 11:56:36 +0100
Peter Maydell wrote:
> On 14 March 2017 at 09:59, Juan Quintela wrote:
> > Peter Maydell wrote:
> >> On 14 March 2017 at 09:13, Stefan Hajnoczi wrote:
> >>> On Mon, Mar 13, 2017 at 11:02:01AM +0100, Peter Maydell wrote:
> >>> The minimum requirements for
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
[...]
>> > I'm confused why we need a 'reset to default' - all we need is the ability
>> > to change each parameter, and for the new value of that parameter
>> > to be an empty s
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> "Dr. David Alan Gilbert" writes:
> [...]
> >> > I'm confused why we need a 'reset to default' - all we need is the
> >> > ability
> >> > to change each par
On 15 March 2017 at 08:12, Paolo Bonzini wrote:
>
>
> On 15/03/2017 14:39, Yang Zhong wrote:
>> Since cpu-memory and memory have same address space,one malloced
>> memory is enough. This patch will skip memory malloc for memory
>> address space,which will reduce around 3M physical memory in heap.
Hi Andreas,
Am 14.03.2017 um 10:50 hat Andreas Grapentin geschrieben:
> The wiki sais to ask on the mailing list for write access to the wiki,
> so here I am :)
please send me a private email with your preferred username and an
initial password (that you'll obviously change immediately) and I can
Instead pass around the address (aka offset into vga memory). Calculate
the pointer in the rop_* functions, after applying the mask to the
address, to make sure the address stays within the valid range.
Signed-off-by: Gerd Hoffmann
---
hw/display/cirrus_vga.c | 20 +++---
hw/display/cirru
On Wed, Mar 15, 2017 at 10:36:35AM +, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (arm...@redhat.com) wrote:
> > "Dr. David Alan Gilbert" writes:
> >
> > > * Markus Armbruster (arm...@redhat.com) wrote:
> > >> "Dr. David Alan Gilbert" writes:
> > [...]
> > >> > I'm confused why we ne
On Mon, 13 Mar 2017 16:55:57 -0700
Stefano Stabellini wrote:
> Upon receiving an event channel notification from the frontend, schedule
> the bottom half. From the bottom half, read one request from the ring,
> create a pdu and call pdu_submit to handle it.
>
> For now, only handle one request p
Am 14.03.2017 um 03:30 hat Fam Zheng geschrieben:
> bdrv_child_set_perm alone is not very usable because the caller must
> call bdrv_child_check_perm first.
Well, you can imagine use cases where you want to check multiple
children first and then set or abort all of them, but apparently we
haven't
The build rules for trace files have a dependancy on $(tracetool-y).
This variable populated in the trace/Makefile.objs file and thus its
definition gets pulled into the top level makefile. This happens too
late in the process though, so by the time $(tracetool-y) is defined,
make has already evalu
On Mon, 13 Mar 2017 16:55:58 -0700
Stefano Stabellini wrote:
> Implement xen_9pfs_init_in/out_iov_from_pdu and
> xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the
> data on the ring.
>
> This is safe as we only handle one request per ring at any given time.
>
> Signed-off-by:
On Wed, Mar 15, 2017 at 10:26:44AM +, Daniel P. Berrange wrote:
> On Wed, Mar 15, 2017 at 06:18:35PM +0800, Stefan Hajnoczi wrote:
> > On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> > > And here's where I'm stuck: the makefiles are broken. Touching
> > > scripts/tracetool/format
On Mon, 13 Mar 2017 16:55:59 -0700
Stefano Stabellini wrote:
> Once a request is completed, xen_9pfs_push_and_notify gets called. In
> xen_9pfs_push_and_notify, update the indexes (data has already been
> copied to the sg by the common code) and send a notification to the
> frontend.
>
> Schedul
Am 14.03.2017 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben:
> If we have separate iothread for cdrom, we lose connection to it on
> qmp_blockdev_change_medium, as aio_context is on bds which is dropped
> and switched with new one.
>
> As an example result, after such media change we have
On Wed, 03/15 11:52, Kevin Wolf wrote:
> Am 14.03.2017 um 03:30 hat Fam Zheng geschrieben:
> > bdrv_child_set_perm alone is not very usable because the caller must
> > call bdrv_child_check_perm first.
>
> Well, you can imagine use cases where you want to check multiple
> children first and then s
On Wed, 03/15 11:37, Lidong Chen wrote:
> Increase bmds->cur_dirty after submit io, so reduce the frequency
> involve into blk_drain, and improve the performance obviously
> when block migration.
>
> The performance test result of this patch:
>
> During the block dirty save phase, this patch impr
On Wed, 03/15 12:03, Kevin Wolf wrote:
> Am 14.03.2017 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > If we have separate iothread for cdrom, we lose connection to it on
> > qmp_blockdev_change_medium, as aio_context is on bds which is dropped
> > and switched with new one.
> >
> > As
BALATON Zoltan writes:
> On Tue, 14 Mar 2017, Alex Bennée wrote:
>> So from a single-threaded -smp guest case there should be no difference
>> in behaviour.
>>However this shouldn't affect
>> anything in the single-threaded world.
>
> I think we have a single CPU and thread for these ppc machin
Le 15/03/2017 à 11:29, Greg Kurz a écrit :
> On Tue, 14 Mar 2017 11:56:36 +0100
> Peter Maydell wrote:
>
>> On 14 March 2017 at 09:59, Juan Quintela wrote:
>>> Peter Maydell wrote:
On 14 March 2017 at 09:13, Stefan Hajnoczi wrote:
> On Mon, Mar 13, 2017 at 11:02:01AM +0100, Peter
On 03/15/2017 05:56 AM, Daniel P. Berrange wrote:
> The build rules for trace files have a dependancy on $(tracetool-y).
> This variable populated in the trace/Makefile.objs file and thus its
> definition gets pulled into the top level makefile. This happens too
> late in the process though, so by
On Wed, Mar 15, 2017 at 06:44:25AM -0500, Eric Blake wrote:
> On 03/15/2017 05:56 AM, Daniel P. Berrange wrote:
> > The build rules for trace files have a dependancy on $(tracetool-y).
> > This variable populated in the trace/Makefile.objs file and thus its
> > definition gets pulled into the top l
On 03/14/2017 10:06 PM, Fam Zheng wrote:
>>> +static int bdrv_child_check_perm(BdrvChild *c, uint64_t perm, uint64_t
>>> shared,
>>> + GSList *ignore_children, Error **errp);
>>> +static void bdrv_child_abort_perm_update(BdrvChild *c);
>>> +static void bdrv_child_s
To avoid access stale memory region cache after reset, this patch
check the existence of virtqueue pfn for all exported virtqueue access
helpers before trying to use them.
Cc: Cornelia Huck
Cc: Paolo Bonzini
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wang
---
Changes from V2:
- return 1 i
Hi:
This series contains several fixes for virtio region caches, please
review.
Thakns
Jason Wang (3):
virtio: guard against NULL pfn
virtio: destroy region cache during reset
virtio: validate address space cache during init
hw/virtio/virtio.c | 104 ++
We don't destroy region cache during reset which can make the maps
of previous driver leaked to a buggy or malicious driver that don't
set vring address before starting to use the device. Fix this by
destroy the region cache during reset and validate it before trying to
see them.
Cc: Cornelia Huck
We don't check the return value of address_space_cache_init(), this
may lead buggy driver use incorrect region caches. Instead of
triggering an assert, catch and warn this early in
virtio_init_region_cache().
Cc: Cornelia Huck
Cc: Paolo Bonzini
Reviewed-by: Cornelia Huck
Signed-off-by: Jason Wa
On 03/15/2017 02:08 AM, Markus Armbruster wrote:
>>> +++ b/.gitignore
>>> @@ -103,11 +103,11 @@
>>> /docs/qemu-ga-ref.txt
>>
>> [1]
>>
>>> /docs/qemu-qmp-ref.html
>>> /docs/qemu-qmp-ref.txt
>>> -docs/qemu-ga-ref.info*
>>> -docs/qemu-qmp-ref.info*
>>> -/qemu-ga-qapi.texi
>>> -/qemu-qapi.texi
>>>
On Mon, 13 Mar 2017 16:55:57 -0700
Stefano Stabellini wrote:
> Upon receiving an event channel notification from the frontend, schedule
> the bottom half. From the bottom half, read one request from the ring,
> create a pdu and call pdu_submit to handle it.
>
> For now, only handle one request p
On 03/15/2017 03:16 AM, Paolo Bonzini wrote:
> Commit eb7eeb8 ("memory: split address_space_read and
> address_space_write", 2015-12-17) made address_space_rw
> dispatch to one of address_space_read or address_space_write,
> rather than vice versa.
>
> For callers of address_space_read and address
On 15 March 2017 at 11:55, Eric Blake wrote:
> On 03/15/2017 03:16 AM, Paolo Bonzini wrote:
>> -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs
>> attrs,
>> - uint8_t *buf, int len, bool is_write)
>> +MemTxResult address_space_read(AddressSpace *
Am 15.03.2017 um 12:09 hat Fam Zheng geschrieben:
> On Wed, 03/15 11:52, Kevin Wolf wrote:
> > Am 14.03.2017 um 03:30 hat Fam Zheng geschrieben:
> > > bdrv_child_set_perm alone is not very usable because the caller must
> > > call bdrv_child_check_perm first.
> >
> > Well, you can imagine use case
off_cur_end is exclusive, so off_cur_end == cirrus_addr_mask is valid.
Fix calculation to make sure to allow that, otherwise the assert added
by commit f153b563f8cf121aebf5a2fff5f0110faf58ccb3 can trigger for valid
blits.
Test case: boot windows nt 4.0
Signed-off-by: Gerd Hoffmann
---
hw/displa
Am 15.03.2017 um 12:14 hat Fam Zheng geschrieben:
> On Wed, 03/15 12:03, Kevin Wolf wrote:
> > Am 14.03.2017 um 18:11 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > If we have separate iothread for cdrom, we lose connection to it on
> > > qmp_blockdev_change_medium, as aio_context is on bds wh
On 03/15/2017 02:30 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>>> @@ -152,6 +152,8 @@ def texi_members(doc, what, member_func):
>>> else:
>>> desc = 'Not documented'
>>> items += member_func(section.member) + texi_format(desc) + '\n'
>>> +if base:
>>>
On 03/15/2017 02:39 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 03/13/2017 01:18 AM, Markus Armbruster wrote:
>>> This fixes the errors uncovered by the previous commit.
>>>
>>> Signed-off-by: Markus Armbruster
>>> ---
>>
>>>
>>> expr = self.get_expr(False)
>>>
On 03/15/2017 06:58 AM, Peter Maydell wrote:
> On 15 March 2017 at 11:55, Eric Blake wrote:
>> On 03/15/2017 03:16 AM, Paolo Bonzini wrote:
>>> -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs
>>> attrs,
>>> - uint8_t *buf, int len, bool is_write
The build rules for trace files have a dependancy on $(tracetool-y).
This variable populated in the trace/Makefile.objs file and thus its
definition gets pulled into the top level makefile. This happens too
late in the process though, so by the time $(tracetool-y) is defined,
make has already evalu
Hello Peter,
The cpu-memory and memory have same address space through info mtree tool.
address-space: memory
- (prio 0, i/o): system
-7fff (prio 0, i/o): alias ram-below-4g @pc.ram
-7fff
00
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Marc-André Lureau
---
scripts/qapi.py | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 53a4477..345cde1 100644
--- a/s
The new test case shows off qapi.py choking on an empty union base.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
tests/Makefile.include | 1 +
tests/qapi-schema/union-base-empty.err | 10 ++
tests/qapi-schema/union-base-
We silently fix missing #optional tags for QAPIDoc by appending a line
"#optional" to the section's .content. However, this interferes with
.__repr__ stripping trailing blank lines from .content.
Use new ArgSection instance variable .optional instead, and leave
.content alone.
To permit testing
Section "Commands" qualifies its rules on permitted argument and
return types "with one exception noted below when 'gen' is used". The
note went away in commit 2d21291. Clean up the dangling references.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Marc-André Lureau
--
Talking about #optional like this
# Note: fields are marked #optional to indicate that they may or may
# not appear ...
doesn't work so well in generated documentation, because the #optional
tag is not visible there. Replace by
# Note: optional members may or may not appear ...
Sig
We use tag #optional to mark optional members, like this:
# @name: #optional The name of the guest
texi_body() strips #optional, but not whitespace around it. For the
above, we get in qemu-qmp-qapi.texi
@item @code{'name'} (optional)
The name of the guest
@end table
The extra
Instead of not saying anything when we have no documentation, say "Not
documented".
Example change (qemu-qmp-ref.txt):
-- Enum: GuestPanicAction
An enumeration of the actions taken when guest OS panic is detected
Values:
'pause'
system pauses
'poweroff'
+
qapi.py has a hardcoded white-list of command names that may violate
the rules on permitted return types. Add a new pragma directive
'returns-whitelist', and use it to replace the hard-coded white-list.
Signed-off-by: Markus Armbruster
---
docs/qapi-code-gen.txt | 13
The recent merge of docs/qmp-commands.txt and docs/qmp-events.txt into
the schema lost type information. Fix this documentation regression.
Example change (qemu-qmp-ref.txt):
-- Struct: InputKeyEvent
Keyboard input event.
Members:
- 'button'
+ 'button: InputButton'
Rename intermediate qemu-qapi.texi to qemu-qmp-qapi.texi to match its
user qemu-qmp-ref.texi, just like qemu-ga-qapi.texi matches
qemu-ga-ref.texi.
Build the intermediate .texi next to the sources and the final output
in docs/ instead of dumping them into the build root.
Fix version.texi dependen
1 - 100 of 352 matches
Mail list logo
