Re qemu-trivial: since I got another lengthy series touching
scripts/qapi* in the pipeline, I'd prefer to handle the conflicts in my
tree.
Marc-André Lureau writes:
> This may help to find where the origin of the type was declared in the
> json (when greping isn't easy enough).
An example for t
On 03/13/2017 02:28 PM, Jason Wang wrote:
On 2017年03月13日 14:18, Zhang Chen wrote:
Hi~~~ All~
No news for a long time, anyone can give me some comments?
Hi,
A question is why use two kinds of colo-frames? This seems not good as
lots of the code were duplicated.
Because Xen colo-frame b
Eric Blake writes:
> On 03/11/2017 07:22 AM, Marc-André Lureau wrote:
>> The type is not used at all yet. Add some tests to exercice it.
>
> s/exercice/exercise/
>
> I wonder if we need this patch at all.
>
> I've been thinking about a possible alternative representation, such
> that a single QIn
* Cornelia Huck [2017-03-10 11:46:05 +0100]:
> On Thu, 9 Mar 2017 17:25:25 +0800
> Dong Jia Shi wrote:
>
> > * Dong Jia Shi [2017-02-17 09:29:24 +0100]:
> >
> > > vfio-ccw: the basic infrastructure
> > > ==
> > >
> > > Introduction
> > >
> > >
>
On 03/13/2017 03:10 PM, Zhang Chen wrote:
On 03/13/2017 02:28 PM, Jason Wang wrote:
On 2017年03月13日 14:18, Zhang Chen wrote:
Hi~~~ All~
No news for a long time, anyone can give me some comments?
Hi,
A question is why use two kinds of colo-frames? This seems not good
as lots of the cod
i used simple trace back end to trace guest code running in qemu but when i
tried to recompile and disable this trace i have always this problem
undefined reference to `trace_record_write_u64'
thanks for your help
Markus Armbruster writes:
> "Dr. David Alan Gilbert" writes:
>
>> * Germano Veit Michel (germ...@redhat.com) wrote:
>>> qemu_announce_self() is triggered by qemu at the end of migrations
>>> to update the network regarding the path to the guest l2addr.
>>>
>>> however it is also useful when the
On 13/03/2017 04:29, Jason Wang wrote:
> 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring
> translations") tries to make IOMMU works with virtio memory region
> cache, but it requires IOMMU to be created before any virtio
> devices. This is sub optimal, fixing this by intro
> -Original Message-
> From: Igor Druzhinin
> Sent: 10 March 2017 20:07
> To: sstabell...@kernel.org; Anthony Perard
> Cc: Paul Durrant ; qemu-devel@nongnu.org; xen-
> de...@lists.xenproject.org; Igor Druzhinin
> Subject: [PATCH v2] xen: don't save/restore the physmap on VM
> save/restore
Hi,
On 20-02-17 10:50, Frediano Ziglio wrote:
According to
https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt
if MESA_platform_gbm is supported display should be initialized
from a GBM handle using eglGetPlatformDisplayEXT.
Signed-off-by: Frediano Ziglio
---
This sh
Hi,
On 20-02-17 10:50, Frediano Ziglio wrote:
According to
https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt
if MESA_platform_gbm is supported display should be initialized
from a GBM handle using eglGetPlatformDisplayEXT.
Signed-off-by: Frediano Ziglio
---
This
A bug was introduced in following commit:
dc0ad84 target/ppc: update overflow flags for add/sub
As for 32-bit ppc target extracting bit 63 for overflow is not correct.
Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
9.2.1 image
Reported-by: Mark Cave-Ayland
Signed-off-by
On 03/13/2017 05:29 AM, Jason Wang wrote:
96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring
translations") tries to make IOMMU works with virtio memory region
cache, but it requires IOMMU to be created before any virtio
devices. This is sub optimal, fixing this by introduce
>
>
>
> Hi,
>
> On 20-02-17 10:50, Frediano Ziglio wrote:
> > According to
> > https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt
> > if MESA_platform_gbm is supported display should be initialized
> > from a GBM handle using eglGetPlatformDisplayEXT.
> >
> > Signed-
On 13/03/2017 10:38, Marcel Apfelbaum wrote:
> On 03/13/2017 05:29 AM, Jason Wang wrote:
>> 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring
>> translations") tries to make IOMMU works with virtio memory region
>> cache, but it requires IOMMU to be created before any virtio
On Mon, 13 Mar 2017 14:29:41 +0800
Jason Wang wrote:
> To avoid access stale memory region cache after reset, this patch
> check the existence of virtqueue pfn for all exported virtqueue access
> helpers before trying to use them.
>
> Cc: Cornelia Huck
> Cc: Paolo Bonzini
> Signed-off-by: Jaso
On Fri, Mar 10, 2017 at 07:04:38PM -0800, ashish mittal wrote:
> On Wed, Mar 8, 2017 at 10:11 AM, Daniel P. Berrange
> wrote:
> > On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote:
> >> On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar
> >> wrote:
> >> >
> >> >
> >> >> On Mar 8, 2017,
On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote:
> Thanks! There is one more input I need some help with!
>
> VxHS network library opens a fixed number of connection channels to a
> given host, and all the vdisks (that connect to the same host) share
> these connection channels.
>
>
On 12 March 2017 at 21:45, Juan Quintela wrote:
>
>
> Hi
>
> Please, send any topic that you are interested in covering.
>
> So far the agenda is:
>
> - Direction of QEMU and toolstack in light of Google Cloud blog:
>
> https://cloudplatform.googleblog.com/2017/01/7-ways-we-harden-our-KVM-hyper
Hi,
On 13-03-17 10:39, Frediano Ziglio wrote:
Hi,
On 20-02-17 10:50, Frediano Ziglio wrote:
According to
https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt
if MESA_platform_gbm is supported display should be initialized
from a GBM handle using eglGetPlatformDispl
On Mon, 13 Mar 2017 14:29:42 +0800
Jason Wang wrote:
> We don't destroy region cache during reset which can make the maps
> of previous driver leaked to a buggy or malicious driver that don't
> set vring address before starting to use the device. Fix this by
> destroy the region cache during rese
Am 13.03.2017 um 04:31 hat Dong Jia Shi geschrieben:
> * Dong Jia Shi [2017-03-08 17:31:05 +0800]:
>
> > * Kevin Wolf [2017-03-08 10:13:46 +0100]:
> >
> > > Am 08.03.2017 um 03:15 hat Dong Jia Shi geschrieben:
> > > > A normal call for raw_open should always pass in a non-NULL @options,
> > > >
On Mon, 13 Mar 2017 14:29:43 +0800
Jason Wang wrote:
> We don't check the return value of address_space_cache_init(), this
> may lead buggy driver use incorrect region caches. Instead of
> triggering an assert, catch and warn this early in
> virtio_init_region_cache().
>
> Cc: Cornelia Huck
> C
On 13/03/2017 10:55, Cornelia Huck wrote:
> On Mon, 13 Mar 2017 14:29:41 +0800
> Jason Wang wrote:
>
>> To avoid access stale memory region cache after reset, this patch
>> check the existence of virtqueue pfn for all exported virtqueue access
>> helpers before trying to use them.
>>
>> Cc: Cor
On 03/13/2017 11:52 AM, Paolo Bonzini wrote:
On 13/03/2017 10:38, Marcel Apfelbaum wrote:
On 03/13/2017 05:29 AM, Jason Wang wrote:
96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring
translations") tries to make IOMMU works with virtio memory region
cache, but it requires
oussema ben khedher writes:
> i used simple trace back end to trace guest code running in qemu but when i
> tried to recompile and disable this trace i have always this problem
> undefined reference to `trace_record_write_u64'
> thanks for your help
It's always worth doing a make clean if you
On 13/03/2017 11:05, Cornelia Huck wrote:
> On Mon, 13 Mar 2017 14:29:42 +0800
> Jason Wang wrote:
>
>> We don't destroy region cache during reset which can make the maps
>> of previous driver leaked to a buggy or malicious driver that don't
>> set vring address before starting to use the devic
Hi
On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster
wrote:
> I'm proposing this is 2.9 because it fixes a documentation regression.
> It affects only documentation; generated C code is unchanged except
> for the removal of trailing space in PATCH 46.
>
> Based on my qapi-next branch, which con
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> Provide a helper to say whether a RAMBlock was created as a
> shared mapping.
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
On 8 March 2017 at 00:40, Henry Wertz wrote:
> I have a trivial, 1-line patch for getdents function; due to use of
> unsigned long, the struct on 64-bit and 32-bit systems is not the same.
> qemu is aware of this, however it currently only checks for a 32-bit target
> on 64-bit host case; in my ca
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> Postcopy doesn't support migration of RAM shared with another process
> yet (we've got a bunch of things to understand).
> Check for the case and don't allow postcopy to be enabled.
>
> Signed-off-by: Dr. David Alan Gilber
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> Hi, David, Andrea and Mike
Hi Alexey,
> The problem I want to discuss it's 1G hugepage based VM and post copy live
> migration.
>
> I would like to know your opinion on following approach of avoiding such
> problem:
> Once we have mmap'ed are
On 9 March 2017 at 19:38, Jose Ricardo Ziviani
wrote:
> This commit set Makefile to point to ppc64le source for both archs
> (ppc64 and ppc64le) because they do the exact same thing. The
> difference is in risugen and how the binary is build.
If we're going to share a single set of source files f
Am 13.03.2017 um 04:42 hat Christopher Pereira geschrieben:
> We are currently providing Linux swap disks with QEMU driver, virtio
> bus and qcow2 type.
>
> Do you know any alternatives that provide better performance?
>
> Considering that swap disks contain less critical data, QEMU could
> avoid
On 9 March 2017 at 18:09, Ard Biesheuvel wrote:
> The arm64 boot protocol stipulates that the kernel must be loaded
> TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET
> could be any 4 KB multiple between 0 and 2 MB, and whose value can be
> found in the header of the Image f
On 13 March 2017 at 11:22, Peter Maydell wrote:
> On 9 March 2017 at 18:09, Ard Biesheuvel wrote:
>> The arm64 boot protocol stipulates that the kernel must be loaded
>> TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET
>> could be any 4 KB multiple between 0 and 2 MB, and w
On 9 March 2017 at 12:17, Alex Bennée wrote:
> The following changes since commit b64842dee42d6b24d51283e4722140b73be1e222:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2017-03-08 09:47:52 +)
>
> are available in the git repository at:
>
> https://git
On Sun, Mar 12, 2017 at 11:16:44AM +, Mark Cave-Ayland wrote:
> On 12/03/17 03:56, Michael S. Tsirkin wrote:
>
> > After looking at it some more, I think the issue is merely with how info
> > mtree presents information, which confuses instead of helping when
> > overlap triggers. Specifically
Marc-André Lureau writes:
> Hi
>
> On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster
> wrote:
>
>> I'm proposing this is 2.9 because it fixes a documentation regression.
>> It affects only documentation; generated C code is unchanged except
>> for the removal of trailing space in PATCH 46.
>>
>
Hi
On Mon, Mar 13, 2017 at 4:14 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster
> > wrote:
> >
> >> I'm proposing this is 2.9 because it fixes a documentation regression.
> >> It affects only documentation; generated C
Hi,
> From: mttcg-requ...@listserver.greensocs.com
> [mailto:mttcg-requ...@listserver.greensocs.com]
>
> The next thing on my list it to look at the icount problems and review
> Paolo's fixes for it. However those fixes should go in a separate
> series and I assume via Paolo's tree.
Do you mea
On Sunday, March 12, 2017 12:04 PM, Michael S. Tsirkin wrote:
> On Sun, Mar 12, 2017 at 01:59:54AM +, Wang, Wei W wrote:
> > On 03/11/2017 10:10 PM, Matthew Wilcox wrote:
> > > On Sat, Mar 11, 2017 at 07:59:31PM +0800, Wei Wang wrote:
> > > > I'm thinking what if the guest needs to transfer the
On 03/10/2017 10:08 PM, Halil Pasic wrote:
>
>
> On 03/10/2017 05:47 PM, Paolo Bonzini wrote:
>>
>> On 07/03/2017 14:16, Halil Pasic wrote:
>>> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and
>>> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active"
>>
Right now, if we receive a compressed page while this features are
disabled, Bad Things (TM) can happen. Just add a test for them.
Signed-off-by: Juan Quintela
--
I had XBZRLE here also, but it don't need extra resources on
destination, only on source. Additionally libvirt don't enable it on
The function waits until it is able to write the full iov.
Signed-off-by: Juan Quintela
---
include/io/channel.h | 23 +++
io/channel.c | 39 +++
migration/qemu-file-channel.c | 29 +
3
Hi
This is the 4th version of multifd. Changes:
- XBZRLE don't need to be checked for
- Documentation and defaults are consistent
- split socketArgs
- use iovec instead of creating something similar.
- We use now the exported size of target page (another HACK removal)
- created qio_chanel_{wirtev,
Creation of the threads, nothing inside yet.
Signed-off-by: Juan Quintela
--
Use pointers instead of long array names
Move to use semaphores instead of conditions as paolo suggestion
Put all the state inside one struct.
Use a counter for the number of threads created. Needed during cancellati
It is the symmetric function from qio_channel_write_all
Signed-off-by: Juan Quintela
---
include/io/channel.h | 23 +++
io/channel.c | 37 +
2 files changed, 60 insertions(+)
diff --git a/include/io/channel.h b/include/io/channel.h
Indicates the number of threads that we would create. By default we
create 2 threads.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
--
Catch inconsistent defaults.
Thanks Eric
Signed-off-by: Juan Quintela
---
hmp.c | 8
include/migration
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/migration.h | 1 +
migration/migration.c | 9 +
qapi-schema.json | 6 --
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/include/migration/migration.h b/include
We now send several pages at a time each time that we wakeup a thread.
Signed-off-by: Juan Quintela
--
Use iovec's insead of creating the equivalent.
Signed-off-by: Juan Quintela
---
migration/ram.c | 46 --
1 file changed, 40 insertions(+), 6 dele
Indicates how many pages we are going to send in each bach to a multifd
thread.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
--
Be consistent with defaults and documentation
Signed-off-by: Juan Quintela
---
hmp.c | 8
include/migration/m
We create new channels for each new thread created. We only send through
them a character to be sure that we are creating the channels in the
right order.
Signed-off-by: Juan Quintela
--
Split SocketArgs into incoming and outgoing args
Signed-off-by: Juan Quintela
---
include/migration/migrat
Signed-off-by: Juan Quintela
--
I removed the [HACK] part because previous patch just check that
compression pages are not received.
Signed-off-by: Juan Quintela
---
migration/ram.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 65419c1..aa51
We are still sending the page through the main channel, that would
change later in the series
Signed-off-by: Juan Quintela
---
migration/ram.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 4914240..6f5ca50 100644
--- a/
The function still don't use multifd, but we have simplified
ram_save_page, xbzrle and RDMA stuff is gone. We have added a new
counter and a new flag for this type of pages.
Signed-off-by: Juan Quintela
---
hmp.c | 2 +
include/migration/migration.h | 1 +
migration/mi
Peter Maydell writes:
> On 12 March 2017 at 21:45, Juan Quintela wrote:
>>
>>
>> Hi
>>
>> Please, send any topic that you are interested in covering.
>>
>> So far the agenda is:
>>
>> - Direction of QEMU and toolstack in light of Google Cloud blog:
>>
>> https://cloudplatform.googleblog.com/
Public bug reported:
tl;dr: A virtfs read fails. The init being on this virtfs (mounted by
the initrd), the linux kernel guest is unable to boot, and kernel
panics. The fact that qemu still takes 100%cpu after the kernel panic
makes me think it's a qemu bug.
Here is the setup (some hashes replace
We make the locking and the transfer of information specific, even if we
are still receiving things through the main thread.
Signed-off-by: Juan Quintela
---
migration/ram.c | 68 ++---
1 file changed, 60 insertions(+), 8 deletions(-)
diff --g
We just send the address through the alternate channels and test that it
is ok.
Signed-off-by: Juan Quintela
---
migration/ram.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 3b1a2dc..32cc678 100644
On 13/03/17 09:31, Nikunj A Dadhania wrote:
> A bug was introduced in following commit:
>
> dc0ad84 target/ppc: update overflow flags for add/sub
>
> As for 32-bit ppc target extracting bit 63 for overflow is not correct.
> Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
Each time that we sync the bitmap, it is a possiblity that we receive
a page that is being processed by a different thread. We fix this
problem just making sure that we wait for all receiving threads to
finish its work before we procedeed with the next stage.
We are low on page flags, so we use a
Oh, I forgot to mention: it first worked for some time, then in the
middle of a shell session running over a screen
/var/lib/vm/consoles/nginx/screen from the outer VM (socat-linked to
/var/lib/vm/consoles/nginx/socket.unix to provide a predictable pty
link), the 9pfs stopped returning any data, an
We switch for sending the page number to send real pages.
Signed-off-by: Juan Quintela
--
Remove the HACK bit, now we have the function that calculates the size
of a page exported.
Signed-off-by: Juan Quintela
---
migration/migration.c | 14
migration/ram.c | 59 ++
check the validity of parameters in cirrus_bitblt_rop_fwd_transp_xxx
and cirrus_bitblt_rop_fwd_xxx to avoid the OOB read which causes qemu
Segmentation fault.
After the fix, we will touch the assert in
cirrus_invalidate_region:
assert(off_cur_end >= off_cur);
Signed-off-by: fangying
Signed-off-
Marc-André Lureau writes:
> Hi
>
> On Mon, Mar 13, 2017 at 4:14 PM Markus Armbruster wrote:
>
>> Marc-André Lureau writes:
>>
>> > Hi
>> >
>> > On Mon, Mar 13, 2017 at 10:23 AM Markus Armbruster
>> > wrote:
>> >
>> >> I'm proposing this is 2.9 because it fixes a documentation regression.
>> >>
Pavel Dovgalyuk writes:
> Hi,
>
>> From: mttcg-requ...@listserver.greensocs.com
>> [mailto:mttcg-requ...@listserver.greensocs.com]
>>
>> The next thing on my list it to look at the icount problems and review
>> Paolo's fixes for it. However those fixes should go in a separate
>> series and I as
On 10 March 2017 at 08:20, Fam Zheng wrote:
> The following changes since commit eba44e9339fc13c36e24c8c59e2b73ea231b46a1:
>
> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
> staging (2017-03-06 15:13:23 +)
>
> are available in the git repository at:
>
> git:/
On 03/13/2017 12:11 AM, Stefan Hajnoczi wrote:
> The qemu-img sub-command executes regardless of invalid global options:
>
> $ qemu-img --foo info test.img
> qemu-img: unrecognized option '--foo'
> image: test.img
> ...
>
> The unrecognized option warning may be missed by the user. This
On 03/13/2017 02:15 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 03/11/2017 07:22 AM, Marc-André Lureau wrote:
>>> The type is not used at all yet. Add some tests to exercice it.
>>
>> s/exercice/exercise/
>>
>> I wonder if we need this patch at all.
>>
>> I've been thinking about a
Pavel Dovgalyuk writes:
> I also encountered icount problems with new MTTCG patches.
>
> Record/replay now cannot work, because iothread requests timers
> without kicking the CPU. And cpu thread updates icount (that
> are used for the clock).
The interaction of kicking the vCPU while grabbing t
Hi
- Original Message -
> On 03/13/2017 02:15 AM, Markus Armbruster wrote:
> > Eric Blake writes:
> >
> >> On 03/11/2017 07:22 AM, Marc-André Lureau wrote:
> >>> The type is not used at all yet. Add some tests to exercice it.
> >>
> >> s/exercice/exercise/
> >>
> >> I wonder if we need t
Public bug reported:
I've recently discovered, that in QEMU 2.8+ my Windows XP loading time
has significantly worsened. In 2.7 it took 30-40 second to boot, but in
2.8 it became 2-2,5 minutes.
I've used Git bisect, and found out that the change happened after
commit a9353fe897ca2687e5b3385ed39e3d
hi i want to know where the translation of branch instruction (arm) to tcg code
is located thanks
> @@ -97,6 +97,11 @@ glue(glue(cirrus_bitblt_rop_fwd_transp_,
> ROP_NAME),_8)(CirrusVGAState *s,
> uint8_t p;
> dstpitch -= bltwidth;
> srcpitch -= bltwidth;
> +
> +if (dstpitch < 0 || srcpitch < 0) {
> +return;
> +}
Shouldn't that be ...
if (bltheight > 1 && (
Le 27/02/2017 à 15:38, Alex Bennée a écrit :
>
> Laurent Vivier writes:
>
>> Le 24/02/2017 à 12:20, Alex Bennée a écrit :
>>> There are a couple of changes that occur at the same time here:
>>>
>>> - introduce a single vCPU qemu_tcg_cpu_thread_fn
>>>
>>> One of these is spawned per vCPU with
On 11.03.2017 22:53, Richard Henderson wrote:
> On 03/12/2017 04:30 AM, Helge Deller wrote:
>> Add the missing defines and for TARGET_MAP_STACK and TARGET_MAP_HUGETLB
>> for alpha, mips, ppc and x86, and fix the mmap_flags translation table
>> to translate those flags between host and target archit
Peter Maydell wrote:
> On 12 March 2017 at 21:45, Juan Quintela wrote:
>>
>>
>> Hi
>>
>> Please, send any topic that you are interested in covering.
>>
>> So far the agenda is:
>>
>> - Direction of QEMU and toolstack in light of Google Cloud blog:
>>
>> https://cloudplatform.googleblog.com/201
The arm64 boot protocol stipulates that the kernel must be loaded
TEXT_OFFSET bytes beyond a 2 MB aligned base address, where TEXT_OFFSET
could be any 4 KB multiple between 0 and 2 MB, and whose value can be
found in the header of the Image file.
So after attempts to load the arm64 kernel image as
On 13 March 2017 at 15:12, Juan Quintela wrote:
> Peter Maydell wrote:
>> [Making QEMU more modular would help with defeating the legacy
>> and back-compat dragons, though]
>
> That would be ideal, but where to start? Think of something as "simple"
> asd adding a struct of operations tha
ctpopl() has a better implementation than hweight_long() and ui/vnc.c
being the last user of hweight_long(), we can simply remove it.
Signed-off-by: Cédric Le Goater
---
include/qemu/bitops.h | 10 --
ui/vnc.c | 6 +++---
2 files changed, 3 insertions(+), 13 deletions(-)
d
On 13 March 2017 at 15:33, Cédric Le Goater wrote:
> ctpopl() has a better implementation than hweight_long() and ui/vnc.c
> being the last user of hweight_long(), we can simply remove it.
>
> Signed-off-by: Cédric Le Goater
Reviewed-by: Peter Maydell
thanks
-- PMM
On 13-Mar-17 08:21, Kevin Wolf wrote:
I think the state of the art is to give the VMs enough memory rather
Thanks Kevin. This was the answer I expected, so here follows my second
question:
By increasing virtual RAM, I'm afraid that the guest OS may detect and
use more memory, causing the host
From: Eric Blake
If bdrv_is_allocated() fails, we should immediately do the backup
error action, rather than attempting backup_do_cow() (although
that will likely fail too).
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/backup.c | 14 ++
1 file changed, 10 insertio
Add myself to MIPSSIM and new entry for Fulong 2E.
Add an entry for Boston machine (Paul Burton).
Signed-off-by: Yongbok Kim
cc: Paul Burton
---
MAINTAINERS | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e3edd04..d196f19 1006
From: Vladimir Sementsov-Ogievskiy
Currently backup to nbd target is broken, as nbd doesn't have
.bdrv_get_info realization.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/backup.c | 12 +++-
1 file changed, 11 insertions(+), 1
This fixes bdrv_co_get_block_status() for the bdrv_mirror_top block
driver, which must fall through to bs->backing instead of bs->file.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
in
The following changes since commit dd4d2578215cd380f40a38028a9904e15b135ef3:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-fixes-20170309-1' into
staging (2017-03-09 13:16:05 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you
From: Eric Blake
If bdrv_is_allocated() fails, we should react to that failure.
For 2 of the 3 callers, reporting the error was easy. But in
cluster_was_modified() and its lone caller
get_cluster_count_for_direntry(), it's rather invasive to update
the logic to pass the error back; so there, I w
In bdrv_open_inherit(), the filename is refreshed after opening the
backing file, but we neglected to do the same when the backing file
changes later.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block.c b/block.c
index dd38
We want query-block to return the right filename, even if a commit job
put a bdrv_commit_top on top of the actual image format driver. Let
bdrv_commit_top.bdrv_refresh_filename get the filename from its backing
file.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/commit.c | 8 +
From: Fam Zheng
BlockLimits.max_transfer can be too high without this fix, guest will
encounter I/O error or even get paused with werror=stop or rerror=stop. The
cause is explained below.
Linux has a separate limit, /sys/block/.../queue/max_segments, which in
the worst case can be more restricti
From: Eric Blake
Migration is the only code left in the tree that does not react
to bdrv_is_allocated() failures. But as there is no useful way
to react to the failure, and we are merely skipping unallocated
sectors on success, just document that our choice of handling
is intended.
Signed-off-b
In some cases, bdrv_co_get_block_status() is called recursively for the
whole backing chain. The automatically inserted bdrv_commit_top filter
driver must not stop the recursion, so implement a callback that simply
forwards the request to bs->backing.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric B
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote:
> this fixes many warnings like:
>
> target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never read
> rn = "invalid sel";
> ^~
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philipp
All callers pass false now, so the parameter can go away again.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/block.c b/block.c
index b404ef2..dd38e71 100644
--- a/block.c
+++ b/block.c
@@
Hi Gerd,
Thanks for rapid reply :)
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Monday, March 13, 2017 9:55 PM
> To: Hangaohuai
> Cc: qemu-devel@nongnu.org; fangying; Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH] fix :cirrus_vga fix OOB read case qem
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Makefile.objs| 1 +
> target/mips/trace-events | 5 +
> target/mips/translate.c | 25 +++--
> 3 files changed, 17 insertions(+), 14 deletions(-)
> create mo
On 04/03/2017 18:56, Philippe Mathieu-Daudé wrote:
> static code analyzer complain:
>
> target/mips/helper.c:453:5: warning: Function call argument is an
> uninitialized value
> qemu_log_mask(CPU_LOG_MMU,
> ^~
>
> 'physical' and 'prot' are uninitialized if 'ret'
We want query-block to return the right filename, even if a mirror job
put a bdrv_mirror_top on top of the actual image format driver. Let
bdrv_mirror_top.bdrv_refresh_filename get the filename from its backing
file.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/mirror.c | 9 +
1 - 100 of 290 matches
Mail list logo
