Re: [Qemu-devel] [PATCH v10 0/8] the reset of msix_init series

2017-03-06 Thread Cao jin
Michael, Is this series ok for 2.9? -- Sincerely, Cao jin On 02/25/2017 04:26 PM, Cao jin wrote: > v10 changelog: > 1. drop the unliked patch, introduce a new patch 1 according to mst's > comments. > 2. base on the new patch, remove the following statements > > /* Any error other than

[Qemu-devel] [PULL for-2.9 3/3] tests: check path to avoid a failing qga/get-vcpus test

2017-03-06 Thread Michael Roth
From: Bruce Rogers The qga/get-vcpus test fails in a simple chroot environment, as used in an openSUSE Build Service local build, so first check that the sysfs based path exists in order to avoid calling this test in an environment where it won't work right. Signed-off-by: Bruce Rogers Reviewed

[Qemu-devel] [PULL for-2.9 0/3] qemu-ga patch queue for 2.9

2017-03-06 Thread Michael Roth
The following changes since commit 17783ac828adc694d986698d2d7014aedfeb48c6: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.9-20170303' into staging (2017-03-04 16:31:14 +) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2017-03-06-ta

[Qemu-devel] [PULL for-2.9 2/3] qga: ignore EBUSY when freezing a filesystem

2017-03-06 Thread Michael Roth
From: Peter Lieven the current implementation fails if we try to freeze an already frozen filesystem. This can happen if a filesystem is mounted more than once (e.g. with a bind mount). Suggested-by: Christian Theune Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Paolo Bon

[Qemu-devel] [PULL for-2.9 1/3] qga: add systemd socket activation support

2017-03-06 Thread Michael Roth
From: Stefan Hajnoczi AF_UNIX and AF_VSOCK listen sockets can be passed in by systemd on startup. This allows systemd to manage the listen socket until the first client connects and between restarts. Advantages of socket activation are that parallel startup of network services becomes possible

Re: [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history

2017-03-06 Thread Markus Armbruster
Nir Soffer writes: > On Fri, Mar 3, 2017 at 9:29 PM, John Snow wrote: >> >> >> On 03/03/2017 02:26 PM, Nir Soffer wrote: >>> On Fri, Mar 3, 2017 at 8:54 PM, John Snow wrote: Use the existing readline history function we are utilizing to provide persistent command history across instan

Re: [Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell

2017-03-06 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The qmp-shell property parser currently rejects attempts to > set string properties to the empty string eg > > (QEMU) migrate-set-parameters tls-hostname= > Error while parsing command line: Expected a key=value pair, got > 'tls-hostname=' > command format:

[Qemu-devel] [PATCH v2 0/2] 9pfs: fix vulnerability and build break

2017-03-06 Thread Greg Kurz
The "9pfs: fix vulnerability in openat_dir() and local_unlinkat_common()" was sent to add the missing O_NOFOLLOW flag and drop O_PATH, which causes build breaks with older versions of glibc. Eric Blake pointed out during review that O_PATH could be kept: https://lists.nongnu.org/archive/html/qemu

[Qemu-devel] [PATCH v2 1/2] 9pfs: fix O_PATH build break with older glibc versions

2017-03-06 Thread Greg Kurz
When O_PATH is used with O_DIRECTORY, it only acts as an optimization: the openat() syscall simply finds the name in the VFS, and doesn't trigger the underlying filesystem. On systems that don't define O_PATH, because they have glibc version 2.13 or older for example, we can safely omit it. We don

[Qemu-devel] [PATCH v2 2/2] 9pfs: fix vulnerability in openat_dir() and local_unlinkat_common()

2017-03-06 Thread Greg Kurz
We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make QEMU vulnerable. While here, we also fix local_unlinkat_common() to use openat_dir() for the same reasons (it was a leftover in the original patchset actually). This fixes CVE-2016-9602. Signed-off-by: Greg Kurz Reviewed

[Qemu-devel] [PATCH] qxl: clear guest_cursor on QXL_CURSOR_HIDE

2017-03-06 Thread Gerd Hoffmann
Make sure we don't leave guest_cursor pointing into nowhere. This might lead to (rare) live migration failures, due to target trying to restore the cursor from the stale pointer. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1421788 Reported-by: Dr. David Alan Gilbert Signed-off-by: Gerd

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-03-06 Thread Dr. David Alan Gilbert
* Bruce Rogers (brog...@suse.com) wrote: > >>> On 2/6/2017 at 4:57 AM, wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> > >> > >> On 03/02/2017 07:00, Stefan Hajnoczi wrote: > >> > On Thu, Feb 02, 2017 at 07:05:30AM ‑0800, Paolo Bonzini wrote: > >> >> The replication feature is a sma

Re: [Qemu-devel] Patch causes Mac OS X to print dead controller messages

2017-03-06 Thread Gerd Hoffmann
On Mi, 2017-03-01 at 23:08 -0500, Programmingkid wrote: > commit 95ed56939eb2eaa4e2f349fe6dcd13ca4edfd8fb > usb: ohci: limit the number of link eds > > This patch causes Mac OS X to continuously print this message: > USBF: 35.508 AppleUSBOHCI[0x1187000] Watchdog detected dead controller (hcca > #

Re: [Qemu-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

2017-03-06 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 03 March 2017 20:43 > To: Stefano Stabellini > Cc: Paul Durrant ; xen-de...@lists.xenproject.org; > qemu-devel@nongnu.org; Anthony Perard > Subject: RE: [PATCH v2 5/5] xen: use libxendevicemodel when a

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-03-06 Thread Daniel P. Berrange
On Sun, Mar 05, 2017 at 04:26:05PM -0800, ashish mittal wrote: > On Wed, Mar 1, 2017 at 1:18 AM, Daniel P. Berrange > wrote: > > > > Yes, that's how other parts of QEMU deal with SSL > > > > NB, QEMU needs to pass 3 paths to libqnoio - the client cert, the > > client key, and the certificate auth

Re: [Qemu-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

2017-03-06 Thread Paul Durrant
> -Original Message- > From: Qemu-devel [mailto:qemu-devel- > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant > Sent: 06 March 2017 09:15 > To: 'Stefano Stabellini' > Cc: Anthony Perard ; xen- > de...@lists.xenproject.org; qemu-devel@nongnu.org > Subject: Re: [Qemu-de

Re: [Qemu-devel] versatilepb cannot load roofs

2017-03-06 Thread Peter Maydell
On 5 March 2017 at 07:57, Jiahuan Zhang wrote: > Dear QEMU developers, > > I have a problem when running qemu to build a system with versatilepb, > linux zImage and rootfs. the qemu cmdl is as follows. > > ../qemu/build/arm-softmmu/qemu-system-arm.exe -M versatilepb -kernel zImage > -dtb versatile

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-06 Thread David Gibson
On Mon, Mar 06, 2017 at 08:56:07AM +0100, Cédric Le Goater wrote: > On 03/06/2017 12:23 AM, David Gibson wrote: > > On Fri, Mar 03, 2017 at 06:23:15PM +0100, Cédric Le Goater wrote: > >> On 03/03/2017 05:54 PM, Thomas Huth wrote: > >>> On 03.03.2017 15:49, Cédric Le Goater wrote: > On 03/03/20

Re: [Qemu-devel] [PATCH v2 00/11] MTTCG fixups for 2.9

2017-03-06 Thread Alex Bennée
Frederic Konrad writes: > Hi All, > > I've a strangeness with the "drop iolock" patch. > It seems it has an impact on the MMIO execution patch-set I'm working > on: Hmm the only real change is the BQL (implicit or explict) being taken on entry to the mmio functions. > Basically modifying the m

Re: [Qemu-devel] [PATCH v2] spapr_pci: allow control of BAR alignment through SLOF

2017-03-06 Thread David Gibson
On Sun, Mar 05, 2017 at 11:44:54PM -0600, Michael Roth wrote: > Quoting David Gibson (2017-03-05 22:16:58) > > On Fri, Mar 03, 2017 at 05:32:57PM -0600, Michael Roth wrote: > > > In certain cases, such as PCI-passthrough with VFIO, we cannot offload > > > MMIO accesses to KVM unless the BAR alignme

Re: [Qemu-devel] [PATCH 2/3] hw/arm/exynos4210: Constify data pointed by few arguments and variables

2017-03-06 Thread Peter Maydell
On 5 March 2017 at 21:48, Krzysztof Kozlowski wrote: > In few places the function arguments and local variables are not > modifying data passed through pointers so this can be made const for > code safeness. Also the static array exynos4210_uart_regs is not being > modified. > > Signed-off-by: Kr

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 04:06, Philippe Mathieu-Daudé wrote: > your change seems OK but while you are here, 'unsigned' is considered > harmful since more than a decade. Considered harmful by who, and why? thanks -- PMM

Re: [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 07:00, Thomas Huth wrote: > Note: In case you respin the series, you might want to add this > CONFIG_SM501 to ppc64-softmmu.mak, too, since it is a superset of the > 32-bit config (i.e. it can also emulate the 32-bit embedded chips). Yes, definitely do this please. (Missed this

Re: [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets

2017-03-06 Thread Thomas Huth
On 06.03.2017 10:47, Peter Maydell wrote: > On 6 March 2017 at 07:00, Thomas Huth wrote: >> Note: In case you respin the series, you might want to add this >> CONFIG_SM501 to ppc64-softmmu.mak, too, since it is a superset of the >> 32-bit config (i.e. it can also emulate the 32-bit embedded chips)

[Qemu-devel] [Bug 1289788] Re: MIDI access (not only adlib) hangs WinNT on QEMU 1.7.x

2017-03-06 Thread Thomas Huth
Is this problem still reproducible with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1289788 Title: MIDI access (n

Re: [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 09:52, Thomas Huth wrote: > I guess we could do something like that on ppc, too (and ppc-softmmu.mak > should likely include ppcemb-softmmu.mak), but > that's something for QEMU 2.10 / 3.0 / whichever version will be next. Yeah, definitely 2.10 material (so is this whole series

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-03-06 Thread Zhang Chen
On 03/06/2017 05:08 PM, Dr. David Alan Gilbert wrote: * Bruce Rogers (brog...@suse.com) wrote: On 2/6/2017 at 4:57 AM, wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: On 03/02/2017 07:00, Stefan Hajnoczi wrote: On Thu, Feb 02, 2017 at 07:05:30AM ‑0800, Paolo Bonzini wrote: The replic

Re: [Qemu-devel] [PATCH v2 06/11] sparc/sparc64: grab BQL before calling cpu_check_irqs

2017-03-06 Thread Alex Bennée
Paolo Bonzini writes: > On 02/03/2017 20:53, Alex Bennée wrote: >> IRQ modification is part of device emulation and should be done while >> the BQL is held to prevent races when MTTCG is enabled. This adds >> assertions in the hw emulation layer and wraps the calls from helpers >> in the BQL. >>

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-06 Thread Peter Maydell
On 4 March 2017 at 22:58, BALATON Zoltan wrote: > On Sat, 4 Mar 2017, Peter Maydell wrote: >> Right, but we should test the PCI-on-a-little-endian CPU >> case, because right now your code has #ifdef TARGET_WORDS_BIGENDIAN >> in it which means that the PCI device will behave differently >> on big a

Re: [Qemu-devel] [PATCH v4 06/13] sm501: Add emulation of chip connected via PCI

2017-03-06 Thread Peter Maydell
On 25 February 2017 at 18:31, BALATON Zoltan wrote: > Only the display controller part is created automatically on PCI > > Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] qxl: clear guest_cursor on QXL_CURSOR_HIDE

2017-03-06 Thread Marc-André Lureau
On Mon, Mar 6, 2017 at 12:32 PM Gerd Hoffmann wrote: > Make sure we don't leave guest_cursor pointing into nowhere. This might > lead to (rare) live migration failures, due to target trying to restore > the cursor from the stale pointer. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [Qemu-devel] [PATCH v4 04/13] sm501: QOMify

2017-03-06 Thread Peter Maydell
On 3 December 2016 at 02:05, BALATON Zoltan wrote: > Adding vmstate saving is not in this patch because the state structure > will be changed in further patches, then another patch will add > vmstate descriptor after those changes. > > Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell t

Re: [Qemu-devel] [PATCH v4 08/13] sm501: Fix hardware cursor

2017-03-06 Thread Peter Maydell
On 4 December 2016 at 18:01, BALATON Zoltan wrote: > Rework HWC handling to simplify it and fix cursor not updating on > screen as needed. Previously cursor was not updated because checking > for changes in a line overrode the update flag set for the cursor but > fixing this is not enough because

Re: [Qemu-devel] [PATCH] target/mips: hold BQL for timer interrupts

2017-03-06 Thread Alex Bennée
Yongbok Kim writes: > Hold BQL when accessing timer which can cause interrupts > > Signed-off-by: Yongbok Kim Thanks, applied to my tree. > --- > target/mips/op_helper.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/target/mips/op_helper.c b/

Re: [Qemu-devel] [PATCH v2 00/11] MTTCG fixups for 2.9

2017-03-06 Thread Frederic Konrad
On 03/06/2017 10:43 AM, Alex Bennée wrote: > > Frederic Konrad writes: > >> Hi All, >> >> I've a strangeness with the "drop iolock" patch. >> It seems it has an impact on the MMIO execution patch-set I'm working >> on: > > Hmm the only real change is the BQL (implicit or explict) being taken on

Re: [Qemu-devel] [PATCH v2] qmp-shell: add persistent command history

2017-03-06 Thread Kashyap Chamarthy
On Mon, Mar 06, 2017 at 09:18:29AM +0100, Markus Armbruster wrote: > Nir Soffer writes: > > > On Fri, Mar 3, 2017 at 9:29 PM, John Snow wrote: [...] > class QMPCompleter(list): > def complete(self, text, state): > @@ -109,6 +112,7 @@ class QMPShell(qmp.QEMUMonitorProtocol)

[Qemu-devel] [PATCH] docker/dockerfiles/debian-s390-cross: include clang

2017-03-06 Thread Alex Bennée
It's a silly little limitation on Shippable that is looks for clang in the container even though we won't use it. The arm/aarch64 cross builds inherit this from debian.docker but as we needed to use debian-testing for this we add it here. We also collapse the update step into one RUN line to remove

Re: [Qemu-devel] [PATCH] target/mips: hold BQL for timer interrupts

2017-03-06 Thread Philippe Mathieu-Daudé
On Fri, Mar 3, 2017 at 8:20 AM, Yongbok Kim wrote: > Hold BQL when accessing timer which can cause interrupts > > Signed-off-by: Yongbok Kim Reviewed-by: Philippe Mathieu-Daudé > --- > target/mips/op_helper.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > d

Re: [Qemu-devel] [PATCH v4 07/13] sm501: Fix device endianness

2017-03-06 Thread Peter Maydell
On 25 February 2017 at 18:46, BALATON Zoltan wrote: > We only emulate the sysbus device in its default LE mode and PCI is LE > as well so specify this for registers. Colors were also off on both > SH4 and PPC which is also fixed here. > diff --git a/hw/display/sm501_template.h b/hw/display/sm501_

Re: [Qemu-devel] [PATCH 2/2] vl: Print CPU help after we've registered the CPU accelerators

2017-03-06 Thread Eduardo Habkost
On Mon, Mar 06, 2017 at 10:06:27AM +1100, David Gibson wrote: > On Fri, Mar 03, 2017 at 11:58:07AM -0300, Eduardo Habkost wrote: > > On Tue, Jan 31, 2017 at 02:11:59PM +0100, Thomas Huth wrote: > > > When running with KVM on POWER, we register some CPU types during > > > the initialization function

[Qemu-devel] [RFC v2 0/3] vITS save/restore

2017-03-06 Thread Eric Auger
This series allows ITS save/restore and migration use cases. It relies on not upstreamed kernel series [1]. ITS tables are flushed into guest RAM on VM stop while registers are save on pre_save() callback. Tables and registers are restored on ITS post_load(). That work was tested on Cavium Thunde

[Qemu-devel] [RFC v2 1/3] linux-headers: Update for vITS save/restore

2017-03-06 Thread Eric Auger
This is a linux header update against 4.11-rc1 plus the non upstreamed ITS migration series. https://github.com/eauger/linux/tree/v4.11-rc1-its-mig-v3 It aims at enhancing the KVM user API with vITS save/restore capability. This consists in two new groups for the ARM_VGIC_ITS KVM device, named: K

[Qemu-devel] [RFC v2 2/3] hw/intc/arm_gicv3_its: Implement state save/restore

2017-03-06 Thread Eric Auger
We need to handle both registers and ITS tables. While register handling is standard, ITS table handling is more challenging since the kernel API is devised so that the tables are flushed into guest RAM and not in vmstate buffers. Flushing the ITS tables on device pre_save() is too late since the

[Qemu-devel] [RFC v2 3/3] hw/intc/arm_gicv3_its: Allow save/restore

2017-03-06 Thread Eric Auger
We change the restoration priority of both the GICv3 and ITS. The GICv3 must be restored before the ITS and the ITS needs to be restored before PCIe devices since it translates their MSI transactions. We typically observe the virtio-pci-net device sending MSI transactions very early (even before t

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

2017-03-06 Thread Eduardo Habkost
Hi, On Sun, Mar 05, 2017 at 11:46:33PM +0200, Krzysztof Kozlowski wrote: > In few places the function arguments and local variables are not > modifying data passed through pointers so this can be made const for > code safeness. > > Signed-off-by: Krzysztof Kozlowski I believe most changes belo

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-03-06 Thread Paolo Bonzini
On 06/03/2017 11:03, Zhang Chen wrote: > > > On 03/06/2017 05:08 PM, Dr. David Alan Gilbert wrote: >> * Bruce Rogers (brog...@suse.com) wrote: >> On 2/6/2017 at 4:57 AM, wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 03/02/2017 07:00, Stefan Hajnoczi wrote: >>

Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables

2017-03-06 Thread Paolo Bonzini
On 06/03/2017 13:09, Eduardo Habkost wrote: >> >> -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t >> *value) >> +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, >> + const uint8_t *value) > This one makes sense to me. Indeed. K

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability

2017-03-06 Thread Paolo Bonzini
On 06/03/2017 10:46, Peter Maydell wrote: > On 6 March 2017 at 04:06, Philippe Mathieu-Daudé wrote: >> your change seems OK but while you are here, 'unsigned' is considered >> harmful since more than a decade. > > Considered harmful by who, and why? It is true that unsigned has all the disadva

Re: [Qemu-devel] [PULL v2 00/27] QAPI patches for 2017-02-28

2017-03-06 Thread Peter Maydell
On 5 March 2017 at 08:35, Markus Armbruster wrote: > The following changes since commit 17783ac828adc694d986698d2d7014aedfeb48c6: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.9-20170303' > into staging (2017-03-04 16:31:14 +) > > are available in the git repository at: >

Re: [Qemu-devel] -rtc clock=vm with -icount 1, sleep=off introduces unexpected delays in device interactions

2017-03-06 Thread Alex Bennée
Frédéric Konrad writes: > Hi Jim, > > I think Alex and Paolo worked on an mttcg/icount issue. > Not sure if its related or not. If you are running a tree post-MTTCG merge you will need to add Paolo's patches: Subject: [PATCH 0/6] tcg: fix icount super slowdown Date: Fri, 3 Mar 2017 14:11:

Re: [Qemu-devel] Qemu deadlocks in tb_lock when using SVM+SoftMMU

2017-03-06 Thread Alex Bennée
Alexander Boettcher writes: > Hello, > > beginning with commit 3bd1d74576bacb120949e13cdeded7a0c792c685 > > "cputlb: introduce tlb_flush_* async work" > > using Qemu with SoftMMU+SVM virtualization deadlocks because tb_lock is > taken second time in cputlb.c tlb_flush_nocheck() function. The fir

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 13:03, Paolo Bonzini wrote: > > > On 06/03/2017 10:46, Peter Maydell wrote: >> On 6 March 2017 at 04:06, Philippe Mathieu-Daudé wrote: >>> your change seems OK but while you are here, 'unsigned' is considered >>> harmful since more than a decade. >> >> Considered harmful by who

Re: [Qemu-devel] Qemu deadlocks in tb_lock when using SVM+SoftMMU

2017-03-06 Thread Alexander Boettcher
Hi, On 06.03.2017 14:15, Alex Bennée wrote: > I found the virtualbox.iso on your branch but I can't trigger the > assert. Running: > > #!/bin/sh > > QEMU="$@" > > ${QEMU} -s -no-kvm -display sdl -m 512 -cpu phenom -nographic -cdrom > virtualbox.iso > > I get: > > NOVA Microhypervisor v7-2436

Re: [Qemu-devel] [PATCH v2 06/11] sparc/sparc64: grab BQL before calling cpu_check_irqs

2017-03-06 Thread Paolo Bonzini
On 06/03/2017 11:28, Alex Bennée wrote: >> This can be called from gdbstub, so you need to put the lock/unlock >> around helper_wrpsr's call to cpu_put_psr instead. Also please add a >> comment /* Called with BQL held. */ around cpu_put_psr. > > OK will do. I have to say its hard to see the gd

Re: [Qemu-devel] [PATCH v7 kernel 5/5] This patch contains two parts:

2017-03-06 Thread David Hildenbrand
Am 03.03.2017 um 06:40 schrieb Wei Wang: > From: Liang Li I'd prefer to split this into two parts then and to create proper subjects. If I remember correctly, the general concept was accepted by most reviewers. > > One is to add a new API to mm go get the unused page information. > The virtio

Re: [Qemu-devel] [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability

2017-03-06 Thread Philippe Mathieu-Daudé
On 03/06/2017 10:16 AM, Peter Maydell wrote: On 6 March 2017 at 13:03, Paolo Bonzini wrote: On 06/03/2017 10:46, Peter Maydell wrote: On 6 March 2017 at 04:06, Philippe Mathieu-Daudé wrote: your change seems OK but while you are here, 'unsigned' is considered harmful since more than a decade

[Qemu-devel] [PATCH] Fix the vm state after vm migration when vm panic

2017-03-06 Thread hangaohuai
Bug steps: 1. windows VM with pvpanic device:in xml 2. inject the panic in windows, the vm state is paused (guest-panicked) 3. migrate the vm to other host, vm state is running Check the vmstate before runstate_set(RUN_STATE_RUNNING) Signed-off-by: hangaohuai --- cpus.c | 3 +++

[Qemu-devel] [PULL v2 16/24] monitor: Assert qmp_schema_json[] is sane

2017-03-06 Thread Markus Armbruster
qmp_query_qmp_schema() parses qmp_schema_json[] with qobject_from_json(). This must not fail, so pass &error_abort. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-17-git-send-email-arm...@redhat.com> --- monitor.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PULL v2 06/24] qapi: Factor out common part of qobject input visitor creation

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-7-git-send-email-arm...@redhat.com> --- qapi/qobject-input-visitor.c | 61 +++- 1 file changed, 26 insertions(+), 35 deletions(-) diff --git a/qapi/qobject-input-visito

[Qemu-devel] [PULL v2 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse

2017-03-06 Thread Markus Armbruster
Ignoring errors first, then asserting success is suboptimal. Pass &error_abort instead, so we abort earlier, and hopefully get more useful clues on what's wrong. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-11-git-send-email-arm...@redhat.com> --- qobj

[Qemu-devel] [PULL v2 11/24] test-qobject-input-visitor: Abort earlier on bad test input

2017-03-06 Thread Markus Armbruster
visitor_input_test_init_internal() parses test input with qobject_from_jsonv(), and asserts it succeeds. Pass &error_abort for good measure. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-12-git-send-email-arm...@redhat.com> --- tests/test-qobject-input-

[Qemu-devel] [PULL v2 05/24] test-keyval: Cover use with qobject input visitor

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-6-git-send-email-arm...@redhat.com> --- tests/test-keyval.c | 312 1 file changed, 312 insertions(+) diff --git a/tests/test-keyval.c b/tests/test-keyval.c

[Qemu-devel] [PULL v2 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no"

2017-03-06 Thread Markus Armbruster
qemu_opts_parse() interprets "no" as negated empty key. Consistent with its acceptance of empty keys elsewhere, whatever that's worth. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-2-git-send-email-arm...@redhat.com> --- tests/test-qemu-opts.c | 5 +

[Qemu-devel] [PULL v2 08/24] qobject: Propagate parse errors through qobject_from_jsonv()

2017-03-06 Thread Markus Armbruster
The next few commits will put the errors to use where appropriate. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-9-git-send-email-arm...@redhat.com> --- include/qapi/qmp/qjson.h | 3 ++- qobject/qjson.c| 12 te

[Qemu-devel] [PULL v2 17/24] test-qapi-util: New, covering qapi/qapi-util.c

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-18-git-send-email-arm...@redhat.com> --- tests/.gitignore | 1 + tests/Makefile.include | 3 +++ tests/test-qapi-util.c | 51 ++ 3 files changed, 55 inse

[Qemu-devel] [PULL v2 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-3-git-send-email-arm...@redhat.com> --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include i

[Qemu-devel] [PULL v2 07/24] qapi: Factor out common qobject_input_get_keyval()

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1488317230-26248-8-git-send-email-arm...@redhat.com> --- qapi/qobject-input-visitor.c | 87 ++-- 1 file changed, 35 insertions(+), 52 deletions(-) diff --git a/qapi/qobject-input-visito

[Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev

2017-03-06 Thread Markus Armbruster
Actually, the command line option is the least part of this series. Its bulk is about building infrastructure and getting errors out of the JSON parser. The design of the command line interface was discussed here: Subject: Non-flat command line option argument syntax Message-ID: <87bmukmlau@du

[Qemu-devel] [PULL v2 03/24] keyval: New keyval_parse()

2017-03-06 Thread Markus Armbruster
keyval_parse() parses KEY=VALUE,... into a QDict. Works like qemu_opts_parse(), except: * Returns a QDict instead of a QemuOpts (d'oh). * Supports nesting, unlike QemuOpts: a KEY is split into key fragments at '.' (dotted key convention; the block layer does something similar on top of QemuO

[Qemu-devel] [PULL v2 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-10-git-send-email-arm...@redhat.com> --- tests/libqtest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 9033c5f..a5c3d2b 100644 --- a/tests/lib

[Qemu-devel] [PULL v2 12/24] qobject: Propagate parse errors through qobject_from_json()

2017-03-06 Thread Markus Armbruster
The next few commits will put the errors to use where appropriate. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-Id: <1488317230-26248-13-git-send-email-arm...@redhat.com> --- block.c| 2 +- include/qapi/qmp/qjson.h

[Qemu-devel] [PULL v2 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()

2017-03-06 Thread Markus Armbruster
qmp_deserialize() calls qobject_from_json() ignoring errors. It passes the result to qobject_input_visitor_new(), which asserts it's not null. Therefore, we can just as well pass &error_abort to qobject_from_json(). Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <14883172

[Qemu-devel] [PULL v2 20/24] qapi: New qobject_input_visitor_new_str() for convenience

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <1488317230-26248-21-git-send-email-arm...@redhat.com> --- include/qapi/qobject-input-visitor.h | 12 qapi/qobject-input-visitor.c | 36 2 files changed, 48 insertions(+) diff --git a/include/q

[Qemu-devel] [PULL v2 13/24] block: More detailed syntax error reporting for JSON filenames

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-14-git-send-email-arm...@redhat.com> --- block.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 5ef5c7c..fe7bddb 100644 --- a/block.c +++ b/block.c @@ -126

[Qemu-devel] [PULL v2 24/24] keyval: Support lists

2017-03-06 Thread Markus Armbruster
Additionally permit non-negative integers as key components. A dictionary's keys must either be all integers or none. If all keys are integers, convert the dictionary to a list. The set of keys must be [0,N]. Examples: * list.1=goner,list.0=null,list.1=eins,list.2=zwei is equivalent to JSON

[Qemu-devel] [PULL v2 23/24] docs/qapi-code-gen.txt: Clarify naming rules

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-24-git-send-email-arm...@redhat.com> --- docs/qapi-code-gen.txt | 61 -- 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/docs/qapi-code-gen.txt b

[Qemu-devel] [PULL v2 22/24] qapi: Improve how keyval input visitor reports unexpected dicts

2017-03-06 Thread Markus Armbruster
Incorrect option -blockdev node-name=foo,driver=file,filename=foo.img,aio.unmap=on is rejected with "Invalid parameter type for 'aio', expected: string". To make sense of this, you almost have to translate it into the equivalent QMP command { "execute": "blockdev-add", "arguments": { "no

[Qemu-devel] [PULL v2 18/24] qapi: New parse_qapi_name()

2017-03-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1488317230-26248-19-git-send-email-arm...@redhat.com> --- include/qapi/util.h| 2 ++ qapi/qapi-util.c | 47 +++ tests/test-qapi-util.c | 34 +++

[Qemu-devel] [PULL v2 21/24] block: Initial implementation of -blockdev

2017-03-06 Thread Markus Armbruster
The new command line option -blockdev works like QMP command blockdev-add. The option argument may be given in JSON syntax, exactly as in QMP. Example usage: -blockdev '{"node-name": "foo", "driver": "raw", "file": {"driver": "file", "filename": "foo.img"} }' The JSON argument doesn't exact

[Qemu-devel] [PATCH 1/2] sm501: drop support for anything but 32bpp

2017-03-06 Thread Gerd Hoffmann
The qemu console code hands out 32bpp display surfaces only, when using qemu_console_resize or qemu_create_displaysurface (which sm501 does). So there is no need to ever generate other output. Drop the code. Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 89 +++---

[Qemu-devel] [PATCH 0/2] sm501: drop obsolete code

2017-03-06 Thread Gerd Hoffmann
Hi, This little series drops a bunch of code which is not needed any more. Nowdays qemu console only uses 32bpp surfaces. BALATON, this should simplify your job of getting the pixel conversions right. Feel free to add this to your series. Gerd Hoffmann (2): sm501: drop support for anything

[Qemu-devel] [PULL v2 04/24] qapi: qobject input visitor variant for use with keyval_parse()

2017-03-06 Thread Markus Armbruster
From: "Daniel P. Berrange" Currently the QObjectInputVisitor assumes that all scalar values are directly represented as the final types declared by the thing being visited. i.e. it assumes an 'int' is using QInt, and a 'bool' is using QBool, etc. This is good when QObjectInputVisitor is fed a QO

[Qemu-devel] [PATCH 2/2] sm501: drop sm501_template.h

2017-03-06 Thread Gerd Hoffmann
Now that we include sm501_template.h only once there is no need to keep this stuff in a separate file. FIXME: as peter mentioned the TARGET_WORDS_BIGENDIAN dependency looks suspious. Left as-is for now. Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 110 +

[Qemu-devel] [PULL v2 14/24] check-qjson: Test errors from qobject_from_json()

2017-03-06 Thread Markus Armbruster
Pass &error_abort with known-good input. Else pass &err and check what comes back. This demonstrates that the parser fails silently for many errors. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id: <1488317230-26248-15-git-send-email-arm...@redhat.com> --- tests/check-qjso

[Qemu-devel] [PULL v2 19/24] keyval: Restrict key components to valid QAPI names

2017-03-06 Thread Markus Armbruster
Restricting the key components to something sane leaves us room for evolving key syntax. Since they will be commonly used as QAPI member names by the QObject input visitor, we can just as well borrow the QAPI naming rules here. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Message-Id

Re: [Qemu-devel] [PATCH 0/2] sm501: drop obsolete code

2017-03-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1488810230-31945-1-git-send-email-kra...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] sm501: drop obsolete code Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(g

[Qemu-devel] Qemu and CPU wait time

2017-03-06 Thread Peter Lieven
Hi, is there something equivalent to "CPU ready" in VMWare or „Hyper-V Hypervisor Virtual Processor\CPU Wait Time Per Dispatch“ in Hyper-V in KVM/Qemu? Thanks, Peter

Re: [Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev

2017-03-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1488809515-4047-1-git-send-email-arm...@redhat.com Subject: [Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] Qemu deadlocks in tb_lock when using SVM+SoftMMU

2017-03-06 Thread Alex Bennée
Alexander Boettcher writes: > Hi, > > On 06.03.2017 14:15, Alex Bennée wrote: >> I found the virtualbox.iso on your branch but I can't trigger the >> assert. Running: >> >> #!/bin/sh >> >> QEMU="$@" >> >> ${QEMU} -s -no-kvm -display sdl -m 512 -cpu phenom -nographic -cdrom >> virtualbox.iso >>

[Qemu-devel] [Bug 1670377] Re: VNC: short read for zlre data/RDR EndOfStream

2017-03-06 Thread Michal Nowak
** Attachment added: "Video record" https://bugs.launchpad.net/qemu/+bug/1670377/+attachment/4832319/+files/video.ogv -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1670377 Title: VNC: short re

[Qemu-devel] [Bug 1670377] [NEW] VNC: short read for zlre data/RDR EndOfStream

2017-03-06 Thread Michal Nowak
Public bug reported: In openQA we have a custom VNC client (https://github.com/os-autoinst /os-autoinst/tree/master/consoles), which connects to QEMU guest and from there performs actions (sends keys, handles pointer, ...). We have several backends (https://github.com/os-autoinst/os- autoinst/tree

Re: [Qemu-devel] [PATCH 1/1] virtio-blk: fix race on guest notifiers

2017-03-06 Thread Paolo Bonzini
On 03/03/2017 20:43, Halil Pasic wrote: > Uh, this is complicated. I'm not out of questions, but I fear taking to > much of your precious time. I will ask again nevertheless, but please > just cut the conversation with -EBUSY if it gets to expensive. It's the opposite! I need other people to lo

Re: [Qemu-devel] [PATCH 1/1] virtio: fail device if set_event_notifier fails

2017-03-06 Thread Cornelia Huck
On Fri, 3 Mar 2017 14:08:37 +0100 Halil Pasic wrote: > On 03/03/2017 01:50 PM, Cornelia Huck wrote: > > On Fri, 3 Mar 2017 13:43:32 +0100 > > Halil Pasic wrote: > > > >> On 03/03/2017 01:21 PM, Cornelia Huck wrote: > >>> On Thu, 2 Mar 2017 19:59:42 +0100 > >>> Halil Pasic wrote: > >>> >

Re: [Qemu-devel] [PATCH 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet

2017-03-06 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 03/02/2017 03:44 PM, Markus Armbruster wrote: >>> QAPI type SocketAddressFlat differs from SocketAddress pointlessly: >>> the discriminator value for variant InetSocketAddress is 'tcp' instead >>> of 'inet'. Rename. >>> >>> The type is far

Re: [Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 14:11, Markus Armbruster wrote: > Actually, the command line option is the least part of this series. > Its bulk is about building infrastructure and getting errors out of > the JSON parser. > > The design of the command line interface was discussed here: > Subject: Non-flat com

Re: [Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 15:06, Peter Maydell wrote: > On 6 March 2017 at 14:11, Markus Armbruster wrote: >> Actually, the command line option is the least part of this series. >> Its bulk is about building infrastructure and getting errors out of >> the JSON parser. >> >> The design of the command lin

Re: [Qemu-devel] [PATCH v10 0/8] the reset of msix_init series

2017-03-06 Thread Michael S. Tsirkin
On Mon, Mar 06, 2017 at 04:10:42PM +0800, Cao jin wrote: > Michael, > Is this series ok for 2.9? > > -- > Sincerely, > Cao jin I'll consider it for 2.10. Sorry it's taking a long time, the benefit here is rather small so I don't see a reason to hurry. > On 02/25/2017 04:26 PM, Cao jin wrote: >

Re: [Qemu-devel] Qemu deadlocks in tb_lock when using SVM+SoftMMU

2017-03-06 Thread Alexander Boettcher
Hi, On 06.03.2017 15:42, Alex Bennée wrote: > > Alexander Boettcher writes: > >> Hi, >> >> On 06.03.2017 14:15, Alex Bennée wrote: >>> I found the virtualbox.iso on your branch but I can't trigger the >>> assert. Running: >>> >>> #!/bin/sh >>> >>> QEMU="$@" >>> >>> ${QEMU} -s -no-kvm -display s

Re: [Qemu-devel] Patch causes Mac OS X to print dead controller messages

2017-03-06 Thread Programmingkid
On Mar 6, 2017, at 4:10 AM, Gerd Hoffmann wrote: > On Mi, 2017-03-01 at 23:08 -0500, Programmingkid wrote: >> commit 95ed56939eb2eaa4e2f349fe6dcd13ca4edfd8fb >> usb: ohci: limit the number of link eds >> >> This patch causes Mac OS X to continuously print this message: >> USBF: 35.508 AppleUSBOH

Re: [Qemu-devel] [PULL 0/5] ppc-for-2.9 queue 20170306

2017-03-06 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.9-20170306 > > for you to fetch changes up to 182fe2cf19e829e34f63443ee1ccd9f799715c2c: > > target/ppc: use helper for excp handling (2017-03-06 13:17:28 +1100) > > --

  1   2   3   >