Re: [Qemu-devel] [PATCH] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

On Wed, Mar 01, 2017 at 01:14:11PM +0530, Nikunj A Dadhania wrote: > Use the softfloat api for fused multiply-add. As we are using the fused > multiply-add, the intermediate result for setting VXISI is not > available. Isn't the behaviour of setting VXISI similar to vector muladd instructions ? If

Re: [Qemu-devel] [PATCH v2 28/30] tests: add specialized device_find function

On Wed, Mar 1, 2017 at 3:22 AM Eric Blake wrote: > On 02/21/2017 08:14 AM, Marc-André Lureau wrote: > > Allows to specify which slot to look for the device. > > "Allow[s] to ${verb}" is not idiomatic; it's missing a subject. But > "Allows $subject to" (as in "allows someone to" or "allows me to"

Re: [Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

On 28.02.2017 23:11, Richard Henderson wrote: > On 02/27/2017 09:18 PM, Michal Marek wrote: >> Indicate the actual features in the STFL implementation and implement >> STFLE. >> >> Signed-off-by: Michal Marek >> --- >> v4: >> - Remove redundant buffer clearing in do_stfle() >> - Always store who

[Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

In an ideal world, read-write access to an image is inherently exclusive, because we cannot guarantee other readers and writers a consistency view of the whole image at all point. That's what the current permission system does, and it is okay as long as it is entirely internal. But that would chang

[Qemu-devel] [PATCH] Add inst_dirty_pages_rate in 'info migrate'

Auto-converge aims to accelerate migration by slowing down the generation of dirty pages. But user doesn't know how to determine the throttle value, so, a new item "inst-dirty-pages-rate" in "info migrate" would be helpful for user's determination. Signed-off-by: Chao Fan --- hmp.c

Re: [Qemu-devel] [PATCH] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

Bharata B Rao writes: > On Wed, Mar 01, 2017 at 01:14:11PM +0530, Nikunj A Dadhania wrote: >> Use the softfloat api for fused multiply-add. As we are using the fused >> multiply-add, the intermediate result for setting VXISI is not >> available. > > Isn't the behaviour of setting VXISI similar to

Re: [Qemu-devel] [PATCH] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

Nikunj A Dadhania writes: > Bharata B Rao writes: > >> On Wed, Mar 01, 2017 at 01:14:11PM +0530, Nikunj A Dadhania wrote: >>> Use the softfloat api for fused multiply-add. As we are using the fused >>> multiply-add, the intermediate result for setting VXISI is not >>> available. >> >> Isn't the

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On 2017年03月01日 15:03, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfelbaum wrote: On 02/24/2017 06:29 AM, Peter

[Qemu-devel] [PULL 02/28] tests: fix qmp response leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi --- tests/libqos/usb.c | 1 + tests/postcopy-test.c | 2 +- tests/pvpanic-test.c | 1 + tests/test-filter-mirror.c | 2 +- tests/test-filter-redirector.c | 4 ++-- tests/virtio

[Qemu-devel] [PULL 01/28] qtest: fix a memory leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- qtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qtest.c b/qtest.c index a6858272eb..5aa6636ca8 100644 --- a/qtest.c +++ b/qtest.c @@ -240,6 +240,7 @@ static void G

[Qemu-devel] [PULL 07/28] tests: fix endianness-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- tests/endianness-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/endianness-test.c b/tests/endianness-test.c index cf8d41b7b4..ed0bf52019 100644 --- a/tests/endianness-test.c +++ b/test

[Qemu-devel] [PULL 13/28] tests: fix ipmi-kcs-test leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- tests/ipmi-kcs-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c index 9cf0b34a33..178ffc1797 100644 --- a/tests/ipmi-kcs-test.c +++ b/tests/ipmi-kcs-

[Qemu-devel] [PULL 00/28] Leak patches

The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba: vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +) are available in the git repository at: g...@github.com:elmarco/qemu.git tags/leak-pull-request for you to fetch changes up to 80e1eea37a25a7696137e6802

[Qemu-devel] [PULL 05/28] glib-compat: add g_test_add_data_func_full fallback

Move the fallback from qtest_add_data_func_full() to glib-compat. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- include/glib-compat.h | 21 + tests/libqtest.c | 10 -- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/include/glib-c

[Qemu-devel] [PULL 15/28] pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice

From: Igor Mammedov PCI hotplug for bridges was introduced only since 2.0 however acpi_set_bsel()->object_property_add_uint32_ptr(bus, ACPI_PCIHP_PROP_BSEL) didn't take in account that for legacy mode (1.7) when PCI hotplug for bridges is unavailable and ACPI_PCIHP_PROP_BSEL property the only b

[Qemu-devel] [PULL 18/28] tests: fix e1000-test leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- tests/e1000-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/e1000-test.c b/tests/e1000-test.c index 59cab68a60..0c5fcdcc44 100644 --- a/tests/e1000-test.c +++ b/tests/e1000-test.c @@ -44,6

[Qemu-devel] [PULL 03/28] tests: fix leaks in test-io-channel-command

No need for strdup, fix leaks when socat is missing. Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: "Daniel P. Berrange" Reviewed-by: Greg Kurz --- tests/test-io-channel-command.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/test-io-channel-c

[Qemu-devel] [PULL 14/28] tests: fix ipmi-bt-test leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- tests/ipmi-bt-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c index e84dd6889b..7e21a9bbcb 100644 --- a/tests/ipmi-bt-test.c +++ b/tests/ipmi-bt-test.

[Qemu-devel] [PULL 21/28] tests: fix virtio-scsi-test leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Greg Kurz Reviewed-by: Paolo Bonzini --- tests/virtio-scsi-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 69220ef07b..0eabd56fd9 100644 --- a/tes

[Qemu-devel] [PULL 04/28] timer: use an inline function for free

Similarly to allocation, do it from an inline function. This allows tests to only use the headers for allocation/free of timer. Signed-off-by: Marc-André Lureau Reviewed-by: Greg Kurz Reviewed-by: Paolo Bonzini --- include/qemu/timer.h | 5 - util/qemu-timer.c| 5 - 2 files changed

[Qemu-devel] [PULL 17/28] tests: fix tco-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/tco-test.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/tests/tco-test.c b/tests/tco-test.c index ef02ec5903..c4c264eb3d 100644 --- a/tests/tco-test.c

[Qemu-devel] [PULL 22/28] tests: fix virtio-9p-test leaks

Spotted by ASAN. Cc: "Aneesh Kumar K.V" Signed-off-by: Marc-André Lureau Reviewed-by: Greg Kurz --- tests/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c index 9556291567..43a1ad813f 100644 --- a/tests/virtio-

[Qemu-devel] [PULL 16/28] tests: fix eepro100-test leak

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Weil --- tests/eepro100-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/eepro100-test.c b/tests/eepro100-test.c index ed23258b0f..bdc8a67d57 100644 --- a/tests/eepro100-test.c +++ b/tests/eepro100-test.c @@ -

[Qemu-devel] [PULL 06/28] tests: fix ptimer leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Paolo Bonzini --- include/hw/ptimer.h | 1 + hw/core/ptimer.c | 8 +++ tests/ptimer-test-stubs.c | 5 ++ tests/ptimer-test.c | 122 -- 4 files changed, 89 insert

[Qemu-devel] [PULL 19/28] tests: fix i440fx-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/i440fx-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index da2d5a53f0..e9d05c87d1 100644 --- a/tests/i440fx-test.c +++ b/tests/i440fx-test.c @@

[Qemu-devel] [PULL 23/28] bus: do not unref hotplug handler

Apparently, none of the bus owner give a reference to the hotplug handler property, do not unref it on bus release. Furthermore, a bus is allowed to be its own hotplug handler, which can be seen in qbus_set_bus_hotplug_handler() function. However, in this case, the reference can't be given to the

[Qemu-devel] [PULL 20/28] tests: fix e1000e leaks

Spotted by ASAN. This hunk adds an assertion. It checks that we're finding no more than one e1000e device: each hit allocates, but there is only one g_free(). Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/e1000e-test.c | 6 +- 1 file changed, 5 insertions(+), 1

[Qemu-devel] [PULL 25/28] tests: allows to run single test in usb-hcd-ehci-test

pci_init() shouldn't be a test function, but instead called before any test. This allows to run a single test with -p /x86_64/ehci/ Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann --- tests/usb-hcd-ehci-test.c | 9 - 1 file changed, 4

[Qemu-devel] [PULL 08/28] tests: fix q35-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/q35-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/q35-test.c b/tests/q35-test.c index 763fe3d6ae..cc58f3ecf4 100644 --- a/tests/q35-test.c +++ b/tests/q35-test.c @@ -71,6 +71,9 @@ static vo

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 06:14 AM, Jason Wang wrote: [...] > Hi Jason, > > I am not saying we don't need to create the IOMMU before some other device, > I just don't think that the command line order should matter to user. > > BTW, are yo

[Qemu-devel] [PULL 09/28] tests: fix vhost-user-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/libqos/virtio-pci.h | 2 ++ tests/libqos/virtio-pci.c | 6 ++ tests/vhost-user-test.c | 11 +++ 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tests/libqos/virtio-pci.h b/tests/l

[Qemu-devel] [PULL 27/28] tests: add specialized device_find function

Allow specifying which slot to look for the device. This will be used in the following patch to avoid leaking when multiple devices exists and we want to lookup the hotplug one. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/libqos/virtio-pci.h | 4 ++-- tests/libqos/virti

[Qemu-devel] [PULL 24/28] usb: release the created buses

Leaks spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 16 hw/usb/dev-uas.c | 2 ++ 2 files changed, 18 insertions(+) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index c607f7606d..74b7856278 100644 --- a/

[Qemu-devel] [PULL 10/28] tests: fix ide-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow --- tests/ide-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index b57c2b1676..139ebc0ec6 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -339,6 +339,7

[Qemu-devel] [PULL 26/28] tests: fix usb-test leaks

Fix the usb tests leaks. Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- tests/libqos/usb.h| 1 + tests/libqos/usb.c| 5 + tests/usb-hcd-ehci-test.c | 10 ++ tests/usb-hcd-uhci-test.c | 1 + 4 files changed, 17 insertions(+) diff

[Qemu-devel] [PULL 11/28] tests: fix hd-geo-test leaks

Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/hd-geo-test.c | 53 - 1 file changed, 36 insertions(+), 17 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 6176e81ab2..24870b

Re: [Qemu-devel] Non-flat command line option argument syntax

Markus Armbruster writes: [...] > == Extensions of the traditional syntax == > > Even if we accept JSON in addition to the traditional KEY=VALUE,... > syntax, we might want to make the traditional syntax more expressive > anyway. Do we? > > Kevin brought up an argument for yes: without it, going

[Qemu-devel] [PULL 12/28] tests: fix bios-tables-test leak

The inside array should be free too. Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- tests/bios-tables-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 54048050c0..d54018da73

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On 03/01/2017 10:43 AM, Jason Wang wrote: On 2017年03月01日 15:03, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: On 2017年03月01日 11:23, Michael S. Tsirkin wrote: On Wed, Mar 01, 2017 at 10:36:35AM +0800, Peter Xu wrote: On Tue, Feb 28, 2017 at 04:42:25PM +0200, Marcel Apfe

[Qemu-devel] [PULL 28/28] tests: fix virtio-blk-test leaks

Use qvirtio_pci_device_find_slot() to avoid leaking the non-hp device. Add assert() to avoid further leaks in the future. Use qvirtio_pci_device_free() to correctly free QVirtioPCIDevice. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/libqos/virtio-pci.c | 3 ++- tests/vir

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 28, 2017 at 02:51:39PM -0800, ashish mittal wrote: > On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange > wrote: > >> +ret = -EINVAL; > >> +goto out; > >> +} > >> + > >> +secretid = qemu_opt_get(opts, VXHS_OPT_SECRETID); > >> +if (!secretid) { > >> +

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On 03/01/2017 11:18 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: [...] Hi Jason, I am not saying we don't need to create the IOMMU before some other device, I just don't think that the command line order shou

[Qemu-devel] [PATCH 1/2] linux-user: call fd_trans_target_to_host_data() for write()

As for sendmsg() or sendto(), we must call the target to host data translator if it is defined. This is needed for eventfd(): the write() syscall allows to add a value to the internal counter, and so, it must be byte-swapped to the host order. Signed-off-by: Laurent Vivier --- linux-user/syscall

[Qemu-devel] [PATCH 2/2] linux-user: fix eventfd

When a fd is opened using eventfd(), a read provides a 64bit counter in the host byte order, and a write increase the internal counter by the provided 64bit value. Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 26 -- 1 file changed, 24 insertions(+), 2 deletion

[Qemu-devel] [PATCH 0/2] linux-user: fix eventfd()

This patch series byte-swap the uint64_t data stream of a file-descriptor opened with eventfd(). It allows to pass more LTP test cases: eventfd011 TPASS : counter value matches required eventfd012 TPASS : read failed with EAGAIN as expected eventfd013 TPASS : counter value ma

Re: [Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

Am 01.03.2017 um 09:15 hat Fam Zheng geschrieben: > In an ideal world, read-write access to an image is inherently > exclusive, because we cannot guarantee other readers and writers a > consistency view of the whole image at all point. That's what the > current permission system does, and it is oka

[Qemu-devel] adress of translation block

hi  i need help because im really blocked in my educational project  my problem is i how can i find the adress of the  instruction of the end of translation block in qemu (usually it's branch instruction) or the adress of the translation block  your advice will be very helpful for me  .thanks

[Qemu-devel] need help

I am trying to understand the block chaining of QEMU. And I have a question about the branch direction of each executed TBs. Suppose the TB#1 has been executed now, and find the next_tb (TB#2). Then we know the direction is TB#1--->TB#2 and store the chain in code cache for speedup the executio

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: > On 03/01/2017 11:18 AM, Peter Xu wrote: > >On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: > >>On 03/01/2017 06:14 AM, Jason Wang wrote: > > > >[...] > > > >>Hi Jason, > >> > >>I am not saying we don't need to cre

[Qemu-devel] [Bug 1653384] Re: Assertion failed with USB pass through with XHCI controller

** Changed in: qemu (Debian) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1653384 Title: Assertion failed with USB pass through with XHCI controller Stat

Re: [Qemu-devel] [Qemu-block] [PATCH v3 2/6] replication: add shared-disk and shared-disk-id options

On Wed, Mar 01, 2017 at 11:53:14AM +0800, Hailiang Zhang wrote: > On 2017/2/28 1:10, Stefan Hajnoczi wrote: > > On Fri, Jan 20, 2017 at 11:47:56AM +0800, zhanghailiang wrote: > > > @@ -119,12 +136,31 @@ static int replication_open(BlockDriverState *bs, > > > QDict *options, > > >

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/6] docs/block-replication: Add description for shared-disk case

On Wed, Mar 01, 2017 at 11:09:11AM +0800, Hailiang Zhang wrote: > On 2017/2/28 0:46, Stefan Hajnoczi wrote: > > On Fri, Jan 20, 2017 at 11:47:55AM +0800, zhanghailiang wrote: > > > +Secondary: > > > + -drive > > > if=none,driver=qcow2,file.filename=/mnt/ramfs/hidden_disk.img,id=hidden_disk0,\ > >

[Qemu-devel] adress of tb

| favorite | am trying to find the translation block adress of QEMU . And I have a question about the adress pointer of translation block . void gen_intermediate_code(CPUARMState *env, TranslationBlock *tb) it is the address of the last translation block found in the cache or that will be trans

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.02.2017 um 20:10 hat Peter Maydell geschrieben: > > I got a make check failure on aarch64 host running a sparc64 test: > > Probably completely unrelated, but while we're at it... > > For me, tests/vhost-user-test has been hanging for check-qtest-i386

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/2] throttle: make throttle_config(throttle_get_config()) symmetric

On Tue, Feb 28, 2017 at 01:17:55PM +0100, Alberto Garcia wrote: > On Tue 28 Feb 2017 12:19:35 PM CET, Stefan Hajnoczi wrote: > > +/* undo internal bucket parameter changes (see throttle_fix_bucket()) */ > > +static void throttle_unfix_bucket(LeakyBucket *bkt) > > +{ > > +double min = bkt->avg /

Re: [Qemu-devel] [RFC PATCH] target-s390x: Implement mvcos instruction

On 28.02.2017 14:17, Miroslav Benes wrote: > Implement MVCOS instruction, which the Linux kernel uses in user access > functions. > > Signed-off-by: Miroslav Benes > --- > I tried to do my best to follow the specification but it is quite > possible that I got something wrong because of my lack of

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Peter Maydell writes: > I got a make check failure on aarch64 host running a sparc64 test: > > > TEST: tests/prom-env-test... (pid=13573) > /sparc64/prom-env/sun4u: ** > ERROR:/home/pm215/qemu/translate-common.c:34:tcg_handle_interrupt: > assertion f

Re: [Qemu-devel] adress of translation block

oussema ben khedher writes: > hi > i need help because im really blocked in my educational project > my problem is i how can i find the adress of the instruction of the end of > translation block in qemu (usually it's branch instruction) or the adress of > the translation block > your advice w

[Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation

v3: * Added Patch 2 to fix invalid test parameters * Switched to nicer max < avg check [Berto] v2: * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto] * Rephrased warning about guest hangs and errors [Berto] * Added Patch 2 to hide the internal .max value from the monitor Patch 1 fleshes

[Qemu-devel] [PATCH v3 1/3] qemu-options: explain disk I/O throttling options

The disk I/O throttling options have been listed for a long time but never explained on the QEMU man page. Suggested-by: Nini Gu Cc: Alberto Garcia Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 24 1 file changed, 24 insertions(+) diff --git a/qemu-options.hx b

[Qemu-devel] [PATCH v3 2/3] throttle: do not use invalid config in test

The (burst) max parameter cannot be smaller than the avg parameter. There is a test case that uses avg = 56, max = 1 and gets away with it because no input validation is performed by the test case. This patch switches to valid test input parameters. Signed-off-by: Stefan Hajnoczi --- tests/test

[Qemu-devel] [PATCH v3 3/3] throttle: make throttle_config(throttle_get_config()) symmetric

Throttling has a weird property that throttle_get_config() does not always return the same throttling settings that were given with throttle_config(). In other words, the set and get functions aren't symmetric. If .max is 0 then the throttling code assigns a default value of .avg / 10 in throttle

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

On 01/03/17 11:36, Alex Bennée wrote: > Peter Maydell writes: > >> I got a make check failure on aarch64 host running a sparc64 test: >> >> >> TEST: tests/prom-env-test... (pid=13573) >> /sparc64/prom-env/sun4u: ** >> ERROR:/home/pm215/qemu/translate

Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir

On Tue, Feb 28, 2017 at 12:28:59PM +, Daniel P. Berrange wrote: > If systemtap support was disabled, the trace-events-all file was > only getting regenerated at time of 'make instal'. This is bad > because it leaves stale files in the build dir for developers. > > Daniel P. Berrange (2): > m

Re: [Qemu-devel] [RFC PATCH] target-s390x: Implement mvcos instruction

On Wed, 1 Mar 2017, Thomas Huth wrote: > On 28.02.2017 14:17, Miroslav Benes wrote: > > Implement MVCOS instruction, which the Linux kernel uses in user access > > functions. > > > > Signed-off-by: Miroslav Benes > > --- > > I tried to do my best to follow the specification but it is quite > > p

Re: [Qemu-devel] [PATCH 0/2] Fix stale 'trace-events-all' file in build dir

On Wed, Mar 01, 2017 at 12:19:34PM +, Stefan Hajnoczi wrote: > On Tue, Feb 28, 2017 at 12:28:59PM +, Daniel P. Berrange wrote: > > If systemtap support was disabled, the trace-events-all file was > > only getting regenerated at time of 'make instal'. This is bad > > because it leaves stale

[Qemu-devel] [PULL 19/19] vl: disable default cdrom when using explicitely scsi-hd

From: Hervé Poussineau In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults". Make it the same for scsi-hd, so you can put one on scsi-id 2 without us

[Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze

The following changes since commit d992f2f1368ceb92e6bfd8efece174110f4236ff: Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170226' into staging (2017-02-26 22:40:23 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you t

[Qemu-devel] [PULL 18/19] memory: Introduce DEVICE_HOST_ENDIAN for ram device

From: Yongji Xie At the moment ram device's memory regions are DEVICE_NATIVE_ENDIAN. It's incorrect. This memory region is backed by a MMIO area in host, so the uint64_t data that MemoryRegionOps read from/write to this area should be host-endian rather than target-endian. Hence, current code doe

Re: [Qemu-devel] [PATCH v3 2/3] throttle: do not use invalid config in test

On Wed 01 Mar 2017 12:50:25 PM CET, Stefan Hajnoczi wrote: > The (burst) max parameter cannot be smaller than the avg parameter. > There is a test case that uses avg = 56, max = 1 and gets away with it > because no input validation is performed by the test case. > > This patch switches to valid tes

[Qemu-devel] [PULL 10/19] KVM: do not use sigtimedwait to catch SIGBUS

Call kvm_on_sigbus_vcpu asynchronously from the VCPU thread. Information for the SIGBUS can be stored in thread-local variables and processed later in kvm_cpu_exec. Signed-off-by: Paolo Bonzini --- cpus.c | 31 +-- include/sysemu/kvm.h | 5 - kvm-al

Re: [Qemu-devel] [PATCH v3 3/3] throttle: make throttle_config(throttle_get_config()) symmetric

On Wed 01 Mar 2017 12:50:26 PM CET, Stefan Hajnoczi wrote: > Throttling has a weird property that throttle_get_config() does not > always return the same throttling settings that were given with > throttle_config(). In other words, the set and get functions aren't > symmetric. > > If .max is 0 the

Re: [Qemu-devel] [PATCH v2] intel_iommu: check misordered init when realize

On 03/01/2017 11:59 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 11:29:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 11:18 AM, Peter Xu wrote: On Wed, Mar 01, 2017 at 09:03:47AM +0200, Marcel Apfelbaum wrote: On 03/01/2017 06:14 AM, Jason Wang wrote: [...] Hi Jason, I am not saying we

[Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Some of the migration parameters are strings, which default to NULL, eg tls_hostname and tls_creds. The mgmt app will set the tls_creds parameter on both source and target QEMU instances, in order to trigger use of TLS for migration. After performing a TLS encrypted migration though, migration mi

[Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" changed how notifications are done for virtio-blk substantially. Due to a race condition interrupts are lost when irqfd is torn down after notify_guest_bh

Re: [Qemu-devel] [PATCH RFC] block: Tolerate existing writers on read only BdrvChild

On Wed, 03/01 10:49, Kevin Wolf wrote: > Am 01.03.2017 um 09:15 hat Fam Zheng geschrieben: > > In an ideal world, read-write access to an image is inherently > > exclusive, because we cannot guarantee other readers and writers a > > consistency view of the whole image at all point. That's what the

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170301123223.12489-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170301123223.12489-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] migration: allow clearing mi

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

Mark Cave-Ayland writes: > On 01/03/17 11:36, Alex Bennée wrote: > >> Peter Maydell writes: >> >>> I got a make check failure on aarch64 host running a sparc64 test: >>> >>> >>> TEST: tests/prom-env-test... (pid=13573) >>> /sparc64/prom-env/sun4u: *

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On 06/16/2016 04:25 AM, Daniel P. Berrange wrote: On Thu, Jun 16, 2016 at 09:05:20AM +0100, Dr. David Alan Gilbert wrote: * Stefan Berger (stef...@linux.vnet.ibm.com) wrote: On 06/15/2016 03:30 PM, Dr. David Alan Gilbert wrote: So what was the multi-instance vTPM proxy driver patch set abou

Re: [Qemu-devel] need help

On 1 March 2017 at 09:50, oussema ben khedher wrote: > I am trying to understand the block chaining of QEMU. And I have > a question about the branch direction of each executed TBs. > Suppose the TB#1 has been executed now, and find the next_tb (TB#2). > Then we know the direction is TB#1--->TB#2

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On 02/28/2017 01:31 PM, Marc-André Lureau wrote: Hi On Fri, Jun 17, 2016 at 1:29 AM Stefan Berger mailto:stef...@linux.vnet.ibm.com>> wrote: On 06/16/2016 03:24 PM, Dr. David Alan Gilbert wrote: > * Stefan Berger (stef...@linux.vnet.ibm.com ) wro

Re: [Qemu-devel] intermittent make check failure: "tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked())"

On 1 March 2017 at 11:36, Alex Bennée wrote: > What will be useful for all these reports is the backtrace. Then it's > fairly simple to identify the thing triggering the interrupt and > identify the correct place for the locking. Unfortunately all I get for build tests is the log output from 'mak

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

On Wed, Mar 01, 2017 at 07:25:28AM -0500, Stefan Berger wrote: > On 06/16/2016 04:25 AM, Daniel P. Berrange wrote: > > On Thu, Jun 16, 2016 at 09:05:20AM +0100, Dr. David Alan Gilbert wrote: > > > * Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > > > > On 06/15/2016 03:30 PM, Dr. David Alan Gil

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On Wed, Mar 01, 2017 at 12:50:04PM +0100, Halil Pasic wrote: > The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and > 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" > changed how notifications are done for virtio-blk substantially. Due to a > race condit

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On 01/03/2017 12:50, Halil Pasic wrote: > The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and > 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" > changed how notifications are done for virtio-blk substantially. Due to a > race condition interrupts are

Re: [Qemu-devel] [PULL for-2.9 0/5] s390x: network boot

On 28 February 2017 at 11:31, Cornelia Huck wrote: > The following changes since commit 6181478f6395cdd9d6ffd99623d0c9f39ea53606: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-28 08:46:03 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL v4 00/19] KVM and cpu-exec patches for 2.9 soft freeze

On 1 March 2017 at 12:29, Paolo Bonzini wrote: > The following changes since commit d992f2f1368ceb92e6bfd8efece174110f4236ff: > > Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170226' into > staging (2017-02-26 22:40:23 +) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PULL 00/27] migration queue

On 28 February 2017 at 12:40, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 6181478f6395cdd9d6ffd99623d0c9f39ea53606: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-28 08:46:03 +0

Re: [Qemu-devel] [PATCH v3 1/3] qemu-options: explain disk I/O throttling options

On Wed 01 Mar 2017 12:50:24 PM CET, Stefan Hajnoczi wrote: > The disk I/O throttling options have been listed for a long time but > never explained on the QEMU man page. > > Suggested-by: Nini Gu > Cc: Alberto Garcia > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PULL 00/27] migration queue

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 28 February 2017 at 12:40, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > > > The following changes since commit 6181478f6395cdd9d6ffd99623d0c9f39ea53606: > > > > Merge remote-tracking branch 'remotes/stefanha/

[Qemu-devel] Windows Pipe

Dear QEMU developers, I want the host-guest communication for QEMU. I want to achieve it via serial port redirection to a pipe. My host is windows and guest is Linux. QEMU is in version 2.8.50 I looked into char-pipe.c and char-win.c, and find that the current QEMU only supports reading data on t

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On 03/01/2017 01:57 PM, Paolo Bonzini wrote: > > > On 01/03/2017 12:50, Halil Pasic wrote: >> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and >> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" >> changed how notifications are done for virtio-blk

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

"Daniel P. Berrange" wrote on 03/01/2017 07:54:14 AM: > From: "Daniel P. Berrange" > To: Stefan Berger > Cc: "Dr. David Alan Gilbert" , Stefan Berger/ > Watson/IBM@IBMUS, "m...@redhat.com" , "qemu- > de...@nongnu.org" , "SERBAN, CRISTINA" > , "Xu, Quan" , > "silviu.vlasce...@gmail.com" , >

Re: [Qemu-devel] [PULL 0/1] seabios: update to 1.10.2 release

On Tue, Feb 28, 2017 at 9:06 AM, Gerd Hoffmann wrote: > Our seabios.git mirror @ qemu.org seems to not sync properly. The > commit isn't there even though it was pushed a few days ago already > (only the tag was pushed today). John, can you have a look please? > master branch, *-stable branches

Re: [Qemu-devel] [PATCH 1/1] virtio: fallback from irqfd to non-irqfd notify

On 03/01/2017 01:54 PM, Michael S. Tsirkin wrote: > On Wed, Mar 01, 2017 at 12:50:04PM +0100, Halil Pasic wrote: >> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and >> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" >> changed how notifications are

[Qemu-devel] [PULL 2/2] mach-virt: Provide sample configuration files

From: Andrea Bolognani These are very much like the sample configuration files for q35, and can be used both as documentation and as a starting point for creating your own guest. Two sample configuration files are provided: * mach-virt-graphical.cfg can be used to start a fully-featured (

Re: [Qemu-devel] [PULL 0/2] Docker patches

On 28 February 2017 at 12:44, Fam Zheng wrote: > The following changes since commit 6181478f6395cdd9d6ffd99623d0c9f39ea53606: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-28 08:46:03 +) > > are available in the git repository at: > >

[Qemu-devel] [PULL 0/2] docs: update sample configuration files

tags/pull-docs-20170301-1 for you to fetch changes up to 166d434685ed6da5db88aca0c0599114e0c54462: mach-virt: Provide sample configuration files (2017-03-01 14:40:40 +0100) docs: update sample conf

[Qemu-devel] [PULL 1/2] q35: Improve sample configuration files

From: Andrea Bolognani Instead of having a single sample configuration file, we now have several: * q35-emulated.cfg documents the default devices QEMU adds to a q35 guest and the additional devices that are pretty much guaranteed to be present in a physical q35-based machine; *

  1   2   3   >