Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Paolo Bonzini
On 08/02/2017 01:43, Michael Roth wrote: >> _includes/releases.html | 4 ++-- > > Somewhat related: I think _data/releases.yml needs to be updated as it's > still referencing 2.7.0 instead of 2.7.1. Would one just start updating > that file with each new release, or is there some other process?

[Qemu-devel] [PATCH] qcow2: remove useless NULL check

2017-02-08 Thread Marc-André Lureau
g_strdup() already handles the case where the argument is NULL. Signed-off-by: Marc-André Lureau --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 96fb8a8f16..9114218030 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-08 Thread Thomas Huth
I meant to copy B, not A ... but I likely just haven't really understood what you're really trying to do here, so never mind. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1662050 Title: qemu-img c

[Qemu-devel] [qemu-web PATCH] releases: update 2.7 branch for 2.7.1 release

2017-02-08 Thread Paolo Bonzini
Suggested-by: Michael Roth Signed-off-by: Paolo Bonzini --- _data/releases.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_data/releases.yml b/_data/releases.yml index 883cab3..db02a39 100644 --- a/_data/releases.yml +++ b/_data/releases.yml @@ -2,8 +2,8 @@ patch:

[Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-08 Thread wayen
@Thomas Huth, I just want to reduce the file size of qcow2 overlay image by this conversion. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1662050 Title: qemu-img convert a overlay qcow2 image into

Re: [Qemu-devel] [libvirt] [Block Replication] Question about supporting COLO in libvirt

2017-02-08 Thread Hailiang Zhang
On 2017/2/6 20:39, Daniel P. Berrange wrote: On Mon, Feb 06, 2017 at 08:34:28PM +0800, Hailiang Zhang wrote: Hi, I'm trying to implement supporting COLO in libvirt, But i found an annoying problem that libvirt does not support the command line option argument syntax we used for block replication

Re: [Qemu-devel] [PATCH] net: e1000e: fix an infinite loop issue

2017-02-08 Thread Dmitry Fleytman
Hello, Thanks for the patch! The problem of infinite loop indeed exists in e1000e, however it is different from the one fixed in e1000. Please find my comments inline. ~Dmitry > On 7 Feb 2017, at 11:43 AM, Li Qiang wrote: > > From: Li Qiang > > This issue is the same as e1000 network card

Re: [Qemu-devel] [PULL 0/6] Migration pull

2017-02-08 Thread Thomas Huth
On 07.02.2017 18:47, Peter Maydell wrote: > On 7 February 2017 at 07:50, Juan Quintela wrote: >> Peter Maydell wrote: >>> On 6 February 2017 at 16:51, Juan Quintela wrote: >> >>> I get a test failure on aarch64 host on one of the ppc guest tests: >>> >>> TEST: tests/prom-env-test... (pid=26435)

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Markus Armbruster
Eric Blake writes: > On 02/07/2017 09:59 AM, Paolo Bonzini wrote: >> I have converted all .gz and .bz2 files to .xz on download.qemu.org >> and this patch would change the links in the website. This would save >> about 5 GB of bandwidth every day (about 20% savings). >> >> xz should be availabl

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-08 Thread Paolo Bonzini
> Does qemu follow recommendations from section 4.3? All that QEMU does is initialize MSR values and QEMU is talking to KVM, not to the processor; KVM in turn talks to the host kernel's perf subsystem. It's the host kernel's perf subsystem that needs to follow Intel's recommendation. In particul

[Qemu-devel] [Bug 639651] Re: DRIVER_IRQL_NOT_LESS_OR_EQUAL booting WIndows XP with Synaptics driver installed

2017-02-08 Thread Thomas Huth
Hmm, I'm not aware of a way to disable the PS2 mouse in QEMU yet. Looking at your other related bug (https://bugs.launchpad.net/qemu/+bug/813546), I think you might need to discuss that patch on the qemu-devel mailing list. -- You received this bug notification because you are a member of qemu- d

[Qemu-devel] [Bug 813546] Re: option to disable PS/2 mouse

2017-02-08 Thread Thomas Huth
Sorry, we don't take any patches from the bug tracker... Could you please post patches on the qemu-devel mailing list instead? Thanks! ** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-02-08 Thread Markus Armbruster
Max Reitz writes: > First, because this is perhaps the most important thing: I think I > remembered what the original proposal to solve all this mess, or at > least move it to a later point: > > We wanted to just disallow overwriting existing files without > conv=notrunc. I think. > > The thing i

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Laszlo Ersek
On 02/08/17 09:49, Markus Armbruster wrote: > Eric Blake writes: > >> On 02/07/2017 09:59 AM, Paolo Bonzini wrote: >>> I have converted all .gz and .bz2 files to .xz on download.qemu.org >>> and this patch would change the links in the website. This would save >>> about 5 GB of bandwidth every d

Re: [Qemu-devel] [PATCH] net: e1000e: fix an infinite loop issue

2017-02-08 Thread Li Qiang
Hello, 2017-02-08 16:38 GMT+08:00 Dmitry Fleytman : > Hello, > > Thanks for the patch! > > The problem of infinite loop indeed exists in e1000e, however it is > different from the one fixed in e1000. > Please find my comments inline. > > If I read the code correctly, I think this issue is the sam

Re: [Qemu-devel] [PATCH] net: e1000e: fix an infinite loop issue

2017-02-08 Thread Dmitry Fleytman
> On 8 Feb 2017, at 11:30 AM, Li Qiang wrote: > > Hello, > > 2017-02-08 16:38 GMT+08:00 Dmitry Fleytman >: > Hello, > > Thanks for the patch! > > The problem of infinite loop indeed exists in e1000e, however it is different > from the one fixed in e1000. > Please

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Laszlo Ersek
On 02/07/17 16:59, Paolo Bonzini wrote: > I have converted all .gz and .bz2 files to .xz on download.qemu.org > and this patch would change the links in the website. This would save > about 5 GB of bandwidth every day (about 20% savings). > > xz should be available for all platforms. Besides pro

Re: [Qemu-devel] [PATCH] net: e1000e: fix an infinite loop issue

2017-02-08 Thread Li Qiang
Hello Dmitry, 2017-02-08 18:01 GMT+08:00 Dmitry Fleytman : > > On 8 Feb 2017, at 11:30 AM, Li Qiang wrote: > > Hello, > > 2017-02-08 16:38 GMT+08:00 Dmitry Fleytman : > >> Hello, >> >> Thanks for the patch! >> >> The problem of infinite loop indeed exists in e1000e, however it is >> different f

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 04:59:56PM +0100, Paolo Bonzini wrote: > I have converted all .gz and .bz2 files to .xz on download.qemu.org > and this patch would change the links in the website. This would save > about 5 GB of bandwidth every day (about 20% savings). > > xz should be available for all

Re: [Qemu-devel] [PATCH 1/3] COLO: fix setting checkpoint-delay not working properly

2017-02-08 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > If we set checkpoint-delay through command 'migrate-set-parameters', > It will not take effect until we finish last sleep chekpoint-delay, > That's will be offensive espeically when we want to change its value > from an extreme big one to a

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-08 Thread Laszlo Ersek
On 02/08/17 07:16, David Gibson wrote: > Marcel, > > Your original patch adding PCIe support to virtio-pci.c has the > limitation noted below that PCIe won't be enabled if the device is on > the root bus (rather than under a root or downstream port). As > reasoned below, I think removing the chec

Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries

2017-02-08 Thread Igor Mammedov
On Tue, 7 Feb 2017 21:09:27 +0100 Laszlo Ersek wrote: > On 02/07/17 14:51, Igor Mammedov wrote: > > On Sun, 5 Feb 2017 01:11:56 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This is initially used to patch a 64-bit address into > >> the VM Generation ID SSDT >

Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto

2017-02-08 Thread Longpeng (Mike)
Hi Daniel, I was writing AF_ALG-backed for QEMU crypto these days, I think there're more than two ways to implements it. The first one look likes below: [ cipher.c ] qcrypto_cipher_new(...) { if (...) { /* use AF_ALG */ cipher = afalg_cipher_new(...) if (ci

Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 06:46:04PM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > I was writing AF_ALG-backed for QEMU crypto these days, I think there're more > than two ways to implements it. > > The first one look likes below: > [ cipher.c ] > qcrypto_cipher_new(...) > { > if (...) { /*

Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries

2017-02-08 Thread Laszlo Ersek
On 02/08/17 11:43, Igor Mammedov wrote: > On Tue, 7 Feb 2017 21:09:27 +0100 > Laszlo Ersek wrote: > >> On 02/07/17 14:51, Igor Mammedov wrote: >>> On Sun, 5 Feb 2017 01:11:56 -0800 >>> b...@skyportsystems.com wrote: >>> From: Ben Warren This is initially used to patch a 64-bit

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Igor Mammedov
On Wed, 8 Feb 2017 01:48:42 +0100 Laszlo Ersek wrote: > On 02/05/17 10:12, b...@skyportsystems.com wrote: > > From: Ben Warren > > > > This implements the VM Generation ID feature by passing a 128-bit > > GUID to the guest via a fw_cfg blob. > > Any time the GUID changes, an ACPI notify event i

Re: [Qemu-devel] [PATCH 2/3] COLO: Shutdown related socket fd while do failover

2017-02-08 Thread Hailiang Zhang
On 2017/1/18 19:01, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If the net connection between primary host and secondary host breaks while COLO/COLO incoming threads are doing read() or write(). It will block until connection is timeout, and the failover

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Laszlo Ersek
On 02/08/17 12:04, Igor Mammedov wrote: > On Wed, 8 Feb 2017 01:48:42 +0100 > Laszlo Ersek wrote: [snip] >> (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 >> decimal". >> >> I explained it under points (6) and (7) in the following message: >> >> Message-Id: >> URL: https

Re: [Qemu-devel] [PATCH 1/3] COLO: fix setting checkpoint-delay not working properly

2017-02-08 Thread Hailiang Zhang
On 2017/2/8 18:38, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If we set checkpoint-delay through command 'migrate-set-parameters', It will not take effect until we finish last sleep chekpoint-delay, That's will be offensive espeically when we want to ch

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > Migration of a "none" machine with no RAM crashes abruptly as > bitmap_new() fails and thus aborts. Instead place zero RAM checks at > appropriate places to skip migration of RAM in this case and complete > migration successfully for devices o

Re: [Qemu-devel] [PATCH 10/18] block/dirty-bitmap: add bdrv_load_dirty_bitmap

2017-02-08 Thread Fam Zheng
On Fri, 02/03 18:47, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 53 > > include/block/block_int.h| 4 > include/block/dirty-bitmap.h | 3 +++ > 3 files changed, 6

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Thomas Huth
On 03.02.2017 11:36, Ashijeet Acharya wrote: > Migration of a "none" machine with no RAM crashes abruptly as > bitmap_new() fails and thus aborts. Instead place zero RAM checks at > appropriate places to skip migration of RAM in this case and complete > migration successfully for devices only. > >

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Igor Mammedov
On Wed, 8 Feb 2017 12:17:54 +0100 Laszlo Ersek wrote: > On 02/08/17 12:04, Igor Mammedov wrote: > > On Wed, 8 Feb 2017 01:48:42 +0100 > > Laszlo Ersek wrote: > > [snip] > > >> (2) Structure of the vmgenid fw_cfg blob, AKA "why that darn offset 40 > >> decimal". > >> > >> I explained it under

Re: [Qemu-devel] [PATCH] net: e1000e: fix an infinite loop issue

2017-02-08 Thread Dmitry Fleytman
> On 8 Feb 2017, at 12:17 PM, Li Qiang wrote: > > Hello Dmitry, > > > 2017-02-08 18:01 GMT+08:00 Dmitry Fleytman : > >> On 8 Feb 2017, at 11:30 AM, Li Qiang wrote: >> >> Hello, >> >> 2017-02-08 16:38 GMT+08:00 Dmitry Fleytman : >> Hello, >> >> Thanks for the patch! >> >> The problem of

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Ashijeet Acharya
On Wed, Feb 8, 2017 at 4:55 PM, Dr. David Alan Gilbert wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM checks at >> appropriate places to skip migration of

Re: [Qemu-devel] [PATCH 11/18] nbd: BLOCK_STATUS for bitmap export: server part

2017-02-08 Thread Eric Blake
On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Only one meta context type is defined: qemu-bitmap:. Why 'qemu-bitmap:' instead of 'qemu:' for our namespace? I guess it's okay, though. > Maximum one query is allowed for NBD_OPT_{SET,LIST}_META_CONTEXT, > NBD_REP_ERR_TOO_BIG is retu

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-02-08 Thread Max Reitz
On 08.02.2017 10:19, Markus Armbruster wrote: > Max Reitz writes: > >> First, because this is perhaps the most important thing: I think I >> remembered what the original proposal to solve all this mess, or at >> least move it to a later point: >> >> We wanted to just disallow overwriting existing

Re: [Qemu-devel] [PATCH v12 14/16] file-posix: Implement image locking

2017-02-08 Thread Max Reitz
On 08.02.2017 07:00, Fam Zheng wrote: > On Wed, 02/08 04:05, Max Reitz wrote: >>> +static int raw_lt_write_to_write_share(RawLockTransOp op, >>> + int old_lock_fd, int new_lock_fd, >>> + BDRVRawLockMode old_lock, >>> +

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-08 Thread Matwey V. Kornilov
** Attachment added: "dmesg-loglevel9" https://bugs.launchpad.net/qemu/+bug/1661386/+attachment/4815387/+files/dmesg-loglevel9 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1661386 Title: Asser

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-08 Thread Matwey V. Kornilov
** Attachment added: "x86info.txt" https://bugs.launchpad.net/qemu/+bug/1661386/+attachment/4815388/+files/x86info.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1661386 Title: Assertion `re

Re: [Qemu-devel] [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-08 Thread Halil Pasic
On 02/08/2017 07:24 AM, Gonglei (Arei) wrote: > Hi Halil, > > Thanks for your comments firstly. > You are welcome :). Sorry it took so long -- I'm currently quite busy. >> >> On 01/18/2017 09:22 AM, Gonglei wrote: >>> The virtio crypto device is a virtual crypto device (ie. hardware >>> crypt

[Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-08 Thread Alexander Graf
QEMU emulated hardware is always dma coherent with its guest. We do annotate that correctly on the PCI host controller, but left out virtio-mmio. Recent kernels have started to interpret that flag rather than take dma coherency as granted with virtio-mmio. While that is considered a kernel bug, as

Re: [Qemu-devel] [PATCH v12 14/16] file-posix: Implement image locking

2017-02-08 Thread Fam Zheng
On Wed, 02/08 14:18, Max Reitz wrote: > On 08.02.2017 07:00, Fam Zheng wrote: > > On Wed, 02/08 04:05, Max Reitz wrote: > >>> +static int raw_lt_write_to_write_share(RawLockTransOp op, > >>> + int old_lock_fd, int new_lock_fd, > >>> +

Re: [Qemu-devel] [Bug 1662050] Re: qemu-img convert a overlay qcow2 image into a entire image

2017-02-08 Thread Eric Blake
On 02/08/2017 02:16 AM, wayen wrote: > @Thomas Huth, I just want to reduce the file size of qcow2 overlay image > by this conversion. Are you merely trying to sparsify the file (punch holes on the portion of the file that is not mapped to disk), so that the apparent file size is unchanged, but the

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Eric Blake
On 02/08/2017 02:49 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 02/07/2017 09:59 AM, Paolo Bonzini wrote: >>> I have converted all .gz and .bz2 files to .xz on download.qemu.org >>> and this patch would change the links in the website. This would save >>> about 5 GB of bandwidth ev

Re: [Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Ashijeet Acharya
On Wed, Feb 8, 2017 at 5:19 PM, Thomas Huth wrote: > On 03.02.2017 11:36, Ashijeet Acharya wrote: >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead place zero RAM checks at >> appropriate places to skip migration of RAM in this case and

[Qemu-devel] [PATCH 1/2] vga: replace debug printf with trace points

2017-02-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/trace-events | 6 ++ hw/display/vga.c| 27 --- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/hw/display/trace-events b/hw/display/trace-events index aadb612..26910e2 100644 --- a/hw/display/trace-e

[Qemu-devel] [PATCH 2/2] cirrus: replace debug printf with trace points

2017-02-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 11 +-- hw/display/trace-events | 6 ++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 16f27e8..b272a70 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/di

Re: [Qemu-devel] [PATCH] qcow2: remove useless NULL check

2017-02-08 Thread Eric Blake
On 02/08/2017 02:09 AM, Marc-André Lureau wrote: > g_strdup() already handles the case where the argument is NULL. > > Signed-off-by: Marc-André Lureau > --- > block/qcow2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/block/qcow2.c b/b

Re: [Qemu-devel] [PATCH] qcow2: remove useless NULL check

2017-02-08 Thread Max Reitz
On 08.02.2017 09:09, Marc-André Lureau wrote: > g_strdup() already handles the case where the argument is NULL. > > Signed-off-by: Marc-André Lureau > --- > block/qcow2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 96fb8a8f1

Re: [Qemu-devel] Question about QEMU's threading model and stacking multiple block drivers

2017-02-08 Thread Max Reitz
CC-ing qemu-block, Stefan, Fam. On 08.02.2017 03:38, Adrian Suarez wrote: > We’ve implemented a block driver that exposes storage to QEMU VMs. Our > block driver (O) is interposing on writes to some other type of storage > (B). O performs low latency replication and then asynchronously issues the

Re: [Qemu-devel] [PATCH] qcow2: remove useless NULL check

2017-02-08 Thread Marc-André Lureau
Hi - Original Message - > On 08.02.2017 09:09, Marc-André Lureau wrote: > > g_strdup() already handles the case where the argument is NULL. > > > > Signed-off-by: Marc-André Lureau > > --- > > block/qcow2.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --gi

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-02-08 Thread Stafford Horne
On Mon, Feb 06, 2017 at 09:53:26PM -0800, Richard Henderson wrote: > On 02/01/2017 02:04 AM, Stafford Horne wrote: > > For kernel builds I have created toolchain binaries here: > > > > http://shorne.noip.me/crosstool/files/bin/x86_64/5.4.0/ > > > > These should work. > > This gdb crashes on th

Re: [Qemu-devel] [Bug 1662468] Re: [feature request] qemu-img convert should respond to control-T like dd

2017-02-08 Thread Max Reitz
[removed LP from CC, but kept qemu-devel because everyone is interested] On 08.02.2017 02:29, Laszlo Ersek wrote: > On 02/08/17 00:22, Max Reitz wrote: >> That should be simple enough to implement considering we have this >> behavior already on SIGUSR1. Unfortunately, I wouldn't be able to test >>

Re: [Qemu-devel] [qcow2] how to avoid qemu doing lseek(SEEK_DATA/SEEK_HOLE)?

2017-02-08 Thread Stephane Chazelas
2017-02-08 00:43:18 +0100, Max Reitz: [...] > OTOH, it may make sense to offer a way for the user to disable > lseek(SEEK_{DATA,HOLE}) in our "file" block driver. That way your issue > would be solved, too, I guess. I'll look into it. [...] Thanks Max, Yes, that would work for me and other users

Re: [Qemu-devel] [qcow2] how to avoid qemu doing lseek(SEEK_DATA/SEEK_HOLE)?

2017-02-08 Thread Stephane Chazelas
2017-02-08 00:43:18 +0100, Max Reitz: [...] > Therefore, the patch as it is makes sense. The fact that said lseek() is > slow on ZFS is (in my humble opinion) the ZFS driver's problem that > needs to be fixed there. [...] For the record, I've mentioned the qemu performance implication at https://g

Re: [Qemu-devel] [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-08 Thread Halil Pasic
On 02/08/2017 04:46 AM, Gonglei (Arei) wrote: > Hi Cornelia, > >> >> On Tue, 7 Feb 2017 12:39:44 +0100 >> Halil Pasic wrote: >> >>> On 01/18/2017 09:22 AM, Gonglei wrote: >> +\section{Crypto Device}\label{sec:Device Types / Crypto Device} + +The virtio crypto device is a virtual

Re: [Qemu-devel] [qcow2] how to avoid qemu doing lseek(SEEK_DATA/SEEK_HOLE)?

2017-02-08 Thread Max Reitz
On 08.02.2017 15:06, Stephane Chazelas wrote: > 2017-02-08 00:43:18 +0100, Max Reitz: > [...] >> OTOH, it may make sense to offer a way for the user to disable >> lseek(SEEK_{DATA,HOLE}) in our "file" block driver. That way your issue >> would be solved, too, I guess. I'll look into it. > [...] >

[Qemu-devel] [PATCH v3] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Ashijeet Acharya
Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead place zero RAM checks at appropriate places to skip migration of RAM in this case and complete migration successfully for devices only. Signed-off-by: Ashijeet Acharya --- Changes in v3: - ha

Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-08 Thread Halil Pasic
On 02/07/2017 01:59 AM, Gonglei (Arei) wrote: > Hi, > >> From: Michael S. Tsirkin [mailto:m...@redhat.com] >> Sent: Tuesday, February 07, 2017 2:20 AM >> Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto >> device specification >> >> On Mon, Feb 06, 2017 at 03:46:25PM +0

Re: [Qemu-devel] Question about QEMU's threading model and stacking multiple block drivers

2017-02-08 Thread Fam Zheng
On Wed, 02/08 14:59, Max Reitz wrote: > CC-ing qemu-block, Stefan, Fam. > > > On 08.02.2017 03:38, Adrian Suarez wrote: > > We’ve implemented a block driver that exposes storage to QEMU VMs. Our > > block driver (O) is interposing on writes to some other type of storage > > (B). O performs low la

Re: [Qemu-devel] [PATCH v12 15/16] qcow2: Force "no other writer" lock on bs->file

2017-02-08 Thread Max Reitz
On 23.01.2017 13:30, Fam Zheng wrote: > Writing to the same qcow2 file from two QEMU processes at the same time > will never work correctly, so disable it even when the caller specifies > BDRV_O_RDWR. > > Other formats are less vulnerable because they don't have internal > snapshots thus qemu-img

[Qemu-devel] [Bug 1657538] Re: qemu 2.7.x 2.8 softmmu dont work on BE machine

2017-02-08 Thread Cameron Kaiser
I can reproduce the same problem on 2.7.0 on a PowerPC G5 for the x86, x86_64 and ppc softmmu targets (minus the Gtk problem, since I use this ported to Cocoa). As with Luigi this seems to be a regression from 2.6.2. There is no change with -nographic. See also: https://bugzilla.redhat.com/show_bu

Re: [Qemu-devel] [PATCH v12 16/16] tests: Add test-image-lock

2017-02-08 Thread Max Reitz
On 23.01.2017 13:30, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/Makefile.include | 2 + > tests/test-image-lock.c | 206 > +++ > tests/test-replication.c | 6 +- > 3 files changed, 211 insertions(+), 3 deletions(-) > create mode

Re: [Qemu-devel] [Bug 1662468] Re: [feature request] qemu-img convert should respond to control-T like dd

2017-02-08 Thread Laszlo Ersek
On 02/08/17 15:04, Max Reitz wrote: > [removed LP from CC, but kept qemu-devel because everyone is interested] [citation needed] :) > On 08.02.2017 02:29, Laszlo Ersek wrote: >> On 02/08/17 00:22, Max Reitz wrote: >>> That should be simple enough to implement considering we have this >>> behavior

Re: [Qemu-devel] [PATCH v12 15/16] qcow2: Force "no other writer" lock on bs->file

2017-02-08 Thread Fam Zheng
On Wed, 02/08 15:33, Max Reitz wrote: > On 23.01.2017 13:30, Fam Zheng wrote: > > Writing to the same qcow2 file from two QEMU processes at the same time > > will never work correctly, so disable it even when the caller specifies > > BDRV_O_RDWR. > > > > Other formats are less vulnerable because t

Re: [Qemu-devel] question about binary translation on qemu

2017-02-08 Thread Frederic Konrad
On 02/07/2017 02:53 PM, oussema ben khedher wrote: > hi > in my academic project i needed to know how qemu exactly translate an arm > instruction to the host assembly (in my case x86) so if you can help me to > know the function in the source code of qemu that tdo this work > thank you > Hi,

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/18] block: expose crypto option names / defs to other drivers

2017-02-08 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:10 AM CET, Daniel P. Berrange wrote: > The block/crypto.c defines a set of QemuOpts that provide > parameters for encryption. This will also be needed by > the qcow/qcow2 integration, so expose the relevant pieces > in a new block/crypto.h header. > > Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 1/2] vga: replace debug printf with trace points

2017-02-08 Thread Laurent Vivier
On 08/02/2017 14:51, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Laurent Vivier > --- > hw/display/trace-events | 6 ++ > hw/display/vga.c| 27 --- > 2 files changed, 10 insertions(+), 23 deletions(-) > > diff --git a/hw/display/trace-

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-08 Thread Laszlo Ersek
CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31, Alexander Graf wrote: > QEMU emulated hardware is always dma coherent with its guest. We do > annotate that correctly on the PCI host controller, but left out > virtio-mmio. I recommend to reference the following com

Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/18] qcow: document another weakness of qcow AES encryption

2017-02-08 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:12 AM CET, Daniel P. Berrange wrote: > Document that use of guest virtual sector numbers as the basis for > the initialization vectors is a potential weakness, when combined > with internal snapshots or multiple images using the same passphrase. > This fixes the formatting

Re: [Qemu-devel] [PATCH 2/2] cirrus: replace debug printf with trace points

2017-02-08 Thread Laurent Vivier
On 08/02/2017 14:51, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Laurent Vivier > --- > hw/display/cirrus_vga.c | 11 +-- > hw/display/trace-events | 6 ++ > 2 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/displ

[Qemu-devel] [Bug 1657538] Re: qemu 2.7.x 2.8 softmmu dont work on BE machine

2017-02-08 Thread luigiburdo
Oh my gosh the great Cameron Kaiser :) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1657538 Title: qemu 2.7.x 2.8 softmmu dont work on BE machine Status in QEMU: New Bug description: Build o

Re: [Qemu-devel] [PATCH v3] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-08 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > Migration of a "none" machine with no RAM crashes abruptly as > bitmap_new() fails and thus aborts. Instead place zero RAM checks at > appropriate places to skip migration of RAM in this case and complete > migration successfully for devices o

[Qemu-devel] [PATCH 1/2] numa: Turn simple union NumaOptions into a flat union

2017-02-08 Thread Markus Armbruster
Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They're best avoided in new code. NumaOptions isn't new, but it's only used internally, not in QMP. Convert it to

[Qemu-devel] [PATCH 0/2] Flatten simple unions where we still can

2017-02-08 Thread Markus Armbruster
Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They're best avoided in new code. But we can do more: we can flatten the simple unions that aren't used in QMP. I

[Qemu-devel] [PATCH 2/2] net: Turn simple union NetLegacyOptions into a flat union

2017-02-08 Thread Markus Armbruster
Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They're best avoided in new code. NetLegacyOptions isn't new, but it's only used internally, not in QMP. Convert i

Re: [Qemu-devel] [PATCH] link to .xz files to save some bandwidth

2017-02-08 Thread Paolo Bonzini
On 08/02/2017 11:29, Daniel P. Berrange wrote: > > Saving GB's of bandwidth a day for our hosting site is a compelling > benefit, if that has direct impact on project running costs. It doesn't but only because we're well within what the host is willing to donate to QEMU. Paolo > Shorter > dow

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-08 Thread Alexander Graf
On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31, Alexander Graf wrote: QEMU emulated hardware is always dma coherent with its guest. We do annotate that correctly on the PCI host controller, but left out virtio-mmio. I

Re: [Qemu-devel] [Qemu-block] [PATCH v3 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-02-08 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:20 AM CET, "Daniel P. Berrange" wrote: > @@ -751,6 +757,23 @@ static int qcow2_update_options_prepare(BlockDriverState > *bs, > r->discard_passthrough[QCOW2_DISCARD_OTHER] = > qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false); > > +switch (s->c

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-08 Thread Laszlo Ersek
On 02/08/17 17:12, Alexander Graf wrote: > On 02/08/2017 04:29 PM, Laszlo Ersek wrote: >> CC'ing Ard and Shannon (I recall this property from earlier): >> >> On 02/08/17 14:31, Alexander Graf wrote: >>> QEMU emulated hardware is always dma coherent with its guest. We do >>> annotate that correctly

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-08 Thread Ard Biesheuvel
> On 8 Feb 2017, at 16:17, Laszlo Ersek wrote: > >> On 02/08/17 17:12, Alexander Graf wrote: >>> On 02/08/2017 04:29 PM, Laszlo Ersek wrote: >>> CC'ing Ard and Shannon (I recall this property from earlier): >>> On 02/08/17 14:31, Alexander Graf wrote: QEMU emulated hardware is always

[Qemu-devel] [PATCH v3 0/8] MIPS Boston board support

2017-02-08 Thread Yongbok Kim
This series introduces support for the MIPS Boston development board. It begins by introducing support for moving MIPS Coherence Manager GCRs which Boston software typically does to avoid conflicting with its flash memory region. An API is then added to retrieve the emulated MIPS GIC timer frequenc

[Qemu-devel] [PATCH v3 1/8] hw/mips_cmgcr: allow GCR base to be moved

2017-02-08 Thread Yongbok Kim
From: Paul Burton Support moving the GCR base address & updating the CPU's CP0 CMGCRBase register appropriately. This is required if a platform needs to move its GCRs away from other memory, as the MIPS Boston development board does to avoid its flash memory. Signed-off-by: Paul Burton Reviewed

[Qemu-devel] [PATCH v3 3/8] hw/mips_gic: Update pin state on mask changes

2017-02-08 Thread Yongbok Kim
From: Paul Burton If the GIC interrupt mask is changed by a write to the smask (set mask) or rmask (reset mask) registers, we need to re-evaluate the state of the pins/IRQs fed to the CPU. Without doing so we risk leaving a pin high despite the interrupt that led to that state being masked, or lo

[Qemu-devel] [PATCH v3 2/8] hw/mips_gictimer: provide API for retrieving frequency

2017-02-08 Thread Yongbok Kim
From: Paul Burton Provide a new function mips_gictimer_get_freq() which returns the frequency at which a GIC timer will count. This will be useful for boards which perform setup based upon this frequency. Signed-off-by: Paul Burton Reviewed-by: Leon Alrae Signed-off-by: Yongbok Kim --- hw/ti

Re: [Qemu-devel] [Qemu-block] [PATCH v3 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 05:15:34PM +0100, Alberto Garcia wrote: > On Thu 26 Jan 2017 11:18:20 AM CET, "Daniel P. Berrange" > wrote: > > > @@ -751,6 +757,23 @@ static int > > qcow2_update_options_prepare(BlockDriverState *bs, > > r->discard_passthrough[QCOW2_DISCARD_OTHER] = > > qe

[Qemu-devel] [PATCH v3 7/8] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

2017-02-08 Thread Yongbok Kim
From: Paul Burton Add support for emulating the Xilinx AXI Root Port Bridge for PCI Express as described by Xilinx' PG055 document. This is a PCIe controller that can be used with certain series of Xilinx FPGAs, and is used on the MIPS Boston board which will make use of this code. Signed-off-by

[Qemu-devel] [PATCH v3 4/8] target-mips: Provide function to test if a CPU supports an ISA

2017-02-08 Thread Yongbok Kim
From: Paul Burton Provide a new cpu_supports_isa function which allows callers to determine whether a CPU supports one of the ISA_ flags, by testing whether the associated struct mips_def_t sets the ISA flags in its insn_flags field. An example use of this is to allow boards which generate bootl

[Qemu-devel] [PATCH v3 5/8] dtc: Update requirement to v1.4.2

2017-02-08 Thread Yongbok Kim
From: Paul Burton In order to obtain fdt_first_subnode & fdt_next_subnode symbols from libfdt for use by a later patch, bump the requirement for dtc to v1.4.2 & the submodule to that same version. Signed-off-by: Paul Burton Reviewed-by: Yongbok Kim Signed-off-by: Yongbok Kim --- configure |

[Qemu-devel] virtio-scsi-pci iothread spins at 100%

2017-02-08 Thread Ed Swierk
Recently I noticed that when I configure a virtio-scsi-pci device using an iothread, as soon as the guest virtio-scsi driver loads, the iothread spins at 100%: -object iothread,id=iothread1 -device virtio-scsi-pci,iothread=iothread1 This occurs whether or not a disk is attached, with either pol

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-02-08 Thread Stafford Horne
Hello, On Wed, Feb 08, 2017 at 11:01:20PM +0900, Stafford Horne wrote: > On Mon, Feb 06, 2017 at 09:53:26PM -0800, Richard Henderson wrote: > > On 02/01/2017 02:04 AM, Stafford Horne wrote: > > > For kernel builds I have created toolchain binaries here: > > > > > > http://shorne.noip.me/crossto

[Qemu-devel] [PATCH v3 6/8] loader: Support Flattened Image Trees (FIT images)

2017-02-08 Thread Yongbok Kim
From: Paul Burton Introduce support for loading Flattened Image Trees, as used by modern U-Boot. FIT images are essentially flattened device tree files which contain binary images such as kernels, FDTs or ramdisks along with one or more configuration nodes describing boot configurations. The MIP

[Qemu-devel] [PATCH v3 8/8] hw/mips: MIPS Boston board support

2017-02-08 Thread Yongbok Kim
From: Paul Burton Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs and the software intended

Re: [Qemu-devel] virtio-scsi-pci iothread spins at 100%

2017-02-08 Thread Ed Swierk
On Wed, Feb 8, 2017 at 8:33 AM, Ed Swierk wrote: > Recently I noticed that when I configure a virtio-scsi-pci device > using an iothread, as soon as the guest virtio-scsi driver loads, the > iothread spins at 100%: > > -object iothread,id=iothread1 -device virtio-scsi-pci,iothread=iothread1 > >

[Qemu-devel] [PATCH] ide: remove undefined behavior in ide-test

2017-02-08 Thread John Snow
trivial: initialize the dirty buffer with a random-ish byte. Stops valgrind from whining about uninitialized buffers. Signed-off-by: John Snow --- tests/ide-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 2fa97bc..139ebc0 100644 --- a/tests/id

Re: [Qemu-devel] [qcow2] how to avoid qemu doing lseek(SEEK_DATA/SEEK_HOLE)?

2017-02-08 Thread Stephane Chazelas
2017-02-08 15:27:11 +0100, Max Reitz: [...] > A bit of a stupid question, but: How is your performance when using > detect-zeroes=off? [...] I did try that. See: } Note that passing detect-zeroes=off or detect-zeroes=unmap (with } discard) doesn't help (even though FALLOC_FL_PUNCH_HOLE is } suppo

[Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-08 Thread Andrea Bolognani
These are very much like the sample configuration files for q35, and can be used both as documentation and as a starting point for creating your own guest. Two sample configuration files are provided: * mach-virt-graphical.cfg can be used to start a fully-featured (USB, graphical console, e

[Qemu-devel] [PATCH v5 0/2] docs: Improve sample configuration files

2017-02-08 Thread Andrea Bolognani
The previous version of this series, that only included the first of the two patches, has already been reviewed by Gerd, but since it's not been pushed yet I figured I would post this as a full new series instead of an incremental improvement over the previous one. The big difference compared to t

[Qemu-devel] [PATCH v5 1/2] q35: Improve sample configuration files

2017-02-08 Thread Andrea Bolognani
Instead of having a single sample configuration file, we now have several: * q35-emulated.cfg documents the default devices QEMU adds to a q35 guest and the additional devices that are pretty much guaranteed to be present in a physical q35-based machine; * q35-virtio-graphical.cfg

  1   2   3   >