Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Zhang Chen
On 02/06/2017 04:13 PM, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'seconda

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add float128_to_uint64_round_to_zero()

2017-02-06 Thread Bharata B Rao
On Fri, Feb 03, 2017 at 03:39:16PM +, Peter Maydell wrote: > On 3 February 2017 at 15:12, Bharata B Rao wrote: > > On Fri, Feb 03, 2017 at 02:40:09PM +, Peter Maydell wrote: > >> On 1 February 2017 at 10:49, Bharata B Rao > >> wrote: > >> > Implement float128_to_uint64() and use that to

Re: [Qemu-devel] [PATCH 05/22] main: free root container

2017-02-06 Thread Paolo Bonzini
On 02/02/2017 15:51, Marc-André Lureau wrote: > This should eventually free all objects that are only referenced by > their parents. > > Signed-off-by: Marc-André Lureau > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index 0b72b12878..945df1d17f 100644 > -

Re: [Qemu-devel] [PATCH 3/3] colo-compare: use notifier to notify inconsistent packets comparing

2017-02-06 Thread Hailiang Zhang
On 2017/2/3 12:50, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 24 ++-- net/colo

Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container

2017-02-06 Thread Paolo Bonzini
On 02/02/2017 15:51, Marc-André Lureau wrote: > +if (QTAILQ_IN_USE(chr, next)) { > +QTAILQ_REMOVE(&chardevs, chr, next); > +} > +if (OBJECT(chr)->parent) { > +object_unparent(OBJECT(chr)); > +} else { > +object_unref(OBJECT(chr)); > +} What's the case

Re: [Qemu-devel] [PATCH 11/22] qcow2: remove useless NULL check

2017-02-06 Thread Paolo Bonzini
On 02/02/2017 15:51, Marc-André Lureau wrote: > g_strdup() already handles the case where the argument is NULL. > > Signed-off-by: Marc-André Lureau > --- > block/qcow2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 96fb8a8

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary

Re: [Qemu-devel] [PATCH 3/3] colo-compare: use notifier to notify inconsistent packets comparing

2017-02-06 Thread Jason Wang
On 2017年02月06日 16:44, Hailiang Zhang wrote: On 2017/2/3 12:50, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-comp

Re: [Qemu-devel] [PATCH v3] vl: Move the cpu_synchronize_all_post_init() after generic devices initialization

2017-02-06 Thread Paolo Bonzini
CCing Eduardo. On 01/02/2017 03:29, Dou Liyang wrote: > At the Qemu initialization, we call the cpu_synchronize_all_post_init() > to synchronize All CPU states to KVM in the ./vl.c::main(). > > Currently, it is called before we initialize the CPUs, which is created > by "-device" command and pars

Re: [Qemu-devel] [PATCH] apic: reset apic_delivered global variable on machine reset

2017-02-06 Thread Paolo Bonzini
On 31/01/2017 12:40, Pavel Dovgalyuk wrote: > This patch adds call to apic_reset_irq_delivered when the virtual > machine is reset. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/intc/apic_common.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/intc/apic_common.c b/hw/intc/ap

Re: [Qemu-devel] [PATCH] char: drop data written to a disconnected pty

2017-02-06 Thread Paolo Bonzini
On 31/01/2017 14:45, Ed Swierk wrote: > When a serial port writes data to a pty that's disconnected, drop the > data and return the length dropped. This avoids triggering pointless > retries in callers like the 16550A serial_xmit(), and causes > qemu_chr_fe_write() to write all data to the log fi

Re: [Qemu-devel] [PATCH v7 1/2] move vm_start to cpus.c

2017-02-06 Thread Paolo Bonzini
On 27/01/2017 19:11, Claudio Imbrenda wrote: > +} > + > +/* XXX: is it ok to send this even before actually resuming the CPUs? */ > +qapi_event_send_resume(&error_abort); > +return res; > +} > + Yes, it is. :) Paolo

Re: [Qemu-devel] [PATCH v7 2/2] gdbstub: Fix vCont behaviour

2017-02-06 Thread Paolo Bonzini
On 27/01/2017 19:11, Claudio Imbrenda wrote: > +/* mark valid CPUs with 1 */ > +CPU_FOREACH(cpu) { > +newstates[cpu_index(cpu) - 1] = 1; > +} Sorry I didn't notice this before: CPU indices are zero-based in QEMU, so you are probably overwriting newstates[-1]. I can adjust it

Re: [Qemu-devel] [PATCH] hw/vfio/pci-quirks: Set category of the "vfio-pci-igd-lpc-bridge" device

2017-02-06 Thread Thomas Huth
On 03.02.2017 19:10, Alex Williamson wrote: > On Tue, 24 Jan 2017 09:02:38 +0100 > Thomas Huth wrote: > >> The device has "bridge" in its name, so it should obviously be in >> the category DEVICE_CATEGORY_BRIDGE. > > Well, physical device is a bridge, but this is really just a stub. > Does that

[Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-06 Thread Dr. David Alan Gilbert
Hi Matwey, 1) Can you provide me with the output of the 'dmesg' command straight after boot on your host. 2) If you look in target/i386/kvm.c in kvm_arch_init_vcpu around line 871 is some code like: if ((ver & 0xff) > 0) { has_msr_architectural_pmu = true; num

Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Ed Robbins
On 3 February 2017 14:46:15 GMT+00:00, Stefan Hajnoczi wrote: >On Thu, Feb 02, 2017 at 12:09:02PM +, E.Robbins wrote: >> I having been looking for prior work on a formalised semantics for >the TCG language. I have seen passing references, and wondered if >anyone can provide any pointers? >>

Re: [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests

2017-02-06 Thread Fam Zheng
On Sat, 01/28 05:59, Nir Soffer wrote: > From: Nir Soffer > > Add regression tests checking that qemu-io fail with non-zero exit code > when reading non-existing file or using the wrong format. > > Signed-off-by: Nir Soffer This message is not correctly threaded as a reply to a v3 cover letter

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > [...] > >> >> === Structured values === > >> >> > >> >> The

[Qemu-devel] [PATCH 1/4] target-ppc: implement load atomic instruction

2017-02-06 Thread Nikunj A Dadhania
From: Balamuruhan S lwat: Load Word Atomic ldat: Load Doubleword Atomic The instruction includes as function code (5 bits) which gives a detail on the operation to be performed. The patch implements five such functions. Signed-off-by: Balamuruhan S Signed-off-by: Harish S Signed-off-by: Athir

[Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part14

2017-02-06 Thread Nikunj A Dadhania
This series contains 8 new instructions for POWER9 ISA3.0 VSX Scalar Maximum DP VSX Scalar Minimum DP Load/Store Atomic instructions Balamuruhan S (2): target-ppc: implement load atomic instruction target-ppc: implement store atomic instruction Bharata B Rao (2): target-ppc: Add

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-02-06 Thread Daniel P. Berrange
On Fri, Feb 03, 2017 at 07:56:11PM +0100, Max Reitz wrote: > > In case you say that's inconvenient: pretty much everything about dd's > > archaic user interface is inconvenient. If you want convenient, roll > > your own. If you want familiar, stick to the original. > > I agree. But qemu-img dd a

[Qemu-devel] [PATCH 2/4] target-ppc: implement store atomic instruction

2017-02-06 Thread Nikunj A Dadhania
From: Balamuruhan S stwat: Store Word Atomic stdat: Store Doubleword Atomic The instruction includes as function code (5 bits) which gives a detail on the operation to be performed. The patch implements five such functions. Signed-off-by: Balamuruhan S Signed-off-by: Harish S Signed-off-by: A

[Qemu-devel] [PATCH 3/4] target-ppc: Add xsmaxcdp and xsmincdp instructions

2017-02-06 Thread Nikunj A Dadhania
From: Bharata B Rao xsmaxcdp: VSX Scalar Maximum Type-C Double-Precision xsmincdp: VSX Scalar Minimum Type-C Double-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 38 + target/ppc/helper.h

Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"

2017-02-06 Thread Daniel P. Berrange
On Sun, Feb 05, 2017 at 12:39:45AM +0200, Lluís Vilanova wrote: > Fam Zheng writes: > > > We install this file to data dir but since 0ab8ed18 it's no longer > > required by any objects during "make". List it explicitly as a depended > > target of install and fix the broken "make install" command.

Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 10:14, Ed Robbins wrote: > It seems pretty good. I was surprised that call instructions can > have arguments/return specified, and wonder if those are normally > just empty, so that emulation of the target stack/registers just > carries the args/return in the background. Othe

Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. > > Signed-off-by: Fam Zheng > -

[Qemu-devel] [PATCH 4/4] target-ppc: Add xsmaxjdp and xsminjdp instructions

2017-02-06 Thread Nikunj A Dadhania
From: Bharata B Rao xsmaxjdp: VSX Scalar Maximum Type-J Double-Precision xsminjdp: VSX Scalar Minimum Type-J Double-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target/ppc/fpu_helper.c | 55 + target/ppc/helper.h

[Qemu-devel] [Bug 1661815] Re: Stack address is returned from function translate_one

2017-02-06 Thread Thomas Huth
The calling function never uses "->fields", so I do not see a real vulnerability here, is there? Did you use a code analyser for this, or how did you come across this issue? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

Re: [Qemu-devel] [PATCH] hw/char/mcf_uart: QOMify the ColdFire UART

2017-02-06 Thread Paolo Bonzini
On 28/01/2017 07:56, Thomas Huth wrote: > Use type_init() etc. to adapt the ColdFire UART > to the latest QEMU device conventions. > > Signed-off-by: Thomas Huth > --- > hw/char/mcf_uart.c| 102 > +- > hw/m68k/mcf5208.c | 6 +-- > incl

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add float128_to_uint64_round_to_zero()

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 08:58, Bharata B Rao wrote: > On Fri, Feb 03, 2017 at 03:39:16PM +, Peter Maydell wrote: >> On 3 February 2017 at 15:12, Bharata B Rao >> wrote: >> > As I said above, it is based on float128_to_int64() >> >> Ah, right. I think that's probably a bad model to copy because

Re: [Qemu-devel] [PATCH v4 1/8] make: move top level dir to end of include search path

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 05:48:01PM +0200, Alberto Garcia wrote: > On Wed, Jan 25, 2017 at 04:14:10PM +, Daniel P. Berrange wrote: > > > One final complication is that the absolute '-I$(BUILD_DIR)/$(@D)' > > will sometimes end up pointing to a non-existant directory if > > that sub-dir does not

Re: [Qemu-devel] TCG semantics

2017-02-06 Thread Ed Robbins
On 6 February 2017 10:39:11 GMT+00:00, Peter Maydell wrote: >On 6 February 2017 at 10:14, Ed Robbins wrote: >> It seems pretty good. I was surprised that call instructions can >> have arguments/return specified, and wonder if those are normally >> just empty, so that emulation of the target st

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Daniel P. Berrange
On Sat, Feb 04, 2017 at 08:21:50PM +0800, Fam Zheng wrote: > On Thu, 02/02 20:42, Markus Armbruster wrote: > > === Comparison === > > > > In my opinion, dotted keys are weird and ugly, but at least they don't > > add to the quoting mess. Structured values look better, except when > > they do add

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues w

[Qemu-devel] [PULL 5/9] xhci: rename xhci_complete_packet to xhci_try_complete_packet

2017-02-06 Thread Gerd Hoffmann
Make clear that this isn't guaranteed to actually complete the transfer, the usb packet can still be in flight after calling that function. Signed-off-by: Gerd Hoffmann Message-id: 1485790607-31399-3-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 12 ++-- 1 file changed, 6 inse

[Qemu-devel] [PULL 8/9] usb: ccid: check ccid apdu length

2017-02-06 Thread Gerd Hoffmann
From: Prasad J Pandit CCID device emulator uses Application Protocol Data Units(APDU) to exchange command and responses to and from the host. The length in these units couldn't be greater than 65536. Add check to ensure the same. It'd also avoid potential integer overflow in emulated_apdu_from_gu

[Qemu-devel] [PULL 6/9] xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer

2017-02-06 Thread Gerd Hoffmann
xhci_submit and xhci_fire_ctl_transfer are is called from xhci_kick_epctx processing loop only, so there is no need to call xhci_kick_epctx make sure processing continues. Also eecursive calls into xhci_kick_epctx can cause trouble. Drop the xhci_kick_epctx calls. Cc: 1653...@bugs.launchpad.net

[Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread Gerd Hoffmann
#x27; into staging (2017-02-03 14:41:49 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20170206-1 for you to fetch changes up to 7da76e12cc5cc902dda4c168d8d608fd4e61cbc5: xhci: fix event queue IRQ handling (2017-02-06 12:1

[Qemu-devel] [PULL 7/9] xhci: guard xhci_kick_epctx against recursive calls

2017-02-06 Thread Gerd Hoffmann
Track xhci_kick_epctx processing being active in a variable. Check the variable before calling xhci_kick_epctx from xhci_kick_ep. Add an assert to make sure we don't call recursively into xhci_kick_epctx. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by:

[Qemu-devel] [PULL 1/9] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-02-06 Thread Gerd Hoffmann
From: Phil Dennis-Jordan 1. Set bInterfaceProtocol to 0x00 for usb-tablet. This should be non-zero for boot protocol devices only, which the usb-tablet is not. 2. Set the usb-tablet's usage to "mouse" in the report descriptor. The boot protocol of 0x02 specifically confused OS X/macOS' HID

[Qemu-devel] [PULL 3/9] usb: accept usb3 control requests

2017-02-06 Thread Gerd Hoffmann
Windows 10 reportedly sends these, so accept them in case the device in question is a superspeed (usb3) device. Signed-off-by: Gerd Hoffmann Message-id: 1485870727-21956-2-git-send-email-kra...@redhat.com --- hw/usb/desc.c| 7 +++ include/hw/usb.h | 2 ++ 2 files changed, 9 insertions(+)

[Qemu-devel] [PULL 4/9] xhci: only free completed transfers

2017-02-06 Thread Gerd Hoffmann
Most callsites check already, one was missed. Cc: 1653...@bugs.launchpad.net Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by: Fabian Lesniak Signed-off-by: Gerd Hoffmann Message-id: 1485790607-31399-2-git-send-email-kra...@redhat.com --- hw/usb/hcd-xhci.c | 4 +++- 1 file changed, 3

[Qemu-devel] [PULL 9/9] xhci: fix event queue IRQ handling

2017-02-06 Thread Gerd Hoffmann
The qemu xhci emulation doesn't handle the ERDP_EHB flag correctly. When the host adapter queues a new event the ERDP_EHB flag is set. The flag is cleared (via w1c) by the guest when it updates the ERDP (event ring dequeue pointer) register to notify the host adapter which events it has fetched.

[Qemu-devel] [PULL 2/9] usb/uas: more verbose error message

2017-02-06 Thread Gerd Hoffmann
Print some more details in case we get a unknown control request, to ease trouble-shooting. Signed-off-by: Gerd Hoffmann Message-id: 1485870727-21956-1-git-send-email-kra...@redhat.com --- hw/usb/dev-uas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-uas.c b/h

Re: [Qemu-devel] QEMU Wiki

2017-02-06 Thread Peter Maydell
On 3 February 2017 at 22:21, Jonathan Michael Stryer wrote: > Hello, > > > Could I have someone create me an account for the QEMU wiki? Sure; what username do you want? thanks -- PMM

[Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
In commit ba78db44f6532d66a1e704bd44613e841baa2fc5 Author: Daniel P. Berrange Date: Wed Jan 25 16:14:10 2017 + make: move top level dir to end of include search path The dir $(BUILD_DIR)/$(@D) was added to the include path. This would sometimes point to a non-existant directory, i

Re: [Qemu-devel] [PATCH 03/17] migration: split common postcopy out of ram postcopy

2017-02-06 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 01.02.2017 14:06, Vladimir Sementsov-Ogievskiy wrote: > > 24.01.2017 22:53, Dr. David Alan Gilbert wrote: > > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > > 24.01.2017 12:24, Juan Quintela wrote: > > > >

Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci. Message-id: 1486380501-13431-1-git-send-email-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Alberto Garcia
On Mon 06 Feb 2017 12:29:53 PM CET, "Daniel P. Berrange" wrote: > Rather than trying to workaround this, just revert the code that > attempted to mkdir the missing include directories. Instead just turn > off the compiler warning in question as the missing dir is expected & > harmless in general.

Re: [Qemu-devel] [PULL 0/3] isa-cleanup queue 20170206

2017-02-06 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/isa-cleanup-20170206 > > for you to fetch changes up to c124c4d13bcb19fc866e7f6de075f906fca6af4a: > > Split ISA and sysbus versions of m48t59 device (2017-02-06 12:33:21 +1100) > >

[Qemu-devel] libslirp and QEMU slirp

2017-02-06 Thread Stefan Hajnoczi
Hi, There was a talk about new developments in VDEplug at FOSDEM 2017. The QEMU slirp code has been extracted into a library: https://fosdem.org/2017/schedule/event/iaas_modvde/ QEMU's slirp code does not have many contributors. Other projects using slirp are probably in this situation too. Spin

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Peter Maydell
On 6 February 2017 at 11:29, Daniel P. Berrange wrote: > In > > commit ba78db44f6532d66a1e704bd44613e841baa2fc5 > Author: Daniel P. Berrange > Date: Wed Jan 25 16:14:10 2017 + > > make: move top level dir to end of include search path > > The dir $(BUILD_DIR)/$(@D) was added to the

[Qemu-devel] [PATCH 3/4] xhci: fix nec vendor quirk handling

2017-02-06 Thread Gerd Hoffmann
Only the TYPE_NEC_XHCI controller will have the nec vendor quirks. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 887bb39..0e25943 10

[Qemu-devel] [PATCH 0/4] xhci: cleanups, add qemu-xhci device.

2017-02-06 Thread Gerd Hoffmann
Hi, This series adds a new qemu-xhci device. It is pretty much identical to the existing nec-usb-xhci device, except that some quirks needed to make the nec/renesas windows driver work will be disabled for the qemu-xhci device. And qemu-xhci gets a PCI ID from the qemu PCi ID range. please re

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-02-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 03/02/2017 07:00, Stefan Hajnoczi wrote: > > On Thu, Feb 02, 2017 at 07:05:30AM -0800, Paolo Bonzini wrote: > >> The replication feature is a small amount of code, does not > >> require any external library and unless used does not add > >> an

[Qemu-devel] [PATCH 4/4] xhci: drop via vendor command handling

2017-02-06 Thread Gerd Hoffmann
Seems pretty pointless, we don't emulate an via xhci controller. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 0e25943..fbf8a8b 100644 --- a/hw/usb/hcd-xhci.c +++

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add float128_to_uint64_round_to_zero()

2017-02-06 Thread Bharata B Rao
On Mon, Feb 06, 2017 at 10:31:49AM +, Peter Maydell wrote: > On 6 February 2017 at 08:58, Bharata B Rao wrote: > > On Fri, Feb 03, 2017 at 03:39:16PM +, Peter Maydell wrote: > >> On 3 February 2017 at 15:12, Bharata B Rao > >> wrote: > >> > As I said above, it is based on float128_to_int

[Qemu-devel] [PATCH 1/4] xhci: drop ER_FULL_HACK workaround

2017-02-06 Thread Gerd Hoffmann
The nec/renesas driver problems have finally been debugged and root caused, see commit "7da76e1 xhci: fix event queue IRQ handling". It's pretty clear now that (a) The whole "driver can't handle ring full" story is most likely wrong. (b) The ER_FULL_HACK workaround based on the false assumt

[Qemu-devel] [PATCH 2/4] xhci: add qemu xhci controller

2017-02-06 Thread Gerd Hoffmann
Turn existing TYPE_XHCI into an abstract base class. Create two child classes, TYPE_NEC_XHCI (same name as old xhci controller) and TYPE_QEMU_XHCI (using an ID from our namespace). Signed-off-by: Gerd Hoffmann --- docs/specs/pci-ids.txt | 1 + hw/usb/hcd-xhci.c | 40 +++

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 11:50:09AM +, Peter Maydell wrote: > On 6 February 2017 at 11:29, Daniel P. Berrange wrote: > > In > > > > commit ba78db44f6532d66a1e704bd44613e841baa2fc5 > > Author: Daniel P. Berrange > > Date: Wed Jan 25 16:14:10 2017 + > > > > make: move top level dir

[Qemu-devel] [PATCH] xhci: apply limits to loops

2017-02-06 Thread Gerd Hoffmann
Limits should be big enough that normal guest should not hit it. Add a tracepoint to log them, just in case. Also, while being at it, log the existing link trb limit too. Reported-by: 李强 Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 15 ++- hw/usb/trace-events | 1 + 2 fi

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Paolo Bonzini
On 06/02/2017 13:05, Daniel P. Berrange wrote: >>> $(shell mkdir -p ./ $(sort $(dir $($v >>> -$(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v >> I know this is the same syntax as the existing line above >> and we're deleting it anyway, but what does it actually d

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 01:22:08PM +0100, Paolo Bonzini wrote: > > > On 06/02/2017 13:05, Daniel P. Berrange wrote: > >>> $(shell mkdir -p ./ $(sort $(dir $($v > >>> -$(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v > >> I know this is the same syntax as the exist

Re: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci.

2017-02-06 Thread Peter Maydell
afeed940dd4cba: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-03 14:41:49 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-usb-20170206-1 > > for you to fetch

[Qemu-devel] [Bug 1661815] Re: Stack address is returned from function translate_one

2017-02-06 Thread shqking
Thanks for your reply. Inspired by this issue in apache httpd (https://bz.apache.org/bugzilla/show_bug.cgi?id=59844#c0), we customized a checker based on the Clang Static Analyzer to detect such undefined behavior. Yes. After examining the code carefully, we didn't find any place where the "-

[Qemu-devel] [Block Replication] Question about supporting COLO in libvirt

2017-02-06 Thread Hailiang Zhang
Hi, I'm trying to implement supporting COLO in libvirt, But i found an annoying problem that libvirt does not support the command line option argument syntax we used for block replication in QEMU. That is libvirt does not support the bellow syntax for block: -drive driver=qcow2,file.filename=test

Re: [Qemu-devel] [libvirt] [Block Replication] Question about supporting COLO in libvirt

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 08:34:28PM +0800, Hailiang Zhang wrote: > Hi, > I'm trying to implement supporting COLO in libvirt, > But i found an annoying problem that libvirt does not > support the command line option argument syntax we used > for block replication in QEMU. > > That is libvirt does no

Re: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

2017-02-06 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 18:24 +, Peter Maydell wrote: > The functions vnc_has_job() and vnc_jobs_clear() are > never used; remove them. Added to ui patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to prote

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-02-06 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2017年01月26日 11:04, Zhang Chen wrote: > > Hi~ > > > > No news for a week. > > > > We need comments ~~ > > > > Ping... > > > > Cc David who is one of the maintainer of migration. My difficulty is I don't know any Xen and I don't understand th

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-06 Thread Kevin Wolf
Am 02.02.2017 um 20:42 hat Markus Armbruster geschrieben: > = Brief recap of dotted key convention = > > We'll discuss use of dotted key convention later, so let me explain it > briefly for the readers who don't know it already. > > The dotted key convention interprets the KEY part as a sequence

[Qemu-devel] [PATCH] qemu-option: reject empty number value

2017-02-06 Thread Marc-André Lureau
When no number is provided, return an invalid number error. (note: this may break some users relying on default 0 value) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1417864 Signed-off-by: Marc-André Lureau --- util/qemu-option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH V2 02/10] qemu-clk: allow to add a clock to a device

2017-02-06 Thread Cédric Le Goater
On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This allows to add a clock to a DeviceState. > Contrary to gpios, the clock pins are not contained in the DeviceState but > with the child property so they can appears in the qom-tree. > > Signed-off-by: KONRAD

[Qemu-devel] [PATCH v4] Add wctablet device

2017-02-06 Thread Gerd Hoffmann
From: Anatoli Huseu1 Add QEMU Wacom Penpartner serial tablet emulation. GSoC 2016 project. Signed-off-by: Anatoli Huseu1 Various cleanups. Add line speed tracking. Implement ST and SP commands. Adapted to chardev QOMification. Signed-off-by: Gerd Hoffmann --- Makefile.objs| 1

Re: [Qemu-devel] [PATCH v3] Add wctablet device

2017-02-06 Thread Gerd Hoffmann
Hi, > +cc->chr_free = wctablet_chr_free; > > > chr_free is going away in the last pull request, you can replace it > with qom finalize. Yep, saw the patches already, rebased now, v4 is on the way. cheers, Gerd

Re: [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests

2017-02-06 Thread Nir Soffer
This was created by mistake with --no-thread and no cover letter, I was confused by the instructions in the wiki, warning not to send multiple patches in the same thread. I already sent v4 and v5 properly. Thanks for the comments, Nir On Mon, Feb 6, 2017 at 12:20 PM, Fam Zheng wrote: > On Sat,

Re: [Qemu-devel] [PATCH v3 0/8] Support multiple listening sockets per VNC server

2017-02-06 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 12:06 +, Daniel P. Berrange wrote: > Followup to > > v2: > https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04951.html > > There are two core feature changes in this series > > - If a DNS name resolves to multiple distinct IP addresses, >the VNC server is n

Re: [Qemu-devel] [PATCH v2] vnc: do not disconnect on EAGAIN

2017-02-06 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 12:52 +0300, Michael Tokarev wrote: > When qemu vnc server is trying to send large update to clients, > there might be a situation when system responds with something > like EAGAIN, indicating that there's no system memory to send > that much data (depending on the network spee

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in set scanout

2017-02-06 Thread Gerd Hoffmann
On Sa, 2017-01-21 at 23:42 -0800, Li Qiang wrote: > From: Li Qiang > > In virtio_gpu_set_scanout function, when creating the 'rect' > its refcount is set to 2, by pixman_image_create_bits and > qemu_create_displaysurface_pixman function. This can lead > a memory leak issues. This patch avoid thi

Re: [Qemu-devel] [PATCH v3 2/3] qemu-io: Add regression tests

2017-02-06 Thread Fam Zheng
On Mon, 02/06 16:25, Nir Soffer wrote: > This was created by mistake with --no-thread and no cover letter, I > was confused by the instructions in the wiki, warning not to send > multiple patches in the same thread. > > I already sent v4 and v5 properly. Nice, I didn't notice it! (My mailbox is o

[Qemu-devel] [PATCH qemu-web] add tag for /feed.xml

2017-02-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Just an example of what a website patch would look like. _includes/assets.html | 1 + 1 file changed, 1 insertion(+) diff --git a/_includes/assets.html b/_includes/assets.html index e3f09e0..77c2942 100644 --- a/_includes/assets.html +++ b/_includes/asse

Re: [Qemu-devel] [PATCH v2 2/2] target/arm: A32, T32: Create Instruction Syndromes for Data Aborts

2017-02-06 Thread Peter Maydell
On 4 February 2017 at 14:31, Edgar E. Iglesias wrote: > On Fri, Feb 03, 2017 at 05:48:55PM +, Peter Maydell wrote: >> Add support for generating the ISS (Instruction Specific Syndrome) >> for Data Abort exceptions taken from AArch32. These syndromes are >> used by hypervisors for example to tr

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-06 Thread Michael S. Tsirkin
On Sun, Feb 05, 2017 at 01:11:57AM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > This adds to the existing 'add pointer' functionality in that it > instructs the guest (BIOS or UEFI) to not patch memory but to instead > write the changes back to QEMU via a writeable fw_cfg file. >

Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code

2017-02-06 Thread Greg Kurz
On Fri, 3 Feb 2017 06:57:23 -0500 Pradeep Jagadeesh wrote: > This patch removes the redundant throttle code that was present in > block and fsdev device files. Now the common code is moved > to a single file. > > Signed-off-by: Pradeep Jagadeesh > > https://lists.gnu.org/archive/html/qemu-dev

Re: [Qemu-devel] [PATCH v2 2/2] target/arm: A32, T32: Create Instruction Syndromes for Data Aborts

2017-02-06 Thread Edgar E. Iglesias
On Mon, Feb 06, 2017 at 02:53:49PM +, Peter Maydell wrote: > On 4 February 2017 at 14:31, Edgar E. Iglesias > wrote: > > On Fri, Feb 03, 2017 at 05:48:55PM +, Peter Maydell wrote: > >> Add support for generating the ISS (Instruction Specific Syndrome) > >> for Data Abort exceptions taken

Re: [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code

2017-02-06 Thread Pradeep Jagadeesh
On 2/6/2017 3:58 PM, Greg Kurz wrote: On Fri, 3 Feb 2017 06:57:23 -0500 Pradeep Jagadeesh wrote: This patch removes the redundant throttle code that was present in block and fsdev device files. Now the common code is moved to a single file. Signed-off-by: Pradeep Jagadeesh https://lists.gn

[Qemu-devel] [PATCH v10 04/23] tcg: move TCG_MO/BAR types into own file

2017-02-06 Thread Alex Bennée
We'll be using the memory ordering definitions to define values for both the host and guest. To avoid fighting with circular header dependencies just move these types into their own minimal header. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v8 - add clarifying comment about

[Qemu-devel] [PATCH v10 03/23] mttcg: Add missing tb_lock/unlock() in cpu_exec_step()

2017-02-06 Thread Alex Bennée
From: Pranith Kumar The recent patch enabling lock assertions uncovered the missing lock acquisition in cpu_exec_step(). This patch adds them. Signed-off-by: Pranith Kumar Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpu-exec.c | 4 1 file changed, 4 insertions(+) diff

[Qemu-devel] [PATCH v10 02/23] mttcg: translate-all: Enable locking debug in a debug build

2017-02-06 Thread Alex Bennée
From: Pranith Kumar Enable tcg lock debug asserts in a debug build by default instead of relying on DEBUG_LOCKING. None of the other DEBUG_* macros have asserts, so this patch removes DEBUG_LOCKING and enable these asserts in a debug build. CC: Richard Henderson Signed-off-by: Pranith Kumar [A

[Qemu-devel] [PATCH v10 00/23] MTTCG Base enabling patches with ARM enablement

2017-02-06 Thread Alex Bennée
Hi Richard/Peter, This is a mostly ARM focused update to last weeks v9. It has necessitated one change to the cputlb API. It was pointed out that translators often have to special case a bunch of things if you longjmp() out of a helper. As a result the cputlb _synched() calls are no longer QEMU_N

[Qemu-devel] [PATCH v10 08/23] tcg: drop global lock during TCG code execution

2017-02-06 Thread Alex Bennée
From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or when leaving the TCG loop. We have to revert a few optimization for the current TCG threading mode

[Qemu-devel] [PATCH v10 06/23] tcg: add kick timer for single-threaded vCPU emulation

2017-02-06 Thread Alex Bennée
Currently we rely on the side effect of the main loop grabbing the iothread_mutex to give any long running basic block chains a kick to ensure the next vCPU is scheduled. As this code is being re-factored and rationalised we now do it explicitly here. Signed-off-by: Alex Bennée Reviewed-by: Richa

[Qemu-devel] [PATCH v10 07/23] tcg: rename tcg_current_cpu to tcg_current_rr_cpu

2017-02-06 Thread Alex Bennée
..and make the definition local to cpus. In preparation for MTTCG the concept of a global tcg_current_cpu will no longer make sense. However we still need to keep track of it in the single-threaded case to be able to exit quickly when required. qemu_cpu_kick_no_halt() moves and becomes qemu_cpu_ki

[Qemu-devel] [PATCH v10 01/23] docs: new design document multi-thread-tcg.txt

2017-02-06 Thread Alex Bennée
This documents the current design for upgrading TCG emulation to take advantage of modern CPUs by running a thread-per-CPU. The document goes through the various areas of the code affected by such a change and proposes design requirements for each part of the solution. The text marked with (Curren

[Qemu-devel] [PATCH v10 10/23] tcg: enable tb_lock() for SoftMMU

2017-02-06 Thread Alex Bennée
tb_lock() has long been used for linux-user mode to protect code generation. By enabling it now we prepare for MTTCG and ensure all code generation is serialised by this lock. The other major structure that needs protecting is the l1_map and its PageDesc structures. For the SoftMMU case we also use

[Qemu-devel] [PATCH v10 05/23] tcg: add options for enabling MTTCG

2017-02-06 Thread Alex Bennée
From: KONRAD Frederic We know there will be cases where MTTCG won't work until additional work is done in the front/back ends to support. It will however be useful to be able to turn it on. As a result MTTCG will default to off unless the combination is supported. However the user can turn it on

[Qemu-devel] [PATCH v10 12/23] tcg: handle EXCP_ATOMIC exception for system emulation

2017-02-06 Thread Alex Bennée
From: Pranith Kumar The patch enables handling atomic code in the guest. This should be preferably done in cpu_handle_exception(), but the current assumptions regarding when we can execute atomic sections cause a deadlock. Signed-off-by: Pranith Kumar [AJB: tweak title] Signed-off-by: Alex Benn

[Qemu-devel] [PATCH v10 14/23] cputlb: tweak qemu_ram_addr_from_host_nofail reporting

2017-02-06 Thread Alex Bennée
This moves the helper function closer to where it is called and updates the error message to report via error_report instead of the deprecated fprintf. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cputlb.c | 24 1 file changed, 12 insertions(+), 12 dele

[Qemu-devel] [PATCH v10 17/23] cputlb: add tlb_flush_by_mmuidx async routines

2017-02-06 Thread Alex Bennée
This converts the remaining TLB flush routines to use async work when detecting a cross-vCPU flush. The only minor complication is having to serialise the var_list of MMU indexes into a form that can be punted to an asynchronous job. The pending_tlb_flush field on QOM's CPU structure also becomes

  1   2   3   >