Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Peter Lieven
Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: > > On 31/01/2017 07:36, Peter Lieven wrote: >> the current implementation fails if we try to freeze an >> already frozen filesystem. This can happen if a filesystem >> is mounted more than once (e.g. with a bind mount). >> >> Suggested-by: Christian Th

[Qemu-devel] [PATCH v6 00/18] VT-d: vfio enablement and misc enhances

2017-02-03 Thread Peter Xu
This is v6 of vt-d vfio enablement series. v6 - do unmap in all cases when replay [Jason] - do global replay even if context entry is invalidated [Jason] - when iommu reset, send unmap to all registered notifiers [Jason] - use rcu read lock to protect the whole vfio_iommu_map_notify() [Alex, Pao

[Qemu-devel] [PATCH v6 01/18] vfio: trace map/unmap for notify as well

2017-02-03 Thread Peter Xu
We traces its range, but we don't know whether it's a MAP/UNMAP. Let's dump it as well. Acked-by: Alex Williamson Signed-off-by: Peter Xu --- hw/vfio/common.c | 3 ++- hw/vfio/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/comm

[Qemu-devel] [PATCH v6 03/18] vfio: allow to notify unmap for very large region

2017-02-03 Thread Peter Xu
Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big region. This can be leveraged by QEMU IOMMU implementation to cleanup existing page mappings for an entire iova address space (by notifying with an IOTLB with extremely huge addr_mask). However current vfio_iommu_map_notify() does

[Qemu-devel] [PATCH v6 04/18] intel_iommu: add "caching-mode" option

2017-02-03 Thread Peter Xu
From: Aviv Ben-David This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David [peterx: using "caching-mode" instead of "cache-mode" to align with spec] [peterx: re-write the

[Qemu-devel] [PATCH v6 14/18] memory: add MemoryRegionIOMMUOps.replay() callback

2017-02-03 Thread Peter Xu
Originally we have one memory_region_iommu_replay() function, which is the default behavior to replay the translations of the whole IOMMU region. However, on some platform like x86, we may want our own replay logic for IOMMU regions. This patch add one more hook for IOMMUOps for the callback, and i

[Qemu-devel] [PATCH v6 06/18] intel_iommu: renaming gpa to iova where proper

2017-02-03 Thread Peter Xu
There are lots of places in current intel_iommu.c codes that named "iova" as "gpa". It is really confusing to use a name "gpa" in these places (which is very easily to be understood as "Guest Physical Address", while it's not). To make the codes (much) easier to be read, I decided to do this once a

[Qemu-devel] [PATCH v6 02/18] vfio: introduce vfio_get_vaddr()

2017-02-03 Thread Peter Xu
A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if the operation is unmap, but it won't hurt much. One thing to mention is that we need the RCU read lock to protect the whole translation and map/unmap procedure. Signed-off-by: Peter Xu --- hw/vfio/common.c | 65 +

[Qemu-devel] [PATCH v6 05/18] intel_iommu: simplify irq region translation

2017-02-03 Thread Peter Xu
Now we have a standalone memory region for MSI, all the irq region requests should be redirected there. Cleaning up the block with an assertion instead. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff --g

[Qemu-devel] [PATCH v6 15/18] intel_iommu: provide its own replay() callback

2017-02-03 Thread Peter Xu
The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally consumes a lot of time (which looks like a dead loop). The solution is simple - we don't walk over all the regions. Instead, we jump over the regions

[Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling

2017-02-03 Thread Peter Xu
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do it. Generally, the rule of mine is: - f

[Qemu-devel] [PATCH v6 09/18] intel_iommu: vtd_slpt_level_shift check level

2017-02-03 Thread Peter Xu
This helps in debugging incorrect level passed in. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index c672621..d74aa27 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -168,6 +

[Qemu-devel] [PATCH v6 08/18] intel_iommu: fix trace for addr translation

2017-02-03 Thread Peter Xu
Another patch to convert the DPRINTF() stuffs. This patch focuses on the address translation path and caching. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 84 --- hw/i386/trace-events | 7 + 2 files changed, 39 insertions(+), 52 delet

[Qemu-devel] [PATCH v6 17/18] intel_iommu: allow dynamic switch of IOMMU region

2017-02-03 Thread Peter Xu
This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU address space, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to m

[Qemu-devel] [PATCH v6 10/18] memory: add section range info for IOMMU notifier

2017-02-03 Thread Peter Xu
In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check the notification type (MAP|UNMAP), but also check whether the notified iova range overlaps with the range of specific IOMMU notifier, and skip th

[Qemu-devel] [PATCH v6 11/18] memory: provide IOMMU_NOTIFIER_FOREACH macro

2017-02-03 Thread Peter Xu
Signed-off-by: Peter Xu --- include/exec/memory.h | 3 +++ memory.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 805a88a..f76e174 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -239,6 +

[Qemu-devel] [PATCH v6 12/18] memory: provide iommu_replay_all()

2017-02-03 Thread Peter Xu
This is an "global" version of exising memory_region_iommu_replay() - we announce the translations to all the registered notifiers, instead of a specific one. Signed-off-by: Peter Xu --- include/exec/memory.h | 8 memory.c | 9 + 2 files changed, 17 insertions(+) d

[Qemu-devel] [PATCH v6 13/18] memory: introduce memory_region_notify_one()

2017-02-03 Thread Peter Xu
Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Signed-off-by: Peter Xu --- include/exec/memory.h | 15 +++ memory.c | 40

Re: [Qemu-devel] [PATCHv2] hw/net: implement MIB counters in mcf_fec driver

2017-02-03 Thread Laurent Vivier
Add cc: to Network devices odd fixer. Le 11/01/2017 à 12:30, Greg Ungerer a écrit : > The FEC ethernet hardware module used on ColdFire SoC parts contains a > block of RAM used to maintain hardware counters. This block is accessible > via the usual FEC register address space. There is currently no

[Qemu-devel] [PATCH v6 18/18] intel_iommu: enable vfio devices

2017-02-03 Thread Peter Xu
This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own codes. Instead of translate() every page for iotlb invalid

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Peter Lieven
Am 03.02.2017 um 09:22 schrieb Christian Theune: > Hi, > >> On 3 Feb 2017, at 09:20, Peter Lieven mailto:p...@kamp.de>> >> wrote: >> >> If you try to THAW an unfrozen FS you get EINVAL. >> >> The current code thaws until an error is returned. >> >> >> So it should work as is. >> >> >> If you feel

[Qemu-devel] [PATCH v6 16/18] intel_iommu: do replay when context invalidate

2017-02-03 Thread Peter Xu
Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). In that case we need to notify all the registered components about the new mapping. Si

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-03 Thread Andrea Bolognani
On Thu, 2017-02-02 at 23:13 +0100, Gerd Hoffmann wrote: > > Not sure about this one. It doesn't show up on my laptop, > > so it's not like every single q35-based physical machine has > > it. >  > Is your laptop really q35+ich9 or something newer? Nope, something newer. Sorry for overlooking this.

Re: [Qemu-devel] [Qemu-ppc] [PULL 000/107] ppc-for-2.9 queue 20170202

2017-02-03 Thread Thomas Huth
On 02.02.2017 23:44, David Gibson wrote: > On Wed, Feb 01, 2017 at 11:41:40PM -0800, no-re...@patchew.org wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: [...] >> Checking PATCH 103/107: tcg/POWER9: NOOP the cp_abort instruction...

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-03 Thread Andrea Bolognani
On Thu, 2017-02-02 at 23:07 +0100, Gerd Hoffmann wrote: > > Oh, wait, I realize where the mismatch comes from now: > > on real hardware (my laptop) the video card is plugged > > into 00:02.0, but the default one you get when you don't > > pass -nodefault to QEMU is plugged into 00:01.0! >  > And th

Re: [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

2017-02-03 Thread Markus Armbruster
Thomas Huth writes: > The "or-irq" device needs to be wired up in source code, there is no > way the user can add this device with the "-device" parameter or the > "device_add" monitor command yet. > > Signed-off-by: Thomas Huth > --- > v2: Changed patch description and comment > > hw/core/or-

Re: [Qemu-devel] [PATCH v2] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet

2017-02-03 Thread Markus Armbruster
Thomas Huth writes: > The "qemu,register" device needs to be wired up in source code, there > is no way the user can add this device with the "-device" parameter or > the "device_add" monitor command yet. Well, the user can (I tried), but it won't do squat then. > Signed-off-by: Thomas Huth >

Re: [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet

2017-02-03 Thread Markus Armbruster
Markus Armbruster writes: > Thomas Huth writes: > >> The "or-irq" device needs to be wired up in source code, there is no >> way the user can add this device with the "-device" parameter or the >> "device_add" monitor command yet. Well, the user can (I tried), but it won't do squat then. >> Si

Re: [Qemu-devel] [PATCH] usb: ccid: check ccid apdu length

2017-02-03 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 00:52 +0530, P J P wrote: > From: Prasad J Pandit > > CCID device emulator uses Application Protocol Data Units(APDU) > to exchange command and responses to and from the host. > The length in these units couldn't be greater than 65536. Add > check to ensure the same. It'd als

Re: [Qemu-devel] [PATCHv2] hw/net: implement MIB counters in mcf_fec driver

2017-02-03 Thread Laurent Vivier
Le 03/02/2017 à 09:40, Laurent Vivier a écrit : > Add cc: to Network devices odd fixer. > > Le 11/01/2017 à 12:30, Greg Ungerer a écrit : >> The FEC ethernet hardware module used on ColdFire SoC parts contains a >> block of RAM used to maintain hardware counters. This block is accessible >> via th

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-03 Thread Gerd Hoffmann
On Do, 2017-02-02 at 16:44 +0200, Pekka Enberg wrote: > Hi, > > Has anyone been able to successfully run QEMU/KVM under Raspberry Pi 3? Yes. The bits are not yet upstream though (Cc'ing alex for status). > I have installed 64-bit Fedora 24 by Gerd Hoffmann on the hardware: > >https://www.k

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-03 Thread Alexander Graf
> Am 03.02.2017 um 10:27 schrieb Gerd Hoffmann : > >> On Do, 2017-02-02 at 16:44 +0200, Pekka Enberg wrote: >> Hi, >> >> Has anyone been able to successfully run QEMU/KVM under Raspberry Pi 3? > > Yes. The bits are not yet upstream though (Cc'ing alex for status). Ugh, the patches fell throu

[Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 08/24] block: introduce auto-loading bitmaps

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps stored in the disk image, which should be loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block.c | 14 +

[Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header'

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH 16/24] qmp: add persistent flag to block-dirty-bitmap-add

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c | 18 +- qapi/block-core.json | 8 +++- 2 files changed, 24 ins

[Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 489 +-- block/qcow2.c| 1 + block/qcow2.h| 1

[Qemu-devel] [PATCH 17/24] qmp: add autoload parameter to block-dirty-bitmap-add

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c | 18 -- qapi/block-core.json | 6 +- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev

[Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 12/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4d026df1bd..fe34d488aa 100644 --- a/block/dirty

[Qemu-devel] [PATCH 05/24] block: fix bdrv_dirty_bitmap_granularity signature

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 41 + block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed, 45 insertions(+) diff --git a/block/qcow2-bit

[Qemu-devel] [PATCH 01/24] specs/qcow2: fix bitmap granularity qemu-specific note

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0e91..dda53dd2a3 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt

[Qemu-devel] [PATCH 20/24] qcow2-refcount: rename inc_refcounts() and make it public

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-refcount.c | 53 ++ block/qcow2.h | 4 2 files cha

[Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 32 bl

[Qemu-devel] [PATCH 19/24] iotests: test qcow2 persistent dirty bitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 89 ++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100755 tests/qemu-iotests/

[Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/Make

Re: [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202

2017-02-03 Thread Peter Maydell
On 2 February 2017 at 05:12, David Gibson wrote: > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-30 10:23:20 +) > > are available in the git repository at: > > git:/

[Qemu-devel] [PATCH 10/24] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 16 block/qcow2-bitmap.c |

[Qemu-devel] [PATCH 15/24] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 4 3 files changed, 45 insertions(+) diff --g

[Qemu-devel] [PATCH 24/24] qmp: block-dirty-bitmap-remove: remove persistent

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from the storage on block-dirty-bitmap-remove. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockdev.c b/blockdev.c index c41b791289..a365cdf3ed 100644 --- a/blockdev.c +++ b/blockdev.c @@ -276

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-03 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 09:22:46PM +, Ketan Nilangekar wrote: > > On 2/2/17, 12:57 PM, "Ketan Nilangekar" wrote: > > [Ketan] > Does the QIO interface allow for readv/writev over network for unsecure > sockets? > > [Ketan] > I checked the qio implementation and it seems

[Qemu-devel] [PATCH 18/24] qmp: add x-debug-block-dirty-bitmap-sha256

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-core.json | 27 +++

[Qemu-devel] [PATCH v13 00/24] qcow2: persistent dirty bitmaps

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v13. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v13 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v13) v13: Just a fix for style checker. 13: line over 80 14: line over 80 22: s/i

[Qemu-devel] [PATCH 06/24] block/dirty-bitmap: add deserialize_ones func

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

Re: [Qemu-devel] [PATCH 0/2 v14] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Greg Kurz
On Fri, 3 Feb 2017 10:41:33 +0100 Pradeep Jagadeesh wrote: > On 2/1/2017 3:44 PM, Alberto Garcia wrote: > > On Tue 24 Jan 2017 10:24:06 AM CET, Pradeep Jagadeesh > > wrote: > > > >> Pradeep Jagadeesh (2): > >> fsdev: add IO throttle support to fsdev devices > >> throttle: removed duplicat

[Qemu-devel] [PATCH 14/24] block: add bdrv_can_store_new_dirty_bitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 22 ++ include/b

Re: [Qemu-devel] [PATCH 0/2 v14] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Alberto Garcia
On Fri 03 Feb 2017 10:41:33 AM CET, Pradeep Jagadeesh wrote: >> I cannot find the second patch in this thread (v14), did you forget >> to send it? >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04913.html > > I did send all the both patch files and the cover letter. > Don't know ho

Re: [Qemu-devel] [PATCH 0/2 v14] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
On 2/1/2017 3:44 PM, Alberto Garcia wrote: On Tue 24 Jan 2017 10:24:06 AM CET, Pradeep Jagadeesh wrote: Pradeep Jagadeesh (2): fsdev: add IO throttle support to fsdev devices throttle: removed duplicate throtlle code from block and fsdev files I cannot find the second patch in this thre

Re: [Qemu-devel] [PATCH v4] q35: Improve sample configuration files

2017-02-03 Thread Gerd Hoffmann
On Fr, 2017-02-03 at 10:46 +0100, Andrea Bolognani wrote: > Instead of having a single sample configuration file, > we now have several: > > * q35-emulated.cfg documents the default devices QEMU > adds to a q35 guest and the additional devices that > are pretty much guaranteed to be pres

[Qemu-devel] [PATCH 21/24] qcow2-bitmap: refcounts

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img check implementation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 76 ++ block/qcow2-refcount.c | 6 block/qcow2.h

Re: [Qemu-devel] [Qemu-ppc] [PULL 000/107] ppc-for-2.9 queue 20170202

2017-02-03 Thread Peter Maydell
On 3 February 2017 at 08:36, Thomas Huth wrote: > We've got lot's of C++ comments in the QEMU sources already, and the > CODING_STYLE document even does not mention this ... maybe this is just > a left-over from the Linux kernel's checkpatch.pl script? So IMHO: > Ignore this error. (and if we real

Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore

2017-02-03 Thread Peter Xu
On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: [...] > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > >> index 1a22887..ebd755c 100644 > >> --- a/include/migration/vmstate.h > >> +++ b/include/migration/vmstate.h > >> @@ -188,6 +188,8 @@ enum VMStateFlags

Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore

2017-02-03 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: > > [...] > > > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > > >> index 1a22887..ebd755c 100644 > > >> --- a/include/migration/vmstate.h > > >> +++ b/include/migratio

[Qemu-devel] [PATCH 07/24] qcow2: add bitmaps extension

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 127 +

[Qemu-devel] [PATCH v4] q35: Improve sample configuration files

2017-02-03 Thread Andrea Bolognani
Instead of having a single sample configuration file, we now have several: * q35-emulated.cfg documents the default devices QEMU adds to a q35 guest and the additional devices that are pretty much guaranteed to be present in a physical q35-based machine; * q35-virtio-graphical.cfg

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-03 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 08:42:33PM +0100, Markus Armbruster wrote: > === Dotted keys === > > One sufficiently powerful syntax extension already exists: the dotted > key convention. It's syntactically unambiguous only when none of the > KEYs involved contains '.' To adopt it across the board, we'

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 18 ++ include/block/block_int.h| 3 +++ include/block/dirty-bitmap.h | 3 +++ 3 files changed, 24 insertions(+) diff --git a/block/dir

[Qemu-devel] [PATCH] vnc: do not disconnect on EAGAIN

2017-02-03 Thread Michael Tokarev
When qemu vnc server is trying to send large update to clients, there might be a situation when system responds with something like EAGAIN, indicating that there's no system memory to send that much data (depending on the network speed, client and server and what is happening). In this case, somet

Re: [Qemu-devel] [PATCH v2] vnc: do not disconnect on EAGAIN

2017-02-03 Thread Daniel P. Berrange
On Fri, Feb 03, 2017 at 12:52:29PM +0300, Michael Tokarev wrote: > When qemu vnc server is trying to send large update to clients, > there might be a situation when system responds with something > like EAGAIN, indicating that there's no system memory to send > that much data (depending on the netw

Re: [Qemu-devel] [PATCH 1/2 v15] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Alberto Garcia
On Fri 03 Feb 2017 11:04:57 AM CET, Pradeep Jagadeesh wrote: > This patchset adds the io throttle support for the 9p-local driver. > For now this functionality can be used only through qemu cli options. > QMP interface and support to other 9p drivers need further extensions. > To make it simple for

Re: [Qemu-devel] [PATCH 1/2 v14] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
On 2/1/2017 4:08 PM, Alberto Garcia wrote: Hello, and sorry for being late reviewing these patches :) On Tue 24 Jan 2017 10:24:07 AM CET, Pradeep Jagadeesh wrote: This patchset adds the io throttle support for the 9p-local driver. For now this functionality can be used only through qemu cli

[Qemu-devel] [PATCH v2] vnc: do not disconnect on EAGAIN

2017-02-03 Thread Michael Tokarev
When qemu vnc server is trying to send large update to clients, there might be a situation when system responds with something like EAGAIN, indicating that there's no system memory to send that much data (depending on the network speed, client and server and what is happening). In this case, somet

Re: [Qemu-devel] [Qemu-ppc] [PULL 000/107] ppc-for-2.9 queue 20170202

2017-02-03 Thread Thomas Huth
On 03.02.2017 10:46, Peter Maydell wrote: > On 3 February 2017 at 08:36, Thomas Huth wrote: >> We've got lot's of C++ comments in the QEMU sources already, and the >> CODING_STYLE document even does not mention this ... maybe this is just >> a left-over from the Linux kernel's checkpatch.pl script

[Qemu-devel] [PATCH 0/2 v15] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
This patch set adds the IO throttling functionality to fsdev/9p devices. So far cgroups were used for throttling IO opertions on the fsdev/9p devices. It is difficult to use cgroups for throttling because we have to set up cgroups externally before we start the qemu process. Qemu provides the thro

Re: [Qemu-devel] [PATCH v9 08/25] tcg: drop global lock during TCG code execution

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > From: Jan Kiszka > > This finally allows TCG to benefit from the iothread introduction: Drop > the global mutex while running pure TCG CPU code. Reacquire the lock > when entering MMIO or PIO emulation, or when leaving the TCG loop. > > We have to

[Qemu-devel] [PATCH v2] migrate: Introduce zero RAM checks to skip RAM migration

2017-02-03 Thread Ashijeet Acharya
Migration of a "none" machine with no RAM crashes abruptly as bitmap_new() fails and thus aborts. Instead place zero RAM checks at appropriate places to skip migration of RAM in this case and complete migration successfully for devices only. Signed-off-by: Ashijeet Acharya --- Changes in v2: - tr

[Qemu-devel] [PATCH 2/2 v15] throttle: factor out duplicate code

2017-02-03 Thread Pradeep Jagadeesh
This patch removes the redundant throttle code that was present in block and fsdev device files. Now the common code is moved to a single file. Signed-off-by: Pradeep Jagadeesh https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg04637.html --- blockdev.c | 81 ++---

[Qemu-devel] [PATCH 1/2 v15] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
This patchset adds the io throttle support for the 9p-local driver. For now this functionality can be used only through qemu cli options. QMP interface and support to other 9p drivers need further extensions. To make it simple for other 9p drivers, the throttle code has been put in separate files.

Re: [Qemu-devel] [PATCH 16/17] iotests: add dirty bitmap migration test

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
02.02.2017 02:12, Max Reitz wrote: On 22.11.2016 18:54, Vladimir Sementsov-Ogievskiy wrote: The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. Signed-off-by: Vladimir Sementsov-O

Re: [Qemu-devel] [PATCH v9 16/25] cputlb and arm/sparc targets: convert mmuidx flushes from varg to bitmap

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > While the vargs approach was flexible the original MTTCG ended up > having munge the bits to a bitmap so the data could be used in > deferred work helpers. Instead of hiding that in cputlb we push the > change to the API to make it take a bitmap of

Re: [Qemu-devel] [PATCH 1/2 v15] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread Pradeep Jagadeesh
On 2/3/2017 11:10 AM, Alberto Garcia wrote: On Fri 03 Feb 2017 11:04:57 AM CET, Pradeep Jagadeesh wrote: This patchset adds the io throttle support for the 9p-local driver. For now this functionality can be used only through qemu cli options. QMP interface and support to other 9p drivers need fu

Re: [Qemu-devel] [PATCH 2/2 v15] throttle: factor out duplicate code

2017-02-03 Thread Alberto Garcia
On Fri 03 Feb 2017 11:04:58 AM CET, Pradeep Jagadeesh wrote: > This patch removes the redundant throttle code that was present in > block and fsdev device files. Now the common code is moved to a single > file. Here it says that this patch moves common code to a separate file, however: > diff --

Re: [Qemu-devel] [PATCH 0/2 v15] fsdev: add IO throttle support to fsdev devices

2017-02-03 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/2 v15] fsdev: add IO throttle support to fsdev devices Message-id: 1486116298-25046-1-git-send-email-pradeep.jagade...@huawei.com === TEST SCRIPT BEGIN ==

[Qemu-devel] [PATCH v2 1/3] spapr: cpu core: separate child threads destruction from machine state operations

2017-02-03 Thread Igor Mammedov
Split off destroying VCPU threads from drc callback spapr_core_release() into new spapr_cpu_core_unrealizefn() which takes care of internal cpu core state cleanup (i.e. VCPU threads) and is called when object_unparent(core) is called. That leaves spapr_core_release() only with board mgmt code, whi

Re: [Qemu-devel] [PATCH 12/17] migration: really use multiple pages at a time

2017-02-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We now send several pages at a time each time that we wakeup a thread. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 44 ++-- > 1 file changed, 38 insertions(+), 6 deletions(-) > > diff --git a/m

Re: [Qemu-devel] [PATCH 13/17] migration: Send the fd number which we are going to use for this page

2017-02-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We are still sending the page through the main channel, that would > change later in the series > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 13 +++-- > 1 file changed, 11 insertions(+), 2

Re: [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive

2017-02-03 Thread Fam Zheng
On Mon, 01/30 09:10, Markus Armbruster wrote: > John Snow writes: > > > On 01/27/2017 11:04 AM, Markus Armbruster wrote: > >> John Snow writes: > >> > >>> On 01/27/2017 06:51 AM, Markus Armbruster wrote: > John Snow writes: > > > On 01/26/2017 10:09 AM, Markus Armbruster wrote: >

Re: [Qemu-devel] [PATCH 16/17] iotests: add dirty bitmap migration test

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: 02.02.2017 02:12, Max Reitz wrote: On 22.11.2016 18:54, Vladimir Sementsov-Ogievskiy wrote: The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b w

Re: [Qemu-devel] [PATCH 03/17] migration: split common postcopy out of ram postcopy

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
01.02.2017 14:06, Vladimir Sementsov-Ogievskiy wrote: 24.01.2017 22:53, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 24.01.2017 12:24, Juan Quintela wrote: Vladimir Sementsov-Ogievskiy wrote: Split common postcopy staff from ram postcopy staf

[Qemu-devel] [PATCH] migration: remove myself as maintainer

2017-02-03 Thread Amit Shah
I'm switching jobs, and I'm not sure I can continue maintaining migration. Signed-off-by: Amit Shah --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 00b81f1..4382bcc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1431,7 +1431,6 @@ F: scripts/chec

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-03 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Feb 02, 2017 at 08:42:33PM +0100, Markus Armbruster wrote: >> === Dotted keys === >> >> One sufficiently powerful syntax extension already exists: the dotted >> key convention. It's syntactically unambiguous only when none of the >> KEYs involved contains

[Qemu-devel] [PATCH] MAINTAINERS: update my email address

2017-02-03 Thread Amit Shah
I'm leaving my job at Red Hat, this email address will stop working next week. Update it to one that I will have access to later. Signed-off-by: Amit Shah --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4382bcc..d69549f 1006

Re: [Qemu-devel] [PATCH v9 21/25] target-arm: don't generate WFE/YIELD calls for MTTCG

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > The WFE and YIELD instructions are really only hints and in TCG's case > they were useful to move the scheduling on from one vCPU to the next. In > the parallel context (MTTCG) this just causes an unnecessary cpu_exit > and contention of the BQL. >

Re: [Qemu-devel] [PATCH v9 20/25] target-arm/powerctl: defer cpu reset work to CPU context

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > When switching a new vCPU on we want to complete a bunch of the setup > work before we start scheduling the vCPU thread. To do this cleanly we > defer vCPU setup to async work which will run the vCPUs execution > context as the thread is woken up.

Re: [Qemu-devel] [PATCH v9 22/25] target-arm/cpu.h: make ARM_CP defined consistent

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > This is a purely mechanical change to make the ARM_CP flags neatly > align and use a consistent format so it is easier to see which bit > each flag is. > > Signed-off-by: Alex Bennée > --- > target/arm/cpu.h | 28 ++-- > 1

Re: [Qemu-devel] [PATCH v9 23/25] target-arm: introduce ARM_CP_EXIT_PC

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > Some helpers may trigger an immediate exit of the cpu_loop. If this > happens the PC need to be rectified to ensure the restart will begin > on the next instruction. > > Signed-off-by: Alex Bennée > --- > target/arm/cpu.h | 3 ++- > tar

Re: [Qemu-devel] [PATCH v9 25/25] tcg: enable MTTCG by default for ARM on x86 hosts

2017-02-03 Thread Peter Maydell
On 1 February 2017 at 15:05, Alex Bennée wrote: > This enables the multi-threaded system emulation by default for ARMv7 > and ARMv8 guests using the x86_64 TCG backend. This is because on the > guest side: > > - The ARM translate.c/translate-64.c have been converted to > - use MTTCG safe ato

Re: [Qemu-devel] [PATCH 14/17] migration: Create thread infrastructure for multifd recv side

2017-02-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We make the locking and the transfer of information specific, even if we > are still receiving things through the main thread. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 77 > +

Re: [Qemu-devel] [PATCH] migration: remove myself as maintainer

2017-02-03 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > I'm switching jobs, and I'm not sure I can continue maintaining migration. > > Signed-off-by: Amit Shah > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 00b81f1..4382bcc 100644 > --- a/MAINT

  1   2   3   4   >