The following commits will split char.c in several files. Let's put them
in a subdirectory.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
qemu-char.c => chardev/char.c | 0
MAINTAINERS | 2 +-
Makefile.objs | 2 +-
chardev/Makefile.objs |
char-serial inherits from char-fd finalizer.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
qemu-char.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 0cece8a34f..3d0d690999 100644
--- a/qemu-char.c
+++ b/qemu-ch
qemu_chr_new_from_opts() is modified to not need CharDriver backend[]
array, but uses instead objectified qmp_query_chardev_backends() and
char_get_class(). The alias field is moved outside in a ChardevAlias[],
similar to QDevAlias for devices.
"kind" and "parse" are moved to ChardevClass ("kind"
All chardev must implement chr_write(), but parallel and null chardev
both use null_chr_write(). Move it to the base class, so we don't need
to export the function when splitting the chardev in respective files.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
chardev/char.c | 21 ++
Signed-off-by: Marc-André Lureau
---
chardev/char-null.c | 54 +++
chardev/char.c| 23 --
chardev/Makefile.objs | 1 +
3 files changed, 55 insertions(+), 23 deletions(-)
create mode 100644 chardev/char-null.c
diff --
The class kind is necessary to lookup the chardev name in
qmp_chardev_add() after calling qemu_chr_new_from_opts() and to set
the appropriate ChardevBackend (mainly to free the right
fields).
qemu_chr_new_from_opts() can be changed to use a non-qmp function
using the chardev class typename. Introd
CharDriver no longer exists, it has been replaced with Chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
include/sysemu/char.h | 40
qemu-char.c | 11 +--
2 files changed, 25 insertions(+), 26 deletions(-)
diff --gi
Signed-off-by: Marc-André Lureau
---
chardev/char-ringbuf.c | 249 +
chardev/char.c | 218 ---
chardev/Makefile.objs | 1 +
3 files changed, 250 insertions(+), 218 deletions(-)
create mode 100644 c
This will help to split char.c in several units without having to
reference them all everywhere. This is useful in particular for tests.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
Makefile | 4 +++-
Makefile.objs | 5 +++--
Makefile.target| 3 +++
On 23 January 2017 at 02:17, Richard Henderson wrote:
> This is just about the minimum required to enable compilation
> without actually executing any instructions. This contains the
> HPPACPU structure and the required callbacks, the gdbstub, the
> basic translation loop, and a translate_one fun
A mechanical move, except that qemu_chr_write_all() needs to be declared
in char.h header to be used from chardev unit files.
Signed-off-by: Marc-André Lureau
---
chardev/char-mux.h| 63 +
include/sysemu/char.h | 3 +-
chardev/char-mux.c| 358 ++
Signed-off-by: Marc-André Lureau
---
chardev/char-io.h | 46
chardev/char-io.c | 192 ++
chardev/char.c| 174 +
chardev/Makefile.objs | 1 +
4 files changed, 240 insertions(
This define is used by several character devices, place it in char
common header.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
include/sysemu/char.h | 1 +
chardev/char.c| 13 ++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/ch
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-fd.h | 44 +
chardev/char-fd.c | 170 ++
chardev/char.c| 147 +--
chardev/Makefile.objs | 1 +
4 files cha
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-win.h| 53 ++
chardev/char-win.c| 265 ++
chardev/char.c| 253 +--
chardev/Makefile.objs | 1 +
4 files ch
On Thu, Jan 26, 2017 at 05:28:27PM +0400, Marc-André Lureau wrote:
> It's still time to wish happy new year!
>
> The Year of the Rooster will begin on January 28, 2017!
>
> Signed-off-by: Marc-André Lureau
> ---
> include/qemu-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Re
Curiously unused since its introduction in commit 7b0bfdf52d69.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
chardev/char.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index 6d0d5e722b..722c98dc33 100644
--- a/chardev/char.c
+++ b/chardev/c
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-win-stdio.h | 29 ++
chardev/char-win-stdio.c | 266 +++
chardev/char.c | 231 +---
chardev/Makefile.objs| 1 +
4 files chan
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-udp.c| 233 ++
chardev/char.c| 198 --
chardev/Makefile.objs | 1 +
3 files changed, 234 insertions(+), 198 deletions(-)
c
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-file.c | 139 ++
chardev/char.c| 106 --
chardev/Makefile.objs | 1 +
3 files changed, 140 insertions(+), 106 deletions(-)
creat
On Fri, Jan 27, 2017 at 10:08:49AM +, Peter Maydell wrote:
> On 27 January 2017 at 06:51, Markus Armbruster wrote:
> > "What can we cut" is the wrong question. The right one is "what are our
> > requirements". Here's my try:
> >
> > HTML: required
> > nroff with an macros: required
> > PDF:
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-stdio.c | 164 ++
chardev/char.c| 120
chardev/Makefile.objs | 1 +
3 files changed, 165 insertions(+), 120 deletions(-)
create
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
include/sysemu/char.h |1 +
chardev/char-socket.c | 1017 +
chardev/char.c| 979 +--
chardev/Makefile.objs |1 +
4 files changed,
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-pipe.c | 191 ++
chardev/char.c| 166 ---
chardev/Makefile.objs | 1 +
3 files changed, 192 insertions(+), 166 deletions(-)
On 20 January 2017 at 13:31, Paolo Bonzini wrote:
> From: Peter Xu
>
> Signed-off-by: Peter Xu
> Message-Id: <1483952153-7221-3-git-send-email-pet...@redhat.com>
> Signed-off-by: Paolo Bonzini
> ---
> hw/intc/ioapic_common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-console.c | 53 ++
chardev/char.c | 3 ---
chardev/Makefile.objs | 1 +
3 files changed, 54 insertions(+), 3 deletions(-)
create mode 100644 chardev/char-console.c
Am 30.01.2017 um 14:15 schrieb Stefan Weil:
> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error.
>
> Signed-off-by: Stefan Weil
> ---
>
> v2: Re-sent as v1 was damaged by my mailer.
>
> This is also broken in Debian.
>
> In addition, there is no default CPU ("any"), so b
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-parallel.h | 32 +
chardev/char-parallel.c | 316
chardev/char.c | 287 +--
chardev/Makefile.objs | 1 +
4 files chang
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-pty.c| 300 ++
chardev/char.c| 258 ---
chardev/Makefile.objs | 1 +
3 files changed, 301 insertions(+), 258 deletions(-)
On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote:
> > > - Original Message -
> > > > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote:
> > > > > Hi
On Thu, Jan 26, 2017 at 02:11:01PM +0100, Thomas Huth wrote:
> This patch is a port of the following commit from the Linux kernel:
>
> commit 15662b3e8644905032c2e26808401a487d4e90c1
> Author: Joe Perches
> Date: Mon Oct 31 17:13:12 2011 -0700
>
> checkpatch: add a --strict check for utf-8
Signed-off-by: Marc-André Lureau
Acked-by: Eric Blake
---
chardev/char-serial.h | 35 ++
chardev/char-serial.c | 318 ++
chardev/char.c| 278 +--
chardev/Makefile.objs | 1 +
4 files changed, 3
On Wed, Jan 25, 2017 at 04:14:09PM +, Daniel P. Berrange wrote:
> This is the final part of my trace events refactoring.
>
> Previously we merged code that split trace-events up
> into one file per sub-directory. We also merged code
> to the code-generator that enables us to generate
> and use
Those could probably be squashed with earlier patches, however I
couldn't easily identify them, test them or check if there are still
necessary on various platforms.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
include/sysemu/char.h | 5 -
chardev/char.c | 40 +--
On Thu, Jan 26, 2017 at 02:11:02PM +0100, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit fa64205df9dfd7b7662cc64a7e82115c00e428e5
> Author: Pasi Savanainen
> Date: Thu Oct 4 17:13:29 2012 -0700
>
> checkpatch: check utf-8 content from a commit
On Thu, Jan 26, 2017 at 11:34:04AM +0800, Fam Zheng wrote:
> v2: Use big endian for WWNN/WWPN fields. [Paolo]
> Clean up vm state change notifier in error/unrealize. [Stefan]
>
> This implements a WIP feature extention being proposed on virtio-scsi.
>
> We assign a set of Fibre Channel proper
On 30 January 2017 at 14:10, David Hildenbrand wrote:
> Am 30.01.2017 um 14:15 schrieb Stefan Weil:
>> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error.
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> v2: Re-sent as v1 was damaged by my mailer.
>>
>> This is also broken in D
On Fri, Jan 27, 2017 at 12:13:58PM +0100, Juergen Gross wrote:
> On 24/01/17 17:42, Roger Pau Monné wrote:
> > Hello,
> >
> > The following commit:
> >
> > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894
> > Author: Juergen Gross
> > Date: Tue Nov 22 07:10:58 2016 +0100
> >
> > xen: create qd
On Thu, Jan 26, 2017 at 02:11:04PM +0100, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit 13f1937ef33950b1112049972249e6191b82e6c9
> Author: Joe Perches
> Date: Wed Aug 6 16:10:59 2014 -0700
>
> checkpatch: emit a warning on file add/move/delet
On Thu, Jan 26, 2017 at 02:11:03PM +0100, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit 29ee1b0c67e0dd7dea8dd718e8326076bce5b6fe
> Author: Joe Perches
> Date: Wed Aug 6 16:10:35 2014 -0700
>
> checkpatch: ignore email headers better
>
>
"any" does not exist, therefore resulting in a misleading error message.
Reported-by: Stefan Weil
Signed-off-by: David Hildenbrand
---
linux-user/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/main.c b/linux-user/main.c
index 3004958..e588f58 100644
--- a/linux-user/mai
On Thu, Jan 26, 2017 at 02:11:05PM +0100, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit e0d975b1b439c4fef58fbc306c542c94f48bb849
> Author: Joe Perches
> Date: Wed Dec 10 15:51:49 2014 -0800
>
> checkpatch: reduce MAINTAINERS update message fr
** Changed in: qemu
Assignee: (unassigned) => Ziyue Yang (yzyubuntuzh)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1656710
Title:
Please support Ctrl-Alt-= to zoom in
Status in QEMU:
New
Current implementation iterates by bdrv_next, and, for example, will
invalidate firstly parent bds and then its children. This leads to the
following bug:
after incoming migration, in bdrv_invalidate_cache_all:
1. invalidate parent bds - reopen it with BDRV_O_INACTIVE cleared
2. child is not yet i
Commit a3a3d8c7 introduced a segfault bug while checking for
'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add
devices which do no set their 'dc->vmsd' yet while initialization.
Place a 'dc->vmsd' check prior to it so that we do not segfault for
such devices.
NOTE: This doesn'
On 01/30/2017 03:50 PM, David Hildenbrand wrote:
"any" does not exist, therefore resulting in a misleading error message.
Reported-by: Stefan Weil
Signed-off-by: David Hildenbrand
I think we support more instructions in user space than in kernel space,
but for now this change is good as it
Am 30.01.2017 um 14:15 schrieb Stefan Weil:
> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error.
>
> Signed-off-by: Stefan Weil
> ---
>
> v2: Re-sent as v1 was damaged by my mailer.
>
Just tested your patch:
Reviewed-by: David Hildenbrand
> This is also broken in Debi
Stefan Hajnoczi writes:
> On Fri, Jan 27, 2017 at 10:08:49AM +, Peter Maydell wrote:
>> On 27 January 2017 at 06:51, Markus Armbruster wrote:
>> > "What can we cut" is the wrong question. The right one is "what are our
>> > requirements". Here's my try:
>> >
>> > HTML: required
>> > nroff
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v2 00/41] chardev: qom clean-up and split in
various backend files
Message-id: 20170130133954.31353-1-marcandre.lur...@redhat.com
=== TEST SCRIPT BEGIN ===
Instead of having a single sample configuration file,
now we have two: one gives access to the guest through
the serial console and only includes a minimal set of
devices, the other uses a graphical console and includes
extra devices such as an audio card.
Both configuration file are full commente
On 30 January 2017 at 14:41, Ashijeet Acharya wrote:
> Commit a3a3d8c7 introduced a segfault bug while checking for
> 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add
> devices which do no set their 'dc->vmsd' yet while initialization.
> Place a 'dc->vmsd' check prior to it s
Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
> "any" does not exist, therefore resulting in a misleading error message.
>
> Reported-by: Stefan Weil
> Signed-off-by: David Hildenbrand
> ---
> linux-user/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/main.c b/li
On 30 January 2017 at 15:09, Stefan Weil wrote:
> Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
>> "any" does not exist, therefore resulting in a misleading error message.
>>
>> Reported-by: Stefan Weil
>> Signed-off-by: David Hildenbrand
>> ---
>> linux-user/main.c | 2 ++
>> 1 file change
The error exits of xen_pv_find_xendev() free the new xen-device via
g_free() which is wrong.
As the xen-device has been initialized as qdev it must be removed
via qdev_unplug().
This bug has been introduced with commit 3a6c9172ac5951e6dac2b3f6
("xen: create qdev for each backend device").
Report
On Fri, Jan 20, 2017 at 05:43:06PM +0100, Paolo Bonzini wrote:
> diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h
> index 14d4f1d..1efa356 100644
> --- a/include/qemu/coroutine_int.h
> +++ b/include/qemu/coroutine_int.h
> @@ -40,12 +40,20 @@ struct Coroutine {
> Corouti
Am 30.01.2017 um 16:11 schrieb Peter Maydell:
> On 30 January 2017 at 15:09, Stefan Weil wrote:
>> Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
>>> "any" does not exist, therefore resulting in a misleading error message.
>>>
>>> Reported-by: Stefan Weil
>>> Signed-off-by: David Hildenbrand
On Fri, Jan 20, 2017 at 05:43:09PM +0100, Paolo Bonzini wrote:
> AioContext is fairly self contained, the only dependency is QEMUTimer but
> that in turn doesn't need anything else. So move them out of block-obj-y
> to avoid introducing a dependency from io/ to block-obj-y.
>
> Signed-off-by: Pao
On 10/20/2016 03:25 PM, Halil Pasic wrote:
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index fc29acf..8767e40 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -66,10 +66,10 @@ static void *vmstate_base_addr(void *opaque, VMStateField
> *field, bool alloc)
>
Most callsites check already, one was missed.
Cc: 1653...@bugs.launchpad.net
Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55
Reported-by: Fabian Lesniak
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/
Make clear that this isn't guaranteed to actually complete the transfer,
the usb packet can still be in flight after calling that function.
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/u
Hi,
Commit 94b037f2a451b3dc855f9f2c346e5049a361bd55 caused some regressions,
partly plain bugs in that commit, partly it seems to have uncovered
other issues lurking in the xhci code. This series fixes the isses
which poped up so far.
cheers,
Gerd
Gerd Hoffmann (4):
xhci: only free comple
On Fri, Jan 20, 2017 at 05:43:10PM +0100, Paolo Bonzini wrote:
> This is in preparation for making qio_channel_yield work on
> AioContexts other than the main one.
>
> Cc: Daniel P. Berrange
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2: removed QIOChannelRestart [Daniel]
>
> include/i
xhci_submit and xhci_fire_ctl_transfer are is called from
xhci_kick_epctx processing loop only, so there is no need to call
xhci_kick_epctx make sure processing continues. Also eecursive calls
into xhci_kick_epctx can cause trouble.
Drop the xhci_kick_epctx calls.
Cc: 1653...@bugs.launchpad.net
Track xhci_kick_epctx processing being active in a variable. Check the
variable before calling xhci_kick_epctx from xhci_kick_ep. Add an
assert to make sure we don't call recursively into xhci_kick_epctx.
Cc: 1653...@bugs.launchpad.net
Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55
Reported-by:
On 30 January 2017 at 15:14, Juergen Gross wrote:
> The error exits of xen_pv_find_xendev() free the new xen-device via
> g_free() which is wrong.
>
> As the xen-device has been initialized as qdev it must be removed
> via qdev_unplug().
>
> This bug has been introduced with commit 3a6c9172ac5951e
What is #PSBM-57554 referring to ? Is that some custom bug tracker
you have ? I'm going to drop that unless its something we need to
keep
On Mon, Jan 30, 2017 at 04:19:56PM +0300, Denis V. Lunev wrote:
> From: Anton Nefedov
>
> According to RFC7230 Section 3.2, header field name is case-insensi
On Fri, Jan 20, 2017 at 05:43:11PM +0100, Paolo Bonzini wrote:
> Support separate coroutines for reading and writing, and place the
> read/write handlers on the AioContext that the QIOChannel is registered
> with.
>
> Cc: Daniel P. Berrange
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2:
On Fri, Jan 20, 2017 at 05:43:12PM +0100, Paolo Bonzini wrote:
> +aio_co_wake(s->recv_coroutine[i]);
>
> -qemu_coroutine_enter(nbd_get_client_session(bs)->send_coroutine);
> +/* We're woken up by the recv_coroutine itself. */
> +qemu_coroutine_yield();
This relies on
On 30.01.2017 15:12, Stefan Hajnoczi wrote:
> On Thu, Jan 26, 2017 at 02:11:01PM +0100, Thomas Huth wrote:
>> This patch is a port of the following commit from the Linux kernel:
>>
>> commit 15662b3e8644905032c2e26808401a487d4e90c1
>> Author: Joe Perches
>> Date: Mon Oct 31 17:13:12 2011 -0700
>
On 30/01/17 16:46, Peter Maydell wrote:
> On 30 January 2017 at 15:14, Juergen Gross wrote:
>> The error exits of xen_pv_find_xendev() free the new xen-device via
>> g_free() which is wrong.
>>
>> As the xen-device has been initialized as qdev it must be removed
>> via qdev_unplug().
>>
>> This bu
On 2017-01-30 13:19, Markus Armbruster wrote:
>>> Can you explain why not letting the guest map the shared memory into its
>>> address space on its own just like any other piece of device memory is a
>>> requirement?
>>
>> It requires reconfiguration of the sensitive 2nd level page tables
>> during
On Fri, Jan 20, 2017 at 05:43:16PM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/curl.c| 2 ++
> block/io.c | 5 +
> block/iscsi.c | 8 ++--
> block/null.c| 4
> block/qed.c
The metadata overlap checks introduced in a40f1c2add help detect
corruption in the qcow2 image by verifying that data writes don't
overlap with existing metadata sections.
The 'refcount-block' check in particular iterates over the refcount
table in order to get the addresses of all refcount blocks
On 1/30/2017 5:51 AM, Daniel P. Berrange wrote:
On Fri, Jan 27, 2017 at 06:08:20PM +, Daniel P. Berrange wrote:
On Fri, Jan 27, 2017 at 09:35:38AM +, Daniel P. Berrange wrote:
On Tue, Jan 24, 2017 at 05:02:25PM -0500, Brian Rak wrote:
We've been considering switching over to using qe
On Mon 30 Jan 2017 05:14:41 PM CET, Alberto Garcia wrote:
> This patch keeps the index of the last used (i.e. non-zero) entry in
> the refcount table and updates it every time the table changes. The
> refcount-block overlap check then uses that index instead of reading
> the whole table.
Note tha
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Record the largest page size in use; we'll need it soon for allocating
> > temporary buffers.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
> Not that I object, but
Peter Maydell wrote:
> On 30 January 2017 at 14:41, Ashijeet Acharya
> wrote:
>> Commit a3a3d8c7 introduced a segfault bug while checking for
>> 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add
>> devices which do no set their 'dc->vmsd' yet while initialization.
>> Place a
Auger Eric wrote:
> Hi Juan,
>
> On 30/01/2017 10:15, Juan Quintela wrote:
>> Eric Auger wrote:
>>> We need to handle both registers and ITS tables. While
>>> register handling is standard, ITS table handling is more
>>> challenging since the kernel API is devised so that the
>>> tables are flush
On 01/27/2017 09:59 PM, Nir Soffer wrote:
> From: Nir Soffer
>
> The result of openfile was not checked, leading to failure deep in the
> actual command with confusing error message, and exiting with exit code 0.
>
When posting a series, please ensure that your messages are all marked
In-Reply-
On 01/27/2017 09:59 PM, Nir Soffer wrote:
> From: Nir Soffer
>
> Many tests expected the wrong behavior when qemu-io call into the
> command with after failing to open the file, writing this error:
>
> no file open, try 'help open'
>
> Now that we fail immediately when opening a file fails,
On 01/26/2017 05:04 AM, Daniel P. Berrange wrote:
> The qemu-img dd command added --image-opts support, but missed
> the corresponding --object support. This prevented passing
> secrets (eg auth passwords) needed by certain disk images.
>
> Signed-off-by: Daniel P. Berrange
> ---
> qemu-img.c |
On 01/28/2017 02:21 PM, Max Reitz wrote:
> On 20.12.2016 20:15, Eric Blake wrote:
>> Passing a byte offset, but sector count, when we ultimately
>> want to operate on cluster granularity, is madness. Clean up
>> the interfaces to take both offset and count as bytes, while
>> still keeping the asse
On 01/30/2017 01:57 AM, Alex Bennée wrote:
>>> diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c
>>> index a9ee7fddf9..2624d8d909 100644
>>> --- a/hw/intc/arm_gicv3_cpuif.c
>>> +++ b/hw/intc/arm_gicv3_cpuif.c
>>> @@ -14,6 +14,7 @@
>>>
>>> #include "qemu/osdep.h"
>>> #include "qem
On 01/28/2017 02:57 PM, Max Reitz wrote:
> On 20.12.2016 20:15, Eric Blake wrote:
>> Make it easier to simulate various unusual hardware setups (for
>> example, recent commits 3482b9b and b8d0a98 affect the Dell
>> Equallogic iSCSI with its 15M preferred and maximum unmap and
>> write zero sizing,
On 01/30/2017 04:22 AM, Denis V. Lunev wrote:
> If explicit zeroing out before mirroring is required for the target image,
> it moves the block job offset counter to EOF, then offset and len counters
> count the image size twice.
>
> There is no harm but confusing stats (e.g. for 1G image the comp
On 01/30/2017 04:51 AM, Daniel P. Berrange wrote:
> The qio_channel_websock_read_wire() method will read upto 4096
s/upto/up to/
> bytes off the socket and then decode the websockets header and
> payload. The code was only decoding a single websockets frame,
> even if the buffered data contained
On 01/30/2017 08:16 PM, Eric Blake wrote:
> On 01/30/2017 04:22 AM, Denis V. Lunev wrote:
>> If explicit zeroing out before mirroring is required for the target image,
>> it moves the block job offset counter to EOF, then offset and len counters
>> count the image size twice.
>>
>> There is no harm
From: Keith Busch
Signed-off-by: Keith Busch
[hch: ported over from qemu-nvme.git to mainline]
Signed-off-by: Christoph Hellwig
---
hw/block/nvme.c | 27 ++-
hw/block/nvme.h | 1 +
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/bloc
Hi all,
this series implements two more NVMe commands: DSM and Write Zeroes.
Both trace their lineage to Keith's qemu-nvme.git repository, and
while the Write Zeroes one is taken from there almost literally
the DSM one has seen a major rewrite to not block the main thread
as well as various other
Support deallocating of LBAs using the DSM command by wiring it up to
the qemu discard implementation. The other DSM operations which are
purely advisory are ignored for now.
Based on an implementation by Keith Busch in the qemu-nvme.git repository,
but rewritten to use the qemu AIO infrastructur
Signed-off-by: Laurent Vivier
---
configure| 2 +-
gdb-xml/m68k-fp.xml | 21 +
target/m68k/helper.c | 45 +
3 files changed, 67 insertions(+), 1 deletion(-)
create mode 100644 gdb-xml/m68k-fp.xml
diff --git a/configur
This series modifies the original ColdFire FPU implementation
to use floatx80 instead of float64 internally as this
is the native datatype for 680x0. I didn't keep the float64
type for ColdFire, but if someone thinks it's required I
can update this series in this way.
The series also adds the FPU
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.h| 1 +
target/m68k/fpu_helper.c | 56
target/m68k/helper.h | 4
target/m68k/translate.c | 14
4 files changed, 75 insertions(+)
diff --git a/target/m68k/cpu.h b/ta
Signed-off-by: Laurent Vivier
---
fpu/softfloat-specialize.h | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
index f05c865..01b594f 100644
--- a/fpu/softfloat-specialize.h
+++ b/fpu/softflo
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.c| 2 +-
target/m68k/cpu.h| 36 +-
target/m68k/fpu_helper.c | 116 +++---
target/m68k/helper.c | 20 ++-
target/m68k/helper.h | 3 +-
target/m68k/qregs.def| 1 +
target/m68k/translate.c | 311 ++
According to the comment, this definition of invalid encoding is given
by intel developer's manual, and doesn't work with the behavior
of 680x0 FPU.
Signed-off-by: Laurent Vivier
---
fpu/softfloat.c | 20
include/fpu/softfloat.h | 15 ---
2 files changed,
Add fssqrt, fdsqrt, fsabs, fdabs, fsneg, fdneg, fsadd, fdadd,
fssub, fdsub, fsmul, fdmul, fsdiv, fddiv, fsmove and fdmove.
The precision is managed using set_floatx80_rounding_precision(),
except for fsmove, fdmove, fsneg, fdneg, fsabs and fdabs:
the value is converted manually to the given precis
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.h| 28 +
target/m68k/fpu_helper.c | 107 ++-
target/m68k/helper.h | 1 +
target/m68k/translate.c | 27
4 files changed, 162 insertions(+), 1 deletion(-)
diff --
Signed-off-by: Laurent Vivier
---
target/m68k/fpu_helper.c | 6 +++
target/m68k/helper.h | 1 +
target/m68k/translate.c | 99 +++-
3 files changed, 80 insertions(+), 26 deletions(-)
diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 43 ---
1 file changed, 24 insertions(+), 19 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 9f60fbc..d9ba735 100644
--- a/target/m68k/translate.c
+++ b/target/m6
101 - 200 of 249 matches
Mail list logo
