Re: [Qemu-devel] [PATCH v4 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-23 Thread Markus Armbruster
Cc'ing qemu-block. Dou Liyang writes: > Change log v3 -> v4: > 1. Develop these into the non-RFC patches. > 2. Fix some comments. > 3. do declarations first. > > Change log v2 -> v3: > 1. Remove the unnecessary code for the bdrv_next_node(). > 2. Remove the change of the locking rules. >

Re: [Qemu-devel] [PATCH] migration: re-active images while migration been canceled after inactive them

2017-01-23 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > which migration aborted QEMU because it didn't regain the control > of images while some errors happened. > > Actually, there are another two cases can trigger the same error re

[Qemu-devel] [PATCH v2] migration: Change name of live migration thread

2017-01-23 Thread Pankaj Gupta
Change the name of live migration thread from 'migration' to 'live_migration' to identify it clearly. 'migration' is a generic word and kernel also has tasks for process migration with the name 'migration/cpu#'. Signed-off-by: Pankaj Gupta --- migration/migration.c | 2 +- 1 file changed, 1 in

Re: [Qemu-devel] [PATCH v2] migration: Change name of live migration thread

2017-01-23 Thread Juan Quintela
Pankaj Gupta wrote: > Change the name of live migration thread from 'migration' > to 'live_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. > > > Signed-off-by: Pankaj Gupta Reviewed-by: Juan Qui

Re: [Qemu-devel] [PATCH] migration: re-active images while migration been canceled after inactive them

2017-01-23 Thread Hailiang Zhang
On 2017/1/23 21:40, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case which migration aborted QEMU because it didn't regain the control of images while some errors happened. Actually, there are anot

Re: [Qemu-devel] [PATCH v2] migration: Change name of live migration thread

2017-01-23 Thread Dr. David Alan Gilbert
* Pankaj Gupta (pagu...@redhat.com) wrote: > Change the name of live migration thread from 'migration' > to 'live_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. > > > Signed-off-by: Pankaj Gupta

Re: [Qemu-devel] [PULL v2 000/180] QAPI patches for 2017-01-16

2017-01-23 Thread Daniel P. Berrange
On Fri, Jan 20, 2017 at 04:46:05PM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On 17 January 2017 at 16:43, Peter Maydell wrote: > >> In any case, applied this pullreq to master. > > > > Although it works fine on my OSX box (with warnings) it seems > > to have broken the Travis

Re: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-01-11

2017-01-23 Thread Paolo Bonzini
On 23/01/2017 11:07, Peter Maydell wrote: > On 20 January 2017 at 13:31, Paolo Bonzini wrote: >> The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: >> >> Merge remote-tracking branch >> 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 >> 12:4

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Pradeep Jagadeesh
-Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Monday, January 23, 2017 11:28 AM To: Pradeep Jagadeesh Cc: Pradeep Jagadeesh; Alberto Garcia; qemu-devel@nongnu.org Subject: Re: [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files On Mon, 23 Jan

[Qemu-devel] [PATCH V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
This patchset adds the throttle support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions. To make it simple for other 9p drivers, the throttle code has been put in separate files. Si

[Qemu-devel] [PATCH V13] throttle: removed duplicate throtlle code from block and fsdev files

2017-01-23 Thread Pradeep Jagadeesh
This removes the redundant throttle code that was present in block and fsdev device files. Now the common code is moved to a single file. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 81 ++-- fsdev/qemu-fsdev-opts.c | 80 ++---

Re: [Qemu-devel] [PULL 30/30] target-sparc: fix up niagara machine

2017-01-23 Thread Artyom Tarasenko
On Mon, Jan 23, 2017 at 1:40 PM, Peter Maydell wrote: > On 18 January 2017 at 22:38, Artyom Tarasenko wrote: >> Remove the Niagara stub implementation from sun4u.c and add a machine, >> compatible with Legion simulator from the OpenSPARC T1 project. >> >> The machine uses the firmware supplied wi

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-23 Thread Markus Armbruster
Jan Kiszka writes: > Hi, > > some of you may know that we are using a shared memory device similar to > ivshmem in the partitioning hypervisor Jailhouse [1]. > > We started as being compatible to the original ivshmem that QEMU > implements, but we quickly deviated in some details, and in the rece

Re: [Qemu-devel] [PULL 30/30] target-sparc: fix up niagara machine

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 14:10, Artyom Tarasenko wrote: > On Mon, Jan 23, 2017 at 1:40 PM, Peter Maydell > wrote: >> I see that 'make check' now warns: >> GTESTER check-qtest-sparc64 >> Could not open option rom 'nvram1': No such file or directory >> Could not open option rom '1up-md.bin': No suc

[Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Daniel P. Berrange
The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-01-20 16:42:07 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-01-23-1 for you t

[Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress

2017-01-23 Thread Daniel P. Berrange
Add a 'numeric' flag to the InetSocketAddress struct to allow the caller to indicate that DNS should be skipped for the host/port fields. This is useful if the caller knows the address is already numeric and wants to guarantee no (potentially blocking) DNS lookups are attempted. Reviewed-by: Eric

[Qemu-devel] [PULL v1 6/8] io: change the QIOTask callback signature

2017-01-23 Thread Daniel P. Berrange
Currently the QIOTaskFunc signature takes an Object * for the source, and an Error * for any error. We also need to be able to provide a result pointer. Rather than continue to add parameters to QIOTaskFunc, remove the existing ones and simply pass the QIOTask object instead. This has methods to ac

[Qemu-devel] [PULL v1 2/8] io: stop incrementing reference in qio_task_get_source

2017-01-23 Thread Daniel P. Berrange
Incrementing the reference in qio_task_get_source is not necessary, since we're not running concurrently with any other code touching the QIOTask. This minimizes chances of further memory leaks. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h| 7 --- io/c

[Qemu-devel] [PULL v1 7/8] io: remove Error parameter from QIOTask thread worker

2017-01-23 Thread Daniel P. Berrange
Now that task objects have a directly associated error, there's no need for an an Error **errp parameter to the QIOTask thread worker function. It already has a QIOTask object, so can directly set the error on it. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h

[Qemu-devel] [PULL v1 3/8] io: fix typo in docs for QIOTask

2017-01-23 Thread Daniel P. Berrange
The GDestroyNotify parameter is already a pointer, so does not need a '*' suffix on the type. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/io/task.h b/include/io/task.h index c26

[Qemu-devel] [PULL v1 4/8] io: add ability to associate an opaque "result" with with a task

2017-01-23 Thread Daniel P. Berrange
Currently there is no data associated with a successful task completion. This adds an opaque pointer to the task to store an arbitrary result. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h | 27 +++ io/task.c | 20 +++

[Qemu-devel] [PULL v1 5/8] io: add ability to associate an error with a task

2017-01-23 Thread Daniel P. Berrange
Currently when a task fails, the error is never explicitly associated with the task object, it is just passed along through the completion callback. This adds the ability to explicitly associate an error with the task. Signed-off-by: Daniel P. Berrange --- include/io/task.h | 32

[Qemu-devel] [PULL v1 8/8] io: introduce a DNS resolver API

2017-01-23 Thread Daniel P. Berrange
Currently DNS resolution is done automatically as part of the creation of a QIOChannelSocket object instance. This works ok for network clients where you just end up a single network socket, but for servers, the results of DNS resolution may require creation of multiple sockets. Introducing a DNS

Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23 Message-id: 20170123142629.0-1-berra...@redhat.com

Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 14:26, Daniel P. Berrange wrote: > The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-20 16:42:07 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 14:02:33 + Pradeep Jagadeesh wrote: > -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Monday, January 23, 2017 11:28 AM > To: Pradeep Jagadeesh > Cc: Pradeep Jagadeesh; Alberto Garcia; qemu-devel@nongnu.org > Subject: Re: [PATCH V1] throttle:R

Re: [Qemu-devel] [PULL v2 000/180] QAPI patches for 2017-01-16

2017-01-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Jan 20, 2017 at 04:46:05PM +0100, Markus Armbruster wrote: >> Peter Maydell writes: >> >> > On 17 January 2017 at 16:43, Peter Maydell >> > wrote: >> >> In any case, applied this pullreq to master. >> > >> > Although it works fine on my OSX box (with war

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-23 Thread Eric Blake
On 01/22/2017 05:43 AM, Wouter Verhelst wrote: > > Having given this some more thought, I'm not entirely sure anymore that > an active resize from the NBD layer is necessarily a layering violation. > There might be other cases where this is useful, and e.g., the Linux > kernel also supports active

[Qemu-devel] [PATCH] cirrus: allow zero source pitch in pattern fill rops

2017-01-23 Thread Wolfgang Bumiller
The rops used by cirrus_bitblt_common_patterncopy only use the destination pitch, so the source pitch shoul allowed to be zero. Signed-off-by: Wolfgang Bumiller --- Resent as requested as non-inline reply; was originally a reply to thread: [PATCH] display: cirrus: check vga bits per pixel(bpp) va

Re: [Qemu-devel] [PULL 30/30] target-sparc: fix up niagara machine

2017-01-23 Thread Artyom Tarasenko
On Mon, Jan 23, 2017 at 3:24 PM, Peter Maydell wrote: > On 23 January 2017 at 14:10, Artyom Tarasenko wrote: >> On Mon, Jan 23, 2017 at 1:40 PM, Peter Maydell >> wrote: >>> I see that 'make check' now warns: >>> GTESTER check-qtest-sparc64 >>> Could not open option rom 'nvram1': No such file

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 3:48 PM, Greg Kurz wrote: On Mon, 23 Jan 2017 14:02:33 + Pradeep Jagadeesh wrote: -Original Message- From: Greg Kurz [mailto:gr...@kaod.org] Sent: Monday, January 23, 2017 11:28 AM To: Pradeep Jagadeesh Cc: Pradeep Jagadeesh; Alberto Garcia; qemu-devel@nongnu.org Subje

Re: [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine

2017-01-23 Thread Eduardo Habkost
On Mon, Jan 23, 2017 at 12:20:33PM +0530, Bharata B Rao wrote: > On Thu, Jan 19, 2017 at 04:04:23PM +0100, Igor Mammedov wrote: > > On Wed, 18 Jan 2017 16:57:13 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Jan 18, 2017 at 06:13:24PM +0100, Igor Mammedov wrote: > > > > it will allow generic

Re: [Qemu-devel] [PULL 30/30] target-sparc: fix up niagara machine

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 14:59, Artyom Tarasenko wrote: > On Mon, Jan 23, 2017 at 3:24 PM, Peter Maydell > wrote: >> If they're actually necessary then perhaps we should refuse >> to start entirely? > > Yes, I think it's a best option. Don't load any images with the > -nodefaults option and fail on

Re: [Qemu-devel] [PATCH] cirrus: allow zero source pitch in pattern fill rops

2017-01-23 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] cirrus: allow zero source pitch in pattern fill rops Message-id: 1485183295-10242-1-git-send-email-w.bumil...@proxmox.com === TEST SCRIPT BEGIN === #!/bin/

[Qemu-devel] what is the syntax and meaning of -numa cpus=foo-bar ?

2017-01-23 Thread Peter Maydell
Hi; something we noticed recently is that some versions of makeinfo gripe about the -numa option syntax in qemu-options.hx: qemu-options.texi:60: warning: unlikely character [ in @var. qemu-options.texi:60: warning: unlikely character ] in @var. qemu-options.texi:61: warning: unlikely character [

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Eric Blake
On 01/23/2017 03:19 AM, Pradeep Jagadeesh wrote: s/throtlle/throttle/ in the subject line (as is, the subject is rather long, and missing a space after ':') > This will allow other subsystems (i.e. fsdev) to implement throttling > without duplicating the command line options. > > Signed-off-by:

Re: [Qemu-devel] [PATCH V2] qemu-img: optimize is_allocated_sectors_min

2017-01-23 Thread Peter Lieven
Am 21.01.2017 um 20:58 schrieb Max Reitz: On 19.01.2017 17:35, Peter Lieven wrote: the current implementation always splits requests if a buffer begins or ends with zeroes independent of the length of the zero area. Change this to really only split off zero areas that have at least a length of '

Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 14:46, Peter Maydell wrote: > On 23 January 2017 at 14:26, Daniel P. Berrange wrote: >> The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >> staging (2017-01-20 16:42:07

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-23 Thread Alex Bligh
> On 23 Jan 2017, at 14:54, Eric Blake wrote: > > Thoughts? My main thought is that the purpose of the extension branches is to discuss and come to a consensus over experimental extension protocols. Whilst I think creating a branch should be a lightweight affair (fine), we explicitly say people

Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 02:46:06PM +, Peter Maydell wrote: > On 23 January 2017 at 14:26, Daniel P. Berrange wrote: > > The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (201

Re: [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 03:24:08PM +, Peter Maydell wrote: > On 23 January 2017 at 14:46, Peter Maydell wrote: > > On 23 January 2017 at 14:26, Daniel P. Berrange wrote: > >> The following changes since commit > >> 598cf1c805271564686f2d732b36f50c3c40dcdd: > >> > >> Merge remote-tracking b

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 4:19 PM, Eric Blake wrote: On 01/23/2017 03:19 AM, Pradeep Jagadeesh wrote: s/throtlle/throttle/ in the subject line (as is, the subject is rather long, and missing a space after ':') Thanks for reviewing the code. I fixed the subject and shortened it. -Pradeep This will allow

Re: [Qemu-devel] [PATCH V13] throttle: removed duplicate throtlle code from block and fsdev files

2017-01-23 Thread Eric Blake
On 01/23/2017 08:06 AM, Pradeep Jagadeesh wrote: Subject line is long and misspelled; I suggest: throttle: factor out duplicate code > This removes the redundant throttle code that was present in > block and fsdev device files. Now the common code is moved > to a single file. > > Signed-off-by:

[Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
This patch set adds the IO throttling functionality to fsdev/9p devices. So far cgroups were used for throttling IO opertions on the fsdev/9p devices. It is difficult to use cgroups for throttling because we have to set up cgroups externally before we start the qemu process. Qemu provides the thro

[Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
This patch set adds the IO throttling functionality to fsdev/9p devices. So far cgroups were used for throttling IO opertions on the fsdev/9p devices. It is difficult to use cgroups for throttling because we have to set up cgroups externally before we start the qemu process. Qemu provides the thro

[Qemu-devel] [PATCH 1/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
This patchset adds the throttle support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions. To make it simple for other 9p drivers, the throttle code has been put in separate files. --

[Qemu-devel] [PATCH 2/2 V13] throttle: factor out duplicate code

2017-01-23 Thread Pradeep Jagadeesh
This patch removes the redundant throttle code that was present in block and fsdev device files. Now the common code is moved to a single file. --- blockdev.c | 81 ++-- fsdev/qemu-fsdev-opts.c | 80 ++-

Re: [Qemu-devel] [PATCH 2/2 V13] throttle: factor out duplicate code

2017-01-23 Thread Eric Blake
On 01/23/2017 09:50 AM, Pradeep Jagadeesh wrote: > This patch removes the redundant throttle code that was present in > block and fsdev device files. Now the common code is moved > to a single file. > > --- You forgot your S-o-b designation. Also, this is the second thread you've sent with a tit

Re: [Qemu-devel] [PATCH RFC v4 00/20] VT-d: vfio enablement and misc enhances

2017-01-23 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 09:08:36PM +0800, Peter Xu wrote: > This is v4 of vt-d vfio enablement series. > > Sorry that v4 growed to 20 patches. Some newly added patches (which > are quite necessary): > > [01/20] vfio: trace map/unmap for notify as well > [02/20] vfio: introduce vfio_get_vaddr() >

[Qemu-devel] [PULL v2 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress

2017-01-23 Thread Daniel P. Berrange
Add a 'numeric' flag to the InetSocketAddress struct to allow the caller to indicate that DNS should be skipped for the host/port fields. This is useful if the caller knows the address is already numeric and wants to guarantee no (potentially blocking) DNS lookups are attempted. Reviewed-by: Eric

[Qemu-devel] [PULL v2 2/8] io: stop incrementing reference in qio_task_get_source

2017-01-23 Thread Daniel P. Berrange
Incrementing the reference in qio_task_get_source is not necessary, since we're not running concurrently with any other code touching the QIOTask. This minimizes chances of further memory leaks. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h| 7 --- io/c

[Qemu-devel] [PULL v2 7/8] io: remove Error parameter from QIOTask thread worker

2017-01-23 Thread Daniel P. Berrange
Now that task objects have a directly associated error, there's no need for an an Error **errp parameter to the QIOTask thread worker function. It already has a QIOTask object, so can directly set the error on it. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h

[Qemu-devel] [PULL v2 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Daniel P. Berrange
The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-01-20 16:42:07 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2017-01-23-2 for you t

[Qemu-devel] [PULL v2 5/8] io: add ability to associate an error with a task

2017-01-23 Thread Daniel P. Berrange
Currently when a task fails, the error is never explicitly associated with the task object, it is just passed along through the completion callback. This adds the ability to explicitly associate an error with the task. Signed-off-by: Daniel P. Berrange --- include/io/task.h | 32

[Qemu-devel] [PULL v2 6/8] io: change the QIOTask callback signature

2017-01-23 Thread Daniel P. Berrange
Currently the QIOTaskFunc signature takes an Object * for the source, and an Error * for any error. We also need to be able to provide a result pointer. Rather than continue to add parameters to QIOTaskFunc, remove the existing ones and simply pass the QIOTask object instead. This has methods to ac

[Qemu-devel] [PULL v2 4/8] io: add ability to associate an opaque "result" with with a task

2017-01-23 Thread Daniel P. Berrange
Currently there is no data associated with a successful task completion. This adds an opaque pointer to the task to store an arbitrary result. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h | 27 +++ io/task.c | 20 +++

[Qemu-devel] [PULL v2 8/8] io: introduce a DNS resolver API

2017-01-23 Thread Daniel P. Berrange
Currently DNS resolution is done automatically as part of the creation of a QIOChannelSocket object instance. This works ok for network clients where you just end up a single network socket, but for servers, the results of DNS resolution may require creation of multiple sockets. Introducing a DNS

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > For ARM virt machine, if we use virt-2.7 which will not create ITS node, > the virtio-net can not recieve interrupts so it can't get ip address > through dhcp. > This fixes commit 83d768b(virtio: set ISR on dat

Re: [Qemu-devel] [PATCH 2/2 V13] throttle: factor out duplicate code

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 4:55 PM, Eric Blake wrote: On 01/23/2017 09:50 AM, Pradeep Jagadeesh wrote: This patch removes the redundant throttle code that was present in block and fsdev device files. Now the common code is moved to a single file. --- You forgot your S-o-b designation. Also, this is the se

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices Message-id: 1485186641-12220-1-git-send-email-pradeep.jagade...@huawei.com === TEST SCRIPT BEGIN ==

[Qemu-devel] [PULL v2 3/8] io: fix typo in docs for QIOTask

2017-01-23 Thread Daniel P. Berrange
The GDestroyNotify parameter is already a pointer, so does not need a '*' suffix on the type. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/task.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/io/task.h b/include/io/task.h index c26

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 08:03:18 -0800 (PST) no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > Pradeep, One should usually take patchew's findings into account. See below. > Type: series > Subject: [Qemu-devel] [PA

Re: [Qemu-devel] what is the syntax and meaning of -numa cpus=foo-bar ?

2017-01-23 Thread Eduardo Habkost
On Mon, Jan 23, 2017 at 03:14:28PM +, Peter Maydell wrote: > Hi; something we noticed recently is that some versions of > makeinfo gripe about the -numa option syntax in qemu-options.hx: > > qemu-options.texi:60: warning: unlikely character [ in @var. > qemu-options.texi:60: warning: unlikely

Re: [Qemu-devel] [RFC PATCH] MAINTAINERS: Add an entry for hw/core/null-machine.c

2017-01-23 Thread Eduardo Habkost
On Mon, Jan 23, 2017 at 09:51:22AM +0200, Marcel Apfelbaum wrote: > On 01/23/2017 07:54 AM, Thomas Huth wrote: > > The "Machine core" section sounds like a good match for this file. > > > > Signed-off-by: Thomas Huth > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 5:22 PM, Greg Kurz wrote: On Mon, 23 Jan 2017 08:03:18 -0800 (PST) no-re...@patchew.org wrote: Hi, Your series seems to have some coding style problems. See output below for more information: Ya, I observed signoff issue. I have created next version files. I will send them tomo

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Eric Blake
On 01/23/2017 10:30 AM, Pradeep Jagadeesh wrote: > On 1/23/2017 5:22 PM, Greg Kurz wrote: >> On Mon, 23 Jan 2017 08:03:18 -0800 (PST) >> no-re...@patchew.org wrote: >>> Hi, >>> >>> Your series seems to have some coding style problems. See output >>> below for >>> more information: >>> >> > Ya, I ob

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 5:34 PM, Eric Blake wrote: On 01/23/2017 10:30 AM, Pradeep Jagadeesh wrote: On 1/23/2017 5:22 PM, Greg Kurz wrote: On Mon, 23 Jan 2017 08:03:18 -0800 (PST) no-re...@patchew.org wrote: Hi, Your series seems to have some coding style problems. See output below for more information:

Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 17:30:13 +0100 Pradeep Jagadeesh wrote: > On 1/23/2017 5:22 PM, Greg Kurz wrote: > > On Mon, 23 Jan 2017 08:03:18 -0800 (PST) > > no-re...@patchew.org wrote: > >> Hi, > >> > >> Your series seems to have some coding style problems. See output below for > >> more information:

Re: [Qemu-devel] [PATCH] migration: re-active images while migration been canceled after inactive them

2017-01-23 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2017/1/23 21:40, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > > > which migration aborted QEMU because it didn't regain the

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

2017-01-23 Thread Paolo Bonzini
On 23/01/2017 10:48, Markus Armbruster wrote: > The PC machines (pc-q35-* pc-i440fx-* pc-* isapc xenfv) automatically > create lsi53c895a SCSI HBAs and SCSI devices to honor -drive if=scsi. > For giggles, try -drive if=scsi,bus=25,media=cdrom --- this makes QEMU > create 25 of them. > > The lsi5

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Paolo Bonzini
On 23/01/2017 17:07, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: >> From: Shannon Zhao >> >> For ARM virt machine, if we use virt-2.7 which will not create ITS node, >> the virtio-net can not recieve interrupts so it can't get ip address >> through d

Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 05:46:47PM +0100, Paolo Bonzini wrote: > > > On 23/01/2017 17:07, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2017 at 08:55:04AM +0800, Shannon Zhao wrote: > >> From: Shannon Zhao > >> > >> For ARM virt machine, if we use virt-2.7 which will not create ITS node, > >> th

Re: [Qemu-devel] [PATCH 07/13] migration: create ram_multifd_page

2017-01-23 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> The function still don't use multifd, but we have simplified >> ram_save_page, xbzrle and RDMA stuff is gone. We have added a new >> counter and a new flag for this type of pages. >> >> Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH 05/13] migration: create multifd migration threads

2017-01-23 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Creation of the threads, nothing inside yet. >> >> Signed-off-by: Juan Quintela >> +void migrate_multifd_send_threads_join(void) >> +{ >> +int i, thread_count; >> + >> +if (!migrate_multifd()){ > > You've

Re: [Qemu-devel] ping2 Re: [PATCH v4 00/17] Dirty bitmaps postcopy migration

2017-01-23 Thread John Snow
I'm really sorry, but I personally don't have the time to review this until February 6th. Juan, David, does this look all-ok from your end? Are we just waiting for block reviews at this point? On 01/23/2017 06:48 AM, Vladimir Sementsov-Ogievskiy wrote: > Ping > > Hi all! What about this? > > 22

Re: [Qemu-devel] [PULL v2 0/8] Merge io/ 2017-01-23

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 15:57, Daniel P. Berrange wrote: > The following changes since commit 598cf1c805271564686f2d732b36f50c3c40dcdd: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-20 16:42:07 +) > > are available in the git repository at: > >

[Qemu-devel] [Bug 1217339] Re: SIGQUIT to send ACPI-shutdown to Guest

2017-01-23 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1217339 Title: SIGQUIT to send ACPI-shutdown to Guest Status in QEMU: New Bug description:

[Qemu-devel] [PULL v2 00/25] New hppa-linux target support

2017-01-23 Thread Richard Henderson
tory at: git://github.com/rth7680/qemu.git tags/pull-hppa-20170123 for you to fetch changes up to ebe9383caefd56d519e965a5d87bca29f0aeffe3: target-hppa: Implement floating-point insns (2017-01-23 09:52:40 -0800) hppa-linux

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Alex Williamson
On Mon, 23 Jan 2017 11:34:29 +0800 Peter Xu wrote: > On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: > > > > > > On 2017年01月22日 17:04, Peter Xu wrote: > > >On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: > > > > > >[...] > > > > > >>>+static void vtd_iotlb_page_inval

[Qemu-devel] [Bug 1248168] Re: MIPS, self-modifying code and uncached memory

2017-01-23 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1248168 Title: MIPS, self-modifying code and uncached memory Status in QEMU: Incomplete Bug de

[Qemu-devel] [PATCH 0/2] qemu-options: Rewrite -numa documentation

2017-01-23 Thread Eduardo Habkost
The first patch is a trivial fix to an issue reported by Peter Maydell. The second patch rewrites all the rest. Eduardo Habkost (2): qemu-options: Rename variables on the -numa "cpus" option qemu-options: Rewrite -numa documentation qemu-options.hx | 46 --

[Qemu-devel] [PATCH 2/2] qemu-options: Rewrite -numa documentation

2017-01-23 Thread Eduardo Habkost
Rewrite the -numa documentation to clarify what exactly it does. Signed-off-by: Eduardo Habkost --- qemu-options.hx | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 780528d6ad..a2c5d6668d 100644 -

[Qemu-devel] [PATCH 1/2] qemu-options: Rename variables on the -numa "cpus" option

2017-01-23 Thread Eduardo Habkost
Use @var{firstcpu} and @var{lastcpu} to make the metasyntatic variables a bit clearer. While doing this, use @var only around the metasyntatic variables, not including the square brackets and hyphen. The semantics of the "cpus" option will be clarified by rewriting the whole -numa documentation in

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-01-23 Thread Richard Henderson
On 01/20/2017 08:39 AM, Stafford Horne wrote: > (+CC Rth) > > I believe you also have some experience with openrisc. Any thought on > the below? > > On Sat, Jan 14, 2017 at 05:04:35PM +0900, Stafford Horne wrote: >> Hello, >> >> On Sat, Jan 14, 2017 at 12:29:32PM +0800, Jia Liu wrote: >>> Hi all

Re: [Qemu-devel] [PATCH RFC v4 01/20] vfio: trace map/unmap for notify as well

2017-01-23 Thread Alex Williamson
On Fri, 20 Jan 2017 21:08:37 +0800 Peter Xu wrote: > We traces its range, but we don't know whether it's a MAP/UNMAP. Let's > dump it as well. > > Signed-off-by: Peter Xu > --- > hw/vfio/common.c | 3 ++- > hw/vfio/trace-events | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) Ac

Re: [Qemu-devel] [PATCH 1/2] qemu-options: Rename variables on the -numa "cpus" option

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 18:06, Eduardo Habkost wrote: > Use @var{firstcpu} and @var{lastcpu} to make the metasyntatic > variables a bit clearer. While doing this, use @var only around > the metasyntatic variables, not including the square brackets and > hyphen. > > The semantics of the "cpus" option

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

2017-01-23 Thread Richard Henderson
On 01/23/2017 02:30 AM, Kirill Batuzov wrote: > Because 4 adds on 4 i32 registers work good only when the size of > vector elements matches the size of scalar variables we use for > representation of a vector. add_i16x8 will not be that great if we use > 4 i32 variables: each will need to be split

Re: [Qemu-devel] [PATCH RFC v4 02/20] vfio: introduce vfio_get_vaddr()

2017-01-23 Thread Alex Williamson
On Fri, 20 Jan 2017 21:08:38 +0800 Peter Xu wrote: > A cleanup for vfio_iommu_map_notify(). Should have no functional change, > just to make the function shorter and easier to understand. > > Signed-off-by: Peter Xu > --- > hw/vfio/common.c | 58 > +

Re: [Qemu-devel] [PATCH for-2.9 0/2] hbitmap: Add hbitmap_is_serializable()

2017-01-23 Thread Max Reitz
On 15.11.2016 23:57, Max Reitz wrote: > This series is a follow-up for "hbitmap: Fix shifts of constants by > granularity". > > So far, adding the assertion in hbitmap_serialization_granularity() (as > done by said previous patch) is enough and we know that it will always > hold true since bitmaps

Re: [Qemu-devel] [PATCH v7 03/27] mttcg: Add missing tb_lock/unlock() in cpu_exec_step()

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > From: Pranith Kumar > > The recent patch enabling lock assertions uncovered the missing lock > acquisition in cpu_exec_step(). This patch adds them. > > CC: Richard Henderson > CC: Alex Bennée > Signed-off-by: Pranith Kumar > --- > cpu-exec.c | 4

Re: [Qemu-devel] [PATCH v7 02/27] mttcg: translate-all: Enable locking debug in a debug build

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > From: Pranith Kumar > > Enable tcg lock debug asserts in a debug build by default instead of > relying on DEBUG_LOCKING. None of the other DEBUG_* macros have > asserts, so this patch removes DEBUG_LOCKING and enable these asserts > in a debug build. >

Re: [Qemu-devel] [PATCH v7 04/27] tcg: move TCG_MO/BAR types into own file

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > We'll be using the memory ordering definitions to define values for > both the host and guest. To avoid fighting with circular header > dependencies just move these types into their own minimal header. > > Signed-off-by: Alex Bennée > --- > tcg/tcg-mo

Re: [Qemu-devel] [PATCH v7 05/27] tcg: add options for enabling MTTCG

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > +void qemu_tcg_configure(QemuOpts *opts, Error **errp) > +{ > +const char *t = qemu_opt_get(opts, "thread"); > +if (t) { > +if (strcmp(t, "multi") == 0) { > +if (TCG_OVERSIZED_GUEST) { > +error_setg(errp, "No M

Re: [Qemu-devel] [PATCH v7 14/27] cputlb: tweak qemu_ram_addr_from_host_nofail reporting

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > This moves the helper function closer to where it is called and updates > the error message to report via error_report instead of the deprecated > fprintf. > > Signed-off-by: Alex Bennée > --- > cputlb.c | 24 > 1 file changed

Re: [Qemu-devel] [PATCH] pci: mark ROMs read-only

2017-01-23 Thread Marcel Apfelbaum
On 01/19/2017 11:00 PM, Michael S. Tsirkin wrote: Looks like we didn't mark PCI ROMs as RO allowing mischief such as guests writing there. Further, e.g. vhost gets confused trying to allocate enough space to log writes there. Fix it up. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 2 +-

Re: [Qemu-devel] [PATCH v7 15/27] cputlb: introduce tlb_flush_* async work.

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > +/* NOTE: > + * If flush_global is true (the usual case), flush all tlb entries. > + * If flush_global is false, flush (at least) all tlb entries not > + * marked global. > + * > + * Since QEMU doesn't currently implement a global/not-global flag > + * f

Re: [Qemu-devel] [PATCH v7 16/27] cputlb: add tlb_flush_by_mmuidx async routines

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > +/* Helper function to slurp va_args list into a bitmap > + */ > +static inline unsigned long make_mmu_index_bitmap(va_list args) > +{ > +unsigned long bitmap = 0; > +int mmu_index = va_arg(args, int); > + > +/* An empty va_list would be a ba

Re: [Qemu-devel] [PATCH RFC v4 10/20] memory: add section range info for IOMMU notifier

2017-01-23 Thread Alex Williamson
On Fri, 20 Jan 2017 21:08:46 +0800 Peter Xu wrote: > In this patch, IOMMUNotifier.{start|end} are introduced to store section > information for a specific notifier. When notification occurs, we not > only check the notification type (MAP|UNMAP), but also check whether the > notified iova is in th

Re: [Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

2017-01-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/01/2017 10:48, Markus Armbruster wrote: >> The PC machines (pc-q35-* pc-i440fx-* pc-* isapc xenfv) automatically >> create lsi53c895a SCSI HBAs and SCSI devices to honor -drive if=scsi. >> For giggles, try -drive if=scsi,bus=25,media=cdrom --- this makes QEMU >> crea

Re: [Qemu-devel] [PATCH v7 17/27] cputlb: atomically update tlb fields used by tlb_reset_dirty

2017-01-23 Thread Richard Henderson
On 01/19/2017 09:04 AM, Alex Bennée wrote: > The main use case for tlb_reset_dirty is to set the TLB_NOTDIRTY flags > in TLB entries to force the slow-path on writes. This is used to mark > page ranges containing code which has been translated so it can be > invalidated if written to. To do this sa

<    1   2   3   4   >