qed_aio_start_io and qed_aio_next_io will not have to acquire/release
the AioContext, while qed_aio_next_io_cb will. Split the functionality
and gain a little type-safety in the process.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/qed.c | 39 +---
On 2017-01-20 12:54, Wang, Wei W wrote:
> On Tuesday, January 17, 2017 5:46 PM, Jan Kiszka wrote:
>> On 2017-01-17 10:13, Wang, Wei W wrote:
>>> Hi Jan,
>>>
>>> On Monday, January 16, 2017 9:10 PM, Jan Kiszka wrote:
On 2017-01-16 13:41, Marc-André Lureau wrote:
> On Mon, Jan 16, 2017 at 12
qcow2_create2 calls this. Do not run a nested event loop, as that
breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup
list of the currently running one.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/block-backend.c | 12
1 file changed
Pull the increment/decrement pair out of aio_bh_poll and into the
callers.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
util/aio-posix.c | 8 +++-
util/aio-win32.c | 8
util/async.c | 12 ++--
3 files changed, 13 insertions(+), 15 deletions(-)
diff -
On Fri, Jan 20, 2017 at 10:50:49AM +0800, Shannon Zhao wrote:
> From: Shannon Zhao
>
> For ARM virt machine, if we use virt-2.7 which will not create ITS node,
> the virtio-net can not recieve interrupts so it can't get ip address
> through dhcp.
> This fixes commit 83d768b(virtio: set ISR on dat
This series pushes down aio_context_acquire/release to the point
where we can actually reason on using different fine-grained mutexes.
The main infrastructure is introduced in patch 1. The new API aio_co_wake
starts a coroutine with aio_context_acquire/release protection, which
requires tracking
Support separate coroutines for reading and writing, and place the
read/write handlers on the AioContext that the QIOChannel is registered
with.
Cc: Daniel P. Berrange
Signed-off-by: Paolo Bonzini
---
v1->v2:
improved qio_channel_set_aio_context docs, renamed to
q
This patch prepares for the removal of unnecessary lockcnt inc/dec pairs.
Extract the dispatching loop for file descriptor handlers into a new
function aio_dispatch_handlers, and then inline aio_dispatch into
aio_poll.
aio_dispatch can now become void.
Reviewed-by: Stefan Hajnoczi
Signed-off-by:
In the client, read the reply headers from a coroutine, switching the
read side between the "read header" coroutine and the I/O coroutine that
reads the body of the reply.
In the server, if the server can read more requests it will create a new
"read request" coroutine as soon as a request has bee
On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > There are theoretical concerns that some compilers might not trigger
> > build failures on attempts to define an array of size -1 and make it a
> > variable sized array instead. Let rewrite usi
This is in preparation for making qio_channel_yield work on
AioContexts other than the main one.
Cc: Daniel P. Berrange
Signed-off-by: Paolo Bonzini
---
v1->v2: removed QIOChannelRestart [Daniel]
include/io/channel.h | 25 +
io/channel-command.c | 13 +++
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/archipelago.c| 3 ---
block/block-backend.c | 7 ---
block/curl.c | 2 +-
block/io.c | 6 +-
block/iscsi.c | 3 ---
block/linux-aio.c | 5 +
block/mirror.c | 12
Signed-off-by: Paolo Bonzini
---
block/curl.c| 2 ++
block/io.c | 5 +
block/iscsi.c | 8 ++--
block/null.c| 4
block/qed.c | 12
block/qed.h | 3 +++
block/throttle-group
AioContext is fairly self contained, the only dependency is QEMUTimer but
that in turn doesn't need anything else. So move them out of block-obj-y
to avoid introducing a dependency from io/ to block-obj-y.
Signed-off-by: Paolo Bonzini
---
v1->v2: new patch [Daniel]
Makefile.objs
On Fri, Jan 20, 2017 at 06:13:22PM +0800, Cao jin wrote:
>
>
> On 01/20/2017 04:16 AM, Michael S. Tsirkin wrote:
> > This is a design and an initial patch for kernel side for AER
> > support in VFIO.
> >
> > 0. What happens now (PCIE AER only)
> >Fatal errors cause a link reset.
> >Non f
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/archipelago.c | 3 +++
block/blkdebug.c | 9 +
block/blkreplay.c | 2 +-
block/block-backend.c | 6 ++
block/curl.c | 26 ++
block/gluster.c | 9 +
block
The AioContext data structures are now protected by list_lock and/or
they are walked with FOREACH_RCU primitives. There is no need anymore
to acquire the AioContext for the entire duration of aio_dispatch.
Instead, just acquire it before and after invoking the callbacks.
The next step is then to p
** Attachment added: "Executable to reproduce this bug"
https://bugs.launchpad.net/qemu/+bug/1658141/+attachment/4806830/+files/exception.exe.bz2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1658
Signed-off-by: Paolo Bonzini
---
include/hw/virtio/virtio-access.h | 52 +++
1 file changed, 52 insertions(+)
diff --git a/include/hw/virtio/virtio-access.h
b/include/hw/virtio/virtio-access.h
index 91ae14d..2e92074 100644
--- a/include/hw/virtio/virtio-acces
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
include/block/block_int.h | 64 +-
include/sysemu/block-backend.h | 14 ++---
2 files changed, 49 insertions(+), 29 deletions(-)
diff --git a/include/block/block_int.h b/include/block/
On Fri, 01/20 06:59, no-re...@patchew.org wrote:
> Hi,
> ERROR:/tmp/qemu-test/src/tests/test-image-lock.c:109:do_test_compat_one:
> 'blk2' should not be NULL
Failed because centos 6 doesn't support F_OFD_SETLK. Will respin to ignore
locking in this case.
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio.c | 2 +-
include/hw/virtio/virtio.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index cc17b97..b1c5563 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1383,7 +1
This makes little difference, but it makes the code change smaller
for the next patch that introduces MemoryRegionCache. This is
because map/unmap are similar to MemoryRegionCache init/destroy.
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio.c | 76
On 16/01/2017 16:17, Peter Lieven wrote:
> nb_cls_shrunk in iscsi_allocmap_update can become -1 if the
> request starts and ends within the same cluster. This results
> in passing -1 to bitmap_set and bitmap_clear and they don't
> handle negative values properly. In the end this leads to data
> c
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 848c30f..668a97f 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -487,17 +487,16 @
On Fri, 20 Jan 2017 20:27:18 +0800
Peter Xu wrote:
> On Fri, Jan 20, 2017 at 11:43:28AM +0800, Peter Xu wrote:
>
> [...]
>
> > > What I don't want to see is for this API bug to leak out into the rest
> > > of the QEMU code such that intel_iommu code, or iommu code in general
> > > subtly avoids
For now, the cache is created on every virtqueue_pop. Later on,
direct descriptors will be able to reuse it.
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio.c | 91 ++
1 file changed, 50 insertions(+), 41 deletions(-)
diff --git a/hw/virtio
About extents: is 32bit length enough? We will have to send 4096 for
empty 16tb disk..
--
Best regards,
Vladimir
The cached translations are RCU-protected to allow efficient use
when processing virtqueues.
Signed-off-by: Paolo Bonzini
---
hw/virtio/virtio.c | 91 --
include/hw/virtio/virtio.h | 1 +
2 files changed, 89 insertions(+), 3 deletions(-)
diff
No cigar, conflicts with master.
Paolo
On 20/01/2017 14:31, Paolo Bonzini wrote:
> The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16
> 12:41:35 +)
>
> a
Patch posted during 2.8 hard freeze. Quick measurements give a 10%
performance improvement on various virtio-blk benchmarks, but the machine
I used seems to love my patches particularly today!
Paolo
Paolo Bonzini (7):
virtio: make virtio_should_notify static
virtio: add virtio_*_phys_cached
From: Marcelo Tosatti
As noticed by David Gilbert, commit 6053a86 'kvmclock: reduce kvmclock
differences on migration' added 'x-mach-use-reliable-get-clock' and a
compatibility entry that turns it off; however it got merged after 2.8.0
was released but the entry has gone into PC_COMPAT_2_7 where
The virtio-net change is necessary because it uses virtqueue_fill
and virtqueue_flush instead of the more convenient virtqueue_push.
Signed-off-by: Paolo Bonzini
---
hw/net/virtio-net.c | 14 +-
hw/virtio/virtio.c | 138 +---
2 files changed,
The following changes since commit d1c82f7cc34443841095f490345f86c9d8baca34:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170120-v2' into
staging (2017-01-20 15:53:58 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
On 20/01/2017 17:57, Michael S. Tsirkin wrote:
> On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" writes:
>>
>>> There are theoretical concerns that some compilers might not trigger
>>> build failures on attempts to define an array of size -1 and make it
On Fri, Jan 20, 2017 at 06:09:52PM +0100, Paolo Bonzini wrote:
>
>
> On 20/01/2017 17:57, Michael S. Tsirkin wrote:
> > On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" writes:
> >>
> >>> There are theoretical concerns that some compilers might not tri
Pavel Dovgalyuk writes:
>> From: Alex Bennée [mailto:alex.ben...@linaro.org]
>> >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com]
>> >> >
>> >> > Yes, this option helps.
>> >> > Thank you.
>> >>
>> >> Good news. This can be fixed in 2.8.1 once someone finds a solution.
>> >
>> > It seems tha
On Fri, Jan 20, 2017 at 06:07:50PM +0100, Paolo Bonzini wrote:
> Patch posted during 2.8 hard freeze. Quick measurements give a 10%
> performance improvement on various virtio-blk benchmarks, but the machine
> I used seems to love my patches particularly today!
>
> Paolo
Will review, thanks!
>
On Fri, Jan 20, 2017 at 08:21:28AM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Thu, Jan 19, 2017 at 02:33:40PM +0100, Markus Armbruster wrote:
> >> Paolo Bonzini writes:
> >>
> >> > On 19/01/2017 09:12, Markus Armbruster wrote:
> >> >> "Michael S. Tsirkin" writes:
>
On Debian this is still present in QEMU 1:2.7+dfsg-3+b1 with the 4.8.11-1 Linux
kernel.
So no change in the past 5 quarters :-(
So I'm attaching a tar file containing standalone and somewhat
minimalist source code for reproducing this issue. Just compile it with
MinGW by typing 'make', send the c
As an alternative to compiling the source code yourselves, I have
attached the capture.exe binary.
** Attachment added: "Executable to reproduce this bug"
https://bugs.launchpad.net/qemu/+bug/1499908/+attachment/4806840/+files/capture.exe.bz2
--
You received this bug notification because you
> On 20 Jan 2017, at 17:04, Vladimir Sementsov-Ogievskiy
> wrote:
>
> About extents: is 32bit length enough? We will have to send 4096 for empty
> 16tb disk..
The nbd protocol uniformly uses 32 bit lengths (for better or for worse). This
is baked into the specification heavily.
I'm not sure
On Fri, 20 Jan 2017 14:04:08 +0800
Cao jin wrote:
> On 01/19/2017 06:36 AM, Alex Williamson wrote:
> > On Sat, 31 Dec 2016 17:13:08 +0800
> > Cao jin wrote:
> >
> >> From: Chen Fan
> >>
> >> Add 'aer' property, let user choose whether expose the aer capability
> >> or not.
> >
> > But tha
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/824074
Title:
Provide runtime option to expose the supported list of keymaps for vnc
Status i
QEMU 0.15 is pretty much outdated ... can you still reproduce this issue
with the latest version of QEMU, or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscr
On Fri, 20 Jan 2017 14:03:42 +0800
Cao jin wrote:
> On 01/19/2017 06:09 AM, Alex Williamson wrote:
> > On Sat, 31 Dec 2016 17:13:06 +0800
> > Cao jin wrote:
> >
> >> From: Chen Fan
> >>
> >> Introduce new function to initilize AER capability registers
> >> for vfio-pci device.
> >>
> >> Sign
On Fri, 20 Jan 2017 06:57:22 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Thursday, January 19, 2017 6:32 AM
> >
> > On Sat, 31 Dec 2016 17:13:07 +0800
> > Cao jin wrote:
> >
> > > From: Chen Fan
> > >
> > > When physical device has uncorrectable error hanppened, the vfio_
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/903365
Title:
[feature request] bind nat (-net user) to other interface (like
eth0:2)
Statu
"Michael S. Tsirkin" writes:
> On Fri, Jan 20, 2017 at 06:09:52PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 20/01/2017 17:57, Michael S. Tsirkin wrote:
>> > On Fri, Jan 20, 2017 at 08:42:41AM +0100, Markus Armbruster wrote:
>> >> "Michael S. Tsirkin" writes:
>> >>
>> >>> There are theoretical co
On Fri, Jan 20, 2017 at 03:30:54PM +0100, David Hildenbrand wrote:
> Am 19.01.2017 um 18:45 schrieb Daniel P. Berrange:
> > On Thu, Jan 19, 2017 at 06:21:22PM +0100, David Hildenbrand wrote:
> >>
> Also think about "query-cpu-model-expansion model=host type=static",
> which will primarily
Since there hasn't been any more complains about later binaries, I
assume we can close this issue nowadays. (Feel free to re-open it
otherwise)
** Changed in: qemu
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
From: Michael Davidsaver
The MRS and MSR instruction handling has a number of flaws:
* unprivileged accesses should only be able to read
CONTROL and the xPSR subfields, and only write APSR
(others RAZ/WI)
* privileged access should not be able to write xPSR
subfields other than APSR
*
From: Michael Davidsaver
FAULTMASK must be cleared on return from all
exceptions other than NMI.
Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/target/
From: Michael Davidsaver
Give an explicit error and abort when a load
from the vector table fails. Architecturally this
should HardFault (which will then immediately
fail to load the HardFault vector and go into Lockup).
Since we don't model Lockup, just report this guest
error via cpu_abort(). T
From: Michael Davidsaver
The v7m CONTROL register bit 1 is SPSEL, which indicates
the stack being used. We were storing this information
not in v7m.control but in the separate v7m.other_sp
structure field. Unfortunately, the code handling reads
of the CONTROL register didn't take account of this,
hw/register.h provides macros like FIELD which make it easy to define
shift, mask and length constants for the fields within a register.
Unfortunately register.h also includes a lot of other things, some
of which will only compile in the softmmu build.
Pull the FIELD macro and friends out into a s
From: Michael Davidsaver
For v7m we need to catch attempts to execute from special
addresses at 0xfff0 and above. Previously we did this
with the aid of a hacky special purpose lump of memory
in the address space and a check in translate.c for whether
we were translating code at those address
Does qemu allow to disable the PS/2 port now?
If so then there is easy workaround in case something similar ever
happens.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/639651
Title:
DRIVER_IRQL_NO
From: Michael Davidsaver
When the guest attempts to start an MII register
access via the MCTL register, clear the START bit,
so that when the guest reads it back the register
transaction will be signalled as having completed.
This avoids the guest spinning as it polls the
START bit waiting for it
This set of six patches is some simple bug fixes which
I've pulled out of Michael Davidsaver's old NVIC rewrite
patchset, as an initial start on getting it upstream.
None of them are particularly exciting, but they're
self-contained so they might as well go through code
review and get into master a
On Wed, Jan 18, 2017 at 06:13:18PM +0100, Igor Mammedov wrote:
> move smbios_set_cpuid() close to the rest of smbios init code
> where it belongs to instead of calling it from pc_cpus_init().
>
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
Applying to machine-next. Thanks!
--
E
On Wed, Jan 18, 2017 at 06:13:19PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
Applying to machine-next. Thanks!
--
Eduardo
On Fri, Jan 20, 2017 at 10:44 AM, Peter Maydell
wrote:
> hw/register.h provides macros like FIELD which make it easy to define
> shift, mask and length constants for the fields within a register.
> Unfortunately register.h also includes a lot of other things, some
> of which will only compile in t
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/6] ARMv7M: some simple bugfixes and cleanups
Message-id: 1484937883-1068-1-git-send-email-peter.mayd...@linaro.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
B
On 01/20/2017 12:00 PM, Alex Bligh wrote:
>
>> On 20 Jan 2017, at 17:04, Vladimir Sementsov-Ogievskiy
>> wrote:
>>
>> About extents: is 32bit length enough? We will have to send 4096 for empty
>> 16tb disk..
>
> The nbd protocol uniformly uses 32 bit lengths (for better or for worse).
> This
On Fri, Jan 20, 2017 at 02:01:16PM +0100, Thomas Huth wrote:
> Now that CPUs show up in the help text of "-device ?",
> we should group them into an appropriate category.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Eduardo Habkost
I assume Paolo will want to queue it, as he had queued v1.
--
On Fri, Jan 20, 2017 at 08:55:58AM +0800, Haozhong Zhang wrote:
> On 01/16/17 11:00 +, Stefan Hajnoczi wrote:
> > On Mon, Jan 16, 2017 at 01:55:34PM +0800, Xiao Guangrong wrote:
> > > On 01/14/2017 02:02 AM, Eduardo Habkost wrote:
> > > > On Fri, Jan 13, 2017 at 01:17:27PM +, Stefan Hajnocz
On Wed, Jan 18, 2017 at 04:34:47PM -0800, Alistair Francis wrote:
> On Wed, Jan 18, 2017 at 10:56 AM, Thomas Huth wrote:
> > On 18.01.2017 18:57, Alistair Francis wrote:
> >> On Wed, Jan 18, 2017 at 4:44 AM, Thomas Huth wrote:
> >>> Sometimes it is useful to have just a machine with CPU and RAM,
Ping? Any feedback?
On Tue, Jan 17, 2017 at 04:46:35PM -0200, Eduardo Habkost wrote:
> This moves the arch_init.c soundhw code to its own file, renames
> audio_init() to soundhw_init(), and renames hw/audio/audio.h to
> hw/audio/soundhw.h.
>
> Eduardo Habkost (3):
> audio: Move arch_init audio
Commit 7a9877a made the 'device' parameter to BlockIOThrottle
optional, favoring 'id' instead. But it forgot to update the
HMP usage to set has_device, which makes all attempts to change
throttling via HMP fail with "Need exactly one of 'device' and 'id'"
CC: qemu-sta...@nongnu.org
Signed-off-by:
On Fri, Jan 20, 2017 at 13:30:15 +0100, p...@philjordan.eu wrote:
> This series makes the Qemu usb-tablet work correctly with OS X/macOS guests
> without the need for a special guest driver.
>
> * The usb-tablet should not have a boot protocol of 2. Other OSes seem to
> ignore this, but the IOH
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/744856
Title:
can't boot w
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1484925
Title:
Segfault wi
201 - 273 of 273 matches
Mail list logo
