Re: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON

2017-01-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > All users include the trailing ;, let's require that > so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not > produce unexpected results. > > Not a huge problem for QEMU since our style requires the use > of {} but seems cleaner nevertheless. I think the actual

Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON

2017-01-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > QEMU_BUILD_BUG_ON uses a typedef in order to be safe > to use outside functions, but sometimes it's useful > to have a version that can be used within an expression. > Following what Linux does, introduce QEMU_BUILD_BUG_ON_ZERO > that return zero after checking cond

Re: [Qemu-devel] [PATCH v2 4/4] ARRAY_SIZE: check that argument is an array

2017-01-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring > changes the argument from an array to a pointer to a dynamically > allocated buffer. Code keeps compiling but any ARRAY_SIZE calls now > return the size of the pointer divided by element size. >

Re: [Qemu-devel] [PATCH v2 23/25] console: make screendump async

2017-01-19 Thread Gerd Hoffmann
On Mi, 2017-01-18 at 20:03 +0400, Marc-André Lureau wrote: > +surface = qemu_console_surface(con); > + > +/* FIXME: async save with coroutine? it would have to copy or > lock > + * the surface. */ > +ppm_save(filename, surface, &err); > + No need to lock or copy. ppm_save() uses t

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-19 Thread Peter Xu
On Wed, Jan 18, 2017 at 03:49:44PM +0800, Peter Xu wrote: [...] > I was trying to invalidate the entire address space by sending a big > IOTLB notification to vfio-pci, which looks like: > > IOMMUTLBEntry entry = { > .target_as = &address_space_memory, > .iova = 0, > .transla

[Qemu-devel] [Bug 665743] Re: Cocoa video corruption when guest uses RGB565 mode

2017-01-19 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? If so, could you please rebase your patch to the latest git version and send it to the mailing list (see http://qemu- project.org/Contribute/SubmitAPatch for details)? Sorry, we do not take patches from the bugtracker, they alway

[Qemu-devel] [Bug 618533] Re: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm-9999 (GIT)

2017-01-19 Thread Thomas Huth
Is this issue still reproducible with the latest version of QEMU, or could we close this issue nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

[Qemu-devel] [Bug 645662] Re: Python 3.1.2 math errors with Qemu 0.12.5

2017-01-19 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? As far as I know, the FPU emulation has been completely switched to softfloat with the latest versions, so I assume your problem might be fixed in recent releases... ** Changed in: qemu Status: New => Incomplete -- You

[Qemu-devel] [Bug 1256432] Re: qemu mingw 32bit windows crash

2017-01-19 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256432 Title: qemu mingw 32bit windows crash Status in QEMU: Fix Released Bug descri

Re: [Qemu-devel] [PULL 04/41] virtio: convert to use DMA api

2017-01-19 Thread Paolo Bonzini
On 18/01/2017 20:10, Michael S. Tsirkin wrote: >> Coverity reports that ARRAY_SIZE(elem->out_sg) (and all the others too) >> is wrong because elem->out_sg is a pointer. >> >> However, the check is not in the right place and the max_size argument >> of virtqueue_map_iovec can be removed. The chec

[Qemu-devel] [PATCH] build-sys: Minor qapi doc generation target cleanups

2017-01-19 Thread Markus Armbruster
Move makeinfo flags from MAKEINFO to MAKEINFOFLAGS. Fix the call of quiet-command for target qemu-ga-qapi.texi. Both messed up in commit 56e8bdd. Cc: Marc-André Lureau Signed-off-by: Markus Armbruster --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makef

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-01-19 Thread Paolo Bonzini
On 19/01/2017 04:32, Jason Wang wrote: >> >>> +addr &= ~(sz - 1); +} else { +sz = VTD_PAGE_SIZE; +} +entry.target_as = &vtd_dev_as->as; +entry.addr_mask = sz - 1; +entry.iova = addr; >>> If S=1, entry.iova must mask away the

Re: [Qemu-devel] [PATCH v2 6/6] qapi: Promote blockdev-change-medium arguments to QAPI type

2017-01-19 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2017 at 9:02 PM Eric Blake wrote: > Having a named rather than anonymous C type will make it easier > to improve the testsuite in a later patch. No semantic change, > to any of the existing code or to the introspection output. > > Signed-off-by: Eric Blake > > You should mov

Re: [Qemu-devel] [PATCH v2 1/6] pci: Use struct instead of QDict to pass back parameters

2017-01-19 Thread Marc-André Lureau
On Wed, Jan 18, 2017 at 8:58 PM Eric Blake wrote: > It's simpler to just use a C struct than it is to bundle things > into a QDict in one function just to pull them back out in the > caller. Plus, doing this gets rid of one more user of dynamic > JSON through qobject_from_jsonf(). > and it look

Re: [Qemu-devel] [PATCH] hw/usb/dev-hid: add a Mac guest compatibility option to usb-tablet

2017-01-19 Thread Gerd Hoffmann
On Mi, 2017-01-18 at 15:30 +0100, Phil Dennis-Jordan wrote: > Darwin/OS X/macOS's HID driver stack does not correctly drive Qemu's > simulated USB Tablet. This adds a boolean option "mac_compat" which > subtly changes the device so it behaves in a way that Mac guests can > handle. > > The specific

Re: [Qemu-devel] [PATCH v2 3/6] qlist: Add convenience helpers for wrapped appends

2017-01-19 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2017 at 8:34 PM Eric Blake wrote: > Similar to the qdict additions of the previous patch, although > this time there are not as many clients. > > Signed-off-by: Eric Blake > Not very useful, but why not: Reviewed-by: Marc-André Lureau > --- > include/qapi/qmp/qlist.h |

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2017 at 8:44 PM Eric Blake wrote: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > > Signed-off-by

Re: [Qemu-devel] [PATCH v2 5/6] test-qga: Actually test 0xff sync bytes

2017-01-19 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2017 at 8:39 PM Eric Blake wrote: > Commit 62c39b3 introduced test-qga, and at face value, appears > to be testing the 'guest-sync' behavior that is recommended for > guests in sending 0xff to QGA to force the parser to reset. But > this aspect of the test has never actually

Re: [Qemu-devel] [PATCH] build-sys: Minor qapi doc generation target cleanups

2017-01-19 Thread Marc-André Lureau
On Thu, Jan 19, 2017 at 1:07 PM Markus Armbruster wrote: > Move makeinfo flags from MAKEINFO to MAKEINFOFLAGS. Fix the call of > quiet-command for target qemu-ga-qapi.texi. Both messed up in commit > 56e8bdd. > > Cc: Marc-André Lureau > Signed-off-by: Markus Armbruster > Yes, I thought you t

Re: [Qemu-devel] [PATCH v2 1/6] pci: Use struct instead of QDict to pass back parameters

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > It's simpler to just use a C struct than it is to bundle things > into a QDict in one function just to pull them back out in the > caller. Plus, doing this gets rid of one more user of dynamic > JSON through qobject_from_jsonf(). > > Signed-off-by: Eric Blake > Acked-by: Mi

[Qemu-devel] [PATCH RFC 2/3] vfio: introduce vfio_get_vaddr()

2017-01-19 Thread Peter Xu
A cleanup for vfio_iommu_map_notify(). Should have no functional change, just to make the function shorter and easier to understand. Signed-off-by: Peter Xu --- hw/vfio/common.c | 58 +--- 1 file changed, 38 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH RFC 1/3] vfio: trace map/unmap for notify as well

2017-01-19 Thread Peter Xu
We traces its range, but we don't know whether it's a MAP/UNMAP. Let's dump it as well. Signed-off-by: Peter Xu --- hw/vfio/common.c | 3 ++- hw/vfio/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 801578b..174f351

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > > Signed-off-by: Eric Blake > Reviewed-by: Albert

[Qemu-devel] [PATCH RFC 0/3] vfio: allow to notify unmap for very big region

2017-01-19 Thread Peter Xu
This requirement originates from the VT-d vfio series: https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03495.html The goal of this series is to allow IOMMU to notify unmap with very big IOTLB range, for example, with base=0 and size=2^63-1 (to unmap the whole address space). The fi

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-19 Thread Laszlo Ersek
On 01/19/17 08:09, Ben Warren wrote: > >> On Jan 18, 2017, at 4:02 PM, Ben Warren >> wrote: >> >> Hi Michael, >>> On Jan 17, 2017, at 9:45 AM, Michael S. Tsirkin >>> wrote: >>> >>> On Mon, Jan 16, 2017 at 10:57:42AM -0800, Ben Warren wrote: I think we have a misunderstanding here. I'm stori

Re: [Qemu-devel] [PATCH v2 4/6] fdc-test: Avoid deprecated 'change' command

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > Use the preferred blockdev-change-medium command instead. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow > --- > tests/fdc-test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/fdc-test.c b/tests/fdc-test.c > index 738c6b4..f5ff

[Qemu-devel] [PATCH RFC 3/3] vfio: allow to notify unmap for very large region

2017-01-19 Thread Peter Xu
Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big region. This can be leveraged by QEMU IOMMU implementation to cleanup existing page mappings for an entire iova address space (by notifying with an IOTLB with extremely huge addr_mask). However current vfio_iommu_map_notify() does

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-19 Thread Peter Xu
On Thu, Jan 19, 2017 at 06:22:48AM +, Tian, Kevin wrote: [...] > still copy response from spec owner here:-) > > Explicit invalidation is anytime software is explicitly invalidating > something ( > through any descriptor) as opposed to something hardware does > implicitly. >

Re: [Qemu-devel] [PATCH v1 11/15] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-01-19 Thread Daniel P. Berrange
On Wed, Jan 18, 2017 at 07:13:19PM +0100, Max Reitz wrote: > On 03.01.2017 19:27, Daniel P. Berrange wrote: > > This converts the qcow2 driver to make use of the QCryptoBlock > > APIs for encrypting image content, using the legacyy QCow2 AES > > scheme. > > > > With this change it is now required

Re: [Qemu-devel] [RFC 00/13] numa: add '-numa cpu' option

2017-01-19 Thread Daniel P. Berrange
On Wed, Jan 18, 2017 at 06:13:16PM +0100, Igor Mammedov wrote: > > Series introduces a new CLI option to allow mapping cpus to numa > nodes using public properties [socket|core|thread]-ids instead of > internal cpu-index and moving cpu<->node mapping from global bitmaps > to PCMachineState struct.

Re: [Qemu-devel] [PATCH v2 5/6] test-qga: Actually test 0xff sync bytes

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > Commit 62c39b3 introduced test-qga, and at face value, appears > to be testing the 'guest-sync' behavior that is recommended for > guests in sending 0xff to QGA to force the parser to reset. But > this aspect of the test has never actually done anything: the > qmp_fd() call

Re: [Qemu-devel] [PATCH v2 1/4] virtio: fix up max size checks

2017-01-19 Thread Cornelia Huck
On Wed, 18 Jan 2017 22:55:40 +0200 "Michael S. Tsirkin" wrote: > Coverity reports that ARRAY_SIZE(elem->out_sg) (and all the others too) > is wrong because elem->out_sg is a pointer. > > However, the check is not in the right place and the max_size argument > of virtqueue_map_iovec can be remove

Re: [Qemu-devel] [PATCH v2 6/6] qapi: Promote blockdev-change-medium arguments to QAPI type

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > Having a named rather than anonymous C type will make it easier > to improve the testsuite in a later patch. Post it together with said later patch then. >No semantic change, > to any of the existing code or to the introspection o

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-01-19 Thread Zhang Chen
Hi~~ Anyone have any comments? Ping Thanks Zhang Chen On 01/05/2017 02:08 PM, Zhang Chen wrote: Xen COLO depend on qemu COLO replication function. So, We need new qmp commands for Xen to use qemu replication. Corresponding libxl patches already in xen.git. Commit ID: ed37ef1f91c20f0a

Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON

2017-01-19 Thread Paolo Bonzini
On 19/01/2017 09:12, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> QEMU_BUILD_BUG_ON uses a typedef in order to be safe >> to use outside functions, but sometimes it's useful >> to have a version that can be used within an expression. >> Following what Linux does, introduce QEMU_

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-19 Thread Paolo Bonzini
On 17/01/2017 20:00, Michael S. Tsirkin wrote: >>> vhost user is not supposed to use maskfd at all. >>> >>> We have this code: >>>if (net->nc->info->type == NET_CLIENT_DRIVER_VHOST_USER) { >>>dev->use_guest_notifier_mask = false; >>>} >>> >>> isn't it effective? >> >>

Re: [Qemu-devel] [PULL 0/4] Tracing patches

2017-01-19 Thread Peter Maydell
On 16 January 2017 at 13:44, Stefan Hajnoczi wrote: > The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 > 12:41:35 +) > > are available in the git reposito

Re: [Qemu-devel] [libvirt] [PATCH 0/9] i386: query-cpu-model-expansion test script

2017-01-19 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 08:18:40PM +0100, David Hildenbrand wrote: > Am 18.01.2017 um 18:34 schrieb Eduardo Habkost: > > On Wed, Jan 18, 2017 at 12:09:28PM -0500, Jason J. Herne wrote: > >> On 01/18/2017 12:00 PM, Eduardo Habkost wrote: > >>> On Tue, Jan 17, 2017 at 10:22:10AM -0500, Jason J. Herne

Re: [Qemu-devel] [RFC 00/13] numa: add '-numa cpu' option

2017-01-19 Thread Eduardo Habkost
On Thu, Jan 19, 2017 at 09:45:11AM +, Daniel P. Berrange wrote: > On Wed, Jan 18, 2017 at 06:13:16PM +0100, Igor Mammedov wrote: > > > > Series introduces a new CLI option to allow mapping cpus to numa > > nodes using public properties [socket|core|thread]-ids instead of > > internal cpu-index

Re: [Qemu-devel] [PATCH v2 4/4] ARRAY_SIZE: check that argument is an array

2017-01-19 Thread Peter Maydell
On 19 January 2017 at 08:20, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring >> changes the argument from an array to a pointer to a dynamically >> allocated buffer. Code keeps compiling but any ARRAY_SIZE calls no

Re: [Qemu-devel] [PATCH 0/7] target-m68k: implement 680x0 FPU

2017-01-19 Thread Laurent Vivier
Le 18/01/2017 à 22:42, Richard Henderson a écrit : > On 01/18/2017 01:05 PM, Laurent Vivier wrote: >> This series modifies the original ColdFire FPU implementation >> to use floatx80 instead of float64 internally as this >> is the native datatype for 680x0. I didn't keep the float64 >> type for Col

Re: [Qemu-devel] [PATCH 3/4] compiler: expression version of QEMU_BUILD_BUG_ON

2017-01-19 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > QEMU_BUILD_BUG_ON uses a typedef in order to be safe > to use outside functions, but sometimes it's useful > to have a version that can be used within an expression. > Following what Linux does, introduce QEMU_BUILD_BUG_ON_ZERO > that return zero afte

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-19 Thread Dou Liyang
Hi, Igor, At 01/18/2017 09:46 PM, Igor Mammedov wrote: On Wed, 18 Jan 2017 20:40:04 +0800 Dou Liyang wrote: As we fixed a bug(Bug 1) in below links, Named "Method-A": https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03354.html Then, Eduardo gave us many suggests. Thanks very much

Re: [Qemu-devel] [Qemu-stable] Data corruption in Qemu 2.7.1

2017-01-19 Thread Fabian Grünbichler
On Wed, Jan 18, 2017 at 05:30:17PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 17:19, Fabian Grünbichler wrote: > > Jan 18 17:07:51 ubuntu kernel: sd 2:0:0:0: [sda] tag#109 FAILED Result: > > hostbyte=DID_OK driverbyte=DRIVER_SENSE > > Jan 18 17:07:51 ubuntu kernel: sd 2:0:0:0: [sda] tag#109

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add round-to-odd rounding mode

2017-01-19 Thread Peter Maydell
On 19 January 2017 at 05:14, Bharata B Rao wrote: > Power ISA 3.0 introduces a few quadruple precision floating point > instructions that support round-to-add rounding mode. The > round-to-odd mode is explained as under: > > Let Z be the intermediate arithmetic result or the operand of a convert >

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-19 Thread Dou Liyang
Hi, Eduardo At 01/19/2017 01:06 AM, Eduardo Habkost wrote: On Wed, Jan 18, 2017 at 09:26:36PM +0800, Dou Liyang wrote: Hi, All ** ERROR:/tmp/qemu-test/src/tests/vhost-user-test.c:668:test_migrate: assertion failed: (qdict_haskey(rsp, "return")) GTester: last random seed: R02Sf52546c4daff8087

Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value

2017-01-19 Thread Cao jin
On 01/18/2017 11:21 PM, Michael S. Tsirkin wrote: > On Wed, Jan 18, 2017 at 02:29:19PM +0800, Cao jin wrote: >> >> >> On 01/18/2017 12:01 AM, Michael S. Tsirkin wrote: >>> On Tue, Jan 17, 2017 at 02:50:38PM +0800, Cao jin wrote: forget to cc maintainers in this new patch On 01/17/2

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/18] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2017-01-19 Thread Peter Maydell
On 18 January 2017 at 09:17, Edgar E. Iglesias wrote: > Hi Peter, I'm on holidays and won't have time to review for a couple of > weeks at least... Do you want me to hold off on committing the GICv3 patches until you get back and have had a chance to review? thanks -- PMM

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/18] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2017-01-19 Thread Edgar E. Iglesias
Nah, if I find something we can always fix it with follow up patches... Cheers, Edgar On Jan 19, 2017 1:59 PM, "Peter Maydell" wrote: > On 18 January 2017 at 09:17, Edgar E. Iglesias > wrote: > > Hi Peter, I'm on holidays and won't have time to review for a couple of > > weeks at least... > >

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

2017-01-19 Thread Kirill Batuzov
On Wed, 18 Jan 2017, Richard Henderson wrote: > On 01/17/2017 01:07 AM, Kirill Batuzov wrote: > > +static inline TCGv_v128 tcg_global_mem_new_v128(TCGv_ptr reg, intptr_t > > offset, > > +const char *name) > > +{ > > +int idx = tcg_global_mem_new_

[Qemu-devel] [PATCH 1/2] qapi: Tweak error message of bdrv_query_image_info

2017-01-19 Thread Fam Zheng
@bs doesn't always have a device name, such as when it comes from "qemu-img info". Report file name instead. Signed-off-by: Fam Zheng --- block/qapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index a62e862..6329735 100644 --- a/block/qap

[Qemu-devel] [PATCH 0/2] block: Fix iotests 059

2017-01-19 Thread Fam Zheng
The 059.out went out of sync, bring it back in line. Fam Zheng (2): qapi: Tweak error message of bdrv_query_image_info iotests: Fix reference output for 059 block/qapi.c | 4 ++-- tests/qemu-iotests/059.out | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.9.3

[Qemu-devel] [PATCH 2/2] iotests: Fix reference output for 059

2017-01-19 Thread Fam Zheng
It was broken by efaa7c4eeb7 when it dropped the device name "image" from BB API. Now this error message text is updated again, sync it up. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/059.out b/te

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-19 Thread Peter Maydell
On 18 January 2017 at 17:26, Laszlo Ersek wrote: > In brief, for one data point, I'd be fine if we didn't tie this change > to machine types. We seem to have arrived at a consensus that we don't need to version-constrain this change, so I'm applying Ard's patch to target-arm.next. thanks -- PMM

Re: [Qemu-devel] [PATCH] hw/usb/dev-hid: add a Mac guest compatibility option to usb-tablet

2017-01-19 Thread Phil Dennis-Jordan
Thanks for looking into this, Gerd. On 19 January 2017 at 10:06, Gerd Hoffmann wrote: > Waded through the specs. Setting bInterfaceProtocol to 0x00 should be > done anyway. Only boot protocol devices (which the tablet isn't) should > set this to 1 (kbd) or 2 (mouse). No need to hide that behi

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/18] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2017-01-19 Thread Peter Maydell
On 19 January 2017 at 13:02, Edgar E. Iglesias wrote: > Nah, if I find something we can always fix it with follow up patches... Cool. I've applied this series to target-arm.next. thanks -- PMM

Re: [Qemu-devel] [PATCH v2 3/4] compiler: expression version of QEMU_BUILD_BUG_ON

2017-01-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/01/2017 09:12, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> QEMU_BUILD_BUG_ON uses a typedef in order to be safe >>> to use outside functions, but sometimes it's useful >>> to have a version that can be used within an expression. >>> Following wh

Re: [Qemu-devel] [PULL v2 00/32] Misc patches for 2017-01-11

2017-01-19 Thread Peter Maydell
On 16 January 2017 at 16:58, Paolo Bonzini wrote: > The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 > 12:41:35 +) > > are available in the git repository

[Qemu-devel] [Bug 641118] Re: NetBSD guest only supports network without ACPI

2017-01-19 Thread Nigel Horne
I've just tried, and it is OK using NetBSD7 as the guest. I no longer have NetBSD5 so I am unable to check if the problem still exists on that. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/641118 T

Re: [Qemu-devel] [RFC 00/13] numa: add '-numa cpu' option

2017-01-19 Thread Igor Mammedov
On Thu, 19 Jan 2017 09:45:11 + "Daniel P. Berrange" wrote: > On Wed, Jan 18, 2017 at 06:13:16PM +0100, Igor Mammedov wrote: > > > > Series introduces a new CLI option to allow mapping cpus to numa > > nodes using public properties [socket|core|thread]-ids instead of > > internal cpu-index an

[Qemu-devel] [PULL 00/36] target-arm queue

2017-01-19 Thread Peter Maydell
x27; into staging (2017-01-17 16:54:09 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170119 for you to fetch changes up to 245c8cbc4e4f0f8b6c3dfaab2090d1d55f94d360: hw/arm/virt: Add board property to enable EL2 (2017-0

[Qemu-devel] [PULL 21/36] target-arm: Expose output GPIO line for VCPU maintenance interrupt

2017-01-19 Thread Peter Maydell
The GICv3 support for virtualization includes an outbound maintenance interrupt signal which is asserted when the CPU interface wants to signal to the hypervisor that it needs attention. Expose this as an outbound GPIO line from the CPU object which can be wired up as a physical interrupt line by t

[Qemu-devel] [PULL 27/36] hw/intc/arm_gicv3: Implement ICV_ registers which are just accessors

2017-01-19 Thread Peter Maydell
If the HCR_EL2.IMO or FMO bits are set, accesses to ICC_ system registers are redirected to be accesses to ICV_ registers (the guest-visible interface to the virtual interrupt controller). Implement this behaviour for the ICV_ registers which are simple accessors to the underlying register state.

[Qemu-devel] [PULL 34/36] target/arm/psci.c: If EL2 implemented, start CPUs in EL2

2017-01-19 Thread Peter Maydell
The PSCI spec states that a CPU_ON call should cause the new CPU to be started in the highest implemented Non-secure exception level. We were incorrectly starting it at the exception level of the caller, which happens to be correct if EL2 is not implemented. Implement the correct logic as described

[Qemu-devel] [PULL 20/36] hw/intc/arm_gic: Add external IRQ lines for VIRQ and VFIQ

2017-01-19 Thread Peter Maydell
Augment the GIC's QOM device interface by adding two new sets of sysbus IRQ lines, to signal VIRQ and VFIQ to each CPU. We never use these, but it's helpful to keep the v2-and-earlier GIC's external interface in line with that of the GICv3 to avoid board code having to add extra code conditional o

[Qemu-devel] [PULL 22/36] hw/arm/virt: Wire VIRQ, VFIQ, maintenance irq lines from GIC to CPU

2017-01-19 Thread Peter Maydell
Wire the new VIRQ, VFIQ and maintenance interrupt lines from the GIC to each CPU. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Message-id: 1483977924-14522-5-git-send-email-peter.mayd...@linaro.org --- include/hw/arm/virt.h | 2 ++ hw/arm/virt.c | 14 +++--- 2 fi

[Qemu-devel] [PULL 23/36] target-arm: Add ARMCPU fields for GIC CPU i/f config

2017-01-19 Thread Peter Maydell
Add fields to the ARMCPU structure to allow CPU classes to specify the configurable aspects of their GIC CPU interface. In particular, the virtualization support allows different values for number of list registers, priority bits and preemption bits. Signed-off-by: Peter Maydell Acked-by: Alistai

[Qemu-devel] [PULL 19/36] hw/intc/arm_gicv3: Add external IRQ lines for VIRQ and VFIQ

2017-01-19 Thread Peter Maydell
Augment the GICv3's QOM device interface by adding two new sets of sysbus IRQ lines, to signal VIRQ and VFIQ to each CPU. Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Message-id: 1483977924-14522-2-git-send-email-peter.mayd...@linaro.org --- include/hw/intc/arm_gicv3_common.h | 2

[Qemu-devel] [PULL 28/36] hw/intc/arm_gicv3: Implement ICV_ HPPIR, DIR and RPR registers

2017-01-19 Thread Peter Maydell
Implement the the ICV_ registers HPPIR, DIR and RPR. Signed-off-by: Peter Maydell Message-id: 1483977924-14522-11-git-send-email-peter.mayd...@linaro.org --- hw/intc/arm_gicv3_cpuif.c | 235 +- hw/intc/trace-events | 3 + 2 files changed, 235 in

[Qemu-devel] [PULL 25/36] hw/intc/gicv3: Add data fields for virtualization support

2017-01-19 Thread Peter Maydell
As the first step in adding support for the virtualization extensions to the GICv3 emulation: * add the necessary data fields to the state structures * add the fields to the migration state, as a subsection which is only present if virtualization is enabled The use of a subsection means we re

[Qemu-devel] [PULL 08/36] aspeed/smc: remove call to aspeed_smc_update_cs() in reset function

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater Instead, we can simply set the irq level when unselecting the slave devices. This change prepares ground for a subsequent cleanup of the aspeed_smc_update_cs() routine which uselessly loops on all slaves to update their status. Signed-off-by: Cédric Le Goater Message-id:

[Qemu-devel] [PULL 18/36] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-19 Thread Peter Maydell
From: Ard Biesheuvel Linux for arm64 v4.10 and later will complain if the ECAM config space is not reserved in the ACPI namespace: acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x3f00-0x3fff] not reserved in ACPI namespace The rationale is that OSes that don't consume the MCFG tabl

[Qemu-devel] [PULL 31/36] hw/intc/arm_gicv3: Implement EL2 traps for CPU i/f regs

2017-01-19 Thread Peter Maydell
Implement the architecturally required traps from NS EL1 to EL2 for the CPU interface registers. These fall into several different groups: * group-0-only registers all trap if ICH_HRC_EL2.TALL0 is set (exactly the registers covered by gicv3_fiq_access()) * group-1-only registers all trap if IC

[Qemu-devel] [PULL 32/36] hw/arm/virt: Support using SMC for PSCI

2017-01-19 Thread Peter Maydell
If we are giving the guest a CPU with EL2, it is likely to want to use the HVC instruction itself, for instance for providing PSCI to inner guest VMs. This makes using HVC as the PSCI conduit for the outer QEMU a bad idea. We will want to use SMC instead is this case: this makes sense because QEMU'

[Qemu-devel] [PULL 17/36] arm: virt: Fix segmentation fault when specifying an unsupported CPU

2017-01-19 Thread Peter Maydell
From: Shannon Zhao Using -cpu cortex-a9 (or any other unsupported CPU) with the virt board will cause QEMU to segmentation fault. This bug was introduced in commit 9ac4ef77, which incorrectly added a NULL terminator when converting the VirtBoardInfo array into a simple array of strings defining

[Qemu-devel] [PULL 26/36] hw/intc/arm_gicv3: Add accessors for ICH_ system registers

2017-01-19 Thread Peter Maydell
The GICv3 virtualization interface includes system registers accessible only to the hypervisor which form the control interface for interrupt virtualization. Implement these registers. The function gicv3_cpuif_virt_update() which determines whether it needs to signal vIRQ, vFIQ or a maintenance in

[Qemu-devel] [PULL 24/36] hw/intc/gicv3: Add defines for ICH system register fields

2017-01-19 Thread Peter Maydell
Add defines to gicv3_internal.h for fields in the ICH_* system registers which form the GIC virtualization control interface. Signed-off-by: Peter Maydell Message-id: 1483977924-14522-7-git-send-email-peter.mayd...@linaro.org --- hw/intc/gicv3_internal.h | 79

[Qemu-devel] [PULL 05/36] target/arm: Handle VIRQ and VFIQ in arm_cpu_do_interrupt_aarch32()

2017-01-19 Thread Peter Maydell
To run a VM in 32-bit EL1 our AArch32 interrupt handling code needs to be able to cope with VIRQ and VFIQ exceptions. These behave like IRQ and FIQ except that we don't need to try to route them to Monitor mode. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- target/arm/helper.c

[Qemu-devel] [PULL 03/36] block: m25p80: Introduce die erase command

2017-01-19 Thread Peter Maydell
From: Marcin Krzeminski Modern big flash NOR devices consist of more than one die. Some of them do not support chip erase and instead have a die erase command that can erase one die only. This commit adds support for defining the number of dies in the chip, and adds support for die erase command.

[Qemu-devel] [PULL 15/36] aspeed/smc: extend tests for Command mode

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater The Aspeed SMC controllers have a mode (Command mode) in which accesses to the flash content are no different than doing MMIOs. The controller generates all the necessary commands to load (or store) data in memory. So add a couple of tests doing direct reads and writes on

[Qemu-devel] [PULL 33/36] hw/arm/virt-acpi-build: use SMC if booting in EL2

2017-01-19 Thread Peter Maydell
From: Andrew Jones Signed-off-by: Andrew Jones Acked-by: Alistair Francis Signed-off-by: Peter Maydell Message-id: 1483977924-14522-16-git-send-email-peter.mayd...@linaro.org [PMM: look at vms->psci_conduit rather than vms->virt to decide whether to use HVC or SMC, and report no PSCI support

[Qemu-devel] [PULL 01/36] arm: Uniquely name imx25 I2C buses.

2017-01-19 Thread Peter Maydell
From: Alastair D'Silva The imx25 chip provides 3 i2c buses, but they have all been named "i2c", which makes it difficult to predict which bus a device will be connected to when specified on the command line. This patch addresses the issue by naming the buses uniquely: i2c-bus.0 i2c-bus.1 i2c-b

[Qemu-devel] [PULL 36/36] hw/arm/virt: Add board property to enable EL2

2017-01-19 Thread Peter Maydell
Add a board level property to the virt board which will enable EL2 on the CPU if the user asks for it. The default is not to provide EL2. If EL2 is enabled then we will use SMC as our PSCI conduit, and report the virtualization support in the GICv3 device tree node and the ACPI tables. Signed-off-

[Qemu-devel] [PULL 29/36] hw/intc/arm_gicv3: Implement ICV_ registers EOIR and IAR

2017-01-19 Thread Peter Maydell
Implement the two remaining ICV_ registers: EOIR and IAR. Signed-off-by: Peter Maydell Message-id: 1483977924-14522-12-git-send-email-peter.mayd...@linaro.org --- hw/intc/arm_gicv3_cpuif.c | 220 ++ hw/intc/trace-events | 2 + 2 files changed, 2

[Qemu-devel] [PULL 09/36] aspeed/smc: rework the prototype of the AspeedSMCFlash helper routines

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater Change the routines prototype to use a 'AspeedSMCFlash *' instead of 'AspeedSMCState *'. The result will help in making future changes clearer. Also change aspeed_smc_update_cs() which uselessly loops on all slave devices to update their status. Signed-off-by: Cédric Le G

[Qemu-devel] [PULL 30/36] hw/intc/arm_gicv3: Implement gicv3_cpuif_virt_update()

2017-01-19 Thread Peter Maydell
Implement the function which signals virtual interrupts to the CPU as appropriate following CPU interface state changes. Signed-off-by: Peter Maydell Message-id: 1483977924-14522-13-git-send-email-peter.mayd...@linaro.org --- include/hw/intc/arm_gicv3_common.h | 1 + hw/intc/arm_gicv3_cpuif.c

[Qemu-devel] [PULL 35/36] target-arm: Enable EL2 feature bit on A53 and A57

2017-01-19 Thread Peter Maydell
Enable the ARM_FEATURE_EL2 bit on Cortex-A52 and Cortex-A57, since this is all now sufficiently implemented to work with the GICv3. We provide the usual CPU property to disable it for backwards compatibility with the older virt boards. In this commit, we disable the EL2 feature on the virt and Zyn

[Qemu-devel] [PULL 14/36] aspeed/smc: reset flash after each test

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater Let's make sure when each test is run that the flash object is in an initial state and did not keep configuration from the previous tests. Signed-off-by: Cédric Le Goater Message-id: 1483979087-32663-9-git-send-email-...@kaod.org Signed-off-by: Peter Maydell --- tests/m

[Qemu-devel] [PULL 12/36] aspeed/smc: adjust the size of the register region

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater The SPI controller of the AST2400 SoC has less registers. So we can adjust the size of the memory region holding the registers depending on the controller type. We can also remove the guest_error logging which is useless as the range of the region is strict enough. Signed-

[Qemu-devel] [PULL 06/36] target/arm: Implement DBGVCR32_EL2 system register

2017-01-19 Thread Peter Maydell
The DBGVCR_EL2 system register is needed to run a 32-bit EL1 guest under a Linux EL2 64-bit hypervisor. Its only purpose is to provide AArch64 with access to the state of the DBGVCR AArch32 register. Since we only have a dummy DBGVCR, implement a corresponding dummy DBGVCR32_EL2. Signed-off-by: Pe

[Qemu-devel] [PATCH v3 1/2] linux-user: fix settime old value location

2017-01-19 Thread Pranith Kumar
From: Marc-André Lureau old_value is the 4th argument of timer_settime(), not the 2nd. Signed-off-by: Marc-André Lureau Signed-off-by: Pranith Kumar --- linux-user/syscall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c

[Qemu-devel] [PULL 13/36] aspeed/smc: handle SPI flash Command mode

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater The Aspeed SMC controllers have a mode (Command mode) in which accesses to the flash content are no different than doing MMIOs. The controller generates all the necessary commands to load (or store) data in memory. However, accesses are restricted to the segment window ass

[Qemu-devel] [PULL 02/36] block: m25p80: Add Quad Page Program 4byte

2017-01-19 Thread Peter Maydell
From: Marcin Krzeminski Some flash chips have additional page program opcode that takes only 4 byte address. This commit adds support for such command in Qemu. Signed-off-by: Marcin Krzeminski Reviewed-by: Edgar E. Iglesias Message-id: 20170108083854.5006-2-mar.krzemin...@gmail.com Signed-off-

[Qemu-devel] [PATCH v3 2/2] linux-user: fix tcg/mmap test

2017-01-19 Thread Pranith Kumar
From: Marc-André Lureau tests/tcg/mmap test fails with values other than default target page size. When creating a map beyond EOF, extra anonymous pages are added up to the target page boundary. Currently, this operation is performed only when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it s

[Qemu-devel] [PULL 07/36] aspeed/smc: remove call to reset in realize function

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater This is useless as reset will be called later on. Signed-off-by: Cédric Le Goater Acked-by: Marcin Krzemiński Message-id: 1483979087-32663-2-git-send-email-...@kaod.org Signed-off-by: Peter Maydell --- hw/ssi/aspeed_smc.c | 2 -- 1 file changed, 2 deletions(-) diff --

[Qemu-devel] [PULL 10/36] aspeed/smc: autostrap CE0/1 configuration

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater On the AST2500 SoC, the FMC controller flash type is fixed to SPI for CE0 and CE1 and 4BYTE mode is autodetected for CE0. On the AST2400 SoC, the FMC controller flash type and 4BYTE mode are strapped with register SCU70. We use the default settings from the palmetto-bmc ma

[Qemu-devel] [PULL 11/36] aspeed/smc: unfold the AspeedSMCController array

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater This is getting difficult to read. Also add a 'has_dma' field for each controller type. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Andrew Jeffery Message-id: 1483979087-32663-6-git-send-email-...@kaod.org Signed-off-by: Peter Maydell --- in

[Qemu-devel] [Bug 641118] Re: NetBSD guest only supports network without ACPI

2017-01-19 Thread Thomas Huth
OK, thanks for checking! ... so let's close this bug. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/641118 Title: NetBSD guest only suppo

[Qemu-devel] [PULL 16/36] aspeed: use first FMC flash as a boot ROM

2017-01-19 Thread Peter Maydell
From: Cédric Le Goater Create a ROM region, using the default size of the mapping window for the CE0 FMC flash module, and fill it with the flash content. This is a little hacky but until we can boot from a MMIO region, it seems difficult to do anything else. Signed-off-by: Cédric Le Goater Re

[Qemu-devel] [PATCH v10 01/16] osdep: Add qemu_lock_fd and qemu_unlock_fd

2017-01-19 Thread Fam Zheng
They are wrappers of POSIX fcntl "file private locking", with a convenient "try lock" wrapper implemented with F_OFD_GETLK. Signed-off-by: Fam Zheng --- include/qemu/osdep.h | 3 +++ util/osdep.c | 48 2 files changed, 51 insertions(+) d

  1   2   3   4   >