Re: [Qemu-devel] [PATCH RFC v2 00/12] basic channel IO passthrough infrastructure based on vfio

2017-01-12 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170112072513.98411-1-bjsdj...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH RFC v2 00/12] basic channel IO passthrough infrastructure based on vfio === TEST SCRIPT BEGIN

Re: [Qemu-devel] [RFC]virtio-blk: add disk-name device property

2017-01-12 Thread Fam Zheng
On Thu, 01/12 15:39, Yang Zhang wrote: > On 2017/1/12 10:22, Fam Zheng wrote: > > On Thu, 01/12 09:22, Yang Zhang wrote: > > > On 2017/1/4 22:44, Stefan Hajnoczi wrote: > > > > On Tue, Jan 03, 2017 at 10:53:06AM -0600, Eric Blake wrote: > > > > > On 12/29/2016 08:41 PM, Junkang Fu wrote: > > > > >

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2017-01-12 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > >> > > >> > Yes, this option helps. > >> > Thank you. > >> > >> Good news. This can be fixed in 2.8.1 once someone finds a solution. > > > > It seems that something still goes wrong. > > I'

Re: [Qemu-devel] [PATCH] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Markus Armbruster
Thomas Huth writes: > When running certain HMP commands ("info registers", "info cpustats" > or dumping virtual memory) with the "none" machine, QEMU crashes > with a segmentation fault. This happens because the "none" machine does > not have any CPUs by default, "Sachen gibt's!" >

Re: [Qemu-devel] [PATCH] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
On 12.01.2017 09:10, Markus Armbruster wrote: > Thomas Huth writes: > >> When running certain HMP commands ("info registers", "info cpustats" >> or dumping virtual memory) with the "none" machine, QEMU crashes >> with a segmentation fault. This happens because the "none" machine does >> not have

[Qemu-devel] [PATCH] ppc/prep: update MAINTAINERS file

2017-01-12 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- MAINTAINERS | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1444b26..f4b02ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -657,10 +657,13 @@ F: hw/misc/macio/ F: hw/intc/heathrow_pic.c PReP +M: Hervé

Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 02:02, Lluís Vilanova wrote: > Paolo Bonzini writes: > [...] >> A weird idea: what about doing > >> -DGENERATED_TRACERS_H=\"hw/scsi/generated-tracers.h\" > >> and then having > >> #ifdef GENERATED_TRACE_H >> #include GENERATED_TRACE_H >> #endif > >> in include

Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 06:50, Peter Xu wrote: > On Wed, Jan 11, 2017 at 06:21:46PM +0100, Paolo Bonzini wrote: >> >> >> On 21/12/2016 08:58, Peter Xu wrote: >>> - mr->romd_mode ? 'R' : '-', >>> - !mr->readonly && !(mr->rom_device && mr->romd_mode) ? >>> 'W' >>> -

[Qemu-devel] [Bug 1268671] Re: CentOS guest crashing due to assertion failure in qemu-char.c

2017-01-12 Thread Paolo Bonzini
It's a glib bug. It's fixed in RHEL 6.9 beta and in due time the fix will get to CentOS. ** Changed in: qemu Status: Incomplete => Invalid ** Bug watch added: Red Hat Bugzilla #1212722 https://bugzilla.redhat.com/show_bug.cgi?id=1212722 -- You received this bug notification because y

[Qemu-devel] [Bug 1268671] Re: CentOS guest crashing due to assertion failure in qemu-char.c

2017-01-12 Thread Paolo Bonzini
https://bugzilla.redhat.com/show_bug.cgi?id=1212722 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1268671 Title: CentOS guest crashing due to assertion failure in qemu-char.c Status in QEMU: Inv

[Qemu-devel] [Bug 622367] Re: No BIOS MPFP structure with smp=92 and more

2017-01-12 Thread Vic3Dexe
Man, really? xD 6 years have passed... Close the ticket please, I don't have this code anymore. ... still laughing... sorry -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/622367 Title: No BIOS MPFP

Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()

2017-01-12 Thread Peter Xu
On Thu, Jan 12, 2017 at 09:54:24AM +0100, Paolo Bonzini wrote: > > > On 12/01/2017 06:50, Peter Xu wrote: > > On Wed, Jan 11, 2017 at 06:21:46PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 21/12/2016 08:58, Peter Xu wrote: > >>> - mr->romd_mode ? 'R' : '-', > >>> -

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file

2017-01-12 Thread Andrew Jones
On Thu, Jan 12, 2017 at 11:36:21AM +0800, Peter Xu wrote: > We were using test.log before to keep all the test logs. This patch > creates one log file per test case under logs/ directory with name > "TESTNAME.log". Meanwhile, we will keep the last time log into > logs.old/. > > Renaming scripts/fu

Re: [Qemu-devel] [PATCH v5 wave 1 0/4] fw-cfg: support writeable blobs and more files

2017-01-12 Thread Laszlo Ersek
On 01/12/17 03:25, Gabriel L. Somlo wrote: > On Wed, Jan 11, 2017 at 06:34:53PM +0100, Laszlo Ersek wrote: >> This is the first (fw_cfg) half of the v5 iteration of the series posted >> here: >> . >> >> In this version, the fw_c

Re: [Qemu-devel] [PATCH v7 20/21] build-sys: add txt documentation rules

2017-01-12 Thread Markus Armbruster
Marc-André Lureau writes: > Build plain text documentation, and install it. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster > --- > .gitignore | 1 + > Makefile | 12 +--- > 2 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/.gitignore b/.gitign

Re: [Qemu-devel] [PATCH] hw/block/m25p80: Fix typo in local macro name

2017-01-12 Thread Michael Tokarev
01.11.2016 20:03, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > hw/block/m25p80.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to -trivial, quite a bit too late but better be late than never :) Thanks! /mjt

[Qemu-devel] [PATCH v2] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes with a segmentation fault. This happens because the "none" machine does not have any CPUs by default, but these HMP commands did not check for a va

[Qemu-devel] How to online resize qemu disk with nbd protocol?

2017-01-12 Thread Bob Chen
Hi, My qemu runs on a 3rd party distributed block storage, and the disk backend protocol is nbd. I notices that there are differences between default qcow2 local disk and my nbd disk, in terms of resizing the disk on the fly. Local qcow2 disk could work no matter using qemu-img resize or qemu m

Re: [Qemu-devel] [Qemu-trivial] [PATCH] README: Add linux to macOS build info

2017-01-12 Thread Michael Tokarev
31.10.2016 20:01, Peter Maydell wrote: > The README lists the URLs for the wiki pages describing > how to build on Linux and Windows; add the equivalent > link for building on macOS. Applied to -trivial :) Thanks, /mjt

Re: [Qemu-devel] [PATCH for-2.8] Fix documentation and some comments (article, grammar)

2017-01-12 Thread Michael Tokarev
19.11.2016 22:22, Stefan Weil wrote: [] Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for-2.8] include: Fix typos found by codespell

2017-01-12 Thread Michael Tokarev
19.11.2016 22:47, Stefan Weil wrote: > Add also a missing parenthesis in a comment. .. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for-2.8] hw: Fix typos found by codespell

2017-01-12 Thread Michael Tokarev
19.11.2016 22:29, Stefan Weil wrote: ... Applied to -trivial, except of the hw/block/m25p80.c hunk which were applied earlier. Thank you! /mjt

Re: [Qemu-devel] Proposal PCI/PCIe device placement on PAPR guests

2017-01-12 Thread Andrea Bolognani
On Mon, 2017-01-09 at 10:46 +1100, David Gibson wrote: > > >* To allow for hotplugged devices, libvirt should also add a number > > >  of additional, empty vPHBs (the PAPR spec allows for hotplug of > > >  PHBs, but this is not yet implemented in qemu). > >  > > "A number" here will hav

[Qemu-devel] [Bug 622367] Re: No BIOS MPFP structure with smp=92 and more

2017-01-12 Thread Thomas Huth
Better late than never ;-) ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/622367 Title: No BIOS MPFP structure with smp=92 and more Statu

[Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
The CFI entry for sector length must be set to sector length per device. This is important for boards using multiple devices like the ARM Vexpress board (width = 4, device-width = 2). Linux and u-boots calculate the size ratio by dividing both values: size_ratio = info->portwidth / info->chipw

Re: [Qemu-devel] [PATCH] qemu-options: cleanup duplicated help message for kernel_irqchip

2017-01-12 Thread Michael Tokarev
29.11.2016 06:34, Po-Hsu Lin wrote: > Remove the duplicated help message for 'kernel_irqchip'. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file

2017-01-12 Thread Peter Xu
On Thu, Jan 12, 2017 at 11:04:05AM +0100, Andrew Jones wrote: [...] > > config=$TEST_DIR/unittests.cfg > > -rm -f test.log > > -printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log > > + > > +rm -rf $unittest_log_dir.old > > +[ -d $unittest_log_dir ] && mv $unittest_log_dir $unittest_log_dir.old

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread Peter Maydell
On 12 January 2017 at 10:35, David Engraf wrote: > The CFI entry for sector length must be set to sector length per device. > This is important for boards using multiple devices like the ARM Vexpress > board (width = 4, device-width = 2). > > Linux and u-boots calculate the size ratio by dividing

Re: [Qemu-devel] [PATCH] linux-user: Use *at functions instead of caching interp_prefix contents

2017-01-12 Thread Peter Maydell
On 12 January 2017 at 04:05, Richard Henderson wrote: > If the interp_prefix is a complete chroot, it may have a *lot* of files. > Setting up the cache for this is quite expensive. Instead, use the *at > versions of various syscalls to attempt the operation in the prefix. > Presumably this also

Re: [Qemu-devel] [PATCH v4 4/4] migration: Fail migration blocker for --only-migratble

2017-01-12 Thread Ashijeet Acharya
On Tuesday, 10 January 2017, Peter Maydell wrote: > On 9 January 2017 at 17:02, Ashijeet Acharya > wrote: > > migrate_add_blocker should rightly fail if the '--only-migratable' > > option was specified and the device in use should not be able to > > perform the action which results in an unmigra

Re: [Qemu-devel] [PATCH v2] usb: Fix typo in documentation

2017-01-12 Thread Michael Tokarev
07.12.2016 19:00, Frediano Ziglio wrote: > simliar -> similar Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 2/2] pcie: fix typo in comments

2017-01-12 Thread Michael Tokarev
11.11.2016 06:02, Cao jin wrote: Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 1/3] object.h: spelling fix

2017-01-12 Thread Michael Tokarev
12.12.2016 20:31, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/qom/object.h | 2 +- Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 2/3] object.h: improve OBJECT/OBJECT_CLASS doc

2017-01-12 Thread Michael Tokarev
12.12.2016 20:31, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/qom/object.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/qom/object.h b/include/qom/object.h > index c5e6fc1f5d..c5456db05d 100644 > --- a/include/qom/object.h

[Qemu-devel] [PATCH] ide: avoid unbounded recursion

2017-01-12 Thread Paolo Bonzini
The end_transfer_func can call ide_transfer_start immediately, before returning, and unbounded recursion can happen at least for ide_atapi_cmd_reply_end. Use a bottom half to defer the call and limit stack usage. Cc: Peter Lieven Cc: John Snow Signed-off-by: Paolo Bonzini --- hw/ide/core.c |

Re: [Qemu-devel] [PATCH] block: remove dead check

2017-01-12 Thread Michael Tokarev
04.01.2017 17:59, Paolo Bonzini wrote: > options must be non-NULL here, because a NULL value is replaced with > qdict_new earlier in the function. Reported by Coverity. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror

2017-01-12 Thread Michael Tokarev
04.01.2017 17:52, Paolo Bonzini wrote: > process_command returns a negative value in case of error. Make this > clear in the "if" statement and fix the strerror argument to flip it > to positive. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 3/3] object: make some funcs static

2017-01-12 Thread Michael Tokarev
12.12.2016 20:31, Marc-André Lureau wrote: > There is no need to have those functions as public API. Were "some" being object_initialize_with_type() and object_new_with_type(). I'm applying this to -trivial, and Cc'ing Andreas, maybe he will say more. Thanks, > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] doc/usb2: fix typo

2017-01-12 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] qemu-img: remove dead check

2017-01-12 Thread Michael Tokarev
04.01.2017 17:56, Paolo Bonzini wrote: > options must be non-NULL here, because it has been checked before. > Reported by Coverity. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow

2017-01-12 Thread Michael Tokarev
06.01.2017 20:45, Peter Maydell wrote: > Don't truncate the multiplication and do a 64 bit one instead > because the result is stored in a 64 bit variable. > > This fixes a similar coverity warning to commit 237a8650d640, > in a similar way, and is the other half of the fix for > coverity CID 1167

Re: [Qemu-devel] [PATCH] hw/i386/kvmvapic: Remove dead code in patch_hypercalls()

2017-01-12 Thread Michael Tokarev
09.01.2017 20:05, Peter Maydell wrote: > The patch_hypercalls() function sets up a 'patches' > variable and checks it at the end of the function, but > never modifies it in the middle. Remove this dead code, > which seems to have been present since the function was > added in commit e5ad936b0fd7 in

Re: [Qemu-devel] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL

2017-01-12 Thread Michael Tokarev
09.01.2017 22:05, Peter Maydell wrote: > Coverity (CID 1005689) warns that we don't check that > spec_reg_info() returned non-NULL before dereferencing. > Add the check, though as the comment notes this is > a can't-really-happen case because the earlier constraint > matching should have ruled out

Re: [Qemu-devel] [PATCH] pci-assign: avoid pointless stat

2017-01-12 Thread Michael Tokarev
04.01.2017 18:05, Paolo Bonzini wrote: > Just check the errno value after fopen and follow it with fstat. > This shuts up Coverity's complaint about TOC/TOU violation. Applied to -trivial, thanks! /mjt

[Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2017-01-12 Thread Thomas Huth
This should have been fixed by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=5d6768e3b8908a60f0 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [Qemu-devel] [PATCH] docs: sync pci-ids.txt

2017-01-12 Thread Michael Tokarev
11.01.2017 14:02, Gerd Hoffmann wrote: > Three commits allocated pci ids in include/hw/pci/pci.h > without also updating docs/specs/pci-ids.txt: > > bf439db pci: Allocate PCIe host bridge PCI ID > 40d14be hw/pci: introduce PCI Expander Bridge (PXB) > 02b0743 hw/pxb: introduce pxb-pcie expand

Re: [Qemu-devel] [PATCH 1/2] vfio: remove a duplicated word in comments

2017-01-12 Thread Michael Tokarev
11.11.2016 06:01, Cao jin wrote: [] Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH v4 0/2] trivial changes on util/mmap-alloc

2017-01-12 Thread Michael Tokarev
02.11.2016 16:44, Cao jin wrote: > Cao jin (2): > util/mmap-alloc: check parameter before using > util/mmap-alloc: refactor a little bit for readability > > util/mmap-alloc.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) Applied (finally) to -trivial, thank you ve

Re: [Qemu-devel] [PATCH v4 4/4] migration: Fail migration blocker for --only-migratble

2017-01-12 Thread Greg Kurz
On Thu, 12 Jan 2017 16:15:28 +0530 Ashijeet Acharya wrote: > On Tuesday, 10 January 2017, Peter Maydell wrote: > > > On 9 January 2017 at 17:02, Ashijeet Acharya > > wrote: > > > migrate_add_blocker should rightly fail if the '--only-migratable' > > > option was specified and the device in use

Re: [Qemu-devel] [PATCH 2/3] object.h: improve OBJECT/OBJECT_CLASS doc

2017-01-12 Thread Peter Maydell
On 12 January 2017 at 10:46, Michael Tokarev wrote: > 12.12.2016 20:31, Marc-André Lureau wrote: >> Signed-off-by: Marc-André Lureau >> --- >> include/qom/object.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/include/qom/object.h b/include/qom/object.h >> ind

Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 10:46, Peter Xu wrote: > Yes, above suggestion makes sense to me, since after all the RW > permissions are derived from the type of memory regions, and the type > itself tells more things than the RW bits. So I totally agree we can > replace the "RW" chars with its type directly (if

Re: [Qemu-devel] [PATCH v6 6/7] trace: [tcg, trivial] Re-align generated code

2017-01-12 Thread Michael Tokarev
28.12.2016 21:41, Lluís Vilanova wrote: > Last patch removed a nesting level in generated code. Re-align all code > generated by backends to be 4-column aligned. Lluís, I'm not applying these (6/7 and 7/7) to -trivial because while they're trivial indeed, they aren't independent and should be appl

Re: [Qemu-devel] [PATCH] win32: use glib gpoll if glib >= 2.50

2017-01-12 Thread Michael Tokarev
03.01.2017 22:19, Marc-André Lureau wrote: > A fix has been committed in upstream glib commit > 210a9796f78eb90f76f1bd6a304e9fea05e97617. > (See also related bug https://bugzilla.gnome.org/show_bug.cgi?id=764415) > > It is desirable to use the glib version instead of qemu copy, since it > provides

Re: [Qemu-devel] [PATCH] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB

2017-01-12 Thread Michael Tokarev
09.01.2017 19:45, Peter Maydell wrote: > Coverity points out that calculating src_len by multiplying > src_width by rows could overflow. This can only happen in > the implausible case of a framebuffer larger than 4GB, but > we may as well fix it, placating Coverity. (CID1005515) Applied to -trivia

Re: [Qemu-devel] implementing architectural timers using QEMU timers

2017-01-12 Thread Pavel Dovgalyuk
> From: Max Filippov [mailto:jcmvb...@gmail.com] > On Tue, Jan 10, 2017 at 12:31 AM, Pavel Dovgalyuk wrote: > >> From: Max Filippov [mailto:jcmvb...@gmail.com] > > > >> I'm trying to reimplement xtensa CCOUNT (cycle counter) and > >> CCOMPARE (CCOUNT-based timer interrupts) using QEMU > >> timers.

Re: [Qemu-devel] [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-12 Thread Gonglei (Arei)
Ping... Any Comments? Thanks, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, January 04, 2017 6:03 PM > To: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: Luonengjun; m...@redhat.com; cornelia.h...@de.ibm.com; > stefa...@redhat.com; denglin...@china

Re: [Qemu-devel] [PATCH] linux-user: fix build with musl on aarch64

2017-01-12 Thread Michael Tokarev
15.12.2016 14:04, Natanael Copa wrote: > Use the standard uint64_t instead of internal __u64. > > This fixes compiler error with musl libc on aarch64: > .../qemu-2.7.0/linux-user/host/aarch64/hostdep.h:28:5: > error: unknown type name '__u64' > __u64 *pcreg = &uc->uc_mcontext.pc; > ^

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread Andrew Jones
On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > On 12 January 2017 at 10:35, David Engraf wrote: > > The CFI entry for sector length must be set to sector length per device. > > This is important for boards using multiple devices like the ARM Vexpress > > board (width = 4, device-

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 3/3] run_tests: allow run tests in parallel

2017-01-12 Thread Andrew Jones
On Thu, Jan 12, 2017 at 11:36:22AM +0800, Peter Xu wrote: > run_task.sh is getting slow. This patch is trying to make it faster by > running the tests concurrently. > > We provide a new parameter "-j" for the run_tests.sh, which can be used > to specify how many run queues we want for the tests. D

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 1/3] run_tests: fix errno for param parsing

2017-01-12 Thread Andrew Jones
On Thu, Jan 12, 2017 at 11:36:20AM +0800, Peter Xu wrote: > Signed-off-by: Peter Xu > --- > run_tests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/run_tests.sh b/run_tests.sh > index 254129d..2cfa365 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -41,7 +41,7

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-12 Thread Vladimir Sementsov-Ogievskiy
(Sorry, it may be a bit out of topic, but I hope it is comfortable for all that I just comment current version of the feature by answering cover letter of last related patch set) From |"NBD_OPT_LIST_META_CONTEXT| (9)": The server MUST either reply with an error (for instance |EINVAL| if the op

Re: [Qemu-devel] [PATCH v4 4/4] migration: Fail migration blocker for --only-migratble

2017-01-12 Thread Ashijeet Acharya
On Thursday, 12 January 2017, Greg Kurz wrote: > On Thu, 12 Jan 2017 16:15:28 +0530 > Ashijeet Acharya > wrote: > > > On Tuesday, 10 January 2017, Peter Maydell > wrote: > > > > > On 9 January 2017 at 17:02, Ashijeet Acharya < > ashijeetacha...@gmail.com > > > > wrote: > > > > migrate_add_block

Re: [Qemu-devel] [PATCH] libqtest: handle zero length memwrite/memread

2017-01-12 Thread Peter Maydell
On 11 January 2017 at 08:49, Greg Kurz wrote: > Some recently added tests pass a zero length to qtest_memwrite(). > Unfortunately, the qtest protocol doesn't implement an on-the-wire > syntax for zero-length writes and the current code happily sends > garbage to QEMU. This causes intermittent fail

Re: [Qemu-devel] about post copy recovery

2017-01-12 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > Hi David, > > I remembered some guys wanted to solve the issue of post copy recovery when > network broken down, do you know latest status? Hi Liang, Yes, Haris looked at it as part of GSoC, the latest version is what was posted: https://lists.

Re: [Qemu-devel] [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-12 Thread Halil Pasic
On 01/04/2017 11:10 AM, Gonglei (Arei) wrote: > Hi all, > > I attach the diff files between v14 and v15 for better review. > Hi, only had a quick look. Will try to come back to this later. > diff --git a/virtio-crypto.tex b/virtio-crypto.tex > index 9f7faf0..884ee95 100644 > --- a/virtio-cryp

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
Am 12.01.2017 um 12:36 schrieb Andrew Jones: On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: On 12 January 2017 at 10:35, David Engraf wrote: The CFI entry for sector length must be set to sector length per device. This is important for boards using multiple devices like the ARM

Re: [Qemu-devel] implementing architectural timers using QEMU timers

2017-01-12 Thread Peter Maydell
On 12 January 2017 at 11:28, Pavel Dovgalyuk wrote: >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> Ok, looks like what happens in my case is that instruction that >> sets CCOMPARE and thus changes remaining icount does not >> cause exit from the cpu_exec. So merely ending TB on >> QEMU_CLOCK

Re: [Qemu-devel] [kvm-unit-tests PATCH 0/8] VT-d ioapic irq test

2017-01-12 Thread Paolo Bonzini
On 30/12/2016 09:55, Peter Xu wrote: > The previous vt-d unittest series only contains the very basic tests. > Let's enlarge it step by step. > > This series expanded it with IOAPIC irq test. > > Peter Xu (8): > pci: introduce pci_intx_line() > pci: introduce pci_msi_set_enable() > lib/as

Re: [Qemu-devel] implementing architectural timers using QEMU timers

2017-01-12 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 12 January 2017 at 11:28, Pavel Dovgalyuk wrote: > >> From: Max Filippov [mailto:jcmvb...@gmail.com] > >> Ok, looks like what happens in my case is that instruction that > >> sets CCOMPARE and thus changes remaining icount does not > >>

Re: [Qemu-devel] [PATCH v2] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > When running certain HMP commands ("info registers", "info cpustats", > "nmi", "memsave" or dumping virtual memory) with the "none" machine, > QEMU crashes with a segmentation fault. This happens because the "none" > machine does not have any CPUs by defaul

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-12 Thread Gonglei (Arei)
Hi, > > On 01/04/2017 11:10 AM, Gonglei (Arei) wrote: > > Hi all, > > > > I attach the diff files between v14 and v15 for better review. > > > Hi, > > only had a quick look. Will try to come back to this later. > That's cool. > > diff --git a/virtio-crypto.tex b/virtio-crypto.tex > > index 9f

Re: [Qemu-devel] [PATCH v2] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
On 12.01.2017 13:19, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> When running certain HMP commands ("info registers", "info cpustats", >> "nmi", "memsave" or dumping virtual memory) with the "none" machine, >> QEMU crashes with a segmentation fault. This happens becau

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Eduardo Habkost
On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > A recent glibc commit[1] added a blacklist to ensure it won't use > > TSX on hosts that are known to have a broken TSX implementation. > > > > Our existing Haswell CPU model

Re: [Qemu-devel] [PATCH 4/5] pc: Add 2.9 machine-types

2017-01-12 Thread Eduardo Habkost
On Tue, Jan 10, 2017 at 06:06:33AM +0200, Michael S. Tsirkin wrote: > On Sun, Jan 08, 2017 at 05:40:40PM -0200, Eduardo Habkost wrote: > > Cc: "Michael S. Tsirkin" > > Cc: Laszlo Ersek > > Cc: Igor Mammedov > > Signed-off-by: Eduardo Habkost > > Do I understand it correctly that you are mergin

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > A recent glibc commit[1] added a blacklist to ensure it won't use > > > TSX on hosts that are known to have a broken TSX

[Qemu-devel] [PATCH v3] monitor: Fix crashes when using HMP commands without CPU

2017-01-12 Thread Thomas Huth
When running certain HMP commands ("info registers", "info cpustats", "nmi", "memsave" or dumping virtual memory) with the "none" machine, QEMU crashes with a segmentation fault. This happens because the "none" machine does not have any CPUs by default, but these HMP commands did not check for a va

Re: [Qemu-devel] [PATCH v5 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 11, 2017 at 06:35:28PM +0100, Laszlo Ersek wrote: > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Gerd Hoffmann > Cc: Igor Mammedov > Cc: Paolo Bonzini > Signed-off-by: Laszlo Ersek > --- > > Notes: > v5: > - replace the v4 patch "hw/i386/pc_q35: advertise broadcas

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 2/3] run_tests: put logs into per-test file

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 04:36, Peter Xu wrote: > We were using test.log before to keep all the test logs. This patch > creates one log file per test case under logs/ directory with name > "TESTNAME.log". Meanwhile, we will keep the last time log into > logs.old/. > > Renaming scripts/functions.bash into s

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-12 Thread Hervé Poussineau
Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : Hi Hervé, nice work! On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau wrote: Hi, This patchset adds the emulation of the IBM RS/6000 7020 (40p). The real machine is able to run AIX (up to 4.3.3), Windows NT (up to 4.0 SP1), the beta of OS/

Re: [Qemu-devel] [PATCH 0/5] Use non-blacklisted family/model/stepping for Haswell CPU model

2017-01-12 Thread Eduardo Habkost
On Thu, Jan 12, 2017 at 12:38:00PM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Mon, Jan 09, 2017 at 11:35:54AM +, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > A recent glibc commit[1] added a blacklis

Re: [Qemu-devel] [PATCH v2 1/2] memory: provide common macros for mtree_print_mr()

2017-01-12 Thread Peter Xu
On Thu, Jan 12, 2017 at 12:19:21PM +0100, Paolo Bonzini wrote: > > > On 12/01/2017 10:46, Peter Xu wrote: > > Yes, above suggestion makes sense to me, since after all the RW > > permissions are derived from the type of memory regions, and the type > > itself tells more things than the RW bits. So

Re: [Qemu-devel] [PATCH v5 wave 1 2/4] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 11, 2017 at 06:34:55PM +0100, Laszlo Ersek wrote: [...] > static Property fw_cfg_io_properties[] = { > DEFINE_PROP_UINT32("iobase", FWCfgIoState, iobase, -1), > DEFINE_PROP_UINT32("dma_iobase", FWCfgIoState, dma_iobase, -1), > DEFINE_PROP_BOOL("dma_enabled", FWCfgIoState

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-12 Thread Alex Bligh
> On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy > wrote: > > Yes this is better. But is it actually needed to force contexts have some > safe default? If context wants it may define such default without this > requirement.. So, should it be requirement at all? I've changed this to:

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-12 Thread Alex Bligh
> On 12 Jan 2017, at 11:43, Vladimir Sementsov-Ogievskiy > wrote: > > From "NBD_OPT_LIST_META_CONTEXT (9)": >> The server MUST either reply with an error (for instance EINVAL if the >> option is not supported), or reply with a list of NBD_REP_META_CONTEXT >> replies followed by NBD_REP_ACK.:

[Qemu-devel] [PULL 1/2] travis: trim out most clang builds

2017-01-12 Thread Alex Bennée
From: "Daniel P. Berrange" We test with both gcc and clang in order to detect cases where clang issues warnings that gcc misses. To achieve this though we don't need to build QEMU in multiple different configurations. Just a single clang-on-linux build will be sufficient, if we have an "all enabl

[Qemu-devel] [PULL 0/2] Travis updates

2017-01-12 Thread Alex Bennée
The following changes since commit b44486dfb9447c88e4b216e730adcc780190852c: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20170110-1' into staging (2017-01-10 14:52:34 +) are available in the git repository at: https://github.com/stsquad/qemu.git tags/pull-travi

[Qemu-devel] [PULL 2/2] travis: add Trusty with clang stable build

2017-01-12 Thread Alex Bennée
Although we've reduced the matrix to avoid repeating clang builds we can still add an additional clang build to use the latest stable version of clang which will typically be available on current distros. Signed-off-by: Alex Bennée --- .travis.yml | 20 1 file changed, 20 in

Re: [Qemu-devel] [PATCH v7 15/21] qapi: add qapi2texi script

2017-01-12 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > As the name suggests, the qapi2texi script converts JSON QAPI >> > description into a texi file suitable for different target >> > formats (info/man/txt/pdf/html...). >> > >> > It parses the fol

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer

2017-01-12 Thread Stefan Hajnoczi
On Wed, Jan 11, 2017 at 09:44:43AM +, Stefan Hajnoczi wrote: > Unlike g_free(), g_array_free() does not accept a NULL pointer argument. > The following error is logged when an nvdimm device is realized: > > GLib-CRITICAL **: g_array_free: assertion 'array' failed > > Cc: Xiao Guangrong > S

[Qemu-devel] [PATCH 2/2] virtio: disable notifications again after poll succeeded

2017-01-12 Thread Stefan Hajnoczi
While AioContext is in polling mode virtqueue notifications are not necessary. Some device virtqueue handlers enable notifications. Make sure they stay disabled to avoid unnecessary vmexits. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 3 +++ 1 file changed, 3 insertions(+) diff --

[Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-12 Thread Stefan Hajnoczi
The virtio_queue_set_notification() nesting introduced for AioContext polling raised an assertion with virtio-net (even in non-polling mode). Converting virtio-net and virtio-crypto to use virtio_queue_set_notification() in a nesting fashion would be invasive and isn't worth it. Patch 1 contains

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix g_array_free() with NULL pointer

2017-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 11:18:25AM +0800, Xiao Guangrong wrote: > > > On 01/11/2017 05:36 PM, Stefan Hajnoczi wrote: > > Unlike g_free(), g_array_free() does not accept a NULL pointer argument. > > The following error is logged when an nvdimm device is realized: > > > > GLib-CRITICAL **: g_arr

[Qemu-devel] [PATCH 1/2] Revert "virtio: turn vq->notification into a nested counter"

2017-01-12 Thread Stefan Hajnoczi
This reverts commit aff8fd18f1786fc5af259a9bc0077727222f51ca. Both virtio-net and virtio-crypto do not balance virtio_queue_set_notification() enable and disable calls. This makes the notifications_disabled counter unreliable and Doug Goldstein reported the following assertion failure: #3 0x0

Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"

2017-01-12 Thread Eduardo Habkost
On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote: > This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4. > > The error "Failed to execute helper program (No such file or directory)" > is due to broken glib installation, missing windows gspawn helpers. > > Signed-off-by:

Re: [Qemu-devel] [kvm-unit-tests PATCH v6 3/3] run_tests: allow run tests in parallel

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 12:42, Andrew Jones wrote: > On Thu, Jan 12, 2017 at 11:36:22AM +0800, Peter Xu wrote: >> run_task.sh is getting slow. This patch is trying to make it faster by >> running the tests concurrently. >> >> We provide a new parameter "-j" for the run_tests.sh, which can be used >> to spe

Re: [Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

2017-01-12 Thread Fam Zheng
On Wed, 01/04 14:26, Paolo Bonzini wrote: > diff --git a/include/qemu/futex.h b/include/qemu/futex.h > new file mode 100644 > index 000..852d612 > --- /dev/null > +++ b/include/qemu/futex.h > @@ -0,0 +1,36 @@ > +/* > + * Wrappers around Linux futex syscall > + * > + * Copyright Red Hat, Inc. 20

Re: [Qemu-devel] [PATCH v2 0/3] fix query-memdev not repporting IDs of memory backends

2017-01-12 Thread Eduardo Habkost
On Tue, Jan 10, 2017 at 01:53:12PM +0100, Igor Mammedov wrote: > > Changelog: > since v1: > * fix mistakes in commit messages/change them as suggested > * extend 3/3 commit message to explain why it's ok to use 'id' > * 3/3 set 'id' property directly instead of injectin

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-12 Thread Artyom Tarasenko
On Thu, Jan 12, 2017 at 1:57 PM, Hervé Poussineau wrote: > Le 11/01/2017 à 17:58, Artyom Tarasenko a écrit : >> >> Hi Hervé, >> >> nice work! >> >> On Thu, Dec 29, 2016 at 11:12 PM, Hervé Poussineau >> wrote: >>> >>> Hi, >>> >>> This patchset adds the emulation of the IBM RS/6000 7020 (40p). The

Re: [Qemu-devel] [PATCH] Revert "win32: don't run subprocess tests on Mingw32 platform"

2017-01-12 Thread Vincent Palatin
On Thu, Jan 12, 2017 at 2:25 PM, Eduardo Habkost wrote: > On Wed, Jan 04, 2017 at 09:57:22PM +0100, Marc-André Lureau wrote: >> This reverts commit 7ad9339e372fcd12d584684d7f52ac259604a4f4. >> >> The error "Failed to execute helper program (No such file or directory)" >> is due to broken glib inst

[Qemu-devel] [PATCH v3 0/2] memory: extend "info mtree" with flat view dump

2017-01-12 Thread Peter Xu
v3: - rather than dump flatview directly in "info mtree", provide a new parameter "-f" for it. [Paolo] - replace "RW" chars with the type of memory region [Paolo] - (cc dave as well since it touches HMP interface) v2: - fix a size error in patch 2 - add r-b for Marc-André in patch 1 Each addres

  1   2   3   4   >