[Qemu-devel] [PATCH v2 19/47] trace: switch hw/timer/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/timer/ directory to include the hw/timer/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- hw/timer/Makefile.objs | 2 ++ hw/timer/aspeed_timer.c | 2 +- hw/timer/grlib_gptimer.c| 2 +- h

[Qemu-devel] [PATCH v2 12/47] trace: switch hw/audio/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/audio/ directory to include the hw/audio/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- hw/audio/Makefile.objs| 3 +++ hw/audio/cs4231.c | 2 +- hw/audio/milkymist-ac97.c | 2 +- 4 files

[Qemu-devel] [PATCH v2 41/47] trace: switch target/ppc/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the target/ppc/ directory to include the target/ppc/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- target/ppc/Makefile.objs | 2 ++ target/ppc/kvm.c | 2 +- 3 files changed, 4 insertions(+), 2 deleti

[Qemu-devel] [PATCH v2 35/47] trace: switch audio/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the audio/ directory to include the audio/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- audio/Makefile.objs | 2 ++ audio/alsaaudio.c | 2 +- audio/ossaudio.c| 2 +- 4 files changed, 5 insertions(+), 3 del

[Qemu-devel] [PATCH v2 28/47] trace: switch hw/pci/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/pci/ directory to include the hw/pci/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- hw/pci/Makefile.objs | 2 ++ hw/pci/pci.c | 2 +- hw/pci/pci_host.c| 2 +- 4 files changed, 5 insertions(+),

[Qemu-devel] [PATCH v2 15/47] trace: switch hw/scsi/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/scsi/ directory to include the hw/scsi/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- hw/scsi/Makefile.objs | 3 +++ hw/scsi/esp-pci.c | 2 +- hw/scsi/esp.c | 2 +- hw/scsi/megasas.c | 2

[Qemu-devel] [PATCH v2 39/47] trace: switch target/sparc/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the target/sparc/ directory to include the target/sparc/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- target/sparc/Makefile.objs | 2 ++ target/sparc/int32_helper.c | 2 +- target/sparc/int64_helper.c |

[Qemu-devel] [PATCH v2 31/47] trace: switch hw/acpi/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/acpi/ directory to include the hw/acpi/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- hw/acpi/Makefile.objs| 2 ++ hw/acpi/cpu.c| 2 +- hw/acpi/memory_hotplug.c | 2 +- 4 files changed

[Qemu-devel] [PATCH v2 36/47] trace: switch net/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the net/ directory to include the net/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- net/Makefile.objs | 2 ++ net/filter-mirror.c | 2 +- net/vhost-user.c| 2 +- 4 files changed, 5 insertions(+), 3 deletio

[Qemu-devel] [PATCH v2 18/47] trace: switch hw/input/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/input/ directory to include the hw/input/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- hw/input/Makefile.objs | 3 +++ hw/input/hid.c | 2 +- hw/input/milkymist-softusb.c | 2

[Qemu-devel] [PATCH v2 42/47] trace: switch qom/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the qom/ directory to include the qom/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- qom/Makefile.objs | 2 ++ qom/object.c | 2 +- qom/trace-events | 7 +++ trace-events | 6 -- 5 files changed,

[Qemu-devel] [PATCH v2 43/47] trace: switch linux-user/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the linux-user/ directory to include the linux-user/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- linux-user/Makefile.objs | 2 ++ linux-user/signal.c | 2 +- 3 files changed, 4 insertions(+), 2 deleti

[Qemu-devel] [PATCH v2 37/47] trace: switch target/arm/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the target/arm/ directory to include the target/arm/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- target/arm/Makefile.objs | 2 ++ target/arm/helper.c | 2 +- 3 files changed, 4 insertions(+), 2 deleti

[Qemu-devel] [PATCH v2 22/47] trace: switch hw/sd/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/sd/ directory to include the hw/sd/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- hw/sd/Makefile.objs | 2 ++ hw/sd/milkymist-memcard.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the target/s390x/ directory to include the target/s390x/trace.h file instead of the global trace.h file. The make rules for gen-features.{h,c} need to be moved out into the top level Makefile.objs, otherwise make complains about the rules being defined multiple times due to target/

[Qemu-devel] [PATCH v2 45/47] trace: remove the global include/trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch to generating top level trace.[hc] files, instead of using include/trace.h with trace/generated-tracers.[ch], so the top level directory works in the same manner as all the sub-dirs. Signed-off-by: Daniel P. Berrange --- .gitignore | 10 ++-- Makefile

Re: [Qemu-devel] [PATCH 5/8] ui: extract code to connect/listen from vnc_display_open

2017-01-06 Thread Eric Blake
On 01/05/2017 10:06 AM, Daniel P. Berrange wrote: > The code which takes a SocketAddress and connects/listens on the > network is going to get more complicated to deal with multiple > listeners. Pull it out into a separate method to avoid making the > vnc_display_open method even more complex. > >

[Qemu-devel] [PATCH v2 24/47] trace: switch hw/mem/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/mem/ directory to include the hw/mem/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 2 +- hw/mem/Makefile.objs | 3 +++ hw/mem/pc-dimm.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 44/47] trace: switch qapi/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the qapi/ directory to include the qapi/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- qapi/Makefile.objs | 2 ++ qapi/qapi-visit-core.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] qemu-softmmu aborted with "Bad ram pointer"

2017-01-06 Thread Peter Maydell
On 6 January 2017 at 15:24, Max Filippov wrote: > On Fri, Jan 6, 2017 at 2:23 AM, Peter Maydell > wrote: >> On 5 January 2017 at 22:52, Max Filippov wrote: >>> Hello, >>> >>> debugging XIP kernel running directly from CFI FLASH I've got to a point >>> where QEMU aborts with the message "Bad ram

[Qemu-devel] [PATCH v2 33/47] trace: switch hw/alpha/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
Switch files in the hw/alpha/ directory to include the hw/alpha/trace.h file instead of the global trace.h file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 2 +- hw/alpha/Makefile.objs | 2 ++ hw/alpha/pci.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) di

[Qemu-devel] [PATCH v2 46/47] trace: update docs to reflect new code generation approach

2017-01-06 Thread Daniel P. Berrange
Describe use of per-subdir trace events files and how it impacts code generation. Signed-off-by: Daniel P. Berrange --- docs/tracing.txt | 61 +++- 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.t

Re: [Qemu-devel] [PATCH 6/8] ui: let VNC server listen on all resolved IP addresses

2017-01-06 Thread Eric Blake
On 01/05/2017 10:06 AM, Daniel P. Berrange wrote: > Remove the limitation that the VNC server can only listen on > a single resolved IP address. This uses the new DNS resolver > API to resolve a SocketAddress struct into an array of > SocketAddress structs containing raw IP addresses. The VNC > ser

[Qemu-devel] [PATCH v2 47/47] trace: improve error reporting when parsing simpletrace header

2017-01-06 Thread Daniel P. Berrange
When loading a simpletrace binary file we just report "Not a valid trace file!" which is not very helpful. Report exactly which field we found to be invalid. Signed-off-by: Daniel P. Berrange --- scripts/simpletrace.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2017 at 03:54:56PM +, Daniel P. Berrange wrote: > This is the final part of my trace events refactoring. > > Previously we merged code that split trace-events up > into one file per sub-directory. We also merged code > to the code-generator that enables us to generate > and use

Re: [Qemu-devel] [PATCH 7/8] util: add qemu_opt_get_all() to get repeated opts

2017-01-06 Thread Eric Blake
On 01/05/2017 10:07 AM, Daniel P. Berrange wrote: > The QemuOpts parser accepts repeated option names, storing > all the provided values. qemu_opt_get() then just returns > the last value. There is no way to get the other values > without using a callback function to iterate over all > option names

Re: [Qemu-devel] [PATCH v3 4/4] migration: Fail migration blocker for --only-migratble

2017-01-06 Thread Greg Kurz
On Wed, 4 Jan 2017 18:02:29 +0530 Ashijeet Acharya wrote: > migrate_add_blocker should rightly fail if the '--only-migratable' > option was specified and the device in use should not be able to > perform the action which results in an unmigratable VM. > > Make migrate_add_blocker return -EACCES

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: fix sending mouse event to guest

2017-01-06 Thread Programmingkid
On Jan 6, 2017, at 11:19 AM, Peter Maydell wrote: > On 6 January 2017 at 15:44, Programmingkid wrote: >> >> On Jan 6, 2017, at 8:48 AM, Peter Maydell wrote: >> >>> On 1 January 2017 at 21:31, Programmingkid >>> wrote: The mouse down event should not be sent to the guest if the mouse dow

Re: [Qemu-devel] [scripts] default shell/perl locations

2017-01-06 Thread Sean Bruno
On 01/06/17 01:14, Paolo Bonzini wrote: > > > On 05/01/2017 23:41, Sean Bruno wrote: >> I don't suppose it would be possible to have configure check/change the >> interpreter path for scripts so that operating systems that don't have >> /usr/bin/perl for example, would work out of the box? > >

Re: [Qemu-devel] [PATCH v2 00/16] Remove VirtGuestInfo

2017-01-06 Thread Peter Maydell
On 2 January 2017 at 20:01, Andrew Jones wrote: > v2: > - all Igor's suggestions > - added four mach-virt acpi cleanup patches > - added the remaining two acpi patches needed to bring equivalence >to Peter's DT changes > > This series is based on Peter's qemu-arm gicv3-virt branch. It's > m

Re: [Qemu-devel] [PATCH 03/20] char: add qemu_chr_fe_add_watch() Returns description

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/sysemu/char.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Eric Blake > diff --git a/include/sysemu/char.h b/include/sysemu/char.h > index 0a149428cf..b6e361860a 100644 > --- a/incl

Re: [Qemu-devel] [PULL 0/4] cryptodev patches

2017-01-06 Thread Peter Maydell
On 24 December 2016 at 06:12, Gonglei wrote: > The following changes since commit a470b33259bf82ef2336bfcd5d07640562d3f63b: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-12-22 19:23:51 +) > > are available in the git repository at: > > > https:/

Re: [Qemu-devel] [PATCH 01/20] tests: fix linking test-char on win32

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > test-char.exe needs main-loop.o symbols, among others. Linking with > $(test-block-obj-y) brings what's necessary. We could try to eventually > strip to the minimum if needed. > > Signed-off-by: Marc-André Lureau > --- > tests/Makefile.include |

Re: [Qemu-devel] [PATCH 04/20] doc: fix spelling

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > I am pretty sure that's the word Fabrice Bellard intended to write. > > Signed-off-by: Marc-André Lureau > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake Spell-checkers don't flag everyth

Re: [Qemu-devel] [PATCH 02/20] qemu-options: stdio is available on win32

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > Available since commit db418a0a7ef5887ea0f3d167584e6f500bb0c4c5 > (October 2011, qemu 1.0) > > Signed-off-by: Marc-André Lureau > --- > qemu-options.hx | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake (Isn't git history fun!)

Re: [Qemu-devel] [PATCH v3 3/4] migration: disallow migrate_add_blocker during migration

2017-01-06 Thread Greg Kurz
Hi Ashijeet, I didn't think hard enough while reviewing the changes for hw/9pfs/9p.c... I have some more remarks, sorry... :-/ On Wed, 4 Jan 2017 18:02:28 +0530 Ashijeet Acharya wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should righ

Re: [Qemu-devel] [PATCH v2 15/16] hw/arm/virt-acpi-build: use SMC if booting in EL2

2017-01-06 Thread Peter Maydell
On 2 January 2017 at 20:01, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > hw/arm/virt-acpi-build.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index b5e17a680d51..7c00ee683f44 100644 > ---

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: fix sending mouse event to guest

2017-01-06 Thread Peter Maydell
On 6 January 2017 at 15:44, Programmingkid wrote: > > On Jan 6, 2017, at 8:48 AM, Peter Maydell wrote: > >> On 1 January 2017 at 21:31, Programmingkid wrote: >>> The mouse down event should not be sent to the guest if the mouse down event >>> causes QEMU to move the foreground from the background

Re: [Qemu-devel] [PATCH v2 16/16] hw/arm/virt-acpi-build: madt: add vgic maint irq

2017-01-06 Thread Peter Maydell
On 2 January 2017 at 20:01, Andrew Jones wrote: > When virtualization is enabled and we have a v3 gic, then we add > the vgic maintenance interrupt to the DT. This patch is the ACPI > equivalent. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt-acpi-build.c | 3 +++ > 1 file changed, 3 insert

Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file

2017-01-06 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file Message-id: 20170106155543.12827-1-ber

Re: [Qemu-devel] [PATCH v2 01/47] trace: introduce some Makefile rules for module code gen

2017-01-06 Thread Lluís Vilanova
Daniel P Berrange writes: > Introduce rules that are able to generate trace.[ch] files > in every subdirectory which has a trace-events file. > Signed-off-by: Daniel P. Berrange > --- > .gitignore | 6 +++ > Makefile | 65 > +++

[Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread Seraphime Kirkovski
Currently, the cmpxchg implementation tests whether the destination address is readable: - if it is, we read the value and continue with the comparison - if isn't, i.e. access to addr would segfault, we assume that src != dest rather than queuing a SIGSEGV. The same problem exists in the c

Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2017 at 06:09:16PM +0100, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > Switch files in the target/s390x/ directory to include the > > target/s390x/trace.h file instead of the global trace.h > > file. > > > The make rules for gen-features.{h,c} need to be moved > > out i

Re: [Qemu-devel] [PATCH v2 46/47] trace: update docs to reflect new code generation approach

2017-01-06 Thread Lluís Vilanova
Daniel P Berrange writes: > Describe use of per-subdir trace events files and how it impacts > code generation. > Signed-off-by: Daniel P. Berrange > --- > docs/tracing.txt | 61 > +++- > 1 file changed, 52 insertions(+), 9 deletions(-) > di

Re: [Qemu-devel] [PATCH 8/8] ui: add ability to specify multiple VNC listen addresses

2017-01-06 Thread Eric Blake
On 01/05/2017 10:07 AM, Daniel P. Berrange wrote: > This change allows the listen address and websocket address > options for -vnc to be repeated. This causes the VNC server > to listen on multiple addresses. e.g. > > $ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\ > websocket=127.

Re: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread Peter Maydell
On 6 January 2017 at 16:21, Seraphime Kirkovski wrote: > Currently, the cmpxchg implementation tests whether the destination address > is readable: > - if it is, we read the value and continue with the comparison > - if isn't, i.e. access to addr would segfault, we assume that src != dest >

Re: [Qemu-devel] Problems with qemu "modern" virtio on sparc64

2017-01-06 Thread Mark Cave-Ayland
On 30/12/16 19:57, Guenter Roeck wrote: > On 12/30/2016 10:18 AM, Mark Cave-Ayland wrote: >> On 25/11/16 18:11, Guenter Roeck wrote: >> >>> Hi, >>> >>> I am using virtio on sparc64 for my Linux kernel runtime tests. >>> >>> Starting with qemu v2.7, I noticed that the kernel either gets stuck or >>

Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file

2017-01-06 Thread Lluís Vilanova
Daniel P Berrange writes: > Switch files in the target/s390x/ directory to include the > target/s390x/trace.h file instead of the global trace.h > file. > The make rules for gen-features.{h,c} need to be moved > out into the top level Makefile.objs, otherwise make > complains about the rules bein

Re: [Qemu-devel] [PATCH v2 00/47] Switch all subdirs over to modular trace.h file

2017-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2017 at 09:02:42AM -0800, no-re...@patchew.org wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it [snip] > /tmp/qemu-test/src/hw/char/pl011.c: In funct

Re: [Qemu-devel] [PATCH v2 01/47] trace: introduce some Makefile rules for module code gen

2017-01-06 Thread Daniel P. Berrange
On Fri, Jan 06, 2017 at 06:20:51PM +0100, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > Introduce rules that are able to generate trace.[ch] files > > in every subdirectory which has a trace-events file. > > > Signed-off-by: Daniel P. Berrange > > --- > > .gitignore

Re: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap

2017-01-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCHv2] target-arm/abi32: check for segfault in do_kernel_trap Message-id: 20170106162116.12859-1-kirkser...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BAS

Re: [Qemu-devel] Proposal PCI/PCIe device placement on PAPR guests

2017-01-06 Thread Andrea Bolognani
[Added Laine to CC, fixed qemu-devel address] On Thu, 2017-01-05 at 16:46 +1100, David Gibson wrote: [...] >   * To allow for hotplugged devices, libvirt should also add a number > of additional, empty vPHBs (the PAPR spec allows for hotplug of > PHBs, but this is not yet implemented in qe

[Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow

2017-01-06 Thread Peter Maydell
Don't truncate the multiplication and do a 64 bit one instead because the result is stored in a 64 bit variable. This fixes a similar coverity warning to commit 237a8650d640, in a similar way, and is the other half of the fix for coverity CID 1167561. Signed-off-by: Peter Maydell --- hw/display

Re: [Qemu-devel] [PATCH 05/20] char: use a const CharDriver

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > No need to allocate & copy fields, let's use static const struct > instead. > > Signed-off-by: Marc-André Lureau > --- > include/sysemu/char.h | 19 +++ > backends/baum.c | 8 ++- > backends/msmouse.c| 7 ++- > backends/testde

Re: [Qemu-devel] [PATCH v2 46/47] trace: update docs to reflect new code generation approach

2017-01-06 Thread Eric Blake
On 01/06/2017 09:55 AM, Daniel P. Berrange wrote: > Describe use of per-subdir trace events files and how it impacts > code generation. > > Signed-off-by: Daniel P. Berrange > --- > docs/tracing.txt | 61 > +++- > 1 file changed, 52 insertions

Re: [Qemu-devel] [PATCH v2 47/47] trace: improve error reporting when parsing simpletrace header

2017-01-06 Thread Eric Blake
On 01/06/2017 09:55 AM, Daniel P. Berrange wrote: > When loading a simpletrace binary file we just report > "Not a valid trace file!" which is not very helpful. Report > exactly which field we found to be invalid. > > Signed-off-by: Daniel P. Berrange > --- > scripts/simpletrace.py | 10 +++-

Re: [Qemu-devel] [PATCH v3] [i.MX] fix CS handling during SPI access.

2017-01-06 Thread Jean-Christophe DUBOIS
Le 06/01/2017 à 13:28, mar.krzeminski a écrit : Please make sure that in HW ECSPI_CONFIGREG_SS_POL bits are 0's after reset/power up (defaults). There is already a memset to 0 of all regs (including CONFIGREG) in the reset function. I saw that memset, my question is rather real HW also have 0s

Re: [Qemu-devel] [PATCH v6 RESEND 00/10] tcg mips64 and mips r6 improvements

2017-01-06 Thread Richard Henderson
On 01/04/2017 08:57 PM, Jin Guojie wrote: > Resend for review. All modifications have been made according to > Henderson's review comments, and all tests passed. > > Changes in v6: > * Update against master(v2.8.0-rc3) > * Fix two bugs according to Richard Henderson's review comments > (

Re: [Qemu-devel] [PATCH v2] [i.MX] Remove MSGDATA register support.

2017-01-06 Thread Jean-Christophe DUBOIS
Le 06/01/2017 à 16:11, Peter Maydell a écrit : +case ECSPI_MSGDATA: +/* it is not clear from the spec what MSGDATA is for */ +/* Anyway it is not used by Linux driver */ +/* So for now we just ignore it */ +qemu_log_mask(LOG_GUEST_ERROR, +

Re: [Qemu-devel] [PATCH] [m25p80] Abort in case we overrun the internal data buffer

2017-01-06 Thread Jean-Christophe DUBOIS
Le 06/01/2017 à 11:18, Peter Maydell a écrit : On 5 January 2017 at 21:39, Jean-Christophe DUBOIS wrote: So I think this behavior could be triggered either by buggy SPI controller emulator or by buggy guest software. And it seems hard to determine where the fault comes from from within Qemu. Ob

[Qemu-devel] [PATCH 01/15] postcopy: Transmit and compare individual page sizes

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When using postcopy with hugepages, we require the source and destination page sizes for any RAMBlock to match. Transmit them as part of the RAM information header and fail if there's a difference. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 15 +

[Qemu-devel] [PATCH 06/15] postcopy: Record largest page size

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Record the largest page size in use; we'll need it soon for allocating temporary buffers. Signed-off-by: Dr. David Alan Gilbert --- exec.c| 13 + include/exec/cpu-common.h | 1 + include/migration/migration.h | 1 + migra

[Qemu-devel] [PATCH 09/15] postcopy: Load huge pages in one go

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The existing postcopy RAM load loop already ensures that it glues together whole host-pages from the target page size chunks sent over the wire. Modify the definition of host page that it uses to be the RAM block page size and thus be huge pages where appropriate.

[Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, The existing postcopy code, and the userfault kernel code that supports it, only works for normal anonymous memory. Kernel support for userfault on hugetlbfs is working it's way upstream; it's just gone into the linux-mm tree, You can get a version at: git:

[Qemu-devel] [PATCH 03/15] postcopy: Chunk discards for hugepages

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" At the start of the postcopy phase, partially sent huge pages must be discarded. The code for dealing with host page sizes larger than the target page size can be reused for this case. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 17 +-

[Qemu-devel] [PATCH 02/15] postcopy: Transmit ram size summary word

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Replace the host page-size in the 'advise' command by a pagesize summary bitmap; if the VM is just using normal RAM then this will be exactly the same as before, however if they're using huge pages they'll be different, and thus: a) Migration from/to old qemu's t

[Qemu-devel] [PATCH 07/15] postcopy: Plumb pagesize down into place helpers

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now we deal with normal size pages and huge pages we need to tell the place handlers the size we're dealing with and make sure the temporary page is large enough. Signed-off-by: Dr. David Alan Gilbert --- include/migration/postcopy-ram.h | 6 +++-- migration/pos

[Qemu-devel] [PATCH 11/15] postcopy: Send whole huge pages

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The RAM save code uses ram_save_host_page to send whole host pages at a time; change this to use the host page size associated with the RAM Block which may be a huge page. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 6 +- 1 file changed, 5 in

[Qemu-devel] [PATCH 04/15] Fold postcopy_ram_discard_range into ram_discard_range

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I'd created this weird pair of: ram_discard_range that lived in migration/ram.c Which is built target-dependent so can access the insides of RAMBlock postcopy_ram_discard_range Which actually does the discard. Flatten these down into ram_disca

[Qemu-devel] [PATCH 15/15] postcopy: Add doc about hugepages and postcopy

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- docs/migration.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/migration.txt b/docs/migration.txt index 6503c17..b462ead 100644 --- a/docs/migration.txt +++ b/docs/migration.txt @@ -482,3 +482,1

[Qemu-devel] [PATCH 08/15] postcopy: Use temporary for placing zero huge pages

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The kernel can't do UFFDIO_ZEROPAGE for huge pages, so we have to allocate a temporary (always zero) page and use UFFDIO_COPYPAGE on it. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 + migration/postcopy-ram.c | 23 +++

[Qemu-devel] [PATCH 14/15] postcopy: Check for userfault+hugepage feature

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We need extra Linux kernel support (~4.9) to support userfaults on hugetlbfs; check for them. Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/migration/postcopy-ram.c b/migration/

[Qemu-devel] [PATCH 05/15] postcopy: enhance ram_discard_range for hugepages

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Unfortunately madvise DONTNEED doesn't work on hugepagetlb so use fallocate(FALLOC_FL_PUNCH_HOLE) qemu_fd_getpagesize only sets the page based off a file if the file is from hugetlbfs. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 24 +++

[Qemu-devel] [PATCH 10/15] postcopy: Mask fault addresses to huge page boundary

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Currently the fault address received by userfault is rounded to the host page boundary and a host page is requested from the source. Use the current RAMBlock page size instead of the general host page size so that for RAMBlocks backed by huge pages we request the wh

[Qemu-devel] [PATCH 12/15] postcopy: Allow hugepages

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow huge pages in postcopy. Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 03cbd6e..6b30b

[Qemu-devel] [PATCH v2 0/3] block: m25p80: Improve mt25qu01g chip model

2017-01-06 Thread Marcin Krzeminski
This series introduce some improvememnt targeting mt25qu01g and adds support for n25q00 device. v2: * Rework die erase command functionality. Since the number of dies is constant per chip, new field to flash description structure has been added (instead of dynamic code from v1). * Add definition f

Re: [Qemu-devel] [PATCH v3] [i.MX] fix CS handling during SPI access.

2017-01-06 Thread mar.krzeminski
W dniu 06.01.2017 o 19:18, Jean-Christophe DUBOIS pisze: Le 06/01/2017 à 13:28, mar.krzeminski a écrit : Please make sure that in HW ECSPI_CONFIGREG_SS_POL bits are 0's after reset/power up (defaults). There is already a memset to 0 of all regs (including CONFIGREG) in the reset function. I

[Qemu-devel] [PATCH 13/15] postcopy: Update userfaultfd.h header

2017-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We use a new userfaultfd define, so update the header. (Not needed if someone just runs the update script once it's gone into the main kernel). Signed-off-by: Dr. David Alan Gilbert --- linux-headers/linux/userfaultfd.h | 81 ++

Re: [Qemu-devel] Problems with qemu "modern" virtio on sparc64

2017-01-06 Thread Guenter Roeck
On Fri, Jan 06, 2017 at 05:04:58PM +, Mark Cave-Ayland wrote: > On 30/12/16 19:57, Guenter Roeck wrote: > > Disabling "modern" mode enables boot to proceed as normal: > > $ ./qemu-system-sparc64 \ > -drive > file=debian-9.0-sparc64-NETINST1.iso,if=none,index=0,id=cd,media=cdrom \ > -device vi

[Qemu-devel] [PATCH v2 1/3] block: m25p80: Add Quad Page Program 4byte

2017-01-06 Thread Marcin Krzeminski
Some flash chips have additional page program opcode that takes only 4 byte address. This commit adds support for such command in Qemu. Signed-off-by: Marcin Krzeminski Reviewed-by: Edgar E. Iglesias --- hw/block/m25p80.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/m25p80.c

[Qemu-devel] [PATCH v2 3/3] block: m25p80: Improve 1GiB Micron flash definition

2017-01-06 Thread Marcin Krzeminski
n25q00 and mt25q01 devices share the same JEDEC ID. The difference between those two devices is number of dies and one bit in extended JEDEC bytes. This commit adds proper entry for both devices by introduction the number of dies and and new 25q00 entries. Signed-off-by: Marcin Krzeminski --- hw

[Qemu-devel] [PATCH v2 2/3] block: m25p80: Introduce die erase command

2017-01-06 Thread Marcin Krzeminski
Modern big flash nor devices consist from more than one die. Some of them do not support chip erase and instead have die erase command that can erase one die only. This commit adds possibility to define number of dies in the chip and adds support for die erase command. Nor flash model is not strict

Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support

2017-01-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170106182823.1960-1-dgilb...@redhat.com Subject: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH 00/15] Postcopy: Hugepage support

2017-01-06 Thread Dr. David Alan Gilbert
* no-re...@patchew.org (no-re...@patchew.org) wrote: > Hi, > Checking PATCH 14/15: postcopy: Check for userfault+hugepage feature... > ERROR: trailing whitespace > #21: FILE: migration/postcopy-ram.c:85: > +bool have_hp = false; $ I noticed that one but explicitly left it; the code really

Re: [Qemu-devel] [PATCH 06/20] char: use a static array for backends

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > Number and kinds of backends is known at compile-time, use a fixed-sized > static array to simplify iterations & lookups. Add an alias field to the > CharDriver structure to cover the cases where we previously registered a > driver twice under two

Re: [Qemu-devel] [PATCH] lm32: milkymist-tmu2: fix another integer overflow

2017-01-06 Thread Michael Walle
Am 6. Januar 2017 18:45:14 MEZ schrieb Peter Maydell : >Don't truncate the multiplication and do a 64 bit one instead >because the result is stored in a 64 bit variable. > >This fixes a similar coverity warning to commit 237a8650d640, >in a similar way, and is the other half of the fix for >coverit

Re: [Qemu-devel] [RFC] pxb: Restrict to x86

2017-01-06 Thread Michael S. Tsirkin
On Fri, Jan 06, 2017 at 08:13:11AM +0200, Marcel Apfelbaum wrote: > On 01/06/2017 07:04 AM, David Gibson wrote: > > The PCI Expander Bridge (PXB) device is essentially a hack to allow > > different PCIe devices to be assigned to different NUMA nodes on x86. Each > > PXB is sort-of a separate PCI h

Re: [Qemu-devel] Problems with qemu "modern" virtio on sparc64

2017-01-06 Thread Mark Cave-Ayland
On 06/01/17 18:34, Guenter Roeck wrote: > On Fri, Jan 06, 2017 at 05:04:58PM +, Mark Cave-Ayland wrote: >> On 30/12/16 19:57, Guenter Roeck wrote: >> >> Disabling "modern" mode enables boot to proceed as normal: >> >> $ ./qemu-system-sparc64 \ >> -drive >> file=debian-9.0-sparc64-NETINST1.iso,

Re: [Qemu-devel] [PATCH 01/20] tests: fix linking test-char on win32

2017-01-06 Thread Marc-André Lureau
Hi - Original Message - > On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > > test-char.exe needs main-loop.o symbols, among others. Linking with > > $(test-block-obj-y) brings what's necessary. We could try to eventually > > strip to the minimum if needed. > > > > Signed-off-by: Marc-An

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-06 Thread Michael S. Tsirkin
On Sat, Dec 17, 2016 at 11:18:03AM +, Peter Maydell wrote: > On 16 December 2016 at 21:32, wrote: > > Your series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Subject: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes > >

Re: [Qemu-devel] [PATCH 01/20] tests: fix linking test-char on win32

2017-01-06 Thread Eric Blake
On 01/06/2017 01:50 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 01/05/2017 10:53 AM, Marc-André Lureau wrote: >>> test-char.exe needs main-loop.o symbols, among others. Linking with >>> $(test-block-obj-y) brings what's necessary. We could try to eventually >>> strip t

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-06 Thread Eric Blake
On 01/06/2017 02:04 PM, Michael S. Tsirkin wrote: > On Sat, Dec 17, 2016 at 11:18:03AM +, Peter Maydell wrote: >> On 16 December 2016 at 21:32, wrote: >>> Your series seems to have some coding style problems. See output below for >>> more information: >>> >>> Type: series >>> Subject: [Qemu-d

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-06 Thread Eric Blake
On 01/06/2017 02:38 PM, Eric Blake wrote: > > But how to force git to send mail in UTF-8 is not something I've had to > figure out (I'm relying on my distro's defaults) - you'll have to poke > around your .git/config (or ~/.gitconfig) and see if you have some > really old settings from an earlier

Re: [Qemu-devel] [PATCH v2 40/47] trace: switch target/s390x/ directory to modular trace.h file

2017-01-06 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Jan 06, 2017 at 06:09:16PM +0100, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > Switch files in the target/s390x/ directory to include the >> > target/s390x/trace.h file instead of the global trace.h >> > file. >> >> > The make rules for gen-featu

Re: [Qemu-devel] [PATCH v2 01/47] trace: introduce some Makefile rules for module code gen

2017-01-06 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Jan 06, 2017 at 06:20:51PM +0100, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > Introduce rules that are able to generate trace.[ch] files >> > in every subdirectory which has a trace-events file. >> >> > Signed-off-by: Daniel P. Berrange >> > --

Re: [Qemu-devel] Problems with qemu "modern" virtio on sparc64

2017-01-06 Thread Guenter Roeck
On Fri, Jan 06, 2017 at 07:42:19PM +, Mark Cave-Ayland wrote: > On 06/01/17 18:34, Guenter Roeck wrote: > > > On Fri, Jan 06, 2017 at 05:04:58PM +, Mark Cave-Ayland wrote: > >> On 30/12/16 19:57, Guenter Roeck wrote: > >> > >> Disabling "modern" mode enables boot to proceed as normal: > >>

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2017-01-06 Thread Michael S. Tsirkin
On Fri, Jan 06, 2017 at 02:38:32PM -0600, Eric Blake wrote: > On 01/06/2017 02:04 PM, Michael S. Tsirkin wrote: > > On Sat, Dec 17, 2016 at 11:18:03AM +, Peter Maydell wrote: > >> On 16 December 2016 at 21:32, wrote: > >>> Your series seems to have some coding style problems. See output below

Re: [Qemu-devel] [PATCH 07/20] char: move callbacks in CharDriver

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > This makes the code more declarative, and avoids duplicating the > information on all instances. > > Signed-off-by: Marc-André Lureau > --- > include/sysemu/char.h | 46 ++--- > backends/baum.c | 11 +- > backends/msmouse.c| 11 +- >

Re: [Qemu-devel] [PATCH 11/20] char: allocate CharDriverState as a single object

2017-01-06 Thread Eric Blake
On 01/05/2017 10:53 AM, Marc-André Lureau wrote: > Use a single allocation for CharDriverState, this avoids extra > allocations & pointers, and is a step towards more object-oriented > CharDriver. > > Gtk console is a bit peculiar, gd_vc_chr_set_echo() used to have a > temporary VirtualConsole to

Re: [Qemu-devel] Problems with qemu "modern" virtio on sparc64

2017-01-06 Thread Michael S. Tsirkin
On Fri, Jan 06, 2017 at 01:05:46PM -0800, Guenter Roeck wrote: > On Fri, Jan 06, 2017 at 07:42:19PM +, Mark Cave-Ayland wrote: > > On 06/01/17 18:34, Guenter Roeck wrote: > > > > > On Fri, Jan 06, 2017 at 05:04:58PM +, Mark Cave-Ayland wrote: > > >> On 30/12/16 19:57, Guenter Roeck wrote:

<    1   2   3   >