On Do, 2017-01-05 at 06:11 +0900, OGAWA Hirofumi wrote:
> Hervé Poussineau writes:
>
> > Le 04/01/2017 à 09:50, Gerd Hoffmann a écrit :
> >> On Mi, 2016-12-28 at 04:55 +0900, OGAWA Hirofumi wrote:
> >>> With "ps2: use QEMU qcodes instead of scancodes", key handling was
> >>> changed to qcode base
Hi,
According to the docs, the destination Qemu must have the exactly same
parameters as the source one. So if the source has just finished cpu or
memory hotplug, what would the dest's parameters be like?
Does DIMM device, or logically QOM object, have to be reflected on the new
command-line para
On 2017/1/4 18:32, Daniel P. Berrange wrote:
On Wed, Jan 04, 2017 at 09:32:01AM +0800, zhanghailiang wrote:
From: Caoxinhua
QEMU will crash with the follow backtrace if the new created thread exited
before
we call qemu_thread_set_name() for it.
(gdb) bt
#0 0x7f9a68b095d7 in __GI_ra
On 2017/1/4 19:59, Paolo Bonzini wrote:
On 04/01/2017 02:32, zhanghailiang wrote:
From: Caoxinhua
QEMU will crash with the follow backtrace if the new created thread exited
before
we call qemu_thread_set_name() for it.
(gdb) bt
#0 0x7f9a68b095d7 in __GI_raise (sig=sig@entry=6) at
Gerd Hoffmann writes:
>> Yes, please use v3. Here is copy&paste, FWIW.
>
> Please don't send new versions of patches as reply. That confuses
> various patch management tools, they are considered being part of the
> discussion then. This is how the reviewed-by tag ended up being
> attributed to
On Thu, Nov 17, 2016 at 07:38:45PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 17, 2016 at 01:27:49PM +, Stefan Hajnoczi wrote:
> > On Thu, Nov 17, 2016 at 12:17:57AM +0200, Michael S. Tsirkin wrote:
> > > On Wed, Nov 16, 2016 at 09:53:06PM +, Stefan Hajnoczi wrote:
> > > > Disabling not
If we want to actually host enforce (disallow) access to inflated pages, having
Is that a new feature?
Still in the design phase. Andrea Arcangeli briefly mentioned in in his
reply to v5 of your patch series
"We also plan to use userfaultfd to make the balloon driver host
enforced (will wo
This series enables VT-d IOMMU migration.
First patch is an enhancement to current migration framework to allow
prioritized save state entry. This is required to let VT-d migrate
properly.
The second patch enables the migration for the vIOMMU.
Please check commit message for more information.
T
During migration, save state entries are saved/loaded without a specific
order - we just traverse the savevm_state.handlers list and do it one by
one. This might not be enough in the future.
There is case that we need to load specific device's vmstate first
before others. For example, VT-d IOMMU c
IOMMU needs to be migrated before all the PCI devices (in case there are
devices that will request for address translation). So marking it with
priority 100. Migration framework helped to do all the rest.
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 21 -
1 file change
On Thu, Jan 05, 2017 at 04:27:26PM +0800, Bob Chen wrote:
> Hi,
>
> According to the docs, the destination Qemu must have the exactly same
> parameters as the source one. So if the source has just finished cpu or
> memory hotplug, what would the dest's parameters be like?
>
> Does DIMM device, or
> >> If we want to actually host enforce (disallow) access to inflated
> >> pages, having
> >
> > Is that a new feature?
>
> Still in the design phase. Andrea Arcangeli briefly mentioned in in his reply
> to
> v5 of your patch series
>
> "We also plan to use userfaultfd to make the balloon drive
On 04/01/2017 14:24, Michael S. Tsirkin wrote:
> On Wed, Jan 04, 2017 at 12:43:35PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 04/01/2017 09:43, Li Qiang wrote:
>>> From: Li Qiang
>>>
>>> The serial_exit_core function doesn't free some resources.
>>> This can lead memory leak when hotplug and unplu
On Wed, Jan 04, 2017 at 04:26:24PM -0500, Paolo Bonzini wrote:
> > > @@ -84,8 +83,8 @@ struct QIOChannel {
> > > +static void qio_channel_set_fd_handlers(QIOChannel *ioc)
> > > +{
> > > +IOHandler *rd_handler = NULL, *wr_handler = NULL;
> > > +
> > > +if (ioc->read_coroutine) {
> > > + rd_h
On 01/03/2017 08:16 PM, Michal Suchanek wrote:
This allows running big endian and little endian guest side by side using
cut & paste between them.
There is a general design idea that swapping should come as close to
virtio_read/virtio_write as possible. In particular, the protocol
between vdagen
On 05/01/2017 11:26, Daniel P. Berrange wrote:
+if (condition == G_IO_IN) {
+ioc->read_coroutine = qemu_coroutine_self();
+} else if (condition == G_IO_OUT) {
+ioc->write_coroutine = qemu_coroutine_self();
+} else {
+abort();
On 05/01/2017 09:36, Hailiang Zhang wrote:
> On 2017/1/4 19:59, Paolo Bonzini wrote:
>> On 04/01/2017 02:32, zhanghailiang wrote:
>>> From: Caoxinhua
>>>
>>> QEMU will crash with the follow backtrace if the new created thread
>>> exited before
>>> we call qemu_thread_set_name() for it.
>>>
>>>
On Wed, Jan 04, 2017 at 11:36:31PM -0200, Eduardo Habkost wrote:
> On Wed, Jan 04, 2017 at 08:26:27PM -0200, Marcelo Tosatti wrote:
> > On Wed, Jan 04, 2017 at 05:59:17PM -0200, Eduardo Habkost wrote:
> > > On Wed, Jan 04, 2017 at 11:39:16AM -0200, Eduardo Habkost wrote:
> > > > On Wed, Jan 04, 201
On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> > Note that even if we follow your suggestion and implement an
> > alternative version of patch 4/4 to cover your use case, I will
> > strongly recommend libvirt developers to support configuring TSC
> > frequency if they want to su
On 3 January 2017 at 14:52, Gerd Hoffmann wrote:
> Hi,
>
> New year, new pull request. Here comes the vga patch queue with
> a collection of virtio-gpu fixes.
>
> please pull,
> Gerd
>
> The following changes since commit 6a928d25b6d8bc3729c3d28326c6db13b9481059:
>
> Update version for v2.8
xxinsertw: VSX Vector Insert Word
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c | 25 +
target-ppc/translate/vsx-impl.inc.c | 5 +++--
target-ppc/translate/vsx-ops.inc.c | 1 +
4 files changed, 30 i
This series contains 11 new instructions for POWER9 ISA3.0
VSX Vector Insert/Extract Word
VSX Scalar Extract Exponent/Significand
VSX Scalar Convert
VSX Scalar Add QP
Various float related improvements
Bharata B Rao (8):
target-ppc: Use float64 arg in helper_compute_fprf
From: Bharata B Rao
xsaddqp: VSX Scalar Add Quad-Precision
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 36
target-ppc/helper.h | 1 +
target-ppc/internal.h | 2 ++
From: Bharata B Rao
Use correct FP precision when setting FPRF in FP conversion helpers
instead of always assuming float64 precision.
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 4 ++--
target-ppc/internal.h | 1 +
2 files changed, 3 insertion
From: Bharata B Rao
xscvdphp: VSX Scalar round & Convert Double-Precision format to
Half-Precision format
xscvhpdp: VSX Scalar Convert Half-Precision format to
Double-Precision format
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
include/fpu/softfloat.h
xxextractuw: VSX Vector Extract Unsigned Word
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c | 26 ++
target-ppc/translate/vsx-impl.inc.c | 30 ++
target-ppc/translate/vsx-op
From: Bharata B Rao
Replace isden() by float64_is_zero_or_denormal() so that code in
helper_compute_fprf() can be reused to work with float128 argument.
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 11 +--
1 file changed, 1 insertion(+),
From: Bharata B Rao
Since helper_compute_fprf() works on float64 argument, rename it
to helper_compute_fprf_float64(). Also use a macro to generate
helper_compute_fprf_float64() so that float128 version of the same
helper can be introduced easily later.
Signed-off-by: Bharata B Rao
Signed-off-b
xsxexpqp: VSX Scalar Extract Exponent Quad Precision
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 15 +++
target-ppc/translate/vsx-ops.inc.c | 1 +
2 files changed, 16 insertions(+)
diff --git a/target-ppc/translate/vsx-impl.inc.c
b/target-ppc/transl
From: Bharata B Rao
xscvdpqp: VSX Scalar Convert Double-Precision format to
Quad-Precision format
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 10 ++
target-ppc/helper.h | 1 +
target-ppc/translate/v
From: Bharata B Rao
xscvqpdp: VSX Scalar round & Convert Quad-Precision format to
Double-Precision format
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 28
target-ppc/helper.h |
From: Bharata B Rao
Use float64 argument instead of unit64_t in helper_compute_fprf()
This allows code in helper_compute_fprf() to be reused later to
work with float128 argument too.
Signed-off-by: Bharata B Rao
Signed-off-by: Nikunj A Dadhania
---
target-ppc/fpu_helper.c | 16 +++
xsxsigdp: VSX Scalar Extract Significand Dual Precision
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 29 +
target-ppc/translate/vsx-ops.inc.c | 1 +
2 files changed, 30 insertions(+)
diff --git a/target-ppc/translate/vsx-impl.inc.c
b/
xsxexpdp: VSX Scalar Extract Exponent Dual Precision
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 13 +
target-ppc/translate/vsx-ops.inc.c | 4
2 files changed, 17 insertions(+)
diff --git a/target-ppc/translate/vsx-impl.inc.c
b/target-ppc/trans
On 3 January 2017 at 16:18, Sean Bruno wrote:
> I'm pondering where to start with getting FreeBSD's bsd-user code into
> shape so it could actually be reviewed and accepted now that its sort of
> working again (signal handling fixed finally).
>
> I almost feel like the existing code should be purg
xsxsigqp: VSX Scalar Extract Significand Quad Precision
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate/vsx-impl.inc.c | 29 +
target-ppc/translate/vsx-ops.inc.c | 1 +
2 files changed, 30 insertions(+)
diff --git a/target-ppc/translate/vsx-impl.inc.c
b/
On 27 December 2016 at 23:11, Sergio Andrés Gómez Del Real
wrote:
> The patch fixes dead code in pl080_read() and pl080_write() as reported
> in bug #1637974. According to ARM's official Technical Reference Manual,
> offsets handled by the switch statement are 0x100, 0x104, 0x108, 0x10C
> and 0x11
On Wed, Oct 26, 2016 at 12:08:52PM -0700, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.
Sorry I missed this during 2.8. This is stable-2.8 material once it
opens. Applied to linux-user now, thanks.
> Cc: Riku Vo
On Thu, Nov 24, 2016 at 05:08:53PM +0100, Lena Djokic wrote:
> This commit adds necessary conversion of argument passed to inotify_init1.
> inotify_init1 flags can be IN_NONBLOCK and IN_CLOEXEC which rely on O_NONBLOCK
> and O_CLOEXEC and those can have different values on different platforms.
Tha
On Thu, Nov 24, 2016 at 05:08:56PM +0100, Lena Djokic wrote:
> Calculation of 64-bit offset was not correct for all cases.
Thanks, applied to linux-user
> Signed-off-by: Lena Djokic
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-use
On Thu, Nov 24, 2016 at 05:08:58PM +0100, Lena Djokic wrote:
> If fourth argument is NULL it should be passed without
> using lock_user function which would, in that case, return
> EFAULT, and system call supports passing NULL as fourth argument.
Thanks, applied to linux-user
> Signed-off-by: Le
On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> On Wed, Jan 04, 2017 at 11:36:31PM -0200, Eduardo Habkost wrote:
> > On Wed, Jan 04, 2017 at 08:26:27PM -0200, Marcelo Tosatti wrote:
> > > On Wed, Jan 04, 2017 at 05:59:17PM -0200, Eduardo Habkost wrote:
> > > > On Wed, Jan 04, 201
On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote:
> On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> > On Wed, Jan 04, 2017 at 11:36:31PM -0200, Eduardo Habkost wrote:
> > > I am considering two possible scenarios below. You probably have
> > > another scenario in m
On 4 January 2017 at 08:21, Greg Kurz wrote:
> The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2016-12-28
> 17:11:11 +)
>
> are available in the git repository at:
On Thu, Jan 05, 2017 at 12:33:51PM +, Daniel P. Berrange wrote:
> On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote:
> > On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> > > On Wed, Jan 04, 2017 at 11:36:31PM -0200, Eduardo Habkost wrote:
[...]
> > > > Scenario 2
* Peter Xu (pet...@redhat.com) wrote:
> During migration, save state entries are saved/loaded without a specific
> order - we just traverse the savevm_state.handlers list and do it one by
> one. This might not be enough in the future.
>
> There is case that we need to load specific device's vmstat
On Thu, Jan 05, 2017 at 10:48:57AM -0200, Eduardo Habkost wrote:
> On Thu, Jan 05, 2017 at 12:33:51PM +, Daniel P. Berrange wrote:
> > On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote:
> > > On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> > > > On Wed, Jan 04,
On Thu, Jan 05, 2017 at 01:00:32PM +, Daniel P. Berrange wrote:
> On Thu, Jan 05, 2017 at 10:48:57AM -0200, Eduardo Habkost wrote:
> > On Thu, Jan 05, 2017 at 12:33:51PM +, Daniel P. Berrange wrote:
> > > On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote:
> > > > On Thu, Jan 0
Am 05.01.2017 um 11:15 schrieb Li, Liang Z:
If we want to actually host enforce (disallow) access to inflated
pages, having
Is that a new feature?
Still in the design phase. Andrea Arcangeli briefly mentioned in in his reply to
v5 of your patch series
"We also plan to use userfaultfd to make
On Thu, Dec 22, 2016 at 10:57 AM, Paolo Bonzini wrote:
>
>
> On 19/12/2016 17:24, Vincent Palatin wrote:
>> #else /* _WIN32 */
>> -abort();
>> +if (!qemu_cpu_is_self(cpu)) {
>> +CONTEXT context;
>> +if (SuspendThread(cpu->hThread) == (DWORD)(-1)) {
>> +fprintf(
On Thu, Dec 22, 2016 at 10:49 AM, Paolo Bonzini wrote:
>
>
> On 19/12/2016 17:24, Vincent Palatin wrote:
>> diff --git a/cpus.c b/cpus.c
>> index 0e01791..b8db313 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -1264,6 +1264,11 @@ static void qemu_cpu_kick_thread(CPUState *cpu)
>> return;
>>
On 4 January 2017 at 13:34, Stefan Hajnoczi wrote:
> The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2016-12-28
> 17:11:11 +)
>
> are available in the git repositor
Report the error hint when running from the command line and reaching an
error, ex:
$ qemu-system-x86_64 -m 1Z
qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and
terabytes.
Signed-off-by: Marc-André Lureau
---
mo
On 05/01/2017 14:50, Vincent Palatin wrote:
> Sorry I missed it.
> I move it to qemu_cpu_kick() as asked in the Darwin patch.
>
>> Apart from the above change, can you check if there are some less
>> heavyeight methods to force an exit? I can think of QueueUserAPC with
>> an empty pfnAPC here,
Hi
On Wed, Jan 4, 2017 at 11:00 PM Eric Blake wrote:
> On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> > Set errp to report errors up.
> >
> > Use error_report() to give hints about parameters on the right monitor,
> > instead of a direct fprintf() call.
> >
> > Signed-off-by: Marc-André Lure
On 05/01/2017 14:59, Marc-André Lureau wrote:
> Report the error hint when running from the command line and reaching an
> error, ex:
>
> $ qemu-system-x86_64 -m 1Z
> qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size
> You may use k, M, G or T suffixes for kilobytes, megabytes, gigabyte
On 29/11/2016 12:33, Paolo Bonzini wrote:
> bdrv_io_plug and bdrv_io_unplug are only called (via their
> BlockBackend equivalents) after starting asynchronous I/O.
> bdrv_drain is not going to be called while they are running,
> because---even if a coroutine runs for some reason---it will
> only
On 2 January 2017 at 12:44, Seraphime Kirkovski wrote:
> Currently, the cmpxchg implementation tests whether the destination address
> is readable:
> - if it is, we read the value and continue with the comparison
> - if isn't, i.e. access to addr would segfault, we assume that src != dest
>
This patch adds an interface for pacing the execution of QEMU to match an
external
simulation clock. Its aim is to permit QEMU to be used as a module within a
larger simulation system.
Signed-off-by: James J. Nutaro
---
Makefile.target | 3 +
cpus.c | 8 +++
docs/
On 25 December 2016 at 08:25, xiaoqiang zhao wrote:
> Drop the old Sysbus init and use instance_init and
> DeviceClass::realize instead
>
> Signed-off-by: xiaoqiang zhao
> ---
> hw/display/g364fb.c | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/hw/disp
Public bug reported:
When trying to install Radeon crimson relive 16.12.1, each host machine freezes
at the machine environment check stage.
Even if you launch the installer in an environment where GPU is not installed,
each host machine freezes in the same way.
When Gusest's CPU is changed from
Signed-off-by: Laurent Vivier
Reviewed-by: Thomas Huth
Reviewed-by: Greg Kurz
Tested-by: Greg Kurz
---
tests/Makefile.include | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 4841d58..8d6ac7a 100644
--- a/tests/Makefile.include
+++ b/
Only enable for ppc64 in the Makefile, but added
code in the file to check cirrus card only on architectures
supporting it (alpha, mips, i386, x86_64).
Signed-off-by: Laurent Vivier
Reviewed-by: Thomas Huth
Reviewed-by: Greg Kurz
Tested-by: Greg Kurz
---
tests/Makefile.include | 1 +
tests/
This will allow to use it with ppc64.
Signed-off-by: Laurent Vivier
---
tests/ivshmem-test.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index 04a5c5d..8095d72 100644
--- a/tests/ivshmem-test.c
Signed-off-by: Laurent Vivier
---
tests/libqos/pci-spapr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/libqos/pci-spapr.c b/tests/libqos/pci-spapr.c
index 1e5d015..2043f1e 100644
--- a/tests/libqos/pci-spapr.c
+++ b/tests/libqos/pci-spapr.c
@@ -193,8 +193,8 @@ QP
This series enables some tests existing for i386 and which
can also work on ppc64.
VGA tests and netfilter tests are trivial, but ivshmem test
needs to enable the SPAPR PCI framework. We also fix a bug
in qpci_map() for SPAPR, where the PCI base is not correctly
set in the CPU address space.
v2:
On 05/01/2017 16:07, James J. Nutaro wrote:
> This patch adds an interface for pacing the execution of QEMU to match an
> external
> simulation clock. Its aim is to permit QEMU to be used as a module within a
> larger simulation system.
>
> Signed-off-by: James J. Nutaro
What's the difference
The test has been converted to use libqos, we can
now use it on ppc64. We also make the test fail on
all other architectures.
As libqos on ppc64 is not able to manage hotplug
and IRQ/MSI, we disable this part in the test on ppc64.
Signed-off-by: Laurent Vivier
---
tests/Makefile.include | 3 ++-
On 01/05/2017 07:59 AM, Marc-André Lureau wrote:
> Report the error hint when running from the command line and reaching an
> error, ex:
>
> $ qemu-system-x86_64 -m 1Z
> qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size
> You may use k, M, G or T suffixes for kilobytes, megabytes, gigabyt
On 20 December 2016 at 21:26, wrote:
> From: Corey Minyard
>
> Add a return value to the event handler. Some I2C devices will
> NAK if they have no data, so allow them to do this. This required
> the following changes:
>
> Go through all the event handlers and change them to return int
> and r
On 31 December 2016 at 01:18, xiaoqiang zhao wrote:
> Drop the old Sysbus init and use instance_init and
> DeviceClass::realize instead
>
> Signed-off-by: xiaoqiang zhao
> ---
> hw/char/grlib_apbuart.c | 26 +++---
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
> diff
On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> Turn Chardev into Object.
>
> qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It
> will call qemu_char_open() to open/intialize the chardev with the
> ChardevCommon *backend settings.
Review part 2:
> spice-qemu-char.c |
On 01/05/17 04:33, Peter Maydell wrote:
> On 3 January 2017 at 16:18, Sean Bruno wrote:
>> I'm pondering where to start with getting FreeBSD's bsd-user code into
>> shape so it could actually be reviewed and accepted now that its sort of
>> working again (signal handling fixed finally).
>>
>> I
Currently DNS resolution of SocketAddress structs is done as
part of the socket connect/listen process. This is very
inflexible as it assumes that a single SocketAddress struct
will only ever require a single socket to be opened. While
true for connect(), it is not the case for listen() in two
scen
On 01/03/17 09:18, Sean Bruno wrote:
>
> I'm pondering where to start with getting FreeBSD's bsd-user code into
> shape so it could actually be reviewed and accepted now that its sort of
> working again (signal handling fixed finally).
>
> I almost feel like the existing code should be purged,
Currently the QIOTaskFunc signature takes an Object * for
the source, and an Error * for any error. We also need to
be able to provide a result pointer. Rather than continue
to add parameters to QIOTaskFunc, remove the existing
ones and simply pass the QIOTask object instead. This
has methods to ac
On 31 December 2016 at 01:18, xiaoqiang zhao wrote:
> Drop the old Sysbus init and use instance_init and
> DeviceClass::realize instead
>
> Signed-off-by: xiaoqiang zhao
> ---
> hw/char/exynos4210_uart.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
Applied this patc
Incrementing the reference in qio_task_get_source is
not neccessary, since we're not running concurrently
with any other code touching the QIOTask. This
minimizes chances of further memory leaks.
Signed-off-by: Daniel P. Berrange
---
include/io/task.h| 7 ---
io/channel-socket.c | 3 ---
The GDestroyNotify parameter is already a pointer, so does
not need a '*' suffix on the type.
Signed-off-by: Daniel P. Berrange
---
include/io/task.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/io/task.h b/include/io/task.h
index c268eb0..1407747 100644
---
Currently DNS resolution is done automatically as part
of the creation of a QIOChannelSocket object instance.
This works ok for network clients where you just end
up a single network socket, but for servers, the results
of DNS resolution may require creation of multiple
sockets.
Introducing a DNS
Currently there is only a single listener for plain VNC and
a single listener for websockets VNC. This means that is
getaddrinfo() returns multiple IP addresses, for a hostname,
the VNC server can only listen on one of them. This is
just bearable if listening on wildcard interface, or if
the host o
Currently when a task fails, the error is never explicitly
associated with the task object, it is just passed along
through the completion callback. This adds ability to
explicitly associate an error with the task.
Signed-off-by: Daniel P. Berrange
---
include/io/task.h | 29
Add a 'numeric' flag to the InetSocketAddress struct to allow the
caller to indicate that DNS should be skipped for the host/port
fields. This is useful if the caller knows the address is already
numeric and wants to guarantee no (potentially blocking) DNS
lookups are attempted.
Signed-off-by: Dan
Now that task objects have a directly associated error,
there's no need for an an Error **errp parameter to
the QIOTask thread worker function. It already has a
QIOTask object, so can directly set the error on it.
Signed-off-by: Daniel P. Berrange
---
include/io/task.h| 19 +-
The code which interprets the CLI args to populate the SocketAddress
objects for plain & websockets VNC is quite complex already and will
need further enhancements shortly. Refactor it into separate methods
to avoid vnc_display_open getting even larger. As a side effect of
the refactoring, it is no
Currently there is no data associated with a successful
task completion. This adds an opaque pointer to the task
to store an arbitrary result.
Signed-off-by: Daniel P. Berrange
---
include/io/task.h | 27 +++
io/task.c | 20
2 files changed, 4
Currently the VNC authentication info is emitted at the
top level of the query-vnc-servers data. This is wrong
because the authentication scheme differs between plain
and websockets when TLS is enabled. We should instead
report auth against the individual servers. e.g.
(QEMU) query-vnc-servers
{
This change allows the listen address and websocket address
options for -vnc to be repeated. This causes the VNC server
to listen on multiple addresses. e.g.
$ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\
websocket=127.0.0.1:8080,websocket=[::]:8081
results in listening on
127.0
The code which takes a SocketAddress and connects/listens on the
network is going to get more complicated to deal with multiple
listeners. Pull it out into a separate method to avoid making the
vnc_display_open method even more complex.
Signed-off-by: Daniel P. Berrange
---
ui/vnc.c | 122 ++
The QemuOpts parser accepts repeated option names, storing
all the provided values. qemu_opt_get() then just returns
the last value. There is no way to get the other values
without using a callback function to iterate over all
option names. Add a qemu_opt_get_all() method to return
a string list of
V5 failed to build with MinGW, so I had to move the arpa/inet.h to a place
inside the #ifndef block in qqq.c. Also fixed some formatting problems.
Otherwise they are the same. Thanks for your reviews!
Jim
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Thursda
On 5 January 2017 at 16:03, Sean Bruno wrote:
> Ok, this is probably too big for a single patch. I'll see if its
> reasonable to break this up across *some* kind of logic boundary.
Yeah, that's pretty huge. My rough rule of thumb: prefer
each patch to be <500 lines, prefer <20 patches in a patch
The -vnc argument is documented as accepting two syntaxes for
the 'websocket' option, either a bare option name, or a port
number. If using the bare option name, it is supposed to apply
the display number as an offset to base port 5700. e.g.
-vnc localhost:3,websocket
should listen on port 5703
This series is dependant on the IO series just posted to support
DNS resolution separately from socket creation.
There are two core feature changes in this series
- If a DNS name resolves to multiple distinct IP addresses,
the VNC server is now able to listen on all of them
- The -vnc argum
Hi
- Original Message -
> On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> > Turn Chardev into Object.
> >
> > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It
> > will call qemu_char_open() to open/intialize the chardev with the
> > ChardevCommon *backend settings
On 01/05/2017 10:03 AM, Daniel P. Berrange wrote:
> Incrementing the reference in qio_task_get_source is
> not neccessary, since we're not running concurrently
s/neccessary/necessary/
> with any other code touching the QIOTask. This
> minimizes chances of further memory leaks.
>
> Signed-off-by:
Remove the limitation that the VNC server can only listen on
a single resolved IP address. This uses the new DNS resolver
API to resolve a SocketAddress struct into an array of
SocketAddress structs containing raw IP addresses. The VNC
server will then attempt to listen on all resolve IP addresses.
On 01/05/2017 10:03 AM, Daniel P. Berrange wrote:
> Add a 'numeric' flag to the InetSocketAddress struct to allow the
> caller to indicate that DNS should be skipped for the host/port
> fields. This is useful if the caller knows the address is already
> numeric and wants to guarantee no (potentiall
From: Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c.
Signed-off-by: Jianjun Duan
Reviewed-by: Dr. David Alan Gilbert
Message-id: 1481224870-18247-4-git-send-email-du...@linux.vnet.ibm.com
Signed-off-by: Amit Shah
---
tests/test-vmstate.c | 147 +
From: Jianjun Duan
Current migration code cannot handle some data structures such as
QTAILQ in qemu/queue.h. Here we extend the signatures of put/get
in VMStateInfo so that customized handling is supported. put now
will return int type.
Signed-off-by: Jianjun Duan
Reviewed-by: Dr. David Alan Gi
1 - 100 of 240 matches
Mail list logo
