Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 for-2.9 0/6] HPT resizing for pseries guests (qemu part)

2016-12-22 Thread Andrea Bolognani
On Thu, 2016-12-22 at 09:43 +1100, David Gibson wrote: > > The name makes sense, we just need to document the host > > kernel requirement properly. The error message should of > > course mention it as well. > > The error message is currently > > "Hash page table resizing not available with this K

Re: [Qemu-devel] [PULL v1 3/7] crypto: add HMAC algorithms framework

2016-12-22 Thread Daniel P. Berrange
On Thu, Dec 22, 2016 at 09:07:03AM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > Can you pick this patch together ? > [PATCH for-2.9 v4 1/6] configure: add CONFIG_GCRYPT_HMAC item Sigh yes. I don't know how i screwed up and missed that patch. Will send a v2 pull request. Regards, Daniel -- |

Re: [Qemu-devel] [libvirt] Performance about x-data-plane

2016-12-22 Thread Daniel P. Berrange
On Thu, Dec 22, 2016 at 01:34:47AM -0500, Weiwei Jia wrote: > Hi, > > With QEMU x-data-plane, I find the performance has not been improved > very much. Please see following two settings. > > Setting 1: I/O thread in host OS (VMM) reads 4KB each time from disk > (8GB in total). Pin the I/O thread

Re: [Qemu-devel] [libvirt] Cannot add iothreads label in libvirt xml configuration file

2016-12-22 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 12:11:51PM -0500, Weiwei Jia wrote: > Hi, > > I cannot add iothreads > (https://libvirt.org/formatdomain.html#elementsIOThreadsAllocation) in > the libvirt xml configuration file. Once I add > "4" and other related config for IOthreads into > the libvirt xml configuration f

[Qemu-devel] CPU hotplug on Windows 2016 as guest

2016-12-22 Thread Eduardo Otubo
Hi guys, I'm just trying Qemu 2.7 and 2.8 and Windows 2016 as guest and cpu hotplug doesn't seem to be working. CPU appears on qemu device tree, but doesn't appear inside the guest (nor control panel, performance monitor or device manager) Anyone going through this? -- Eduardo Otubo ProfitBrick

[Qemu-devel] A question about PCI device address spaces

2016-12-22 Thread Peter Xu
Hello, Since this is a general topic, I picked it out from the VT-d discussion and put it here, just want to be more clear of it. The issue is, whether we have exposed too much address spaces for emulated PCI devices? Now for each PCI device, we are having PCIDevice::bus_master_as for the device

[Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2016-12-22 Thread Peter Xu
This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU region, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to make sur

Re: [Qemu-devel] [PATCH v5 4/4] hax: add Darwin support

2016-12-22 Thread Paolo Bonzini
On 19/12/2016 17:24, Vincent Palatin wrote: > diff --git a/cpus.c b/cpus.c > index 0e01791..b8db313 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1264,6 +1264,11 @@ static void qemu_cpu_kick_thread(CPUState *cpu) > return; > } > cpu->thread_kicked = true; > +#ifdef CONFIG_DARWIN >

Re: [Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2016-12-22 Thread Jason Wang
On 2016年12月22日 17:48, Peter Xu wrote: /* Handle Translation Enable/Disable */ static void vtd_handle_gcmd_te(IntelIOMMUState *s, bool en) { +if (s->dmar_enabled == en) { +return; +} + VTD_DPRINTF(CSR, "Translation Enable %s", (en ? "on" : "off")); if (en) {

Re: [Qemu-devel] [PATCH 1/4] ramblock-notifier: new

2016-12-22 Thread Paolo Bonzini
> diff --git a/xen-mapcache.c b/xen-mapcache.c > index 8f3a592..dc9b321 100644 > --- a/xen-mapcache.c > +++ b/xen-mapcache.c > @@ -163,6 +163,7 @@ static void xen_remap_bucket(MapCacheEntry *entry, > err = g_malloc0(nb_pfn * sizeof (int)); > > if (entry->vaddr_base != NULL) { > +

Re: [Qemu-devel] [PATCH v5 3/4] Plumb the HAXM-based hardware acceleration support

2016-12-22 Thread Paolo Bonzini
On 19/12/2016 17:24, Vincent Palatin wrote: > #else /* _WIN32 */ > -abort(); > +if (!qemu_cpu_is_self(cpu)) { > +CONTEXT context; > +if (SuspendThread(cpu->hThread) == (DWORD)(-1)) { > +fprintf(stderr, "qemu:%s: GetLastError:%lu\n", __func__, > +

Re: [Qemu-devel] [PATCH v6 06/17] qapi: rework qapi Exception

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Use a base class QAPIError, and QAPIParseError for parser errors and > QAPISemError for semantic errors, suggested by Markus Armbruster. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 338 > ++-- >

Re: [Qemu-devel] [PATCH v6 07/17] qapi: use a QAPIParseError in parser

2016-12-22 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 13 +++-- > tests/qapi-schema/include-cycle.err | 2 +- > tests/qapi-schema/include-format-err.err | 2 +- > tests/qapi-schema/include-no-file.err| 2 +- > tests/q

Re: [Qemu-devel] [PATCH RFC v2 0/4] block/qapi: refactor and optimize the qmp_query_blockstats()

2016-12-22 Thread Dou Liyang
At 12/21/2016 07:06 PM, Stefan Hajnoczi wrote: On Wed, Dec 21, 2016 at 05:13:39PM +0800, Dou Liyang wrote: Hi Stefan, At 12/20/2016 05:39 PM, Stefan Hajnoczi wrote: On Tue, Dec 20, 2016 at 12:32:40AM +0800, Fam Zheng wrote: On Mon, 12/19 15:02, Stefan Hajnoczi wrote: On Mon, Dec 19, 2016 a

Re: [Qemu-devel] A question about PCI device address spaces

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 10:42, Peter Xu wrote: > Hello, > > Since this is a general topic, I picked it out from the VT-d > discussion and put it here, just want to be more clear of it. > > The issue is, whether we have exposed too much address spaces for > emulated PCI devices? > > Now for each PCI devi

Re: [Qemu-devel] [PATCH for-2.9 07/10] memhp: move GPE handler_E03 into build_memory_hotplug_aml()

2016-12-22 Thread Marcel Apfelbaum
On 12/21/2016 03:39 PM, Igor Mammedov wrote: On Wed, 21 Dec 2016 14:31:45 +0200 Marcel Apfelbaum wrote: On 12/06/2016 01:32 AM, Igor Mammedov wrote: From this patch all the memory hotplug related AML bits are consolidated in one place within DSTD. Follow up patches will utilize that to simpli

[Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016-12-21

2016-12-22 Thread Daniel P. Berrange
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: Open 2.9 development tree (2016-12-20 16:20:16 +) are available in the git repository at: git://github.com/berrange/qemu pull-qcrypto-2016-12-21-2 for you to fetch changes up to 4fd460bf25b197f94b9db463b77a6943

[Qemu-devel] [PULL v2 2/8] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede support when using libgcrypt or nettle. Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/cipher-gcrypt.c | 6 +++ crypto/cipher-nettle.c | 37 +++

[Qemu-devel] [PULL v2 1/8] cipher: fix leak on initialization error

2016-12-22 Thread Daniel P. Berrange
From: Marc-André Lureau On error path, ctx may be leaked. Assign ctx earlier, and call qcrypto_cipher_free() on error. Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- crypto/cipher-nettle.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions

[Qemu-devel] [PULL v2 8/8] crypto: add HMAC algorithms testcases

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add HMAC algorithms testcases Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- tests/Makefile.include | 2 + tests/test-crypto-hmac.c | 266 +++ 2 files changed, 268 insertions(+) create mode

[Qemu-devel] [PULL v2 5/8] crypto: support HMAC algorithms based on libgcrypt

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add HMAC algorithms based on libgcrypt support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-gcrypt.c | 111 ++- 1 file changed, 109 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PULL v2 4/8] crypto: add HMAC algorithms framework

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch introduce HMAC algorithms framework. Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs | 4 ++ crypto/hmac-gcrypt.c | 45 ++ crypto/hmac-glib.c | 44 ++ crypto/hmac-nettle.c | 45 ++

[Qemu-devel] [PULL v2 3/8] configure: add CONFIG_GCRYPT_HMAC item

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This item will be used for support libcrypt-backed HMAC algorithms. Support for hmac has been added in Libgcrypt 1.6.0, but we cannot use pkg-config to get libcrypt's version. However we can make a in configure to know whether current libcrypt support hmac. Signed-off-by:

[Qemu-devel] [PULL v2 6/8] crypto: support HMAC algorithms based on glib

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add glib-backed HMAC algorithms support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-glib.c | 122 + 1 file changed, 122 insertions(+) diff --git a/crypto/hmac-glib.c b/cr

[Qemu-devel] [PULL v2 7/8] crypto: support HMAC algorithms based on nettle

2016-12-22 Thread Daniel P. Berrange
From: "Longpeng(Mike)" This patch add nettle-backed HMAC algorithms support Signed-off-by: Longpeng(Mike) Signed-off-by: Daniel P. Berrange --- crypto/hmac-nettle.c | 136 +-- 1 file changed, 133 insertions(+), 3 deletions(-) diff --git a/crypt

Re: [Qemu-devel] [PATCH for-2.9 09/10] memhp: don't generate memory hotplug AML if it's not enabled/supported

2016-12-22 Thread Marcel Apfelbaum
On 12/06/2016 01:32 AM, Igor Mammedov wrote: That reduces DSDT by 910 bytes when memory hotplug isn't enabled. While doing so drop intermediate variables/arguments passing around ACPI_MEMORY_HOTPLUG_IO_LEN and making it local to memory_hotplug.c, hardcoding it there as it can't change. Also don

[Qemu-devel] [Bug 1652011] [NEW] VM shuts down due to error in qemu block.c

2016-12-22 Thread Andrew Parker
Public bug reported: On a Trusty KVM host one of the guest VMs shut down without any user interaction. The system is running: $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=14.04 DISTRIB_CODENAME=trusty DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS" $ dpkg -l libvirt0 qemu-kvm qemu-system-co

Re: [Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2016-12-22 Thread Peter Xu
On Thu, Dec 22, 2016 at 05:52:58PM +0800, Jason Wang wrote: > > > On 2016年12月22日 17:48, Peter Xu wrote: > > /* Handle Translation Enable/Disable */ > > static void vtd_handle_gcmd_te(IntelIOMMUState *s, bool en) > > { > >+if (s->dmar_enabled == en) { > >+return; > >+} > >+ > >

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 00/14] VT-d unit test

2016-12-22 Thread Andrew Jones
Alex, Are you happy with v8? If so, then, as far as I'm concerned, this series is ready. I'd like to try driving the edu device from ARM tests too. Thanks, drew On Mon, Dec 12, 2016 at 11:08:06AM +0800, Peter Xu wrote: > This is v8 of vt-d unit test series. > > (CC qemu-devel list this time.)

Re: [Qemu-devel] [PATCH v3] intel_iommu: allow dynamic switch of IOMMU region

2016-12-22 Thread Jason Wang
On 2016年12月22日 19:04, Peter Xu wrote: On Thu, Dec 22, 2016 at 05:52:58PM +0800, Jason Wang wrote: On 2016年12月22日 17:48, Peter Xu wrote: /* Handle Translation Enable/Disable */ static void vtd_handle_gcmd_te(IntelIOMMUState *s, bool en) { +if (s->dmar_enabled == en) { +retur

Re: [Qemu-devel] [PULL V2 1/3] record/replay: add network support

2016-12-22 Thread Jason Wang
On 2016年12月22日 14:56, Pavel Dovgalyuk wrote: Hi, Jason! Please don't forget this for 2.9. Pavel Dovgalyuk Already in my queue so it won't be missed :) Thanks

Re: [Qemu-devel] [kvm-unit-tests PATCH v8 00/14] VT-d unit test

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 12:06, Andrew Jones wrote: > Alex, > > Are you happy with v8? If so, then, as far as I'm concerned, this > series is ready. I'd like to try driving the edu device from ARM > tests too. > > Thanks, > drew There are some minor conflicts, but nothing that I cannot fix. I've pushed

Re: [Qemu-devel] [PULL 0/1] Move target-xxx folders to target/ folder

2016-12-22 Thread Peter Maydell
On 20 December 2016 at 21:16, Thomas Huth wrote: > The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: > > Open 2.9 development tree (2016-12-20 16:20:16 +) > > are available in the git repository at: > > https://github.com/huth/qemu.git tags/target-dirs-20161220 >

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Marcel Apfelbaum
On 12/06/2016 01:32 AM, Igor Mammedov wrote: Move DIMM devices from global _SB scope to a new \_SB.MHPC container along with common methods used by DIMMs: MCRS, MRST, MPXM, MOST, MEJ00, MSCN, MTFY this reduces AML size on 12 * #slots bytes, i.e. up to 3072 bytes for 265 slots. Can you pleas

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Holger Schranz
Hi Fam, You win !!! I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which is based on kernel 4.4. Both system see the tape devices and can work. Than I restart in the same session the VM with SLES11 SP4 (kernel 3.0.101) and an older RH based on kernel 2.6. This both system c

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 13:37, Kirill A. Shutemov wrote: > On Fri, Dec 16, 2016 at 01:59:36PM +0100, Paolo Bonzini wrote: >> >> >> On 15/12/2016 01:13, Kirill A. Shutemov wrote: >>> The new paging more is extension of IA32e mode with more additional page >>> table level. >>> >>> It brings support of 57-bit

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-22 Thread Kirill A. Shutemov
On Fri, Dec 16, 2016 at 01:59:36PM +0100, Paolo Bonzini wrote: > > > On 15/12/2016 01:13, Kirill A. Shutemov wrote: > > The new paging more is extension of IA32e mode with more additional page > > table level. > > > > It brings support of 57-bit vitrual address space (128PB) and 52-bit > > physi

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread addr_cc
On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)" >>> is always succeeds. So, Can you suggest to me the right name? >> If replication_get_error_all() always succeeds, then w

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread Eric Blake
[resend, I don't know how I botched the From: line in my first attempt, or if that botch changed who received the mail] On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)" >>

Re: [Qemu-devel] CPU hotplug on Windows 2016 as guest

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 10:40:29 +0100 Eduardo Otubo wrote: > Hi guys, > > I'm just trying Qemu 2.7 and 2.8 and Windows 2016 as guest and cpu > hotplug doesn't seem to be working. CPU appears on qemu device tree, but > doesn't appear inside the guest (nor control panel, performance monitor > or devi

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Fam Zheng
On Thu, 12/22 13:33, Holger Schranz wrote: > Hi Fam, > > You win !!! > > I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which > is based on kernel 4.4. Both system see the tape devices and can work. > Than I restart in the same session the VM with SLES11 SP4 (kernel 3.0.101)

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 14:31:19 +0200 Marcel Apfelbaum wrote: > On 12/06/2016 01:32 AM, Igor Mammedov wrote: > > Move DIMM devices from global _SB scope to a new \_SB.MHPC > > container along with common methods used by DIMMs: > > MCRS, MRST, MPXM, MOST, MEJ00, MSCN, MTFY > > > > this reduces AML

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Marcel Apfelbaum
On 12/22/2016 03:31 PM, Igor Mammedov wrote: On Thu, 22 Dec 2016 14:31:19 +0200 Marcel Apfelbaum wrote: On 12/06/2016 01:32 AM, Igor Mammedov wrote: Move DIMM devices from global _SB scope to a new \_SB.MHPC container along with common methods used by DIMMs: MCRS, MRST, MPXM, MOST, MEJ00, M

[Qemu-devel] [PATCH] vexpress fix flash device-width

2016-12-22 Thread David Engraf
The current implementation uses width = 4 and device-width = 2 for the flash configuration. When using u-boot or Linux, the flash is detected as 32 x 16 bit, thus the sector size is doubled to 512 KB. When u-boot sends a sector erase, only the first 256 KB are erased because the QEMU flash impl

Re: [Qemu-devel] [PATCH for-2.9 10/10] memhp: move DIMM devices into dedicated scope with related common methods

2016-12-22 Thread Igor Mammedov
On Thu, 22 Dec 2016 15:53:55 +0200 Marcel Apfelbaum wrote: > On 12/22/2016 03:31 PM, Igor Mammedov wrote: > > On Thu, 22 Dec 2016 14:31:19 +0200 > > Marcel Apfelbaum wrote: > > > >> On 12/06/2016 01:32 AM, Igor Mammedov wrote: > >>> Move DIMM devices from global _SB scope to a new \_SB.MHPC

Re: [Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?

2016-12-22 Thread Corey Minyard
On 12/19/2016 09:47 AM, dcb wrote: Public bug reported: I just had a go at compiling qemu trunk with llvm trunk. It said: hw/ipmi/isa_ipmi_bt.c:283:31: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] Source code is IP

[Qemu-devel] [Bug 1651167] Re: hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?

2016-12-22 Thread cminyard
** Changed in: qemu Assignee: (unassigned) => cminyard (minyard) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1651167 Title: hw/ipmi/isa

[Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread minyard
From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Reported in https://bugs.launchpad.net/bugs/1651167 Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi_bt.c | 18 +- 1 file changed, 9 insertions(+), 9 delet

[Qemu-devel] QEMU for RISC6000

2016-12-22 Thread giancarlo teodori
Hi, I'm working to emulate aix SO on RISC6000 environment using qemu emulator. I tried to import related patch ([RFC,2/6] prep: add IBM RS/6000 7248 (43p) machine emulation), but this operation give me an error. I'm using a wrong release of qemu code? Do you know a version of qemu already integrat

Re: [Qemu-devel] [PATCH v4 1/2] pcie_aer: Convert pcie_aer_init to Error

2016-12-22 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 21 Dec 2016, at 10:21 AM, Cao jin wrote: > > When user specify invalid value for property aer_log_max, device should > fail to create, and report appropriate message. > > Signed-off-by: Cao jin > Reviewed-by: Marcel Apfelbaum > Acked-by: Dmitry Fleytman > ---

Re: [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread Eric Blake
On 12/22/2016 08:30 AM, miny...@acm.org wrote: > From: Corey Minyard > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Reported in https://bugs.launchpad.net/bugs/1651167 > > Signed-off-by: Corey Minyard > --- > hw/ipmi/isa_ipmi_bt.

[Qemu-devel] [PATCH for-2.9 v2 07/10] memhp: move GPE handler_E03 into build_memory_hotplug_aml()

2016-12-22 Thread Igor Mammedov
build hotplug event handler method body in generic hw/acpi/memory_hotplug.c and make hw/i386/acpi-build.c only provide target specific full name of the event handler. That removes hardcoded MEMORY_HOTPLUG_HANDLER_PATH and allows to do target specific memory hotplug AML placement and wiring it with

[Qemu-devel] [PATCH] smbios: filter based on CONFIG_SMBIOS rather than TARGET

2016-12-22 Thread Leif Lindholm
-smbios command line options were accepted but silently ignored on TARGET_ARM, due to a test for TARGET_I386 in arch_init.c. Copy the mechanism of hw/pci/pci-stub.c to implement an smbios-stub instead, enabled for all targets without CONFIG_SMBIOS. Signed-off-by: Leif Lindholm --- Not sure if S

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-22 Thread Leif Lindholm
On Wed, Dec 21, 2016 at 06:58:44PM +0100, Paolo Bonzini wrote: > On 21/12/2016 14:59, Igor Mammedov wrote: > >> Apparently a misunderstanding of the underlying command line handling > >> mechanics. > >> > >>> Also this patch would break build for targets that don't link smbios.c > >>> (i.e. which d

[Qemu-devel] [PULL 04/25] exec: introduce MemoryRegionCache

2016-12-22 Thread Paolo Bonzini
Device models often have to perform multiple access to a single memory region that is known in advance, but would to use "DMA-style" functions instead of address_space_map/unmap. This can happen for example when the data has to undergo endianness conversion. Introduce a new data structure to cache

[Qemu-devel] [PULL 13/25] block: drop remaining legacy aio functions in comment

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai Commit 87f68d318222563822b5c6b28192215fc4b4e441 (block: drop aio functions that operate on the main AioContext) drops qemu_aio_wait function references mostly while leaves these behind, clean up them. Signed-off-by: Yaowei Bai Message-Id: <1480566640-27264-3-git-send-email-baiy

[Qemu-devel] [PULL 06/25] rules.mak: speedup save-vars load-vars

2016-12-22 Thread Paolo Bonzini
Unnesting variables spends a lot of time parsing and executing foreach and if functions. Because actually very few variables have to be saved and restored, a good strategy is to remember what has to be done in load-vars, and only iterate the right variables in load-vars. For save-vars, unroll the

[Qemu-devel] [PULL 05/25] watchdog: 6300esb: add exit function

2016-12-22 Thread Paolo Bonzini
From: Li Qiang When the Intel 6300ESB watchdog is hot unplug. The timer allocated in realize isn't freed thus leaking memory leak. This patch avoid this through adding the exit function. Signed-off-by: Li Qiang Message-Id: <583cde9c.3223ed0a.7f0c2.8...@mx.google.com> Signed-off-by: Paolo Bonzin

[Qemu-devel] [PULL 02/25] exec: introduce memory_ldst.inc.c

2016-12-22 Thread Paolo Bonzini
Templatize the address_space_* and *_phys functions, so that we can add similar functions in the next patch that work with a lightweight, cache-like version of address_space_map/unmap. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- exec.c| 681 +---

[Qemu-devel] [PULL 14/25] target-i386: Add Intel SHA_NI instruction support.

2016-12-22 Thread Paolo Bonzini
From: Yi Sun Add SHA_NI feature bit. Its spec can be found at: https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf Signed-off-by: Yi Sun Message-Id: <1481683803-10051-1-git-send-email-yi.y@linux.intel.com> Signed-off-by: Paolo Bonzini --- target/i

[Qemu-devel] [PULL 01/25] exec: optimize remaining address_space_* cases

2016-12-22 Thread Paolo Bonzini
Do them right before the next patch generalizes them into a multi-included file. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- exec.c | 126 + 1 file changed, 103 insertions(+), 23 deletions(-) diff --git a/exec.c

[Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

2016-12-22 Thread Paolo Bonzini
The following changes since commit d1e8e8ecc3d2a1a72504912d671f1cbbac1b06e5: Merge remote-tracking branch 'remotes/huth/tags/target-dirs-20161220' into staging (2016-12-21 21:11:48 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL 19/25] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-22 Thread Paolo Bonzini
From: Vlad Lungu get_opt_value() truncates the value at the first comma Use memcpy() instead so that -append works correctly in the presence of commas. For -initrd to work right, instead, unescape the module filename and parameters with get_opt_value() before calling mb_add_cmdline(). Signed-of

[Qemu-devel] [PULL 10/25] qemu-timer: check active_timers outside lock/event

2016-12-22 Thread Paolo Bonzini
This avoids taking the active_timers_lock or resetting/setting the timers_done_ev if there are no active timers. This removes a small (2-3%) source of overhead for dataplane. The list is then checked again inside the lock, or a NULL pointer could be dereferenced. Reviewed-by: Stefan Hajnoczi Si

[Qemu-devel] [PULL 03/25] exec: introduce address_space_extend_translation

2016-12-22 Thread Paolo Bonzini
This extracts the common part of address_space_map and address_space_cache_init into a new function. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- exec.c | 50 +- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/exec

[Qemu-devel] [PULL 17/25] pc: make pit configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-4-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 21 - hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 3 ++- include/hw/i386/pc.h | 3 +++ 4 f

[Qemu-devel] [PULL 08/25] build-sys: remove libtool left-over

2016-12-22 Thread Paolo Bonzini
From: Marc-André Lureau Libtool support was removed in commit e999ee44349, there is a few left-over. Signed-off-by: Marc-André Lureau Message-Id: <20161108070513.30274-1-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- .gitignore| 4 Makefile | 9 +++-- Makefile

[Qemu-devel] [PULL 20/25] hw/block/pflash_cfi*.c: fix confusing assert fail message

2016-12-22 Thread Paolo Bonzini
From: Ziyue Yang The patch is to fix the confusing assert fail message caused by un-initialized device structure (from bite sized tasks). The bug can be reproduced by ./qemu-system-x86_64 -nographic -device cfi.pflash01 The CFI hardware is dynamically loaded by QOM realizing mechanism, however

[Qemu-devel] [PULL 07/25] rules.mak: add more rules to avoid chaining

2016-12-22 Thread Paolo Bonzini
Really rule chaining is not a particularly expensive task, since GNU Make caches the directory listing. However it is easy to avoid it for most files and for phony targets (one was missing). After this patch, only "Makefile", "scripts/hxtool" and "scripts/create_config" attempt to use chained rul

[Qemu-devel] [PULL 18/25] x86: Fix x86_64 'g' packet response to gdb from 32-bit mode.

2016-12-22 Thread Paolo Bonzini
From: Doug Evans The remote protocol can't handle flipping back and forth between 32-bit and 64-bit regs. To compensate, pretend "as if" on 64-bit cpu when in 32-bit mode. Signed-off-by: Doug Evans Reviewed-by: Richard Henderson Message-Id: <001a113dca8274572005406e0...@google.com> Signed-off-

[Qemu-devel] [PULL 09/25] virtio-scsi: introduce virtio_scsi_acquire/release

2016-12-22 Thread Paolo Bonzini
These will be used more as soon as the acquire/release is pushed down to the ioeventfd handlers. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff -

[Qemu-devel] [PULL 11/25] timer: fix misleading comment in timer.h

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai It's timer to expire, not clock. Signed-off-by: Yaowei Bai Message-Id: <1480566640-27264-1-git-send-email-baiyao...@cmss.chinamobile.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- include/qemu/timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 12/25] main-loop: update comment for qemu_mutex_lock/unlock_iothread

2016-12-22 Thread Paolo Bonzini
From: Yaowei Bai Commit 49cf57281b7 (vl: delay thread initialization after daemonization) makes the global mutex is taken after daemonization instead before daemonization by qemu_init_main_loop(). Signed-off-by: Yaowei Bai Message-Id: <1480566640-27264-2-git-send-email-baiyao...@cmss.chinamobil

[Qemu-devel] [PULL 21/25] scsi-disk: fix VERIFY for scsi-block

2016-12-22 Thread Paolo Bonzini
When a scsi-disk object receives VERIFY command with BYTCHK bit being zero, scsi_block_is_passthrough returns false and finally makes req being proceeded by scsi_block_dma_command. Because scsi_block_dma_command has removed process of VERIFY, QEMU will abort in this function. Reported-by: Junlian

[Qemu-devel] [PULL 15/25] pc: make smbus configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-2-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 18 ++ hw/i386/pc_q35.c | 12 +++- include/hw/i386/pc.h | 2 ++ 3 files changed, 27 insertio

[Qemu-devel] [PULL 16/25] pc: make sata configurable

2016-12-22 Thread Paolo Bonzini
From: Chao Peng Signed-off-by: Chao Peng Message-Id: <1478330391-74060-3-git-send-email-chao.p.p...@linux.intel.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 29 - hw/i386/pc_q35.c | 24 ++-- include/hw/i386/pc.h | 2 ++ 3 fil

[Qemu-devel] [PULL 22/25] kvm: sync linux headers

2016-12-22 Thread Paolo Bonzini
From: Marcelo Tosatti Import KVM_CLOCK_TSC_STABLE. Signed-off-by: Marcelo Tosatti Message-Id: <20161210172324.402794...@redhat.com> Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input.h| 1 + include/standard-headers/linux/pci_regs.h | 15 ++- linux-headers

[Qemu-devel] [PULL 23/25] kvmclock: reduce kvmclock difference on migration

2016-12-22 Thread Paolo Bonzini
From: Marcelo Tosatti Check for KVM_CAP_ADJUST_CLOCK capability KVM_CLOCK_TSC_STABLE, which indicates that KVM_GET_CLOCK returns a value as seen by the guest at that moment. For new machine types, use this value rather than reading from guest memory. This reduces kvmclock difference on migratio

Re: [Qemu-devel] [PATCH] smbios: filter based on CONFIG_SMBIOS rather than TARGET

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 16:18, Leif Lindholm wrote: > -smbios command line options were accepted but silently ignored on > TARGET_ARM, due to a test for TARGET_I386 in arch_init.c. > > Copy the mechanism of hw/pci/pci-stub.c to implement an smbios-stub > instead, enabled for all targets without CONFIG_SMB

[Qemu-devel] [PULL 24/25] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-22 Thread Paolo Bonzini
From: Doug Evans The syscall and sysret instructions behave a bit differently: TF is checked after the instruction completes. This allows the o/s to disable #DB at a syscall by adding TF to FMASK. And then when the sysret is executed the #DB is taken "as if" the syscall insn just completed. Sign

[Qemu-devel] [PULL 25/25] x86: implement la57 paging mode

2016-12-22 Thread Paolo Bonzini
From: "Kirill A. Shutemov" The new paging more is extension of IA32e mode with more additional page table level. It brings support of 57-bit vitrual address space (128PB) and 52-bit physical address space (4PB). The structure of new page table level is identical to pml4. The feature is enumera

Re: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9

2016-12-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 20161222152300.32395-1-pbonz...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/25] First round of misc patches for QEMU 2.9 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 to

[Qemu-devel] [PATCH 02/11] stubs: move smbios stubs to hw/smbios

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/smbios/Makefile.objs | 11 --- stubs/smbios_type_38.c => hw/smbios/smbios_type_38-stub.c | 0 stubs/Makefile.objs

[Qemu-devel] [PATCH 04/11] stubs: remove unused stub for serial_hd

2016-12-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 1 - stubs/get-next-serial.c | 4 2 files changed, 5 deletions(-) delete mode 100644 stubs/get-next-serial.c diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs index c4df915..5b3e7c6 100644 --- a/stubs/Makefile.objs +++ b/stubs

[Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
This moves out of libqemustub.a those functions which can be handled simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. libqemustub.a keep the more complex cases where a small part of the executables we build needs an implementation of a small subset of an API. Paolo Paolo B

[Qemu-devel] [PATCH 01/11] stubs: merge all monitor stubs in one file, remove monitor_cur_is_qmp stub

2016-12-22 Thread Paolo Bonzini
monitor_cur_is_qmp was previously used by other stubs, but it's not since 397d30e ("qemu-error: remove dependency of stubs on monitor", 2016-11-01). Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 4 +--- stubs/mon-is-qmp.c| 10 -- stubs/monitor-init.c

[Qemu-devel] [PATCH 03/11] stubs: move acpi stubs to hw/acpi

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/acpi/Makefile.objs | 12 stubs/ipmi.c => hw/acpi/ipmi-stub.c | 0 stubs/Makefile.objs | 1 - 3 files changed, 8 insertions(+), 5 delet

[Qemu-devel] [PATCH 05/11] hw: move reset handlers from vl.c to hw/core

2016-12-22 Thread Paolo Bonzini
They are small, it is not worth stubbing them. Just include them in user-mode emulators and unit tests as well. Signed-off-by: Paolo Bonzini --- hw/core/Makefile.objs | 2 +- hw/core/reset.c | 72 + include/hw/hw.h | 6 + i

[Qemu-devel] [PATCH 06/11] stubs: group stubs for user-mode emulation

2016-12-22 Thread Paolo Bonzini
Some stubs are used for user-mode emulation only; they are not needed by tools. Move them out of stubs/. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 1 + Makefile.target | 4 ++-- stubs/Makefile.objs | 2 -- stubs/cpus.c| 11 --- stubs/replay-user.c | 33 --

[Qemu-devel] [PATCH 11/11] stubs: remove stubs/kvm.c

2016-12-22 Thread Paolo Bonzini
This has a single function, just move it to the other target/*/kvm.c files. Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 1 - stubs/kvm.c | 8 target/mips/kvm.c | 5 + target/ppc/kvm.c| 5 + target/s390x/kvm.c | 5 + 5 files changed, 15 insertions(+)

[Qemu-devel] [PATCH 07/11] stubs: group all monitor_fdset_* functions in a single file

2016-12-22 Thread Paolo Bonzini
It makes little sense to implement only one of them, so avoid proliferation of stubs files. Signed-off-by: Paolo Bonzini --- stubs/Makefile.objs | 5 + stubs/fdset-add-fd.c| 8 stubs/fdset-find-fd.c | 8 stubs/fdset-get-fd.c| 8 stubs/fdset-remove

[Qemu-devel] [PATCH 09/11] event_notifier: cleanups around event_notifier_set_handler

2016-12-22 Thread Paolo Bonzini
EventNotifiers are already supported by AioContext, so reuse that in iohandler.c and remove the useless is_external argument. Since the iohandler AioContext is never used for block devices, aio_disable_external is never called on it. This lets us remove stubs/iohandler.c. Signed-off-by: Paolo Bo

[Qemu-devel] [PATCH 10/11] build: remove --enable-colo/--disable-colo

2016-12-22 Thread Paolo Bonzini
No need to provide this knob, just enable COLO unconditionally. Remove the configure option as well as stubs/migration-colo.c. Signed-off-by: Paolo Bonzini --- configure | 11 --- migration/Makefile.objs | 3 +-- stubs/Makefile.objs | 1 - stubs/migration-colo.c | 46

[Qemu-devel] [PATCH 08/11] stubs: move vhost stubs to stubs/vhost.o

2016-12-22 Thread Paolo Bonzini
No need to include them in libqemustub.a, since only system emulators need them. Signed-off-by: Paolo Bonzini --- hw/Makefile.objs| 2 +- hw/virtio/Makefile.objs | 6 +- stubs/vhost.c => hw/virtio/vhost-stub.c | 0 stubs/Makefile.objs

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 13:33, Holger Schranz wrote: > > > I have installed an RH 7.7 based on kernel 3.10 and a SuSE LEAP 42.2 which > is based on kernel 4.4. Both system see the tape devices and can work. > Than I restart in the same session the VM with SLES11 SP4 (kernel 3.0.101) > and an older RH bas

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Peter Maydell
On 22 December 2016 at 15:59, Paolo Bonzini wrote: > This moves out of libqemustub.a those functions which can be handled > simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. > libqemustub.a keep the more complex cases where a small part of the > executables we build needs an

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 18:30, Peter Maydell wrote: > On 22 December 2016 at 15:59, Paolo Bonzini wrote: >> This moves out of libqemustub.a those functions which can be handled >> simply by $(call lnot), like we already do for pci-stub.c or kvm-stub.c. >> libqemustub.a keep the more complex cases where a

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Eduardo Habkost
On Thu, Dec 22, 2016 at 06:32:24PM +0100, Paolo Bonzini wrote: > > > On 22/12/2016 18:30, Peter Maydell wrote: > > On 22 December 2016 at 15:59, Paolo Bonzini wrote: > >> This moves out of libqemustub.a those functions which can be handled > >> simply by $(call lnot), like we already do for pci-

Re: [Qemu-devel] [RFC PATCH 00/11] Stubs cleanup

2016-12-22 Thread Paolo Bonzini
On 22/12/2016 18:42, Eduardo Habkost wrote: > On Thu, Dec 22, 2016 at 06:32:24PM +0100, Paolo Bonzini wrote: >> >> >> On 22/12/2016 18:30, Peter Maydell wrote: >>> On 22 December 2016 at 15:59, Paolo Bonzini wrote: This moves out of libqemustub.a those functions which can be handled si

Re: [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters

2016-12-22 Thread Corey Minyard
On 12/22/2016 09:01 AM, Eric Blake wrote: On 12/22/2016 08:30 AM, miny...@acm.org wrote: From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Reported in https://bugs.launchpad.net/bugs/1651167 Signed-off-by: Corey Minyard

  1   2   >