Re: [Qemu-devel] Lock contention in QEMU

2016-12-19 Thread Weiwei Jia
Got it. Thank you very much. Best, Weiwei Jia On Mon, Dec 19, 2016 at 5:58 AM, Stefan Hajnoczi wrote: > On Fri, Dec 16, 2016 at 04:42:54PM -0500, Weiwei Jia wrote: >> Has x-data-plane been used (or accepted) widely in systems. I have >> this concern since if it hasn't been widely accepted, it ma

[Qemu-devel] [Bug 682326] Re: linux-user/mmap exhaustion

2016-12-19 Thread Thomas Huth
Triaging old bug tickets ... do you still have this issue with the latest version of QEMU? If so, could you please discuss the patch on the qemu-devel mailing list? (since we do not take patches from the bugtracker) ** Changed in: qemu Status: New => Incomplete -- You received this bug no

[Qemu-devel] [Bug 597575] Re: Hangs on HTTP errors when using the curl block driver

2016-12-19 Thread Thomas Huth
QEMU 0.11 / 0.12 are pretty much outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

Re: [Qemu-devel] any known virtio-net regressions in Qemu 2.7?

2016-12-19 Thread Stefan Priebe - Profihost AG
Am 19.12.2016 um 12:03 schrieb Stefan Hajnoczi: > On Fri, Dec 16, 2016 at 10:00:36PM +0100, Stefan Priebe - Profihost AG wrote: >> >> Am 15.12.2016 um 07:46 schrieb Alexandre DERUMIER: >>> does rollbacking the kernel to previous version fix the problem ? >> >> The culprit is the used tuned agent f

[Qemu-devel] [Bug 682360] Re: Unaccessible memory

2016-12-19 Thread Thomas Huth
QEMU 0.13 is pretty much outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

[Qemu-devel] [Bug 1251470] Re: Guest not working in KVM mode but does in TCG mode

2016-12-19 Thread Thomas Huth
According to comment #3, this bug has been fixed, so I'm closing this ticket now. If you can still reproduce this issue with the latest version from QEMU, please feel free to open this ticket again. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification beca

[Qemu-devel] [Bug 697510] Re: Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2016-12-19 Thread Thomas Huth
Triaging old bug tickets ... do you still have this problem with the latest version of QEMU, or could we close this bug nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-19 Thread Leif Lindholm
So, in addition to the style issue I was automatically notified of, I also neglected to CC the appropriate people - adding them here. As for the style issue - is it more important to adhere to checkpatch.pl or to surrounding definitions? Regards, Leif On Fri, Dec 16, 2016 at 03:23:19PM +, L

Re: [Qemu-devel] Is block_save_iterate() dead code?

2016-12-19 Thread John Snow
On 12/19/2016 11:30 AM, Thomas Huth wrote: > On 16.12.2016 18:03, Dr. David Alan Gilbert wrote: >> * Thomas Huth (th...@redhat.com) wrote: >>> On 18.11.2016 09:13, Thomas Huth wrote: On 17.11.2016 04:45, David Gibson wrote: > On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote:

Re: [Qemu-devel] [PATCHv3] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-19 Thread Eduardo Habkost
On Mon, Dec 19, 2016 at 11:35:34AM +0200, Vlad Lungu wrote: > On 12/18/2016 10:25 PM, Eduardo Habkost wrote: > > On Thu, Dec 15, 2016 at 02:32:04PM +0200, Vlad Lungu wrote: > >> get_opt_value() truncates the value at the first comma > >> Use memcpy() instead > >> Unescape the module filename and pa

Re: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-19 Thread Eduardo Habkost
On Mon, Dec 19, 2016 at 11:41:47AM +0200, Vlad Lungu wrote: > get_opt_value() truncates the value at the first comma > Use memcpy() instead > Unescape the module filename and parameters with get_opt_value() > before calling mb_add_cmdline() > > Signed-off-by: Vlad Lungu Reviewed-by: Eduardo Habk

Re: [Qemu-devel] [PATCH 06/54] char: introduce generic qemu_chr_get_kind()

2016-12-19 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > This allows to remove the "is_mux" field from CharDriverState. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 2 +- > qemu-char.c | 21 ++--- > include/sysemu/char.h | 15 +-- > 3 file

Re: [Qemu-devel] [PATCH 01/23] target-arm: Log AArch64 exception returns

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > We already log exception entry; add logging of the AArch64 exception > return path as well. > > Signed-off-by: Peter Maydell > Reviewed-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target-arm/op_helper.

Re: [Qemu-devel] [PATCH 09/23] hw/intc/arm_gic: Add external IRQ lines for VIRQ and VFIQ

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > Augment the GIC's QOM device interface by adding two > new sets of sysbus IRQ lines, to signal VIRQ and VFIQ to > each CPU. > > We never use these, but it's helpful to keep the v2-and-earlier > GIC's external interface in line with that of th

[Qemu-devel] [PATCH] target-arm/abi32: check for segfault in do_kernel_trap

2016-12-19 Thread Seraphime Kirkovski
Currently, the cmpxchg implementation tests whether the destination address is readable: - if it is, we read the value and continue with the comparison - if isn't, i.e. access to addr would segfault, we assume that src != dest rather than queuing a SIGSEGV. The same problem exists in the c

Re: [Qemu-devel] [PATCH 07/54] char: use a feature bit for replay

2016-12-19 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > Use a feature flag rather than a structure field for "replay". > > Signed-off-by: Marc-André Lureau > --- > qemu-char.c | 33 - > include/sysemu/char.h | 3 ++- > 2 files changed, 22 insertions(+), 14 d

Re: [Qemu-devel] [PATCH 22/23] target-arm: Enable EL2 feature bit on A53 and A57

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 8:11 AM, Edgar E. Iglesias wrote: > On Tue, Dec 13, 2016 at 10:36:23AM +, Peter Maydell wrote: >> Enable the ARM_FEATURE_EL2 bit on Cortex-A52 and >> Cortex-A57, since this is all now sufficiently implemented >> to work with the GICv3. We provide the usual CPU property

Re: [Qemu-devel] [PATCH 00/23] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > This patchset adds support for the Virtualization extensions to QEMU's > GICv3 emulation. This was the last missing piece that was stopping > us from turning on the EL2 support in the CPU model, so the patchset > also adds support for enablin

[Qemu-devel] [PATCH 1/5] docs: vm generation id device's description

2016-12-19 Thread ben
From: Ben Warren Signed-off-by: Ben Warren Cc: Gal Hammer --- docs/specs/vmgenid.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 inde

[Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands

2016-12-19 Thread ben
From: Igor Mammedov Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "changed": true, "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } }

[Qemu-devel] [PATCH 2/5] ACPI: Add a function for building named qword entries

2016-12-19 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 4 2 files changed, 32 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index b2a1e40..dc4edc2 100644 --- a/hw/acpi/aml-build.c

[Qemu-devel] [PATCH 4/5] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2016-12-19 Thread ben
From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Ben Warren --- hmp-commands-i

[Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID

2016-12-19 Thread ben
From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This has been tested to work with Windows 2012 R2. I consider it RFC quality

[Qemu-devel] [PATCH 3/5] ACPI: Add Virtual Machine Generation ID support

2016-12-19 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. The user interface is a simple device with two parameters: - guid (string, must be in UUID format ----) - changed (boolean, signal to the g

Re: [Qemu-devel] [PATCH 20/67] ahci: clear aiocb in ncq_cb

2016-12-19 Thread John Snow
Hi, some more considerations: e7bd708ec85e40fd51569bb90c52d6613ffd8f45 atapi: classify read_cd as conditionally returning data This fixes problems with certain operating systems being unable to read from the CDROM. 99868af3d0a75cf6a515a9aa81bf0d7bcb39eadb dma-helpers: explicitly pass alignment

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin.jiang
Well, that makes sense, I lose my consideration, thanks. Sochin Jiang On 2016/12/19 23:31, Eric Blake wrote: > On 12/19/2016 04:38 PM, sochin jiang wrote: >> Mirroring using 'top' mode without backing file specified on the target can >> be success, >> but end with a disaster. >> >> For ex

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin.jiang
I got the idea, thanks, Max. Sochin.Jiang On 2016/12/19 23:31, Max Reitz wrote: > On 19.12.2016 23:38, sochin jiang wrote: >> Mirroring using 'top' mode without backing file specified on the target can >> be success, >> but end with a disaster. >> >> For example: >>Migration can be suc

Re: [Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

2016-12-19 Thread Stefano Stabellini
I am OK with this, if the relevant maintainers (Migration, QMP) ack the patches. On Fri, 16 Dec 2016, Zhang Chen wrote: > Xen COLO depend on qemu COLO replication function. > So, We need new qmp commands for Xen to use qemu replication. > > Corresponding libxl patches already in xen.git. > Commit

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread David Gibson
On Mon, Dec 19, 2016 at 10:41:26PM +0800, Peter Xu wrote: > This is preparation work to finally enabled dynamic switching ON/OFF for > VT-d protection. The old VT-d codes is using static IOMMU region, and > that won't satisfy vfio-pci device listeners. > > Let me explain. > > vfio-pci devices dep

Re: [Qemu-devel] [PATCH] 9pfs: fix crash when fsdev is missing

2016-12-19 Thread Li Qiang
On 2016-12-19 22:28 GMT+08:00 Greg Kurz wrote: > If the user passes -device virtio-9p without the corresponding -fsdev, QEMU > dereferences a NULL pointer and crashes. > > This is a 2.8 regression introduced by commit 702dbcc274e2c. > > Signed-off-by: Greg Kurz > Reviewed-by: Li Qiang > ---

Re: [Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

2016-12-19 Thread Zhang Chen
On 12/20/2016 08:56 AM, Stefano Stabellini wrote: I am OK with this, if the relevant maintainers (Migration, QMP) ack the patches. Can you add reviewed-by for this patch set? Thanks Zhang Chen On Fri, 16 Dec 2016, Zhang Chen wrote: Xen COLO depend on qemu COLO replication function. So, We

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Mon, Dec 19, 2016 at 09:56:50AM -0700, Alex Williamson wrote: > On Mon, 19 Dec 2016 22:41:26 +0800 > Peter Xu wrote: > > > This is preparation work to finally enabled dynamic switching ON/OFF for > > VT-d protection. The old VT-d codes is using static IOMMU region, and > > that won't satisfy v

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Tue, Dec 20, 2016 at 10:30:12AM +1100, David Gibson wrote: [...] > > +static void vtd_switch_address_space(IntelIOMMUState *s, bool enabled) > > +{ > > +GHashTableIter iter; > > +VTDBus *vtd_bus; > > +VTDAddressSpace *as; > > +int i; > > + > > +g_hash_table_iter_init(&iter,

Re: [Qemu-devel] [RESEND Patch v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-19 Thread Wei Wang
Hi Marc-André, thanks for the comments. On 12/20/2016 12:43 AM, Marc-André Lureau wrote: Hi Wei, On Mon, Dec 19, 2016 at 7:00 AM Wei Wang > wrote: This patch series implements vhost-pci, which is a point-to-point based inter-vm communication solution.

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Alex Williamson
On Tue, 20 Dec 2016 11:44:41 +0800 Peter Xu wrote: > On Mon, Dec 19, 2016 at 09:56:50AM -0700, Alex Williamson wrote: > > On Mon, 19 Dec 2016 22:41:26 +0800 > > Peter Xu wrote: > > > > > This is preparation work to finally enabled dynamic switching ON/OFF for > > > VT-d protection. The old VT

[Qemu-devel] [PATCHv5 for 2.9 1/6] pseries: Add pseries-2.9 machine type

2016-12-19 Thread David Gibson
Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier --- hw/ppc/spapr.c | 23 +-- include/hw/compat.h | 3 +++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 31210b3..fcaa2a5 100644 ---

[Qemu-devel] [PATCHv5 for 2.9 3/6] pseries: Implement HPT resizing

2016-12-19 Thread David Gibson
This patch implements hypercalls allowing a PAPR guest to resize its own hash page table. This will eventually allow for more flexible memory hotplug. The implementation is partially asynchronous, handled in a special thread running the hpt_prepare_thread() function. The state of a pending resiz

[Qemu-devel] [PATCHv5 for 2.9 4/6] pseries: Enable HPT resizing for 2.9

2016-12-19 Thread David Gibson
We've now implemented a PAPR extensions which allows PAPR guests (i.e. "pseries" machine type) to resize their hash page table during runtime. However, that extension is only enabled if explicitly chosen on the command line. This patch enables it by default for spapr-2.9, but leaves it disabled (

[Qemu-devel] [PATCHv5 for 2.9 0/6] HPT resizing for pseries guests (qemu part)

2016-12-19 Thread David Gibson
This series implements the host side of the PAPR ACR to allow runtime resizing of the Hashed Page Table (HPT) for pseries guests. Exercising this feature requires a guest OS which is also aware of it. Patches to implement the guest side in Linux have just been submitted upstream: https://lists.ozl

[Qemu-devel] [PATCHv5 for 2.9 6/6] pseries: Allow HPT resizing with KVM

2016-12-19 Thread David Gibson
So far, qemu implements the PAPR Hash Page Table (HPT) resizing extension with TCG. The same implementation will work with KVM PR, but we don't currently allow that. For KVM HV we can only implement resizing with the assistance of the host kernel, which needs a new capability and ioctl()s. This

Re: [Qemu-devel] [PATCH v6 00/10] tcg mips64 and mips r6 improvements

2016-12-19 Thread Jin Guojie
ping http://patchwork.ozlabs.org/patch/704829/ Please give me any advice and comment for speeding up the review process. Thank you all! Jin Guojie -- Original -- From: "jinguojie";; Send time: Sunday, Dec 11, 2016 9:36 PM To: "qemu-devel"; Cc: "Aurelien Jarn

[Qemu-devel] [PATCHv5 for 2.9 2/6] pseries: Stubs for HPT resizing

2016-12-19 Thread David Gibson
This introduces stub implementations of the H_RESIZE_HPT_PREPARE and H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR extension to allow run time resizing of a guest's hash page table. It also adds a new machine property for controlling whether this new facility is available. For now

[Qemu-devel] [PATCHv5 for 2.9 5/6] pseries: Use smaller default hash page tables when guest can resize

2016-12-19 Thread David Gibson
We've now implemented a PAPR extension allowing PAPR guest to resize their hash page table (HPT) during runtime. This patch makes use of that facility to allocate smaller HPTs by default. Specifically when a guest is aware of the HPT resize facility, qemu sizes the HPT to the initial memory size,

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: [...] > > Yes, this patch just tried to move VT-d forward a bit, rather than do > > it once and for all. I think we can do better than this in the future, > > for example, one address space per guest IOMMU domain (as you have > > me

Re: [Qemu-devel] [virtio-dev] Re: [RESEND Patch v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-19 Thread Wei Wang
On 12/20/2016 12:32 PM, Wei Wang wrote: Hi Marc-André, thanks for the comments. On 12/20/2016 12:43 AM, Marc-André Lureau wrote: Another question, what are vpnet->rqs used for? This should be redundant, I will remove it. I think I should explain more about this: the rqs field is redundant i

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2016-12-19 Thread Pavel Dovgalyuk
It also fails much earlier when I enable logs with "-d int -D log". Here is backtrace for this failure: #0 0x76e79e52 in ntdll!EtwpCreateEtwThread () from /c/Windows/SYSTEM32/ntdll.dll #1 0x76e56965 in ntdll!EtwEventSetInformation () from /c/Windows/SYSTEM32/ntdll.dl

<    1   2