[Qemu-devel] [PATCH 3/4] hw/arm/virt: Rename 'vbi' variables to 'vms'

2016-12-09 Thread Peter Maydell
Rename all the variables which used to be VirtBoardInfo* and are now VirtMachineState* so their names are in line with the type being used. Apart from the removal of the line 'VirtMachineState *vbi = vms;' this commit is purely a search-and-replace of 'vbi' with 'vms'. Signed-off-by: Peter Maydel

[Qemu-devel] [PATCH 4/4] hw/arm/virt: Don't incorrectly claim architectural timer to be edge-triggered

2016-12-09 Thread Peter Maydell
The architectural timers in ARM CPUs all have level triggered interrupts (unless you're using KVM on a host kernel before 4.4, which misimplemented them as edge-triggered). We were incorrectly describing them in the device tree as edge triggered. This can cause problems for guest kernels in 4.8 be

[Qemu-devel] [PATCH 2/4] hw/arm/virt: Merge VirtBoardInfo and VirtMachineState

2016-12-09 Thread Peter Maydell
One of the purposes of VirtBoardInfo was to hold various bits of state about the board. Now we have MachineState and the subclass VirtMachineState to do this. Fold the VirtBoardInfo into VirtMachineState rather than having some flags in one struct and some in another with no useful way to get betwe

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-09 Thread Andrea Arcangeli
Hello, On Fri, Dec 09, 2016 at 05:35:45AM +, Li, Liang Z wrote: > > On 12/08/2016 08:45 PM, Li, Liang Z wrote: > > > What's the conclusion of your discussion? It seems you want some > > > statistic before deciding whether to ripping the bitmap from the ABI, > > > am I right? > > > > I think

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-12-09 Thread Maxime Coquelin
On 12/09/2016 03:42 PM, Daniel P. Berrange wrote: On Fri, Dec 09, 2016 at 02:35:58PM +0100, Maxime Coquelin wrote: ++Daniel for libvirt On 11/24/2016 07:31 AM, Yuanhan Liu wrote: As version here is an opaque string for libvirt and qemu, anything can be used - but I suggest either a list of

Re: [Qemu-devel] [PATCH 04/20] alpha: Move CPU files to target/ folder

2016-12-09 Thread Richard Henderson
On 12/09/2016 04:17 AM, Thomas Huth wrote: > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 2 +- > hw/alpha/alpha_sys.h | 2 +- > {target-alpha => target/alpha}/Makefile.objs | 0 > {target-alpha => target/alpha}/STATUS| 0 > {ta

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-12-09 Thread Daniel P. Berrange
On Fri, Dec 09, 2016 at 05:45:13PM +0100, Maxime Coquelin wrote: > > > On 12/09/2016 03:42 PM, Daniel P. Berrange wrote: > > On Fri, Dec 09, 2016 at 02:35:58PM +0100, Maxime Coquelin wrote: > > > ++Daniel for libvirt > > > > > > On 11/24/2016 07:31 AM, Yuanhan Liu wrote: > > > > > > > > > > > As

Re: [Qemu-devel] [PATCH v4 62/64] tcg: Use ctpop to generate ctz if needed

2016-12-09 Thread Richard Henderson
On 12/09/2016 08:07 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Particularly when andc is also available, this is two insns >> shorter than using clz to compute ctz. >> >> Signed-off-by: Richard Henderson >> --- >> tcg/tcg-op.c | 107 >> --

Re: [Qemu-devel] [PATCH 01/20] Makefile: Allow CPU targets to reside in target/ folder, too

2016-12-09 Thread Thomas Huth
On 09.12.2016 13:24, Laurent Vivier wrote: > Le 09/12/2016 à 13:17, Thomas Huth a écrit : >> To be able to compile the CPU targets from within a subfolder >> of the target/ folder, we've got to adapt the Makefile.target >> a little bit first. After this change, target CPUs can either >> reside in a

Re: [Qemu-devel] [PATCH 01/19] linux-user: fix settime old value location

2016-12-09 Thread Alex Bennée
Pranith Kumar writes: > From: Marc-André Lureau > > old_value is the 4th argument of timer_settime(), not the 2nd. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Pranith Kumar Reviewed-by: Alex Bennée but this should really be sent in another series. > --- > linux-user/syscall.c |

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-09 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 451 > +++ > block/

Re: [Qemu-devel] [for-2.9 2/5] pseries: Stubs for HPT resizing

2016-12-09 Thread Michael Roth
Quoting David Gibson (2016-12-08 20:23:11) > This introduces stub implementations of the H_RESIZE_HPT_PREPARE and > H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR > extension to allow run time resizing of a guest's hash page table. It > also adds a new machine property for controlli

Re: [Qemu-devel] [PATCH 14/21] block: add bdrv_can_store_dirty_bitmap

2016-12-09 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > This will be needed to check some restrictions before making bitmap > persistent in qmp-block-dirty-bitmap-add (this functionality will be > added by future patch) > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c

Re: [Qemu-devel] [PATCH 02/19] linux-user: fix tcg/mmap test

2016-12-09 Thread Alex Bennée
Pranith Kumar writes: > From: Marc-André Lureau > > tests/tcg/mmap test fails with values other than default target page > size. When creating a map beyond EOF, extra anonymous pages are added up > to the target page boundary. Currently, this operation is performed only > when qemu_real_host_pa

Re: [Qemu-devel] [PATCH 04/19] tests/tcg: comment unused code

2016-12-09 Thread Alex Bennée
Pranith Kumar writes: > From: Marc-André Lureau > > I didn't remove it, as suggest by checkpatch, because it looks like it > may eventually be restored back. I'm not so sure, especially with having full source control. Either fix it or delete it please. > > Signed-off-by: Marc-André Lureau >

Re: [Qemu-devel] [PATCH 03/19] check-help: add some hint to run a single test

2016-12-09 Thread Alex Bennée
Pranith Kumar writes: > From: Marc-André Lureau > > It's possible to run the test directly, tests/test-foo, but then > recompilation is not triggered and test environment variables aren't set > for you. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Pranith Kumar Reviewed-by: Alex Ben

Re: [Qemu-devel] [PATCH v4 61/64] qemu/host-utils.h: Reduce the operation count in the fallback ctpop

2016-12-09 Thread Richard Henderson
On 12/09/2016 06:41 AM, Alex Bennée wrote: > +struct bitcnt_test_data sixtyfour_bit_data[] = { > +{ { .w64 = 0x0001 }, .popct=1 }, Thanks. Merged with added ULL for the 64-bit data. r~

[Qemu-devel] [PATCH v3 0/1] migration: disallow migrate_add_blocker during migration

2016-12-09 Thread John Snow
As discussed on-list, this may be a necessary building block for a run-time flag that prevents us from getting into any situations where we configure a non-migratable QEMU. I'd like extra attention to be paid to the virtio-gpu, vhost, and ivshmem changes as I am not perfectly confident in those.

[Qemu-devel] [PATCH v3 1/1] migration: disallow migrate_add_blocker during migration

2016-12-09 Thread John Snow
If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Add an errp parameter and a retcode return value to migrate_add_blocker. Signed-off-by: John Snow --- block/qcow.c | 6 +- block/vdi.c | 6 +

Re: [Qemu-devel] [PATCH kvm-unit-tests v8 09/10] arm/arm64: gicv3: add an IPI test

2016-12-09 Thread Andrew Jones
On Fri, Dec 09, 2016 at 04:08:00PM +, Andre Przywara wrote: > On 08/12/16 17:50, Andrew Jones wrote: > > +u32 gicv3_iar_irqnr(u32 iar) > > +{ > > + return iar; > > I am probably a bit paranoid here, but the spec says that the interrupt > ID is in bits[23:0] only (at most). Indeed, I'll add

Re: [Qemu-devel] [PATCH 15/21] qcow2: add .bdrv_can_store_dirty_bitmap

2016-12-09 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_can_store_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 40 > block/qcow2.c| 1 + > block/qcow2.h| 4 >

Re: [Qemu-devel] [PATCH 16/21] qmp: add persistent flag to block-dirty-bitmap-add

2016-12-09 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > blockdev.c| 17 - > docs/qmp-c

Re: [Qemu-devel] [PATCH v3 1/1] migration: disallow migrate_add_blocker during migration

2016-12-09 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Add an errp parameter and a retcode return value to migrate_add_blocker. > > Signed-off-by: John Snow > --- > block/qcow.c

Re: [Qemu-devel] [PATCH v3 0/1] migration: disallow migrate_add_blocker during migration

2016-12-09 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/1] migration: disallow migrate_add_blocker during migration Type: series Message-id: 20161209172547.31550-1-js...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 17/21] qmp: add autoload parameter to block-dirty-bitmap-add

2016-12-09 Thread Max Reitz
On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Optional. Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > blockdev.c| 18 -- > docs/qmp-commands.txt | 4 > qapi/block-core.json | 6 +- >

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-09 Thread Vladimir Sementsov-Ogievskiy
09.12.2016 20:05, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 451 +

Re: [Qemu-devel] [PATCH 15/21] qcow2: add .bdrv_can_store_dirty_bitmap

2016-12-09 Thread Vladimir Sementsov-Ogievskiy
09.12.2016 20:28, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: Realize .bdrv_can_store_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block

[Qemu-devel] [PATCH v3 0/2] Fixes/tests for hmp_object_del()

2016-12-09 Thread Michael Roth
hmp_object_del() followed by a subsequent hmp_object_add() can trigger a duplicate ID error if the previous object shared the same ID and was added via the command-line. Please see patch 2/2 for more details. This patchset fixes the issue in question and adds some general unit tests for object cre

[Qemu-devel] [PATCH v3 2/2] monitor: fix object_del for command-line-created objects

2016-12-09 Thread Michael Roth
Currently objects specified on the command-line are only partially cleaned up when 'object_del' is issued in either HMP or QMP: the object itself is fully finalized, but the QemuOpts are not removed. This results in the following behavior: x86_64-softmmu/qemu-system-x86_64 -monitor stdio \ -

[Qemu-devel] [PATCH for-2.9] qom: Make all interface types abstract

2016-12-09 Thread Eduardo Habkost
"qom-list-types abstract=false" currently returns all interface types, as if they were not abstract. Fix this by making sure all interface types are abstract. All interface types have instance_size == 0, so we can use it to set abstract=true on Signed-off-by: Eduardo Habkost --- qom/object.c

Re: [Qemu-devel] [PATCH 19/20] xtensa: Move CPU files to target/ folder

2016-12-09 Thread Max Filippov
On Fri, Dec 9, 2016 at 4:17 AM, Thomas Huth wrote: > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 2 +- > {target-xtensa => target/xtensa}/Makefile.objs| 0 > {target-xtensa => target/xtensa}/core-dc232b.c| 0 > {target-xt

[Qemu-devel] [PATCH v3 1/2] tests: check-qom-proplist: add checks for cmdline-created objects

2016-12-09 Thread Michael Roth
check-qom-proplist originally added tests for verifying that object-creation helpers object_new_with_{props,propv} behaved in similar fashion to the "traditional" method involving setting each individual property separately after object creation rather than via a single call. Another similar "help

Re: [Qemu-devel] [PATCH 1/2] 9p: v9fs add writepages.

2016-12-09 Thread Edward Shishkin
On 10/25/2016 04:01 PM, Alexander Graf wrote: On 10/10/2016 07:24 PM, Edward Shishkin wrote: Add a v9fs private ->writepages() method of address_space operations for merging pages into long 9p messages. Signed-off-by: Edward Shishkin --- fs/9p/v9fs.c | 46 +++ fs/9p/v9fs.h |

Re: [Qemu-devel] [PATCH 2/2] 9p: v9fs new readpages.

2016-12-09 Thread Edward Shishkin
Hello Alexander, Thank you for the comments. Please, find my answers below. On 10/25/2016 04:13 PM, Alexander Graf wrote: On 10/10/2016 07:24 PM, Edward Shishkin wrote: Modify v9fs private ->readpages() method of address_space operations for merging pages into long 9p messages. Signed-off-by

Re: [Qemu-devel] [RFC for-2.8] machine: Convert abstract typename on compat_props to subclass names

2016-12-09 Thread Eduardo Habkost
On Wed, Dec 07, 2016 at 02:39:25PM +0100, Greg Kurz wrote: > On Tue, 6 Dec 2016 17:31:59 -0200 > Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 05:19:52PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > > Since commit "9a4c0e220d8a hw/virt

[Qemu-devel] Reproducible crash on PCIe hotplug

2016-12-09 Thread Eduardo Habkost
Using latest qemu.git master: $ qemu-system-x86_64 -machine q35 -readconfig docs/q35-chipset.cfg -monitor stdio QEMU 2.7.93 monitor - type 'help' for more information (qemu) device_add e1000e,bus=ich9-pcie-port-4,addr=00 (qemu) device_add e1000e,bus=ich9-pcie-port-4,addr=08 Segmentation

Re: [Qemu-devel] [PATCH v3 1/1] migration: disallow migrate_add_blocker during migration

2016-12-09 Thread John Snow
On 12/09/2016 12:39 PM, Dr. David Alan Gilbert wrote: > * John Snow (js...@redhat.com) wrote: >> If a migration is already in progress and somebody attempts >> to add a migration blocker, this should rightly fail. >> >> Add an errp parameter and a retcode return value to migrate_add_blocker. >> >

Re: [Qemu-devel] [PATCH 3/8] 9pfs: fix P9_NOTAG and P9_NOFID macros

2016-12-09 Thread Eric Blake
On 12/09/2016 03:28 AM, Greg Kurz wrote: > The u16 and u32 types don't exist in QEMU common headers. It never broke > build because these two macros aren't use by the current code, but this > is about to change with the future addition of functional tests for 9P. > > This patch convert the types t

Re: [Qemu-devel] [PATCH v6 1/2] sparc: fix a building error reported by kbuild

2016-12-09 Thread Sam Ravnborg
Hi Gonglei. On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote: > >> arch/sparc/include/asm/topology_64.h:44:44: > error: implicit declaration of function 'cpu_data' > [-Werror=implicit-function-declaration] > > #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id) >

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free

2016-12-09 Thread Gonglei (Arei)
> > > On 09.12.2016 02:42, Gonglei (Arei) wrote: > > Hi, > > > >> > >> Subject: Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key > >> material before free > >> > >> On 08.12.2016 16:23, Eric Blake wrote: > >>> On 12/07/2016 08:28 PM, Gonglei (Arei) wrote: > >>> > > As far as

<    1   2