[Qemu-devel] [PATCH for-2.9 V2 0/3] Add new qmp commands to suppurt Xen COLO

2016-12-08 Thread Zhang Chen
Xen COLO depend on qemu COLO replication function. So, We need new qmp commands for Xen to use qemu replication. Corresponding libxl patches already in xen.git. Commit ID: ed37ef1f91c20f0ab162ce60f8c38400b917fa64 COLO: introduce new API to prepare/start/do/get_error/stop replication a0ddc0b35937

[Qemu-devel] [PATCH for-2.9 V2 2/3] Add a new qmp command to start/stop replication

2016-12-08 Thread Zhang Chen
We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen --- docs/qmp-commands.txt | 17 + migration/colo.c | 22 ++ qapi-schema.json | 19 +++ 3 files changed

[Qemu-devel] [RFC PATCH] block/qapi: Optimize the query function of the blockstats

2016-12-08 Thread Dou Liyang
In the query function named qmp_query_blockstats, for each block/node, the process is as shown below: the 0 func determines which the lookup queue will be used by the 1 func, then gets the next object by the 1 func and calls the 2. The 2 func calls the 3 and 4 func. There are some judgement and wor

[Qemu-devel] [PATCH for-2.9 V2 1/3] Migration: Don't load vmdesc when xen is enabled

2016-12-08 Thread Zhang Chen
Xen doesn't need this. Signed-off-by: Zhang Chen --- migration/savevm.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 0363372..bec6c7e 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1973,6 +1973,10 @@ int qemu_loadvm_state(QEM

[Qemu-devel] [PATCH for-2.9 V2 3/3] Add a new qmp command to do checkpoint, get replication error

2016-12-08 Thread Zhang Chen
We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen --- docs/qmp-commands.txt | 24 migration/colo.c | 10 ++ qapi-schema.json | 22 ++ 3 files changed, 56 insert

Re: [Qemu-devel] QEMU Advent Calendar

2016-12-08 Thread Thomas Huth
On 07.12.2016 23:15, Martin Steigerwald wrote: > Dear Thomas, Dear Kashyap, dear QEMU developers, > > What a wonderful idea! > > Thank you. Thanks for the kind words! > > Considered > > http://aros.sourceforge.net/ > > or some of its distributions? Yes, just yesterday, somebody else suggest

[Qemu-devel] [Bug 920772] Re: Win98SE glitches RHEL6.2/CentOS6.2 QEMU

2016-12-08 Thread Thomas Huth
QEMU 0.12 is pretty much outdated nowadays - can you still reproduce these issues with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

Re: [Qemu-devel] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-08 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > > > On 12/07/2016 11:49 AM, Dr. David Alan Gilbert wrote: > > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > >> Add a test for QTAILQ migration to tests/test-vmstate.c. > > > > Yes, but see comment below if you have to respin: > > > >> Sign

Re: [Qemu-devel] [PATCH for-2.9 v2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 10:33:28AM +0800, Longpeng(Mike) wrote: > Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede > support when using libgcrypt or nettle. > > Signed-off-by: Longpeng(Mike) > --- > Changes since v1: > - rename 3des-ede to 3des. [Daniel] > - add (since 2.

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-12-08 Thread James Page
** Also affects: cloud-archive/mitaka Importance: Undecided Status: New ** Changed in: cloud-archive/mitaka Status: New => Fix Committed ** Changed in: cloud-archive Status: Fix Released => Invalid -- You received this bug notification because you are a member of qemu- d

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-08 Thread Wouter Verhelst
On Thu, Dec 08, 2016 at 03:39:19AM +, Alex Bligh wrote: > > > On 2 Dec 2016, at 18:45, Alex Bligh wrote: > > > > Thanks. That makes sense - or enough sense for me to carry on commenting! > > > I finally had some time to go through this extension in detail. Rather > than comment on all the

Re: [Qemu-devel] [PATCH for-2.9 v2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-08 Thread Longpeng (Mike)
On 2016/12/8 17:33, Daniel P. Berrange wrote: > On Thu, Dec 08, 2016 at 10:33:28AM +0800, Longpeng(Mike) wrote: >> Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede >> support when using libgcrypt or nettle. >> >> Signed-off-by: Longpeng(Mike) >> --- >> Changes since v1: >> -

Re: [Qemu-devel] [RFC PATCH] block/qapi: Optimize the query function of the blockstats

2016-12-08 Thread Stefan Hajnoczi
On Thu, Dec 08, 2016 at 03:56:42PM +0800, Dou Liyang wrote: The commit message says "optimize" but I think the purpose of this patch is to refactor qmp_query_blockstats() to make it easier to read? Just checking if you expect a change in performance. Usually when I see "optimize" I think improvi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cadence_uart: Check if receiver timeout counter is disabled

2016-12-08 Thread Edgar E. Iglesias
On Thu, Dec 08, 2016 at 08:50:40AM +0100, Laurent Vivier wrote: > I CC: Xilinx Zynq Maintainers. > > Laurent Thanks > > On 07/12/2016 22:12, Andrew Gacek wrote: > > When register Rcvr_timeout_reg0 (R_RTOR in cadence_uart.c) is set to > > 0, the receiver timeout counter should be disabled. See p

[Qemu-devel] [PATCH v2] egl-helpers: Change file licensing to LGPLv2

2016-12-08 Thread Frediano Ziglio
The relicense permits sharing the code with Spice which is LGPL. All people listed below have agreed to the relicense: - Arei Gonglei; - Cole Robinson; - Gerd Hoffmann; - Peter Maydell. Signed-off-by: Frediano Ziglio Acked-by: Cole Robinson --- ui/egl-helpers.c | 16 1 file ch

Re: [Qemu-devel] [RFC PATCH] block/qapi: Optimize the query function of the blockstats

2016-12-08 Thread Dou Liyang
At 12/08/2016 06:07 PM, Stefan Hajnoczi wrote: On Thu, Dec 08, 2016 at 03:56:42PM +0800, Dou Liyang wrote: The commit message says "optimize" but I think the purpose of this patch is to refactor qmp_query_blockstats() to make it easier to read? Just checking if you expect a change in performa

Re: [Qemu-devel] [RFC PATCH] block/qapi: Optimize the query function of the blockstats

2016-12-08 Thread Dou Liyang
At 12/08/2016 07:17 PM, Dou Liyang wrote: At 12/08/2016 06:07 PM, Stefan Hajnoczi wrote: On Thu, Dec 08, 2016 at 03:56:42PM +0800, Dou Liyang wrote: The commit message says "optimize" but I think the purpose of this patch is to refactor qmp_query_blockstats() to make it easier to read? Jus

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cadence_uart: Check if receiver timeout counter is disabled

2016-12-08 Thread Andrew Gacek
When register Rcvr_timeout_reg0 (R_RTOR in cadence_uart.c) is set to 0, the receiver timeout counter should be disabled. See page 1801 of "Zynq-7000 AP SoC Technical Reference Manual". This commit adds a such a check before setting the receive timeout interrupt. Signed-off-by: Andrew Gacek Review

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-12-08 Thread Rafael David Tinoco
@jamespage, @cpaelzer, I'll verify this fix in couple of days so it can be released. Thank you! Rafael -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create fallback mec

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-12-08 Thread Rafael David Tinoco
Hello Antonio (@arcimboldo) The fix only makes sense for newer QEMUs (>= Xenial, like the one from Mitaka Ubuntu Cloud Archive). OBS: The "migration check" is done in VHOST initialization functions when the devices are virtually attached to the virtual machine. If you are using kernel 3.13 and h

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cadence_uart: Check if receiver timeout counter is disabled

2016-12-08 Thread Andrew Gacek
Laurent, thanks for CC'ing Xilinx Zynq maintainers. I read that part of the submission guidelines, then completely forgot to do it. Edgar, thanks for the comments. I wasn't sure if I needed to call that function or not. Also, one other discrepancy with the technical reference manual is that writin

[Qemu-devel] [PATCH 0/2] Remove need for -iscsi argument

2016-12-08 Thread Daniel P. Berrange
This small series removes the need for using the -iscsi argument by directly supporting all the -iscsi options against the block device config eg instead of $QEMU \ -object secret,id=sec0,data=123456 \ -drive driver=iscsi,file=iscsi://catbus/iqn.fedora:kvm/2 \ -iscsi initiator-name=fish,user

[Qemu-devel] [PATCH 1/2] iscsi: reduce code duplication parsing -iscsi opts

2016-12-08 Thread Daniel P. Berrange
The iscsi block driver has to pull some of its options out of a separate -iscsi. It has a separate helper method for each set of options it needs to extract, and in doing so, it runs qemu_opts_find multiple times. Switch to running qemu_opts_find once and passing the QemuOpts object into the helper

[Qemu-devel] [PATCH 2/2] iscsi: support most -iscsi opts against block dev opts

2016-12-08 Thread Daniel P. Berrange
Currently a number of iscsi related options must be specified against the separate -iscsi argument, instead of as part of the block device configuration. This extends the iscsi bdev runtime options to support all the options available via -iscsi, except for the deprecated "password" option. This m

Re: [Qemu-devel] [RFC 00/13] Live memory snapshot based on userfaultfd

2016-12-08 Thread Hailiang Zhang
Hi Andrea, I noticed that, you call change_protection() helper in mprotect to realize write protect capability for userfault. But i doubted mprotect can't work properly with KVM. If shadow page table (spte) which used by VM is already established in EPT,change_protection() does not remove its wri

Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-08 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 12/07 10:48, Kevin Wolf wrote: >> > If so I think there is no race to worry about, mirror-filter should go >> > away only after a QMP command. >> >> Currently, a mirror job goes away whenever it is done. This is not >> directly tied to a QMP command. > > Ah right, blo

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] Remove need for -iscsi argument

2016-12-08 Thread Kevin Wolf
Am 08.12.2016 um 13:41 hat Daniel P. Berrange geschrieben: > This small series removes the need for using the -iscsi argument > by directly supporting all the -iscsi options against the block > device config eg instead of > > $QEMU \ > -object secret,id=sec0,data=123456 \ > -drive driver=iscsi

[Qemu-devel] [RFC PATCH 2/6] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2016-12-08 Thread Kevin Wolf
This splits the logic in the old parse_chap() function into a part that parses the -iscsi options into the new driver-specific options, and another part that actually applies those options (called apply_chap() now). Note that this means that username and password specified with -iscsi only take ef

[Qemu-devel] [RFC PATCH 1/6] iscsi: Split URL into individual options

2016-12-08 Thread Kevin Wolf
This introduces a .bdrv_parse_filename handler for iscsi which parses an URL if given and translates it to individual options. Signed-off-by: Kevin Wolf --- block/iscsi.c | 189 ++ 1 file changed, 136 insertions(+), 53 deletions(-) diff --

[Qemu-devel] [RFC PATCH 0/6] iscsi: Add blockdev-add support

2016-12-08 Thread Kevin Wolf
This adds blockdev-add support to the iscsi block driver. Note that this is only compile tested at this point. Jeff is going to take over from here and bring the series to a mergable state. Kevin Wolf (6): iscsi: Split URL into individual options iscsi: Handle -iscsi user/password in bdrv_par

[Qemu-devel] [RFC PATCH 6/6] iscsi: Add blockdev-add support

2016-12-08 Thread Kevin Wolf
This adds blockdev-add support for iscsi devices. Signed-off-by: Kevin Wolf --- block/iscsi.c| 14 ++ qapi/block-core.json | 74 2 files changed, 78 insertions(+), 10 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c ind

[Qemu-devel] [RFC PATCH 4/6] iscsi: Add header-digest option

2016-12-08 Thread Kevin Wolf
This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. Signed-off-by: Kevin Wolf --- block/iscsi.c | 38 ++ 1 file changed,

[Qemu-devel] [RFC PATCH 3/6] iscsi: Add initiator-name option

2016-12-08 Thread Kevin Wolf
This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. Signed-off-by: Kevin Wolf --- block/iscsi.c | 32 +++- 1 file changed, 15 ins

[Qemu-devel] [RFC PATCH 5/6] iscsi: Add timeout option

2016-12-08 Thread Kevin Wolf
This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. All -iscsi options have a corresponding driver-specific option for the iscsi block driver now. Signed-off-

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] Remove need for -iscsi argument

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:12:04PM +0100, Kevin Wolf wrote: > Am 08.12.2016 um 13:41 hat Daniel P. Berrange geschrieben: > > This small series removes the need for using the -iscsi argument > > by directly supporting all the -iscsi options against the block > > device config eg instead of > > > >

Re: [Qemu-devel] [RFC PATCH 2/6] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:07PM +0100, Kevin Wolf wrote: > This splits the logic in the old parse_chap() function into a part that > parses the -iscsi options into the new driver-specific options, and > another part that actually applies those options (called apply_chap() > now). > > Note that

Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-08 Thread Fam Zheng
On Thu, 12/08 13:46, Markus Armbruster wrote: > Fam Zheng writes: > > > On Wed, 12/07 10:48, Kevin Wolf wrote: > >> > If so I think there is no race to worry about, mirror-filter should go > >> > away only after a QMP command. > >> > >> Currently, a mirror job goes away whenever it is done. This

Re: [Qemu-devel] [RFC PATCH 0/6] iscsi: Add blockdev-add support

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:05PM +0100, Kevin Wolf wrote: > This adds blockdev-add support to the iscsi block driver. > > Note that this is only compile tested at this point. Jeff is going to > take over from here and bring the series to a mergable state. > > Kevin Wolf (6): > iscsi: Split UR

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-08 Thread Alex Bligh
> On 8 Dec 2016, at 06:58, Vladimir Sementsov-Ogievskiy > wrote: > > An idea: let's not use uppercase. Why to shout the namespace? 'base' and 'x-' > would be better I think. BASE and X- will provoke all user-defined namespaces > be in uppercase too and a lot of uppercase will come to the code

Re: [Qemu-devel] [RFC PATCH 5/6] iscsi: Add timeout option

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:10PM +0100, Kevin Wolf wrote: > This was previously only available with -iscsi. Again, after this patch, > the -iscsi option only takes effect if an URL is given. New users are > supposed to use the new driver-specific option. > > All -iscsi options have a correspondi

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-08 Thread Alex Bligh
Wouter, >> +- `NBD_OPT_META_CONTEXT` (10) >> + >> +Return a list of `NBD_REP_META_CONTEXT` replies, one per context, >> +followed by an `NBD_REP_ACK`. If a server replies to such a request >> +with no error message, clients >> >> "*the* server" / "*the* cient" >> >> Perhaps only an '

Re: [Qemu-devel] [RFC PATCH 0/6] iscsi: Add blockdev-add support

2016-12-08 Thread Kevin Wolf
Am 08.12.2016 um 14:55 hat Daniel P. Berrange geschrieben: > On Thu, Dec 08, 2016 at 02:23:05PM +0100, Kevin Wolf wrote: > > This adds blockdev-add support to the iscsi block driver. > > > > Note that this is only compile tested at this point. Jeff is going to > > take over from here and bring the

Re: [Qemu-devel] [RFC PATCH 3/6] iscsi: Add initiator-name option

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:08PM +0100, Kevin Wolf wrote: > This was previously only available with -iscsi. Again, after this patch, > the -iscsi option only takes effect if an URL is given. New users are > supposed to use the new driver-specific option. > > Signed-off-by: Kevin Wolf > --- > b

Re: [Qemu-devel] [RFC PATCH 6/6] iscsi: Add blockdev-add support

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:11PM +0100, Kevin Wolf wrote: > This adds blockdev-add support for iscsi devices. > > Signed-off-by: Kevin Wolf > --- > block/iscsi.c| 14 ++ > qapi/block-core.json | 74 > > 2 files changed, 78 i

Re: [Qemu-devel] [kvm-unit-tests PATCH v14 3/5] arm: Add PMU test

2016-12-08 Thread Andrew Jones
On Tue, Dec 06, 2016 at 12:05:26PM -0600, Wei Huang wrote: > From: Christopher Covington > > Beginning with a simple sanity check of the control register, add > a unit test for the ARM Performance Monitors Unit (PMU). > > Signed-off-by: Christopher Covington > Signed-off-by: Wei Huang > --- >

Re: [Qemu-devel] QEMU Advent Calendar

2016-12-08 Thread Martin Steigerwald
Am Donnerstag, 8. Dezember 2016, 09:14:06 CET schrieb Thomas Huth: > On 07.12.2016 23:15, Martin Steigerwald wrote: […] > > Considered > > > > http://aros.sourceforge.net/ > > > > or some of its distributions? > > Yes, just yesterday, somebody else suggested that to me. So far, I only > thought

Re: [Qemu-devel] [RFC PATCH 1/6] iscsi: Split URL into individual options

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:06PM +0100, Kevin Wolf wrote: > This introduces a .bdrv_parse_filename handler for iscsi which parses an > URL if given and translates it to individual options. > > Signed-off-by: Kevin Wolf > --- > block/iscsi.c | 189 > ++--

Re: [Qemu-devel] [RFC PATCH 1/6] iscsi: Split URL into individual options

2016-12-08 Thread Kevin Wolf
Am 08.12.2016 um 15:10 hat Daniel P. Berrange geschrieben: > On Thu, Dec 08, 2016 at 02:23:06PM +0100, Kevin Wolf wrote: > > This introduces a .bdrv_parse_filename handler for iscsi which parses an > > URL if given and translates it to individual options. > > > > Signed-off-by: Kevin Wolf > > ---

Re: [Qemu-devel] [RFC PATCH 4/6] iscsi: Add header-digest option

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 02:23:09PM +0100, Kevin Wolf wrote: > This was previously only available with -iscsi. Again, after this patch, > the -iscsi option only takes effect if an URL is given. New users are > supposed to use the new driver-specific option. > > Signed-off-by: Kevin Wolf > --- > b

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free

2016-12-08 Thread Eric Blake
On 12/07/2016 08:33 PM, Gonglei (Arei) wrote: >> Sensitive information is sometimes also held in mlocked pages to prevent >> it being swapped to disk, but qemu in general is not currently taking >> that level of precaution (see also commit 8813800b). >> >>> >>> Let's zeroize the memory of CryptoDe

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-12-08 Thread Antonio Messina
Hi all, I am facing this issue too, and although I can confirm the patch can be easily backported to Trusty (we run Mitaka on Trusty), some of our customers have VMs started with the old qemu and I cannot live migrate anymore or update qemu without stopping and starting the VM. Do you have any su

Re: [Qemu-devel] [PATCH v3 0/3] Add HAX support

2016-12-08 Thread Yu Ning
As a HAXM developer at Intel, I just want to come out and show our support for Vincent's upstreaming effort. We'd love to see HAXM support code land in upstream QEMU, and will do what is necessary to make that happen. We've been working on the issues that Vincent raised and have made some pro

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free

2016-12-08 Thread Eric Blake
On 12/07/2016 08:28 PM, Gonglei (Arei) wrote: >> As far as I'm aware, other projects usually have a special memset >> variation for doing this. That is because compilers may choose to >> "optimize" memset(p, ...) + free(p) to just the free(p). Having a > > Actually, I googled this, but I didn't f

Re: [Qemu-devel] [PATCH v3 0/3] Add HAX support

2016-12-08 Thread Stefan Weil
Am 08.12.2016 um 10:34 schrieb Yu Ning: > As a HAXM developer at Intel, I just want to come out and show our > support for Vincent's upstreaming effort. We'd love to see HAXM support > code land in upstream QEMU, and will do what is necessary to make that > happen. > > We've been working on the is

Re: [Qemu-devel] [PATCH for-2.9 V2 2/3] Add a new qmp command to start/stop replication

2016-12-08 Thread Eric Blake
On 12/08/2016 01:55 AM, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > --- > docs/qmp-commands.txt | 17 + > migration/colo.c | 22 ++ > qapi-

Re: [Qemu-devel] qemu -netdev tun/tap support can't handle macvtap type devices

2016-12-08 Thread Peter Maydell
On 8 December 2016 at 01:52, Jason Wang wrote: > On 2016年12月07日 22:32, Peter Maydell wrote: >> It's particularly confusing in this case that fd= doesn't work with >> queues=, because the user isn't trying to pass multiple fds, just >> the one is fine. > > > Since fd can only accept on file descrip

Re: [Qemu-devel] [PATCH for-2.9 v2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-08 Thread Eric Blake
On 12/07/2016 08:33 PM, Longpeng(Mike) wrote: > Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede > support when using libgcrypt or nettle. > > Signed-off-by: Longpeng(Mike) > --- > +++ b/qapi/crypto.json > @@ -63,6 +63,7 @@ > # @aes-192: AES with 192 bit / 24 byte keys > # @ae

Re: [Qemu-devel] [PATCH v3 0/3] Add HAX support

2016-12-08 Thread Vincent Palatin
On Thu, Dec 8, 2016 at 4:31 PM, Stefan Weil wrote: > > Am 08.12.2016 um 10:34 schrieb Yu Ning: > > As a HAXM developer at Intel, I just want to come out and show our > > support for Vincent's upstreaming effort. We'd love to see HAXM support > > code land in upstream QEMU, and will do what is nece

Re: [Qemu-devel] [PATCH for-2.9 v2] crypto: add 3des-ede support when using libgcrypt/nettle

2016-12-08 Thread Daniel P. Berrange
On Thu, Dec 08, 2016 at 09:45:13AM -0600, Eric Blake wrote: > On 12/07/2016 08:33 PM, Longpeng(Mike) wrote: > > Libgcrypt and nettle support 3des-ede, so this patch add 3des-ede > > support when using libgcrypt or nettle. > > > > Signed-off-by: Longpeng(Mike) > > --- > > > +++ b/qapi/crypto.json

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-08 Thread Eric Blake
On 12/08/2016 08:40 AM, Alex Bligh wrote: >>> + metadata context is the basic "exists at all" metadata context. >>> >>> Disagree. You're saying that if a server supports metadata contexts >>> at all, it must support this one. >> >> No, I'm trying to say that this metadata context exposes whether t

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-08 Thread Alex Bligh
> On 8 Dec 2016, at 15:59, Eric Blake wrote: > > We should use similar wording to whatever we already say about what a > client would see when reading data cleared by NBD_CMD_TRIM. After all, > the status of STATE_HOLE set and STATE_ZERO clear is what you logically > get when TRIM cannot guaran

[Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode

2016-12-08 Thread Kirill A. Shutemov
The new paging more is extension of IA32e mode with more additional page table level. It brings support of 57-bit vitrual address space (128PB) and 52-bit physical address space (4PB). The structure of new page table level is identical to pml4. The feature is enumerated with CPUID.(EAX=07H, ECX=

Re: [Qemu-devel] [RFC PATCH 6/6] iscsi: Add blockdev-add support

2016-12-08 Thread Eric Blake
On 12/08/2016 07:23 AM, Kevin Wolf wrote: > This adds blockdev-add support for iscsi devices. > > Signed-off-by: Kevin Wolf > --- > block/iscsi.c| 14 ++ > qapi/block-core.json | 74 > > 2 files changed, 78 insertions(+), 10 d

Re: [Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode

2016-12-08 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode Type: series Message-id: 20161208162150.148763-2-kirill.shute...@linux.intel.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

Re: [Qemu-devel] [PATCH v4 23/64] tcg: Allow an operand to be matching or a constant

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > This allows an output operand to match an input operand > only when the input operand needs a register. > > Signed-off-by: Richard Henderson It's hard to offer anything more than a mechanical review for this as the constraints aren't intuitive to me (I guess not as

Re: [Qemu-devel] [PATCH v4 24/64] tcg: Add clz and ctz opcodes

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg-runtime.c| 20 +++ > tcg/README | 8 +++ > tcg/aarch64/tcg-target.h | 4 ++ > tcg/arm/tcg-target.h | 2 + > tcg/i386/tcg-target.h| 4 ++ > tcg/ia6

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-08 Thread Jianjun Duan
On 12/08/2016 01:03 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 12/07/2016 11:49 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: Add a test for QTAILQ migration to tests/test-vmstate.c. >>> >>> Yes, b

Re: [Qemu-devel] [PATCH v4 38/64] target-arm: Use clz opcode

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target-arm/helper-a64.c| 10 -- > target-arm/helper-a64.h| 2 -- > target-arm/helper.c| 5 - > target-arm/helper.h| 1 - > target-arm/translate-a64.c | 8 +++

Re: [Qemu-devel] [PATCH v4 23/64] tcg: Allow an operand to be matching or a constant

2016-12-08 Thread Richard Henderson
On 12/08/2016 09:19 AM, Alex Bennée wrote: Richard Henderson writes: This allows an output operand to match an input operand only when the input operand needs a register. Signed-off-by: Richard Henderson It's hard to offer anything more than a mechanical review for this as the constraints

[Qemu-devel] [PATCH kvm-unit-tests v8 07/10] libcflat: add IS_ALIGNED() macro, and page sizes

2016-12-08 Thread Andrew Jones
From: Peter Xu These macros will be useful to do page alignment checks. Reviewed-by: Andre Przywara Reviewed-by: Eric Auger Signed-off-by: Peter Xu [drew: also added SZ_64K and changed to shifts] Signed-off-by: Andrew Jones --- v6: change to shifts [Alex] --- lib/libcflat.h | 6 ++ 1 f

[Qemu-devel] [PATCH kvm-unit-tests v8 03/10] arm/arm64: add some delay routines

2016-12-08 Thread Andrew Jones
Allow a thread to wait some specified amount of time. Can specify in cycles, usecs, and msecs. Signed-off-by: Andrew Jones --- v8: rewrote basing on new sysreg framework. Also decided delay functions warrant their own files (delay.[ch]) --- arm/Makefile.common | 1 + lib/arm/asm/dela

[Qemu-devel] [PATCH kvm-unit-tests v8 01/10] arm/arm64: yield on cpu_relax

2016-12-08 Thread Andrew Jones
In many tests one or more cpus wait for events from other cpus. However, with TCG, if the event triggering cpus then continue without first informing TCG it should schedule other cpus, then those other cpus may never get scheduled, and never see their events. This is because the TCG scheduler relie

[Qemu-devel] [PATCH kvm-unit-tests v8 00/10] arm/arm64: add gic framework

2016-12-08 Thread Andrew Jones
v8: - Main change is rebasing to Wei's sysreg framework, which is part of his PMU series, which I've applied to arm/next. That rebase leads to dropping the first two patches of the v7 series, expecting get_mpidr() to return u64 (with future patches), a rework of the delay routines (no

[Qemu-devel] [PATCH kvm-unit-tests v8 04/10] arm/arm64: irq enable/disable

2016-12-08 Thread Andrew Jones
Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 10 ++ lib/arm64/asm/processor.h | 10 ++ 2 files changed, 20 insertions(+) diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h index 857bdd96a3cc..6dc1472468

[Qemu-devel] [PATCH kvm-unit-tests v8 02/10] arm/arm64: smp: support more than 8 cpus

2016-12-08 Thread Andrew Jones
By adding support for launching with gicv3 we can break the 8 vcpu limit. This patch adds support to smp code and also selects the vgic model corresponding to the host. The vgic model may also be manually selected by adding e.g. -machine gic-version=3 to extra_params. Reviewed-by: Alex Bennée Rev

[Qemu-devel] [PATCH kvm-unit-tests v8 05/10] arm/arm64: add initial gicv2 support

2016-12-08 Thread Andrew Jones
Add some gicv2 support. This just adds init and enable functions, allowing unit tests to start messing with it. Reviewed-by: Andre Przywara Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v6: added comments (register offset headers) [Alex] v5: share/use only the modern register names [

[Qemu-devel] [PATCH kvm-unit-tests v8 10/10] arm/arm64: gic: don't just use zero

2016-12-08 Thread Andrew Jones
Instead of using cpu0 and irq=0 for the IPI test, use something a bit more interesting. To make sure we can still run the test with the minimal number of cpus (2), we need to use sender=1. As the irq in the test (an SGI) can only be 0 to 15 and there's really no difference, then use irq=1. sender=1

[Qemu-devel] [PATCH kvm-unit-tests v8 06/10] arm/arm64: gicv2: add an IPI test

2016-12-08 Thread Andrew Jones
Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v8: - fix check_spurious print arguments and change the printf to a report_info - remove the self-ipi test issued when no subtest is given, i.e. require a subtest to be given - use report_summary for no supported gic present in

[Qemu-devel] [PATCH kvm-unit-tests v8 08/10] arm/arm64: add initial gicv3 support

2016-12-08 Thread Andrew Jones
Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v8: few sysreg framework and new delay rebase changes v7: split lib/arm/gic.c into gic-v2/3.c [Eric] v6: - added comments [Alex] - added stride parameter to gicv3_set_redist_base [Andre] - redist-wait s/rwp/uwp/

[Qemu-devel] migration: Introduce a new "--only-migratable" option

2016-12-08 Thread Ashijeet Acharya
Hi Dave, I have added the compatibility of this option for both command line and hotplug via qmp and hmp. Although, please confirm that making use of "device_add" is the only way of hotplugging devices into a QEMU instance. With this sorted out, there is one special case left where the device dyn

[Qemu-devel] [PATCH kvm-unit-tests v8 09/10] arm/arm64: gicv3: add an IPI test

2016-12-08 Thread Andrew Jones
Signed-off-by: Andrew Jones --- v8: - keep the gic_common_ops concept completely local to lib/arm/gic.c by instead exposing the more useful concept of gic-specific functions - sysreg rebase changes - ordered ICC registers in spec-order (OCD kicked in...) v7: - add common ipi_send_single

Re: [Qemu-devel] [PATCH v4 42/64] tcg/arm: Handle ctz and clz opcodes

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 4 ++-- > tcg/arm/tcg-target.inc.c | 27 +++ > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h > index 02cc242

Re: [Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

2016-12-08 Thread Paolo Bonzini
On 07/12/2016 16:38, Pranith Kumar wrote: > > Hi Alex, > > Alex Bennée writes: > >> >> Do you have any numbers for this? The main reason being we are trying to >> avoid bouncing the lock too much and while this is cleaner it could >> cause more contention. > > I did not really consider perfor

Re: [Qemu-devel] [PATCH v4 42/64] tcg/arm: Handle ctz and clz opcodes

2016-12-08 Thread Richard Henderson
On 12/08/2016 09:56 AM, Alex Bennée wrote: +if (c && a2 == 32) { +tcg_out_dat_reg(s, COND_AL, INSN_CLZ, a0, 0, a1, 0); +break; +} Why the early break instead of else leg? +tcg_out_dat_imm(s, COND_AL, ARITH_CMP, 0, a1, 0); +tcg_out_dat_re

[Qemu-devel] [QEMU PATCH v16 0/4] migration: migrate QTAILQ

2016-12-08 Thread Jianjun Duan
Hi all, I addressed some review comments. Comments are welcome. v16: - Moved a variable to global in test-vmstate.c following Dave's suggestion. Previous versions are: v15: - Improved error messages. (link: http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg01059.html) v14: -

[Qemu-devel] [QEMU PATCH v16 2/4] migration: migrate QTAILQ

2016-12-08 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list. When

[Qemu-devel] [QEMU PATCH v16 1/4] migration: extend VMStateInfo

2016-12-08 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw/int

[Qemu-devel] [QEMU PATCH v16 3/4] tests/migration: Add test for QTAILQ migration

2016-12-08 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 147 +++ 1 file changed, 147 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..140754d 100644 --- a

[Qemu-devel] [QEMU PATCH v16 4/4] migration: add error_report

2016-12-08 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..8ddd230 100644 --- a/migration/vmstate.c +++ b/migration

Re: [Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free

2016-12-08 Thread Max Reitz
On 08.12.2016 16:23, Eric Blake wrote: > On 12/07/2016 08:28 PM, Gonglei (Arei) wrote: > >>> As far as I'm aware, other projects usually have a special memset >>> variation for doing this. That is because compilers may choose to >>> "optimize" memset(p, ...) + free(p) to just the free(p). Having a

[Qemu-devel] [Bug 1592590] Re: Prevent qemu-img resize from causing "Active L1 table too large"

2016-12-08 Thread Max Reitz
Thanks for the report, sorry for the late reply: This has been fixed in commit 84c26520d3c1c9ff4a10455748139463278816d5 (included in the 2.7.0 release). ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [Qemu-devel] migration: Introduce a new "--only-migratable" option

2016-12-08 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > Hi Dave, > > I have added the compatibility of this option for both command line > and hotplug via qmp and hmp. Although, please confirm that making use > of "device_add" is the only way of hotplugging devices into a QEMU > instance. Hmm; th

Re: [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

2016-12-08 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > Hi, > > On 2016/12/6 23:24, Dr. David Alan Gilbert wrote: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: > > > > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > > > > w

[Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-08 Thread Eduardo Habkost
This adds a new command to QMP: query-device-slots. It will allow management software to query possible slots where devices can be plugged. This implementation of the command will return: * Multiple PCI slots per bus, in the case of PCI buses; * One slot per bus in the case of the other buses; *

[Qemu-devel] Timeslice of vCPU thread in QEMU/KVM is not stable

2016-12-08 Thread Weiwei Jia
Hi everyone, I am testing the timeslice of vCPU thread in QEMU/KVM. In principle, the timeslice should be stable under following workload but it is unstable after I do experiments with following workload. I appreciate it if you can give me some suggestions. Thanks in advance. Workload settings: I

Re: [Qemu-devel] [PATCH v4 23/64] tcg: Allow an operand to be matching or a constant

2016-12-08 Thread Alex Bennée
Richard Henderson writes: > On 12/08/2016 09:19 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> This allows an output operand to match an input operand >>> only when the input operand needs a register. >>> >>> Signed-off-by: Richard Henderson >> >> It's hard to offer anything mor

Re: [Qemu-devel] migration: Introduce a new "--only-migratable" option

2016-12-08 Thread John Snow
On 12/08/2016 02:59 PM, Dr. David Alan Gilbert wrote: > * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: >> Hi Dave, >> >> I have added the compatibility of this option for both command line >> and hotplug via qmp and hmp. Although, please confirm that making use >> of "device_add" is the on

[Qemu-devel] [Bug 613529] Re: qemu does not accept regular disk geometry

2016-12-08 Thread Thomas Huth
Which version of QEMU have you been using for your tests? Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

Re: [Qemu-devel] [PATCH v1 5/9] target-ppc: implement xxextractuw instruction

2016-12-08 Thread David Gibson
On Wed, Dec 07, 2016 at 11:54:58PM +0530, Nikunj A Dadhania wrote: > xxextractuw: VSX Vector Extract Unsigned Word > > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 31 +++ > target-ppc/tra

Re: [Qemu-devel] [PATCH v1 3/9] target-ppc: implement stxvl instruction

2016-12-08 Thread David Gibson
On Wed, Dec 07, 2016 at 11:54:56PM +0530, Nikunj A Dadhania wrote: > stxvl: Store VSX Vector with Length > > Vector (8-bit elements) in BE: > +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ > |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| > +---+---+---+---+---+---

  1   2   >