Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-06 Thread Dou Liyang
Hi Paolo,Stefan, At 12/05/2016 07:57 PM, Paolo Bonzini wrote: On 05/12/2016 12:53, Stefan Hajnoczi wrote: Adding the BlockBackend *query_blk parameter is a reasonable short-term workaround. I wonder if the polling stats APIs need to be rethought in the longer term. Regarding the low-level d

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Greg Kurz
On Mon, 5 Dec 2016 17:01:28 +0100 Cornelia Huck wrote: > On Mon, 5 Dec 2016 16:42:00 +0100 > Cornelia Huck wrote: > > > On Mon, 05 Dec 2016 16:21:22 +0100 > > Greg Kurz wrote: > > > > AFAIK, libvirt's XML doesn't know about modern/legacy modes for virtio > > > devices. Early adopters of vir

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-06 Thread Lan Tianyu
On 2016年12月06日 15:22, Peter Xu wrote: > On Tue, Dec 06, 2016 at 03:06:20PM +0800, Lan Tianyu wrote: >> On 2016年12月06日 14:51, Peter Xu wrote: >>> On Tue, Dec 06, 2016 at 02:30:24PM +0800, Lan Tianyu wrote: >>> >>> [...] >>> >> 2. How to restore GPA->HPA mapping when IOVA is disabled by guest. >>

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-06 Thread David Hildenbrand
Am 30.11.2016 um 09:43 schrieb Liang Li: This patch set contains two parts of changes to the virtio-balloon. One is the change for speeding up the inflating & deflating process, the main idea of this optimization is to use bitmap to send the page information to host instead of the PFNs, to reduc

Re: [Qemu-devel] [PATCH 11/13] target-ppc: implement xsnegqp instruction

2016-12-06 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +case OP_NEG: \ >> +tcg_gen_xor_i64(xbh, xbh, sgm); \ >> +tcg_gen_xori_i64(xbl, xbl, 0);\ >> +

Re: [Qemu-devel] [Nbd] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-06 Thread Alex Bligh
> On 5 Dec 2016, at 23:42, Eric Blake wrote: > > While not directly related to NBD_CMD_WRITE_ZEROES, the qemu > team discovered that it is useful if a server can advertise > whether an export is in a known-all-zeroes state at the time > the client connects. I think this is good to go, and ...

[Qemu-devel] An issue for migration determining the cpu throttle value according to workload

2016-12-06 Thread Chao Fan
Hi all, Here is an issue in auto-converge feature of migration. When migrating a guest which consumes too much CPU & memory, dirty pages amount will increase significantly, so does the migration time, migration can not even complete, at worst. I did some simple tests on this feature. Set the two

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Add xxperm and xxpermr instructions

2016-12-06 Thread Bharata B Rao
On Tue, Dec 06, 2016 at 03:11:22PM +1100, David Gibson wrote: > On Mon, Dec 05, 2016 at 04:55:30PM +0530, Nikunj A Dadhania wrote: > > From: Bharata B Rao > > > > xxperm: VSX Vector Permute > > xxpermr: VSX Vector Permute Right-indexed > > > > Signed-off-by: Bharata B Rao > > Signed-off-by: Ni

Re: [Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-06 Thread Gonglei (Arei)
Hi Herbert, Would you please review and/or ack the virtio_crypto_algs.c? It is the realization of specified algs based on Linux Crypto Framework. Thanks! Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 01, 2016 8:39 PM > To: linux-ker...@vger.k

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Greg Kurz
On Mon, 5 Dec 2016 19:14:40 +0100 Halil Pasic wrote: > On 12/05/2016 06:41 PM, Eduardo Habkost wrote: > > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: > >> > On Mon, 5 Dec 2016 14:48:29 -0200 > >> > Eduardo Habkost wrote: > >> > > >>> > > On Mon, Dec 05, 2016 at 04:42:00PM

Re: [Qemu-devel] [PATCH v4 12/13] aio: self-tune polling time

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 09:06:17PM +0100, Christian Borntraeger wrote: > On 12/01/2016 08:26 PM, Stefan Hajnoczi wrote: > > This patch is based on the algorithm for the kvm.ko halt_poll_ns > > parameter in Linux. The initial polling time is zero. > > > > If the event loop is woken up within the m

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-06 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 01:23:31AM +, Gonglei (Arei) wrote: > > > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Tuesday, December 06, 2016 12:59 AM > > To: Gonglei (Arei) > > Cc: longpeng; ebl...@redhat.com; arm...@redhat.com; > > qemu-devel@nongnu.org; Wubin (H); Zhoujian (

Re: [Qemu-devel] [kvm-unit-tests RFC 03/15] arm/arm64: ITS skeleton

2016-12-06 Thread Andrew Jones
On Mon, Dec 05, 2016 at 10:46:34PM +0100, Eric Auger wrote: > At the moment we just detect the presence of ITS as part of the > GICv3 init routine and initialize its base address. > > Signed-off-by: Eric Auger > --- > arm/Makefile.common| 1 + > lib/arm/asm/gic-v3-its.h | 22 +

Re: [Qemu-devel] [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-06 Thread Kevin Wolf
Am 06.12.2016 um 00:42 hat Eric Blake geschrieben: > While not directly related to NBD_CMD_WRITE_ZEROES, the qemu > team discovered that it is useful if a server can advertise > whether an export is in a known-all-zeroes state at the time > the client connects. Does a server usually have the infor

Re: [Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 10:40:49AM -0600, Karl Rister wrote: > On 12/05/2016 08:56 AM, Stefan Hajnoczi wrote: > > > > Karl: do you have time to run a bigger suite of benchmarks to identify a > > reasonable default poll-max-ns value? Both aio=native and aio=threads > > are important. > > > > If

Re: [Qemu-devel] [kvm-unit-tests RFC 05/15] arm/arm64: GICv3: add cpu count

2016-12-06 Thread Andrew Jones
On Mon, Dec 05, 2016 at 10:46:36PM +0100, Eric Auger wrote: > Add a new cpu_count field in gicv3_data indicating the > number of redistributors. This will be useful for enumeration > of their resources such as LPI pending tables. I'm fine with the additional state, but just curious, will it ever b

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Greg Kurz
On Mon, 5 Dec 2016 15:41:30 -0200 Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: > > On Mon, 5 Dec 2016 14:48:29 -0200 > > Eduardo Habkost wrote: > > > > > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > > > > On Mon, 05 Dec 2016 16:

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-06 Thread Gonglei (Arei)
> > > > > > > } > > > > > > diff --git a/qapi/crypto.json b/qapi/crypto.json > > > > > > index 5c9d7d4..d403ab9 100644 > > > > > > --- a/qapi/crypto.json > > > > > > +++ b/qapi/crypto.json > > > > > > @@ -75,7 +75,7 @@ > > > > > > { 'enum': 'QCryptoCipherAlgorithm', > > > > > >'prefix

Re: [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-06 Thread David Hildenbrand
Am 06.12.2016 um 00:57 schrieb Eduardo Habkost: On Mon, Dec 05, 2016 at 07:18:47PM +0100, David Hildenbrand wrote: Am 02.12.2016 um 22:18 schrieb Eduardo Habkost: The query-cpu-model-expand QMP command needs at least one static model, to allow the "static" expansion mode to be implemented. Inst

Re: [Qemu-devel] [kvm-unit-tests RFC 05/15] arm/arm64: GICv3: add cpu count

2016-12-06 Thread Andre Przywara
Hi, On 06/12/16 09:29, Andrew Jones wrote: > On Mon, Dec 05, 2016 at 10:46:36PM +0100, Eric Auger wrote: >> Add a new cpu_count field in gicv3_data indicating the >> number of redistributors. This will be useful for enumeration >> of their resources such as LPI pending tables. > > I'm fine with t

Re: [Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 10:22:12AM -0500, Paolo Bonzini wrote: > > Anyway, I'm glad the polling series on its own is already showing good > > performance results. I'd like to merge it at the beginning of QEMU 2.9 > > so we can work on further improvements that build on top of it. > > Yes, it woul

Re: [Qemu-devel] [PATCH for 2.8 v3 1/1] cadence_uart: Check baud rate generator and divider values on migration

2016-12-06 Thread Peter Maydell
On 5 December 2016 at 18:35, Alistair Francis wrote: > The Cadence UART device emulator calculates speed by dividing the > baud rate by a 'baud rate generator' & 'baud rate divider' value. > The device specification defines these register values to be > non-zero and within certain limits. Checks w

Re: [Qemu-devel] [PULL for-2.8 0/4] vga fixes

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 12:03:56PM +0100, Gerd Hoffmann wrote: > Hi, > > Here is a last-minute poll for 2.8-rc3, bringing some vga fixes. > > Most important one is the qxl fix which is quite user-visible. > Sorry for submitting that late, it lingers in my queue for a while > already and I throu

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-06 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > > Record/replay without this option uses '-snapshot' to preserve > > the state o

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 04:21:22PM +0100, Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent. So, if you have: > > -global virtio-pci.disable-modern=on > -global virtio-blk-pci.disable-modern=off > > Then the default value of disable-modern for a v

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8 v2] qcow2: Don't strand clusters near 2G intervals during commit

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 09:49:34AM -0600, Eric Blake wrote: > The qcow2_make_empty() function is reached during 'qemu-img commit', > in order to clear out ALL clusters of an image. However, if the > image cannot use the fast code path (true if the image is format > 0.10, or if the image contains a

Re: [Qemu-devel] [kvm-unit-tests RFC 00/15] arm/arm64: add ITS framework

2016-12-06 Thread Andrew Jones
On Mon, Dec 05, 2016 at 10:46:31PM +0100, Eric Auger wrote: > This series proposes a framework to test the virtual ITS. > This is based on Drew's v7 series [1]. The last patch tests > several ITS commands (collection/device mapping, interrupt > translation service entry creation and LPI trigger thr

[Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

2016-12-06 Thread Gonglei
Zeroize the memory of CryptoDevBackendSymOpInfo structure pointed for key material security. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 2f2467e.

Re: [Qemu-devel] [PULL 0/9] QAPI patches for 2016-12-05

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 05:45:04PM +0100, Markus Armbruster wrote: > A set of fixes for MacOS from Eric, and a little documentation > polishing from Marc-André. The diffstat for the .json may look scary, > but the generated code is identical. > > The following changes since commit bd8ef5060dd2124

Re: [Qemu-devel] [PULL 0/1] target-arm queue

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 05:59:34PM +, Peter Maydell wrote: > One patch for 2.8-rc3, which is Alex's partial revert > of 1dd089d0 to fix A64 ldaxp. > > thanks > -- PMM > > The following changes since commit bc66cedb4141fb7588f2462c74310d8fb5dd4cf1: > > Merge remote-tracking branch 'yongbok/

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Greg Kurz
On Tue, 6 Dec 2016 09:47:08 + Stefan Hajnoczi wrote: > On Mon, Dec 05, 2016 at 04:21:22PM +0100, Greg Kurz wrote: > > The current code recursively applies global properties from child up to > > parent. So, if you have: > > > > -global virtio-pci.disable-modern=on > > -global virtio-blk-pci.d

Re: [Qemu-devel] [RFC PATCH] glusterfs: allow partial reads

2016-12-06 Thread Kevin Wolf
Am 05.12.2016 um 09:26 hat Wolfgang Bumiller geschrieben: > On Fri, Dec 02, 2016 at 01:13:28PM -0600, Eric Blake wrote: > > On 12/01/2016 04:59 AM, Wolfgang Bumiller wrote: > > > Fixes #1644754. > > > > > > Signed-off-by: Wolfgang Bumiller > > > --- > > > I'm not sure what the original rationale

Re: [Qemu-devel] [kvm-unit-tests RFC 05/15] arm/arm64: GICv3: add cpu count

2016-12-06 Thread Auger Eric
Hi Andre, Drew, On 06/12/2016 10:32, Andre Przywara wrote: > Hi, > > On 06/12/16 09:29, Andrew Jones wrote: >> On Mon, Dec 05, 2016 at 10:46:36PM +0100, Eric Auger wrote: >>> Add a new cpu_count field in gicv3_data indicating the >>> number of redistributors. This will be useful for enumeration >

Re: [Qemu-devel] [Qemu-block] [PULL for-2.8 0/3] Block patches for -rc3

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 04:31:58PM -0500, Jeff Cody wrote: > The following changes since commit bc66cedb4141fb7588f2462c74310d8fb5dd4cf1: > > Merge remote-tracking branch 'yongbok/tags/mips-20161204' into staging > (2016-12-05 10:56:45 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 03/13] target-ppc: implement lxvl instruction

2016-12-06 Thread Nikunj A Dadhania
Richard Henderson writes: >> +void helper_lxvl(CPUPPCState *env, target_ulong addr, >> + target_ulong xt_num, target_ulong rb) >> +{ >> +ppc_vsr_t xt; >> + >> +getVSR(xt_num, &xt, env); >> +if (unlikely((rb & 0xFF) == 0)) { >> +xt.s128 = int128_make128(0, 0); >>

Re: [Qemu-devel] [PATCH v4 12/13] aio: self-tune polling time

2016-12-06 Thread Christian Borntraeger
On 12/06/2016 10:20 AM, Stefan Hajnoczi wrote: > On Mon, Dec 05, 2016 at 09:06:17PM +0100, Christian Borntraeger wrote: >> On 12/01/2016 08:26 PM, Stefan Hajnoczi wrote: >>> This patch is based on the algorithm for the kvm.ko halt_poll_ns >>> parameter in Linux. The initial polling time is zero. >

Re: [Qemu-devel] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 05:42:35PM -0600, Eric Blake wrote: > While not directly related to NBD_CMD_WRITE_ZEROES, the qemu > team discovered that it is useful if a server can advertise > whether an export is in a known-all-zeroes state at the time > the client connects. > > Signed-off-by: Eric Bla

Re: [Qemu-devel] [PULL V2 0/3] Net patches

2016-12-06 Thread Stefan Hajnoczi
On Tue, Dec 06, 2016 at 10:32:29AM +0800, Jason Wang wrote: > The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: > > Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into > staging (2016-12-01 13:39:29 +) > > are available in the git repository at:

Re: [Qemu-devel] [Nbd] [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-06 Thread Alex Bligh
> On 6 Dec 2016, at 09:25, Kevin Wolf wrote: > > Am 06.12.2016 um 00:42 hat Eric Blake geschrieben: >> While not directly related to NBD_CMD_WRITE_ZEROES, the qemu >> team discovered that it is useful if a server can advertise >> whether an export is in a known-all-zeroes state at the time >> th

Re: [Qemu-devel] [Nbd] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

2016-12-06 Thread Alex Bligh
> On 6 Dec 2016, at 08:46, Alex Bligh wrote: > > I would support this. > > In fact the patch is sufficiently simple I think I'd merge this > into extension-write-zeroes then merge that into master. Hence: Reviewed-By: Alex Bligh -- Alex Bligh

[Qemu-devel] [RFC PATCH 01/13] intel_iommu: allocate new key when creating new address space

2016-12-06 Thread Peter Xu
From: Jason Wang We use the pointer to stack for key for new address space, this will break hash table searching, fixing by g_malloc() a new key instead. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: Peter Xu Signed-off-by: Jason Wang Signed-o

[Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup

2016-12-06 Thread Peter Xu
This RFC series is a continue work for Aviv B.D.'s vfio enablement series with vt-d. Aviv has done a great job there, and what we still lack there are mostly the following: (1) VFIO got duplicated IOTLB notifications due to splitted VT-d IOMMU memory region. (2) VT-d still haven't provide a c

[Qemu-devel] [RFC PATCH 03/13] intel_iommu: renaming gpa to iova where proper

2016-12-06 Thread Peter Xu
There are lots of places in current intel_iommu.c codes that named "iova" as "gpa". It is really confusing to use a name "gpa" in these places (which is very easily to be understood as "Guest Physical Address", while it's not). To make the codes (much) easier to be read, I decided to do this once a

[Qemu-devel] [RFC PATCH 05/13] intel_iommu: fix trace for addr translation

2016-12-06 Thread Peter Xu
Another patch to convert the DPRINTF() stuffs. This patch focuses on the address translation path and caching. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 87 --- hw/i386/trace-events | 7 + 2 files changed, 48 insertions(+), 46 delet

[Qemu-devel] [RFC PATCH 02/13] intel_iommu: simplify irq region translation

2016-12-06 Thread Peter Xu
Before we have int-remap, we need to bypass interrupt write requests. That's not necessary now - we have supported int-remap, and all the irq region requests should be redirected there. Cleaning up the block with an assertion instead. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 29 ++

[Qemu-devel] [RFC PATCH 04/13] intel_iommu: fix trace for inv desc handling

2016-12-06 Thread Peter Xu
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do it. Generally, the rule of mine is: - f

[Qemu-devel] [RFC PATCH 07/13] memory: add section range info for IOMMU notifier

2016-12-06 Thread Peter Xu
In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check the notification type (MAP|UNMAP), but also check whether the notified iova is in the range of specific IOMMU notifier, and skip those notifiers

[Qemu-devel] [RFC PATCH 06/13] intel_iommu: vtd_slpt_level_shift check level

2016-12-06 Thread Peter Xu
This helps in debugging incorrect level passed in. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 0f8387e..46b8a2f 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -188,6 +

[Qemu-devel] [RFC PATCH 09/13] memory: introduce memory_region_notify_one()

2016-12-06 Thread Peter Xu
Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Signed-off-by: Peter Xu --- include/exec/memory.h | 15 +++ memory.c | 29 ++--- 2 files ch

[Qemu-devel] [RFC PATCH 08/13] memory: provide iommu_replay_all()

2016-12-06 Thread Peter Xu
This is an "global" version of exising memory_region_iommu_replay() - we announce the translations to all the registered notifiers, instead of a specific one. Signed-off-by: Peter Xu --- include/exec/memory.h | 8 memory.c | 9 + 2 files changed, 17 insertions(+) d

[Qemu-devel] [RFC PATCH 11/13] intel_iommu: provide its own replay() callback

2016-12-06 Thread Peter Xu
The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally bring a dead loop when guest starts. The solution is simple - we don't walk over all the regions. Instead, we jump over the regions when we found tha

[Qemu-devel] [RFC PATCH 10/13] memory: add MemoryRegionIOMMUOps.replay() callback

2016-12-06 Thread Peter Xu
Originally we have one memory_region_iommu_replay() function, which is the default behavior to replay the translations of the whole IOMMU region. However, on some platform like x86, we may want our own replay logic for IOMMU regions. This patch add one more hook for IOMMUOps for the callback, and i

[Qemu-devel] [RFC PATCH 13/13] intel_iommu: use page_walk for iotlb inv notify

2016-12-06 Thread Peter Xu
Instead of translate() every page for iotlb invalidations (which is slower), we walk the pages when needed and notify in a hook function. This will also simplify the code a bit. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 64 +++ 1 file cha

[Qemu-devel] [RFC PATCH 12/13] intel_iommu: do replay when context invalidate

2016-12-06 Thread Peter Xu
Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). In that case we need to notify all the registered components about the new mapping. Si

Re: [Qemu-devel] [Spice-devel] Postcopy+spice crash

2016-12-06 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > >> On a quick glance I'd blame the guest for sending corrupted commands. > > >> Strange though that it happens on migration only, so there could be > > >> a host issue too. Or a timing issue triggered by migration. > > >> > > >> Which migra

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-06 Thread Igor Mammedov
On Thu, 1 Dec 2016 18:06:19 +0100 Laszlo Ersek wrote: > We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could > lead to problems with backward migration: a more recent QEMU (running an > older machine type) would allow the guest, in fw_cfg_select(), to select a > high key val

Re: [Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup

2016-12-06 Thread Peter Xu
On Tue, Dec 06, 2016 at 06:36:15PM +0800, Peter Xu wrote: > This RFC series is a continue work for Aviv B.D.'s vfio enablement > series with vt-d. Aviv has done a great job there, and what we still > lack there are mostly the following: > > (1) VFIO got duplicated IOTLB notifications due to splitt

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-06 Thread Peter Xu
On Tue, Dec 06, 2016 at 04:27:39PM +0800, Lan Tianyu wrote: [...] > > > >> User space driver(E.G DPDK) also can enable/disable > >> IOVA for device dynamically. > > > > Could you provide more detailed (or any pointer) on how to do that? I > > did try to find it myself, I see an VFIO_IOMMU_ENABL

Re: [Qemu-devel] [Qemu-block] Meeting notes on -blockdev, dynamic backend reconfiguration

2016-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 01:03:50PM +0100, Markus Armbruster wrote: > I recently met Kevin, and we discussed two block layer topics in some > depth. Thanks for sharing this. Both topics were a good read and the direction you are heading in looks good. Stefan signature.asc Description: PGP signa

[Qemu-devel] RISU TCG failures (AArch64 on AArch64)

2016-12-06 Thread Alex Bennée
Hi Claudio, I've been fixing up the RISU tests for AArch64 while I was reviewing Richard's latest TCG series. In the process I discovered a bunch of them fail when run on an ARMv8 host using TCG although they pass on my x86_64 desktop machine. I'm assuming (but I could be wrong) this means the bu

[Qemu-devel] [PATCH] qemu-img: fix in-flight count for qemu-img bench

2016-12-06 Thread Paolo Bonzini
With aio=native (qemu-img bench -n) one or more requests can be completed when a new request is submitted. This in turn can cause bench_cb to recurse before b->in_flight is updated. The blk_aio_pwritev coroutines are never freed, and qemu-img aborts. Signed-off-by: Paolo Bonzini --- qemu-img.c

Re: [Qemu-devel] [kvm-unit-tests RFC 00/15] arm/arm64: add ITS framework

2016-12-06 Thread Andre Przywara
Hi, On 06/12/16 09:48, Andrew Jones wrote: > On Mon, Dec 05, 2016 at 10:46:31PM +0100, Eric Auger wrote: >> This series proposes a framework to test the virtual ITS. >> This is based on Drew's v7 series [1]. The last patch tests >> several ITS commands (collection/device mapping, interrupt >> tran

Re: [Qemu-devel] [PATCH] qemu-img: fix in-flight count for qemu-img bench

2016-12-06 Thread Kevin Wolf
Am 06.12.2016 um 12:08 hat Paolo Bonzini geschrieben: > With aio=native (qemu-img bench -n) one or more requests can be completed > when a new request is submitted. This in turn can cause bench_cb to > recurse before b->in_flight is updated. The blk_aio_pwritev coroutines > are never freed, and q

Re: [Qemu-devel] [kvm-unit-tests RFC 00/15] arm/arm64: add ITS framework

2016-12-06 Thread Andrew Jones
On Tue, Dec 06, 2016 at 11:14:41AM +, Andre Przywara wrote: > Hi, > > On 06/12/16 09:48, Andrew Jones wrote: > > On Mon, Dec 05, 2016 at 10:46:31PM +0100, Eric Auger wrote: > >> This series proposes a framework to test the virtual ITS. > >> This is based on Drew's v7 series [1]. The last patch

Re: [Qemu-devel] RISU TCG failures (AArch64 on AArch64)

2016-12-06 Thread Peter Maydell
On 6 December 2016 at 11:06, Alex Bennée wrote: A quick eyeball of the logs: > loading test image > testcases.aarch64/insn_ADDPv_ADD_RES1_ADD_RES2_ADDS__INC.risu.bin... > starting apprentice image at 0x4000801000 > Executed 100 test instructions (pc=0x4000801574).Executed 200 test > instructio

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-06 Thread Laszlo Ersek
On 12/06/16 11:50, Igor Mammedov wrote: > On Thu, 1 Dec 2016 18:06:19 +0100 > Laszlo Ersek wrote: > >> We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could >> lead to problems with backward migration: a more recent QEMU (running an >> older machine type) would allow the gues

Re: [Qemu-devel] [PATCH v5 13/17] qapi: add qapi2texi script

2016-12-06 Thread Markus Armbruster
I had to resort to diff to find your replies, and massage the text manually to produce a readable reply myself. Please quote the usual way. > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> As the name suggests, the qapi2texi script converts JSON QAPI > >> description into a

Re: [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

2016-12-06 Thread Igor Mammedov
On Thu, 1 Dec 2016 18:06:20 +0100 Laszlo Ersek wrote: > Accordingly, generalize the "file_slots" minimum calculation in > fw_cfg_init_io_dma(), and move the constant FW_CFG_FILE_SLOTS_TRAD > argument to the callers of fw_cfg_init_io_dma(). If I get idea correctly you're extending fw_cfg_init_io_

Re: [Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-06 Thread Igor Mammedov
On Tue, 6 Dec 2016 12:43:06 +0100 Laszlo Ersek wrote: > On 12/06/16 11:50, Igor Mammedov wrote: > > On Thu, 1 Dec 2016 18:06:19 +0100 > > Laszlo Ersek wrote: > > > >> We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could > >> lead to problems with backward migration: a mo

[Qemu-devel] [Bug 1646610] Re: "Assertion `!r->req.sg' failed." during live migration with VirtIO

2016-12-06 Thread Thomas Huth
Which version of QEMU are you using? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1646610 Title: "Assertion `!r->req.sg' failed." during live migration with VirtIO Status in QEMU: New Bug desc

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Halil Pasic
On 12/06/2016 10:30 AM, Greg Kurz wrote: > On Mon, 5 Dec 2016 15:41:30 -0200 > Eduardo Habkost wrote: > >> > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: >>> > > On Mon, 5 Dec 2016 14:48:29 -0200 >>> > > Eduardo Habkost wrote: >>> > > > > > On Mon, Dec 05, 2016 at 04:

[Qemu-devel] [Bug 1647683] [NEW] Bad interaction between tb flushing & gdb stub

2016-12-06 Thread Julian Brown
Public bug reported: I have been working on a series of patches for ARM big-endian system mode support, using QEMU as a bare-metal simulator for the GDB test suite. At some point I realised that these tests were not running reliably on the QEMU master branch, even without my patches applied. (I.e.

[Qemu-devel] [Bug 1221966] Re: SIGSEGV in static_code_gen_buffer

2016-12-06 Thread Thomas Huth
Triaging old bug tickets ... is this still an issue with the latest version of QEMU or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2016-12-06 Thread Thomas Huth
Looks like Petar's patch from comment #6 has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=4d66261f71f2efa31e1052e ==> Fix released ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [Bug 1647683] Re: Bad interaction between tb flushing & gdb stub

2016-12-06 Thread Julian Brown
(FAOD, the crashes happen without Valgrind too, and the above backtrace may be a red herring.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1647683 Title: Bad interaction between tb flushing & gdb

Re: [Qemu-devel] [PATCH v4 04/64] tcg/aarch64: Implement field extraction opcodes

2016-12-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 8 > tcg/aarch64/tcg-target.inc.c | 14 ++ > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h > index

[Qemu-devel] [Bug 1243639] Re: qemu-1.5.3 segment fault with -vga qxl

2016-12-06 Thread Thomas Huth
Triaging old bug tickets ... QEMU 1.5 is quite old already - can you still reproduce the crash with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Qemu-devel] [Bug 1248469] Re: qemu 1.6.1 q35 ioh3420 not work in windows 7 32bit

2016-12-06 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1248469 Title: qemu 1.6.1 q

Re: [Qemu-devel] [PATCH v4 05/64] tcg/arm: Move isa detection to tcg-target.h

2016-12-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson A slightly expanded commit message to mention why you are moving it wouldn't go amiss. Otherwise: Reviewed-by: Alex Bennée > --- > tcg/arm/tcg-target.h | 36 > tcg/arm/tcg-target.inc.c | 4

Re: [Qemu-devel] [Bug 1647683] [NEW] Bad interaction between tb flushing & gdb stub

2016-12-06 Thread Peter Maydell
On 6 December 2016 at 11:39, Julian Brown <1647...@bugs.launchpad.net> wrote: > Running QEMU under GDB in the test harness via Valgrind, using something > akin to: > > (gdb) target remote | valgrind --tool=memcheck qemu-arm-system [...] > > leads to intermittent (and quite hard-to-reproduce) segfau

Re: [Qemu-devel] [Spice-devel] Postcopy+spice crash

2016-12-06 Thread Gerd Hoffmann
Hi, Yep, spice worker thread ... > Thread 7 (Thread 0x7fbe7f9ff700 (LWP 22383)): > #0 0x7fc0aa42f49d in read () from /lib64/libpthread.so.0 > #1 0x7fc0a8c36c01 in spice_backtrace_gstack () from > /lib64/libspice-server.so.1 > #2 0x7fc0a8c3e4f7 in spice_logv () from /lib64/libspi

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

2016-12-06 Thread Halil Pasic
On 12/06/2016 10:11 AM, Greg Kurz wrote: >> Given the current doc: >> > """ >> > -global driver.prop=value >> > -global driver=driver,property=property,value=value >> > Set default value of driver's property prop to value, e.g.: >> > >> > qemu-system-i386 -global ide-drive.physical_

Re: [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 10:32:48AM +0100, David Hildenbrand wrote: [...] > > > > I would like to hear from libvirt developers what they think. I > > still don't know what they plan to use the type=static expansion > > results for. > > > > > > > > How long is the static expansion on a recent inte

[Qemu-devel] [Bug 1221966] Re: SIGSEGV in static_code_gen_buffer

2016-12-06 Thread Peter Maydell
Also I just noticed that the original report says the crash is while trying to run a SunOS binary. This isn't supported at all -- we can run Linux Sparc binaries with qemu-sparc, not random-other-OS binaries, and "guest binary crashes" is not an implausible result... -- You received this bug noti

Re: [Qemu-devel] [PATCH v5 13/17] qapi: add qapi2texi script

2016-12-06 Thread Marc-André Lureau
Hi On Tue, Dec 6, 2016 at 2:50 PM Markus Armbruster wrote: > I had to resort to diff to find your replies, and massage the text > manually to produce a readable reply myself. Please quote the usual > way. > > I'd have to switch to something else than gmail (which bothers me for various reasons,

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-06 Thread Wouter Verhelst
Hi John Sorry for the late reply; weekend was busy, and so was monday. On Fri, Dec 02, 2016 at 03:39:08PM -0500, John Snow wrote: > On 12/02/2016 01:45 PM, Alex Bligh wrote: > > John, > > > >>> +Some storage formats and operations over such formats express a > >>> +concept of data dirtiness. Whe

Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

2016-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2016 at 05:29:13PM +0800, Gonglei wrote: > Zeroize the memory of CryptoDevBackendSymOpInfo structure pointed > for key material security. > > Signed-off-by: Gonglei > --- > hw/virtio/virtio-crypto.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff -

Re: [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

2016-12-06 Thread Kevin Wolf
Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > which migration aborted QEMU because it didn't regain the control > of images while some errors happened. > > Actually, we have another case in that error path to abort QEMU > bec

Re: [Qemu-devel] [Bug 1647683] [NEW] Bad interaction between tb flushing & gdb stub

2016-12-06 Thread Peter Maydell
On 6 December 2016 at 12:34, Peter Maydell wrote: > I saw something similar the other day as well, not involving valgrind, > just a simple gdb connected to the gdbstub. http://people.linaro.org/~peter.maydell/gdbstub-bug.tgz is a repro case for this (with an aarch64 kernel guest). Segfaults every

[Qemu-devel] [PATCH v6 01/17] qapi: improve device_add schema

2016-12-06 Thread Marc-André Lureau
'device_add' is still incomplete for now, but we can fix a few arguments: - 'bus' is a common argument, regardless of the device - 'id' is an optional argument Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed,

[Qemu-devel] [PATCH v6 02/17] qapi: improve TransactionAction doc

2016-12-06 Thread Marc-André Lureau
TransactionAction is a flat union, document 'type' versions exhaustively, and sort the members. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- qapi-schema.json | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/qapi-schema.

[Qemu-devel] [PATCH v6 04/17] qapi: add some sections in docs

2016-12-06 Thread Marc-André Lureau
Add some more section titles to organize the documentation we're going to generate. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- qapi-schema.json | 4 qapi/block-core.json | 6 -- qapi/block.json | 10 -- qapi/common.json | 6 -- qapi/

[Qemu-devel] [PATCH v6 00/17] qapi doc generation (whole version, squashed)

2016-12-06 Thread Marc-André Lureau
Add a qapi2texi script to generate the documentation from the qapi schemas. The SQUASHED patch in this series is a squashed version of the documentation move from qmp-commands.txt to the schemas. The whole version (not sent on the ML to avoid spamming) is in the following git branch: https://githu

[Qemu-devel] [PATCH v6 13/17] build-sys: use --no-split for info

2016-12-06 Thread Marc-André Lureau
Splitting the info files doesn't bring much benefits these days. This fixes also untracked generated info files from git ignore. Let's use MAKEINFOFLAGS for common flags, --number-sections is already the default anyway, so adding it doesn't change the info output. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v6 03/17] qga/schema: improve guest-set-vcpus Returns: section

2016-12-06 Thread Marc-André Lureau
Itemize the possible return values of guest-set-vcpus. Signed-off-by: Marc-André Lureau --- qga/qapi-schema.json | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 94c03128fd..ad63737fce 100644 --- a/qga/qapi-schema.json

[Qemu-devel] [PATCH v6 10/17] json: reorder documentation body

2016-12-06 Thread Marc-André Lureau
Place the body of expression documentation at the top (after the @symbol:). This prevents ambiguity with other argument or tagged-section documentation. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 83 ++-- qapi/block-core.json | 14

[Qemu-devel] [PATCH v6 14/17] build-sys: remove dvi doc generation

2016-12-06 Thread Marc-André Lureau
There is no clear reason to have rules to generate dvi format documentation, pdf is generally better supported. Signed-off-by: Marc-André Lureau --- Makefile | 12 .gitignore | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 0bc470d97

[Qemu-devel] [PATCH v6 16/17] build-sys: add txt documentation rules

2016-12-06 Thread Marc-André Lureau
Build txt documentation, and install it. Signed-off-by: Marc-André Lureau --- Makefile | 12 +--- .gitignore | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index d18bac1c31..37d45ee21b 100644 --- a/Makefile +++ b/Makefile @@ -81,7 +81,7 @@ M

[Qemu-devel] [PATCH v6 05/17] docs: add master qapi texi files

2016-12-06 Thread Marc-André Lureau
The qapi2texi script generates a file to be included in a texi file. Add "QEMU QMP Reference Manual" and "QEMU Guest Agent Protocol Reference" master texi files. Signed-off-by: Marc-André Lureau --- docs/qapi-syntax.texi | 175 + docs/qemu-ga-ref.

[Qemu-devel] [PATCH v6 06/17] qapi: rework qapi Exception

2016-12-06 Thread Marc-André Lureau
Use a base class QAPIError, and QAPIParseError for parser errors and QAPISemError for semantic errors, suggested by Markus Armbruster. Signed-off-by: Marc-André Lureau --- scripts/qapi.py | 338 ++-- 1 file changed, 158 insertions(+), 180 delet

  1   2   3   >