Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-01 Thread Lan Tianyu
On 2016年12月01日 12:21, Tian, Kevin wrote: >> I am thinking about this replay thing recently and now I start to >> > doubt whether the whole vt-d vIOMMU framework suites this... >> > >> > Generally speaking, current work is throwing away the IOMMU "domain" >> > layer here. We maintain the mapping on

[Qemu-devel] QEMU Advent Calendar 2016

2016-12-01 Thread Thomas Huth
Hi all, it's now December 1st, so the first door of the QEMU Advent Calendar 2016 can now be opened: http://www.qemu-advent-calendar.org/2016/#day-1 For the next 23 days, we are going to present a new disk image each day, so if you like, stop by regularly (I won't send a reminder each day).

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-01 Thread Lan Tianyu
On 2016年11月30日 17:23, Peter Xu wrote: > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: >> * intel_iommu's replay op is not implemented yet (May come in different >> patch >> set). >> The replay function is required for hotplug vfio device and to move >> devices >> between exist

Re: [Qemu-devel] GTK UI keycodes broken under Wayland

2016-12-01 Thread Thomas Huth
On 01.12.2016 08:24, Stefan Hajnoczi wrote: > I recently upgraded to Fedora 25 which runs Wayland by default. > > The GTK UI is now sending unknown keycodes to the guests. Although > alphanumeric keys work, the cursor keys are broken. > > There is X11-specific code for keycode mapping in ui/gtk.

Re: [Qemu-devel] QEMU Advent Calendar 2016

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 8:24 AM, Thomas Huth wrote: > it's now December 1st, so the first door of the QEMU Advent Calendar > 2016 can now be opened: > > http://www.qemu-advent-calendar.org/2016/#day-1 > > For the next 23 days, we are going to present a new disk image each day, > so if you like,

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-01 Thread Paolo Bonzini
- Original Message - > From: "Alessandro Di Federico" > To: "Paolo Bonzini" , "Liviu Ionescu" > Cc: "qemu-devel" > Sent: Thursday, December 1, 2016 12:01:12 AM > Subject: Re: [Qemu-devel] Support for using TCG frontend as a library > > On Tue, 29 Nov 2016 17:26:59 +0100 > Paolo Bonzin

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Andrew Jones
Should this be From: Andre? On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: > This patch defines four macros to assist creating system register > accessors under both ARMv7 and AArch64: >* DEFINE_GET_SYSREG32(name, ...) >* DEFINE_SET_SYSREG32(name, ...) >* DEFINE_GET_SYSREG

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 2/4] arm: Add PMU test

2016-12-01 Thread Andrew Jones
On Wed, Nov 30, 2016 at 11:16:40PM -0600, Wei Huang wrote: > From: Christopher Covington > > Beginning with a simple sanity check of the control register, add > a unit test for the ARM Performance Monitors Unit (PMU). PMU register > was read using the newly defined macros. > > Signed-off-by: Chr

Re: [Qemu-devel] QEMU 2.8 release approaching

2016-12-01 Thread Stefan Hajnoczi
On Wed, Nov 30, 2016 at 3:42 PM, Stefan Hajnoczi wrote: > If you are currently looking into pending issues or have bug fixes > needing attention from maintainers, please reply to this email. Laszlo, Gonglei, Thanks for pointing out these patches that should be included in QEMU 2.8. Patches still

[Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/event

2016-12-01 Thread Paolo Bonzini
This avoids taking the active_timers_lock or resetting/setting the timers_done_ev if there are no active timers. This removes a small (2-3%) source of overhead for dataplane. The list is then checked again inside the lock, or a NULL pointer could be dereferenced. Signed-off-by: Paolo Bonzini --

Re: [Qemu-devel] QEMU 2.8 release approaching

2016-12-01 Thread Hailiang Zhang
Cc: Juan Quintela Cc: Amit Shah Hi Stefan, I have one, but I'm not quite sure.Anyway, we caught this bug in our test. [PATCH] migration: re-active images when migration fails to complete Thanks, hailiang On 2016/11/30 23:42, Stefan Hajnoczi wrote: Dear QEMU community, QEMU 2.8.0-rc3 will b

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 3/4] arm: pmu: Check cycle count increases

2016-12-01 Thread Andrew Jones
On Wed, Nov 30, 2016 at 11:16:41PM -0600, Wei Huang wrote: > From: Christopher Covington > > Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, > even for the smallest delta of two subsequent reads. > > Signed-off-by: Christopher Covington > Signed-off-by: Wei Huang > Reviewed-

Re: [Qemu-devel] [PATCH v5 00/19] Cleanup of TCG tests

2016-12-01 Thread Peter Maydell
On 1 December 2016 at 05:14, Pranith Kumar wrote: > Hello, > > This patch series cleans up the tcg tests in tests/tcg folder. > linux-user/mmap.c | 27 +++--- > linux-user/syscall.c| 2 +- These aren't test code -- it would probably be better not to m

Re: [Qemu-devel] [PATCH] monitor: fix object_del for command-line-created objects

2016-12-01 Thread Daniel P. Berrange
On Wed, Nov 30, 2016 at 05:06:16PM -0600, Michael Roth wrote: > Currently objects specified on the command-line are only partially > cleaned up when 'object_del' is issued in either HMP or QMP: the > object itself is fully finalized, but the QemuOpts are not removed. > This results in the following

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

2016-12-01 Thread Andrew Jones
On Wed, Nov 30, 2016 at 11:16:42PM -0600, Wei Huang wrote: > From: Christopher Covington > > Calculate the numbers of cycles per instruction (CPI) implied by ARM > PMU cycle counter values. The code includes a strict checking facility > intended for the -icount option in TCG mode in the configura

[Qemu-devel] [PATCH] ui: use evdev keymap when running under wayland

2016-12-01 Thread Daniel P. Berrange
Wayland always uses evdev as its input source, so QEMU can use the existing evdev keymap data Signed-off-by: Daniel P. Berrange --- ui/gtk.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e816428..81dba57 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -90,6 +90,9 @

Re: [Qemu-devel] GTK UI keycodes broken under Wayland

2016-12-01 Thread Daniel P. Berrange
On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote: > On 01.12.2016 08:24, Stefan Hajnoczi wrote: > > I recently upgraded to Fedora 25 which runs Wayland by default. > > > > The GTK UI is now sending unknown keycodes to the guests. Although > > alphanumeric keys work, the cursor keys are

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Andrew Jones
On Thu, Dec 01, 2016 at 09:59:03AM +0100, Andrew Jones wrote: > > Should this be From: Andre? > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: > > This patch defines four macros to assist creating system register > > accessors under both ARMv7 and AArch64: > >* DEFINE_GET_SYSREG

[Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Daniel P. Berrange
Wayland always uses evdev as its input source, so QEMU can use the existing evdev keymap data Signed-off-by: Daniel P. Berrange --- Changed in v2 - Actually add all changed files to commit - gtk.h :-) include/ui/gtk.h | 4 ui/gtk.c | 7 +++ 2 files changed, 11 insertions(+)

Re: [Qemu-devel] QEMU 1.1.2: block IO throttle might occasionally freeze running process's IO to zero

2016-12-01 Thread Fam Zheng
On Thu, 12/01 12:07, Bob Chen wrote: > Test case: > > 1. QEMU 1.1.2 > 2. Run fio inside the vm, give it some pressure. Watch the realtime > throughput > 3. block_set_io_throttle drive_2 1 0 0 2000 0 0 # throttle > bps and iops, any value > 4. Observed that the IO is very likely to

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2016-12-01 Thread Vijay Kilari
On Wed, Nov 30, 2016 at 10:29 PM, Peter Maydell wrote: > On 30 November 2016 at 16:23, Vijay Kilari wrote: >> On Mon, Nov 28, 2016 at 10:05 PM, Peter Maydell >> wrote: >>> Still I would prefer it if we did this with the same >>> mechanism for both TCG and KVM. A generic mechanism for >>> "let th

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-01 Thread Wouter Verhelst
Here's another update. Changes since previous version: - Rename "allocation context" to "metadata context" - Stop making metadata context 0 be special; instead, name it "BASE:allocation" and allow it to be selected like all other contexts. - Clarify in a bit more detail when a server MAY omit me

Re: [Qemu-devel] QEMU 1.1.2: block IO throttle might occasionally freeze running process's IO to zero

2016-12-01 Thread Paolo Bonzini
On 01/12/2016 05:07, Bob Chen wrote: > Test case: > > 1. QEMU 1.1.2 > 2. Run fio inside the vm, give it some pressure. Watch the realtime > throughput > 3. block_set_io_throttle drive_2 1 0 0 2000 0 0 # > throttle bps and iops, any value > 4. Observed that the IO is very likely t

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

2016-12-01 Thread Andre Przywara
Hi Drew, actually unrelated to this actual patch, but since you mentioned it: > As we work out how best to handle tcg-only tests in order to get Alex > Bennee's MTTCG tests merged, we'll probably revisit this file, So when I was experimenting with kvmtool, I realized that some tests would need t

Re: [Qemu-devel] QEMU 2.8 release approaching

2016-12-01 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Thursday, December 01, 2016 5:04 PM > To: Laszlo Ersek; Gonglei (Arei) > Cc: Peter Maydell; qemu-devel > Subject: Re: QEMU 2.8 release approaching > > On Wed, Nov 30, 2016 at 3:42 PM, Stefan Hajnoczi > wrote

Re: [Qemu-devel] GTK UI keycodes broken under Wayland

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 9:35 AM, Daniel P. Berrange wrote: > On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote: >> On 01.12.2016 08:24, Stefan Hajnoczi wrote: >> > I recently upgraded to Fedora 25 which runs Wayland by default. >> > >> > The GTK UI is now sending unknown keycodes to the g

[Qemu-devel] [RFC PATCH] glusterfs: allow partial reads

2016-12-01 Thread Wolfgang Bumiller
Fixes #1644754. Signed-off-by: Wolfgang Bumiller --- I'm not sure what the original rationale was to treat both partial reads as well as well as writes as I/O error. (Seems to have happened from original glusterfs v1 to v2 series with a note but no reasoning for the read side as far as I could se

Re: [Qemu-devel] QEMU 2.8 release approaching

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 10:30 AM, Gonglei (Arei) wrote: > >> -Original Message- >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] >> Sent: Thursday, December 01, 2016 5:04 PM >> To: Laszlo Ersek; Gonglei (Arei) >> Cc: Peter Maydell; qemu-devel >> Subject: Re: QEMU 2.8 release approaching

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Andre Przywara
Hi, On 01/12/16 08:59, Andrew Jones wrote: > > Should this be From: Andre? No need from my side, this way all the bug reports are send to Wei ;-) > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: >> This patch defines four macros to assist creating system register >> accessors under

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange wrote: > Wayland always uses evdev as its input source, so QEMU > can use the existing evdev keymap data > > Signed-off-by: Daniel P. Berrange > --- > > Changed in v2 > > - Actually add all changed files to commit - gtk.h :-) > > include/ui/gtk

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 11:20 AM, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange > wrote: >> Wayland always uses evdev as its input source, so QEMU >> can use the existing evdev keymap data >> >> Signed-off-by: Daniel P. Berrange >> --- >> >> Changed in v2 >> >> - A

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-12-01 Thread Vladimir Sementsov-Ogievskiy
01.12.2016 13:14, Wouter Verhelst wrote: Here's another update. Changes since previous version: - Rename "allocation context" to "metadata context" - Stop making metadata context 0 be special; instead, name it "BASE:allocation" and allow it to be selected like all other contexts. - Clarify in

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 1, 2016 at 11:25 AM, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 11:20 AM, Stefan Hajnoczi wrote: >> On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange >> wrote: >>> Wayland always uses evdev as its input source, so QEMU >>> can use the existing evdev keymap data >>> >>> Signed-

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Daniel P. Berrange
On Thu, Dec 01, 2016 at 11:26:59AM +, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 11:25 AM, Stefan Hajnoczi wrote: > > On Thu, Dec 1, 2016 at 11:20 AM, Stefan Hajnoczi wrote: > >> On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange > >> wrote: > >>> Wayland always uses evdev as its input

Re: [Qemu-devel] [PATCH v2] ui: use evdev keymap when running under wayland

2016-12-01 Thread Daniel P. Berrange
On Thu, Dec 01, 2016 at 11:20:36AM +, Stefan Hajnoczi wrote: > On Thu, Dec 1, 2016 at 9:41 AM, Daniel P. Berrange > wrote: > > Wayland always uses evdev as its input source, so QEMU > > can use the existing evdev keymap data > > > > Signed-off-by: Daniel P. Berrange > > --- > > > > Changed i

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 3/4] arm: pmu: Check cycle count increases

2016-12-01 Thread Andre Przywara
Hi, On 01/12/16 05:16, Wei Huang wrote: > From: Christopher Covington > > Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, > even for the smallest delta of two subsequent reads. > > Signed-off-by: Christopher Covington > Signed-off-by: Wei Huang > Reviewed-by: Andrew Jones

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 2/4] arm: Add PMU test

2016-12-01 Thread Andre Przywara
Hi, On 01/12/16 09:03, Andrew Jones wrote: > On Wed, Nov 30, 2016 at 11:16:40PM -0600, Wei Huang wrote: >> From: Christopher Covington >> >> Beginning with a simple sanity check of the control register, add >> a unit test for the ARM Performance Monitors Unit (PMU). PMU register >> was read using

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-01 Thread Stefan Hajnoczi
On Wed, Nov 30, 2016 at 07:41:11PM +0200, Avi Kivity wrote: > On 11/29/2016 12:45 PM, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 04:41:13PM +0100, Paolo Bonzini wrote: > > > On 28/11/2016 16:29, Stefan Hajnoczi wrote: > > > > Thanks for sharing the link. I'll let you know before embarking

Re: [Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > > b/drivers/crypto/virtio/virtio_crypto_algs.c > > > new file mode 100644 > > > index 000..08b077f > > > -

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-01 Thread Liviu Ionescu
> On 1 Dec 2016, at 10:50, Paolo Bonzini wrote: > >> But why only linux-user and not full system emulation too? > > It would simplify the library. The front-end and helpers have some > differences > between usermode and softmmu, and the latter is much more intertwined with > the rest of the Q

Re: [Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > +static int virtio_crypto_alg_ablkcipher_init_session( > > > + struct virtio_crypto_ablkcipher_ctx *ctx, > > > + uint32_t alg, const uint8_t *key, > > >

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-01 Thread Avi Kivity
On 12/01/2016 01:45 PM, Stefan Hajnoczi wrote: On Wed, Nov 30, 2016 at 07:41:11PM +0200, Avi Kivity wrote: On 11/29/2016 12:45 PM, Stefan Hajnoczi wrote: On Mon, Nov 28, 2016 at 04:41:13PM +0100, Paolo Bonzini wrote: On 28/11/2016 16:29, Stefan Hajnoczi wrote: Thanks for sharing the link. I'

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 2/4] arm: Add PMU test

2016-12-01 Thread Peter Maydell
On 1 December 2016 at 11:28, Andre Przywara wrote: > I don't think so. At least here as a _variable_ type uint32_t is > probably the right one, as the ARMv8 ARM explicitly says that PMCR is a > 32-bit register, for both bitnesses. For 64-bit ARM this is strictly speaking just shorthand for "64-bi

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 2/4] arm: Add PMU test

2016-12-01 Thread Andre Przywara
Hi, On 01/12/16 12:02, Peter Maydell wrote: > On 1 December 2016 at 11:28, Andre Przywara wrote: >> I don't think so. At least here as a _variable_ type uint32_t is >> probably the right one, as the ARMv8 ARM explicitly says that PMCR is a >> 32-bit register, for both bitnesses. > > For 64-bit A

Re: [Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei (Arei)
> > Subject: Re: [PATCH v4 1/1] crypto: add virtio-crypto driver > > On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > +static int virtio_crypto_alg_ablkcipher_init_session( > > > > + struct virtio_c

Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

2016-12-01 Thread Cédric Le Goater
On 12/01/2016 01:42 AM, Alastair D'Silva wrote: > On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote: >> On 11/30/2016 06:36 AM, Alastair D'Silva wrote: >>> From: Alastair D'Silva >>> >>> The imx25 chip provides 3 i2c buses, but they have all been named >>> "i2c", which makes it difficult t

Re: [Qemu-devel] [PATCH] monitor: fix object_del for command-line-created objects

2016-12-01 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Nov 30, 2016 at 05:06:16PM -0600, Michael Roth wrote: > > Currently objects specified on the command-line are only partially > > cleaned up when 'object_del' is issued in either HMP or QMP: the > > object itself is fully finalized, but the

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 2/4] arm: Add PMU test

2016-12-01 Thread Peter Maydell
On 1 December 2016 at 12:19, Andre Przywara wrote: > Hi, > > On 01/12/16 12:02, Peter Maydell wrote: >> On 1 December 2016 at 11:28, Andre Przywara wrote: >>> I don't think so. At least here as a _variable_ type uint32_t is >>> probably the right one, as the ARMv8 ARM explicitly says that PMCR is

Re: [Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei (Arei)
> > On Thu, Dec 01, 2016 at 02:27:19AM +, Gonglei (Arei) wrote: > > > On Tue, Nov 29, 2016 at 08:48:14PM +0800, Gonglei wrote: > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > > > b/drivers/crypto/virtio/virtio_crypto_algs.c > > > > new file mode 100644 > > > > index 000..

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-01 Thread Peter Maydell
On 1 December 2016 at 11:54, Liviu Ionescu wrote: > >> On 1 Dec 2016, at 10:50, Paolo Bonzini wrote: >> >>> But why only linux-user and not full system emulation too? >> >> It would simplify the library. The front-end and helpers have some >> differences >> between usermode and softmmu, and the

[Qemu-devel] [PATCH v5 0/1] virtio-crypto: add Linux driver

2016-12-01 Thread Gonglei
v5: - add comments for algs_lock and table_lock. [Stefan] - use kzfree instead of kfree for key material security. [Stefan] - drop unnecessary spin_lock for struct virtio_crypto_ablkcipher_ctx. - dynamically allocated memory for iv in order to avoid to do DMA from the stack memory in __virti

[Qemu-devel] [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-01 Thread Gonglei
This patch introduces virtio-crypto driver for Linux Kernel. The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The encryption anddecryption requests are placed in the data queue and are ultimately handled by thebackend

Re: [Qemu-devel] [RFCv2 00/12] Clean up compatibility mode handling

2016-12-01 Thread Greg Kurz
On Wed, 16 Nov 2016 09:17:43 +1100 David Gibson wrote: > This series is a significant rework to how we handle CPU compatibility > modes on ppc. > David, Please find below the results of the migration tests. > * Information about compatibility modes was previously open coded and >scattere

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Andrew Jones
On Thu, Dec 01, 2016 at 11:11:55AM +, Andre Przywara wrote: > Hi, > > On 01/12/16 08:59, Andrew Jones wrote: > > > > Should this be From: Andre? > > No need from my side, this way all the bug reports are send to Wei ;-) > > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: > >> T

Re: [Qemu-devel] [PATCH v5 00/19] Cleanup of TCG tests

2016-12-01 Thread Pranith Kumar
Peter Maydell writes: > On 1 December 2016 at 05:14, Pranith Kumar wrote: >> Hello, >> >> This patch series cleans up the tcg tests in tests/tcg folder. > >> linux-user/mmap.c | 27 +++--- >> linux-user/syscall.c| 2 +- > > These aren't test code -- i

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-01 Thread Liviu Ionescu
> On 1 Dec 2016, at 14:38, Peter Maydell wrote: > > ... clean up QEMU's code so > that it is less interdependent ... that's a good idea anyway, but this does not address the current issue. if I'd have a separate library with ARM TCG, for Cortex-M emulation I'd probably write a simple memory m

Re: [Qemu-devel] [PULL 0/5] virtio, vhost, pc: fixes

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 05:58:40AM +0200, Michael S. Tsirkin wrote: > Comments on patches included: > > - a spec update seems important for 2.8 as incorrect > spec makes people implement backends incorrectly. > - undefined behaviour fix seems important too - > who knows what would compiler optimiz

Re: [Qemu-devel] [PULL 0/1] ppc-for-2.8 queue 20161201

2016-12-01 Thread Stefan Hajnoczi
://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161201 > > for you to fetch changes up to 5c0139a8c2f01e068c96d456ecf12b0eeb707660: > > spapr: fix default DRC state for coldplugged LMBs (2016-12-01 13:41:00 > +1100) > > ---

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

2016-12-01 Thread Andrew Jones
On Thu, Dec 01, 2016 at 10:19:13AM +, Andre Przywara wrote: > Hi Drew, > > actually unrelated to this actual patch, but since you mentioned it: > > > As we work out how best to handle tcg-only tests in order to get Alex > > Bennee's MTTCG tests merged, we'll probably revisit this file, > > S

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

2016-12-01 Thread Stefan Hajnoczi
On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: > It's timer to expire, not clock. > > Signed-off-by: Yaowei Bai > --- > include/qemu/timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For the whole series: Reviewed-by: Stefan Hajnoczi PS: I suggest sending a cover l

[Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-01 Thread Jin Guojie
Changes in v5: * Update against master(v2.8.0-rc2) * Fix a bug: 64-bit big-endian guests hang on mips64 little-endian hosts, and vice versa. This bug was first introduced in v2 patch, due to obvious misuse of ret/arg registers in tcg_out_bswap64(). tcg_out_opc_reg(s, OPC_DS

[Qemu-devel] [PATCH v5 06/10] tcg-mips: Adjust load/store functions for mips64

2016-12-01 Thread Jin Guojie
tcg_out_ldst: using a generic ALIAS_PADD to avoid ifdefs tcg_out_ld: generates LD or LW tcg_out_st: generates SD or SW Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 14 +++--- 1 file changed, 11 insertions

[Qemu-devel] [PATCH v5 03/10] tcg-mips: Support 64-bit opcodes

2016-12-01 Thread Jin Guojie
Bulk patch adding 64-bit opcodes into tcg_out_op. Note that mips64 is as yet neither complete nor enabled. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.h | 41 ++ tcg/mips/tcg-target.inc.c | 322 +++

[Qemu-devel] [PATCH v5 04/10] tcg-mips: Add bswap32u and bswap64

2016-12-01 Thread Jin Guojie
Without the mips32r2 instructions to perform swapping, bswap is quite large, dominating the size of each reverse-endian qemu_ld/qemu_st operation. Create two subroutines in the prologue block. The subroutines require extra reserved registers (TCG_TMP[2, 3]). Using these within qemu_ld means that

[Qemu-devel] [PATCH v5 07/10] tcg-mips: Adjust prologue for mips64

2016-12-01 Thread Jin Guojie
Take stack frame parameters out from the function body. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 54 ++- 1 file changed, 25 insertions(+), 29 deletions(-) diff --g

[Qemu-devel] [PATCH v5 02/10] tcg-mips: Add mips64 opcodes

2016-12-01 Thread Jin Guojie
Since the mips manual tables are in octal, reorg all of the opcodes into that format for clarity. Note that the 64-bit opcodes are as yet unused. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 193

[Qemu-devel] [PATCH v5 08/10] tcg-mips: Add tcg unwind info

2016-12-01 Thread Jin Guojie
Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 44 1 file changed, 44 insertions(+) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index 9e24662..b7e

[Qemu-devel] [PATCH v5 09/10] tcg-mips: Adjust calling conventions for mips64

2016-12-01 Thread Jin Guojie
Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.h | 19 +++ tcg/mips/tcg-target.inc.c | 21 +++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/tcg/mips/tcg-target.h b/t

[Qemu-devel] [PATCH v5 01/10] tcg-mips: Move bswap code to a subroutine

2016-12-01 Thread Jin Guojie
Without the mips32r2 instructions to perform swapping, bswap is quite large, dominating the size of each reverse-endian qemu_ld/qemu_st operation. Create a subroutine in the prologue block. The subroutine requires extra reserved registers (TCG_TMP[2, 3]). Using these within qemu_ld means that we

[Qemu-devel] [PATCH v5 05/10] tcg-mips: Adjust move functions for mips64

2016-12-01 Thread Jin Guojie
tcg_out_mov: using OPC_OR as most mips assemblers do; tcg_out_movi: extended to 64-bit immediate. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 34 +- 1 file changed, 25 insertions(

[Qemu-devel] [PATCH v5 10/10] tcg-mips: Adjust qemu_ld/st for mips64

2016-12-01 Thread Jin Guojie
Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 203 +- 1 file changed, 146 insertions(+), 57 deletions(-) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc

Re: [Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/event

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 10:03:43AM +0100, Paolo Bonzini wrote: > This avoids taking the active_timers_lock or resetting/setting the > timers_done_ev if there are no active timers. This removes a small > (2-3%) source of overhead for dataplane. The list is then checked > again inside the lock, or

Re: [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

2016-12-01 Thread Kevin Wolf
Forwarding to qemu-block so I won't forget to have a look. Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: > commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case > which migration aborted QEMU because it didn't regain the control > of images while some errors happened. > > Actually,

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-12-01 Thread Paolo Bonzini
> > > Maybe we could do the same for sockets? When data is available on a > > > socket (or when it becomes writable), write to a user memory location. > > > > > > I, too, have an interest in polling; in my situation most of the polling > > > happens in userspace. > > > > You are trying to improve

Re: [Qemu-devel] Support for using TCG frontend as a library

2016-12-01 Thread Peter Maydell
On 1 December 2016 at 13:33, Liviu Ionescu wrote: >> On 1 Dec 2016, at 14:38, Peter Maydell wrote: >> >> ... clean up QEMU's code so >> that it is less interdependent ... > > that's a good idea anyway, but this does not address the current issue. > > if I'd have a separate library with ARM TCG, f

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

2016-12-01 Thread YunQiang Su
On Thu, Dec 1, 2016 at 4:30 AM, Richard Henderson wrote: > On 11/30/2016 10:39 AM, Jin Guojie wrote: >> Yesterday I successfully got in touch with a Debian developer from imgtec. >> Welcome Su Yunqiang. >> V4 patch can be tested on mips64 be hosts now. >> The following guests on a mips64 >> big-

Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

2016-12-01 Thread Eric Blake
On 12/01/2016 12:06 AM, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > +++ b/qapi-schema.json > @@ -4676,6 +4676,24 @@ > { 'command': 'xen-load-d

Re: [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

2016-12-01 Thread Eric Blake
On 12/01/2016 12:06 AM, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24 > +++ b/qapi-schema.json > @@ -

Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence

2016-12-01 Thread Eric Blake
On 12/01/2016 12:55 AM, Zhang Chen wrote: > Say it in another way to make it easier to understand. > > Signed-off-by: Zhang Chen > Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't write the patch. At any rate, since this is doc-only

Re: [Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled

2016-12-01 Thread Eric Blake
On 12/01/2016 12:06 AM, Zhang Chen wrote: > Xen need't this. Huh? Did you mean: Xen doesn't need this. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > migration/savevm.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/migration/savevm.c b/migration/savevm.c

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-12-01 Thread James Page
This bug was fixed in the package qemu - 1:2.6.1+dfsg-0ubuntu7~cloud0 --- qemu (1:2.6.1+dfsg-0ubuntu7~cloud0) xenial-ocata; urgency=medium . * New update for the Ubuntu Cloud Archive. . qemu (1:2.6.1+dfsg-0ubuntu7) zesty; urgency=medium . [ Rafael David Tinoco ] * Fixed w

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

2016-12-01 Thread Paolo Bonzini
On 01/12/2016 14:50, Stefan Hajnoczi wrote: > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: >> It's timer to expire, not clock. >> >> Signed-off-by: Yaowei Bai >> --- >> include/qemu/timer.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > For the whole series: > > R

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Wei Huang
On 12/01/2016 02:59 AM, Andrew Jones wrote: > > Should this be From: Andre? > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: >> This patch defines four macros to assist creating system register >> accessors under both ARMv7 and AArch64: >>* DEFINE_GET_SYSREG32(name, ...) >>

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

2016-12-01 Thread James Hogan
On Wed, Nov 30, 2016 at 12:30:19PM -0800, Richard Henderson wrote: > On 11/30/2016 10:39 AM, Jin Guojie wrote: > > But even Su cannot provide an R6 machine. > > Ok, I guess we will just have to drop the R6 patches for now, until imgtec is > able to provide feedback on them. It booted a mips64r6 g

Re: [Qemu-devel] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

2016-12-01 Thread Paolo Bonzini
On 30/11/2016 14:36, Paolo Bonzini wrote: > > > On 30/11/2016 14:31, Stefan Hajnoczi wrote: >> On Tue, Nov 29, 2016 at 12:47:03PM +0100, Paolo Bonzini wrote: >>> @@ -272,22 +275,32 @@ bool aio_prepare(AioContext *ctx) >>> bool aio_pending(AioContext *ctx) >>> { >>> AioHandler *node; >>>

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

2016-12-01 Thread Alex Williamson
On Wed, 30 Nov 2016 17:23:59 +0800 Peter Xu wrote: > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > * intel_iommu's replay op is not implemented yet (May come in different > > patch > > set). > > The replay function is required for hotplug vfio device and to move > > devices

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

2016-12-01 Thread Andrew Jones
On Thu, Dec 01, 2016 at 09:27:59AM -0600, Wei Huang wrote: > > > On 12/01/2016 02:59 AM, Andrew Jones wrote: > > > > Should this be From: Andre? > > > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: > >> This patch defines four macros to assist creating system register > >> accesso

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

2016-12-01 Thread Richard Henderson
On 12/01/2016 05:51 AM, Jin Guojie wrote: > Changes in v5: > * Update against master(v2.8.0-rc2) > * Fix a bug: 64-bit big-endian guests hang on mips64 little-endian > hosts, and vice versa. This bug was first introduced in v2 patch, > due to obvious misuse of ret/arg registers in t

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

2016-12-01 Thread Richard Henderson
On 12/01/2016 07:32 AM, James Hogan wrote: > On Wed, Nov 30, 2016 at 12:30:19PM -0800, Richard Henderson wrote: >> On 11/30/2016 10:39 AM, Jin Guojie wrote: >>> But even Su cannot provide an R6 machine. >> >> Ok, I guess we will just have to drop the R6 patches for now, until imgtec is >> able to p

Re: [Qemu-devel] [PATCH for-2.8] monitor: fix object_del for command-line-created objects

2016-12-01 Thread Michael Roth
Quoting Eric Blake (2016-11-30 20:33:56) > On 11/30/2016 05:06 PM, Michael Roth wrote: > > Currently objects specified on the command-line are only partially > > cleaned up when 'object_del' is issued in either HMP or QMP: the > > object itself is fully finalized, but the QemuOpts are not removed.

Re: [Qemu-devel] [PATCH] monitor: fix object_del for command-line-created objects

2016-12-01 Thread Michael Roth
Quoting Dr. David Alan Gilbert (2016-12-01 06:34:10) > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Nov 30, 2016 at 05:06:16PM -0600, Michael Roth wrote: > > > Currently objects specified on the command-line are only partially > > > cleaned up when 'object_del' is issued in either

[Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI

2016-12-01 Thread Laszlo Ersek
* This is version 4 of the series; the last version was at . This version is practically a rewrite from scratch, seeking to address the v3 feedback. Here's what the individual patches do: - Patch #1 rebases and extends

[Qemu-devel] [PATCH v4 4/7] hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots

2016-12-01 Thread Laszlo Ersek
Add "file_slots" compat properties for 2.8 and earlier machine types. Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek --- include/hw/compat.h| 11 +++ include/hw/i386/pc.h | 3 +++

[Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

2016-12-01 Thread Laszlo Ersek
Accordingly, generalize the "file_slots" minimum calculation in fw_cfg_init_io_dma(), and move the constant FW_CFG_FILE_SLOTS_TRAD argument to the callers of fw_cfg_init_io_dma(). Cc: "Gabriel L. Somlo" Cc: "Michael S. Tsirkin" Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-

[Qemu-devel] [PATCH v4 5/7] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2016-12-01 Thread Laszlo Ersek
Introduce the following fw_cfg files: - "etc/smi/host-features": a little endian uint64_t feature bitmap, presenting the features known by the host to the guest. Read-only for the guest. The content of this file is calculated by QEMU at startup (the calculation will be added later). The s

[Qemu-devel] [PATCH v4 6/7] hw/isa/lpc_ich9: add broadcast SMI feature

2016-12-01 Thread Laszlo Ersek
The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before ExitBootS

[Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

2016-12-01 Thread Laszlo Ersek
We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could lead to problems with backward migration: a more recent QEMU (running an older machine type) would allow the guest, in fw_cfg_select(), to select a high key value that is unavailable in the same machine type implemented by th

[Qemu-devel] [PATCH v4 1/7] fw-cfg: support writeable blobs

2016-12-01 Thread Laszlo Ersek
From: "Michael S. Tsirkin" Useful to send guest data back to QEMU. Changes from Laszlo Ersek : - rebase the patch from Michael Tsirkin's original postings at [1] and [2] to the following patches: - loader: Allow a custom AddressSpace when loading ROMs - loader: Add AddressSpace loading sup

[Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

2016-12-01 Thread Laszlo Ersek
For the time being, we cannot handle SMIs in OVMF if VCPUs can show up after boot. Otherwise, advertise ICH9_LPC_SMI_F_BROADCAST. Implement this generally, by introducing a new PCMachineClass method, namely get_smi_host_features(), and implement the above logic for pc-q35-2.9 and later. The idea i

Re: [Qemu-devel] [PATCH v4 14/64] target-arm: Use new deposit and extract ops

2016-12-01 Thread Alex Bennée
Richard Henderson writes: > Use the new primitives for UBFX and SBFX. > > Signed-off-by: Richard Henderson > --- > target-arm/translate-a64.c | 79 > +++--- > target-arm/translate.c | 37 +- > 2 files changed, 34 insertions(+), 8

  1   2   >