Defined device API strings. Vendor driver using mediated device
framework should use corresponding string for device_api attribute.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: I42d29f475f02a7132ce13297fbf2b48f1da10995
---
include/uapi/linux/vfio.h | 10 ++
1 file cha
This patch (hack?) works around the slowness in SEEK_HOLE for large dense files
on Linux tmpfs. It may improve life elsewhere as well, and the penalty of the
checks
should be vanishingly small where it is not needed.
If I'm subtly (or not so subtly) wrong, please fire back.
Sincerely,
--
Chri
Add find_iommu_group()
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Reviewed-by: Jike Song
Reviewed-by: Dong Jia Shi
Change-Id: I9d372f1ebe9eb01a5a21374b8a2b03f7df73601f
---
drivers/vfio/vfio_iommu_type1.c | 57 -
1 file changed, 33 insertions(
Hi Paolo,
I was able to test your patches in our s390 environment. I don't see the
qemu crashes anymore which I noticed before.
Testing a guest running high stress I/O workload, without iothreads does
show a delay in guest response time. But running
the same test with iothreads seems to sol
This change rearrange functions to have common function to increment
container_users
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Reviewed-by: Jike Song
Change-Id: I8bdeb352bc8439b107ffd519480fd4dc238677f2
---
drivers/vfio/vfio.c | 34 +-
1 file changed
Add a notifier calback to parent's ops structure of mdev device so that per
device notifer for vfio module is registered through vfio_mdev module.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
---
drivers/vfio/mdev/vfio_mdev.c | 34 +++
Vendor driver using mediated device framework would use same mechnism to
validate and prepare IRQs. Introducing this function to reduce code
replication in multiple drivers.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: Ie201f269dda0713ca18a07dc4852500bd8b48309
---
drivers/vfi
On 11/16/2016 01:48 PM, Christopher Oliver wrote:
>
>
Attaching the patch (rather than including it inline) requires reviewers
to save the attachment off to a file in order to even see what you
wrote. To save others some time, I'm pasting the text and replying inline:
> The following patch is
Add file Documentation/vfio-mediated-device.txt that include details of
mediated device framework.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d
---
Documentation/vfio-mediated-device.txt | 298 +
driver
Adding myself as a maintainer of mediated device framework,
a sub module of VFIO.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: I58f6717783e0d4008ca31f4a5c4494696bae8571
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
inde
--
Christopher Oliver
qemu-patch
Description: Binary data
On 11/16/2016 03:16 PM, Michael S. Tsirkin wrote:
On Wed, Nov 16, 2016 at 03:03:13PM -0500, Farhan Ali wrote:
Hi Paolo,
I was able to test your patches in our s390 environment. I don't see the
qemu crashes anymore which I noticed before.
Testing a guest running high stress I/O workload, with
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [patch v3 00/18] tcg field extract primitives
Message-id: 1479326625-10682-1-git-send-email-...@twiddle.net
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
tot
On Wed, Nov 16, 2016 at 04:05:31PM -0500, Paolo Bonzini wrote:
>
>
> - Original Message -
> > From: "Michael S. Tsirkin"
> > To: "Paolo Bonzini"
> > Cc: qemu-devel@nongnu.org, "alex williamson" ,
> > borntrae...@de.ibm.com, fel...@nutanix.com
> > Sent: Wednesday, November 16, 2016 9:39
On 11/16/2016 03:32 PM, Farhan Ali wrote:
On 11/16/2016 03:16 PM, Michael S. Tsirkin wrote:
On Wed, Nov 16, 2016 at 03:03:13PM -0500, Farhan Ali wrote:
Hi Paolo,
I was able to test your patches in our s390 environment. I don't see
the
qemu crashes anymore which I noticed before.
Testing
Disabling notifications during virtqueue processing reduces the number of
exits. The virtio-net device already uses virtio_queue_set_notifications() but
virtio-blk and virtio-scsi do not.
The following benchmark shows a 15% reduction in virtio-blk-pci MMIO exits:
(host)$ qemu-system-x86_64 \
The guest does not need to kick the virtqueue while we are processing
it. This reduces the number of vmexits during periods of heavy I/O.
Signed-off-by: Stefan Hajnoczi
---
hw/block/virtio-blk.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/hw/block/vir
virtio_queue_notify_vq() checks vdev->broken before invoking the
handler, virtio_queue_notify_aio_vq() should too.
Signed-off-by: Stefan Hajnoczi
---
hw/virtio/virtio.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 55a00cd..a4759bd 100644
-
The guest does not need to kick the virtqueue while we are processing
it. This reduces the number of vmexits during periods of heavy I/O.
Signed-off-by: Stefan Hajnoczi
---
hw/scsi/virtio-scsi.c | 36 +---
1 file changed, 21 insertions(+), 15 deletions(-)
diff -
On Fri, Nov 11, 2016 at 8:06 PM, Edgar E. Iglesias
wrote:
> On Fri, Nov 11, 2016 at 06:51:20PM -0800, Alistair Francis wrote:
>> This patch fixes the generic-loader file loading to only set the program
>> counter if a CPU is specified. This follows what is written in the
>> documentation and was a
On Mon, Nov 7, 2016 at 4:34 PM, Alistair Francis
wrote:
> The Cadence UART device emulator calculates speed by dividing the
> baud rate by a 'baud rate generator' & 'baud rate divider' value.
> The device specification defines these register values to be
> non-zero and within certain limits. Check
On Wed, Nov 16, 2016 at 09:53:06PM +, Stefan Hajnoczi wrote:
> Disabling notifications during virtqueue processing reduces the number of
> exits. The virtio-net device already uses virtio_queue_set_notifications()
> but
> virtio-blk and virtio-scsi do not.
>
> The following benchmark shows a
On Thu, 17 Nov 2016 02:16:22 +0530
Kirti Wankhede wrote:
> @@ -931,6 +1344,24 @@ static void vfio_iommu_type1_detach_group(void
> *iommu_data,
>
> mutex_lock(&iommu->lock);
>
> + if (iommu->external_domain) {
> + group = find_iommu_group(iommu->external_domain, iommu_gro
On Thu, 17 Nov 2016 02:16:23 +0530
Kirti Wankhede wrote:
> @@ -1321,12 +1350,11 @@ static void vfio_iommu_unmap_unpin_reaccount(struct
> vfio_iommu *iommu)
>
> static void vfio_sanity_check_pfn_list(struct vfio_iommu *iommu)
> {
> - struct rb_node *n, *p;
> + struct rb_node *n;
>
>
Hi all,
I addressed some review comments. Comments are welcome.
v13: - Changed some QTAILQ related macro names to match existing ones.
Previous versions are:
v12: - Fixed type for put_qtailq which caused build break.
(link: http://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01328
Current migration code cannot handle some data structures such as
QTAILQ in qemu/queue.h. Here we extend the signatures of put/get
in VMStateInfo so that customized handling is supported. put now
will return int type.
Signed-off-by: Jianjun Duan
---
hw/display/virtio-gpu.c | 8 +++-
hw/int
Currently we cannot directly transfer a QTAILQ instance because of the
limitation in the migration code. Here we introduce an approach to
transfer such structures. We created VMStateInfo vmstate_info_qtailq
for QTAILQ. Similar VMStateInfo can be created for other data structures
such as list.
When
Add a test for QTAILQ migration to tests/test-vmstate.c.
Signed-off-by: Jianjun Duan
---
tests/test-vmstate.c | 160 +++
1 file changed, 160 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index d2f529b..88aab8c 100644
--- a
Added error_report where version_ids do not match in vmstate_load_state.
Signed-off-by: Jianjun Duan
---
migration/vmstate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 2f9d4ba..0e6fce4 100644
--- a/migration/vmstate.c
+++ b/migration/vms
While customary, the /chosen and /memory devicetree nodes do not have to
exist. Create if necessary. Also create the /memory/device_type property
if needed.
Signed-off-by: Guenter Roeck
---
The problem is seen with the latest version of the Linux kernel in
linux-next (next-20161116), where many
* Kirti Wankhede [2016-11-16 20:47:18 +0530]:
>
>
> On 11/16/2016 12:07 PM, Dong Jia Shi wrote:
> > * Kirti Wankhede [2016-11-15 20:59:55 +0530]:
> >
> > Hi Kirti,
> >
> > [...]
> >
> >> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> >> index ffc36758cb84..4fc6
> -Original Message-
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> Sent: Thursday, November 17, 2016 4:18 AM
> To: qemu-devel@nongnu.org
> Cc: Gonglei (Arei); Michael S. Tsirkin; Stefan Hajnoczi
> Subject: [PATCH] virtio-crypto: fix virtio_queue_set_notification() race
>
> We
On 16/11/16 01:02, Andrea Bolognani wrote:
> On Tue, 2016-11-01 at 13:46 +1100, David Gibson wrote:
>> On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote:
>>>
>>> On 31/10/16 13:53, David Gibson wrote:
On Fri, Oct 28, 2016 at 12:07:12PM +0200, Greg Kurz wrote:
>
* Kirti Wankhede [2016-11-17 02:16:24 +0530]:
Hi Kirti,
> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
[...]
> @@ -51,6 +78,11 @@ static void vfio_mdev_release(void *device_data)
> if (likely(parent->ops->release))
> parent->ops->release(mdev);
When I run this test disk image:
http://wiki.qemu.org/download/ppc-virtexml507-linux-2_6_34.tgz
I see these error messages:
/selftest.sh: line 6: /usr/bin/sha1test: not found
/selftest.sh: line 7: /usr/bin/hmactest: not found
Maybe /usr/bin/sha1sum is what the first test should be. I don't see
On 11/17/2016 04:46 AM, Kirti Wankhede wrote:
> Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers
> about DMA_UNMAP.
> Exported two APIs vfio_register_notifier() and vfio_unregister_notifier().
> Notifier should be registered, if external user wants to use
> vfio_pin_pages()/vf
Unrealize should undo things that were set during realize in
reverse order. So should do in the error path in realize.
Signed-off-by: Li Qiang
---
Changes since the v2:
-adjust the order in the error path in realize
hw/9pfs/9p.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
In the init operation of proxy backend dirver, it allocates a
V9fsProxy struct and some other resources. We should free these
resources when the 9pfs device is unrealized. This is what this
patch does.
Signed-off-by: Li Qiang
---
Changes since the v2:
-only close proxy->sockfd if QEMU opened the
Currently, the backend of VirtFS doesn't have a cleanup
function. This will leak some resources in handle and proxy
backend driver. This patchset addresses this issue.
Li Qiang (4):
9pfs: adjust the order of resource cleanup in device unrealize
9pfs: add cleanup operation in FileOperations
9
Currently, the backend of VirtFS doesn't have a cleanup
function. This will lead resource leak issues if the backed
driver allocates resources. This patch addresses this issue.
Signed-off-by: Li Qiang
---
Changes since the v1:
-move the cleanup stuff above calls to g_free
-add cleanup call in th
In the init operation of handle backend dirver, it allocates a
handle_data struct and opens a mount file. We should free these
resources when the 9pfs device is unrealized. This is what this
patch does.
Signed-off-by: Li Qiang
---
hw/9pfs/9p-handle.c | 9 +
1 file changed, 9 insertions(+
On Wed, Nov 16, 2016 at 08:25:17PM +0100, Richard Henderson wrote:
> Cc: qemu-...@nongnu.org
> Cc: David Gibson
> Signed-off-by: Richard Henderson
Reviewed-by: David Gibson
> ---
> target-ppc/helper.h | 4
> target-ppc/int_helper.c | 20
> target-ppc/translate.c
On Wed, Nov 16, 2016 at 06:07:27PM -0200, Jose Ricardo Ziviani wrote:
> bcdcfsq.: Decimal convert from signed quadword. It is possible to
I think there should be a "not" in there.
> convert values less than 10^31-1 or greater than -10^31-1 to be
> represented in packed decimal format.
>
> Signed
On Mon, Nov 14, 2016 at 07:59:28PM -0500, Peter Xu wrote:
> When one IOMMU memory region is splitted into multiple memory sections,
> vfio will register multiple same notifiers to a vIOMMU for the same
> region. That's not sensible. What we need is to register one IOMMU
> notifier for each IOMMU re
On Wed, Nov 16, 2016 at 02:17:47PM +0100, Thomas Huth wrote:
> On 16.11.2016 13:37, Greg Kurz wrote:
> > On Wed, 16 Nov 2016 12:24:50 +
> > "Dr. David Alan Gilbert" wrote:
> >
> >> * Greg Kurz (gr...@kaod.org) wrote:
> >>> On Wed, 16 Nov 2016 09:39:31 +0100
> >>> Thomas Huth wrote:
> >>>
On Wed, Nov 16, 2016 at 06:07:29PM -0200, Jose Ricardo Ziviani wrote:
> bcdcpsgn.: Decimal copy sign. Given two registers vra and vrb, it
> copies the vra value with vrb sign to the result register vrt.
>
> Signed-off-by: Jose Ricardo Ziviani
> ---
> target-ppc/helper.h | 1 +
>
On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote:
> Thomas Huth wrote:
> > qemu_savevm_state_iterate() expects the iterators to return 1
> > when they are done, and 0 if there is still something left to do.
> > However, ram_save_iterate() does not obey this rule and returns
> > the nu
On Wed, Nov 16, 2016 at 09:39:31AM +0100, Thomas Huth wrote:
> The ppc64 postcopy test does not work with KVM-PR, and it is also
> causing annoying warning messages when run on a x86 host. So let's
> use KVM here only if we know that we're running with KVM-HV (which
> automatically also means that
On Wed, Nov 16, 2016 at 06:07:30PM -0200, Jose Ricardo Ziviani wrote:
> bcdsetsgn.: Decimal set sign. This instruction copies the register
> value to the result register but adjust the signal according to
> the preferred sign value.
>
> Signed-off-by: Jose Ricardo Ziviani
> ---
> target-ppc/help
On Wed, Nov 16, 2016 at 06:07:28PM -0200, Jose Ricardo Ziviani wrote:
> bcdctsq.: Decimal convert to signed quadword. It is possible to
> convert packed decimal values to signed quadwords.
>
> Signed-off-by: Jose Ricardo Ziviani
> ---
> target-ppc/helper.h | 1 +
> target-ppc/in
The spapr-vlan device in QEMU has always presented it's MAC address in
the device tree as an 8 byte value, even though PAPR requires it to be
6 bytes. This is because, at the time, AIX required the value to be 8
bytes. However, modern versions of AIX only support the (correct) 6
byte value so the
On 11/17/2016 5:27 AM, Alex Williamson wrote:
> On Thu, 17 Nov 2016 02:16:22 +0530
> Kirti Wankhede wrote:
>> @@ -931,6 +1344,24 @@ static void vfio_iommu_type1_detach_group(void
>> *iommu_data,
>>
>> mutex_lock(&iommu->lock);
>>
>> +if (iommu->external_domain) {
>> +gr
VFIO IOMMU drivers are designed for the devices which are IOMMU capable.
Mediated device only uses IOMMU APIs, the underlying hardware can be
managed by an IOMMU domain.
Aim of this change is:
- To use most of the code of TYPE1 IOMMU driver for mediated devices
- To support direct assigned device
Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers
about DMA_UNMAP.
Exported two APIs vfio_register_notifier() and vfio_unregister_notifier().
Notifier should be registered, if external user wants to use
vfio_pin_pages()/vfio_unpin_pages() APIs to pin/unpin pages.
Vendor driver
Add a notifier calback to parent's ops structure of mdev device so that per
device notifer for vfio module is registered through vfio_mdev module.
Signed-off-by: Kirti Wankhede
Signed-off-by: Neo Jia
Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637
---
drivers/vfio/mdev/vfio_mdev.c | 32 +++
On 11/17/2016 7:45 AM, Dong Jia Shi wrote:
> * Kirti Wankhede [2016-11-17 02:16:24 +0530]:
>
> Hi Kirti,
>
>> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> [...]
>
>> @@ -51,6 +78,11 @@ static void vfio_mdev_release(void *device_data)
>> if (likely(parent->
On 16/11/16 19:38, Felipe Franciosi wrote:
>
>> On 16 Nov 2016, at 04:05, Alexey Kardashevskiy wrote:
>>
>> On 11/11/16 01:45, Christian Borntraeger wrote:
>>> On 11/09/2016 01:44 PM, Felipe Franciosi wrote:
Following the recent refactor of virtio notfiers [1], more specifically
the pat
On 17/11/16 05:05, Paolo Bonzini wrote:
> Following the recent refactoring of virtio notifiers [1], more specifically
> the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to
> start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2]
> by default, core virtio code requires 'ioev
On 17/11/16 07:46, Kirti Wankhede wrote:
> Add task structure to vfio_dma structure. Task structure is used for:
> - During DMA_UNMAP, same task who mapped it or other task who shares same
> address space is allowed to unmap, otherwise unmap fails.
> QEMU maps few iova ranges initially, then fork t
On Thu, 17 Nov 2016 16:41:14 +1100
Alexey Kardashevskiy wrote:
> On 17/11/16 07:46, Kirti Wankhede wrote:
> > Add task structure to vfio_dma structure. Task structure is used for:
> > - During DMA_UNMAP, same task who mapped it or other task who shares same
> > address space is allowed to unmap,
On Wed, 11/16 17:46, Stefan Hajnoczi wrote:
> The new AioPollFn io_poll() argument to aio_set_fd_handler() and
> aio_set_event_handler() is used in the next patch.
>
> Keep this code change separate due to the number of files it touches.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> aio-posix.c
On 11/17/2016 11:11 AM, Alexey Kardashevskiy wrote:
> On 17/11/16 07:46, Kirti Wankhede wrote:
>> Add task structure to vfio_dma structure. Task structure is used for:
>> - During DMA_UNMAP, same task who mapped it or other task who shares same
>> address space is allowed to unmap, otherwise unma
On 17/11/16 03:02, Igor Mammedov wrote:
> This series removes global MAX_CPUMASK_BITS constant
> so that it won't inderectly influence maximum CPUs count
> supported by different targets.
>
> It replaces statically allocated bitmasks with dynamically
> allocated ones using '-smp maxcpus' value for
On 17/11/16 17:12, Alex Williamson wrote:
> On Thu, 17 Nov 2016 16:41:14 +1100
> Alexey Kardashevskiy wrote:
>
>> On 17/11/16 07:46, Kirti Wankhede wrote:
>>> Add task structure to vfio_dma structure. Task structure is used for:
>>> - During DMA_UNMAP, same task who mapped it or other task who sh
Hi Laurent,
On 2016/11/15 16:44, Laurent Vivier wrote:
Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
ping ?
Anyone pick this up?
The original patch that added these lines went through Amit Shah and
David Gilbert. I have CCe
On 17/11/2016 04:18, David Gibson wrote:
> On Wed, Nov 16, 2016 at 09:39:31AM +0100, Thomas Huth wrote:
>> The ppc64 postcopy test does not work with KVM-PR, and it is also
>> causing annoying warning messages when run on a x86 host. So let's
>> use KVM here only if we know that we're running wit
Hello,
On 11/17/2016 05:36 AM, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> The imx25 chip provides 3 i2c buses, but they have all been named
> "i2c", which makes it difficult to predict which bus a device will
> be connected to when specified on the command line.
>
> This patch address
Le 17/11/2016 à 08:08, Hailiang Zhang a écrit :
> Hi Laurent,
>
> On 2016/11/15 16:44, Laurent Vivier wrote:
>> Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit :
>>> On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote:
ping ?
Anyone pick this up?
>>>
>>> The original patch
201 - 268 of 268 matches
Mail list logo
