On Sat, 29 Oct 2016 00:35:37 +0800
Xiao Guangrong wrote:
> For each NVDIMM present or intended to be supported by platform,
> platform firmware also exposes an ACPI Namespace Device under
> the root device
>
> So it builds nvdimm devices for all slots to support vNVDIMM hotplug
>
> Reviewed-by:
On Sat, Oct 29, 2016 at 12:35:38AM +0800, Xiao Guangrong wrote:
> The buffer is used to save the FIT info for all the presented nvdimm
> devices which is updated after the nvdimm device is plugged or
> unplugged. In the later patch, it will be used to construct NVDIMM
> ACPI _FIT method which refle
On 30 October 2016 at 21:23, Michael S. Tsirkin wrote:
> The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into
> staging (2016-10-28 17:59:04 +0100)
>
> are available in the git repository at:
Hi,
> I rebased KVMGT upon v10, with 2 minor changes:
>
> 1, get_user_pages_remote has only 7 args
Appears to be a 4.9 merge window change. v10 as-is applies and builds
fine against 4.8, after rebasing to 4.9-rc3 it stops building due to
this.
Can you share the patch?
> 2, vfio
On Tue, 1 Nov 2016 15:17:01 +
Stefan Hajnoczi wrote:
> On Sat, Oct 29, 2016 at 12:35:38AM +0800, Xiao Guangrong wrote:
> > The buffer is used to save the FIT info for all the presented nvdimm
> > devices which is updated after the nvdimm device is plugged or
> > unplugged. In the later patch,
bcdctz. converts from BCD to Zoned numeric format. Zoned format uses
a byte to represent a digit where the most significant nibble is 0x3
or 0xf, depending on the preferred signal.
Signed-off-by: Jose Ricardo Ziviani
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c
bcdcfn. converts from National numeric format to BCD. National format
uses a byte to represent a digit where the most significant nibble is
always 0x3 and the least sign. nibbles is the digit itself.
Signed-off-by: Jose Ricardo Ziviani
---
target-ppc/helper.h | 1 +
target-ppc/i
bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses
a byte to represent a digit where the most significant nibble is 0x3
or 0xf, depending on the preferred signal.
Signed-off-by: Jose Ricardo Ziviani
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c
bcdctn. converts from BCD to National numeric format. National format
uses a byte to represent a digit where the most significant nibble is
always 0x3 and the least sign. nibbles is the digit itself.
Signed-off-by: Jose Ricardo Ziviani
---
target-ppc/helper.h | 1 +
target-ppc/i
v4:
- throws invalid for any instruction not implemented by default
- creates a function to compare bcd value to zero
v3:
- generates invalid instruction excpetion when opc4 is not handled/invalid
- changes get_national ret. type to uint16_t to handle invalid encoding
- small improvements
v2
translater -> translator (found by codespell)
Signed-off-by: Stefan Weil
---
hw/intc/arm_gicv3_its_kvm.c| 10 +-
include/hw/intc/arm_gicv3_its_common.h | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_it
On 1 November 2016 at 15:28, Stefan Weil wrote:
> translater -> translator (found by codespell)
>
> Signed-off-by: Stefan Weil
This is intentional: the name of the hardware register
in question is GITS_TRANSLATER, the ITS Translation Register.
The R stands for 'register', as is usual for ARM har
Hi Stefan,
On 01/11/2016 16:28, Stefan Weil wrote:
> translater -> translator (found by codespell)
Actually GITS_TRANSLATER is the terminology used for this register in
the ARM GIC architecture specification (IHI0069B).
Thanks
Eric
>
> Signed-off-by: Stefan Weil
> ---
> hw/intc/arm_gicv3_its
On 11/01/2016 06:07 AM, Richard Henderson wrote:
V2, now with more windows workarounds. I'll note that I have not
been 100% successful in actually building a mingw64 image. But
at least the error Peter saw with v1 is fixed.
I'll report on the other mingw64 failures under separate cover.
Bah.
On 11/01/2016 04:02 PM, Paolo Bonzini wrote:
>
>
> On 31/10/2016 14:10, Halil Pasic wrote:
>> I think this got overly complicated.
>
> I agree. :)
>
>> Here is a little patch on
>> top of your stuff which gets rid of 15 lines and IMHO simplifies
>> things quite a bit. What do you think?
>>
Add a new memory debug attribute, this attribute should be set when
memory read or write access is performed for debugging purposes.
Signed-off-by: Brijesh Singh
---
include/exec/memattrs.h |4
1 file changed, 4 insertions(+)
diff --git a/include/exec/memattrs.h b/include/exec/memattrs
In current implementation, read and write of the guest RAM is
performed using using memcpy(). This patch adds support to register
a callback which can override the memcpy() with something else.
This feature will be used in Secure Encrypted Virtualization (SEV)
guests in which read and write of gue
This RFC series provides support for AMD's new Secure Encrypted
Virtualization (SEV) feature. This RFC is based KVM RFC [1].
SEV is an extension to the AMD-V architecture which supports running
multiple VMs under the control of a hypervisor. The SEV feature allows
the memory contents of a virtual
The patch adds the following new APIs:
- cpu_physical_memory_read_debug
- cpu_physical_memory_write_debug
- cpu_physical_memory_rw_debug
- ldl_phys_debug
- ldq_phys_debug
The idea behind this patch is that if all the qemu monitor memory dumps
and gdbserver accesses are done through these common AP
Add APIs to provide guest memory encryption support.
Signed-off-by: Brijesh Singh
---
include/sysemu/kvm.h |8 ++
kvm-all.c| 64 ++
2 files changed, 72 insertions(+)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
in
updates hmp monitor to use debug version of memory access apis when
accessing the guest memory.
Signed-off-by: Brijesh Singh
---
cpus.c|2 +-
disas.c |2 +-
monitor.c |2 +-
target-i386/helper.c | 14 +++---
target-i386/monitor.c |
The command is used to prepare a guest for the transition into
SEV-enabled mode.
Command uses the parameters specified in 'sev-launch-info' object, see
doc/amd-memory-encryption.txt for parameter details. The command creates
a new VM Encryption Key (VEK) and cryptographic context. The key created
The object can be used to define global security policy for the guest.
object provides two properties:
1) debug: can be used to disable guest memory access from hypervisor.
e.g to disable guest memory debug from qemu monitor
# $QEMU \
-object security-policy,debug=false,id=myp
update 'info kvm' to display the memory encryption support.
(qemu) info kvm
kvm support: enabled
memory encryption: disabled
Signed-off-by: Brijesh Singh
---
hmp.c|2 ++
qapi-schema.json |5 -
qmp.c|1 +
3 files changed, 7 insertions(+), 1 deletion(-)
di
On 1 November 2016 at 15:34, Richard Henderson wrote:
> Bah. I think I've been tripped up by the fact that we fail to preserve
> PKG_CONFIG_PATH when re-running configure via make. We really should
> finally fix that -- it's really really annoying when building a non-default
> config.
FWIW this
This patch adds the initial support required to integrate Secure
Encrypted Virtualization (SEV) feature. SEV is an extension to the
existing AMD-V technology found on AMD processors. The SEV feature
allows the memory contents of a virtual machine to be transparently
encrypted with a key unique to t
The command is used to finalize the SEV guest launch process.
The command returns a measurement value of the data encrypted through
the LAUNCH_UPDATE command. This measurement can be handed to the guest
owner to verify that the guest was launched into SEV-enabled mode.
Signed-off-by: Brijesh Sing
Snapshot, Restore and Migration is not implemented in first phase.
Return error when user tries to perform any of these operations.
Signed-off-by: Brijesh Singh
---
migration/migration.c |7 +++
migration/savevm.c| 11 +++
2 files changed, 18 insertions(+)
diff --git a/mi
During system boot, rom_reset copies bios binary from internal PC.BIOS
ROM to guest RAM (PC.RAM).
If memory encryption is enabled then we need to ensure that encryption
context is created before we start the copy process. When encryption is
enabled any data copy from PC.BIOS ROM to guest RAM will
The command is used to encrypt a guest memory region using the VM Encryption
Key (VEK) created by LAUNCH_START command. The firmware will also update
the measurement with the contents of the memory region. This measurement
can be retrieved by calling LAUNCH_FINISH command.
Signed-off-by: Brijesh S
Hi Daniel,
Thanks for pointing that out. I had done a fresh configure and make
before submitting the patch. I am somehow not able to reproduce that
error!
Checked out fresh source just now and tried again, still no luck.
[root@rhel72ga-build-upstream qemu] 2016-11-01 08:51:15$ git apply
~/qemu/3
The command is used to decrypt a page of guest memory for debug.
The command will be used by qemu monitor dump and gdbserver to access
the guest memory for debug purposes. A typical usage look like:
cpu_physical_memory_rw_debug
cpu_physical_memory_rw_debug_internal
sev_debug_decrypt
Sig
Fn8000_001f cpuid provides the memory encryption (aka C-bit) location
in a page table for the SEV-enabled guest.
Signed-off-by: Brijesh Singh
---
target-i386/cpu.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 83998a8..9dc7b4f 100644
---
The command is used to encrypt a region of guest memory for debug.
The command will be used by gdbserver when writing the data into guest
memory for debug purposes (e.g setting breakpoint)
A typical usage looks like:
cpu_memory_rw_debug
cpu_physical_memory_rw_debug_internal
sev_debug_enc
If guest is launched with memory encryption enabled then register
PC.BIOS and PC.RAM memory regions with memory encryption handler.
Registering PC.BIOS memory region will ensure that memory encryption
routines will be used when rom_reset copies the BIOS image into guest memory.
A typical sequence
On 11/01/2016 11:25 PM, Igor Mammedov wrote:
On Tue, 1 Nov 2016 15:17:01 +
Stefan Hajnoczi wrote:
On Sat, Oct 29, 2016 at 12:35:38AM +0800, Xiao Guangrong wrote:
The buffer is used to save the FIT info for all the presented nvdimm
devices which is updated after the nvdimm device is plug
In SEV-enabled guest the physical addresses in page table will
have C-bit set, we need to clear the C-bit when walking the page table.
The C-bit position should be available in cpuid Fn8000_001f[EBX]
Signed-off-by: Brijesh Singh
---
target-i386/helper.c | 37 ++
On Tue, Nov 01, 2016 at 09:34:24AM -0600, Richard Henderson wrote:
> On 11/01/2016 06:07 AM, Richard Henderson wrote:
> > V2, now with more windows workarounds. I'll note that I have not
> > been 100% successful in actually building a mingw64 image. But
> > at least the error Peter saw with v1 is
Paolo Bonzini writes:
> On 21/10/2016 13:54, Alex Bennée wrote:
>> There is a slight wart when checking for the state of the BQL when using
>> GThread base co-routines (which we keep for ThreadSanitizer runs). While
>> the main-loop holds the BQL it is suspended until the co-routine
>> completes
On Tue, Nov 1, 2016 at 2:31 AM, Stefan Hajnoczi wrote:
> Valentine and I attended Google Summer of Code Mentor Summit on behalf
> of QEMU. The event brings together GSoC mentors from all
> participating organizations.
>
> A lot of people benefit from QEMU and told me so at the summit. There
> ar
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization
(AMD)
Message-id: 147801550845.18237.12915616525154608660.stgit@brijesh-build-machine
=== TEST SCRIPT BEG
On 11/01/2016 09:58 PM, Igor Mammedov wrote:
I mean, for example. if there are two devices, the first one is failed to be
realized, the second one is init-ed successfully, then can
nvdimm_plugged_device_list() get these two devices?
Based the code of pc_dimm_built_list(), i guess yes.
nope,
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Subject: [Qemu-devel] [RFC PATCH v3 00/18] x86: Secure Encrypted Virtualization
(AMD)
Message-id: 147801550845.1
On Sat, 29 Oct 2016 00:35:39 +0800
Xiao Guangrong wrote:
> _FIT is required for hotplug support, guest will inquire the updated
> device info from it if a hotplug event is received
>
> As FIT buffer is not completely mapped into guest address space, so a
> new function, Read FIT whose UUID is UU
From: Eric Blake
The NBD protocol allows servers to advertise a human-readable
description alongside an export name during NBD_OPT_LIST. Add
an option to pass through the user's string to the NBD client.
Doing this also makes it easier to test commit 200650d4, which
is the client counterpart of
On 11/01/2016 10:14 PM, Igor Mammedov wrote:
On Tue, 1 Nov 2016 15:55:36 +0200
"Michael S. Tsirkin" wrote:
On Tue, Nov 01, 2016 at 02:21:07PM +0100, Igor Mammedov wrote:
On Tue, 1 Nov 2016 00:48:11 +0200
"Michael S. Tsirkin" wrote:
On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov
Implement error_vprintf to send the output of error_report to
the test log. This silences test-vmstate.
Signed-off-by: Paolo Bonzini
Message-Id: <1477326663-67817-3-git-send-email-pbonz...@redhat.com>
---
include/glib-compat.h | 13 +
stubs/error-printf.c | 8 +++-
2 files cha
On 1 November 2016 at 16:20, Daniel P. Berrange wrote:
> On Tue, Nov 01, 2016 at 09:34:24AM -0600, Richard Henderson wrote:
>> On 11/01/2016 06:07 AM, Richard Henderson wrote:
>> > V2, now with more windows workarounds. I'll note that I have not
>> > been 100% successful in actually building a mi
From: Eric Blake
Rather than open-coding NBD_REP_SERVER, reuse the code we
already have by adding a length parameter. Additionally,
the refactoring will make adding NBD_OPT_GO in a later patch
easier.
Signed-off-by: Eric Blake
Message-Id: <1476469998-28592-7-git-send-email-ebl...@redhat.com>
S
From: Haozhong Zhang
If the memory backend file is not large enough to hold the required 'size',
Qemu will report error and exit.
Signed-off-by: Haozhong Zhang
Message-Id: <20161027042300.5929-3-haozhong.zh...@intel.com>
Signed-off-by: Paolo Bonzini
---
exec.c | 7 +++
1 file changed, 7 i
On Tue, Nov 01, 2016 at 09:09:31AM -0700, ashish mittal wrote:
> Hi Daniel,
>
> Thanks for pointing that out. I had done a fresh configure and make
> before submitting the patch. I am somehow not able to reproduce that
> error!
>
> Checked out fresh source just now and tried again, still no luck.
Otherwise, the CHR_EVENT_OPENED event is sent twice: first when the
backend (for example "stdio") is opened, and second after processing
the command line.
The incorrect sending of the event prints the monitor banner when
QEMU is started with "-serial mon:stdio". This includes the "(qemu)"
prompt;
From: Haozhong Zhang
For '-object memory-backend-file,mem-path=foo,size=xyz', if the size of
file 'foo' does not match the given size 'xyz', the current QEMU will
truncate the file to the given size, which may corrupt the existing data
in that file. To avoid such data corruption, this patch disab
On Tue, 1 Nov 2016 23:57:55 +0800
Xiao Guangrong wrote:
> On 11/01/2016 09:58 PM, Igor Mammedov wrote:
>
> >>
> >> I mean, for example. if there are two devices, the first one is failed to
> >> be
> >> realized, the second one is init-ed successfully, then can
> >> nvdimm_plugged_device_list()
Leave the implementation of error_vprintf and error_vprintf_unless_qmp
(the latter now trivially wrapped by error_printf_unless_qmp) to
libqemustub.a and monitor.c. This has two advantages: it lets us
remove the monitor_printf and monitor_vprintf stubs, and it lets
tests provide a different implem
From: Eric Blake
Our coding convention prefers CamelCase names, and we already
have other existing structs with NBDFoo naming. Let's be
consistent, before later patches add even more structs.
Signed-off-by: Eric Blake
Message-Id: <1476469998-28592-6-git-send-email-ebl...@redhat.com>
Signed-off
From: Jeff Cody
Signed-off-by: Jeff Cody
Message-Id:
<83b0fae0728906e18849c971d22d077d7fc0f179.1478010883.git.jc...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatc
Avoid triggering on
typedef struct BlockJobDriver BlockJobDriver;
or
struct BlockJobDriver {
Cc: John Snow
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
inde
From: Eric Blake
We have both 'struct NBDRequest' and 'struct nbd_request'; making
it confusing to see which does what. Furthermore, we want to
rename nbd_request to align with our normal CamelCase naming
conventions. So, rename the struct which is used to associate
the data received during req
From: Pranith Kumar
s/presented/prevented/
Signed-off-by: Pranith Kumar
Message-Id: <20161018050418.4912-1-bobby.pr...@gmail.com>
Signed-off-by: Paolo Bonzini
---
docs/rcu.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/rcu.txt b/docs/rcu.txt
index a70b72c..c84e7f
From: Eric Blake
The server has a nice helper function nbd_negotiate_drop_sync()
which lets it easily ignore fluff from the client (such as the
payload to an unknown option request). We can't quite make it
common, since it depends on nbd_negotiate_read() which handles
coroutine magic, but we can
From: Changlong Xie
NBD is using the CoMutex in a way that wasn't anticipated. For example, if
there are
N(N=26, MAX_NBD_REQUESTS=16) nbd write requests, so we will invoke
nbd_client_co_pwritev
N times.
tim
From: Eric Blake
Current upstream NBD documents that requests have a 16-bit flags,
followed by a 16-bit type integer; although older versions mentioned
only a 32-bit field with masking to find flags. Since the protocol
is in network order (big-endian over the wire), the ABI is unchanged;
but dea
From: Eric Blake
The NBD Protocol allows the server and client to mutually agree
on a shorter handshake (omit the 124 bytes of reserved 0), via
the server advertising NBD_FLAG_NO_ZEROES and the client
acknowledging with NBD_FLAG_C_NO_ZEROES (only possible in
newstyle, whether or not it is fixed n
Done!
All builds are fine, but I have no way of knowing if that fixed the
issue! Please let me know if you still see a problem.
[root@rhel72ga-build-upstream qemu] 2016-11-01 09:46:06$ make
CC block/vxhs.o
LINKqemu-nbd
LINKqemu-img
LINKqemu-io
LINKaarch64-softmmu/qe
The following changes since commit 39542105bbb19c690219d2f22844d8dfbd9bba05:
Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
(2016-11-01 12:48:07 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch
From: Eric Blake
The NBD spec says that a client should send NBD_OPT_ABORT
rather than just dropping the connection, if the client doesn't
like something the server sent during option negotiation. This
is a best-effort attempt only, and can only be done in places
where we know the server is stil
From: Eric Blake
Upstream NBD protocol recently added the ability to efficiently
write zeroes without having to send the zeroes over the wire,
along with a flag to control whether the client wants a hole.
The generic block code takes care of falling back to the obvious
write of lots of zeroes if
Pranith Kumar writes:
> On Tue, Nov 1, 2016 at 3:45 AM, Alex Bennée wrote:
>
>>
>> Odd. I'll look into it. What was you configure string and host architecture?
>>
>
> It's a plain configure string, nothing special:
>
> $ ../configure --target-list=aarch64-softmmu
>
> But I did rebase your patch
From: Alex Bennée
The memory_dispatch field is meant to be protected by RCU so we should
use the correct primitives when accessing it. This race was flagged up
by the ThreadSanitizer.
Signed-off-by: Alex Bennée
Message-Id: <20161021153418.21571-1-alex.ben...@linaro.org>
Signed-off-by: Paolo Bo
From: Eric Blake
NBD commit 6d34500b clarified how clients and servers are supposed
to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN
(for the server to announce it is about to go away during option
haggling, so the client should quit sending NBD_OPT_* other than
NBD_OPT_ABORT)
From: Luwei Kang
The spec can be found in Intel Software Developer Manual or in
Instruction Set Extensions Programming Reference.
Signed-off-by: Piotr Luc
Signed-off-by: Luwei Kang
Message-Id: <1477902446-5932-1-git-send-email-he.c...@linux.intel.com>
Signed-off-by: Paolo Bonzini
---
target-
On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote:
[...]
> > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp)
> > {
> > PCMachineState *pcms = PC_MACHINE(obj);
> > @@ -2159,6 +2173,8 @@ static void pc_machine_initfn(Object *obj)
> > pcms->vmport = O
From: Eric Blake
It's better to use consistent capitalization of the namespace
used for NBD functions; we have more instances of NBD* than
Nbd*.
Signed-off-by: Eric Blake
Message-Id: <1476469998-28592-5-git-send-email-ebl...@redhat.com>
Signed-off-by: Paolo Bonzini
---
block/nbd-client.c | 26
From: Eric Blake
Upstream NBD protocol recently added the ability to efficiently
write zeroes without having to send the zeroes over the wire,
along with a flag to control whether the client wants to allow
a hole.
Note that when it comes to requiring full allocation, vs.
permitting optimizations
On 1 November 2016 at 16:22, wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
Fam, it looks like patchew's test script is assuming git arguments
that don't exist on the git version it's trying to use:
> === TEST SCRIPT BEGIN ===
> #
From: Eric Blake
The NBD Protocol allows us to send human-readable messages
along with any NBD_REP_ERR error during option negotiation;
make use of this fact for clients that know what to do with
our message.
Signed-off-by: Eric Blake
Message-Id: <1476469998-28592-8-git-send-email-ebl...@redhat
From: Christian Borntraeger
For automated testing purposes it can be helpful to exit qemu
(poweroff) when the guest panics. Make this the default unless
-no-shutdown is specified.
For internal-errors like errors from KVM_RUN the behaviour is
not changed, in other words QEMU does not exit to allo
On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote:
> On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote:
> [...]
> > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp)
> > > {
> > > PCMachineState *pcms = PC_MACHINE(obj);
> > > @@ -2159,6 +2173,8 @@
From: Eric Blake
Rather than open-coding each option request, it's easier to
have common helper functions do the work. That in turn requires
having convenient packed types for handling option requests
and replies.
Signed-off-by: Eric Blake
Message-Id: <1476469998-28592-9-git-send-email-ebl...@
On Tue, Nov 01, 2016 at 02:59:25PM -0200, Eduardo Habkost wrote:
> On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote:
> > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote:
> > [...]
> > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error
> > > > **errp)
> > >
From: Max Reitz
We do not want to display the "I/O thread spun" warning for test cases
that run under qtest. The first attempt for this (commit
01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled()
was true.
Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd correctly recognized
Introduce this field to control whether ACPI build is enabled by a
particular machine or accelerator.
It defaults to true so that PC machine has ACPI build by default. Xen
accelerator will disable it because Xen is in charge of building ACPI
tables for the guest.
Signed-off-by: Wei Liu
---
Cc: I
From: Eric Blake
Since we know that the maximum name we are willing to accept
is small enough to stack-allocate, rework the iteration over
NBD_OPT_LIST responses to reuse a stack buffer rather than
allocating every time. Furthermore, we don't even have to
allocate if we know the server's length
From: Eric Blake
Checkpatch complains that 'return EINVAL' is usually wrong
(since we tend to favor 'return -EINVAL'). But it is a
false positive for nbd_errno_to_system_errno(). Since NBD
may add future defined wire values, refactor the code to
keep checkpatch happy.
Signed-off-by: Eric Blake
Reuse the existing locking provided by stdio to keep in_asm, cpu,
op, op_opt, op_ind, and out_asm as contiguous blocks.
While it isn't possible to interleave e.g. in_asm or op_opt logs
because of the TB lock protecting all code generation, it is
possible to interleave cpu logs, or to interleave a
Fix also some indefinite articles.
Signed-off-by: Stefan Weil
---
I still don't understand the comment in docs/colo-proxy.txt.
Stefan
docs/COLO-FT.txt| 2 +-
docs/colo-proxy.txt | 2 +-
qemu-doc.texi | 2 +-
qemu-options.hx | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-
Signed-off-by: Stefan Weil
---
hw/block/m25p80.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index d29ff4c..09ea51f 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -121,7 +121,7 @@ typedef struct FlashPartInfo {
#define
SLIRP expects a CharBackend as the third argument to slirp_add_exec,
but net/slirp.c was passing a CharDriverState. Fix this to restore
guestfwd functionality.
Reported-by: Dr. David Alan Gilbert
Signed-off-by: Paolo Bonzini
---
net/slirp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
On Tue, Nov 01, 2016 at 09:52:59AM -0700, ashish mittal wrote:
> Done!
>
> All builds are fine, but I have no way of knowing if that fixed the
> issue! Please let me know if you still see a problem.
configure works for me after pulling your libqnio update
Regards,
Daniel
--
|: http://berrange
On 11/01/2016 08:26 AM, Peter Maydell wrote:
i686-w64-mingw32 builds fail to link :-(
exec.o: In function `qemu_flockfile':
/home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:110:
undefined reference to `_imp___lock_file'
exec.o: In function `qemu_funlockfile':
/home/petmay01/linaro
On 1 November 2016 at 17:25, Michael S. Tsirkin wrote:
> A general question - I have a couple of tweaks to tests in
> my tree. Didn't push to avoid them blocking the features.
> I think test tweaks are fair game after freeze - agree?
Yes, especially if they're only tweaks, not enormous
changes.
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31
Message-id: 1478017783-7703-1-git-send-email-pbonz...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
to
ranch 'remotes/cody/tags/block-pull-request' into
staging (2016-11-01 14:27:05 +)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-tcg-20161101-2
for you to fetch changes up to 3ff91d7e85176f8b4b131163d7fd801757a2c949:
tcg: correct 32-bit tcg_ge
On Tue, Nov 01, 2016 at 03:22:01PM +, Peter Maydell wrote:
> On 30 October 2016 at 21:23, Michael S. Tsirkin wrote:
> > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6:
> >
> > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1'
> > into staging
On Tue, Nov 01, 2016 at 05:12:37PM +, Wei Liu wrote:
> On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote:
> > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote:
> > [...]
> > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque,
> > > int running,
> > >
The following changes since commit c46ef897dbb75590af94b6e3dca6a9c5f9a1ea1e:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> staging (2016-11-01 14:27:05 +)
>
> are available in the git repository at:
>
> git://github.com/rth7680/qe
Introduce this field to control whether ACPI build is enabled by a
particular machine or accelerator.
It defaults to true if the machine itself supports ACPI build. Xen
accelerator will disable it because Xen is in charge of building ACPI
tables for the guest.
Signed-off-by: Wei Liu
---
Cc: Igor
On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote:
> Introduce this field to control whether ACPI build is enabled by a
> particular machine or accelerator.
>
> It defaults to true so that PC machine has ACPI build by default. Xen
> accelerator will disable it because Xen is in charge of bui
On Sat, Oct 29, 2016 at 12:35:39AM +0800, Xiao Guangrong wrote:
> +1) Read FIT
> + As we only reserved one page for NVDIMM ACPI it is impossible to map the
> + whole FIT data to guest's address space. This function is used by _FIT
> + method to read a piece of FIT data from QEMU.
> +
> + In
101 - 200 of 258 matches
Mail list logo
