Re: [Qemu-devel] [PATCHv5 08/12] tests: Clean up IO handling in ide-test

2016-10-25 Thread Alexey Kardashevskiy
On 24/10/16 15:59, David Gibson wrote: > ide-test uses many explicit inb() / outb() operations for its IO, which > means it's not portable to non-x86 platforms. This cleans it up to use > the libqos PCI accessors instead. > > Signed-off-by: David Gibson > --- > tests/ide-test.c | 179 > +++

[Qemu-devel] [PATCH] adb: change handler only when recognized

2016-10-25 Thread Hervé Poussineau
ADB devices must take new handler into account only when they recognize it. This lets operating systems probe for valid/invalid handles, to know device capabilities. Add a FIXME in keyboard handler, which should use a different translation table depending of the selected handler. Signed-off-by:

[Qemu-devel] Request IVSHMEM sample codes working in VM

2016-10-25 Thread Royce Niu
Dear all, I am going to implement some applications in NFV via IVSHMEM. But, I find only the sample codes working in hypervisor. Is there any sample to show how to do inter-VM communication? Thanks. -- Regards, Royce Niu

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Fam Zheng
On Mon, 10/24 12:11, Kevin Wolf wrote: > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > I personally still don't like making locking a qdev property very much > > because it doesn't make sense to me*. But I remember Kevin had his > > reasons (even though I can no longer remember th

Re: [Qemu-devel] [PATCH V7 0/2] Add option to configure guest vPMU

2016-10-25 Thread Andrew Jones
On Mon, Oct 24, 2016 at 11:39:59PM -0500, Wei Huang wrote: > >> V6->V7: > >> * change has_pmu variable type from OnOffAuto to Boolean > >> * only add "pmu" property to CPU under kvm mode, default ON > > > > Hmm, if we don't allow the property with TCG then switching a guest from > > KVM to TCG

Re: [Qemu-devel] [PATCH v5 15/17] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2016-10-25 Thread Cédric Le Goater
On 10/25/2016 07:30 AM, David Gibson wrote: > On Sat, Oct 22, 2016 at 11:46:48AM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> The PSI (Processor Service Interface) is one of the engines of the >> "Bridge" unit which connects the different interfaces to the Power >> Processo

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Richard W.M. Jones
On Tue, Oct 25, 2016 at 03:09:51PM +0800, Fam Zheng wrote: > On Mon, 10/24 12:11, Kevin Wolf wrote: > > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > > > > I personally still don't like making locking a qdev property very much > > > because it doesn't make sense to me*. But I reme

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Kevin Wolf
Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > On 24.10.2016 12:11, Kevin Wolf wrote: > > [...] > > > Now, the big question is how to translate this into file locking. This > > could become a little tricky. I had a few thoughts involving another > > lock on byte 2, but none of them actually

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-25 Thread Alex Bennée
David Gibson writes: > On Mon, Oct 24, 2016 at 03:44:01PM +0100, Alex Bennée wrote: >> >> Alex Bennée writes: >> >> > Hi, >> > >> > In the MTTCG patch set one of the big patches is to remove the >> > requirement to hold the BQL while running code: >> > >> > tcg: drop global lock during TCG co

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-10-25 Thread Kevin Wolf
Am 25.10.2016 um 01:06 hat Ed Swierk geschrieben: > On Mon, Oct 24, 2016 at 2:21 PM, Eric Blake wrote: > > How are you getting max_transfer == 65536? I can't reproduce it with > > the following setup: > > > > $ qemu-img create -f qcow2 -o cluster_size=1M file 10M > > $ qemu-io -f qcow2 -c 'w 7m 1

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-25 Thread Alex Bennée
Nikunj A Dadhania writes: > Alex Bennée writes: > >> Hi, >> >> In the MTTCG patch set one of the big patches is to remove the >> requirement to hold the BQL while running code: >> >> tcg: drop global lock during TCG code execution >> >> And this broke the PPC code because emulate_ppc_hypercal

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-10-25 Thread Abhijit Dey
+ Venky from Storage engineering Sent from my iPhone > On Oct 24, 2016, at 4:24 PM, Paolo Bonzini wrote: > > > >> On 20/10/2016 03:31, Ketan Nilangekar wrote: >> This way the failover logic will be completely out of qemu address >> space. We are considering use of some of our proprietary >> c

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-10-25 Thread Abhijit Dey
+ Venky Sent from my iPhone > On Oct 25, 2016, at 7:07 AM, Ketan Nilangekar > wrote: > > We are able to derive significant performance from the qemu block driver as > compared to nbd/iscsi/nfs. We have prototyped nfs and nbd based io tap in the > past and the performance of qemu block driver

Re: [Qemu-devel] [PATCH RFC 1/7] docs/block-replication: Add description for shared-disk case

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: Introuduce the scenario of shared-disk block replication and how to use it. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- docs/block-replication.txt | 131 +++-- 1

Re: [Qemu-devel] [PATCHv5 11/12] tests: Don't assume structure of PCI IO base in ahci-test

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 16:00:00 +1100 David Gibson wrote: > In a couple of places ahci-test makes assumptions about how the tokens > returned from qpci_iomap() are formatted in ways it probably shouldn't. > > First in verify_state() it uses a non-NULL token to indicate that the AHCI > device has be

Re: [Qemu-devel] [PATCH v5 0/4] fdc: Use separate qdev device for drives

2016-10-25 Thread Kevin Wolf
Am 24.10.2016 um 20:44 hat John Snow geschrieben: > On 10/24/2016 07:37 AM, Kevin Wolf wrote: > >We have been complaining for a long time about how the floppy controller and > >floppy drives are combined in a single qdev device and how this makes the > >device awkward to work with because it behave

[Qemu-devel] [PATCH] tests: Restore check-qdict unit test

2016-10-25 Thread Markus Armbruster
Commit ea3af47 accidentally dropped check-qdict from the list of unit tests. Put it back. Signed-off-by: Markus Armbruster --- Could be committed directly as a build fix. If not, I'll include it in my next pull. tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Qemu-devel] [PATCH real v5 0/4] fdc: Use separate qdev device for drives

2016-10-25 Thread Kevin Wolf
We have been complaining for a long time about how the floppy controller and floppy drives are combined in a single qdev device and how this makes the device awkward to work with because it behaves different from all other block devices. The latest reason to complain was when I noticed that using

[Qemu-devel] [PATCH v5 1/4] fdc: Add a floppy qbus

2016-10-25 Thread Kevin Wolf
This adds a qbus to the floppy controller that should contain the floppy drives eventually. At the moment it just exists and is empty. Signed-off-by: Kevin Wolf Reviewed-by: John Snow --- hw/block/fdc.c | 40 +++- 1 file changed, 35 insertions(+), 5 deletions

[Qemu-devel] [PATCH v5 2/4] fdc: Add a floppy drive qdev

2016-10-25 Thread Kevin Wolf
Floppy controllers automatically create two floppy drive devices in qdev now. (They always created two drives, but managed them only internally.) Signed-off-by: Kevin Wolf Reviewed-by: John Snow --- hw/block/fdc.c | 151 + 1 file changed,

[Qemu-devel] [PATCH v5 3/4] fdc: Move qdev properties to FloppyDrive

2016-10-25 Thread Kevin Wolf
This makes the FloppyDrive qdev object actually useful: Now that it has all properties that don't belong to the controller, you can actually use '-device floppy' and get a working result. Command line semantics is consistent with CD-ROM drives: By default you get a single empty floppy drive. You c

[Qemu-devel] [PATCH v5 4/4] qemu-iotests: Test creating floppy drives

2016-10-25 Thread Kevin Wolf
This tests the different supported methods to create floppy drives and how they interact. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/172 | 246 ++ tests/qemu-iotests/172.out | 1170 tests/qemu-iotests/group |1 + 3 files chang

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Fam Zheng
On Tue, 10/25 09:06, Richard W.M. Jones wrote: > On Tue, Oct 25, 2016 at 03:09:51PM +0800, Fam Zheng wrote: > > On Mon, 10/24 12:11, Kevin Wolf wrote: > > > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > > > > > > > I personally still don't like making locking a qdev property very

Re: [Qemu-devel] [PULL 00/32] target-arm queue

2016-10-25 Thread Peter Maydell
On 24 October 2016 at 18:24, Peter Maydell wrote: > My review queue is currently empty. I may do another > small pullreq towards the end of the week if a few things > that didn't pass code review get respun. > > thanks > -- PMM > > The following changes since commit a3ae21ec3fe036f536dc94cad735931

Re: [Qemu-devel] [PATCHv5 10/12] tests: Use qpci_mem{read, write} in ivshmem-test

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 15:59:59 +1100 David Gibson wrote: > ivshmem implements a block of shared memory in a PCI BAR. Currently our > test case accesses this using qtest_mem{read,write}. However, deducing > the correct addresses for these requires making assumptions about the > internel format ret

Re: [Qemu-devel] [PATCHv5 12/12] libqos: Change PCI accessors to take opaque BAR handle

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 16:00:01 +1100 David Gibson wrote: > The usual use model for the libqos PCI functions is to map a specific PCI > BAR using qpci_iomap() then pass the returned token into IO accessor > functions. This, and the fact that iomap() returns a (void *) which > actually contains a PC

Re: [Qemu-devel] [PATCH v2 00/13] Refactor common part of xen backend and frontend

2016-10-25 Thread Xuquan (Quan Xu)
On October 13, 2016 2:02 PM, Emil Condrea wrote: >This patch series was splitted from QEMU:Xen stubdom vTPM for HVM virtual >machine http://markmail.org/message/fkix7g3a5zdj7lvr > >It contains a reorganization of xen backend and frontend functions together >with >code style fixes. >Common functio

[Qemu-devel] [PATCH] Versatile memory should not exceed 256MB.

2016-10-25 Thread Jean-Christophe Dubois
For now Qemu accpet a memory size greater than 256 MB but it would crash afterward. Versatile devices are starting at 256 MB bondary. Signed-off-by: Jean-Christophe Dubois --- hw/arm/versatilepb.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatil

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-25 Thread Pradeep Jagadeesh
On 10/24/2016 3:00 PM, Alberto Garcia wrote: On Sat 22 Oct 2016 05:07:22 PM CEST, Pradeep Jagadeesh wrote: This adds the support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-25 Thread Pradeep Jagadeesh
On 10/24/2016 11:28 PM, Greg Kurz wrote: Re-post (I had hit the send button by error :) On Sat, 22 Oct 2016 11:07:22 -0400 Pradeep Jagadeesh wrote: Signed-off-by: Pradeep Jagadeesh --- Hi Pradeep, I see that Berto already did a thorough review for this patch and I agree for all the sugges

[Qemu-devel] macOS 10.12 Sierra, Xcode 8 & clock_gettime()

2016-10-25 Thread Liviu Ionescu
In Xcode 8 (more or less mandatory after upgrading to Sierra), Apple added support for `clock_gettime(CLOCK_MONOTONIC, &ts)`, which is not bad in itself. Unfortunately, with this addition, a QEMU built on 10.12 runs **only** on 10.12; on previous versions it fails with something like: ``` $ ./q

Re: [Qemu-devel] [PATCH] i.MX: Fix GPIO ISR register write

2016-10-25 Thread Jean-Christophe DUBOIS
Le 25/10/2016 à 04:03, Guenter Roeck a écrit : Writing the ISR register is supposed to clear interrupt status bits, not to set them. This patch makes '-M sabrelite' work without devicetree changes (Linux kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with multi_v7_defconfig;

Re: [Qemu-devel] [RESEND PATCH v3 kernel 4/7] virtio-balloon: speed up inflate/deflate process

2016-10-25 Thread Li, Liang Z
> > +static inline void init_pfn_range(struct virtio_balloon *vb) { > > + vb->min_pfn = ULONG_MAX; > > + vb->max_pfn = 0; > > +} > > + > > +static inline void update_pfn_range(struct virtio_balloon *vb, > > +struct page *page) > > +{ > > + unsigned long balloon_pfn

Re: [Qemu-devel] [PATCH RFC 2/7] block-backend: Introduce blk_root() helper

2016-10-25 Thread Changlong Xie
I know you need blk->root in the next patch, but we strongly don't recommend your current solution. Please refer Kevin's cf2ab8fc 1409 /* XXX Ugly way to get blk->root, but that's a feature, not a bug. This 1410 * hack makes it obvious that vhdx_write_header() bypasses the BlockBacke

Re: [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- block/replication.c | 33 + 1 file changed, 33 insertions(+) diff -

Re: [Qemu-devel] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it

2016-10-25 Thread Kevin Wolf
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > Add InetSocketAddress compatibility to SSH driver. > > Add a new option "server" to the SSH block driver which then accepts > a InetSocketAddress. > > "host" and "port" are supported as legacy options and are mapped to > their InetSocketA

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-25 Thread Eduardo Habkost
On Tue, Oct 25, 2016 at 02:42:41PM +0800, Haozhong Zhang wrote: > On 10/24/16 11:10 -0200, Eduardo Habkost wrote: > > On Thu, Oct 20, 2016 at 03:55:22PM +0200, Kevin Wolf wrote: > > > Am 20.10.2016 um 14:34 hat Igor Mammedov geschrieben: > > > > > #ifdef __linux__ > > > > > +static uint64_t get_fi

Re: [Qemu-devel] macOS 10.12 Sierra, Xcode 8 & clock_gettime()

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 10:43, Liviu Ionescu wrote: > In Xcode 8 (more or less mandatory after upgrading to Sierra), Apple added > support for `clock_gettime(CLOCK_MONOTONIC, &ts)`, which is not bad in itself. > > Unfortunately, with this addition, a QEMU built on 10.12 runs **only** on > 10.12; o

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-25 Thread Markus Armbruster
Max Reitz writes: > On 21.10.2016 11:58, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >>> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: "Daniel P. Berrange" writes: > The qdict_flatten() method will take a dict whose elements are > further

Re: [Qemu-devel] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public

2016-10-25 Thread Kevin Wolf
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > Make inet_connect_saddr() in util/qemu-sockets.c public in order to be > able to use it with InetSocketAddress sockets outside of > util/qemu-sockets.c independently. > > Signed-off-by: Ashijeet Acharya Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 4/5] block/ssh: Use InetSocketAddress options

2016-10-25 Thread Kevin Wolf
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > Drop the use of legacy options in favour of the InetSocketAddress > options. > > Signed-off-by: Ashijeet Acharya > Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict()

2016-10-25 Thread Kevin Wolf
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > We have 5 options plus ("server") option which is added in the next > patch that conflict with specifying a SSH filename. We need to iterate > over all the options to check whether its key has an "server." prefix. > > This iteration will h

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-10-25 Thread Aviv B.D.
On Mon, Oct 24, 2016 at 11:02 AM, Peter Xu wrote: > On Mon, Oct 24, 2016 at 10:53:01AM +0300, Aviv B.D. wrote: > > [...] > > > This was my first algorithm, but VFIO do not support remapping of mapped > > page. > > Before each MAP operation in VFIO one must do unmap, and therefore I'm > > sending

Re: [Qemu-devel] [PATCH v3 5/5] qapi: allow blockdev-add for ssh

2016-10-25 Thread Kevin Wolf
Am 17.10.2016 um 19:32 hat Ashijeet Acharya geschrieben: > Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to > support blockdev-add for SSH network protocol driver. Use only 'struct > InetSocketAddress' since SSH only supports connection over TCP. > > Signed-off-by: Ashijeet Ach

Re: [Qemu-devel] [RFC PATCH 3/4] migration/vmstate: fix array of pointers to struct

2016-10-25 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the reward > for trying to migrate an array with some null pointers in it was an > illegal memory access, that is a swift and painless death of the > process. Let's make vmstate cope with

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-25 Thread Daniel P. Berrange
On Tue, Oct 25, 2016 at 12:03:33PM +0200, Markus Armbruster wrote: > Max Reitz writes: > > > On 21.10.2016 11:58, Markus Armbruster wrote: > >> "Daniel P. Berrange" writes: > >> > >>> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: >

Re: [Qemu-devel] macOS 10.12 Sierra, Xcode 8 & clock_gettime()

2016-10-25 Thread Liviu Ionescu
> On 25 Oct 2016, at 13:02, Peter Maydell wrote: > > ... Does "build on 10.12, run on earlier versions" work apart from > that problem? it is a challenge for me to test, since I don't have a 10.11 at hand; I'll try to have an answer in the evening, but I expect it'll work. regards, Liviu

Re: [Qemu-devel] [PULL v2 00/16] x86 and CPU queue, 2016-10-24

2016-10-25 Thread Peter Maydell
On 24 October 2016 at 20:52, Eduardo Habkost wrote: > Change in v2: > * Removed patch: "target-i386: Print warning when mixing [+-]foo > and foo=(on|off)" > > The following changes since commit a3ae21ec3fe036f536dc94cad735931777143103: > > Merge remote-tracking branch 'remotes/bonzini/tags/for

Re: [Qemu-devel] [PATCH 12/22] qcow2-bitmap: add IN_USE flag

2016-10-25 Thread Vladimir Sementsov-Ogievskiy
24.10.2016 20:18, Max Reitz wrote: On 24.10.2016 19:08, Max Reitz wrote: On 24.10.2016 13:35, Vladimir Sementsov-Ogievskiy wrote: 24.10.2016 13:32, Vladimir Sementsov-Ogievskiy пишет: 21.10.2016 22:58, Max Reitz пишет: On 21.10.2016 17:34, Vladimir Sementsov-Ogievskiy wrote: 07.10.2016 22:44

Re: [Qemu-devel] [PATCH v5 13/17] ppc/xics: add a xics_get_cpu_index_by_pir helper

2016-10-25 Thread Cédric Le Goater
On 10/25/2016 07:36 AM, David Gibson wrote: > On Sat, Oct 22, 2016 at 11:46:46AM +0200, Cédric Le Goater wrote: >> We will need this helper to translate the server number of the XIVE >> (which is a PIR) into an ICPState index number (which is a cpu index). >> >> Signed-off-by: Cédric Le Goater >

Re: [Qemu-devel] [PATCH v5 15/17] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2016-10-25 Thread Cédric Le Goater
>> +#define PSIHB_MMIO_BAR 0x00 >> +#define PSIHB_MMIO_FSPBAR 0x08 >> +#define PSIHB_MMIO_CR 0x20 >> +#define PSIHB_MMIO_SEMR 0x28 >> +#define PSIHB_MMIO_XIVR_PSI 0x30 >> +#define PSIHB_MMIO_SCR 0x40 >> +#define PSIHB_MMIO_CCR 0x48 >> +#define

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 07:07, Ketan Nilangekar wrote: > We are able to derive significant performance from the qemu block > driver as compared to nbd/iscsi/nfs. We have prototyped nfs and nbd > based io tap in the past and the performance of qemu block driver is > significantly better. Hence we would like

Re: [Qemu-devel] KVM call for 2016-10-25

2016-10-25 Thread Juan Quintela
Juan Quintela wrote: > Hi As there are no topics, call gets cancelled. Happy hacking, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the

Re: [Qemu-devel] [PATCH 16/22] qmp: add persistent flag to block-dirty-bitmap-add

2016-10-25 Thread Vladimir Sementsov-Ogievskiy
24.10.2016 20:30, Max Reitz wrote: On 24.10.2016 17:12, Vladimir Sementsov-Ogievskiy wrote: 10.10.2016 19:08, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: [...] +} out: aio_context_release(aio_context); diff --git a/qapi/block-core.json b/qapi/b

Re: [Qemu-devel] [PATCH 2/2] tests: send error_report to test log

2016-10-25 Thread Halil Pasic
On 10/24/2016 06:31 PM, Paolo Bonzini wrote: > Implement error_vprintf to send the output of error_report to > the test log. This silences test-vmstate. > > Signed-off-by: Paolo Bonzini [..] > void error_vprintf(const char *fmt, va_list ap) > { > -vfprintf(stderr, fmt, ap); > +if (g_

Re: [Qemu-devel] [PATCH 1/2] tests: Simplify expected error checking for qmp output

2016-10-25 Thread Markus Armbruster
Eric Blake writes: > Minor test cleanup noticed while writing a new test. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 2/2] tests: Enhance qmp output to cover partial visit

2016-10-25 Thread Markus Armbruster
Eric Blake writes: > Add a test that proves (at least when run under valgrind) that > we are correctly handling allocated memory even when a visit > is aborted in the middle for whatever other reason. > > See commit f24582d "qapi: fix double free in > qmp_output_visitor_cleanup()" for a fix that

Re: [Qemu-devel] [PATCH] i.MX: Fix GPIO ISR register write

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 03:03, Guenter Roeck wrote: > Writing the ISR register is supposed to clear interrupt status bits, > not to set them. > > This patch makes '-M sabrelite' work without devicetree changes (Linux > kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with > multi_

Re: [Qemu-devel] [PATCH] arm: cubieboard: Add support for initrd

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 03:05, Guenter Roeck wrote: > Signed-off-by: Guenter Roeck > --- > hw/arm/cubieboard.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c > index fbd78ed..dd19ba3 100644 > --- a/hw/arm/cubieboard.c > +++ b/hw/arm/cubieboard.c

Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-10-25 Thread Gonglei (Arei)
Hi Michael and Stefan, Ping... Would you please review and/or merge this feature for Qemu 2.8 because the soft-freeze period draw near. Thanks, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, October 20, 2016 7:46 PM > Subject: [PATCH v9 00/12] virtio-crypto: int

Re: [Qemu-devel] [PATCH 2/2] memory: Don't use memcpy for ram_device regions

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 01:00, Alex Williamson wrote: > With a vfio assigned device we lay down a base MemoryRegion registered > as an IO region, giving us read & write accessors. If the region > supports mmap, we lay down a higher priority sub-region MemoryRegion > on top of the base layer initialized as

Re: [Qemu-devel] [PATCH 2/2] tests: send error_report to test log

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 13:06, Halil Pasic wrote: > > > On 10/24/2016 06:31 PM, Paolo Bonzini wrote: >> Implement error_vprintf to send the output of error_report to >> the test log. This silences test-vmstate. >> >> Signed-off-by: Paolo Bonzini > [..] >> void error_vprintf(const char *fmt, va_list ap

Re: [Qemu-devel] macOS 10.12 Sierra, Xcode 8 & clock_gettime()

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 11:43, Liviu Ionescu wrote: > In Xcode 8 (more or less mandatory after upgrading to Sierra), Apple added > support for `clock_gettime(CLOCK_MONOTONIC, &ts)`, which is not bad in itself. > > Unfortunately, with this addition, a QEMU built on 10.12 runs **only** on > 10.12; on prev

Re: [Qemu-devel] [PATCH] tests: Restore check-qdict unit test

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 10:09, Markus Armbruster wrote: > Commit ea3af47 accidentally dropped check-qdict from the list of unit > tests. Put it back. > > Signed-off-by: Markus Armbruster > --- > Could be committed directly as a build fix. If not, I'll include it > in my next pull. Applied to mas

[Qemu-devel] [PATCH 0/4] linux-user: fix timespec and itimerspec related issues, add clock_settime

2016-10-25 Thread Dejan Jovicevic
In this series the clock_gettime() was fixed to behave as intended when not having valid arguments. The emulation for the system call clock_settime() was added. Conversion of itimerspec structure and error handling in timer_settime() syscall were corrected. Dejan Jovicevic (4): linux-user: fix c

[Qemu-devel] [PATCH 3/4] linux-user: correct conversion of itimerspec structure

2016-10-25 Thread Dejan Jovicevic
__get_user() and __put_user() have certain advantages over tswapal(). There was also a previous commit for equivalent change for converting structure timespec. Signed-off-by: Dejan Jovicevic --- linux-user/syscall.c | 39 +-- 1 file changed, 17 insertions(+),

Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives

2016-10-25 Thread Eduardo Habkost
On Mon, Oct 24, 2016 at 12:04:33PM -0700, Richard Henderson wrote: > Pinging target maintainers. If I don't get responses by the end of the > week, I'll only push the generic tcg bits and the two targets that I > maintain. I can't say I fully reviewed it, but I trust your judgement. For the i386

Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx: Correctly handle external GPIO reset requests

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 03:06, Guenter Roeck wrote: > The internal GPIO reset, enabled with GPR_EN, only applies to GPIO pin 1. > If other GPIO pins are used for reset, this is unrelated to GPR_EN, the > reset is an external reset pin, and it resets the entire system. > > This fixes GPIO reset failu

[Qemu-devel] [PATCH 1/4] linux-user: fix clock_gettime()

2016-10-25 Thread Dejan Jovicevic
When timespec stucture pointer points outside the accessible address space (i.e. it's an invalid pointer), the clock_gettime() syscall should return with -1 and set the errno to EFAULT. This wasn't the case, since there was no check if the host_to_target_timespec() failed. This check was added and

[Qemu-devel] [PATCH 4/4] linux-user: timer_settime fix

2016-10-25 Thread Dejan Jovicevic
Error handling was improved. host_to_target_itimerspec() was invoked with arg2 passed instead of arg4. Signed-off-by: Dejan Jovicevic --- linux-user/syscall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b4f53b1..ca

[Qemu-devel] [PATCH 2/4] linux-user: add clock_settime()

2016-10-25 Thread Dejan Jovicevic
The implementation of the clock_settime() system call emulation is based on converting the timespec structure values from target to host and then calling the clock_settime() syscall on the host. Signed-off-by: Dejan Jovicevic --- linux-user/syscall.c | 11 +++ 1 file changed, 11 insertio

Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 03:07, Guenter Roeck wrote: > The code used default values for PXA270 to configure CCCR. For PXA255, > the resulting register value is invalid (unsupported) and resulted > in a division by zero in the Linux kernel. Use default values from > datasheet instead. > > Signed-off-b

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-10-25 Thread Peter Lieven
Am 01.08.2016 um 11:22 schrieb Paolo Bonzini: On 28/07/2016 04:39, Eric Blake wrote: On 07/27/2016 01:25 AM, Fam Zheng wrote: On Thu, 07/21 13:34, Eric Blake wrote: +max_write_zeroes = max_write_zeroes / alignment * alignment; Not using QEMU_ALIGN_DOWN despite patch 3? Looks like I miss

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 14:03, Peter Lieven wrote: > Am 01.08.2016 um 11:22 schrieb Paolo Bonzini: >> >> On 28/07/2016 04:39, Eric Blake wrote: >>> On 07/27/2016 01:25 AM, Fam Zheng wrote: On Thu, 07/21 13:34, Eric Blake wrote: > +max_write_zeroes = max_write_zeroes / alignment * alignment; >>

Re: [Qemu-devel] [PATCH] Versatile memory should not exceed 256MB.

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 10:37, Jean-Christophe Dubois wrote: > For now Qemu accpet a memory size greater than 256 MB but it would > crash afterward. > > Versatile devices are starting at 256 MB bondary. > > Signed-off-by: Jean-Christophe Dubois > --- > hw/arm/versatilepb.c | 8 > 1 file

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-10-25 Thread Peter Lieven
Am 25.10.2016 um 14:09 schrieb Paolo Bonzini: On 25/10/2016 14:03, Peter Lieven wrote: Am 01.08.2016 um 11:22 schrieb Paolo Bonzini: On 28/07/2016 04:39, Eric Blake wrote: On 07/27/2016 01:25 AM, Fam Zheng wrote: On Thu, 07/21 13:34, Eric Blake wrote: +max_write_zeroes = max_write_zeroe

Re: [Qemu-devel] [PATCHv5 07/12] libqos: Implement mmio accessors in terms of mem{read, write}

2016-10-25 Thread David Gibson
On Tue, Oct 25, 2016 at 05:47:43PM +1100, Alexey Kardashevskiy wrote: > On 24/10/16 15:59, David Gibson wrote: > > In the libqos PCI code we now have accessors both for registers (byte > > significance preserving) and for streaming data (byte address order > > preserving). These exist in both the

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: correct reset value for baud rate registers

2016-10-25 Thread Peter Maydell
On 25 October 2016 at 07:49, P J P wrote: > From: Prasad J Pandit > > The Cadence UART device emulator stores 'baud rate generator' > and 'baud rate divider' values, used in computing speed, in two > registers. The device specification defines their range and > their reset value. Use their correc

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-10-25 Thread Paolo Bonzini
On 25/10/2016 14:12, Peter Lieven wrote: > Am 25.10.2016 um 14:09 schrieb Paolo Bonzini: >> >> On 25/10/2016 14:03, Peter Lieven wrote: >>> Am 01.08.2016 um 11:22 schrieb Paolo Bonzini: On 28/07/2016 04:39, Eric Blake wrote: > On 07/27/2016 01:25 AM, Fam Zheng wrote: >> On Thu, 07/21

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

2016-10-25 Thread Thomas Huth
On 24.10.2016 14:04, David Gibson wrote: > On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: >> On 24.10.2016 12:22, Bharata B Rao wrote: >>> >>> On Wed, Oct 19, 2016 at 7:46 AM, David Gibson >>> mailto:da...@gibson.dropbear.id.au>> wrote: >>> >>> On Tue, Oct 18, 2016 at 10:46:39PM +

[Qemu-devel] [PATCH] net: smc91c111: check packet number and data register index

2016-10-25 Thread P J P
From: Prasad J Pandit SMSC91C111 Ethernet interface emulator has registers to store 'packet number' and a 'pointer' to Tx/Rx FIFO buffer area. These two are used to derive an address to access into 'data' registers. If they are not set correctly, they could lead to OOB r/w access beyond packet 'd

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-25 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Oct 25, 2016 at 12:03:33PM +0200, Markus Armbruster wrote: >> Max Reitz writes: >> >> > On 21.10.2016 11:58, Markus Armbruster wrote: >> >> "Daniel P. Berrange" writes: >> >> >> >>> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: >> >>

Re: [Qemu-devel] [PATCHv5 04/12] libqos: Better handling of PCI legacy IO

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 15:59:53 +1100 David Gibson wrote: > The usual model for PCI IO with libqos is to use qpci_iomap() to map a > specific BAR for a PCI device, then perform IOs within that BAR using > qpci_io_{read,write}*(). > > However, certain devices also have legacy PCI IO. In this case,

Re: [Qemu-devel] [PATCHv5 05/12] tests: Adjust tco-test to use qpci_legacy_iomap()

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 15:59:54 +1100 David Gibson wrote: > Avoid tco-test making assumptions about the internal format of the address > tokens passed to PCI IO accessors, by using the new qpci_legacy_iomap() > function. > > Signed-off-by: David Gibson > Reviewed-by: Laurent Vivier > --- Reviewe

Re: [Qemu-devel] [PATCHv5 08/12] tests: Clean up IO handling in ide-test

2016-10-25 Thread Greg Kurz
On Mon, 24 Oct 2016 15:59:57 +1100 David Gibson wrote: > ide-test uses many explicit inb() / outb() operations for its IO, which > means it's not portable to non-x86 platforms. This cleans it up to use > the libqos PCI accessors instead. > > Signed-off-by: David Gibson > --- Reviewed-by: Greg

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-10-25 Thread Peter Lieven
Am 25.10.2016 um 14:19 schrieb Paolo Bonzini: On 25/10/2016 14:12, Peter Lieven wrote: Am 25.10.2016 um 14:09 schrieb Paolo Bonzini: On 25/10/2016 14:03, Peter Lieven wrote: Am 01.08.2016 um 11:22 schrieb Paolo Bonzini: On 28/07/2016 04:39, Eric Blake wrote: On 07/27/2016 01:25 AM, Fam Zhen

Re: [Qemu-devel] [PATCH v2 07/18] tcg/i386: Implement field extraction opcodes

2016-10-25 Thread Paolo Bonzini
On 18/10/2016 17:10, Richard Henderson wrote: > +case INDEX_op_extract_i32: > +/* On the off-chance that we can use the high-byte registers. > + Otherwise we emit the same ext16 + shift pattern that we > + would have gotten from the normal tcg-op.c expansion. */ >

Re: [Qemu-devel] [PATCH v2 00/18] tcg field extract primitives

2016-10-25 Thread Paolo Bonzini
On 24/10/2016 21:04, Richard Henderson wrote: > Pinging target maintainers. If I don't get responses by the end of the > week, I'll only push the generic tcg bits and the two targets that I > maintain. There's no documentation in tcg/README; apart from that looks good. Paolo > > r~ > > > O

[Qemu-devel] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

2016-10-25 Thread Vladimir Sementsov-Ogievskiy
ping For now there are some notes mostly about accessory patches. What about migration itself? Is it ok? Has it a chance of being merged one day? 16.08.2016 13:25, Vladimir Sementsov-Ogievskiy wrote: v2: some bugs fixed, iotests a bit changed and merged into one test. based on block-next (htt

[Qemu-devel] [PATCH v4 1/5] block/ssh: Add ssh_has_filename_options_conflict()

2016-10-25 Thread Ashijeet Acharya
We have 5 options plus ("server") option which is added in the next patch that conflict with specifying a SSH filename. We need to iterate over all the options to check whether its key has an "server." prefix. This iteration will help us adding the new option "server" easily. Signed-off-by: Ashij

[Qemu-devel] [PATCH v4 5/5] qapi: allow blockdev-add for ssh

2016-10-25 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to support blockdev-add for SSH network protocol driver. Use only 'struct InetSocketAddress' since SSH only supports connection over TCP. Signed-off-by: Ashijeet Acharya Reviewed-by: Kevin Wolf --- qapi/block-core.json | 26 +

[Qemu-devel] [PATCH v4 4/5] block/ssh: Use InetSocketAddress options

2016-10-25 Thread Ashijeet Acharya
Drop the use of legacy options in favour of the InetSocketAddress options. Signed-off-by: Ashijeet Acharya Reviewed-by: Max Reitz Reviewed-by: Kevin Wolf --- block/ssh.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index d814006..6e6966

[Qemu-devel] [PATCH v4 3/5] block/ssh: Add InetSocketAddress and accept it

2016-10-25 Thread Ashijeet Acharya
Add InetSocketAddress compatibility to SSH driver. Add a new option "server" to the SSH block driver which then accepts a InetSocketAddress. "host" and "port" are supported as legacy options and are mapped to their InetSocketAddress representation. Signed-off-by: Ashijeet Acharya --- block/ssh

[Qemu-devel] [PATCH v4 0/5] Allow blockdev-add for SSH

2016-10-25 Thread Ashijeet Acharya
Previously posted series patches: v3: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg03781.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg03403.html v1: http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02137.html This series adds blockdev-add support for SSH

[Qemu-devel] [PATCH v5 01/13] block/nbd: Drop trailing "." in error messages

2016-10-25 Thread Max Reitz
Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Max Reitz --- block/nbd.c | 4 ++-- tests/qemu-iotests/051.out| 4 ++-- tests/qemu-iotests/051.pc.out | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 6bc

[Qemu-devel] [PATCH v5 04/13] block/nbd: Use qdict_put()

2016-10-25 Thread Max Reitz
Instead of inlining this nice macro (i.e. resorting to qdict_put_obj(..., QOBJECT(...))), use it. Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Max Reitz --- block/nbd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/block/nbd.c b/block/nbd.c

[Qemu-devel] [PATCH v4 2/5] util/qemu-sockets: Make inet_connect_saddr() public

2016-10-25 Thread Ashijeet Acharya
Make inet_connect_saddr() in util/qemu-sockets.c public in order to be able to use it with InetSocketAddress sockets outside of util/qemu-sockets.c independently. Signed-off-by: Ashijeet Acharya Reviewed-by: Kevin Wolf --- include/qemu/sockets.h | 2 ++ util/qemu-sockets.c| 4 ++-- 2 files

[Qemu-devel] [PATCH v5 12/13] iotests: Add assert_json_filename_equal() method

2016-10-25 Thread Max Reitz
Since the order of keys in JSON filenames is not necessarily fixed, they should not be compared to fixed strings. This method takes a Python dict as a reference, parses a given JSON filename and compares both. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 20

[Qemu-devel] [PATCH v5 06/13] block/nbd: Accept SocketAddress

2016-10-25 Thread Max Reitz
Add a new option "server" to the NBD block driver which accepts a SocketAddress. "path", "host" and "port" are still supported as legacy options and are mapped to their corresponding SocketAddress representation. Signed-off-by: Max Reitz --- block/nbd.c | 175 +

[Qemu-devel] [PATCH v5 03/13] block/nbd: Default port in nbd_refresh_filename()

2016-10-25 Thread Max Reitz
Instead of not emitting the port in nbd_refresh_filename(), just set it to the default if the user did not specify it. This makes the logic a bit simpler. Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Max Reitz --- block/nbd.c | 19 ++- 1 file changed, 6 insert

  1   2   3   4   >