Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255

2016-10-24 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1477361273-1-1-git-send-email-li...@roeck-us.net Subject: [Qemu-devel] [PATCH] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255 === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH v3 07/13] xen: Move xenstore cleanup and mkdir functions

2016-10-24 Thread Emil Condrea
The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea Acked-by: Anthony PERARD --- hw/xen/xen_backend.c | 49 - hw/xen/xen_pvdev.c | 51 +++

[Qemu-devel] [PATCH v3 08/13] xen: Rename xen_be_printf to xen_pv_printf

2016-10-24 Thread Emil Condrea
Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea Acked-by: Anthony PERARD --- hw/block/xen_disk.c| 58 +++--- hw/char/xen_console.c | 8 +++ hw/display/xenfb.c

[Qemu-devel] [PATCH v3 05/13] xen: Move evtchn functions to xen_pvdev.c

2016-10-24 Thread Emil Condrea
The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 35 --- hw/xen/xen_pvdev.c | 35 +++ include/hw/xen/xen_b

[Qemu-devel] [PATCH v3 00/13] Refactor common part of xen backend and frontend

2016-10-24 Thread Emil Condrea
This patch series was splitted from QEMU:Xen stubdom vTPM for HVM virtual machine http://markmail.org/message/fkix7g3a5zdj7lvr It contains a reorganization of xen backend and frontend functions together with code style fixes. Common functions shared by backends and frontends are moved to xen_pvde

[Qemu-devel] [PATCH v3 06/13] xen: Prepare xendev qtail to be shared with frontends

2016-10-24 Thread Emil Condrea
* move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 51 +-- hw/xen/xen_pvdev.c | 57

[Qemu-devel] [PATCH v3 12/13] xen: Rename xen_be_find_xendev

2016-10-24 Thread Emil Condrea
Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea Acked-by: Anthony PERARD Reviewed-by: Quan Xu --- hw/display/xenfb.c | 4 ++-- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/h

[Qemu-devel] [PATCH v3 01/13] xen: Fix coding style errors

2016-10-24 Thread Emil Condrea
Fixes the following errors: * ERROR: line over 90 characters * ERROR: code indent should never use tabs * ERROR: space prohibited after that open square bracket '[' * ERROR: do not initialise statics to 0 or NULL * ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Emil Condrea --- hw/char/

Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options

2016-10-24 Thread Fam Zheng
On Sat, 10/22 02:11, Max Reitz wrote: > On 30.09.2016 14:09, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > hw/core/qdev-properties.c| 10 ++ > > include/hw/block/block.h | 1 + > > include/hw/qdev-properties.h | 3 +++ > > 3 files changed, 14 insertions(+) > > Why d

[Qemu-devel] [PATCH v3 04/13] xen: Move xenstore_update to xen_pvdev.c

2016-10-24 Thread Emil Condrea
* xenstore_update -> xen_pvdev.c Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 30 +++--- hw/xen/xen_pvdev.c | 23 +++ include/hw/xen/xen_backend.h | 3 +++ include/hw/xen/xen_pvdev.h | 1 + 4 files changed, 30 insertion

[Qemu-devel] [PATCH v3 09/13] xen: Rename xen_be_unbind_evtchn

2016-10-24 Thread Emil Condrea
Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea Acked-by: Anthony PERARD Reviewed-by: Quan Xu --- hw/block/xen_disk.c| 2 +- hw/char/xen_console.c | 2 +- hw/display/xenfb.c | 2 +- hw/ne

Re: [Qemu-devel] [PATCH 3/4] target-ppc: add vrldnmi and vrlwmi instructions

2016-10-24 Thread Nikunj A Dadhania
Richard Henderson writes: > We already have rol32 and rol64. > > Which I see are broken for shift == 0. I tried with different shift (including 0) in a test program, and the result is as expected: 0: ccddeeff static inline unsigned int rol32(unsigned int word, unsigned int shift) { return (

[Qemu-devel] [PATCH v3 10/13] xen: Rename xen_be_send_notify

2016-10-24 Thread Emil Condrea
Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea Acked-by: Anthony PERARD Reviewed-by: Quan Xu --- hw/block/xen_disk.c| 4 ++-- hw/char/xen_console.c | 4 ++-- hw/display/xenfb.c | 8 h

[Qemu-devel] [PATCH v3 11/13] xen: Rename xen_be_evtchn_event

2016-10-24 Thread Emil Condrea
Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea Acked-by: Anthony PERARD Reviewed-by: Quan Xu --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files

[Qemu-devel] [PATCH v3 13/13] xen: Rename xen_be_del_xendev

2016-10-24 Thread Emil Condrea
Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea Acked-by: Anthony PERARD Reviewed-by: Quan Xu --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files change

[Qemu-devel] [PATCH v1 0/3] POWER9 TCG enablements - part7

2016-10-24 Thread Nikunj A Dadhania
This series contains 8 new instructions for POWER9 ISA3.0 VSX Scalar compare Vector Rotate Left Dword Vector Rotate Left Word Changelog: v0: * Use extract32 and extract64 helper * Use rol32 and rol64 helper Patches: 01: xscmpeqdp: VSX Scalar Compare Equal Double-Precision xs

[Qemu-devel] [PATCH v1 1/3] target-ppc: add xscmp[eq, gt, ge, ne]dp instructions

2016-10-24 Thread Nikunj A Dadhania
From: Sandipan Das xscmpeqdp: VSX Scalar Compare Equal Double-Precision xscmpgedp: VSX Scalar Compare Greater Than or Equal Double-Precision xscmpgtdp: VSX Scalar Compare Greater Than Double-Precision xscmpnedp: VSX Scalar Compare Not Equal Double-Precision Signed-off-by: Sandipan Das Signed-of

[Qemu-devel] [PATCH v1 3/3] target-ppc: add vrldnm and vrlwnm instructions

2016-10-24 Thread Nikunj A Dadhania
From: Bharata B Rao vrldnm: Vector Rotate Left Doubleword then AND with Mask vrlwnm: Vector Rotate Left Word then AND with Mask Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- disas/ppc.c | 2 ++ target-ppc/helper.h | 2 ++ target-pp

[Qemu-devel] [PATCH v1 2/3] target-ppc: add vrldnmi and vrlwmi instructions

2016-10-24 Thread Nikunj A Dadhania
From: "Gautham R. Shenoy" vrldmi: Vector Rotate Left Dword then Mask Insert vrlwmi: Vector Rotate Left Word then Mask Insert Signed-off-by: Gautham R. Shenoy Signed-off-by: Bharata B Rao ( use extract[32,64] and rol[32,64] ) Signed-off-by: Nikunj A Dadhania --- disas/ppc.c

Re: [Qemu-devel] [PATCH v5 07/17] ppc/pnv: add XSCOM infrastructure

2016-10-24 Thread Cédric Le Goater
On 10/25/2016 03:13 AM, David Gibson wrote: > On Sat, Oct 22, 2016 at 11:46:40AM +0200, Cédric Le Goater wrote: >> On a real POWER8 system, the Pervasive Interconnect Bus (PIB) serves >> as a backbone to connect different units of the system. The host >> firmware connects to the PIB through a bridg

Re: [Qemu-devel] [PATCH v8 05/36] raw-posix: Add image locking support

2016-10-24 Thread Fam Zheng
On Sat, 10/22 01:40, Max Reitz wrote: > On 30.09.2016 14:09, Fam Zheng wrote: > > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > the intervene. > > s/the intervene/a conflict/? OK. > > > > > Both file and host device protocols are covered. > > > > The complication is w

Re: [Qemu-devel] [RESEND PATCH v3 kernel 4/7] virtio-balloon: speed up inflate/deflate process

2016-10-24 Thread Michael S. Tsirkin
On Fri, Oct 21, 2016 at 02:24:37PM +0800, Liang Li wrote: > The implementation of the current virtio-balloon is not very > efficient, the time spends on different stages of inflating > the balloon to 7GB of a 8GB idle guest: > > a. allocating pages (6.5%) > b. sending PFNs to host (68.3%) > c. add

Re: [Qemu-devel] [PATCH] hostmem-file: add a property 'notrunc' to avoid data corruption

2016-10-24 Thread Haozhong Zhang
On 10/24/16 11:10 -0200, Eduardo Habkost wrote: On Thu, Oct 20, 2016 at 03:55:22PM +0200, Kevin Wolf wrote: Am 20.10.2016 um 14:34 hat Igor Mammedov geschrieben: > > #ifdef __linux__ > > +static uint64_t get_file_size(const char *path, Error **errp) > Maybe QEMU laredy has an utility to do it t

Re: [Qemu-devel] [PATCHv5 07/12] libqos: Implement mmio accessors in terms of mem{read, write}

2016-10-24 Thread Alexey Kardashevskiy
On 24/10/16 15:59, David Gibson wrote: > In the libqos PCI code we now have accessors both for registers (byte > significance preserving) and for streaming data (byte address order > preserving). These exist in both the interface for qtest drivers and in > the machine specific backends. > > Howev

[Qemu-devel] [PATCH] char: cadence: correct reset value for baud rate registers

2016-10-24 Thread P J P
From: Prasad J Pandit The Cadence UART device emulator stores 'baud rate generator' and 'baud rate divider' values, used in computing speed, in two registers. The device specification defines their range and their reset value. Use their correct value when resetting the device in cadence_uart_rese

Re: [Qemu-devel] [PATCH v2] ppc: allow certain HV interrupts to be delivered to guests

2016-10-24 Thread Nicholas Piggin
On Mon, 24 Oct 2016 12:16:19 +1100 David Gibson wrote: > On Fri, Oct 21, 2016 at 03:35:43PM +1100, Nicholas Piggin wrote: > > On Fri, 21 Oct 2016 12:09:54 +1100 > > David Gibson wrote: > > > > > On Fri, Oct 21, 2016 at 12:40:58AM +1100, Nicholas Piggin wrote: > > > > On Thu, 20 Oct 2016 15:

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/10/2016 11:12, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 20/10/2016 10:37, Daniel P. Berrange wrote: You have a problem of context - if you have multiple monitors, how do you know which to send the error back to if you're not in the even

[Qemu-devel] [PATCH v1] vhost-pci-net: design vhost-pci-net for the transmission of network packets between VMs

2016-10-24 Thread Wei Wang
Here lists the issues that we discussed before, and solutions are provided below. 1. Interrupt support 1) vhost-pci-net According to the virtio spec, "The device MUST present at least one notification capability", which implies that a virtio device can have multiple notification capabilities. The

Re: [Qemu-devel] [PATCH v9 00/12] Add Mediated device support

2016-10-24 Thread Jike Song
On 10/18/2016 05:22 AM, Kirti Wankhede wrote: > This series adds Mediated device support to Linux host kernel. Purpose > of this series is to provide a common interface for mediated device > management that can be used by different devices. This series introduces > Mdev core module that creates and

[Qemu-devel] [PATCH v1] docs/vhost-user: extend the vhost-user protocol to support the vhost-pci based inter-vm communication

2016-10-24 Thread Wei Wang
Signed-off-by: Wei Wang --- docs/specs/vhost-user.txt | 81 +-- 1 file changed, 72 insertions(+), 9 deletions(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 7890d71..173f693 100644 --- a/docs/specs/vhost-user.txt +++ b/docs

Re: [Qemu-devel] QOM properties vs C functions/fields (was Re: [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn())

2016-10-24 Thread Markus Armbruster
Peter Maydell writes: > On 21 October 2016 at 19:26, Markus Armbruster wrote: >> "Device not pluggable" does not imply "device has no configuration knobs >> a user may legitimately want to mess with". Plenty of onboard devices >> have such knobs. >> >> Right now, users configure these mostly vi

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: check divider against baud rate

2016-10-24 Thread Alistair Francis
On Fri, Oct 21, 2016 at 9:47 AM, P J P wrote: > +-- On Thu, 20 Oct 2016, Edgar E. Iglesias wrote --+ > | The UART is described in the Zynq TRMs, I think you can just > | google for zynq TRM and a reference to UG585 and UG1085 will come up. > > Unlikely for a novice to think 'zynq TRM' as search

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-10-24 Thread Aviv B.D.
On Fri, Oct 21, 2016 at 6:57 AM, Peter Xu wrote: > On Thu, Oct 20, 2016 at 10:11:15PM +0300, Aviv B.D. wrote: > > [...] > > > > > +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, > > > > + uint16_t domain_id, > hwaddr > > > addr, > > > >

Re: [Qemu-devel] [PATCH v9 10/11] vfio: Add waiting for host aer error progress

2016-10-24 Thread Cao jin
Hi On 07/19/2016 03:38 PM, Zhou Jie wrote: From: Chen Fan For supporting aer recovery, host and guest would run the same aer recovery code, that would do the secondary bus reset if the error is fatal, the aer recovery process: 1. error_detected 2. reset_link (if fatal) 3. slot_reset/m

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-10-24 Thread Peter Xu
On Mon, Oct 24, 2016 at 10:53:01AM +0300, Aviv B.D. wrote: [...] > This was my first algorithm, but VFIO do not support remapping of mapped > page. > Before each MAP operation in VFIO one must do unmap, and therefore I'm > sending > the unmap notifications blindly before. > I can rearrange my cod

Re: [Qemu-devel] [PATCH V7 0/2] Add option to configure guest vPMU

2016-10-24 Thread Andrew Jones
On Fri, Oct 21, 2016 at 05:53:00PM -0400, Wei Huang wrote: > This patchset adds a pmu=[on/off] option to enable/disable vPMU support > for guest VM. There are several reasons to justify this option. First, > vPMU can be problematic for cross-migration between different SoC as perf > counters are a

Re: [Qemu-devel] [PATCH 09/13] virtio: remove set_handler argument from set_host_notifier_internal

2016-10-24 Thread Cornelia Huck
On Fri, 21 Oct 2016 22:48:12 +0200 Paolo Bonzini wrote: > Make virtio_device_start_ioeventfd_impl use the same logic as > dataplane to set up the host notifier. This removes the need > for the set_handler argument in set_host_notifier_internal. > > This is a first step towards using virtio_bus_

[Qemu-devel] Fwd: facing issue with qemu amd-v support

2016-10-24 Thread Anand J
-- Forwarded message -- From: Anand J Date: Mon, Oct 24, 2016 at 4:28 AM Subject: facing issue with qemu amd-v support To: qemu-disc...@nongnu.org Hi, I'm running fedora-24_x86_64 inside qemu in software mode. I configured KVM in the guest OS and want to run qemu inside the gues

Re: [Qemu-devel] [PATCH v4 0/2] Script changes to find duplicate #include entries

2016-10-24 Thread Anand J
ping On Fri, Oct 21, 2016 at 12:27 PM, Anand J wrote: > There were some files in the code base with multiple inclusion of the same > header files. > Following changes are made to mitigate this issue. > > 1) --check-dup-head option is added to the scripts/clean-includes to > search files and >

Re: [Qemu-devel] [PATCH V7 2/2] arm: virt: add PMU property to mach-virt machine type

2016-10-24 Thread Andrew Jones
On Fri, Oct 21, 2016 at 05:53:02PM -0400, Wei Huang wrote: > CPU vPMU is now turned ON by default, but this feature wasn't introduced > until virt-2.7 machine type. To solve this problem, this patch adds a > PMU option in machine state, which is used to control CPU's vPMU status. > This PMU option

[Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part7

2016-10-24 Thread Nikunj A Dadhania
This series contains 12 new instructions for POWER9 ISA3.0 VSX Scalar compare Vector Multiply-by-10 Vector Rotate Left Dword Vector Rotate Left Word Patches: 01: xscmpeqdp: VSX Scalar Compare Equal Double-Precision xscmpgedp: VSX Scalar Compare Greater Than or Equal Doubl

[Qemu-devel] [PATCH 1/4] target-ppc: add xscmp[eq, gt, ge, ne]dp instructions

2016-10-24 Thread Nikunj A Dadhania
From: Sandipan Das xscmpeqdp: VSX Scalar Compare Equal Double-Precision xscmpgedp: VSX Scalar Compare Greater Than or Equal Double-Precision xscmpgtdp: VSX Scalar Compare Greater Than Double-Precision xscmpnedp: VSX Scalar Compare Not Equal Double-Precision Signed-off-by: Sandipan Das Signed-of

[Qemu-devel] [PATCH 3/4] target-ppc: add vrldnmi and vrlwmi instructions

2016-10-24 Thread Nikunj A Dadhania
From: "Gautham R. Shenoy" vrldmi: Vector Rotate Left Dword then Mask Insert vrlwmi: Vector Rotate Left Word then Mask Insert Signed-off-by: Gautham R. Shenoy Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- disas/ppc.c | 2 + target-ppc/helper.h

[Qemu-devel] [PATCH 4/4] target-ppc: add vrldnm and vrlwnm instructions

2016-10-24 Thread Nikunj A Dadhania
From: Bharata B Rao vrldnm: Vector Rotate Left Doubleword then AND with Mask vrlwnm: Vector Rotate Left Word then AND with Mask Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- disas/ppc.c | 2 ++ target-ppc/helper.h | 2 ++ target-pp

[Qemu-devel] [PATCH 2/4] target-ppc: add vmul10[u, eu, cu, ecu]q instructions

2016-10-24 Thread Nikunj A Dadhania
From: Vasant Hegde vmul10uq : Vector Multiply-by-10 Unsigned Quadword VX-form vmul10euq : Vector Multiply-by-10 Extended Unsigned Quadword VX-form vmul10cuq : Vector Multiply-by-10 & write Carry Unsigned Quadword VX-form vmul10ecuq: Vector Multiply-by-10 Extended & write Carry Unsigned Quadword

[Qemu-devel] [PATCH 0/2] Improve truncation behavior of memory-backend-file

2016-10-24 Thread Haozhong Zhang
The previous discussion thread can be found at http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg04668.html For a mmeory backend file, e.g. -object memory-backend-file,mem-path=foo,size=SZ,... the size of the backend file 'foo' is specified by the 'size' option. If the specified size

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-24 Thread Markus Armbruster
Max Reitz writes: > On 21.10.2016 11:58, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >>> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: "Daniel P. Berrange" writes: > The qdict_flatten() method will take a dict whose elements are > further

[Qemu-devel] [PATCH 2/2] hostmem-file: allow option 'size' optional

2016-10-24 Thread Haozhong Zhang
If 'size' option of hostmem-file is not given, QEMU will use the file size of 'mem-path' instead. For an empty file, a non-zero size must be specified by the option 'size'. Signed-off-by: Haozhong Zhang --- backends/hostmem-file.c | 10 ++ exec.c | 8 2 files c

[Qemu-devel] [PATCH 1/2] exec.c: do not truncate non-empty memory backend file

2016-10-24 Thread Haozhong Zhang
For '-object memory-backend-file,mem-path=foo,size=xyz', if the size of file 'foo' does not match the given size 'xyz', the current QEMU will truncate the file to the given size, which may corrupt the existing data in that file. To avoid such data corruption, this patch disables truncating non-empt

Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-24 Thread Igor Mammedov
On Mon, 24 Oct 2016 12:53:10 +1100 Alexey Kardashevskiy wrote: > On 19/10/16 23:23, Igor Mammedov wrote: > > On Wed, 19 Oct 2016 10:39:12 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 18/10/16 22:00, Igor Mammedov wrote: > >>> On Tue, 11 Oct 2016 09:19:10 +1100 > >>> Alexey Kardashevski

[Qemu-devel] [Bug 1636126] [NEW] qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Roman
Public bug reported: I'll attach a binary that runs fine with qemu-system-arm V2.2.0 but V2.7.0 segfaults. By stepping through with gdb I found that the segfaults happens when executing the line "smulbb r7, r5, r5" (where r7=0x1, r5=0x12). I'll also attach a debugger screenshot. call and output

Re: [Qemu-devel] [PATCH] net: rtl8139: limit processing of ring descriptors

2016-10-24 Thread P J P
Hello Jason, +-- On Mon, 24 Oct 2016, Jason Wang wrote --+ | > RTL8139 ethernet controller in C+ mode supports multiple | > descriptor rings, each with maximum of 64 descriptors. While | > processing transmit descriptor ring in 'rtl8139_cplus_transmit', | > it does not limit the descriptor count

[Qemu-devel] [Bug 1636126] Re: qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Roman
in the screenshot one can see the assembler line that fails ** Attachment added: "Debugger screenshot" https://bugs.launchpad.net/qemu/+bug/1636126/+attachment/4766312/+files/Screenshot_Debugger.png -- You received this bug notification because you are a member of qemu- devel-ml, which is su

[Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor

2016-10-24 Thread Paolo Bonzini
Leave the implementation of error_printf, error_printf_unless_qmp and error_vprintf to libqemustub.a and monitor.c, so that we can remove the monitor_printf and monitor_vprintf stubs. Signed-off-by: Paolo Bonzini --- This should help shutting up the vmstate unit tests. monitor.c

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-24 Thread Paolo Bonzini
On 24/10/2016 03:44, Changlong Xie wrote: > Ping. Any comments? It's really a problem for NBD. Sorry, I haven't been sending pull requests. I'll do it this week. Paolo > Thanks > -Xie > > On 10/12/2016 06:18 PM, Changlong Xie wrote: >> NBD is using the CoMutex in a way that wasn't antici

Re: [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-24 Thread Dr. David Alan Gilbert
* vijay.kil...@gmail.com (vijay.kil...@gmail.com) wrote: > From: Vijaya Kumar K > > Add helper API to read MIDR_EL1 registers to fetch > cpu identification information. This helps in > adding errata's and architecture specific features. > > This is implemented only for arm architecture. > > Sig

Re: [Qemu-devel] [PATCH] acpi: fix assert failure caused by commit 35c5a52d

2016-10-24 Thread Xiao Guangrong
On 10/19/2016 05:19 PM, Haozhong Zhang wrote: Commit 35c5a52d "acpi: do not use TARGET_PAGE_SIZE" changed struct NvdimmDsmIn from a variable-size structure to a fixed-size structure of 4096 bytes. It forgot to adjust an assert in nvdimm_dsm_set_label_data(..., NvdimmDsmIn *in, ...): assert(

[Qemu-devel] [Bug 1469978] Re: compile qemu use with KVM machine not supported

2016-10-24 Thread Thomas Huth
What kind of Linux distribution are you using? Sound like you're using libvirt on top of QEMU ... how does your guest XML definition in libvirt look like? You might need to specify a different machine type in your XML there... ** Changed in: qemu Status: New => Incomplete -- You received

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2016-10-24 Thread Thomas Huth
** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463812 Title: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption Status in QEMU: New Bug description: copied the RHEL5.9 p

[Qemu-devel] [Bug 1469924] Re: qemu-kvm crash when guest os is booting

2016-10-24 Thread Thomas Huth
Which version of QEMU are you using? Does the problem still occur with the latest version of QEMU? What kind of guest and host OS are you using? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [Qemu-devel] [PATCHv4 11/11] libqos: Change PCI accessors to take opaque BAR handle

2016-10-24 Thread Greg Kurz
On Mon, 24 Oct 2016 14:19:47 +1100 David Gibson wrote: > On Fri, Oct 21, 2016 at 03:23:51PM +0200, Greg Kurz wrote: > > On Fri, 21 Oct 2016 12:19:52 +1100 > > David Gibson wrote: > > > > > The usual use model for the libqos PCI functions is to map a specific PCI > > > BAR using qpci_iomap() t

Re: [Qemu-devel] [PULL 0/3] tags/xen-20161021-tag

2016-10-24 Thread Peter Maydell
On 21 October 2016 at 21:06, Stefano Stabellini wrote: > The following changes since commit b49e452fe994f8fbcd22bf5a87b79a2355481318: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160921' > into staging (2016-10-21 13:49:58 +0100) > > are available in the git repository

[Qemu-devel] [Bug 1289898] Re: qemu-system-ppc64 easily cause file corruption

2016-10-24 Thread Thomas Huth
Is this the same issue as bug https://bugs.launchpad.net/qemu/+bug/1463812 ? If so, I think we should close one of the two tickets - no need to track an issue twice. ** Tags added: ppc -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1636126] Re: qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Peter Maydell
Hi. This command line: /opt/qemu-system-arm -M integratorcp -cpu cortex-m3 ... is wrong. The integratorcp board is not a Cortex-M3 and trying to stick one into it produces something that is not likely to work very well. Please can you either (a) using a board that's expected to support a Cortex-M

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-24 Thread Kevin Wolf
Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > I personally still don't like making locking a qdev property very much > because it doesn't make sense to me*. But I remember Kevin had his > reasons (even though I can no longer remember them) for asking for it, > and I don't have any besid

[Qemu-devel] REMINDER: new freeze rules

2016-10-24 Thread Peter Maydell
Just a reminder that (1) softfreeze is on the 1st November (next Tuesday!) and (2) we are trying a new set of rules for how freeze works: * by the softfreeze date all patches for feature work must be in maintainer trees -- if your patch is on the mailing list but hasn't been merged then it

Re: [Qemu-devel] [PATCHv4 11/11] libqos: Change PCI accessors to take opaque BAR handle

2016-10-24 Thread Greg Kurz
On Mon, 24 Oct 2016 15:31:12 +1100 David Gibson wrote: > On Mon, Oct 24, 2016 at 02:19:47PM +1100, David Gibson wrote: > > On Fri, Oct 21, 2016 at 03:23:51PM +0200, Greg Kurz wrote: > > > On Fri, 21 Oct 2016 12:19:52 +1100 > > > David Gibson wrote: > > > > > > > The usual use model for the

Re: [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-24 Thread Vijay Kilari
On Mon, Oct 24, 2016 at 3:09 PM, Dr. David Alan Gilbert wrote: > * vijay.kil...@gmail.com (vijay.kil...@gmail.com) wrote: >> From: Vijaya Kumar K >> >> Add helper API to read MIDR_EL1 registers to fetch >> cpu identification information. This helps in >> adding errata's and architecture specific

Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

2016-10-24 Thread Bharata B Rao
On Wed, Oct 19, 2016 at 7:46 AM, David Gibson wrote: > On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > > The OpenBIOS NVRAM set-up is based on the layout defined in the CHRP > > (Common Hardware Reference Platform) specification. This is the same > > layout that is also used by the

[Qemu-devel] [Bug 1455254] Re: Segmentation fault. __memcmp_sse4_1 () at ../sysdeps/x86_64/multiarch/memcmp-sse4.S:69

2016-10-24 Thread Thomas Huth
I assume this is the same bug as https://bugzilla.redhat.com/show_bug.cgi?id=1163047 - so this should have been fixed with this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=c6e484707f28b3e115e6412 ... thus I'm changing the status to "Fix released" now. If you still have this problem

Re: [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict

2016-10-24 Thread Daniel P. Berrange
On Mon, Oct 24, 2016 at 11:18:29AM +0200, Markus Armbruster wrote: > Max Reitz writes: > > > On 21.10.2016 11:58, Markus Armbruster wrote: > >> "Daniel P. Berrange" writes: > >> > >>> On Tue, Oct 18, 2016 at 04:32:13PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: >

Re: [Qemu-devel] [PATCH 12/22] qcow2-bitmap: add IN_USE flag

2016-10-24 Thread Vladimir Sementsov-Ogievskiy
21.10.2016 22:58, Max Reitz пишет: On 21.10.2016 17:34, Vladimir Sementsov-Ogievskiy wrote: 07.10.2016 22:44, Max Reitz пишет: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: This flag means that the bitmap is now in use by the software or was not successfully saved. In any way, with

Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor

2016-10-24 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Leave the implementation of error_printf, error_printf_unless_qmp > and error_vprintf to libqemustub.a and monitor.c, so that we can > remove the monitor_printf and monitor_vprintf stubs. > > Signed-off-by: Paolo Bonzini > --- > This should h

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-24 Thread Kirti Wankhede
On 10/21/2016 8:06 PM, Alex Williamson wrote: > On Fri, 21 Oct 2016 15:49:07 +0800 > Jike Song wrote: > >> On 10/18/2016 05:22 AM, Kirti Wankhede wrote: >>> diff --git a/drivers/vfio/vfio_iommu_type1.c >>> b/drivers/vfio/vfio_iommu_type1.c >>> index 2ba19424e4a1..5d67058a611d 100644 >>> --- a/

Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

2016-10-24 Thread Thomas Huth
On 24.10.2016 12:22, Bharata B Rao wrote: > > On Wed, Oct 19, 2016 at 7:46 AM, David Gibson > mailto:da...@gibson.dropbear.id.au>> wrote: > > On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > > The OpenBIOS NVRAM set-up is based on the layout defined in the CHRP > > (Comm

[Qemu-devel] [Bug 1453436] Re: Building on OS X: Undefined symbols ___emutls_v.prng_state and ___emutls_v.prng_state_data

2016-10-24 Thread Thomas Huth
According to comment #4, the build finally worked, so I'm closing this ticket now. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1453436 Title:

Re: [Qemu-devel] [PULL 00/35] cmpxchg atomic operations

2016-10-24 Thread Peter Maydell
On 22 October 2016 at 22:04, Richard Henderson wrote: > This is v7, with the additional fix for gcc 4.2, as on Centos 6. > > > r~ > > > The following changes since commit da158a86c407fa7b9da848b571356a26809d8df9: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-qcrypto-2016-10-20-

Re: [Qemu-devel] [PATCH v11 01/19] block: Add bdrv_drain_all_{begin, end}()

2016-10-24 Thread Paolo Bonzini
On 19/10/2016 19:11, Kevin Wolf wrote: > Am 14.10.2016 um 15:08 hat Alberto Garcia geschrieben: >> bdrv_drain_all() doesn't allow the caller to do anything after all >> pending requests have been completed but before block jobs are >> resumed. >> >> This patch splits bdrv_drain_all() into _begin(

[Qemu-devel] [Bug 1636126] Re: qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Roman
Hi Peter! Thank you for your help, it works fine with "-M integratprcp -cpu cortex-m4" but I might choose another board as you suggested. I didn't have in mind that we switched to M4 instruction set. Where do I get the information that integratorcp is not good for cortex-M3? Or better question:

Re: [Qemu-devel] [RFC PATCH] memory: Don't use memcpy for ram marked as skip_dump

2016-10-24 Thread Paolo Bonzini
On 22/10/2016 17:09, Alex Williamson wrote: > > Add a trace message for each mrop. > > Yes, this is on my todo list post-RFC. Another thing to think about: 1) rename all the skip_dump occurrences in the API to device_memory. The new ops make it much more specific than just skipping the region

[Qemu-devel] [Bug 1636126] Re: qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Peter Maydell
You're right that we don't document this at all (and the board models don't have any way of restricting the set of things that '-cpu help' lists to only what they support). As a rule of thumb, for any ARM board except 'virt' don't try to use anything except the default CPU. They all model embedded

Re: [Qemu-devel] [RFC PATCH 1/4] tests/test-vmstate.c: add save_buffer util func

2016-10-24 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Let us de-duplicate some code by introducing an utility function for > saving a chunk of bytes (used when testing load based on wire). > > Signed-off-by: Halil Pasic > Reviewed-by: Guenther Hutzl Reviewed-by: Dr. David Alan Gilbert > --- > te

Re: [Qemu-devel] [PATCH v3 3/3] utils: Add prefetch for Thunderx platform

2016-10-24 Thread Paolo Bonzini
On 24/10/2016 07:55, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Thunderx pass2 chip requires explicit prefetch > instruction to give prefetch hint. > > To speed up live migration on Thunderx platform, > prefetch instruction is added in zero buffer check > function.The below resul

Re: [Qemu-devel] [PATCH v3 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-24 Thread Paolo Bonzini
On 24/10/2016 11:39, Dr. David Alan Gilbert wrote: > * vijay.kil...@gmail.com (vijay.kil...@gmail.com) wrote: >> From: Vijaya Kumar K >> >> Add helper API to read MIDR_EL1 registers to fetch >> cpu identification information. This helps in >> adding errata's and architecture specific features. >

Re: [Qemu-devel] [PATCH 12/22] qcow2-bitmap: add IN_USE flag

2016-10-24 Thread Vladimir Sementsov-Ogievskiy
24.10.2016 13:32, Vladimir Sementsov-Ogievskiy пишет: 21.10.2016 22:58, Max Reitz пишет: On 21.10.2016 17:34, Vladimir Sementsov-Ogievskiy wrote: 07.10.2016 22:44, Max Reitz пишет: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: This flag means that the bitmap is now in use by the sof

Re: [Qemu-devel] [PATCH v2] target-i386: Print warning when mixing [+-]foo and foo=(on|off)

2016-10-24 Thread Igor Mammedov
On Fri, 21 Oct 2016 17:41:13 -0200 Eduardo Habkost wrote: > Print a warning when mixing [+-]foo and foo=(on|off) in the -cpu > argument in a way that will break in the future. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Coding style fixes > * Print "compatibility won't be k

[Qemu-devel] [PATCH v5 1/4] block: improve error handling in raw_open

2016-10-24 Thread Kevin Wolf
From: Halil Pasic Make raw_open for POSIX more consistent in handling errors by setting the error object also when qemu_open fails. The error object was set generally set in case of errors, but I guess this case was overlooked. Do the same for win32. Signed-off-by: Halil Pasic Reviewed-by: Sasc

[Qemu-devel] [PATCH v5 0/4] fdc: Use separate qdev device for drives

2016-10-24 Thread Kevin Wolf
We have been complaining for a long time about how the floppy controller and floppy drives are combined in a single qdev device and how this makes the device awkward to work with because it behaves different from all other block devices. The latest reason to complain was when I noticed that using

[Qemu-devel] [PATCH v5 3/4] throttle: Correct access to wrong BlockBackendPublic structures

2016-10-24 Thread Kevin Wolf
From: Alberto Garcia In 27ccdd52598290f0f8b58be56e235aff7aebfaf3 the throttling fields were moved from BlockDriverState to BlockBackend. However in a few cases the code started using throttling fields from the active BlockBackend instead of the round-robin token, making the algorithm behave incor

[Qemu-devel] [Bug 1636126] Re: qemu-system-arm segfaults on "smulbb r7, r5, r5"

2016-10-24 Thread Roman
Tried to run cortex-M4 command on M3. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1636126 Title: qemu-system-arm segfaults on "smulbb r7, r5, r5

[Qemu-devel] [PATCH v5 2/4] qapi: fix memory leak in bdrv_image_info_specific_dump

2016-10-24 Thread Kevin Wolf
From: Pino Toscano The 'obj' result of the visitor was not properly freed, like done in other places doing a similar job. Signed-off-by: Pino Toscano Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi.c b/block/qa

Re: [Qemu-devel] [PATCH] qapi: fix memory leak in QmpOutputVisitor

2016-10-24 Thread Pino Toscano
On Friday, 21 October 2016 16:20:30 CEST Eric Blake wrote: > On 10/18/2016 06:22 AM, Pino Toscano wrote: > > On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote: > >> On 10/18/2016 04:17 AM, Pino Toscano wrote: > >>> qmp_output_start_struct() and qmp_output_start_list() create a new > >>> QO

[Qemu-devel] [PATCH v5 4/4] qemu-iotests: Test I/O in a single drive from a throttling group

2016-10-24 Thread Kevin Wolf
From: Alberto Garcia iotest 093 contains a test that creates a throttling group with several drives and performs I/O in all of them. This patch adds a new test that creates a similar setup but only performs I/O in one of the drives at the same time. This is useful to test that the round robin al

Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-24 Thread Igor Mammedov
On Fri, 21 Oct 2016 16:28:01 +0800 Haozhong Zhang wrote: > Hi, > > Commit d2f39ad "exec.c: Ensure right alignment also for file backed > ram" added an additional alignment requirement besides to the previous > page size for the size of the backend file. On x86, the alignment > requirement for th

Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor

2016-10-24 Thread Paolo Bonzini
On 24/10/2016 12:34, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Leave the implementation of error_printf, error_printf_unless_qmp >> and error_vprintf to libqemustub.a and monitor.c, so that we can >> remove the monitor_printf and monitor_vprintf stubs. >> >>

Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too

2016-10-24 Thread David Gibson
On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: > On 24.10.2016 12:22, Bharata B Rao wrote: > > > > On Wed, Oct 19, 2016 at 7:46 AM, David Gibson > > mailto:da...@gibson.dropbear.id.au>> wrote: > > > > On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > > > The Ope

Re: [Qemu-devel] [PATCHv4 11/11] libqos: Change PCI accessors to take opaque BAR handle

2016-10-24 Thread David Gibson
On Mon, Oct 24, 2016 at 12:02:31PM +0200, Greg Kurz wrote: > On Mon, 24 Oct 2016 14:19:47 +1100 > David Gibson wrote: > > > On Fri, Oct 21, 2016 at 03:23:51PM +0200, Greg Kurz wrote: > > > On Fri, 21 Oct 2016 12:19:52 +1100 > > > David Gibson wrote: > > > > > > > The usual use model for the l

Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

2016-10-24 Thread Haozhong Zhang
On 10/24/16 13:44 +0200, Igor Mammedov wrote: On Fri, 21 Oct 2016 16:28:01 +0800 Haozhong Zhang wrote: Hi, Commit d2f39ad "exec.c: Ensure right alignment also for file backed ram" added an additional alignment requirement besides to the previous page size for the size of the backend file. On

Re: [Qemu-devel] [PATCH v17 00/14] PTimer fixes/features and ARM MPTimer conversion

2016-10-24 Thread Peter Maydell
On 2 October 2016 at 16:53, Dmitry Osipenko wrote: > Hello, > > Currently, QEMU ARM MPTimer device model provides only a certain subset of > the emulation behavior. This patch series is supposed to add missing parts by > converting the MPTimer to use generic ptimer helper. It fixes some important

Re: [Qemu-devel] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes

2016-10-24 Thread Peter Maydell
On 17 October 2016 at 15:07, Andrew Jones wrote: > On Mon, Oct 17, 2016 at 02:31:06PM +0200, Eric Auger wrote: >> From: Prem Mallappa >> >> This patch builds an IORT table that features a root complex node and >> an ITS node. This complements the ITS description in the ACPI MADT >> table and allo

  1   2   3   4   5   >