Le 17/10/2016 à 20:31, Peter Maydell a écrit :
On 5 October 2016 at 23:11, wrote:
From: KONRAD Frederic
This adds the qemu-clock documentation.
Signed-off-by: KONRAD Frederic
---
docs/clock.txt | 109 +
1 file changed, 109 insertio
On Mon, 17 Oct 2016 19:51:12 -0200
Eduardo Habkost wrote:
> On Thu, Oct 13, 2016 at 11:52:43AM +0200, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov
> > ---
> > v4:
> > - drop kvm_has_x2apic_api() and reuse kvm_enable_x2apic() instead
> > ---
> > hw/i386/kvm/apic.c | 12 ++--
> >
Le 17/10/2016 à 20:13, Peter Maydell a écrit :
On 5 October 2016 at 23:10, wrote:
From: KONRAD Frederic
This allows to attach a clock to a DeviceState.
Contrary to gpios, the clock pins are not contained in the DeviceState but
with the child property so they can appears in the qom-tree.
For automated testing purposes it can be helpful to exit qemu
(poweroff) when the guest panics. Make this the default unless
-no-shutdown is specified.
For internal-errors like errors from KVM_RUN the behaviour is
not changed, in other words QEMU does not exit to allow debugging
in the QEMU monito
From: Prasad J Pandit
In Cirrus CLGD 54xx VGA Emulator, if cirrus graphics mode is VGA,
'cirrus_get_bpp' returns zero(0), which could lead to a divide
by zero error in while copying pixel data. The same could occur
via blit pitch values. Add check to avoid it.
Reported-by: Huawei PSIRT
Signed-o
On Thu, Oct 13, 2016 at 12:10 AM, Anand J wrote:
> Added script to check duplicate #include entries. This check will scan and
> print the files in which duplicate #include entries are present.
>
> Script might output false postive entries as well. Such entries should
> not be removed. So if it fi
On Mon, Oct 17, 2016 at 04:24:24PM +0300, riku.voi...@linaro.org wrote:
> From: Aleksandar Markovic
>
> There are currently several problems related to syslog() support.
>
> For example, if the second argument "bufp" of target syslog() syscall
> is NULL, the current implementation always returns
Paolo Bonzini writes:
> On 17/10/2016 21:15, Dr. David Alan Gilbert wrote:
>> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>>> On 17 October 2016 at 19:51, Dr. David Alan Gilbert
>>> wrote:
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> I've just noticed that qemu master runn
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
>
>
> On 10/17/2016 12:16 PM, Dr. David Alan Gilbert wrote:
> > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
> >>
> >>
> >> On 10/17/2016 11:52 AM, Dr. David Alan Gilbert wrote:
> >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote:
>
> >>
On Tue, 18 Oct 2016 16:52:04 +1100
David Gibson wrote:
> On Mon, Oct 17, 2016 at 10:47:02PM -0600, Alex Williamson wrote:
> > On Tue, 18 Oct 2016 15:06:55 +1100
> > David Gibson wrote:
> >
> > > On Mon, Oct 17, 2016 at 10:07:36AM -0600, Alex Williamson wrote:
> > > > On Mon, 17 Oct 2016 18:
The routines :
void icp_set_cppr(ICPState *icp, uint8_t cppr);
void icp_set_mfrr(ICPState *icp, uint8_t mfrr);
void icp_eoi(ICPState *icp, uint32_t xirr);
now use one 'ICPState *icp' argument instead of a 'XICSState *' and a
server arguments. The backlink on XICSState* is
Hello,
Here are a couple of changes removing duplicated code and modifying
the remaining icp_ routines still using a 'XICSState *' as argument.
Thanks,
C.
Cédric Le Goater (3):
ppc/xics: add a xics_set_nr_servers common routine
ppc/xics: add a XICSState backlink in ICPState
ppc/xics: cha
The link will be used to change the API of the icp_* routines which
are still using an XICSState as an argument.
Signed-off-by: Cédric Le Goater
---
hw/intc/xics.c| 1 +
include/hw/ppc/xics.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index c05
xics_spapr and xics_kvm nearly define the same 'set_nr_servers'
handler. Only the type of the ICP differs. So let's make a common one
to remove some duplicated code.
Signed-off-by: Cédric Le Goater
---
hw/intc/xics.c| 24 +---
hw/intc/xics_kvm.c| 13 +
On 12.10.2016 20:40, Anand J wrote:
> Added script to check duplicate #include entries. This check will scan and
> print the files in which duplicate #include entries are present.
>
> Script might output false postive entries as well. Such entries should
> not be removed. So if it finds any duplic
On 17 October 2016 at 19:40, Peter Maydell wrote:
> Random mix of stuff here, nothing in particular
> very large. Includes a fix for the regression running
> Thumb userspace code.
>
> thanks
> -- PMM
>
>
> The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197:
>
> Merge rem
Thanks for reporting the issue, patch has now been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=04bb79d1f519ae190a
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEM
From: Marcin Krzeminski
According to ARM DUI 0552A 4.2.10. NVIC set pending status
also for disabled interrupts. This patch adds possibility
to emulate this in Qemu.
Signed-off-by: Marcin Krzeminski
---
Changes for v2:
- add a dedicated unction for nvic
- update complete_irq
hw/intc/ar
To be able to include your patch, you've got to send it to the qemu-
devel mailing list, with a proper Signed-off-by line. Please see http
://qemu-project.org/Contribute/SubmitAPatch#Submitting_your_Patches for
details.
--
You received this bug notification because you are a member of qemu-
devel
Right, this problem should be fixed with Spice, so I'm closing this
ticket now.
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/498039
Titl
OK, according to the last comments, the bug has been fixed somewhere
with the last kernel or QEMU releases, so I'm closing this ticket now.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is sub
On Mon, 17 Oct 2016 19:44:52 -0200
Eduardo Habkost wrote:
> On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote:
> [...]
> > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,
> > MachineState *machine,
> > /* The current AML generator can cover the APIC ID range [0.
* Radim Krčmář (rkrc...@redhat.com) wrote:
> 2016-10-17 07:47-0200, Marcelo Tosatti:
> > On Fri, Oct 14, 2016 at 06:20:31PM -0300, Eduardo Habkost wrote:
> >> I have been wondering: should we allow live migration with the
> >> invtsc flag enabled, if TSC scaling is available on the
> >> destination
On Mon, 17 Oct 2016 19:44:52 -0200
Eduardo Habkost wrote:
> On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote:
> [...]
> > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,
> > MachineState *machine,
> > /* The current AML generator can cover the APIC ID range [0.
qmp_output_start_struct() and qmp_output_start_list() create a new
QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
where it is saved as 'value'. When freeing the iterator in
qmp_output_free(), these values are never freed properly.
The simple solution is to qobject_decref
The 'obj' result of the visitor was not properly freed, like done in
other places doing a similar job.
---
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 6f947e3..50d3090 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -698,6 +698,7 @@ void bdrv_
Hi
vhost-user & virtio have tricky corners and evolve regularly. There
isn't a reference code that would help you get started either. And the
backends duplicate most of the effort.
Furthermore, due to usage of ancillary data, shared memory, eventfd,
atomics, it is not so simple to implement in ot
hi, all:
i apply this patch,
https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33
.
but this patch always results in a bug(bug?). a vm always exits wi
hi, jasowang:
according to my test , the vm's network performance is just 20% of
physical ethernet, the thread of vhost easily eat up 100% cpu when under
pressure.
when using multi queue(two queues) the performance goes up by 50%, but it uses
more threads.
if we can come to a conclusion th
Hi
vhost-user & virtio have tricky corners and evolve regularly. There
isn't a reference code that would help you get started either. And the
backends duplicate most of the effort.
Furthermore, due to usage of ancillary data, shared memory, eventfd,
atomics, it is not so simple to implement in ot
Add a library to help implementing vhost-user backend (or slave).
Dealing with vhost-user as an application developper isn't so easy: you
have all the trouble with any protocol: validation, unix ancillary data,
shared memory, eventfd, logging, and on top of that you need to deal
with virtio queues
dispatcher_remove() is in use.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-bridge.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 775e031..e91279b 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-bridge.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 19b0e94..97e45d8 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -385,7 +385,6 @@ vubr_message_re
The call fd is not watched
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-bridge.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index e91279b..19b0e94 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -9
Use the libvhost-user library.
This ended up being a rather large patch that cannot be easily splitted,
due to massive code move and API changes.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-bridge.c | 1177 +
tests/Makefile.include|2
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-bridge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 97e45d8..5b618f6 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -1200,6 +1200,7 @@ vubr_accept_
Am 17.10.2016 um 16:50 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben:
> >> Cc: Kevin for discussion of QemuOpts dotted key convention
> >>
> >> "Daniel P. Berrange" writes:
> >>
> >> > Currently qdict_crumple requires a t
On 17 October 2016 at 18:51, Eduardo Habkost wrote:
> The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197:
>
> Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
> (2016-10-17 16:17:51 +0100)
>
> are available in the git repository at:
>
> git:
Am 17.10.2016 um 19:07 hat Max Reitz geschrieben:
> On 28.09.2016 22:46, Max Reitz wrote:
> > 162 is potentially racy and makes some invalid assumptions about what
> > should happen when connecting to a non-existing domain name. This series
> > fixes both issues.
> >
> >
> > v4:
> > - Added docum
On Tue, Oct 18, 2016 at 10:24 AM, yue wrote:
> i apply this patch,
> https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33
> .
> but this patch always r
Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index 6f947e3..50d3090 100644
From: Prasad J Pandit
The Cadence UART device emulator calculates speed by dividing the
baud rate by a divider. If this divider was to be zero or if baud
rate was to be lesser than the divider, it could lead to a divide
by zero error. Add check to avoid it.
Reported-by: Huawei PSIRT
Signed-off-
On 18 October 2016 at 10:47, P J P wrote:
> From: Prasad J Pandit
>
> The Cadence UART device emulator calculates speed by dividing the
> baud rate by a divider. If this divider was to be zero or if baud
> rate was to be lesser than the divider, it could lead to a divide
> by zero error. Add chec
* Markus Armbruster (arm...@redhat.com) wrote:
> Paolo Bonzini writes:
>
> > On 17/10/2016 21:15, Dr. David Alan Gilbert wrote:
> >> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> >>> On 17 October 2016 at 19:51, Dr. David Alan Gilbert
> >>> wrote:
> * Peter Maydell (peter.mayd...@lin
On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote:
> Hi,
> I had a look at a couple of readline like libraries;
> editline and linenoise. A difficulty with using them is that
> they both want fd's or FILE*'s; editline takes either but
> from a brief look I think it's expecti
On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote:
> Hi,
> I had a look at a couple of readline like libraries;
> editline and linenoise. A difficulty with using them is that
> they both want fd's or FILE*'s; editline takes either but
> from a brief look I think it's expecti
On Mon, Oct 17, 2016 at 06:29:42AM +, Gonglei (Arei) wrote:
>
> > -Original Message-
> > From: Stefan Hajnoczi [mailto:stefa...@gmail.com]
> > Sent: Sunday, October 16, 2016 9:23 PM
> > Subject: Re: [Qemu-devel] [PATCH v7 09/12] virtio-crypto: add data queue
> > processing handler
> >
On Mon, Oct 17, 2016 at 10:04:59AM +0200, Paolo Bonzini wrote:
>
>
> On 16/10/2016 18:40, Stefan Hajnoczi wrote:
> > > void bdrv_wakeup(BlockDriverState *bs)
> > > {
> > > +if (bs->wakeup) {
> > > +aio_bh_schedule_oneshot(qemu_get_aio_context(), dummy_bh_cb,
> > > NULL);
> > > +
On Mon, Oct 17, 2016 at 09:25:46AM -0500, Eric Blake wrote:
> On 10/16/2016 08:35 AM, Stefan Hajnoczi wrote:
>
> >>> +
> >>> +if (sscanf(str, "%32[^:]:%32[^,]%n", cid, port, &n) != 2) {
> >>
> >> This says stop at the first comma after the colon...
> >>
> >>> +error_setg(errp, "error p
This adds a qbus to the floppy controller that should contain the floppy
drives eventually. At the moment it just exists and is empty.
Signed-off-by: Kevin Wolf
Reviewed-by: John Snow
---
hw/block/fdc.c | 40 +++-
1 file changed, 35 insertions(+), 5 deletions
Floppy controllers automatically create two floppy drive devices in qdev
now. (They always created two drives, but managed them only internally.)
Signed-off-by: Kevin Wolf
Reviewed-by: John Snow
---
hw/block/fdc.c | 151 +
1 file changed,
We have been complaining for a long time about how the floppy controller and
floppy drives are combined in a single qdev device and how this makes the
device awkward to work with because it behaves different from all other block
devices.
The latest reason to complain was when I noticed that using
This makes the FloppyDrive qdev object actually useful: Now that it has
all properties that don't belong to the controller, you can actually
use '-device floppy' and get a working result.
Command line semantics is consistent with CD-ROM drives: By default you
get a single empty floppy drive. You c
This tests the different supported methods to create floppy drives and
how they interact.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/172 | 242 +
tests/qemu-iotests/172.out | 1205
tests/qemu-iotests/group |1 +
3 files change
On Tue, Oct 18, 2016 at 11:02:54AM +0200, Igor Mammedov wrote:
> On Mon, 17 Oct 2016 19:44:52 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote:
> > [...]
> > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,
> > > MachineState *m
Added script to check duplicate #include entries. This check will scan
and print the files in which duplicate #include entries are present.
Script might output false positive entries as well. Such entries should
not be removed. So if it finds any duplicate entries script will
terminate with an exi
Some files contain multiple #includes of the same header file.
Removed most of those unnecessary duplicate entries using
scripts/clean-includes.
Signed-off-by: Anand J
---
accel.c | 1 -
cputlb.c| 1 -
gdbstub.c |
On Tuesday, 18 October 2016 11:44:26 CEST Kevin Wolf wrote:
> Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> > The 'obj' result of the visitor was not properly freed, like done in
> > other places doing a similar job.
> > ---
> > block/qapi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
On Tue, Oct 18, 2016 at 11:12:04AM +0200, Igor Mammedov wrote:
> On Mon, 17 Oct 2016 19:44:52 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Oct 13, 2016 at 11:52:39AM +0200, Igor Mammedov wrote:
> > [...]
> > > @@ -236,7 +237,11 @@ void build_legacy_cpu_hotplug_aml(Aml *ctx,
> > > MachineState *m
qmp_output_start_struct() and qmp_output_start_list() create a new
QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
where it is saved as 'value'. When freeing the iterator in
qmp_output_free(), these values are never freed properly.
The simple solution is to qobject_decref
On 17 October 2016 at 18:55, Eduardo Habkost wrote:
> The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197:
>
> Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
> (2016-10-17 16:17:51 +0100)
>
> are available in the git repository at:
>
> git:
On Tue, Oct 18, 2016 at 09:17:48AM +0200, Igor Mammedov wrote:
> On Mon, 17 Oct 2016 19:51:12 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Oct 13, 2016 at 11:52:43AM +0200, Igor Mammedov wrote:
> > > Signed-off-by: Igor Mammedov
> > > ---
> > > v4:
> > > - drop kvm_has_x2apic_api() and reuse kv
The 'obj' result of the visitor was not properly freed, like done in
other places doing a similar job.
Signed-off-by: Pino Toscano
---
Changes in v2:
- added Signed-off-by
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 6f947e3..50d3090 100644
On 10/17/2016 09:06 PM, Dr. David Alan Gilbert wrote:
>> OK, memory was allocated at #2
>> > It is a bit confusing though (for a novice like me) that we have a non
>> > ALLOC VBUFFER
>> > whose pointer is NULL after post_load.
> I don't think this pointer can be NULL; the sbreserve at #2 causes
Am 17.10.2016 um 21:34 schrieb Ashijeet Acharya:
On Tue, Oct 18, 2016 at 12:59 AM, Eric Blake wrote:
On 10/17/2016 01:00 PM, Ashijeet Acharya wrote:
One more relatively easy question though, will we include @port as an
option in runtime_opts while converting NFS to use several
runtime_opts? T
Am 12.10.2016 um 23:18 schrieb Michael R. Hines:
Peter,
Greetings from DigitalOcean. We're experiencing the same symptoms without this
patch.
We have, collectively, many gigabytes of un-planned-for RSS being used
per-hypervisor
that we would like to get rid of =).
Without explicitly trying th
On Mon, 17 Oct 2016 17:20:22 -0200
Eduardo Habkost wrote:
> On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote:
> > Modify all CPUs to call it from XXX_cpu_realizefn() function.
> >
> > Remove all the cannot_destroy_with_object_finalize_yet as
> > unsafe references have been moved to
ivshmem implements a block of shared memory in a PCI BAR. Currently our
test case accesses this using qtest_mem{read,write}. However, deducing
the correct addresses for these requires making assumptions about the
internel format returned by qpci_iomap(), along with some ugly casts.
This patch ch
In the libqos PCI code we now have accessors both for registers (byte
significance preserving) and for streaming data (byte address order
preserving). These exist in both the interface for qtest drivers and in
the machine specific backends.
However, the register-style accessors aren't actually ne
This series contains a number of cleanups to the libqos code for
accessing PCI devices, and to tests which use it.
The general aim is to improve the consistency of semantics across
functions, and reduce the amount of intimate knowledge of the libqos
PCI layer needed by tests.
This should make it
The 'addr' parameter to qvirtio_config_read*() doesn't have a consistent
meaning: when using the virtio-pci versions, it's a full PCI space address,
but for virtio-mmio, it's an offset from the device's base mmio address.
This means that the callers need to do different things to calculate the
add
The usual use model for the libqos PCI functions is to map a specific PCI
BAR using qpci_iomap() then pass the returned token into IO accessor
functions. This, and the fact that iomap() returns a (void *) which
actually contains a PCI space address, kind of suggests that the return
value from ioma
Currently PCI memory (aka MMIO) space is accessed via a set of readb/writeb
style accessors. This is what we want for accessing discrete registers of
a certain size. However, there are a few cases where we instead need a
"bag of bytes" style streaming interface to PCI MMIO space. This can be
eit
The PCI backends in libqos each supply an iomap() and iounmap() function
which is used to set up a specified PCI BAR. But PCI BAR allocation takes
place entirely within PCI space, so doesn't really need per-backend
versions. For example, Linux includes generic BAR allocation code used on
platform
The PCI IO space (aka PIO, aka legacy IO) and PCI memory space (aka MMIO)
are distinct address spaces by the PCI spec (although parts of one might be
aliased to parts of the other in some cases).
However, qpci_io_read*() and qpci_io_write*() can perform accesses to
either space depending on parame
tco_test uses the libqos PCI code to access the device. This makes perfect
sense for the PCI config space accesses. However for IO, rather than the
usual PCI approach of mapping a PCI BAR, then accessing that, it instead
uses the legacy approach of fixed, known addresses in PCI IO space.
That do
The member VMStateField.start was solely used to implement the partial
data migration for VBUFFER data (basically provide migration for a
sub-buffer). However the implementation of this feature is broken, but
this goes unnoticed since the feature is not used at all.
So what the series does is firs
This reverts the effect of the previous patch in the series as
a preparation for getting rid of VMStateField.start.
Signed-off-by: Halil Pasic
Reviewed-by: Guenther Hutzl
---
tests/test-vmstate.c | 48
1 file changed, 48 deletions(-)
diff --git
The member VMStateField.start was solely used to implement the partial
data migration for VBUFFER data (basically provide migration for a
sub-buffer). However the implementation of this feature seems broken to
me, but this goes unnoticed since the feature is not used at all.
Instead of fixing it le
From: Guenther Hutzl
The unit test test-vmstate.c is missing tests for some of the complex
vmstate macros. This patch adds a new test for VMSTATE_VBUFFER
and VMSTATE_VBUFFER_ALLOC_UINT32. The added test does not cover
start != 0 because it's broken and unused so our intention is to
remove start a
On Thu, Oct 13, 2016 at 11:52:40AM +0200, Igor Mammedov wrote:
> ACPI ID is 32 bit wide on CPUs with x2APIC support.
> Extend 'id' property to support it.
>
> Signed-off-by: Igor Mammedov
> ---
> v3:
>keep original behaviour where 'id' is readonly after
>object is realized (pbonzini)
> --
On Tue, 11 Oct 2016 09:19:10 +1100
Alexey Kardashevskiy wrote:
> Ping, anyone?
I have a similar patch
http://patchwork.ozlabs.org/patch/681709/
which bumps limit to 288 and does a little bit more
so it wouldn't affect current users.
After that's merged, I plan to get rid of this limit and
make t
Eric Blake writes:
> On 10/17/2016 09:50 AM, Markus Armbruster wrote:
>>> But even if I realised that QemuOpts support this syntax, I think we
>>> would still have to use the dotted syntax because it's explicit about
>>> the index and we need that because the list can contains dicts.
>>>
>>> Comp
The handling of VMStateField.start is currently quite broken if
VMS_ALLOC is present (that is for VMSTATE_VBUFFER_ALLOC_UINT32) but
fortunately also quite underutilized -- nobody is using .start != 0.
Let's prove with this patch that it's really broken (as a first
step towards fixing things up).
On 10/18/2016 04:17 AM, Pino Toscano wrote:
> qmp_output_start_struct() and qmp_output_start_list() create a new
> QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
> where it is saved as 'value'. When freeing the iterator in
> qmp_output_free(), these values are never freed
On 10/18/2016 05:37 AM, Pino Toscano wrote:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
>
> Signed-off-by: Pino Toscano
> ---
Reviewed-by: Eric Blake
>
> Changes in v2:
> - added Signed-off-by
>
> block/qapi.c | 1 +
> 1 file ch
Am 18.10.2016 um 12:37 hat Pino Toscano geschrieben:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
>
> Signed-off-by: Pino Toscano
Thanks, applied to my block branch.
Kevin
On 10/18/2016 06:13 AM, Eric Blake wrote:
> On 10/18/2016 04:17 AM, Pino Toscano wrote:
>> qmp_output_start_struct() and qmp_output_start_list() create a new
>> QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
>> where it is saved as 'value'. When freeing the iterator in
>>
On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote:
> On 10/18/2016 04:17 AM, Pino Toscano wrote:
> > qmp_output_start_struct() and qmp_output_start_list() create a new
> > QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
> > where it is saved as 'value'. When freei
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20161018105724.26520-1-pa...@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 0/4] remove unused VMSTateField.start
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=
On Fri, Oct 14, 2016 at 01:25:35PM +0200, Igor Mammedov wrote:
> it would prevent starting guest with incorrect configs
> where interrupts couldn't be delivered to CPUs with
> APIC IDs > 255.
>
> Signed-off-by: Igor Mammedov
> Reviewed-by: Radim Krčmář
> ---
> v4:
> - s/254/255/ in commit messa
* Daniel P. Berrange (berra...@redhat.com) wrote:
> On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote:
> > Hi,
> > I had a look at a couple of readline like libraries;
> > editline and linenoise. A difficulty with using them is that
> > they both want fd's or FILE*'s; editli
On 17 October 2016 at 20:51, Alex Williamson wrote:
> The following changes since commit 0975b8b823a888d474fa33821dfe84e6904db197:
>
> Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
> (2016-10-17 16:17:51 +0100)
>
> are available in the git repository at:
>
>
> gi
that's enough to make old code that depends on it
to prevent QEMU starting with more than 255 CPUs.
Signed-off-by: Igor Mammedov
---
v4:
- keep assert() as it doesn't affect x2APIC cpus (Eduardo)
---
hw/acpi/cpu_hotplug.c | 7 ++-
hw/i386/pc.c | 6 --
2 files changed, 6 insert
Hi
On Tue, Oct 18, 2016 at 2:32 PM Dr. David Alan Gilbert
wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote:
> > > Hi,
> > > I had a look at a couple of readline like libraries;
> > > editline and linenoise. A
Hi
On Tue, Oct 18, 2016 at 2:41 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Tue, Oct 18, 2016 at 2:32 PM Dr. David Alan Gilbert <
> dgilb...@redhat.com> wrote:
>
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David A
Am 18.10.2016 um 00:25 hat Tomáš Golembiovský geschrieben:
> This is a follow-up to the patch:
> [PATCH] raw-posix: add 'offset' and 'size' options
>
> The main changes are:
> - options were moved from 'file' driver into 'raw' driver as suggested
> - added support for writing, reopen and t
ASAN complains about buffer overflow when running:
aarch64-softmmu/qemu-system-aarch64 -machine xilinx-zynq-a9
==476==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60235e38
at pc 0x00f75253 bp 0x7ffc597e0ec0 sp 0x7ffc597e0eb0
READ of size 8 at 0x60235e38 thread T0
#0
On Tue, 18 Oct 2016 13:00:07 +0200
Igor Mammedov wrote:
> On Tue, 11 Oct 2016 09:19:10 +1100
> Alexey Kardashevskiy wrote:
>
> > Ping, anyone?
> I have a similar patch
> http://patchwork.ozlabs.org/patch/681709/
> which bumps limit to 288 and does a little bit more
> so it wouldn't affect cur
On 18/10/2016 12:52, David Gibson wrote:
> This series contains a number of cleanups to the libqos code for
> accessing PCI devices, and to tests which use it.
>
> The general aim is to improve the consistency of semantics across
> functions, and reduce the amount of intimate knowledge of the li
1 - 100 of 396 matches
Mail list logo
