After commit 0a73336d, 'props' variable in find_and_check_chardev()
is unused. Remove it, togther with struct CompareChardevProps.
Signed-off-by: zhanghailiang
---
net/colo-compare.c | 8
1 file changed, 8 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 47703c5.
On 10/13/2016 02:57 PM, zhanghailiang wrote:
After commit 0a73336d, 'props' variable in find_and_check_chardev()
is unused. Remove it, togther with struct CompareChardevProps.
Signed-off-by: zhanghailiang
Reviewed-by: Zhang Chen
Thanks
Zhang Chen
---
net/colo-compare.c | 8
From: Heiher
Signed-off-by: Heiher
Signed-off-by: Fuxin Zhang
---
target-mips/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index ed67180..139f249 100644
--- a/target-mips/translate.c
+++ b/target-mips/translat
From: Heiher
Needed to emit FPU exception on Loongson multimedia instructions
executing if Status:CU1 is clear. or FPR changes may be missed
on Linux.
Signed-off-by: Heiher
Signed-off-by: Fuxin Zhang
---
target-mips/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-mips/t
Introduces VirtIOCryptoReq structure to store
crypto request so that we can support sync and async
crypto operation in the future.
At present, we only support cipher and algorithm
chainning.
Signed-off-by: Gonglei
---
hw/virtio/virtio-crypto.c | 338 +
Hi,
The virtio crypto is a virtual crypto device as well as a kind
of virtual hardware accelerator for virtual machines. The
encryption and decryption requests are placed in the data
queue and handled by the real crypto accelerators finally.
The second queue is the control queue used to create or
Hi,
> So far plan is merge it into QEMU 2.8.
> I've amended QEMU counterpart according to Radim's and Paolo's reviews
> and plan to respin it soon.
No respin yet on the list it seems. What is the status? Do you wait
for Radim's patches land upstream first? Can you cc me if you post it?
> I
This patch includes two parts: Cryptodev Backends
and virtio-crypto stuff. I can maintain cryptodev backends
which introduced by myself. For virtio-crypto stuff, I can
share the work with Michael (The whole virtio supporter).
Signed-off-by: Gonglei
---
MAINTAINERS | 13 +
1 file chan
This patch adds virtio-crypto-pci, which is the pci proxy for the virtio
crypto device.
Signed-off-by: Gonglei
---
hw/virtio/Makefile.objs | 1 +
hw/virtio/virtio-crypto-pci.c | 77 +++
hw/virtio/virtio-pci.h| 15 +
3 files changed,
Introduce the virtio crypto realization, I'll
finish the core code in the following patches. The
thoughts came from virtio net realization.
For more information see:
http://qemu-project.org/Features/VirtioCrypto
Signed-off-by: Gonglei
---
hw/virtio/Makefile.objs | 1 +
hw/
On Do, 2016-09-29 at 16:45 +0100, Daniel P. Berrange wrote:
> This patches series should have no functional change, it is
> just a series of cleanups I've accumulated for the VNC server.
> It aims to remove misleading cruft and simplify some parts
> to make future work I'm experimenting with easier
cryptodev backend interface is used to realize the active work for
virtual crypto device.
This patch only add the framework, doesn't include specific operations.
Signed-off-by: Gonglei
---
backends/Makefile.objs | 2 +
backends/cryptodev.c | 176 +
We use an opaque point to the VirtIOCryptoReq which
can support different packets based on different
algorithms.
Signed-off-by: Gonglei
---
backends/cryptodev-builtin.c | 2 +-
backends/cryptodev.c | 28 ++--
hw/virtio/virtio-crypto.c| 10 +-
include/
Markus Armbruster writes:
> "Daniel P. Berrange" writes:
>
>> Instead of requiring all callers to go through the mutli-step
>
> multi-step
>
>> process of turning QemuOpts into a suitable QObject for visiting,
>> add a new constructor that encapsulates this logic. This will
>> allow QObjectInput
On 10/12/2016 06:28 PM, Laszlo Ersek wrote:
Marcel,
On 10/11/16 15:45, Marcel Apfelbaum wrote:
Proposes best practices on how to use PCI Express/PCI device
in PCI Express based machines and explain the reasoning behind them.
Signed-off-by: Marcel Apfelbaum
---
Hi,
RFC->v2:
- Addressed a lo
This patch adds session operation and crypto operation
stuff in the cryptodev backend, including function
pointers and corresponding structures.
Signed-off-by: Gonglei
---
backends/cryptodev.c | 45 +++
include/sysemu/cryptodev.h | 138 +
For one source buffer, we can do cipher and hash operations
partly in algorithms chainning mode. We updated the
corresponding part in virtio crypto specification firstly.
The cryptodev-builtin backend doesn't support algorithm
chainning, so let's add a check for it.
Signed-off-by: Gonglei
---
b
On 13/10/2016 01:57, David Gibson wrote:
> The 'spapr-pci-host-bridge' represents the virtual PCI host bridge (PHB)
> for a PAPR guest. Unlike on x86, it's routine on Power (both bare metal
> and PAPR guests) to have numerous independent PHBs, each controlling a
> separate PCI domain.
>
> There
The new cryptodev backend named cryptodev-builtin,
which realized by QEMU cipher APIs. These APIs can
be backed by either nettle or gcrypt.
Signed-off-by: Gonglei
---
backends/Makefile.objs | 1 +
backends/cryptodev-builtin.c | 345 +++
qemu-option
On 13/10/2016 01:57, David Gibson wrote:
> Currently the default PCI host bridge for the 'pseries' machine type is
> constructed with its IO windows in the 1TiB..(1TiB + 64GiB) range in
> guest memory space. This means that if > 1TiB of guest RAM is specified,
> the RAM will collide with the PCI
Expose the capacity of algorithms supported by
virtio crypto device to the frontend driver using
pci configuration space.
Signed-off-by: Gonglei
---
hw/virtio/virtio-crypto.c | 40 ++-
include/hw/virtio/virtio-crypto.h | 14 ++
2 files chan
On Wed, Oct 12, 2016 at 02:40:30PM +0100, Peter Maydell wrote:
> On 12 October 2016 at 14:33, Andrew Jones wrote:
> > On Tue, Oct 11, 2016 at 06:08:18PM +0100, Peter Maydell wrote:
> >> Rather than defining TARGET_PAGE_BITS to always be 10,
> >> switch to using a value picked at runtime. This allo
> On Mon, Oct 10, 2016 at 15:59:02 +0200, Paolo Bonzini wrote:
> > See each patch. My attempt at fixing whatever I did when I obviously
> > didn't know enough^W about the C11 memory model, and at setting a
> > better example for future generations...
>
> Just for context. Building on this patchse
Introduce the virtio_crypto.h which follows
virtio-crypto specification.
Signed-off-by: Gonglei
---
include/standard-headers/linux/virtio_crypto.h | 406 +
1 file changed, 406 insertions(+)
create mode 100644 include/standard-headers/linux/virtio_crypto.h
diff --git a/i
- Original Message -
> From: "David Hildenbrand"
> To: "Claudio Imbrenda"
> Cc: "David Hildenbrand" , "Paolo Bonzini"
> , qemu-devel@nongnu.org
> Sent: Wednesday, October 12, 2016 8:38:15 PM
> Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
>
> On Wed, Oct 12, 20
On Wed, 12 Oct 2016 15:49:46 -0500
Eric Blake wrote:
> On 10/12/2016 08:23 AM, Greg Kurz wrote:
> >
> > But in fact, I'm afraid we have a more serious problem here... size
> > comes from the guest and could cause g_malloc() to abort if QEMU has
> > reached some RLIMIT... we need to call g_try_ma
On Wed, 12 Oct 2016 19:53:39 -0700
Li Qiang wrote:
> From: Li Qiang
>
> In 9pfs xattr read/write function, it mix to use unsigned/signed
> ,32/64 bits integers. This will causes oob read/write issues. This patch
> fix this.
>
I suggested a more detailed changelog.
> Signed-off-by: Li Qiang
Realize the symmetric algorithm control queue handler,
including plain cipher and chainning algorithms.
Currently the control queue is used to create and
close session for symmetric algorithm.
Signed-off-by: Gonglei
---
hw/virtio/virtio-crypto.c | 285 +++
Jason, what about v5 of this patch?
Pavel Dovgalyuk
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, September 23, 2016 9:07 AM
> To: Pavel Dovgalyuk; qemu-devel@nongnu.org
> Cc: peter.mayd...@linaro.org; quint...@redhat.com; pbonz...@redhat.com;
> m..
On Wed, 12 Oct 2016 19:55:42 -0700
Li Qiang wrote:
> From: Li Qiang
>
> Currently, 9pfs sets the fs.xattr.copied_len field in V9fsFidState
> to -1 to indicate a xattr walk fid. As the fs.xattr.copied_len is also
> used to account for copied bytes, this may cause confusion. This patch
> add a bo
On 13/10/2016 01:57, David Gibson wrote:
> On real hardware, and under pHyp, the PCI host bridges on Power machines
> typically advertise two outbound MMIO windows from the guest's physical
> memory space to PCI memory space:
> - A 32-bit window which maps onto 2GiB..4GiB in the PCI address spa
On Thu, 13 Oct 2016 11:30:08 +0800
Li Qiang wrote:
> Yes, I think the limit to apply to xattr size in 9pfs is the same as the
> Linux xattr size limit, I will try to find this limit.
>
/usr/include/linux/limits.h:#define XATTR_SIZE_MAX 65536/* size of an
extended attribute value (64k)
On Thu, 13 Oct 2016 09:17:51 +0200
Gerd Hoffmann wrote:
> Hi,
>
> > So far plan is merge it into QEMU 2.8.
> > I've amended QEMU counterpart according to Radim's and Paolo's reviews
> > and plan to respin it soon.
>
> No respin yet on the list it seems. What is the status? Do you wait
>
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Message-id: 1476342726-104488-1-git-send-email-arei.gong...@huawei.com
Type: series
Subject: [Qemu-devel] [PATCH v7 00/12] vir
> > No, I disagree. We shouldn't be worried about making intrusive changes
> > to all invocations or declarations, if that leads to a simpler API.
>
> If VMStateInfo was meant for complete customization, then it was missing
> some parts. I think the API is indeed simpler. Just like
> definition
> So we are better leave it as is. Maybe we need to rename some functions in
> that file.
> __iirc__ adding xen_frontend.c is one of Stefano's comments in previous v6
> or v7..
I agree; it's quite possible that code can be shared between backend and
frontend (renaming functions as needed), and
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Wed, Oct 12, 2016 at 4:04 PM, Stefan Hajnoczi wrote:
> > Perhaps this approach can be prototyped with mprotect and a SIGSEGV
> > handler if anyone wants to get async savevm going. I don't know if
> > there are any disadvantages to mprotecting gue
"Daniel P. Berrange" writes:
> If given an option string such as
>
> size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind
>
> the qemu_opts_to_qdict() method will currently overwrite
> the values for repeated option keys, so only the last
> value is in the returned dict:
>
> size=QString("102
On 13/10/2016 01:57, David Gibson wrote:
> Currently, the MMIO space for accessing PCI on pseries guests begins at
> 1 TiB in guest address space. Each PCI host bridge (PHB) has a 64 GiB
> chunk of address space in which it places its outbound PIO and 32-bit and
> 64-bit MMIO windows.
>
> This
On 10/11/2016 03:44 PM, Aleksei wrote:
> Hi,
> I'm using libvirt, but folks on libvirt mailing list said it makes
> more sense to post here.
>
> I have a Windows 7 SP1 Pro 64-bit VM which works fine on libvirt 2.3.0
> and Qemu 2.7.0.
>
> If I enable HyperV features
> (https://libvirt.org/formatdoma
On 10/13/16 09:25, Marcel Apfelbaum wrote:
> On 10/12/2016 06:28 PM, Laszlo Ersek wrote:
>> Marcel,
>>
>> On 10/11/16 15:45, Marcel Apfelbaum wrote:
>>> Proposes best practices on how to use PCI Express/PCI device
>>> in PCI Express based machines and explain the reasoning behind them.
>>>
>>> Sign
On 13/10/2016 02:49, John Snow wrote:
> As context to everyone else as to why I'm going down the rabbit hole of
> trying to remove external references to AioContext at all, see
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00795.html
>
> On 10/07/2016 03:49 AM, Paolo Bonzini wrote:
On 10/13/2016 11:53 AM, Laszlo Ersek wrote:
On 10/13/16 09:25, Marcel Apfelbaum wrote:
On 10/12/2016 06:28 PM, Laszlo Ersek wrote:
Marcel,
On 10/11/16 15:45, Marcel Apfelbaum wrote:
Proposes best practices on how to use PCI Express/PCI device
in PCI Express based machines and explain the reas
Markus Armbruster writes:
> "Daniel P. Berrange" writes:
>
>> If given an option string such as
>>
>> size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind
>>
>> the qemu_opts_to_qdict() method will currently overwrite
>> the values for repeated option keys, so only the last
>> value is in the re
On 10/13/2016 3:14 AM, Alex Williamson wrote:
> On Thu, 13 Oct 2016 00:32:48 +0530
> Kirti Wankhede wrote:
>
>> On 10/12/2016 9:29 PM, Alex Williamson wrote:
>>> On Wed, 12 Oct 2016 20:43:48 +0530
>>> Kirti Wankhede wrote:
>>>
On 10/12/2016 7:22 AM, Tian, Kevin wrote:
>> From: Ki
Query input device keys, initialize state accordingly, so the correct
state is reflected in case any key is pressed at initialization time.
There is a high chance for this to actually happen for the 'enter' key
in case you start qemu with a terminal command (directly or virsh).
When finding any pr
0-12 14:05:23 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-ui-20161013-1
for you to fetch changes up to 2a57c55f26f7ba6dcea6d01ef74bae7069150f6f:
input-linux: initialize key state (2016-10-13 09:2
From: "Daniel P. Berrange"
Rename the vnc_init_state method to reflect what its actual
purpose is, to discourage future devs from using it for more
general state initialization.
Signed-off-by: Daniel P. Berrange
Message-id: 1475163940-26094-10-git-send-email-berra...@redhat.com
Signed-off-by: G
From: "Daniel P. Berrange"
The last line in vnc_init_state() says
/* vs might be free()ed here */
This was added in
commit 198a0039c5fca224a77e9761e2350dd9cc102ad0
Author: Gerd Hoffmann
Date: Tue Jun 16 14:19:48 2009 +0200
vnc: rework VncState release workflow.
because the
From: "Daniel P. Berrange"
The vnc_init_state method calls reset_keys() to reset the
modifier key state. This was originally added in
commit 53762ddb277c690e486d0e17b10591774248c8cf
Author: malc
Date: Mon Dec 1 20:57:52 2008 +
Reset the key modifiers upon client connect
This w
From: "Daniel P. Berrange"
The 'ws_tls' field in VncState is only ever representing
the result of 'tlscreds != NULL' and is thus pointless.
Replace use of 'ws_tls' with a direct check against
'tlscreds'
Signed-off-by: Daniel P. Berrange
Message-id: 1475163940-26094-4-git-send-email-berra...@red
On 13/10/2016 11:11, Marcel Apfelbaum wrote:
> Agreed, I sent the patch with both Red Hat and Google SMTP and each time
> was rejected by the server for the recipient domain nongnu.org by
> eggs.gnu.org. [2001:4830:134:3::10].
>
> The error that the other server returned was: 550 Invalid address
From: "Daniel P. Berrange"
Just before accepting a new client connection the vnc_listen_io
method calls graphic_hw_update(). This is bogus because there
is a call to this method already in vnc_state_init() and the
client doesn't need up2date graphics console before reaching
that.
Signed-off-by:
From: "Daniel P. Berrange"
There is a lot of repeated code in the auth type setup method,
particularly around checking TLS credential types. Refactor
it to reduce duplication and instead of having one method
do both plain and websockets at once, call it separately
for each.
Signed-off-by: Daniel
From: "Daniel P. Berrange"
Most of the fields in VncState are initialized in the
vnc_connect() method, but some are done in vnc_init_state()
instead.
The purpose of having vnc_init_state() is to delay starting
of the VNC wire protocol until after the websockets handshake
has completed. As such t
From: "Daniel P. Berrange"
Normally code declares 'VncDisplay *vd' or 'VncState *vs'
but there are a bunch of places which misleadingly declare
'VncDisplay *vs'.
Signed-off-by: Daniel P. Berrange
Message-id: 1475163940-26094-5-git-send-email-berra...@redhat.com
Signed-off-by: Gerd Hoffmann
---
If a name is provided, the same name is assigned to both the I2C
controllers. Leaving it NULL, causes names to be automatically
assigned with an ID suffix, giving unique names to each
controller. This helps us to uniquely identify each controller in the
device tree, for example when adding an I2C d
From: "Daniel P. Berrange"
The 'ws_enabled' field is never used outside of the
vnc_display_open method, so can be a local variable.
The 'enabled' field is easily replaced by a check
for whether 'lsock' is non-NULL.
Signed-off-by: Daniel P. Berrange
Message-id: 1475163940-26094-3-git-send-email
that's enough to make old code that depends on it
to prevent QEMU starting with more than 255 CPUs.
Signed-off-by: Igor Mammedov
---
hw/acpi/cpu_hotplug.c | 7 ++-
hw/i386/pc.c | 7 ---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/cpu_hotplug.c b/hw/acp
Signed-off-by: Igor Mammedov
---
rebase on top in 2.7 + updated cpu PXM patches
---
include/hw/acpi/acpi-defs.h | 11 +++
hw/i386/acpi-build.c| 34 --
2 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/include/hw/acpi/acpi-defs.h b/inc
Signed-off-by: Igor Mammedov
---
include/hw/acpi/acpi-defs.h | 18 +++
hw/i386/acpi-build.c| 78 +++--
2 files changed, 72 insertions(+), 24 deletions(-)
diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h
index 9c1b7cb..
Signed-off-by: Igor Mammedov
---
v4:
- drop kvm_has_x2apic_api() and reuse kvm_enable_x2apic() instead
---
hw/i386/kvm/apic.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
index be55102..9a7dd03 100644
--- a/hw/i386/kvm/
Changes since v2:
- rebase on top of EIM fixes
- drop kvm_has_x2apic_ids() and reuse kvm_enable_x2apic()
from Radim's EIM fixes
- fix hang on reboot in BIOS due to not updated 'etc/boot-cpus' fwcfg file
after CPU hotplug
- drop not used anymore pc_present_cpus_count() and incrementa
APIC ID should be restored to initial APIC ID
state after Reset and Power-On.
Signed-off-by: Igor Mammedov
---
hw/intc/apic_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index 30f2af0..ea3c8ca 100644
--- a/hw/intc/apic_common.c
+++ b/h
Switch to modern cpu hotplug at machine startup time if
a cpu present at boot has apic-id in range unsupported
by legacy cpu hotplug interface (i.e. > 254), to avoid
killing QEMU from legacy cpu hotplug code with error:
"acpi: invalid cpu id: #apic-id#"
Signed-off-by: Igor Mammedov
---
hw/acp
ACPI ID is 32 bit wide on CPUs with x2APIC support.
Extend 'id' property to support it.
Signed-off-by: Igor Mammedov
---
v3:
keep original behaviour where 'id' is readonly after
object is realized (pbonzini)
---
include/hw/i386/apic_internal.h | 3 ++-
target-i386/cpu.h | 1
Signed-off-by: Igor Mammedov
---
hw/acpi/cpu.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
index 902f5c9..5ac89fe 100644
--- a/hw/acpi/cpu.c
+++ b/hw/acpi/cpu.c
@@ -531,6 +531,11 @@ void build_cpus_aml(Aml *table, MachineState *machine,
CPUHotplugFeatur
so that it would be possible to increase maxcpus limit
for x86 target. Keep spapr/virt_arm at limit they used
to have 255.
Signed-off-by: Igor Mammedov
---
CC: da...@gibson.dropbear.id.au
CC: peter.mayd...@linaro.org
CC: drjo...@redhat.com
include/sysemu/sysemu.h | 2 +-
hw/arm/virt.c
On 13/10/2016 11:52, Igor Mammedov wrote:
> To play with the feature, one would also need x2apic enabled
> seabios counterpart:
> https://github.com/imammedo/seabios.git x2apic_v4
Is this going to make it into seabios 1.10?
Paolo
SDM: x2APIC State Transitions:
State Changes From xAPIC Mode to x2APIC Mode
"
Any APIC ID value written to the memory-mapped
local APIC ID register is not preserved
"
Signed-off-by: Igor Mammedov
---
hw/intc/apic_common.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/intc/
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f1c1013..f807932 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -746,17 +746,15 @@ static FWCfgState *bochs_bios_init(AddressSpa
I had the same problem and it took me some time to get to this bug
report.
Since this behaviour will not change in future versions of Qemu/OVMF,
maybe Qemu should recognize this configuration as invalid and print
error message instead of failing silently?
--
You received this bug notification be
it would prevent starting guest with incorrect configs
where interrupts couldn't be delivered to CPUs with
APIC IDs > 254.
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 40eb43b..f7070e0 100644
--
From: Li Qiang
The 'len' in V9fsXattr comes from the 'size' argument in setxattr()
function in guest. The setxattr() function's declaration is this:
int setxattr(const char *path, const char *name,
const void *value, size_t size, int flags);
and 'size' is treated as u64 in linux ke
From: Li Qiang
The v9fs_xattr_read() and v9fs_xattr_write() are passed a guest
originated offset: they must ensure this offset does not go beyond
the size of the extended attribute that was set in v9fs_xattrcreate().
Unfortunately, the current code implement these checks with unsafe
calculations
>>> Markus Armbruster 2016/10/11 星期二 下午 2:56 >>>
>Eric Blake writes:
>
>> On 10/10/2016 10:09 AM, Lin Ma wrote:
>>>
>>>
>> Eric Blake 2016/9/27 星期二 上午 4:17 >>>
On 09/26/2016 05:38 AM, Daniel P. Berrange wrote:
> On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote:
>> Auto
Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
to get number of CPUs present at boot. However 1 byte is
not enough to handle more than 255 CPUs. So add a new
fw_cfg file that would allow QEMU to tell it.
For compat reasons add file only for machine types that
support more than 255 CPUs.
From: Li Qiang
The current xattr implementation in 9pfs has several issues.
-The 'copied_len' in V9fsXattr is used both for accounting bytes and to tag the
xattr fid.
-The 'len/copied_len' field in V9fsXattr has a wrong type.
-The read/write dispatch function of xattr uses unsafe computations.
On Thu, 13 Oct 2016 12:01:48 +0200
Paolo Bonzini wrote:
> On 13/10/2016 11:52, Igor Mammedov wrote:
> > To play with the feature, one would also need x2apic enabled
> > seabios counterpart:
> > https://github.com/imammedo/seabios.git x2apic_v4
>
> Is this going to make it into seabios 1.10?
T
On Do, 2016-10-13 at 12:01 +0200, Paolo Bonzini wrote:
>
> On 13/10/2016 11:52, Igor Mammedov wrote:
> > To play with the feature, one would also need x2apic enabled
> > seabios counterpart:
> > https://github.com/imammedo/seabios.git x2apic_v4
>
> Is this going to make it into seabios 1.10?
sea
On 10/12/2016 04:59 PM, Dr. David Alan Gilbert wrote:
>> Paolo I agree on a theoretical level. It's just I do not see why this
>> > particular change makes the API simpler. In my opinion this complicates
>> > things because now all VMStateInfo's can do funky stuff. Having additional
>> > state yo
On 12 October 2016 at 23:35, Michael Walle wrote:
> Be consistent with the reference manual.
>
> Signed-off-by: Michael Walle
> ---
> target-lm32/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index dc64cc6
On 12 October 2016 at 23:35, Michael Walle wrote:
> Don't truncate the multiplication and do a 64 bit one instead because
> because the result is stored in a 64 bit variable.
>
> Spotted by coverity, CID 1167561.
>
> Signed-off-by: Michael Walle
> ---
> hw/display/milkymist-tmu2.c | 2 +-
> 1 fi
On 12 October 2016 at 23:35, Michael Walle wrote:
> The lm32 target already has a disassembler which logs the assembly
> instructions with "-d in_asm". Therefore, turn of the LOG_DIS() macro to
> prevent logging the assembly instructions twice. Also turn the macro in a
> one which is always compil
On 12 October 2016 at 23:35, Michael Walle wrote:
> Drop the rX, rY and rZ stuff and use dc->r{0,1,2} directly. This should
> also fix the false positive in coverity CID 1005720.
>
> Signed-off-by: Michael Walle
> ---
> target-lm32/translate.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 de
On 13 October 2016 at 07:42, P J P wrote:
> +-- On Wed, 12 Oct 2016, Peter Maydell wrote --+
> | > -while (gtb->compare < update.new) {
> | > +if (gtb->compare < update.new) {
> | >
> | > +inc = update.new - gtb->compare - 1;
> |
> | Can you explain why
On 10/13/2016 10:22 AM, Paolo Bonzini wrote:
>>> No, I disagree. We shouldn't be worried about making intrusive changes
>>> > > to all invocations or declarations, if that leads to a simpler API.
>> >
>> > If VMStateInfo was meant for complete customization, then it was missing
>> > some parts.
On 10/13/2016 12:38 PM, Paolo Bonzini wrote:
On 13/10/2016 11:11, Marcel Apfelbaum wrote:
Agreed, I sent the patch with both Red Hat and Google SMTP and each time
was rejected by the server for the recipient domain nongnu.org by
eggs.gnu.org. [2001:4830:134:3::10].
The error that the other se
From: Prem Mallappa
ACPI Spec 6.0 introduces IO Remapping Table Structure. This patch
introduces the definitions required to describe the IO relationship
between the PCIe root complex and the ITS.
This conforms to:
"IO Remapping Table System Software on ARM Platforms",
Document number: ARM DEN 0
This series completes the support of MSIs for ACPI guests featuring an ITS.
It generates an ACPI IORT table which describes the relationship between
the root complex and the ITS. This typically enables vhost-net support on
such guest.
The series applies on top of Drew's [PATCH 0/2] couple ITS sup
From: Prem Mallappa
This patch builds an IORT table that features a root complex node and
an ITS node. This complements the ITS description in the ACPI MADT
table and allows vhost-net on ACPI guest.
Signed-off-by: Prem Mallappa
Signed-off-by: Eric Auger
---
hw/arm/virt-acpi-build.c | 71 +
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>
>
> On 10/12/2016 04:59 PM, Dr. David Alan Gilbert wrote:
> >> Paolo I agree on a theoretical level. It's just I do not see why this
> >> > particular change makes the API simpler. In my opinion this complicates
> >> > things because now all VMSta
chardev property is blindly trying to remove the frontend handlers, but
that doesn't work properly that way since there might be several
frontend on the same chardev. Instead, chardev frontend should use
qemu_chr_remove_handlers(). A previous commit should have fixed all
users.
Signed-off-by: Marc
Hi,
Commit 949055a2 "char: use a fixed idx for child muxed chr" introduced
a regression in mux usage, since it wrongly interpreted mux as muxing
various chr backend. Instead, it muxes frontends.
The first patch reverts the broken change, the following patches add
tracking to frontend handler, fin
That commit mis-used mux char: the frontend are multiplexed, not the
backend. Fix the regression preventing "c-a c" to switch the focus. The
following patches will fix the crash (when leaving or removing frontend)
by tracking frontends with handler tags.
This reverts commit 949055a2549afc4cde06b79
Enforce good usage of frontend handlers.
Signed-off-by: Marc-André Lureau
---
include/sysemu/char.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index 36d82b1..9632dbb 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -439,6
Remove the handlers associated with a frontend tag.
Signed-off-by: Marc-André Lureau
---
qemu-char.c | 9 +
include/sysemu/char.h | 9 +
2 files changed, 18 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 168af69..a7fec6a 100644
--- a/qemu-char.c
+++ b/qemu-
The tag helps to keep track of the frontend, and will be used in a later
change for removing the associated callbacks. Once the conversion is
done, a warning will be added to not ignore the return value, since that
would likely lead to an incorrect behaviour.
Signed-off-by: Marc-André Lureau
---
Signed-off-by: Marc-André Lureau
---
tests/test-char.c | 238 +
tests/Makefile.include | 4 +
2 files changed, 242 insertions(+)
create mode 100644 tests/test-char.c
diff --git a/tests/test-char.c b/tests/test-char.c
new file mode 100644
in
Frontends should use qemu_chr_add_handlers()/qemu_chr_remove_handlers()
with the appropriate tag. This prevents from growing the mux char
frontends. A following patch will add error handling (check tag return
value and add an Error argument).
Signed-off-by: Marc-André Lureau
---
backends/rng-egd
1 - 100 of 317 matches
Mail list logo
