Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 3/9] ppc/xics: Make the ICSState a list

2016-09-19 Thread Cédric Le Goater
On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Instead of an array of fixed sized blocks, use a list, as we will need > to have sources with variable number of interrupts. SPAPR only uses > a single entry. Native will create more. If performance becomes an > i

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 3/9] ppc/xics: Make the ICSState a list

2016-09-19 Thread Nikunj A Dadhania
Cédric Le Goater writes: > On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> Instead of an array of fixed sized blocks, use a list, as we will need >> to have sources with variable number of interrupts. SPAPR only uses >> a single entry. Native will create m

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 7/9] ppc/xics: Add "native" XICS subclass

2016-09-19 Thread Cédric Le Goater
On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > This provides MMIO based ICP access as found on POWER8 > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Nikunj A Dadhania There are further changes to do on this one before merging it. I think we sho

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

2016-09-19 Thread Cédric Le Goater
On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > The existing implementation remains same and ics-base is introduced. The > type name "ics" is retained, and all the related functions renamed as > ics_simple_* > > This will allow different implementations for th

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-19 Thread Jike Song
On 09/12/2016 11:53 PM, Alex Williamson wrote: > On Mon, 12 Sep 2016 13:19:11 +0530 > Kirti Wankhede wrote: > >> On 9/12/2016 10:40 AM, Jike Song wrote: >>> On 09/10/2016 03:55 AM, Kirti Wankhede wrote: On 9/10/2016 12:12 AM, Alex Williamson wrote: > On Fri, 9 Sep 2016 23:18:45 +0530

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 3/9] ppc/xics: Make the ICSState a list

2016-09-19 Thread Cédric Le Goater
On 09/19/2016 09:02 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: >>> From: Benjamin Herrenschmidt >>> >>> Instead of an array of fixed sized blocks, use a list, as we will need >>> to have sources with variable number of interrupts

Re: [Qemu-devel] [PATCH v3 0/5] POWER9 TCG enablements - part4(pending)

2016-09-19 Thread David Gibson
On Fri, Sep 16, 2016 at 04:21:46PM +0530, Nikunj A Dadhania wrote: > This series contains 4 new instructions for POWER9 ISA3.0 > Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x. > > Patches: > 01: darn: Deliver a random number I've applied this one. > 02: lxvw4x -

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-19 Thread David Gibson
On Fri, Sep 16, 2016 at 04:21:48PM +0530, Nikunj A Dadhania wrote: > Load 8byte at a time and manipulate. > > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 1 + > target-ppc/mem_helper.c | 5 + > target-ppc/translate/vsx-impl.inc.c | 19 +---

Re: [Qemu-devel] [PATCH v3 5/5] target-ppc: add lxvb16x and stxvb16x

2016-09-19 Thread David Gibson
On Fri, Sep 16, 2016 at 04:21:51PM +0530, Nikunj A Dadhania wrote: > lxvb16x: Load VSX Vector Byte*16 > stxvb16x: Store VSX Vector Byte*16 > > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/translate/vsx-impl.inc.c | 55 > + > target-ppc/translate/vsx-op

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-19 Thread David Gibson
On Mon, Sep 19, 2016 at 04:19:34PM +1000, David Gibson wrote: > On Fri, Sep 16, 2016 at 04:21:48PM +0530, Nikunj A Dadhania wrote: > > Load 8byte at a time and manipulate. > > > > Signed-off-by: Nikunj A Dadhania > > --- > > target-ppc/helper.h | 1 + > > target-ppc/mem_helper.c

Re: [Qemu-devel] [PATCH v3 4/5] target-ppc: add lxvh8x and stxvh8x

2016-09-19 Thread David Gibson
On Fri, Sep 16, 2016 at 04:21:50PM +0530, Nikunj A Dadhania wrote: > lxvh8x: Load VSX Vector Halfword*8 > stxvh8x: Store VSX Vector Halfword*8 > > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 1 + > target-ppc/mem_helper.c | 6 > target-ppc

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in virtio_gpu_resource_create_2d

2016-09-19 Thread Marc-André Lureau
On Mon, Sep 19, 2016 at 6:08 AM Li Qiang wrote: > From: Li Qiang > > In virtio gpu resource create dispatch, if the pixman format is zero > it doesn't free the resource object allocated previously. Thus leading > a host memory leak issue. This patch avoid this. > > Signed-off-by: Li Qiang > Re

Re: [Qemu-devel] [PATCH v3 2/2] qemu: use bdrv_flush_all for vm_stop et al

2016-09-19 Thread Kevin Wolf
Am 16.09.2016 um 18:17 hat John Snow geschrieben: > > > On 09/15/2016 07:42 PM, John Snow wrote: > >Bypass the usual check to see if we are "allowed" to flush via the > >block model, and manually flush the BDS nodes themselves instead. > > > >This allows us to do things like migrate when we have

Re: [Qemu-devel] [s390] possible deadlock in handle_sigp?

2016-09-19 Thread Christian Borntraeger
On 09/15/2016 09:21 PM, David Hildenbrand wrote: >> On 09/12/2016 08:03 PM, Paolo Bonzini wrote: >>> >>> >>> On 12/09/2016 19:37, Christian Borntraeger wrote: On 09/12/2016 06:44 PM, Paolo Bonzini wrote: > I think that two CPUs doing reciprocal SIGPs could in principle end up > wai

[Qemu-devel] [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation

2016-09-19 Thread Gonglei
Changes since v2: According to Daniel's comments: - drop cryptodev kernel module as a cryptodev backend - rename crypto stuff to cryptodev stuff - change some files' license to GPLv2+ - remove cryptodev command line instead of QOM to define the cryptodev backend - rename all functions and str

[Qemu-devel] [PATCH v3 01/10] cryptodev: introduce cryptodev backend interface

2016-09-19 Thread Gonglei
cryptodev backend interface is used to realize the active work for virtual crypto device. This patch only add the framework, doesn't include specific operations. Signed-off-by: Gonglei --- crypto/Makefile.objs | 1 + crypto/cryptodev.c | 175 +

[Qemu-devel] [PATCH v3 05/10] virtio-crypto: add virtio crypto device emulation

2016-09-19 Thread Gonglei
Introduce the virtio crypto realization, I'll finish the core code in the following patches. The thoughts came from virtio net realization. For more information see: http://qemu-project.org/Features/VirtioCrypto Signed-off-by: Gonglei --- hw/virtio/Makefile.objs | 1 + hw/virtio/vir

[Qemu-devel] [PATCH v3 02/10] cryptodev: add symmetric algorithm operation stuff

2016-09-19 Thread Gonglei
This patch add session operation and crypto operation stuff in the cryptodev backend, including function pointers and correpsonding structures. Signed-off-by: Gonglei --- crypto/cryptodev.c | 44 +++ include/crypto/cryptodev.h | 132 ++

[Qemu-devel] [PATCH v3 07/10] virtio-crypto: set capacity of algorithms supported

2016-09-19 Thread Gonglei
Expose the capacity of algorithms supported by virtio crypto device to the frontend driver using pci configuration space. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 39 ++- include/hw/virtio/virtio-crypto.h | 14 ++ 2 files chan

[Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei
Signed-off-by: Gonglei --- crypto/Makefile.objs | 1 + crypto/cryptodev-gcrypt.c | 329 ++ qemu-options.hx | 18 +++ 3 files changed, 348 insertions(+) create mode 100644 crypto/cryptodev-gcrypt.c diff --git a/crypto/Makefile.objs b/

[Qemu-devel] [PATCH v3 03/10] virtio-crypto: introduce virtio_crypto.h

2016-09-19 Thread Gonglei
Introdue the virtio_crypto.h which follows virtio-crypto specification. Signed-off-by: Gonglei --- include/standard-headers/linux/virtio_crypto.h | 466 + 1 file changed, 466 insertions(+) create mode 100644 include/standard-headers/linux/virtio_crypto.h diff --git a/in

[Qemu-devel] [PATCH v3 09/10] virtio-crypto: add data queue processing handler

2016-09-19 Thread Gonglei
Firstly I introduce VirtIOCryptoReq structure to store crypto request so that we can support sync and async crypto operation in the future. Secondly, VirtIOCryptoBuffer structure is used to support sg list on source data, destionation data and associated anthentication data according virtio crypto

[Qemu-devel] [PATCH v3 10/10] cryptodev: introduce an unified wrapper for crypto operation

2016-09-19 Thread Gonglei
We use an opaque point to the VirtIOCryptoReq which can support different packets based on different algorithms. Signed-off-by: Gonglei --- crypto/cryptodev-gcrypt.c | 2 +- crypto/cryptodev.c | 28 ++-- hw/virtio/virtio-crypto.c | 10 +- include/crypto

[Qemu-devel] [PATCH v3 06/10] virtio-crypto-pci: add virtio crypto pci support

2016-09-19 Thread Gonglei
This patch adds virtio-crypto-pci, which is the pci proxy for the virtio crypto device. Signed-off-by: Gonglei --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-crypto-pci.c | 76 +++ hw/virtio/virtio-pci.h| 15 + 3 files changed,

[Qemu-devel] [PATCH] linux-user: fix tcg/mmap test

2016-09-19 Thread Marc-André Lureau
tests/tcg/mmap test fails with values other than default target page size. When creating a map beyond EOF, extra anonymous pages are added up to the target page boundary. Currently, this operation is performed only when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it should be performed if the

Re: [Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

2016-09-19 Thread Aleksandar Markovic
Thanks a lot for the review, Laurent, I am going to add TARGET_SH4 and TARGET_ALPHA to this change. I test LTP syscall test set on mips, arm and intel platforms as my regression tests, but also some number of individual LTP tests (the choice of tests depends on the change) on more platforms, an

[Qemu-devel] [PATCH v3 08/10] virtio-crypto: add control queue handler

2016-09-19 Thread Gonglei
Realize the symmetric algorithm control queue handler, including plain cipher and chainning algorithms. Currently the control queue is used to create and close session for symmetric algorithm. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 234 +++

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Daniel P. Berrange
AFAICT you are not using gcrypt here - you're using QEMU cipher APIs (which is good). These APIs can be backed by either nettle or gcrypt though, so the subject is misleading. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [Qemu-devel] [PATCH v3 0/5] POWER9 TCG enablements - part4(pending)

2016-09-19 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Sep 16, 2016 at 04:21:46PM +0530, Nikunj A Dadhania wrote: >> This series contains 4 new instructions for POWER9 ISA3.0 >> Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x. >> >> Patches: >> 01: darn: Deliver

[Qemu-devel] [PATCH v2 1/3] pc: clean up COMPAT macroses chaining

2016-09-19 Thread Igor Mammedov
Since commit bacc344c ("machine: add properties to compat_props incrementaly") there is no need to chain per machine type compat macroses. Clean up places where it was done anyway so it will be consistent and won't confuse contributors during addtion of new machine types. Signed-off-by: Igor Mam

Re: [Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignment cases for Mips64

2016-09-19 Thread Aleksandar Markovic
So true. In v7, I am going to use the style that you suggested. From: Laurent Vivier [laur...@vivier.eu] Sent: Friday, September 16, 2016 12:29 PM To: Aleksandar Markovic; qemu-devel@nongnu.org; riku.voi...@iki.fi; peter.mayd...@linaro.org; aurel...@aurel3

[Qemu-devel] [PATCH v2 0/3] pc: compat macroses fixes/cleanups

2016-09-19 Thread Igor Mammedov
Changes since v1: - drop 'pc: fix regression introduced by adding 2.8 machine' it's not needed - cleanup old style compat chaining - add missing HW_COMPAT_2_8 to PC_COMPAT_2_8 machine type ref to v1: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03140.html Igor Mammedov (3):

Re: [Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls items in strace.list

2016-09-19 Thread Aleksandar Markovic
Thanks, I did it hard way: by copying the content of strace.list and headers in into columns of a spreadsheet, than processing the content so that each syscall has its own row, and after that doing numerous copying and pasting for syscalls that did not appear to have support in strace.list. In h

[Qemu-devel] [PATCH v2 2/3] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

2016-09-19 Thread Igor Mammedov
commit (14c985cff target-i386: present virtual L3 cache info for vcpus) misplaced compat property putting it in new 2.8 machine type which would effectively to disable feature until 2.9 is released. Intent of commit probably should be to disable feature for 2.7 and older while allowing not yet rele

Re: [Qemu-devel] [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation

2016-09-19 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation Message-id: 1474272982-275836-1-git-send-email-arei.gong...@huawei.com === TEST SCRIPT BEG

Re: [Qemu-devel] [PATCH 1/6] tests/tcg: Move i386 tests to arch specific folder

2016-09-19 Thread Marc-André Lureau
Hi On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar wrote: > Signed-off-by: Pranith Kumar > --- > tests/tcg/Makefile | 156 > > tests/tcg/i386/Makefile | 88 ++ > tests/tcg/{ => i386}/hello-i386.c | 9 +

[Qemu-devel] [PATCH v2 3/3] add stub HW_COMPAT_2_8 to PC_COMPAT_2_8

2016-09-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- include/hw/compat.h | 2 ++ include/hw/i386/pc.h | 1 + 2 files changed, 3 insertions(+) diff --git a/include/hw/compat.h b/include/hw/compat.h index a1d6694..ddbb2c4 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -1,6 +1,8 @@ #ifndef HW_COMPAT_H

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-19 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Sep 16, 2016 at 04:21:48PM +0530, Nikunj A Dadhania wrote: >> Load 8byte at a time and manipulate. >> >> Signed-off-by: Nikunj A Dadhania >> --- >> target-ppc/helper.h | 1 + >> target-ppc/mem_helper.c |

Re: [Qemu-devel] [PATCH v6 4/7] linux-user: Fix structure target_semid64_ds definition for Mips

2016-09-19 Thread Aleksandar Markovic
The naming in this patch will be synced with that from the kernel in v7. Thanks! From: Laurent Vivier [laur...@vivier.eu] Sent: Friday, September 16, 2016 12:00 PM To: Aleksandar Markovic; qemu-devel@nongnu.org; riku.voi...@iki.fi; peter.mayd...@linaro.org

[Qemu-devel] [RFC PATCH] ppc/xics: introduce helpers to find an ICP from some (CPU) index

2016-09-19 Thread Cédric Le Goater
Today, the CPU index is used to index the icp array under xics. This works correctly when the indexes are sync but that is an assumption that could break future implementations. For instance, the PowerNV platform CPUs use real HW ids and they are not contiguous. Let's introduce some helpers to hid

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei (Arei)
Hi Daniel, > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 19, 2016 4:30 PM > Subject: Re: [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new > cryptodev backend > > AFAICT you are not using gcrypt here - you're using QEMU > c

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2016 at 04:16:16PM +0800, Gonglei wrote: > Signed-off-by: Gonglei > --- > crypto/Makefile.objs | 1 + > crypto/cryptodev-gcrypt.c | 329 > ++ > qemu-options.hx | 18 +++ > 3 files changed, 348 insertions(+) > create m

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 19, 2016 4:56 PM > Subject: Re: [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new > cryptodev backend > > On Mon, Sep 19, 2016 at 04:16:16PM +0800, Gonglei wrote: > > Signed-off-

[Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

2016-09-19 Thread P J P
From: Prasad J Pandit virtio back end uses set of buffers to facilitate I/O operations. If its size is too large, 'cpu_physical_memory_map' could return a null address. This would result in a null dereference while un-mapping descriptors. Add check to avoid it. Reported-by: Qinghao Tang Signed-

Re: [Qemu-devel] [PATCH] virtio: add check for descriptor's mapped address

2016-09-19 Thread P J P
+-- On Fri, 16 Sep 2016, Laszlo Ersek wrote --+ | CC Stefan | I think it would be reasonable to handle this other guest bug similarly: | | if (iov[num_sg].iov_base == NULL) { | error_report("virtio: bogus descriptor or out of resources"); | exit(EXIT_FAILURE); | } ... | So,

[Qemu-devel] [PULL 1/5] s390x/kvm: disable cpu model for the 2.7 machine

2016-09-19 Thread Cornelia Huck
From: Christian Borntraeger cpu model was merged with 2.8, it is wrong to abuse ri_allowed which was enabled with 2.7. Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 + include/hw/s390x/s390-virtio-ccw.h | 3 +++

[Qemu-devel] [PULL 0/5] next round of s390x patches

2016-09-19 Thread Cornelia Huck
The following changes since commit e3571ae30cd26d19efd4554c25e32ef64d6a36b3: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160916' into staging (2016-09-16 16:54:50 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20160919 for yo

[Qemu-devel] [PULL 5/5] QMP: fixup typos and whitespace damage

2016-09-19 Thread Cornelia Huck
From: Christian Borntraeger Fixup some typos and whitespace damage introduced by the CPU model patches for s390. Reported-by: Eric Blake Signed-off-by: Christian Borntraeger Reviewed-by: Eric Blake Signed-off-by: Cornelia Huck --- qapi-schema.json | 8 1 file changed, 4 insertions(

[Qemu-devel] [PULL 4/5] virtio-ccw: set revision 2 as maximal revision number

2016-09-19 Thread Cornelia Huck
From: Pierre Morel We have everything needed for virtio-ccw revision 2 wired up now. Bump the maximum supported revision reported on a device basis to the guest so they can make use of it. Signed-off-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.h | 2 +- 1 file change

[Qemu-devel] [PULL 2/5] MAINTAINERS: update s390 machine file patterns

2016-09-19 Thread Cornelia Huck
From: Sascha Silbe Some files used by s390 KVM code were missing in MAINTAINERS. Add them. Reported-by: Markus Armbruster Signed-off-by: Sascha Silbe Signed-off-by: Cornelia Huck --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d43026..7

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Sep 14, 2016 at 11:30:06AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Dr. David Alan Gilbert (git)" writes: >> > >> > > From: "Dr. David Alan Gilbert" >> > > >> > > This started off as Andreas Färber's imp

[Qemu-devel] [PULL 3/5] virtio-ccw: respond to READ_STATUS command

2016-09-19 Thread Cornelia Huck
From: Pierre Morel This patch adds the response to the READ_STATUS CCW command. Signed-off-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 20 hw/s390x/virtio-ccw.h | 1 + 2 files changed, 21 insertions(+) diff --git a/hw/s390x/virtio-ccw.c b/h

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Markus Armbruster
Peter Maydell writes: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: >> On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: >>> On 16 September 2016 at 14:55, Laurent Vivier wrote: >>> > This series is the result of coccinelle patch >>> > scripts/coccinelle/exit.cocci >>>

Re: [Qemu-devel] [PULL v2 7/8] tests: virtio-9p: add basic transaction test

2016-09-19 Thread Greg Kurz
On Fri, 16 Sep 2016 20:03:29 +0200 Greg Kurz wrote: > This adds a simple test to validate the device is functional: it transmits > a request with type Terror, which is not used by the 9P protocol [1], and > expects QEMU to return a reply with type Rerror and the "Operation not > supported" error

Re: [Qemu-devel] [PATCH v3 3/3] tests: virtio-9p: add basic transaction test

2016-09-19 Thread Greg Kurz
On Fri, 16 Sep 2016 19:43:57 +0200 Greg Kurz wrote: > This adds a simple test to validate the device is functional: it transmits > a request with type Terror, which is not used by the 9P protocol [1], and > expects QEMU to return a reply with type Rerror and the "Operation not > supported" error

Re: [Qemu-devel] seccomp missing calls in 2.7.0?

2016-09-19 Thread Markus Armbruster
Brian Rak writes: > getrusage is used in a number of places throughout the qemu codebase > (notably, in crypto/pbkdf.c). > Without this syscall being whitelisted, qemu ends up getting killed by > the kernel whenever you > try to connect to a VNC console. The body of the commit message now looks

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Laurent Vivier
On 16/09/2016 17:45, Peter Maydell wrote: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: >> On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: >>> On 16 September 2016 at 14:55, Laurent Vivier wrote: This series is the result of coccinelle patch scripts/coccine

Re: [Qemu-devel] seccomp missing calls in 2.7.0?

2016-09-19 Thread Eduardo Otubo
On Mon, Sep 19, 2016 at 11=45=47AM +0200, Markus Armbruster wrote: > Brian Rak writes: > > > getrusage is used in a number of places throughout the qemu codebase > > (notably, in crypto/pbkdf.c). > > Without this syscall being whitelisted, qemu ends up getting killed by > > the kernel whenever yo

Re: [Qemu-devel] [PATCH 0/4] Move some trace events to the correct files

2016-09-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > When I split up the monolithic trace-events file, a few > events ended up in incorrect files, partly due to incorrect > file name annotations against the events, partly due to my > mistakes. Are you aware of scripts/cleanup-trace-events.pl? [...]

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2016 at 11:18:05AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Sep 14, 2016 at 11:30:06AM +0100, Dr. David Alan Gilbert wrote: > >> * Markus Armbruster (arm...@redhat.com) wrote: > >> > "Dr. David Alan Gilbert (git)" writes: > >> > > >> > > From:

Re: [Qemu-devel] [PATCH 0/4] Move some trace events to the correct files

2016-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2016 at 11:51:09AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > When I split up the monolithic trace-events file, a few > > events ended up in incorrect files, partly due to incorrect > > file name annotations against the events, partly due to my > > mistak

[Qemu-devel] [PULL v3 0/7] 9p patches for 2.8 20160919

2016-09-19 Thread Greg Kurz
Hi Peter, This is a respin of v2 with the very same patches, except the one with the endianness problems which gets dropped. I hence only post the cover letter. Cheers. -- Greg The following changes since commit 5f473241ac595452ae0638dc63e7af2a2294f5ec: Merge remote-tracking branch 'remotes/

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Peter Maydell
On 19 September 2016 at 10:46, Laurent Vivier wrote: > --- > Portability note: Some non-POSIX systems use different conventions for > exit status values. For greater portability, you can use the macros > EXIT_SUCCESS and EXIT_FAIL

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-19 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Sep 19, 2016 at 04:19:34PM +1000, David Gibson wrote: >> On Fri, Sep 16, 2016 at 04:21:48PM +0530, Nikunj A Dadhania wrote: >> > diff --git a/target-ppc/translate/vsx-impl.inc.c >> > b/target-ppc/translate/vsx-impl.inc.c >> > index eee

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Cornelia Huck
On Fri, 16 Sep 2016 16:45:06 +0100 Peter Maydell wrote: > On 16 September 2016 at 16:39, Daniel P. Berrange wrote: > > On Fri, Sep 16, 2016 at 03:47:37PM +0100, Peter Maydell wrote: > >> On 16 September 2016 at 14:55, Laurent Vivier wrote: > >> > This series is the result of coccinelle patch >

Re: [Qemu-devel] [PATCH v2] virtio: add check for descriptor's mapped address

2016-09-19 Thread Laszlo Ersek
On 09/19/16 11:06, P J P wrote: > From: Prasad J Pandit > > virtio back end uses set of buffers to facilitate I/O operations. > If its size is too large, 'cpu_physical_memory_map' could return > a null address. This would result in a null dereference while > un-mapping descriptors. Add check to a

[Qemu-devel] [PATCH] qemu-options.hx: fix -chardev ringbuf typos

2016-09-19 Thread Stefan Hajnoczi
Clean up the documentation for -chardev ringbuf. There is a stray closing parenthesis and the comma is unnecessary. Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 0b621bb..094733d 100

Re: [Qemu-devel] [PULL v4 0/2] virtio: fixes

2016-09-19 Thread Peter Maydell
On 16 September 2016 at 19:55, Michael S. Tsirkin wrote: > The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56: > > fpu: add mechanism to check for invalid long double formats (2016-09-15 > 12:43:18 +0100) > > are available in the git repository at: > > git://git.kerne

Re: [Qemu-devel] [PATCH] qemu-options.hx: fix -chardev ringbuf typos

2016-09-19 Thread Marc-André Lureau
On Mon, Sep 19, 2016 at 2:56 PM, Stefan Hajnoczi wrote: > Clean up the documentation for -chardev ringbuf. There is a stray > closing parenthesis and the comma is unnecessary. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-André Lureau > --- > qemu-options.hx | 2 +- > 1 file changed,

Re: [Qemu-devel] [PATCH 16/26] s390: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-19 Thread Cornelia Huck
On Fri, 16 Sep 2016 15:56:07 +0200 Laurent Vivier wrote: > This patch is the result of coccinelle script > scripts/coccinelle/exit.cocci As stated in my other reply, I'm not convinced that this conversion is useful, but I did take a look at the exit()s we have in here: > > Signed-off-by: Laure

Re: [Qemu-devel] [s390] possible deadlock in handle_sigp?

2016-09-19 Thread David Hildenbrand
> On 09/15/2016 09:21 PM, David Hildenbrand wrote: > >> On 09/12/2016 08:03 PM, Paolo Bonzini wrote: > >>> > >>> > >>> On 12/09/2016 19:37, Christian Borntraeger wrote: > On 09/12/2016 06:44 PM, Paolo Bonzini wrote: > > I think that two CPUs doing reciprocal SIGPs could in princi

Re: [Qemu-devel] [PATCH 2/2] target-mips: reimplement SC instruction and use cmpxchg

2016-09-19 Thread Leon Alrae
On Fri, Sep 16, 2016 at 09:48:51AM -0700, Richard Henderson wrote: > On 09/15/2016 01:44 AM, Leon Alrae wrote: > > /* Store conditional */ > >+static void gen_st_cond(DisasContext *ctx, int rt, int base, int offset, > >+int size) > > { > >+TCGv addr, t0, val; > >+TCG

Re: [Qemu-devel] [PULL v2 0/8] Block layer patches

2016-09-19 Thread Peter Maydell
On 17 September 2016 at 23:05, Max Reitz wrote: > The following changes since commit e3571ae30cd26d19efd4554c25e32ef64d6a36b3: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160916' into > staging (2016-09-16 16:54:50 +0100) > > are available in the git repository at: > > git:/

[Qemu-devel] [PULL v1 2/8] crypto: make PBKDF iterations configurable for LUKS format

2016-09-19 Thread Daniel P. Berrange
As protection against bruteforcing passphrases, the PBKDF algorithm is tuned by counting the number of iterations needed to produce 1 second of running time. If the machine that the image will be used on is much faster than the machine where the image is created, it can be desirable to raise the nu

[Qemu-devel] [PULL v1 4/8] crypto: use correct derived key size when timing pbkdf

2016-09-19 Thread Daniel P. Berrange
Currently when timing the pbkdf algorithm a fixed key size of 32 bytes is used. This results in inaccurate timings for certain hashes depending on their digest size. For example when using sha1 with aes-256, this causes us to measure time for the master key digest doing 2 sha1 operations per iterat

[Qemu-devel] [PULL v1 3/8] crypto: clear out buffer after timing pbkdf algorithm

2016-09-19 Thread Daniel P. Berrange
The 'out' buffer will hold a key derived from master password, so it is best practice to clear this buffer when no longer required. At this time, the code isn't worrying about locking buffers into RAM to prevent swapping sensitive data to disk. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Be

[Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic v6->v7: - Rebased to the latest code. - Patch 1/1 expanded to act on alpha and sh4. - Naming in patch 4/7 synced with kernel naming. - Change code style of patch 5/7. - Corrected spelling in all patches. v5->v6: - Corrected two instances of wrong field typ

[Qemu-devel] [PULL v1 8/8] crypto: add trace points for TLS cert verification

2016-09-19 Thread Daniel P. Berrange
It is very useful to know about TLS cert verification status when debugging, so add a trace point for it. Signed-off-by: Daniel P. Berrange --- crypto/tlssession.c | 10 -- crypto/trace-events | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/crypto/tlssession.c b/cr

Re: [Qemu-devel] [s390] possible deadlock in handle_sigp?

2016-09-19 Thread Christian Borntraeger
On 09/19/2016 01:25 PM, David Hildenbrand wrote: [...] >> >> We only do the slow path things in QEMU. Maybe we could just have one lock >> that >> we trylock and return a condition code of 2 (busy) if we fail. That seems >> the >> most simple solution while still being architecturally correct. S

[Qemu-devel] [PULL v1 0/8] Merge qcrypto 2016/09/19

2016-09-19 Thread Daniel P. Berrange
The following changes since commit 0f2fa73ba0ca19ebdaccf0d1785583d6601411b6: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-19 11:23:20 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2016-09-19-1 for you t

[Qemu-devel] [PATCH v7 7/7] linux-user: Add missing Mips syscalls items in strace.list

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Without this patch, a number of Mips syscalls will be logged in the following way (in this example, this is an invocation of accept4()): 86906 Unknown syscall 4334 This patch provides standard Qemu's strace output for such cases, like this: 95861 accept4(3,1996486

[Qemu-devel] [PATCH v7 2/7] linux-user: Fix TARGET_F_GETOWN definition for Mips

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic For some reason, Qemu's TARGET_F_GETOWN constant for Mips does not match the correct value of correspondent F_GETOWN. This patch fixes this problem. For reference, see Mips' F_GETOWN definition in Linux kernel at arch/mips/include/uapi/asm/fcntl.h#L44. This patch also

[Qemu-devel] [PULL v1 1/8] crypto: use uint64_t for pbkdf iteration count parameters

2016-09-19 Thread Daniel P. Berrange
The qcrypto_pbkdf_count_iters method uses a 64 bit int but then checks its value against INT32_MAX before returning it. This bounds check is premature, because the calling code may well scale the iteration count by some value. It is thus better to return a 64-bit integer and let the caller do range

Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests

2016-09-19 Thread Marc-André Lureau
Hi Pranith On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar wrote: > Hello, > > This patch series cleans up the tcg tests in tests/tcg folder. > > Incidentally, I was also looking at reorganizing tests/tcg last week. I think your series brings some necessary improvements, but it will probably need

[Qemu-devel] [PATCH v7 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch fixes wrong definition of TARGET_SIOCATMARK for mips, alpha, and sh4. The current definition is: #define SIOCATMARK 0x8905 while the correct definition is: #define SIOCATMARK TARGET_IOR('s', 7, int) See Linux kernel source file arch/mips/inc

[Qemu-devel] [PULL v1 5/8] crypto: remove bogus /= 2 for pbkdf iterations

2016-09-19 Thread Daniel P. Berrange
When calculating iterations for pbkdf of the key slot data, we had a /= 2, which was copied from identical code in cryptsetup. It was always unclear & undocumented why cryptsetup had this division and it was recently removed there, too. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange -

[Qemu-devel] [PATCH v13 4/6] qapi: rename QmpOutputVisitor to QObjectOutputVisitor

2016-09-19 Thread Daniel P. Berrange
The QmpOutputVisitor has no direct dependency on QMP. It is valid to use it anywhere that one wants a QObject. Rename it to better reflect its functionality as a generic QAPI to QObject converter. Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- block/qapi.

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-19 Thread Markus Armbruster
This is about QOM use. Cc: Andreas in case he has smart ideas. Andreas, you may want to skip ahead to "EnumProperty". "Lin Ma" writes: Markus Armbruster 2016/9/12 星期一 下午 11:42 >>> >>Lin Ma writes: >> >>> '-object help' prints available user creatable backends. >>> '-object $typename,help

[Qemu-devel] [PATCH v7 3/7] linux-user: Fix structure target_flock definition for Mips

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure flock is defined for Mips in a way different from any other platform. For reference, see Linux kernel source code files: arch/mips/include/uapi/asm/fcntl.h, line 63 (for Mips) include/uapi/asm-generic/fcntl.h, line 195 (for all other platforms) This patch fix

[Qemu-devel] [PULL v1 7/8] crypto: support more hash algorithms for pbkdf

2016-09-19 Thread Daniel P. Berrange
Currently pbkdf is only supported with SHA1 and SHA256. Expand this to support all algorithms known to QEMU. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- crypto/pbkdf-gcrypt.c | 12 - crypto/pbkdf-nettle.c | 63 --- te

[Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object

2016-09-19 Thread Daniel P. Berrange
The current -object command line syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way t

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Mon, Sep 19, 2016 at 10:54:49AM +0100, Daniel P. Berrange wrote: > > On Mon, Sep 19, 2016 at 11:18:05AM +0200, Markus Armbruster wrote: > > > "Daniel P. Berrange" writes: > > > > > > > On Wed, Sep 14, 2016 at 11:30:06AM +0100, Dr. David Alan

[Qemu-devel] [PULL v1 6/8] crypto: increase default pbkdf2 time for luks to 2 seconds

2016-09-19 Thread Daniel P. Berrange
cryptsetup recently increased the default pbkdf2 time to 2 seconds to partially mitigate improvements in hardware performance wrt brute-forcing the pbkdf algorithm. This updates QEMU defaults to match. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- crypto/block-luks.c | 2 +- qap

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2016 at 10:54:49AM +0100, Daniel P. Berrange wrote: > On Mon, Sep 19, 2016 at 11:18:05AM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Sep 14, 2016 at 11:30:06AM +0100, Dr. David Alan Gilbert wrote: > > >> * Markus Armbruster (arm...@redhat.com

[Qemu-devel] [PATCH v7 4/7] linux-user: Fix structure target_semid64_ds definition for Mips

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch corrects target_semid64_ds structure definition for Mips. See, for example definition of semid64_ds for Mips in Linux kernel: arch/mips/include/uapi/asm/sembuf.h#L13. This patch will also fix certain semaphore-related LTP tests for Mips, if they are executed

[Qemu-devel] [PATCH v13 0/6] QAPI/QOM work for non-scalar object properties

2016-09-19 Thread Daniel P. Berrange
This patch series contains only the QAPI/QOM bits of my previous access control patch series: v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03

[Qemu-devel] [PATCH v7 5/7] linux-user: Fix certain argument alignment cases for Mips64

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic The function that is changed in this patch is supposed to indicate that there was certain argument rearrangement related to 64-bit arguments on 32-bit platforms. The background on such rearrangements can be found, for example, in the man page for syscall(2). However, fo

[Qemu-devel] [PATCH v13 2/6] option: make parse_option_bool/number non-static

2016-09-19 Thread Daniel P. Berrange
The opts-visitor.c opts_type_bool() method has code for parsing a string to set a bool value, as does the qemu-option.c parse_option_bool() method, except it handles fewer cases. To enable consistency across the codebase, extend parse_option_bool() to handle "yes", "no", "y" and "n", and make it n

Re: [Qemu-devel] [PATCH v2 1/6] Pass generic CPUState to gen_intermediate_code()

2016-09-19 Thread Lluís Vilanova
Richard Henderson writes: > On 09/09/2016 06:03 AM, Lluís Vilanova wrote: >> -void gen_intermediate_code(CPUAlphaState *env, struct TranslationBlock *tb) >> +void gen_intermediate_code(CPUState *cpu, struct TranslationBlock *tb) >> { >> -AlphaCPU *cpu = alpha_env_get_cpu(env); >> -CPUState

[Qemu-devel] [PATCH v7 6/7] linux-user: Add missing TARGET_EDQUOT error code for Mips

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic EDQUOT is defined for Mips platform in Linux kernel in such a way that it has different value than on most other platforms. However, correspondent TARGET_EDQUOT for Mips is missing in Qemu code. Moreover, TARGET_EDQUOT is missing from the table for conversion of error co

  1   2   3   4   5   >