Re: [Qemu-devel] [PATCH] 9pfs: fix potential segfault during walk

2016-09-16 Thread Greg Kurz
On Fri, 16 Sep 2016 01:05:11 +0200 Greg Kurz wrote: > If the call to fid_to_qid() returns an error, we will call v9fs_path_free() > on uninitialized paths. > I'll add this to the changelog: It is a regression introduced by the following commit: 56f101ecce0e 9pfs: handle walk of ".." in the ro

Re: [Qemu-devel] [PATCH v2 1/2] xen_platform: unplug also SCSI disks

2016-09-16 Thread Olaf Hering
On Wed, Sep 14, Stefano Stabellini wrote: > Written like this, the code will unplug any Xen SCSI disks together with > Xen IDE disks when the guest writes "1" to ioport `0x10`. I am sorry to > be pedantic, but the recent changes introduced to > docs/misc/hvm-emulated-unplug.markdown do not cover a

Re: [Qemu-devel] [PATCH v2 06/10] replay: vmstate for replay module

2016-09-16 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 15/09/2016 11:01, Pavel Dovgalyuk wrote: > > This patch introduces vmstate for replay data structures. > > It allows saving and loading vmstate while replaying. > > > > Signed-off-by: Pavel Dovgalyuk > > ---

Re: [Qemu-devel] [PATCH] 9pfs: fix potential segfault during walk

2016-09-16 Thread Cédric Le Goater
On 09/16/2016 09:19 AM, Greg Kurz wrote: > On Fri, 16 Sep 2016 01:05:11 +0200 > Greg Kurz wrote: > >> If the call to fid_to_qid() returns an error, we will call v9fs_path_free() >> on uninitialized paths. >> > > I'll add this to the changelog: > > It is a regression introduced by the following

Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-09-16 Thread Olaf Hering
On Wed, Sep 14, Stefano Stabellini wrote: > The doc says: > > "If VMDP was configured to control just NIC devices it would write the > value 0x1 to offset 0x8. If VMDP was configured to control just storage > devices it would write the value 0x2 to offset 0x8." > > So 0x1 to 0x8 to unplug NICs,

[Qemu-devel] [Bug 1611979] Re: GTK+ interface, backspace is broken in the monitor console

2016-09-16 Thread T. Huth
Fix has been picked up into the repository now: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=344aa283b89bec2af9761 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [Qemu-devel] [PATCH v2 02/10] block: set snapshot option for block devices in blkreplay module

2016-09-16 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 15/09/2016 11:00, Pavel Dovgalyuk wrote: > > diff --git a/docs/replay.txt b/docs/replay.txt > > index 347b2ff..5be8f25 100644 > > --- a/docs/replay.txt > > +++ b/docs/replay.txt > > @@ -196,6 +196,14 @@ is recorded to the log. In replay phase

Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state

2016-09-16 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 15/09/2016 11:01, Pavel Dovgalyuk wrote: > > +{ > > +if (replay_mode == REPLAY_MODE_RECORD) { > > +QDict *opts = qdict_new(); > > +qdict_put(opts, "name", qstring_from_str("replay_init")); > > +hmp_savevm(cur_mon, o

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-16 Thread Igor Mammedov
On Thu, 15 Sep 2016 18:18:46 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote: > > On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote: > > > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend > > > PC_COMPAT_2_6 to include PC_COMPAT

Re: [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

2016-09-16 Thread Igor Mammedov
On Thu, 15 Sep 2016 11:23:47 -0300 Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 12:01:50PM +0200, Igor Mammedov wrote: > > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > > misplaced compat property putting it in new 2.8 machine type > > which would effectively to di

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: > On 09/15/2016 07:09 PM, Kevin Wolf wrote: > > Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: > >> This mode could be very useful for flush bottlenecks evaluation and for > >> running non-persistent VMs, when host crash is considered n

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Kevin Wolf
Am 16.09.2016 um 10:15 hat Denis V. Lunev geschrieben: > On 09/16/2016 11:08 AM, Kevin Wolf wrote: > > Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: > >> On 09/15/2016 07:09 PM, Kevin Wolf wrote: > >>> Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: > This mode could be very us

Re: [Qemu-devel] [PATCH RESEND v2 15/17] target-ppc: add lxvb16x and lxvh8x

2016-09-16 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Sep 12, 2016 at 12:11:44PM +0530, Nikunj A Dadhania wrote: >> lxvb16x: Load VSX Vector Byte*16 >> lxvh8x: Load VSX Vector Halfword*8 >> >> Signed-off-by: Nikunj A Dadhania >> --- >> target-ppc/helper.h | 1 + >> ta

Re: [Qemu-devel] [PATCH RESEND v2 17/17] target-ppc: add stxvb16x and stxvh8x

2016-09-16 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Sep 12, 2016 at 12:11:46PM +0530, Nikunj A Dadhania wrote: >> stxvb16x: Store VSX Vector Byte*16 >> stxvh8x: Store VSX Vector Halfword*8 >> >> Signed-off-by: Nikunj A Dadhania > > Basically the same comments as on the load side - th

Re: [Qemu-devel] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-16 Thread Kevin Wolf
Am 16.09.2016 um 01:42 hat John Snow geschrieben: > One more try. > > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may or may not need to be flushed. > > This is likely the simplest soluti

[Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-16 Thread Pradeep Jagadeesh
Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev devices. Signed-off-by: Pradeep Jagadeesh --- fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 ++ fsdev/qemu-fsdev-throttle.c | 191 +

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Michael Fritscher
Am 15.09.2016 um 19:21 schrieb Programmingkid: There has been talk about what resolutions to add support for in the VGA driver. What do you think of this list: 512x342 640x400 640x480 800x600 1024x600 1024x640 1152x864 1200x700 1280x720 1280x768 1280x800 1366x768 1440x900 1920x1200 2304x1440 25

Re: [Qemu-devel] [PATCH 1/1] tests: allow to specify list of formats to test for check-block.sh

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 18:42 hat Denis V. Lunev geschrieben: > This would make code better and allow to test specific format. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Denis V. Lunev
On 09/16/2016 11:08 AM, Kevin Wolf wrote: > Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: >> On 09/15/2016 07:09 PM, Kevin Wolf wrote: >>> Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: This mode could be very useful for flush bottlenecks evaluation and for running non-pe

Re: [Qemu-devel] [PATCH] hmp: Remove dead code in hmp_qemu_io()

2016-09-16 Thread Marc-André Lureau
On Thu, Sep 15, 2016 at 7:50 PM Kevin Wolf wrote: > blk can never be NULL, drop the check. This fixes a Coverity warning. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-André Lureau > --- > hmp.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/hmp

Re: [Qemu-devel] [PATCH] 9pfs: fix potential segfault during walk

2016-09-16 Thread Greg Kurz
On Fri, 16 Sep 2016 09:37:48 +0200 Cédric Le Goater wrote: > On 09/16/2016 09:19 AM, Greg Kurz wrote: > > On Fri, 16 Sep 2016 01:05:11 +0200 > > Greg Kurz wrote: > > > >> If the call to fid_to_qid() returns an error, we will call v9fs_path_free() > >> on uninitialized paths. > >> > > > > I

Re: [Qemu-devel] [PATCH v2 07/10] replay: allow replay stopping and restarting

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 08:35, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> On 15/09/2016 11:01, Pavel Dovgalyuk wrote: >>> This patch fixes bug with stopping and restarting replay >>> through monitor. >>> >>> Signed-off-by: Pavel Dovgalyu

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Benjamin Herrenschmidt
On Fri, 2016-09-16 at 10:37 +0200, Michael Fritscher wrote: >  > I assume that you left out the common CGA/EGA resolution > intentionally? It's not because a resolution exists somewhere that we need it in the driver's menu :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-09-16 Thread Namhyung Kim
Hello Michael, Thanks for your detailed review. Btw are you ok with the overall direction of the patch? On Tue, Sep 13, 2016 at 06:19:41PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the psto

Re: [Qemu-devel] [PATCH v2 02/10] block: set snapshot option for block devices in blkreplay module

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 09:55, Pavel Dovgalyuk wrote: >> Since you have to create >> overlay.qcow2 outside QEMU anyway, overlay.qcow2 might as well be the >> "image". That is, you could choose between: >> >>-drive driver=blkreplay,if=none,image=overlay.qcow2,id=img-blkreplay \ >>-rr snapshot=repla

Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 09:56, Pavel Dovgalyuk wrote: >>> > > +{ >>> > > +if (replay_mode == REPLAY_MODE_RECORD) { >>> > > +QDict *opts = qdict_new(); >>> > > +qdict_put(opts, "name", qstring_from_str("replay_init")); >>> > > +hmp_savevm(cur_mon, opts); >>> > > +QDECREF(

Re: [Qemu-devel] [PATCH] 9pfs: fix potential segfault during walk

2016-09-16 Thread Cédric Le Goater
On 09/16/2016 10:52 AM, Greg Kurz wrote: > On Fri, 16 Sep 2016 09:37:48 +0200 > Cédric Le Goater wrote: > >> On 09/16/2016 09:19 AM, Greg Kurz wrote: >>> On Fri, 16 Sep 2016 01:05:11 +0200 >>> Greg Kurz wrote: >>> If the call to fid_to_qid() returns an error, we will call v9fs_path_free(

Re: [Qemu-devel] [PATCH v2 02/10] block: set snapshot option for block devices in blkreplay module

2016-09-16 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 16/09/2016 09:55, Pavel Dovgalyuk wrote: > >> Since you have to create > >> overlay.qcow2 outside QEMU anyway, overlay.qcow2 might as well be the > >> "image". That is, you could choose between: > >> > >>

Re: [Qemu-devel] [PATCH v2 02/10] block: set snapshot option for block devices in blkreplay module

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 11:36, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> On 16/09/2016 09:55, Pavel Dovgalyuk wrote: Since you have to create overlay.qcow2 outside QEMU anyway, overlay.qcow2 might as well be the "image".

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-09-16 Thread Namhyung Kim
On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:43PM +0900, Namhyung Kim wrote: > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by pstore device > > option. > > > >

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Michael Fritscher
Am 16.09.2016 um 10:56 schrieb Benjamin Herrenschmidt: On Fri, 2016-09-16 at 10:37 +0200, Michael Fritscher wrote: I assume that you left out the common CGA/EGA resolution intentionally? It's not because a resolution exists somewhere that we need it in the driver's menu :-) Cheers, Ben. H

Re: [Qemu-devel] [PATCH v5 3/5] linux-user: Fix structure target_flock definition for Mips

2016-09-16 Thread Aleksandar Markovic
You are correct. This is going to be fixed in v6, which will appear soon. Thanks! Aleksandar From: Leon Alrae Sent: Thursday, September 15, 2016 2:51 AM To: Aleksandar Markovic Cc: qemu-devel@nongnu.org; riku.voi...@iki.fi; peter.mayd...@linaro.org; aurel

Re: [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework

2016-09-16 Thread Laurent Vivier
On 16/09/2016 05:04, David Gibson wrote: > On Thu, Sep 15, 2016 at 10:09:34AM +1000, David Gibson wrote: >> On Wed, Sep 14, 2016 at 08:48:22PM +0200, Laurent Vivier wrote: >>> Define and use trace_spapr_XXX functions instead of >>> DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_

Re: [Qemu-devel] [PULL 0/1] VFIO fixes 2016-09-15

2016-09-16 Thread Peter Maydell
On 15 September 2016 at 19:24, Alex Williamson wrote: > The following changes since commit 9f16390cd3cdd85fa20739f07120f4d697c11837: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160914-1' into > staging (2016-09-15 14:56:36 +0100) > > are available in the git repository at: >

[Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-16 Thread Nikunj A Dadhania
Load 8byte at a time and manipulate. Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 5 + target-ppc/translate/vsx-impl.inc.c | 19 +-- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH v3 0/5] POWER9 TCG enablements - part4(pending)

2016-09-16 Thread Nikunj A Dadhania
This series contains 4 new instructions for POWER9 ISA3.0 Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x. Patches: 01: darn: Deliver a random number 02: lxvw4x - improve implementation 03: stxv4x - improve implementation 04: lxvh8x: Load VSX Vector Halfw

[Qemu-devel] [PATCH v3 1/5] target-ppc: implement darn instruction

2016-09-16 Thread Nikunj A Dadhania
From: Ravi Bangoria darn: Deliver A Random Number Currently return invalid random number for all the case. This needs proper algorithm to provide cryptographically suitable random data. Reading from /dev/random can block and that is not an expected behaviour while the cpu instruction is getting

[Qemu-devel] [PATCH v3 3/5] target-ppc: improve stxvw4x implementation

2016-09-16 Thread Nikunj A Dadhania
Manipulate data and store 8bytes instead of 4bytes. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/target-ppc/translate/vsx-impl.inc.c b/target-ppc/translate/vsx-impl.inc.c index

[Qemu-devel] [PATCH v3 4/5] target-ppc: add lxvh8x and stxvh8x

2016-09-16 Thread Nikunj A Dadhania
lxvh8x: Load VSX Vector Halfword*8 stxvh8x: Store VSX Vector Halfword*8 Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 6 target-ppc/translate/vsx-impl.inc.c | 59 + target-ppc/tra

[Qemu-devel] [PATCH v3 5/5] target-ppc: add lxvb16x and stxvb16x

2016-09-16 Thread Nikunj A Dadhania
lxvb16x: Load VSX Vector Byte*16 stxvb16x: Store VSX Vector Byte*16 Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 55 + target-ppc/translate/vsx-ops.inc.c | 2 ++ 2 files changed, 57 insertions(+) diff --git a/target-ppc/transla

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Gerd Hoffmann
On Fr, 2016-09-16 at 08:06 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-15 at 13:21 -0400, Programmingkid wrote: > > There has been talk about what resolutions to add support for in the > > VGA driver. What do you think of this list: Which driver? Linux kernel driver just uses the kerne

Re: [Qemu-devel] [PULL v3 0/6] virtio,pci: fixes and updates

2016-09-16 Thread Peter Maydell
On 15 September 2016 at 21:38, Michael S. Tsirkin wrote: > The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56: > > fpu: add mechanism to check for invalid long double formats (2016-09-15 > 12:43:18 +0100) > > are available in the git repository at: > > git://git.kerne

[Qemu-devel] [PATCH v6 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic v5->v6: - Corrected two instances of wrong field type in the patch on target_flock. - Added a patch that corrects handling of EDQUOT error code for Mips. - Added a patch that adds missing Mips-related items in strace.list. v4->v5: - Commit messages improved.

[Qemu-devel] [PATCH v6 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch fixes wrong definition of TARGET_SIOCATMARK for Mips. The current definition is: #define SIOCATMARK 0x8905 while the correct definition is: #define SIOCATMARK TARGET_IOR('s', 7, int) See Linux kernel source file arch/mips/include/uapi/asm/so

[Qemu-devel] [PATCH v6 2/7] linux-user: Fix TARGET_F_GETOWN definition for Mips

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic For some reason, Qemu's TARGET_F_GETOWN constant for Mips does not match the correct value of correspondant F_GETOWN. This patch fixes this problem. For reference, see Mips' F_GETOWN definition in Linux kernel at arch/mips/include/uapi/asm/fcntl.h#L44. This patch also

[Qemu-devel] [PATCH v6 6/7] linux-user: Add missing TARGET_EDQUOT error code for Mips

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic EDQUOT is defined for Mips platform in Linux kernel in such a way that it has different value than on most other platforms. However, correspondant TARGET_EDQUOT for Mips is missing in Qemu code. Moreover, TARGET_EDQUOT is missing from the table for conversion of error co

[Qemu-devel] [PATCH v6 3/7] linux-user: Fix structure target_flock definition for Mips

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure flock is defined for Mips in a way different from any other platform. For reference, see Linux kernel source code files: arch/mips/include/uapi/asm/fcntl.h, line 63 (for Mips) include/uapi/asm-generic/fcntl.h, line 195 (for all other platforms) This patch fix

[Qemu-devel] [PATCH v6 5/7] linux-user: Fix certain argument alignment cases for Mips64

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic The function that is changed in this patch is supposed to indicate that there was certaing argument rearangement related to 64-bit arguments on 32-bit platforms. The background on such rearangements can be found, for example, in the man page for syscall(2). However, for

[Qemu-devel] [PATCH v6 4/7] linux-user: Fix structure target_semid64_ds definition for Mips

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch corrects target_semid64_ds structure definition for Mips. See, for example definition of semid64_ds for Mips in Linux kernel: arch/mips/include/uapi/asm/sembuf.h#L13. This patch will also fix certain semaphore-related LTP tests for Mips, if they are executed

[Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls items in strace.list

2016-09-16 Thread Aleksandar Markovic
From: Aleksandar Markovic Without this patch, a number of Mips syscalls will be logged in the following way (in this examople, this is an invocation of accept4()): 86906 Unknown syscall 4334 This patch provides standard Qemu's strace output for such cases, like this: 95861 accept4(3,199648

Re: [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

2016-09-16 Thread Eduardo Habkost
On Fri, Sep 16, 2016 at 10:08:30AM +0200, Igor Mammedov wrote: > On Thu, 15 Sep 2016 11:23:47 -0300 > Eduardo Habkost wrote: > > > On Wed, Sep 14, 2016 at 12:01:50PM +0200, Igor Mammedov wrote: > > > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > > > misplaced compat pr

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread G 3
On 9/16/16 4:37 AM, Michael Fritscher wrote: Am 15.09.2016 um 19:21 schrieb Programmingkid: There has been talk about what resolutions to add support for in the VGA driver. What do you think of this list: 512x342 640x400 640x480 800x600 1024x600 1024x640 1152x864 1200x700 1280x720 1280x768 12

[Qemu-devel] [Bug 1618431] Re: windows hangs after live migration with virtio

2016-09-16 Thread WOLI
When I set -rtc clock=vm the mig problem is solved, but what does this flag exactly? In the docu there is only " If you want to isolate the guest time from the host, you can set clock to "rt" instead. To even prevent it from progressing during suspension, you can set it to "vm"." what does t

Re: [Qemu-devel] [PATCH] kvm/apic: drop debugging

2016-09-16 Thread Eduardo Habkost
On Thu, Sep 15, 2016 at 06:05:51PM +0300, Michael S. Tsirkin wrote: > commit 78d6a05d2f69cbfa6e95f0a4a24a2c934969913b > ("x86/lapic: Load LAPIC state at post_load") > has some debugging leftovers. > > Drop them. > > Cc: Dr. David Alan Gilbert > Signed-off-by: Michael S. Tsirkin I have appl

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Benjamin Herrenschmidt
On Fri, 2016-09-16 at 12:13 +0200, Michael Fritscher wrote: > at least in Windows, the GUI doesn't display the CGA/EGA resolution, but  > the driver supports them and can be accessed via API. Some (rather old)  > games used that for example. For MacOS I wouldn't fret it. A lot of Apple monitors ha

Re: [Qemu-devel] Adding resolutions to the VGA driver

2016-09-16 Thread Benjamin Herrenschmidt
On Fri, 2016-09-16 at 12:58 +0200, Gerd Hoffmann wrote: > On Fr, 2016-09-16 at 08:06 +1000, Benjamin Herrenschmidt wrote: > > > > On Thu, 2016-09-15 at 13:21 -0400, Programmingkid wrote: > > > > > > There has been talk about what resolutions to add support for in the > > > VGA driver. What do you

Re: [Qemu-devel] [PATCH V3 0/2] Add option to configure guest vPMU

2016-09-16 Thread Andrea Bolognani
On Thu, 2016-09-15 at 01:04 -0400, Wei Huang wrote: > This patchset adds a pmu=[on/off] option to enable/disable vPMU support  > for guest VM. There are several reasons to justify this option. First, > vPMU can be problematic for cross-migration between different SoC as perf > counters are architec

[Qemu-devel] [Bug 1618431] Re: windows hangs after live migration with virtio

2016-09-16 Thread Dr. David Alan Gilbert
Hmm, I'd not tried that one; I don't think that should change the behaviour during normal running, but the behaviour on pause and interactions with things like host ntp clock syncing is probably different - how different I'd have to dig in a bit more. However, we've done two patches this week tha

[Qemu-devel] [PATCH v2 0/5] spapr: convert SPAPR devices to trace framework

2016-09-16 Thread Laurent Vivier
Define and use trace_spapr_XXX functions instead of DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_rtas, spapr_llan, spapr_vscsi. This allows to enable dynamically (instead of recompiling the source) the traces for these devices. Messages are close as possible as messages used by

[Qemu-devel] [PATCH v2 1/5] spapr_drc: convert to trace framework instead of DPRINTF

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake --- v2: - Remove blank line after the comment line in trace-events file - add Eric's R-b hw/ppc/spapr_drc.c | 54 - hw/ppc/trace-events | 21 + 2 files changed, 41 inse

[Qemu-devel] [PATCH v2 2/5] spapr_rtas: convert to trace framework instead of DPRINTF

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake --- v2: - Remove blank line after the comment line in trace-events file - add Eric's R-b hw/ppc/spapr_rtas.c | 30 -- hw/ppc/trace-events | 8 2 files changed, 16 insertions(+), 22 deletions(-) diff --g

[Qemu-devel] [PATCH v2 3/5] spapr_vio: convert to trace framework instead of DPRINTF

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake --- v2: - Remove blank line after the comment line in trace-events file - add Eric's R-b hw/ppc/spapr_vio.c | 17 +++-- hw/ppc/trace-events | 4 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/ppc/spapr_

[Qemu-devel] [PATCH v2 4/5] spapr_llan: convert to trace framework instead of DPRINTF

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake --- v2: - Remove blank line after the comment line in trace-events file - add Eric's R-b hw/net/spapr_llan.c | 61 ++--- hw/net/trace-events | 16 ++ 2 files changed, 41 insertions(

[Qemu-devel] [PATCH v2 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake --- v2: - fix spapr_vscsi with "ust" backend (limited number of arguments) - Remove blank line after the comment line in trace-events file - add Eric's R-b hw/scsi/spapr_vscsi.c | 88 +-- hw/sc

Re: [Qemu-devel] [PATCH v2 0/7] Add "read-only" to the options QDict

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 16:52 hat Alberto Garcia geschrieben: > This series adds "read-only" to the options QDict, fixing a > long-standing problem with the reopening code. > >[E] <- [D] <- [C] <- [B] <- [A] > > In a normal scenario, the active layer [A] is in read-write mode and > everything else i

Re: [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-16 Thread Peter Lieven
Am 06.09.2016 um 12:36 schrieb Kevin Wolf: Am 06.09.2016 um 12:12 hat Peter Maydell geschrieben: On 5 September 2016 at 19:13, Kevin Wolf wrote: The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: Open 2.8 development tree (2016-09-05 11:38:54 +0100) are available

Re: [Qemu-devel] [PATCH] net: limit allocation in nc_sendv_compat

2016-09-16 Thread Peter Lieven
Am 30.06.2016 um 15:39 schrieb Stefan Hajnoczi: On Thu, Jun 30, 2016 at 11:49:40AM +0200, Peter Lieven wrote: we only need to allocate enough memory to hold the packet. This might be less than NET_BUFSIZE. Additionally fail early if the packet is larger than NET_BUFSIZE. Signed-off-by: Peter Li

[Qemu-devel] [PATCH 19/26] alpha: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Richard Henderson --- hw/alpha/dp264.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index f1267b5..d533d2f 100644 ---

[Qemu-devel] [PATCH 24/26] error, trace: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Markus Armbruster --- trace/control.c | 10 +- util/error.c| 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/trace/control.c b/trace/control.c index 05

[Qemu-devel] [PATCH 02/26] arm: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Peter Maydell --- hw/arm/armv7m.c | 6 +++--- hw/arm/boot.c | 16 hw/arm/cubieboard.c | 8 hw/arm/digic_boards.c | 6 +++---

[Qemu-devel] [PATCH 25/26] hw: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- hw/display/ssd0303.c | 3 ++- hw/i2c/smbus.c| 3 ++- hw/moxie/moxiesim.c | 8 hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 2 +- 5 files changed, 10 insertio

[Qemu-devel] [PATCH 26/26] net: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Jason Wang --- net/net.c| 4 ++-- slirp/misc.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index d51cb29..0215618 100644 --- a/net/n

[Qemu-devel] [PATCH 09/26] qemu-user: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Riku Voipio --- bsd-user/main.c | 20 ++-- linux-user/main.c| 4 ++-- linux-user/syscall.c | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --

[Qemu-devel] [PATCH 14/26] x86: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Paolo Bonzini --- hw/i386/intel_iommu.c | 2 +- hw/i386/multiboot.c | 10 +- hw/i386/pc.c | 24 hw/i386/pc_piix.c | 2 +

[Qemu-devel] [PATCH 20/26] common: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Paolo Bonzini --- accel.c | 2 +- arch_init.c | 6 +- bootdevice.c | 2 +- contrib/ivshmem-server/main.c | 12 +- gdbstub

[Qemu-devel] [PATCH 03/26] cris: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Edgar E. Iglesias --- hw/cris/boot.c | 4 ++-- tests/tcg/cris/check_gcctorture_pr28634-1.c | 2 +- tests/tcg/cris/check_gcctorture_pr28634.c | 2 +- tests

[Qemu-devel] [PATCH 06/26] graphics: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Gerd Hoffmann --- ui/console-gl.c | 2 +- ui/console.c| 2 +- ui/curses.c | 4 ++-- ui/gtk.c| 2 +- ui/sdl.c| 8 ui/sdl2.c | 2 +- ui/spice-

[Qemu-devel] [PATCH 01/26] coccinelle: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- scripts/coccinelle/exit.cocci | 12 1 file changed, 12 insertions(+) create mode 100644 scripts/coccinelle/exit.cocci diff --git a/scripts/coccinelle/exit.cocci b/scripts/coccinelle/exit.cocci new file mode 100644 index 000..73386c0 --- /dev/nu

[Qemu-devel] [PATCH 04/26] block: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Max Reitz --- hw/block/pflash_cfi01.c | 2 +- hw/block/tc58128.c | 2 +- qemu-img.c | 4 ++-- qemu-io.c | 24 4 files changed

[Qemu-devel] [PATCH 17/26] tcg: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Richard Henderson --- cpus.c | 16 cputlb.c| 2 +- exec.c | 2 +- tcg/tcg.c | 2 +- translate-all.c | 2 +- 5 files changed, 12 inse

[Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This series is the result of coccinelle patch scripts/coccinelle/exit.cocci provided by the first patch of the series. It replaces exit(0) by exit(EXIT_SUCCESS) and exit(1) by exit(EXIT_FAILURE). All other exit() are not modified as we don't want to change the behavior. In some cases, I've added

[Qemu-devel] [PATCH 23/26] core: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Marcel Apfelbaum --- hw/core/machine.c | 2 +- hw/core/platform-bus.c | 4 ++-- hw/core/qdev.c | 2 +- numa.c | 12 ++-- 4 files changed, 10 inse

[Qemu-devel] [PATCH 05/26] ppc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: David Gibson --- device_tree.c | 18 hw/intc/xics_kvm.c | 6 +++--- hw/ppc/e500.c | 14 ++-- hw/ppc/mac_newworld.c |

[Qemu-devel] [PATCH 08/26] replay: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- replay/replay-char.c | 6 +++--- replay/replay-events.c | 6 +++--- replay/replay-internal.c | 2 +- replay/replay-time.c | 2 +- replay/replay.c | 14 +++-

[Qemu-devel] [PATCH 21/26] misc machine: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- hw/cris/axis_dev88.c | 2 +- hw/lm32/lm32_boards.c | 8 hw/lm32/milkymist.c| 6 +++--- hw/openrisc/openrisc_sim.c | 4 ++-- hw/tricore/tricore

[Qemu-devel] [PATCH 15/26] mips: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Leon Alrae --- hw/mips/mips_fulong2e.c | 12 ++-- hw/mips/mips_jazz.c | 10 +- hw/mips/mips_malta.c| 20 ++-- hw/mips/mips_mipssim.c | 10 +-

[Qemu-devel] [PATCH 22/26] blockdev: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: John Snow --- hw/ide/core.c| 2 +- hw/scsi/lsi53c895a.c | 7 --- hw/sd/ssi-sd.c | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/ide/core.c b

[Qemu-devel] [PATCH 12/26] sparc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Mark Cave-Ayland --- hw/sparc/leon3.c | 12 ++-- hw/sparc/sun4m.c | 22 +++--- hw/sparc64/sun4u.c | 8 3 files changed, 21 insertions(+), 21 deleti

[Qemu-devel] [PATCH 07/26] tests: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- tests/ipmi-bt-test.c | 6 +++--- tests/libqtest.c | 8 tests/migration/stress.c | 4 ++-- tests/qht-bench.c | 2 +- tests/rcutorture.c| 4 ++-

[Qemu-devel] [PATCH 11/26] pci, virtio: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Stefan Hajnoczi --- hw/9pfs/9p.c| 2 +- hw/block/virtio-blk.c | 6 +++--- hw/net/virtio-net.c | 10 +- hw/pci/pci.c

Re: [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916

2016-09-16 Thread Peter Maydell
On 16 September 2016 at 14:09, Greg Kurz wrote: > The following changes since commit 5f473241ac595452ae0638dc63e7af2a2294f5ec: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-09-15 18:12:40 +0100) > > are available in the git repository at: > > https:

[Qemu-devel] [PATCH 16/26] s390: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Cornelia Huck --- target-s390x/cpu.c| 2 +- target-s390x/kvm.c| 18 +- target-s390x/mmu_helper.c | 2 +- 3 files changed, 11 insertions(+), 11 deletion

[Qemu-devel] [PATCH 18/26] posix: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- os-posix.c | 34 +- util/oslib-posix.c | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/os-posix.c b/os-posix.c index c6d

[Qemu-devel] [PATCH 13/26] sh4: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Aurelien Jarno --- hw/sh4/r2d.c | 6 +++--- hw/sh4/shix.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c index db373c7..537ef52 10

Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474034177-17663-1-git-send-email-lviv...@redhat.com Subject: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH 03/26] cris: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Edgar E. Iglesias
On Fri, Sep 16, 2016 at 03:55:54PM +0200, Laurent Vivier wrote: > This patch is the result of coccinelle script > scripts/coccinelle/exit.cocci > > Signed-off-by: Laurent Vivier > CC: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias > --- > hw/cris/boot.c | 4 ++

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-16 Thread Peter Lieven
Am 13.09.2016 um 20:04 schrieb Michael Roth: Quoting Peter Lieven (2016-09-13 10:52:04) Am 13.09.2016 um 17:42 schrieb Stefan Hajnoczi : On Thu, Sep 08, 2016 at 03:58:26PM -0500, Michael Roth wrote: Quoting Stefan Hajnoczi (2016-09-05 12:54:35) On Fri, Aug 26, 2016 at 01:45:56PM +0200, Pete

[Qemu-devel] [PATCH 10/26] m68k: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

2016-09-16 Thread Laurent Vivier
This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier --- hw/m68k/an5206.c | 6 +++--- hw/m68k/dummy_m68k.c | 4 ++-- hw/m68k/mcf5208.c| 8 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/m68k/an5206.c b/hw/m6

Re: [Qemu-devel] [PULL 0/8] 9p patches for 2.8 20160916

2016-09-16 Thread Peter Maydell
On 16 September 2016 at 15:39, Greg Kurz wrote: > Ok, I'll look into it... but the important part in this pull request is > the "9pfs: fix potential segfault during walk" patch. It fixes a regression > introduced in 2.7 by the 9P security fixes. And IIUC, Michael Roth is about > to release 2.6.1.1

[Qemu-devel] [PATCH] RFC: linux-user-i386: crash on cpuid

2016-09-16 Thread Marc-André Lureau
Running cpuid instructions with a simple run like: i386-linux-user/qemu-i386 tests/tcg/sha1-i386 Results in the following assert: #0 0x764246f5 in raise () from /lib64/libc.so.6 #1 0x764262fa in abort () from /lib64/libc.so.6 #2 0x77937ec5 in g_assertion_message () fr

  1   2   3   >