Re: [Qemu-devel] [PATCH for-2.7] vnc: fix qemu crash because of SIGSEGV

2016-09-09 Thread Gonglei (Arei)
Hi Gerd, Can you pls pick up this patch? thanks Regards, -Gonglei > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Friday, September 02, 2016 8:39 PM > To: Marc-André Lureau > Cc: Gonglei (Arei); QEMU Developers; Huangweidong (C); Gerd Hoffmann > Subj

Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-09-09 Thread Gonglei (Arei)
Who can pick up this patch? Dmitry or Jason? Thanks! Regards, -Gonglei > -Original Message- > From: Dmitry Fleytman [mailto:dmi...@daynix.com] > Sent: Wednesday, August 31, 2016 8:59 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; berra...@redhat.com > Subject: Re: [PATCH v2 2/2] e

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Greg Kurz
On Fri, 09 Sep 2016 08:38:13 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Thu, 8 Sep 2016 18:19:27 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > >> > On Thu, 8 Sep 2016 18:00:28 +0300 > >> > "Michael S. Tsirki

Re: [Qemu-devel] [PULL 34/38] qmp: add QMP interface "query-cpu-model-comparison"

2016-09-09 Thread Christian Borntraeger
On 09/08/2016 04:12 PM, Eric Blake wrote: > On 09/06/2016 02:47 AM, Cornelia Huck wrote: >> From: David Hildenbrand >> >> Let's provide a standardized interface to compare two CPU models. >> "query-cpu-model-compare" takes two models and returns how they compare >> in a specific configuration. >>

[Qemu-devel] [PATCH] usb-host: fix streams detection in usb_host_speed_compat

2016-09-09 Thread Gerd Hoffmann
The companion descriptor is present on all usb3 devices, not only those with streams support. We need to check attributes to see whenever the device uses streams or not. Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

2016-09-09 Thread Greg Kurz
As with other virtio-* qtests, PC platform is assumed. --- Greg Kurz (3): tests: virtio-9p: introduce start/stop functions tests: virtio-9p: add basic configuration test tests: virtio-9p: add basic transaction test tests/Makefile.include |2 - tests/virtio-9p-test.c | 17

[Qemu-devel] [PATCH 1/3] tests: virtio-9p: introduce start/stop functions

2016-09-09 Thread Greg Kurz
First step to be able to run several functional steps. Signed-off-by: Greg Kurz --- tests/virtio-9p-test.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c index 1e39335a7945..ed53f21bc31

[Qemu-devel] [PATCH 2/3] tests: virtio-9p: add basic configuration test

2016-09-09 Thread Greg Kurz
This adds PCI init code and a basic test that checks the device config matches what is passed on the command line. Signed-off-by: Greg Kurz --- tests/Makefile.include |2 + tests/virtio-9p-test.c | 82 +++- 2 files changed, 81 insertions(+), 3 de

[Qemu-devel] [PATCH 3/3] tests: virtio-9p: add basic transaction test

2016-09-09 Thread Greg Kurz
This adds a simple test to validate the device is functional: it transmits a request with type Terror, which is not used by the 9P protocol [1], and expects QEMU to return a reply with type Rerror and the "Operation not supported" error string. [1] http://lxr.free-electrons.com/source/include/net/

[Qemu-devel] [Bug 842290] Re: MIPS Malta mini-bootloader print function has bad jump instruction

2016-09-09 Thread T. Huth
Looks like this has been finally fixed by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7f81dbb9a0e89b53 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p

2016-09-09 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 147340827736.6462.8546871953640244651.stgit@bahia Subject: [Qemu-devel] [PATCH 0/3] tests: more test cases for virtio-9p === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP

2016-09-09 Thread Marc-André Lureau
On Fri, Sep 9, 2016 at 7:16 AM Eric Blake wrote: > Commit 69ef1f3 accidentally broke migrate_set_parameter's ability > to set the cpu-throttle-increment to anything other than the > default, because it forgot to parse the user's string into an > integer. > > CC: qemu-sta...@nongnu.org > Signed-of

Re: [Qemu-devel] [PATCH for-2.7] vnc: fix qemu crash because of SIGSEGV

2016-09-09 Thread Gerd Hoffmann
On Fr, 2016-09-09 at 07:13 +, Gonglei (Arei) wrote: > Hi Gerd, > > Can you pls pick up this patch? thanks Added to UI queue, thanks. cheers, Gerd

Re: [Qemu-devel] [PATCH v9 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-09 Thread Zeng, Xin
On Thursday, September 08, 2016 6:05 PM, Gonglei Wrote: > +The below AEAD algorithms are defined currently: > + > +\begin{lstlisting} > +#define VIRTIO_CRYPTO_NO_AEAD 0 > +#define VIRTIO_CRYPTO_AEAD_GCM1 > +#define VIRTIO_CRYPTO_AEAD_CCM2 > +#define VIRTIO_CRYPTO_AEAD_CHACHA20_POLY1305

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Cornelia Huck
On Thu, 8 Sep 2016 19:55:16 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > > On Thu, 8 Sep 2016 18:19:27 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: > > > > On Thu, 8 Sep 2016 18

[Qemu-devel] [PATCH] MAINTAINERS: add virtio-* tests

2016-09-09 Thread Greg Kurz
Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix it, according to the following logic: - when the related subsystem has its own section in MAINTAINERS, the test is added there - otherwise it is added to the "parent" section (aka. SCSI, Network devices, virtio) Signed-o

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Greg Kurz
On Fri, 9 Sep 2016 10:30:53 +0200 Cornelia Huck wrote: > On Thu, 8 Sep 2016 19:55:16 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > > > On Thu, 8 Sep 2016 18:19:27 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu, Sep 08,

Re: [Qemu-devel] [PATCH] iothread: Stop threads before main() quits

2016-09-09 Thread Paolo Bonzini
> > Reviewed-by: Paolo Bonzini > > Thanks! Is there a coming PULL from you that this patch could sneak in? :) There is (next week), but iothread.c is one of those grey area of maintenance that I wouldn't mind passing to someone else. Such as the owner of block/io.c. :) Paolo

Re: [Qemu-devel] [PATCH v2] target-mips: generate fences

2016-09-09 Thread Leon Alrae
On Thu, Sep 08, 2016 at 10:04:05AM -0700, Richard Henderson wrote: > > +static void gen_sync(int stype) > > +{ > > +TCGOrder tcg_mo = TCG_BAR_SC; > > + > > +switch (stype) { > > +case 0x4: /* SYNC_WMB */ > > +tcg_mo |= TCG_MO_ST_ST; > > +break; > > +case 0x10: /* SYN

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 10:46:25 +0200 Greg Kurz wrote: > On Fri, 9 Sep 2016 10:30:53 +0200 > Cornelia Huck wrote: > > > On Thu, 8 Sep 2016 19:55:16 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Sep 08, 2016 at 06:26:52PM +0200, Greg Kurz wrote: > > > > On Thu, 8 Sep 2016 18:19:27 +030

[Qemu-devel] [PATCH v2] virtio-pci: error out when both legacy and modern modes are disabled

2016-09-09 Thread Greg Kurz
From: Greg Kurz Without presuming if we got there because of a user mistake or some more subtle bug in the tooling, it really does not make sense to implement a non-functional device. Signed-off-by: Greg Kurz Reviewed-by: Marcel Apfelbaum Reviewed-by: Cornelia Huck Signed-off-by: Greg Kurz -

Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct

2016-09-09 Thread Marc-André Lureau
On Fri, Sep 9, 2016 at 7:19 AM Eric Blake wrote: > It is rather verbose, and slightly error-prone, to repeat > the same set of parameters for input (migrate-set-parameters) > as for output (query-migrate-parameters), where the only > difference is whether the members are optional. We can just >

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Markus Armbruster
Greg Kurz writes: > On Fri, 09 Sep 2016 08:38:13 +0200 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > On Thu, 8 Sep 2016 18:19:27 +0300 >> > "Michael S. Tsirkin" wrote: >> > >> >> On Thu, Sep 08, 2016 at 05:04:47PM +0200, Cornelia Huck wrote: >> >> > On Thu, 8 Sep 2016 18:00:28

Re: [Qemu-devel] [PATCH 3/3] migrate: Use boxed qapi for migrate-set-parameters

2016-09-09 Thread Marc-André Lureau
On Fri, Sep 9, 2016 at 7:16 AM Eric Blake wrote: > Now that QAPI makes it easy to pass a struct around, we don't > have to declare as many parameters or local variables. > > Signed-off-by: Eric Blake > Reviewed-by: Marc-André Lureau > --- > qapi-schema.json | 2 +- > hmp.c

[Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Pradeep Jagadeesh
Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which use 9p-local driver. Signed-off-by: Pradeep Jagadeesh --- fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 52 + hw/9pfs/9p-local.c | 18 - hw/9pfs/9p-throttle.c | 201 ++

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-09-09 Thread Jan Kara
On Thu 08-09-16 14:47:08, Ross Zwisler wrote: > On Tue, Sep 06, 2016 at 05:06:20PM +0200, Jan Kara wrote: > > On Thu 01-09-16 20:57:38, Ross Zwisler wrote: > > > On Wed, Aug 31, 2016 at 04:44:47PM +0800, Xiao Guangrong wrote: > > > > On 08/31/2016 01:09 AM, Dan Williams wrote: > > > > > > > > > >

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Greg Kurz
On Fri, 9 Sep 2016 10:53:05 +0200 Cornelia Huck wrote: > On Fri, 9 Sep 2016 10:46:25 +0200 > Greg Kurz wrote: > > > On Fri, 9 Sep 2016 10:30:53 +0200 > > Cornelia Huck wrote: > > > > > On Thu, 8 Sep 2016 19:55:16 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu, Sep 08, 2016

Re: [Qemu-devel] [PATCH 6/6] crypto: support more hash algorithms for pbkdf

2016-09-09 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 12:57:38PM -0500, Eric Blake wrote: > On 09/08/2016 11:27 AM, Daniel P. Berrange wrote: > > Currently pbkdf is only supported with SHA1 and SHA256. Expand > > this to support all algorithms known to QEMU. > > > > Signed-off-by: Daniel P. Berrange > > --- > > crypto/pbkdf-

Re: [Qemu-devel] [PATCH 1/6] crypto: make PBKDF iterations configurable for LUKS format

2016-09-09 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 12:44:55PM -0500, Eric Blake wrote: > On 09/08/2016 11:27 AM, Daniel P. Berrange wrote: > > As protection against bruteforcing passphrases, the PBKDF > > algorithm is tuned by counting the number of iterations > > needed to produce 1 second of running time. If the machine >

Re: [Qemu-devel] [PATCH 2/6] crypto: clear out buffer after timing pbkdf algorithm

2016-09-09 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 12:47:43PM -0500, Eric Blake wrote: > On 09/08/2016 11:27 AM, Daniel P. Berrange wrote: > > The 'out' buffer will hold a key derived from master > > password, so it is best practice to clear this buffer > > when no longer required. > > > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Greg Kurz
On Fri, 9 Sep 2016 11:26:17 +0200 Greg Kurz wrote: > > > > Stefan had already sent > > <1460467534-29147-4-git-send-email-stefa...@redhat.com> ages ago, but > > it has not yet made it anywhere... > > > > I don't know what to do with this message-id :\ I finally found :) +message-id:<146046

Re: [Qemu-devel] [PATCH v9 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-09 Thread Gonglei (Arei)
Hi Xin, Will fix in the next version, thanks! Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Friday, September 09, 2016 4:26 PM > To: Gonglei (Arei); qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: Huangpeng (Peter); Luonengjun;

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-09 Thread Greg Kurz
On Fri, 09 Sep 2016 11:08:56 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Fri, 09 Sep 2016 08:38:13 +0200 > > Markus Armbruster wrote: > > > >> Greg Kurz writes: > >> > >> > On Thu, 8 Sep 2016 18:19:27 +0300 > >> > "Michael S. Tsirkin" wrote: > >> > > >> >> On Thu, Se

[Qemu-devel] [PATCH RFC] exec: remove duplicate madvise to QEMU_MADV_DONTFORK

2016-09-09 Thread Cao jin
kvm_setup_guest_memory() also just does "madivse to QEMU_MADV_DONTFORK". Signed-off-by: Cao jin --- Though I don't understand these code well, tt seems is duplicate code to me. But I am not sure whether I am doing the right thing, so, RFC. exec.c | 3 --- 1 file changed, 3 deletions(-) diff -

Re: [Qemu-devel] [PULLv2 00/25] Leak patches

2016-09-09 Thread Peter Maydell
On 8 September 2016 at 15:16, Marc-André Lureau wrote: > The following changes since commit 59351d9b40b1de0fb77e1ff3e53faa04c995c707: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20160907' > into staging (2016-09-08 11:28:12 +0100) > > are available in the git repository a

[Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Maxime Coquelin
This patch adds virtio_test_backend_feature() function to enable checking a backend feature before the negociation takes place. It may be used, for example, to check whether the backend supports VIRTIO_F_VERSION_1 before enabling modern capabilities. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin

[Qemu-devel] [PATCH 0/2] virtio-pci: Improve device plugging whith legacy backends

2016-09-09 Thread Maxime Coquelin
This series makes device plugging more robust, to avoid guest to be confused when the backend doesn't support VIRTIO_F_VERSION_1. The problem is seen with Linux guests running mainline kernels, when backend doesn't support the feature: virtio_net virtio0: virtio: device uses modern interface but d

[Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Maxime Coquelin
This patch makes pci devices plugging more robust, by not confusing guest with modern interface when the backend doesn't support VIRTIO_F_VERSION_1. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Cc: qemu-sta...@nongnu.org Signed-off-by: Maxime Coquelin --- hw/virtio/virtio-pci.c | 15 +++

[Qemu-devel] [Bug 965327] Re: virtio-pci: can't reserve io 0x0000-0x001f

2016-09-09 Thread T. Huth
Closing according to comment #3 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/965327 Title: virtio-pci: can't reserve io 0x-0x001f Statu

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: > This patch adds virtio_test_backend_feature() function to > enable checking a backend feature before the negociation > takes place. > > It may be used, for example, to check whether the backend > supports VIRTIO_F_VERSION_1 before enabl

Re: [Qemu-devel] [PULL v2 0/4] target-arm queue

2016-09-09 Thread Peter Maydell
On 9 September 2016 at 07:50, Cédric Le Goater wrote: > Hello Peter, > > I have a little patchset fixing what you have asked for > regarding the RAM setting in Aspeed, but it depends on > the ast2500. So I suppose I should wait for the next > merge before sending ? I dropped those patches, so you

Re: [Qemu-devel] vxhs caching behaviour (was: [PATCH v4 RFC] block/vxhs: Initial commit to add) Veritas HyperScale VxHS block device support

2016-09-09 Thread Kevin Wolf
Am 08.09.2016 um 22:46 hat ashish mittal geschrieben: > Hi Kevin, > > By design, our writeback cache is on non-volatile SSD device. We do > async writes to this cache and also maintain a persistent index map of > the data written. This gives us the capability to recover write-back > cache if neede

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 12:14:32 +0200 Maxime Coquelin wrote: > This patch makes pci devices plugging more robust, by not confusing > guest with modern interface when the backend doesn't support > VIRTIO_F_VERSION_1. > > Cc: Marcel Apfelbaum > Cc: Michael S. Tsirkin > Cc: qemu-sta...@nongnu.org >

[Qemu-devel] [PATCH RFC v1 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

2016-09-09 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- target-ppc/cpu.h | 1 + target-ppc/helper_regs.h | 2 +- target-ppc/mmu-hash64.c | 4 ++-- target-ppc/mmu_helper.c | 6 +++--- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 1e808c8..7dc 1

[Qemu-devel] [PATCH RFC v1 3/3] target-ppc: tlbie should have global effect

2016-09-09 Thread Nikunj A Dadhania
tlbie (H_REMOVE, H_PROTECT and H_BULK_REMOVE for pseries) should have a global effect. Introduces TLB_NEED_GLOBAL_FLUSH flag. During delayed flush, once taking care of local flush, check broadcast flush(ptesync, tlbsync, etc) is needed. Depending on the bitmask state of the tlb_need_flush, tlb is

[Qemu-devel] [PATCH RFC v1 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-09 Thread Nikunj A Dadhania
The flag will be used to indicate whether broadcast tlb flush is needed or not. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_hcall.c | 4 ++-- target-ppc/excp_helper.c | 4 ++-- target-ppc/helper.h | 2 +- target-ppc/helper_regs.h | 4 ++-- target-ppc/mmu_helper.c | 4 ++-- t

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 01:33 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: This patch adds virtio_test_backend_feature() function to enable checking a backend feature before the negociation takes place. It may be used, for example, to check whether the backend supp

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 13:48:00 +0300 Marcel Apfelbaum wrote: > On 09/09/2016 01:33 PM, Cornelia Huck wrote: > > On Fri, 9 Sep 2016 12:14:31 +0200 > > Maxime Coquelin wrote: > > > >> This patch adds virtio_test_backend_feature() function to > >> enable checking a backend feature before the negociat

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 01:55 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 13:48:00 +0300 Marcel Apfelbaum wrote: On 09/09/2016 01:33 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:31 +0200 Maxime Coquelin wrote: This patch adds virtio_test_backend_feature() function to enable checking a backend

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > I previously split the global trace-events file up into one file >> > per-subdirectory to avoid merge conflict hell. >> [...] >> >> Sorry, I could not find the message

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 01:40 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:32 +0200 Maxime Coquelin wrote: This patch makes pci devices plugging more robust, by not confusing guest with modern interface when the backend doesn't support VIRTIO_F_VERSION_1. Cc: Marcel Apfelbaum Cc: Michael S. Tsir

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: > I was thinking to keep the same function proposed by Maxime and change it to > negate things: > > /* > * A missing feature before all negotiations finished will still be missing > at the end. > */ > bool virtio_test_backend_unsupp

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 14:04:55 +0300 Marcel Apfelbaum wrote: > On 09/09/2016 01:40 PM, Cornelia Huck wrote: > > On Fri, 9 Sep 2016 12:14:32 +0200 > > Maxime Coquelin wrote: > > > >> This patch makes pci devices plugging more robust, by not confusing > >> guest with modern interface when the backen

Re: [Qemu-devel] [PATCH RFC v1 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

2016-09-09 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote: > > Signed-off-by: Nikunj A Dadhania > --- >  target-ppc/cpu.h | 1 + >  target-ppc/helper_regs.h | 2 +- >  target-ppc/mmu-hash64.c  | 4 ++-- >  target-ppc/mmu_helper.c  | 6 +++--- >  4 files changed, 7 insertions(+), 6 deletions(-

Re: [Qemu-devel] [PATCH RFC v1 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-09 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote: > The flag will be used to indicate whether broadcast tlb flush is > needed > or not. > > Signed-off-by: Nikunj A Dadhania > --- >  hw/ppc/spapr_hcall.c |  4 ++-- >  target-ppc/excp_helper.c |  4 ++-- >  target-ppc/helper.h  |  2

[Qemu-devel] [PATCH 1/3] tests: add /vhost-user/connect-fail test

2016-09-09 Thread Marc-André Lureau
Check early connection failure and resume. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index b89a551..ab91e16 100644 --- a/tests/vhost-u

[Qemu-devel] [PATCH 0/3] vhost-user tests

2016-09-09 Thread Marc-André Lureau
Hi, The following tests have been post-poned for after 2.7 from the vhost-user-reconnect series. They have been rebased and fixed to work with last changes. Marc-André Lureau (3): tests: add /vhost-user/connect-fail test tests: add a simple /vhost-user/multiqueue test tests: add /vhost-use

[Qemu-devel] [PATCH 2/3] tests: add a simple /vhost-user/multiqueue test

2016-09-09 Thread Marc-André Lureau
This test just checks that 2 virtio-net queues can be setup over vhost-user and waits for them to be started. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 109 ++-- tests/Makefile.include | 2 +- 2 files changed, 107 insertions(+),

[Qemu-devel] [PATCH 3/3] tests: add /vhost-user/flags-mismatch test

2016-09-09 Thread Marc-André Lureau
Check that qemu disconnects the backend that doesn't have the previously acked features. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 60 - 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/te

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Maxime Coquelin
On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: I was thinking to keep the same function proposed by Maxime and change it to negate things: /* * A missing feature before all negotiations finished will still be missing at the end.

Re: [Qemu-devel] [PATCH RFC v1 3/3] target-ppc: tlbie should have global effect

2016-09-09 Thread Benjamin Herrenschmidt
On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote: > > +env->tlb_need_flush = TLB_NEED_GLOBAL_FLUSH | TLB_NEED_LOCAL_FLUSH; > check_tlb_flush(env th, 1); > Hrm... how did that work bore ? IE. check_tlb_flush won't do anything if tlb_need_flush is 0, isn't it already set elsewhere ?

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Maxime Coquelin
On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:04:55 +0300 Marcel Apfelbaum wrote: On 09/09/2016 01:40 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:32 +0200 Maxime Coquelin wrote: This patch makes pci devices plugging more robust, by not confusing guest with mod

Re: [Qemu-devel] [PATCH 1/2] virtio: Add backend feature testing functionnality

2016-09-09 Thread Marcel Apfelbaum
On 09/09/2016 02:36 PM, Maxime Coquelin wrote: On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:02:17 +0300 Marcel Apfelbaum wrote: I was thinking to keep the same function proposed by Maxime and change it to negate things: /* * A missing feature before all negotiation

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Cornelia Huck
On Fri, 9 Sep 2016 13:44:35 +0200 Maxime Coquelin wrote: > On 09/09/2016 01:20 PM, Cornelia Huck wrote: > > On Fri, 9 Sep 2016 14:04:55 +0300 > > Marcel Apfelbaum wrote: > > > >> On 09/09/2016 01:40 PM, Cornelia Huck wrote: > >>> On Fri, 9 Sep 2016 12:14:32 +0200 > >>> Maxime Coquelin wrote: >

Re: [Qemu-devel] [PATCH for-2.7] qtest.c: Allow zero size in memset qtest commands

2016-09-09 Thread Peter Maydell
On 8 September 2016 at 15:37, Eric Blake wrote: > On 08/05/2016 05:43 AM, Peter Maydell wrote: >> Some tests use the qtest protocol "memset" command with a zero >> size, expecting it to do nothing. However in the current code this >> will result in calling memset() with a NULL pointer, which is >>

Re: [Qemu-devel] [PATCH RFC v1 3/3] target-ppc: tlbie should have global effect

2016-09-09 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote: >> >> +env->tlb_need_flush = TLB_NEED_GLOBAL_FLUSH | TLB_NEED_LOCAL_FLUSH; >> check_tlb_flush(env th, 1); >> > > Hrm... how did that work bore ? IE. check_tlb_flush won't do anything > if tlb_need_f

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Maxime Coquelin
On 09/09/2016 01:49 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 13:44:35 +0200 Maxime Coquelin wrote: On 09/09/2016 01:20 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 14:04:55 +0300 Marcel Apfelbaum wrote: On 09/09/2016 01:40 PM, Cornelia Huck wrote: On Fri, 9 Sep 2016 12:14:32 +0200 Ma

Re: [Qemu-devel] [Libguestfs] Extracting files from OVA is bad

2016-09-09 Thread Richard W.M. Jones
On Fri, Sep 09, 2016 at 01:03:49PM +0200, Tomáš Golembiovský wrote: > Hi, > > recently we (oVirt) have started discussing whether the way virt-v2v > handles import from OVA files is good. And I would be interested in > ideas how it can be improved. It is likely somebody already gave some > thought

Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver

2016-09-09 Thread Claudio Fontana
Hi Pradeep, two comment below: On 09.09.2016 11:10, Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > devices which use 9p-local driver. > > Signed-off-by: Pradeep Jagadeesh > --- > fsdev/file-op-9p.h | 3 + > fsdev/qemu-fsdev-opts

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Daniel P. Berrange
On Fri, Sep 09, 2016 at 01:03:51PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > I previously split the global trace-events file up into one file > >> > per-subdirectory to

Re: [Qemu-devel] [PULL 0/9] Docker patches

2016-09-09 Thread Peter Maydell
On 9 September 2016 at 06:52, Fam Zheng wrote: > The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-09-06 17:18:17 +0100) > > are available in the git repository at: > > g...@gith

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-09 Thread Greg Kurz
On Thu, 8 Sep 2016 09:50:31 +0200 Laurent Vivier wrote: > On 08/09/2016 04:04, David Gibson wrote: > > On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote: > >> And add support for ppc64. > >> > >> Signed-off-by: Laurent Vivier > > > > Some of my coments may be obsoleted by the d

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-09 Thread Laurent Vivier
On 09/09/2016 14:25, Greg Kurz wrote: > On Thu, 8 Sep 2016 09:50:31 +0200 > Laurent Vivier wrote: > >> On 08/09/2016 04:04, David Gibson wrote: >>> On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote: And add support for ppc64. Signed-off-by: Laurent Vivier >>> >>

[Qemu-devel] [PATCH 2/2] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-09 Thread Denis V. Lunev
bdrv_is_allocated_above() returns true in the case even for completel zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. The patch stops using bdrv_is_allocated_above() wrapper and switches to bdrv_get_block_status_above() to distinguish zeroed areas and areas with data to avoid extra

[Qemu-devel] [PATCH v2 0/2] mirror: fix improperly filled copy_bitmap for mirror block job

2016-09-09 Thread Denis V. Lunev
bdrv_is_allocated_above() returns true in the case even for completel zeroed areas as BDRV_BLOCK_ALLOCATED flag is set in both cases. The patch stops using bdrv_is_allocated_above() wrapper and switches to bdrv_get_block_status_above() to distinguish zeroed areas and areas with data to avoid extra

[Qemu-devel] [PATCH 1/2] block: sync bdrv_co_get_block_status_above() with bdrv_is_allocated_above()

2016-09-09 Thread Denis V. Lunev
They should work very similar, covering same areas if backing store is shorter than the image. This change is necessary for the followup patch switching to bdrv_get_block_status_above() in mirror to avoid assert in check_block. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Fam Zheng CC:

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-09 Thread Paulina Szubarczyk
On 09/08/2016 12:00 AM, Paulina Szubarczyk wrote: On 09/07/2016 10:56 PM, Stefano Stabellini wrote: On Wed, 7 Sep 2016, Paulina Szubarczyk wrote: Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be alloca

Re: [Qemu-devel] [PATCH v5 20/20] Replace qmp-commands.hx by doc/qmp-commands.txt

2016-09-09 Thread Markus Armbruster
s,doc/,docs/ in subject. Can touch up on commit.

Re: [Qemu-devel] [PATCH v3 05/34] int128: Add int128_make128

2016-09-09 Thread Leon Alrae
On Sat, Sep 03, 2016 at 09:39:33PM +0100, Richard Henderson wrote: > Allows Int128 to be used more generally, rather than having to > begin with 64-bit inputs and accumulate. > > Signed-off-by: Richard Henderson > --- > include/qemu/int128.h | 20 +++- > 1 file changed, 15 insert

[Qemu-devel] [PATCH v2 2/6] queue: Add macro for incremental traversal

2016-09-09 Thread Lluís Vilanova
Adds macro QTAILQ_FOREACH_CONTINUE to support incremental list traversal. Signed-off-by: Lluís Vilanova --- include/qemu/queue.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index c2b6c81..4d57166 100644 --- a/include/qemu/queue.h +++ b/

[Qemu-devel] [RFC PATCH v2 0/6] translate: [tcg] Generic translation framework

2016-09-09 Thread Lluís Vilanova
This series proposes a generic (target-agnostic) instruction translation framework. It basically provides a generic main loop for instruction disassembly, which calls target-specific functions when necessary. This generalization makes inserting new code in the main loop easier, and helps in keepin

[Qemu-devel] [PATCH v2 3/6] target: [tcg] Add generic translation framework

2016-09-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/gen-icount.h |2 include/exec/translate-all_template.h | 76 + include/qom/cpu.h | 21 +++ translate-all_template.h | 200 + 4 files changed, 298 inser

[Qemu-devel] [PATCH v2 5/6] target: [tcg, i386] Port to generic translation framework

2016-09-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-i386/translate.c | 306 ++- 1 file changed, 142 insertions(+), 164 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index bfd9aed..a02398d 100644 --- a/target-i386/translate.c +++ b/t

[Qemu-devel] [PATCH v2 4/6] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*)

2016-09-09 Thread Lluís Vilanova
Temporarily redefine DISAS_* values based on DJ_TARGET. They should disappear as targets get ported to the generic framework. Signed-off-by: Lluís Vilanova --- include/exec/exec-all.h | 11 +++ target-arm/translate.h | 15 --- target-cris/translate.c |

[Qemu-devel] [PATCH v2 1/6] Pass generic CPUState to gen_intermediate_code()

2016-09-09 Thread Lluís Vilanova
Needed to implement a target-agnostic gen_intermediate_code() in the future. Signed-off-by: Lluís Vilanova Reviewed-by: David Gibson --- include/exec/exec-all.h |2 +- target-alpha/translate.c | 11 +-- target-arm/translate.c| 24 targ

[Qemu-devel] [PATCH v2 0/2] virtio-pci: Improve device plugging whith legacy backends

2016-09-09 Thread Maxime Coquelin
This series makes device plugging more robust, to avoid guest to be confused when the backend doesn't support VIRTIO_F_VERSION_1. The problem is seen with Linux guests running mainline kernels, when backend doesn't support the feature: virtio_net virtio0: virtio: device uses modern interface but d

[Qemu-devel] [PATCH v2 1/2] virtio: Add function to check whether backend supports VIRTIO_1

2016-09-09 Thread Maxime Coquelin
This patch adds virtio_test_backend_virtio_1() function to check whether backend supports VIRTIO_F_VERSION_1 before the negociation takes place. Cc: Cornelia Huck Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Cc: qemu-sta...@nongnu.org Signed-off-by: Maxime Coquelin --- hw/virtio/virtio.c

[Qemu-devel] [PATCH v2 6/6] target: [tcg, arm] Port to generic translation framework

2016-09-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- target-arm/translate-a64.c | 342 ++--- target-arm/translate.c | 718 ++-- target-arm/translate.h | 42 ++- 3 files changed, 553 insertions(+), 549 deletions(-) diff --git a/target-arm/translate

[Qemu-devel] [PATCH v2 2/2] virtio-pci: Disable modern interface if backend without VIRTIO_F_VERSION_1

2016-09-09 Thread Maxime Coquelin
This patch makes pci devices plugging more robust, by not confusing guest with modern interface when the backend doesn't support VIRTIO_F_VERSION_1. Cc: Cornelia Huck Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Cc: qemu-sta...@nongnu.org Signed-off-by: Maxime Coquelin --- hw/virtio/virtio-pci

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2016-09-09 Thread Leon Alrae
> +#define GEN_ATOMIC_HELPER(NAME, OP, NEW)\ > +static void * const table_##NAME[16] = {\ > +[MO_8] = gen_helper_atomic_##NAME##b, \ > +[MO_16 | MO_LE] = gen_helper_atomic_##NAME##w_le,

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Sep 09, 2016 at 01:03:51PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> >> Daniel P Berrange writes: >> >> >> >> > I previously split the global trace-events file up into o

[Qemu-devel] [PATCH v2 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

2016-09-09 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- target-ppc/cpu.h | 1 + target-ppc/helper_regs.h | 4 ++-- target-ppc/mmu-hash64.c | 4 ++-- target-ppc/mmu_helper.c | 6 +++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 1e808c8..7dc

[Qemu-devel] [PATCH v2 3/3] target-ppc: tlbie should have global effect

2016-09-09 Thread Nikunj A Dadhania
tlbie (H_REMOVE, H_PROTECT and H_BULK_REMOVE for pseries) should have a global effect. Introduces TLB_NEED_GLOBAL_FLUSH flag. During delayed flush, once taking care of local flush, check broadcast flush(ptesync, tlbsync, etc) is needed. Depending on the bitmask state of the tlb_need_flush, tlb is

[Qemu-devel] [PATCH v2 2/3] target-ppc: add flag in chech_tlb_flush()

2016-09-09 Thread Nikunj A Dadhania
The flag will be used to indicate whether broadcast tlb flush is needed or not. Moreover, BookS does both ptesync and tlbsync, so make that a nop for the server and tlbsync would generate a check flush for BookE Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_hcall.c | 4 ++-- target-ppc

Re: [Qemu-devel] [PATCH v2 4/6] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event

2016-09-09 Thread Lluís Vilanova
Michael S Tsirkin writes: > On Mon, Sep 05, 2016 at 08:56:44PM +0200, Lluís Vilanova wrote: >> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h >> index 929ec2f..8973f57 100644 >> --- a/include/hw/pci/pci.h >> +++ b/include/hw/pci/pci.h >> @@ -80,6 +80,8 @@ >> #define PCI_DEVICE_ID_VIRTIO_

Re: [Qemu-devel] [PATCH v4 06/17] monitor: unregister conditional commands

2016-09-09 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > The current monitor dispatch codes doesn't know commands that have been >> > filtered out during qmp-commands.hx preprocessing. query-commands >> > do

Re: [Qemu-devel] [PATCH v4] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-09 Thread Ashijeet Acharya
On Fri, Sep 9, 2016 at 8:41 AM, Eric Blake wrote: > On 09/08/2016 10:59 AM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting maximum migration speed and expected downtime limit par

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-09-09 Thread Theodore Ts'o
On Fri, Sep 09, 2016 at 11:19:25AM +0200, Jan Kara wrote: > > > > > 1. make the guest kernel based on your tree, the top commit is > > > > >10d7902fa0e82b (dax: unmap/truncate on device shutdown) and > > > > >the config file can be found in this thread. What git tree is 10d7902fa0e82b from

Re: [Qemu-devel] [PATCH RFC v1 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

2016-09-09 Thread Alex Bennée
Nikunj A Dadhania writes: I think we need a little more detail here. In fact when you post the next version of the series could you please include a cover letter to cover what the series is trying to achieve? > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/cpu.h | 1 + > target

Re: [Qemu-devel] [Libguestfs] Extracting files from OVA is bad

2016-09-09 Thread Michal Skrivanek
> On 09 Sep 2016, at 14:02, Richard W.M. Jones wrote: > > On Fri, Sep 09, 2016 at 01:03:49PM +0200, Tomáš Golembiovský wrote: >> Hi, >> >> recently we (oVirt) have started discussing whether the way virt-v2v >> handles import from OVA files is good. And I would be interested in >> ideas how it

  1   2   3   >