Re: [Qemu-devel] [PATCH 2/6] pci: Convert msix_init() to Error and fix callers to check it

2016-08-19 Thread Cao jin
On 08/18/2016 03:55 PM, Markus Armbruster wrote: Cao jin writes: diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 40a2ebc..b8511ee 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -899,6 +899,7 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp)

[Qemu-devel] [PATCH v2 0/2] Fix build with older linux-headers properly

2016-08-19 Thread Michal Privoznik
This is v2 of: http://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg03075.html diff to v1: - Dropped enum initializations in 2/2 as requested in the review Michal Privoznik (2): Revert "syscall.c: Fix build with older linux-headers" syscall.c: Redefine IFLA_* enums linux-user/syscall

[Qemu-devel] [PATCH v2 1/2] Revert "syscall.c: Fix build with older linux-headers"

2016-08-19 Thread Michal Privoznik
The fix I've made there was wrong. I mean, basically what I did there was equivalent to: #if 0 some code; #endif This reverts commit 9c37146782e7850877d452da47dc451ba73aa62d. Signed-off-by: Michal Privoznik --- linux-user/syscall.c | 86 ---

[Qemu-devel] [PATCH v2 2/2] syscall.c: Redefine IFLA_* enums

2016-08-19 Thread Michal Privoznik
In 9c37146782 I've tried to fix a broken build with older linux-headers. However, I didn't do it properly. The solution implemented here is to grab the enums that caused the problem initially, and rename their values so that they are "QEMU_" prefixed. In order to guarantee matching values with actu

Re: [Qemu-devel] Question with migrate_set_speed

2016-08-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Hi, > > I am playing with live migration and got one question about live > migration set_speed. > > Now we can use migrate_set_speed to configure the threshold during > migration (it should be only used for precopy, so let's assume the > migration is a prec

Re: [Qemu-devel] [PATCH v2 1/2] Revert "syscall.c: Fix build with older linux-headers"

2016-08-19 Thread Laurent Vivier
Le 19/08/2016 à 10:06, Michal Privoznik a écrit : > The fix I've made there was wrong. I mean, basically what I did > there was equivalent to: > > #if 0 > some code; > #endif > > This reverts commit 9c37146782e7850877d452da47dc451ba73aa62d. > > Signed-off-by: Michal Privoznik Reviewed-

Re: [Qemu-devel] [PATCH v2 2/2] syscall.c: Redefine IFLA_* enums

2016-08-19 Thread Laurent Vivier
Le 19/08/2016 à 10:06, Michal Privoznik a écrit : > In 9c37146782 I've tried to fix a broken build with older > linux-headers. However, I didn't do it properly. The solution > implemented here is to grab the enums that caused the problem > initially, and rename their values so that they are "QEMU

Re: [Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output

2016-08-19 Thread Janosch Frank
On 08/18/2016 10:12 PM, Sascha Silbe wrote: > Unlike Popen.communicate(), subprocess.call() doesn't read from the > stdout file descriptor. If the child process produces more output than > fits into the pipe buffer, it will block indefinitely. > > If we don't intend to consume the output, just sen

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-19 Thread Vijay Kilari
On Thu, Aug 18, 2016 at 8:26 PM, Peter Maydell wrote: > On 18 August 2016 at 15:46, Richard Henderson wrote: >> On 08/18/2016 07:14 AM, Peter Maydell wrote: >>> While we're on the subject, can somebody explain to me why we >>> use ifuncs at all? I couldn't work out why it would be better than >>>

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-19 Thread Masami Hiramatsu
On Thu, 18 Aug 2016 09:37:11 -0400 Luiz Capitulino wrote: > On Thu, 18 Aug 2016 11:54:24 +0100 > Stefan Hajnoczi wrote: > > > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > > > The hypertrace channel allows guest code to emit events in QEMU (the > > > host) using > > > its t

Re: [Qemu-devel] Question with migrate_set_speed

2016-08-19 Thread Peter Xu
On Fri, Aug 19, 2016 at 09:13:15AM +0100, Dr. David Alan Gilbert wrote: > Actually, that's what QEMU does; the migrate_set_speed is really only used > for (1) directly. > (2) actually comes from a measured bandwidth multiplied by the > 'migrate_set_downtime' > figure. (See around line 1800ish i mi

Re: [Qemu-devel] [PATCH 0/3] docker tests fixes

2016-08-19 Thread Alex Bennée
Sascha Silbe writes: > A couple of fixes for issues encountered while trying out the new > docker test support. The debian-bootstrap image still doesn't build > for me, but that's a problem for another day. Can you offer any details? What host OS and what errors do you get? > > Thanks for the

Re: [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Ladi Prosek
On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: > Upon save/restore virtio-balloon stats acquisition stops. The reason is > that the fact that the (only) virtqueue element is being used by QEMU is > not recorded anywhere on save, so upon restore it's not released to the > guest, making furthe

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-19 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 12:19:50PM -0400, Steven Rostedt wrote: > On Thu, 18 Aug 2016 11:54:24 +0100 > Stefan Hajnoczi wrote: > > > Steven is working on a host/guest solution for trace-cmd. It is also > > asynchronous. No new paravirt hardware is needed and it makes me wonder > > whether the hy

Re: [Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1

2016-08-19 Thread Ladi Prosek
On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: > The protocol for virtio-balloon stats virtqueue doesn't allow more than > one element in the virtqueue. > > So, instead of trying to compensate for guest misbehavior if it sends > new data before the slot has been released by the host, just def

Re: [Qemu-devel] [PATCH v2 0/2] Fix build with older linux-headers properly

2016-08-19 Thread Peter Maydell
On 19 August 2016 at 09:06, Michal Privoznik wrote: > This is v2 of: > > http://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg03075.html > > diff to v1: > - Dropped enum initializations in 2/2 as requested in the review > > Michal Privoznik (2): > Revert "syscall.c: Fix build with older li

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-19 Thread Auger Eric
Hi Alex, On 19/08/2016 00:35, Alexander Graf wrote: > >> On 18 Aug 2016, at 05:37, Auger Eric wrote: >> >> Hi Shanker, >> >> Adding Alex in CC for (*) >> >> On 14/08/2016 17:42, Shanker Donthineni wrote: >>> This patch introduces the Qualcomm Technologies, Inc HIDMA device and >>> allows passthr

Re: [Qemu-devel] [PATCH v2 1/2] glib: add compatibility implementation for g_dir_make_tmp()

2016-08-19 Thread Peter Maydell
On 18 August 2016 at 19:46, Sascha Silbe wrote: > We're going to make use of g_dir_make_tmp() in test-logging. Provide a > compatibility implementation of it for glib < 2.30. > > May behave differently in some edge cases (e.g. pattern only at the > end of the template, the file name is not part of

Re: [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 11:57:44AM +0200, Ladi Prosek wrote: > On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: > > Upon save/restore virtio-balloon stats acquisition stops. The reason is > > that the fact that the (only) virtqueue element is being used by QEMU is > > not recorded anywhere on

Re: [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Ladi Prosek
On Fri, Aug 19, 2016 at 1:37 PM, Roman Kagan wrote: > On Fri, Aug 19, 2016 at 11:57:44AM +0200, Ladi Prosek wrote: >> On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: >> > Upon save/restore virtio-balloon stats acquisition stops. The reason is >> > that the fact that the (only) virtqueue elem

Re: [Qemu-devel] [PATCH for-v2.7 v2 0/2] test-logging: don't hard-code paths in /tmp

2016-08-19 Thread Peter Maydell
On 18 August 2016 at 19:46, Sascha Silbe wrote: > This version should be good enough for inclusion in 2.7. I kept the > temporary directory removal function local to test-logging for now, > only cleaning up a single directory level. We can still factor it out > and make it more generic in the 2.8

Re: [Qemu-devel] [libvirt] [RFC] libvirt vGPU QEMU integration

2016-08-19 Thread Michal Privoznik
On 18.08.2016 18:41, Neo Jia wrote: > Hi libvirt experts, Hi, welcome to the list. > > I am starting this email thread to discuss the potential solution / proposal > of > integrating vGPU support into libvirt for QEMU. > > Some quick background, NVIDIA is implementing a VFIO based mediated dev

[Qemu-devel] [PATCH] block: m25p80c Fix vmstate structure name

2016-08-19 Thread marcin.krzeminski
From: Marcin Krzeminski Change wrong name of the vmstate structure. Since this breaks compatibility update version and fields to 0. Signed-off-by: Marcin Krzeminski --- This patch assumes that none migrates m25p80 flash devices. hw/block/m25p80.c | 29 ++--- 1 file ch

Re: [Qemu-devel] [Qemu-arm] [PATCH] block: m25p80c Fix vmstate structure name

2016-08-19 Thread Peter Maydell
On 19 August 2016 at 13:30, wrote: > From: Marcin Krzeminski > > Change wrong name of the vmstate structure. Since this breaks > compatibility update version and fields to 0. > > Signed-off-by: Marcin Krzeminski > --- > > This patch assumes that none migrates m25p80 flash devices. > > hw/block

[Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

2016-08-19 Thread Max Reitz
There are some (mostly ISP-specific) name servers who will redirect non-existing domains to special hosts. In this case, we will get a different error message when trying to connect to such a host, which breaks test 162. 162 needed this specific error message so it can confirm that qemu was indeed

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-19 Thread Steven Rostedt
On Fri, 19 Aug 2016 11:02:07 +0100 Stefan Hajnoczi wrote: > > [1] > > https://lcccna2016.sched.org/event/7JWL/trace-cmd-virt-server-a-status-update-steven-rostedt-red-hat?iframe=no&w=i:100;&sidebar=yes&bg=no > > > > Cool, that's very interesting! I'll try to attend. Good, see you then! >

Re: [Qemu-devel] [PATCH 0/4] virtio-balloon: assorted fixes

2016-08-19 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 09:27:50PM +0300, Roman Kagan wrote: > This patchset addresses a few problems discovered when analyzing aborts > of (an older version of) QEMU with backported commit > afd9096eb1882f23929f5b5c177898ed231bac66 "virtio: error out if guest > exceeds virtqueue size". Those prob

Re: [Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1

2016-08-19 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 09:27:52PM +0300, Roman Kagan wrote: > The protocol for virtio-balloon stats virtqueue doesn't allow more than > one element in the virtqueue. > > So, instead of trying to compensate for guest misbehavior if it sends > new data before the slot has been released by the host,

Re: [Qemu-devel] nvml test failures with QEMU nvdimm device

2016-08-19 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 08:31:51PM +0800, Xiao Guangrong wrote: > > Stefan, > > I am digging into it. Thanks, I appreciate it. Let me know if there is something I can do to help. Stefan signature.asc Description: PGP signature

[Qemu-devel] [PATCH v2 2/6] virtio-balloon: make stats virtqueue length 1

2016-08-19 Thread Roman Kagan
The protocol for virtio-balloon stats virtqueue doesn't allow more than one element in the virtqueue. So, instead of trying to compensate for guest misbehavior if it sends new data before the slot has been released by the host, just define the stats virtqueue length to 1 initially and rely on the

[Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Roman Kagan
Upon save/restore virtio-balloon stats acquisition stops. The reason is that the fact that the (only) virtqueue element is being used by QEMU is not recorded anywhere on save, so upon restore it's not released to the guest, making further progress impossible. Saving the information about the used

Re: [Qemu-devel] [Qemu-arm] [PATCH] block: m25p80c Fix vmstate structure name

2016-08-19 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 19 August 2016 at 13:30, wrote: > > From: Marcin Krzeminski > > > > Change wrong name of the vmstate structure. Since this breaks > > compatibility update version and fields to 0. > > > > Signed-off-by: Marcin Krzeminski > > --- > > > > Thi

Re: [Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 02:44:10PM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 18, 2016 at 09:27:52PM +0300, Roman Kagan wrote: > > The protocol for virtio-balloon stats virtqueue doesn't allow more than > > one element in the virtqueue. > > > > So, instead of trying to compensate for guest misbeh

Re: [Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 04:39:19PM +0300, Roman Kagan wrote: > This patchset addresses a few problems discovered when analyzing aborts > of (an older version of) QEMU with backported commit > afd9096eb1882f23929f5b5c177898ed231bac66 "virtio: error out if guest > exceeds virtqueue size". Those prob

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Peter Maydell
On 11 August 2016 at 06:13, P J P wrote: > From: Prasad J Pandit > > At various places in 9pfs back-end, it creates full path by > concatenating two path strings. It could lead to a path > traversal issue if one of the parameter was a relative path. > Add check to avoid it. > > Reported-by: Felix

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-19 Thread Richard Henderson
On 08/19/2016 02:05 AM, Vijay Kilari wrote: On Thu, Aug 18, 2016 at 8:26 PM, Peter Maydell wrote: On 18 August 2016 at 15:46, Richard Henderson wrote: On 08/18/2016 07:14 AM, Peter Maydell wrote: While we're on the subject, can somebody explain to me why we use ifuncs at all? I couldn't work

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-19 Thread Dan Williams
On Fri, Aug 19, 2016 at 4:19 AM, Xiao Guangrong wrote: > > Hi Dan, > > Recently, Redhat reported that nvml test suite failed on QEMU/KVM, > more detailed info please refer to: >https://bugzilla.redhat.com/show_bug.cgi?id=1365721 > > The reason for this bug is that the memory region created by

Re: [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 02:08:50PM +0200, Ladi Prosek wrote: > On Fri, Aug 19, 2016 at 1:37 PM, Roman Kagan wrote: > > On Fri, Aug 19, 2016 at 11:57:44AM +0200, Ladi Prosek wrote: > >> On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: > >> > Upon save/restore virtio-balloon stats acquisition st

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Peter Maydell
On 19 August 2016 at 15:55, Peter Maydell wrote: > Also, strstr(name, "../") is the wrong check. There are I think > two possibilities here: > > (1) the "name" parameter may only validly be a single pathname > component. In this case we should be enforcing this by treating > any string with a "/"

Re: [Qemu-devel] [PATCH v2 6/6] virtio-ballon: drop reset handler

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 04:39:25PM +0300, Roman Kagan wrote: > Since the release of ->stat_vq_elem is now ensured by the vm state > change handler, there's no need in the reset handler doing it. Oops, sorry, this is a duplicate of the same message modulo typo in the subject, please ignore. Roman.

Re: [Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1

2016-08-19 Thread Roman Kagan
On Fri, Aug 19, 2016 at 12:05:29PM +0200, Ladi Prosek wrote: > On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: > > The protocol for virtio-balloon stats virtqueue doesn't allow more than > > one element in the virtqueue. > > > > So, instead of trying to compensate for guest misbehavior if it s

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-19 Thread Andrea Bolognani
On Thu, 2016-08-18 at 08:38 +0200, Andrew Jones wrote: > > > Finally, FWIW, with a guest kernel of 4.6.4-301.fc24.aarch64. The > > > following qemu command line works for me. > > > (notice the use of PCIe), and my network interface gets labeled enp0s1. > > >   > > > $QEMU -machine virt-2.6,accel=kv

[Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset

2016-08-19 Thread Roman Kagan
As we don't write anything to guest on stats virtqueue we should pass len=0 to virtqueue_push(). This makes ->stats_vq_offset unnecessary, so drop it. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Ladi Prosek Cc: Stefan Hajnoczi --- hw/virtio/virtio-balloon.c | 3 +-- inclu

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Greg Kurz
On Fri, 19 Aug 2016 15:55:17 +0100 Peter Maydell wrote: > On 11 August 2016 at 06:13, P J P wrote: > > From: Prasad J Pandit > > > > At various places in 9pfs back-end, it creates full path by > > concatenating two path strings. It could lead to a path > > traversal issue if one of the paramete

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Greg Kurz
On Fri, 19 Aug 2016 16:14:48 +0100 Peter Maydell wrote: > On 19 August 2016 at 15:55, Peter Maydell wrote: > > Also, strstr(name, "../") is the wrong check. There are I think > > two possibilities here: > > > > (1) the "name" parameter may only validly be a single pathname > > component. In this

[Qemu-devel] [PATCH] block: Allow node name for 'qemu-io' HMP command

2016-08-19 Thread Kevin Wolf
When using a node name, create a temporary BlockBackend that is used to run the qemu-io command. Signed-off-by: Kevin Wolf --- hmp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hmp.c b/hmp.c index a7dfe6f..ad33b44 100644 --- a/hmp.c +++ b/hmp.c @@ -1923,11 +1923,22 @@ void

[Qemu-devel] [PATCH 01/10] block: Add blk_by_dev()

2016-08-19 Thread Kevin Wolf
This finds a BlockBackend given the device model that is attached to it. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/block-backend.c | 19 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 20 insertions(+) diff --git a/block/block-backend.c b/

[Qemu-devel] [PATCH 07/10] block: Accept device model name for eject

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts eject to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 10 +++--- hmp.c | 2 +- qapi/block

[Qemu-devel] [PATCH 06/10] block: Accept device model name for x-blockdev-remove-medium

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-remove-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 23 +--

[Qemu-devel] [PATCH 08/10] block: Accept device model name for blockdev-change-medium

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-change-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 18 +++--- hmp.c

[Qemu-devel] [PATCH 05/10] block: Accept device model name for x-blockdev-insert-medium

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-insert-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 33 +--

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-19 Thread Shanker Donthineni
Eric/Alex, Seems everyone was agreed, and add support for a generic vfio platform device class. I'm going to drop this HIDMA patch since the new generic vfio platform device class will cover. Shanker On 08/19/2016 06:43 AM, Auger Eric wrote: Hi Alex, On 19/08/2016 00:35, Alexander Graf wro

[Qemu-devel] [PATCH 02/10] qdev-monitor: Factor out find_device_state()

2016-08-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qdev-monitor.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e19617f..bc0213f 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -801,7 +801,7 @@ void qmp_device_a

[Qemu-devel] [PATCH 00/10] block: Accept qdev IDs in device level QMP commands

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we already converted all block layer QMP commands on the node level to accept node names instead of BlockBackend names. This series converts the second part, device level commands, to allow qdev device names instead of

[Qemu-devel] [PATCH 09/10] block: Accept device model name for block_set_io_throttle

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts block_set_io_throttle to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 12 +++- qapi/block-c

[Qemu-devel] [PATCH 03/10] qdev-monitor: Add blk_by_qdev_id()

2016-08-19 Thread Kevin Wolf
This finds the BlockBackend attached to the device model identified by its qdev ID. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/sysemu/block-backend.h | 1 + qdev-monitor.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/sysemu

[Qemu-devel] [RFC PATCH 3/4] tcg/tests: Move mips test to arch specific folder

2016-08-19 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- tests/tcg/{ => mips}/hello-mips.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/tcg/{ => mips}/hello-mips.c (100%) diff --git a/tests/tcg/hello-mips.c b/tests/tcg/mips/hello-mips.c similarity index 100% rename from tests/tcg/hello-mips.c rena

[Qemu-devel] [PATCH 04/10] block: Accept device model name for blockdev-open/close-tray

2016-08-19 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-open/close-tray to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c | 60 +++

[Qemu-devel] [RFC PATCH 4/4] tests/tcg: misc tests holds arch independent tests

2016-08-19 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- tests/tcg/misc/Makefile | 75 +++ tests/tcg/{ => misc}/linux-test.c | 3 ++ tests/tcg/{ => misc}/sha1.c | 0 tests/tcg/{ => misc}/test-mmap.c | 0 tests/tcg/{ => misc}/test_path.c | 0 tests/tcg/{ => misc}/

[Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name

2016-08-19 Thread Kevin Wolf
We just added the option to use qdev device names in all device related block QMP commands. This patch converts some of the test cases in 118 to use qdev device names instead of BlockBackend names to cover the new way. It converts cases for each of the media change commands, but only for CD-ROM and

[Qemu-devel] [RFC PATCH 1/4] tests/tcg: Move i386 tests to arch specific folder

2016-08-19 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- tests/tcg/Makefile | 156 tests/tcg/i386/Makefile | 88 ++ tests/tcg/{ => i386}/hello-i386.c | 0 tests/tcg/{ => i386}/pi_10.com | Bin tests/tcg/{ => i386}/run

[Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests

2016-08-19 Thread Pranith Kumar
Hello, This RFC patch series cleans up the tcg tests in tests/tcg folder. The tests have bit-rotten and were not compiling or running. I fixed the Makefiles to make them compile though there are tests which do not pass. I plan to fix them if you think this approach is reasonable. The motivation

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Peter Maydell
On 19 August 2016 at 17:37, Greg Kurz wrote: > Peter Maydell wrote: >> If (1) is true and "only single path component" is a protocol >> requirement then probably we should be enforcing this at a >> higher layer than in 9p-local.c, ie in hw/9pfs/cofs.c. > As we discussed on IRC, the / character i

Re: [Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support

2016-08-19 Thread Wei Huang
On 08/15/2016 11:13 AM, Peter Maydell wrote: >> static inline int arm_feature(CPUARMState *env, int feature) >> diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c >> index 1635deb..19e8127 100644 >> --- a/target-arm/cpu64.c >> +++ b/target-arm/cpu64.c >> @@ -111,6 +111,9 @@ static void aarch6

[Qemu-devel] [RFC PATCH 2/4] tests/tcg: Move arm tests to arch specific folder

2016-08-19 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- tests/tcg/arm/Makefile| 45 +++ tests/tcg/{ => arm}/hello-arm.c | 0 tests/tcg/{ => arm}/test-arm-iwmmxt.s | 0 3 files changed, 45 insertions(+) create mode 100644 tests/tcg/arm/Makefile rename tests/tcg/{

[Qemu-devel] [PATCH v2 6/6] virtio-ballon: drop reset handler

2016-08-19 Thread Roman Kagan
Since the release of ->stat_vq_elem is now ensured by the vm state change handler, there's no need in the reset handler doing it. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Ladi Prosek Cc: Stefan Hajnoczi --- hw/virtio/virtio-balloon.c | 11 --- 1 file changed, 11 deletio

[Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes

2016-08-19 Thread Roman Kagan
This patchset addresses a few problems discovered when analyzing aborts of (an older version of) QEMU with backported commit afd9096eb1882f23929f5b5c177898ed231bac66 "virtio: error out if guest exceeds virtqueue size". Those problems are present in master, too, except that they don't trigger an ab

[Qemu-devel] [PATCH v2 6/6] virtio-balloon: drop reset handler

2016-08-19 Thread Roman Kagan
Since the release of ->stat_vq_elem is now ensured by the vm state change handler, there's no need in the reset handler doing it. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Ladi Prosek Cc: Stefan Hajnoczi --- hw/virtio/virtio-balloon.c | 11 --- 1 file changed, 11 deletio

Re: [Qemu-devel] [RFC v6-based v1 0/5] refine mdev framework

2016-08-19 Thread Kirti Wankhede
On 8/18/2016 11:55 PM, Alex Williamson wrote: > On Thu, 18 Aug 2016 16:42:14 +0800 > Dong Jia wrote: > >> On Wed, 17 Aug 2016 03:09:10 -0700 >> Neo Jia wrote: >> >>> On Wed, Aug 17, 2016 at 04:58:14PM +0800, Dong Jia wrote: On Tue, 16 Aug 2016 16:14:12 +0800 Jike Song wrote:

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-19 Thread Greg Kurz
On Fri, 19 Aug 2016 18:03:29 +0100 Peter Maydell wrote: > On 19 August 2016 at 17:37, Greg Kurz wrote: > > Peter Maydell wrote: > >> If (1) is true and "only single path component" is a protocol > >> requirement then probably we should be enforcing this at a > >> higher layer than in 9p-local

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-19 Thread Laine Stump
On 08/19/2016 11:43 AM, Andrea Bolognani wrote: On Thu, 2016-08-18 at 08:38 +0200, Andrew Jones wrote: Finally, FWIW, with a guest kernel of 4.6.4-301.fc24.aarch64. The following qemu command line works for me. (notice the use of PCIe), and my network interface gets labeled enp0s1. $QEMU -ma

[Qemu-devel] QEMU make: ROM is too large

2016-08-19 Thread Thomas Hanson
All, Just pulled top of tree, make clean and make as follows: CFLAGS="-g3 -O0" ./configure --enable-vhost-net --enable-virtfs make -j8 Build fails with ASoptionrom/kvmvapic.o Building optionrom/multiboot.img Building optionrom/linuxboot.img Building optionrom/linuxboot_dma.im

[Qemu-devel] [Bug 1615079] [NEW] GTK+ UI virtual consoles scrolling broken

2016-08-19 Thread Bug Report
Public bug reported: "In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and Ctrl-PageDown to move in the back log." ** Affects: qemu Importance: Undecided Status: New ** Summary changed: - gtk+ ui virtual consoles scrolling broken + GTK+ UI virtual consoles scro

Re: [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-19 Thread Ladi Prosek
On Fri, Aug 19, 2016 at 4:45 PM, Roman Kagan wrote: > On Fri, Aug 19, 2016 at 02:08:50PM +0200, Ladi Prosek wrote: >> On Fri, Aug 19, 2016 at 1:37 PM, Roman Kagan wrote: >> > On Fri, Aug 19, 2016 at 11:57:44AM +0200, Ladi Prosek wrote: >> >> On Thu, Aug 18, 2016 at 8:27 PM, Roman Kagan wrote: >>

Re: [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd

2016-08-19 Thread Reda Sallahi
On Tue, Aug 16, 2016 at 12:09:06PM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote: > > +blk2 = blk_new_open(image_opts ? NULL : out.filename, > > +NULL, qoptions, BDRV_O_RDWR, NULL); > > This code duplicates a subset of img_

[Qemu-devel] [PATCH 0/7] MIPS Boston board support

2016-08-19 Thread Paul Burton
This series introduces support for the MIPS Boston development board. It begins by introducing support for moving MIPS Coherence Manager GCRs which Boston software typically does to avoid conflicting with its flash memory region. An API is then added to retrieve the emulated MIPS GIC timer frequenc

[Qemu-devel] [PATCH 1/7] hw/mips_cmgcr: allow GCR base to be moved

2016-08-19 Thread Paul Burton
Support moving the GCR base address & updating the CPU's CP0 CMGCRBase register appropriately. This is required if a platform needs to move its GCRs away from other memory, as the MIPS Boston development board does to avoid its flash memory. Signed-off-by: Paul Burton --- hw/misc/mips_cmgcr.c

[Qemu-devel] [PATCH 3/7] hw/mips_gic: Update pin state on mask changes

2016-08-19 Thread Paul Burton
If the GIC interrupt mask is changed by a write to the smask (set mask) or rmask (reset mask) registers, we need to re-evaluate the state of the pins/IRQs fed to the CPU. Without doing so we risk leaving a pin high despite the interrupt that led to that state being masked, or losing interrupts if a

[Qemu-devel] [PATCH 4/7] target-mips: Provide function to test if a CPU supports an ISA

2016-08-19 Thread Paul Burton
Provide a new cpu_supports_isa function which allows callers to determine whether a CPU supports one of the ISA_ flags, by testing whether the associated struct mips_def_t sets the ISA flags in its insn_flags field. An example use of this is to allow boards which generate bootloader code to determ

[Qemu-devel] [PATCH 2/7] hw/mips_gictimer: provide API for retrieving frequency

2016-08-19 Thread Paul Burton
Provide a new function mips_gictimer_get_freq() which returns the frequency at which a GIC timer will count. This will be useful for boards which perform setup based upon this frequency. Signed-off-by: Paul Burton --- hw/timer/mips_gictimer.c | 5 + include/hw/timer/mips_gictimer.h |

[Qemu-devel] [PATCH 5/7] loader: Support Flattened Image Trees (FIT images)

2016-08-19 Thread Paul Burton
Introduce support for loading Flattened Image Trees, as used by modern U-Boot. FIT images are essentially flattened device tree files which contain binary images such as kernels, FDTs or ramdisks along with one or more configuration nodes describing boot configurations. The MIPS Boston board typic

[Qemu-devel] [PATCH 6/7] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

2016-08-19 Thread Paul Burton
Add support for emulating the Xilinx AXI Root Port Bridge for PCI Express as described by Xilinx' PG055 document. This is a PCIe controller that can be used with certain series of Xilinx FPGAs, and is used on the MIPS Boston board which will make use of this code. Signed-off-by: Paul Burton ---

[Qemu-devel] [PATCH v2 3/6] virtio-balloon: don't restart stats timer in callback

2016-08-19 Thread Roman Kagan
There's no need to restart the stats timer in its callback. If the callback happens to run when there's nothing to do just do nothing and return. The timer is armed either in receive handler or initially when periodic stats collection is enabled via QMP. While at this, observe that the presence

[Qemu-devel] [PATCH 7/7] hw/mips: MIPS Boston board support

2016-08-19 Thread Paul Burton
Introduce support for emulating the MIPS Boston development board. The Boston board is built around an FPGA & 3 PCIe controllers, one of which is connected to an Intel EG20T Platform Controller Hub. It is used during the development & debug of new CPUs and the software intended to run on them, and

Re: [Qemu-devel] [libvirt] [RFC] libvirt vGPU QEMU integration

2016-08-19 Thread Laine Stump
On 08/18/2016 12:41 PM, Neo Jia wrote: Hi libvirt experts, I am starting this email thread to discuss the potential solution / proposal of integrating vGPU support into libvirt for QEMU. Thanks for the detailed description. This is very helpful. Some quick background, NVIDIA is implementin

Re: [Qemu-devel] [PATCH 0/7] MIPS Boston board support

2016-08-19 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20160819190903.10974-1-paul.bur...@imgtec.com Subject: [Qemu-devel] [PATCH 0/7] MIPS Boston board support Type: se

Re: [Qemu-devel] [PATCH 0/7] MIPS Boston board support

2016-08-19 Thread Paul Burton
On 19/08/16 20:25, no-re...@patchew.org wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Message-id: 20160819190903.10974-1-paul.bur...@imgtec.com > Su

[Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow

2016-08-19 Thread Roman Kagan
Make sure that ->inuse counter on virtqueue never goes negative. This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, "virtio: error out if guest exceeds virtqueue size", which, due to signed ->inuse comparison against unsigned ->vring.num, manifested a bug in virtio-balloon where vir

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-19 Thread Dmitry Osipenko
On 19.08.2016 02:24, Marek Vasut wrote: > On 08/18/2016 11:49 AM, Dmitry Osipenko wrote: >> On 17.08.2016 23:19, Marek Vasut wrote: >>> On 08/16/2016 11:38 PM, Dmitry Osipenko wrote: >>> >>> [...] >>> >>> Well what is sane clock frequency for hardware which can have arbitrary >>> frequency

Re: [Qemu-devel] DAX can not work on virtual nvdimm device

2016-08-19 Thread Ross Zwisler
On Fri, Aug 19, 2016 at 07:59:29AM -0700, Dan Williams wrote: > On Fri, Aug 19, 2016 at 4:19 AM, Xiao Guangrong > wrote: > > > > Hi Dan, > > > > Recently, Redhat reported that nvml test suite failed on QEMU/KVM, > > more detailed info please refer to: > >https://bugzilla.redhat.com/show_bug.cg

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-19 Thread Marek Vasut
On 08/19/2016 10:53 PM, Dmitry Osipenko wrote: > On 19.08.2016 02:24, Marek Vasut wrote: >> On 08/18/2016 11:49 AM, Dmitry Osipenko wrote: >>> On 17.08.2016 23:19, Marek Vasut wrote: On 08/16/2016 11:38 PM, Dmitry Osipenko wrote: [...] Well what is sane clock frequency

Re: [Qemu-devel] [Qemu-arm] [PATCH] block: m25p80c Fix vmstate structure name

2016-08-19 Thread Alistair Francis
On Fri, Aug 19, 2016 at 7:19 AM, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 19 August 2016 at 13:30, wrote: >> > From: Marcin Krzeminski >> > >> > Change wrong name of the vmstate structure. Since this breaks >> > compatibility update version and fie

[Qemu-devel] [Bug 1490611]

2016-08-19 Thread Nish Aravamudan
** Attachment added: "attachment" https://bugs.launchpad.net/bugs/1490611/+attachment/4724312/+files/attachment -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to

Re: [Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-08-19 Thread Nish Aravamudan
On 17.08.2016 [10:20:26 -0700], Nish Aravamudan wrote: > On 17.08.2016 [13:12:19 -], Chris J Arges wrote: > > Can you rebase your fix on 1:2.5+dfsg-5ubuntu10.4 (due to the > > regression fix mentioned in #25)? > > Will do! Done. > > Another thing about your backport is that it dropped the qe

[Qemu-devel] [PATCH] Avoid additional GET_FEATURES call on vhost-user

2016-08-19 Thread Felipe Franciosi
Vhost-user requires an early GET_FEATURES call to determine if the slave supports protocol feature negotiation. An extra GET_FEATURES call is made after vhost_backend_init() to actually set the device features. This patch moves the actual setting of the device features to both implementations (ker

Re: [Qemu-devel] QEMU make: ROM is too large

2016-08-19 Thread Thomas Hanson
Update: After several rounds, git bisect says: 7f2569246c81d5f88e74c142b8fbdc0ee601bffe is the first bad commit commit 7f2569246c81d5f88e74c142b8fbdc0ee601bffe Author: Paolo Bonzini Date: Fri Aug 5 10:51:37 2016 +0200 linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation It'

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 4/4] adb.c: prevent NO_KEY value from going to guest

2016-08-19 Thread Programmingkid
On Aug 18, 2016, at 7:06 AM, BALATON Zoltan wrote: > On Wed, 17 Aug 2016, John Arbuckle wrote: >> @@ -446,7 +438,10 @@ static void adb_keyboard_event(DeviceState *dev, >> QemuConsole *src, >>return; >>} >>keycode = qcode_to_adb_keycode[qcode]; >> - >> +if (keycode == NO_KEY)

Re: [Qemu-devel] [RFC 00/13] Live memory snapshot based on userfaultfd

2016-08-19 Thread Hailiang Zhang
Hi, I updated this series, but didn't post it, because there are some problems while i tested the snapshot function. I didn't know if it is the userfaultfd issue or not. I don't have time to investigate it this month. I have put them in github https://github.com/coloft/qemu/tree/snapshot-v2 Any