Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-04 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, August 04, 2016 3:04 AM > > > 2. Physical device driver interface > This interface provides vendor driver the set APIs to manage physical > device related work in their own driver. APIs are : > - supported_config: provide supp

[Qemu-devel] [PATCH v2] net: check fragment length during fragmentation

2016-08-04 Thread P J P
From: Prasad J Pandit Network transport abstraction layer supports packet fragmentation. While fragmenting a packet, it checks for more fragments from packet length and current fragment length. It is susceptible to an infinite loop, if the current fragment length is zero. Add check to avoid it.

Re: [Qemu-devel] [PATCH v6 4/4] docs: Add Documentation for Mediated devices

2016-08-04 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, August 04, 2016 3:04 AM > > + > +* mdev_supported_types: (read only) > +List the current supported mediated device types and its details. > + > +* mdev_create: (write only) > + Create a mediated device on target physica

Re: [Qemu-devel] [Patch v1 26/29] qmp: add QMP interface "query-cpu-model-baseline"

2016-08-04 Thread David Hildenbrand
> +## > +# @query-cpu-model-baseline: > +# > +# Baseline two CPU models, creating a compatible third model. The created > +# model will always be a static, migration-safe CPU model (see "static" > +# CPU model expansion for details). The QEMU machine QEMU has been started > +# with affects the res

Re: [Qemu-devel] [Patch v1 25/29] qmp: add QMP interface "query-cpu-model-comparison"

2016-08-04 Thread David Hildenbrand
> +## > +# @CpuModelCompareResult: > +# > +# An enumeration of CPU model comparation results. > +# > +# @incompatible: both model definition are incompatible > +# > +# @identical: model A == model B > +# > +# @superset: model A > model B > +# > +# @subset: model A < model B > +# > +# Since: 2.8.0

Re: [Qemu-devel] [PATCH] virtio-net: allow increasing rx queue size

2016-08-04 Thread Cornelia Huck
On Thu, 4 Aug 2016 02:16:14 +0300 "Michael S. Tsirkin" wrote: > This allows increasing the rx queue size up to 1024: unlike with tx, > guests don't put in huge S/G lists into RX so the risk of running into > the max 1024 limitation due to some off-by-one seems small. > > It's helpful for users l

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragment length during fragmentation

2016-08-04 Thread P J P
Hello Jason, +-- On Thu, 4 Aug 2016, Jason Wang wrote --+ | The patch doesn't apply cleanly on HEAD, we now move this logic to | hw/net/net_tx_pkt.c. Please resend on top of HEAD and cc Dmitry Fleytman | . I see, that explains why it did not show-up in search. I've sent a revised patch v2.

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Zeng, Xin
On Monday, August 01, 2016 5:20 PM, Gonglei Wrote: > -Original Message- > From: Gonglei [mailto:arei.gong...@huawei.com] > Sent: Monday, August 1, 2016 5:20 PM > To: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: peter.huangp...@huawei.com; luoneng...@huawei.com; > m...@redhat

Re: [Qemu-devel] [PATCH V3] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-08-04 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 05:12:25PM +0800, Zhang Chen wrote: > Add qemu_chr_add_handlers_full() API, we can use > this API pass in a GMainContext,make handler run > in the context rather than main_loop. > This comments from Daniel P . Berrange. > > Signed-off-by: Zhang Chen > Signed-off-by: Li Zhi

Re: [Qemu-devel] [PATCH 3/5] sclpconsole: remove bogus check for -EAGAIN

2016-08-04 Thread Cornelia Huck
On Wed, 3 Aug 2016 17:22:38 +0100 "Daniel P. Berrange" wrote: s/sclpconsole/sclpconsolelm/ in the subject, as there are two sclp consoles :) > The write_console_data() method in sclpconsole-lm.c checks > whether the return value of qemu_chr_fe_write() has the > value of -EAGAIN and if so then i

Re: [Qemu-devel] [PATCH V3] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-08-04 Thread Zhang Chen
On 08/04/2016 04:05 PM, Daniel P. Berrange wrote: On Thu, Jul 28, 2016 at 05:12:25PM +0800, Zhang Chen wrote: Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-

Re: [Qemu-devel] [PATCH 4/5] hw: replace most use of qemu_chr_fe_write with qemu_chr_fe_write_all

2016-08-04 Thread Cornelia Huck
On Wed, 3 Aug 2016 17:22:39 +0100 "Daniel P. Berrange" wrote: > The qemu_chr_fe_write method will return -1 on EAGAIN if the > chardev backend write would block. Almost no callers of the > qemu_chr_fe_write() method check the return value, instead > blindly assuming data was successfully sent. I

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

2016-08-04 Thread Laurent Vivier
On 04/08/2016 04:38, David Gibson wrote: > On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: >> If we don't provide the page size in target-ppc:cpu_get_dump_info(), >> the default one (TARGET_PAGE_SIZE, 4KB) is used to create >> the compressed dump. It works fine with Macintosh, but

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 06:18:25PM +0200, Christian Pinto wrote: > Hello Stefan, > > On Tue, Jul 19, 2016 at 10:40 AM, Stefan Hajnoczi > wrote: > > > On Tue, Jul 19, 2016 at 09:47:13AM +0200, Christian Pinto wrote: > > > > > +During the initialization phase the device connects also to the > > >

[Qemu-devel] [PATCH V4] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-08-04 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Reviewed-by: Daniel P. Berrange ---

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-08-04 Thread Paolo Bonzini
> > Thanks, these can go in 2.8. > > I am fine with the time. Do you want me to repost these after 2.8? No, it's okay. Paolo

Re: [Qemu-devel] [PATCH 2/2] iotests: fix 109

2016-08-04 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 03.08.2016 17:22, Sascha Silbe wrote: [...] >> What are the exact semantics of the "offset" field for >> BLOCK_JOB_COMPLETED? >> >> docs/qmp-events.txt is rather vague. As an API consumer I'd have assumed >> that everything up to offset has been completed succes

Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-04 Thread Vijay Kilari
Hi Paolo, On Tue, Aug 2, 2016 at 4:18 PM, Paolo Bonzini wrote: > - Original Message - >> From: "vijay kilari" >> To: qemu-...@nongnu.org, "peter maydell" , >> pbonz...@redhat.com >> Cc: qemu-devel@nongnu.org, "Prasun Kapoor" , >> "vijay kilari" , >> "Vijaya Kumar K" >> Sent: Tuesday,

Re: [Qemu-devel] [PULL for-2.7 0/3] vnc: fixes for "-vnc none".

2016-08-04 Thread Peter Maydell
On 3 August 2016 at 16:35, Gerd Hoffmann wrote: > Hi, > > vnc patch queue, with three patches fixing "-vnc none" with > connects via monitor fd passing. > > cheers, > Gerd > > The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60: > > MAINTAINERS: Update the Xilinx main

Re: [Qemu-devel] [PATCH v7 02/16] block: Convert bdrv_pwrite_compressed() to BdrvChild

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 11:17:41AM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > Reviewed-by: Eric Blake > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wol

Re: [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Wei Liu
The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is

Re: [Qemu-devel] [PATCH v7 00/16] backup compression

2016-08-04 Thread Stefan Hajnoczi
On Fri, Jul 22, 2016 at 11:17:39AM +0300, Denis V. Lunev wrote: > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > These patches add the ability to compress data during backup. T

Re: [Qemu-devel] [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread David Vrabel
On 03/08/16 15:36, David Vrabel wrote: > On 02/08/16 15:06, Paulina Szubarczyk wrote: >> >> +/** >> + * Copy memory from or to grant references. The information of each >> operations >> + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value >> indicate >> + * the direction of an o

Re: [Qemu-devel] [PATCH v24 01/12] unblock backup operations in backing file

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:42PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > --- > block.c | 17 + > 1 file changed, 17 insertions(+) Reviewed-by: Stefan Hajnoczi signature

Re: [Qemu-devel] [PATCH v24 02/12] Backup: clear all bitmap when doing block checkpoint

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:43PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block/backup.c | 18 +

Re: [Qemu-devel] [PATCH v24 03/12] Backup: export interfaces for extra serialization

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:44PM +0800, Changlong Xie wrote: > Normal backup(sync='none') workflow: > step 1. NBD peformance I/O write from client to server >qcow2_co_writev > bdrv_co_writev > ... >bdrv_aligned_pwritev > notifier_with_return_list_notify -> backup_do_c

Re: [Qemu-devel] [PATCH v24 05/12] docs: block replication's description

2016-08-04 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 03:01:46PM +0800, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 239 > +++

Re: [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits

2016-08-04 Thread Stefan Hajnoczi
On Thu, Jul 28, 2016 at 11:08:11AM +0300, Alberto Garcia wrote: > Hello, > > Gu Nini found this problem and reported it in > > https://bugzilla.redhat.com/show_bug.cgi?id=1355665 > > When setting the throttling configuration, the burst limits can be > lower than the normal limits. This does not

Re: [Qemu-devel] [PATCH v4] block/gluster: add support to choose libgfapi logfile

2016-08-04 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > currently all the libgfapi logs defaults to '/dev/stderr' as it was hardcoded > in a call to glfs logging api. When the debug level is chosen to DEBUG/TRACE, > gfapi logs will be huge and fill/overflow the console view. > > This patch provides a commandline option

Re: [Qemu-devel] [PULL v2 00/25] Misc QEMU fixes for 2016-08-02

2016-08-04 Thread Peter Maydell
On 3 August 2016 at 18:04, Paolo Bonzini wrote: > The following changes since commit cc0100f464c94bf80ad36cd432f4a1ed58126b60: > > MAINTAINERS: Update the Xilinx maintainers (2016-08-01 15:31:32 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-u

Re: [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Paulina Szubarczyk
On 08/04/2016 11:38 AM, Wei Liu wrote: The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: In a linux part an ioctl(gntdev, IOCTL

[Qemu-devel] [PATCH] tests: Rename qtests which have names ending "error"

2016-08-04 Thread Peter Maydell
We have three qtest tests which have test names ending with "error". This is awkward because the output of verbose test runs looks like /crypto/task/error: OK /crypto/task/thread_error: OK which gives fa

Re: [Qemu-devel] [PULL 1/2] spapr: Error out when CPU hotplug is attempted on older pseries machines

2016-08-04 Thread Bharata B Rao
On Wed, Aug 03, 2016 at 03:25:50PM +1000, David Gibson wrote: > From: Bharata B Rao > > CPU hotplug and coldplug aren't supported prior to pseries-2.7. Further, > earlier machine types don't use CPU core objects at all. These mean that > query-hotpluggable-cpus and coldplug on older pseries mac

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-08-04 Thread Robie Basak
Uploaded to Xenial, thanks. Am I right in thinking that the new option force_size is required to be used with the patch to fix the problem? It's probably worth mentioning this in the Test Case in the bug description; otherwise it will appear to testers that the fix doesn't work. -- You received t

Re: [Qemu-devel] [PATCH v2] net: check fragment length during fragmentation

2016-08-04 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman On Thu, Aug 4, 2016 at 12:30 AM, P J P wrote: > From: Prasad J Pandit > > Network transport abstraction layer supports packet fragmentation. > While fragmenting a packet, it checks for more fragments from > packet length and current fragment length. It is susceptib

[Qemu-devel] [PATCH v2 for-2.7] Update ancient copyright string in -version output

2016-08-04 Thread Peter Maydell
Currently the -version command line argument prints a string ending with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some eight years out of date; abstract it out of the several places that print the string and update it to: Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Gonglei (Arei)
Hi Xin, Thanks for your feedback! Please see my embedded reply. Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Thursday, August 04, 2016 3:48 PM > To: Gonglei (Arei); qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: Huangpeng (Pe

Re: [Qemu-devel] [PATCH] tests: Rename qtests which have names ending "error"

2016-08-04 Thread Daniel P. Berrange
On Thu, Aug 04, 2016 at 11:39:38AM +0100, Peter Maydell wrote: > We have three qtest tests which have test names ending with "error". > This is awkward because the output of verbose test runs looks like > /crypto/task/error: OK > /crypto/task/thr

Re: [Qemu-devel] [PATCH v1 1/1] block/gluster: improve defense over string to int conversion

2016-08-04 Thread Markus Armbruster
Cc: Eric, because there's a relation to QAPI even though the patch doesn't touch the schema. Prasanna Kumar Kalever writes: > using atoi() for converting string to int may be error prone in case if > string supplied in the argument is not a fold of numerical number, > > This is not a bug because

[Qemu-devel] [PATCH for-2.7] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
If a qdev block device is created with an anonymous BlockBackend (i.e. a node name rather than a BB name was given for the drive property), qdev used to return an empty string when the property was read. This patch fixes it to return the node name instead. Signed-off-by: Kevin Wolf --- hw/core/q

Re: [Qemu-devel] [PATCH] trace: add syslog tracing backend

2016-08-04 Thread Stefan Hajnoczi
On Tue, Aug 02, 2016 at 04:06:42PM +0100, Paul Durrant wrote: > This patch adds a tracing backend which sends output using syslog(). > The syslog backend is limited to POSIX compliant systems. > > openlog() is called with facility set to LOG_DAEMON, with the LOG_PID > option. Trace events are logg

[Qemu-devel] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
If a qdev block device is created with an anonymous BlockBackend (i.e. a node name rather than a BB name was given for the drive property), qdev used to return an empty string when the property was read. This patch fixes it to return the node name instead. Signed-off-by: Kevin Wolf --- v2: - Chec

Re: [Qemu-devel] [PATCH for-2.7] block: Accept any target node for transactional blockdev-backup

2016-08-04 Thread Stefan Hajnoczi
On Tue, Aug 02, 2016 at 07:22:04PM +0200, Kevin Wolf wrote: > Commit 0d978913 changed blockdev-backup to accept arbitrary node names > instead of device names (i.e. root nodes) for the backup target. > However, it forgot to make the same change in transactions and to update > the documentation. Thi

Re: [Qemu-devel] [PATCH for-2.7] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Kevin Wolf
Am 04.08.2016 um 14:03 hat Kevin Wolf geschrieben: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the no

Re: [Qemu-devel] [RFC PATCH v1 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-04 Thread Paolo Bonzini
> > Third, it's probably a bad idea to call this function from generic code, so > > make it static and add the detection function from patch 2/2 already here. > > By making it static, it's also possible to define it only if CONFIG_LINUX > > is defined; the ThunderX detection will then return false

Re: [Qemu-devel] [PATCH] trace: add syslog tracing backend

2016-08-04 Thread Paul Durrant
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: 04 August 2016 13:04 > To: Paul Durrant > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH] trace: add syslog tracing backend > > On Tue, Aug 02, 2016 at 04:06:42PM +0100, Paul Durrant wrote: > > This patch ad

Re: [Qemu-devel] [PATCH] virtio-blk: rename virtio_device_info to virtio_blk_info

2016-08-04 Thread Stefan Hajnoczi
On Wed, Aug 03, 2016 at 04:49:07PM +0800, Changlong Xie wrote: > The old one is confusing with @virtio_device_info in virtio.c, > so make it more appropriate. > > Signed-off-by: Changlong Xie > --- > hw/block/virtio-blk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, appli

Re: [Qemu-devel] [PATCH] docker: Be compatible with older docker

2016-08-04 Thread Paolo Bonzini
On 04/08/2016 04:33, Fam Zheng wrote: > On Wed, 08/03 13:42, Fam Zheng wrote: >> By not using "--format" with docker images command. >> >> The option is not available on RHEL 7 docker command. Use an awk >> matching command instead. >> >> Reported-by: Paolo Bonzini >> Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset

2016-08-04 Thread Paolo Bonzini
On 03/08/2016 02:52, Fam Zheng wrote: >> > It's also (perhaps especially) because blk_drain() can consume them. Fam's >> > patch to do blk_drain() first would cause a double-free. > That "consume" part is what I don't understand. > > Shouldn't blk_drain() only process submitted requests (and fu

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Paolo Bonzini
On 03/08/2016 04:36, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: >> >> >> - Original Message - >>> From: "Fam Zheng" >>> To: qemu-devel@nongnu.org >>> Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, >>> kw...@redhat.com, mre...@redhat.com, >>> mdr...@linu

Re: [Qemu-devel] [PATCH v3 0/2] Two virtio-blk fixes

2016-08-04 Thread Stefan Hajnoczi
On Thu, Aug 04, 2016 at 10:44:12AM +0800, Fam Zheng wrote: > v3: Patch 1: add comment as Laszlo suggested, and add his r-b too. :) > > Fam Zheng (2): > virtio-blk: Release s->rq queue at system_reset > virtio-blk: Remove stale comment about draining > > hw/block/virtio-blk.c | 13 +--

[Qemu-devel] [RESEND PATCH V5 6/6] coroutine: reduce stack size to 64kB

2016-08-04 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

[Qemu-devel] [RESEND PATCH V5 0/6] coroutine: mmap stack memory and stack size

2016-08-04 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

[Qemu-devel] [RESEND PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/corouti

[Qemu-devel] [RESEND PATCH V5 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/

[Qemu-devel] [RESEND PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage

2016-08-04 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini --- configure | 19 +++ util/oslib-posix.c | 37 + 2 files changed, 56 insertions(+) diff

[Qemu-devel] [RESEND PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free

2016-08-04 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake --- in

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 4:44 PM Paolo Bonzini wrote: > > > On 03/08/2016 04:36, Fam Zheng wrote: > > On Tue, 08/02 15:45, Paolo Bonzini wrote: > >> > >> > >> - Original Message - > >>> From: "Fam Zheng" > >>> To: qemu-devel@nongnu.org > >>> Cc: f...@redhat.com, berra...@redhat.com, pb

[Qemu-devel] [RESEND PATCH V5 2/6] coroutine: add a macro for the coroutine stack size

2016-08-04 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --

[Qemu-devel] [PATCH v1 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.c |1 + target-ppc/translate/vmx-ops.c |1 + 4 files changed, 23 in

[Qemu-devel] [PATCH v1 5/5] target-ppc: add vector permute right indexed instruction

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.c | 18 ++ target-ppc/translate/vmx-ops.c |1 + 4 f

[Qemu-devel] [PATCH v1 0/5] POWER9 TCG enablement - part3

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH v1 1/5] target-ppc: add vector insert instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 target

[Qemu-devel] [PATCH v1 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] [PATCH v1 2/5] target-ppc: add vector extract instructions

2016-08-04 Thread Rajalakshmi Srinivasaraghavan
The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Markus Armbruster
Copying the QGA maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Free the list, not just the elements. > > Signed-off-by: Marc-André Lureau > --- > include/glib-compat.h | 9 + > qga/main.c| 8 ++-- > 2 files changed, 11 insertions(+), 6 del

Re: [Qemu-devel] [PATCH for-2.7 v3 04/36] qga: free remaining leaking state

2016-08-04 Thread Markus Armbruster
Copying the QGA maintainer. marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qga/guest-agent-command-state.c | 7 +++ > qga/guest-agent-core.h | 1 + > qga/main.c | 6 ++ > 3 files changed, 14 inser

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > Copying the QGA maintainer. > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Free the list, not just the elements. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/glib-compat.h | 9 + > > qga/main.c

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on > class base init name generation instead. Get rid of some leaks that way. > > Signed-off-by: Marc-André Lureau > --- > hw/core/machine.c| 1 + > includ

[Qemu-devel] [PATCH v2] trace: add syslog tracing backend

2016-08-04 Thread Paul Durrant
This patch adds a tracing backend which sends output using syslog(). The syslog backend is limited to POSIX compliant systems. openlog() is called with facility set to LOG_DAEMON, with the LOG_PID option. Trace events are logged at level LOG_INFO. Signed-off-by: Paul Durrant Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin

2016-08-04 Thread Anthony PERARD
On Wed, Jul 27, 2016 at 09:30:48AM -0600, Bruce Rogers wrote: > Commit 5a11d0f7 mistakenly converted a log message into an error > condition when no pin interrupt is found for the pci device being > passed through. Revert that part of the commit. > > Signed-off-by: Bruce Rogers Acked-by: Anthony

[Qemu-devel] [PULL 3/5] linux-user: Don't write off end of new_utsname buffer

2016-08-04 Thread riku . voipio
From: Peter Maydell Use g_strlcpy() rather than strcpy() to copy the uname string into the structure we return to the guest for the uname syscall. This avoids overrunning the buffer if the user passed us an overlong string via the QEMU command line. We fix a comment typo while we're in the neigh

[Qemu-devel] [PULL 5/5] linux-user: Handle brk() attempts with very large sizes

2016-08-04 Thread riku . voipio
From: Peter Maydell In do_brk(), we were inadvertently truncating the size of a requested brk() from the guest by putting it into an 'int' variable. This meant that we would incorrectly report success back to the guest rather than a failed allocation, typically resulting in the guest then segfaul

[Qemu-devel] [PULL 1/5] linux-user: Use correct alignment for long long on i386 guests

2016-08-04 Thread riku . voipio
From: Peter Maydell For i386, the ABI specifies that 'long long' (8 byte values) need only be 4 aligned, but we were requiring them to be 8-aligned. This meant we were laying out the target_epoll_event structure wrongly. Add a suitable ifdef to abitypes.h to specify the i386-specific alignment re

[Qemu-devel] [PULL 0/5] linux-user fixes for 2.7

2016-08-04 Thread riku . voipio
iku.voipio/qemu.git tags/pull-linux-user-20160804 for you to fetch changes up to ef4330c23bb47b97a859dbdbae1c784fd2ca402f: linux-user: Handle brk() attempts with very large sizes (2016-08-04 16:38:17 +0300) linux-user important fix

[Qemu-devel] [PULL 4/5] linux-user: Fix target_semid_ds structure definition

2016-08-04 Thread riku . voipio
From: Peter Maydell The target_semid_ds structure is not correct for all architectures: the padding fields should only exist for: * 32-bit ABIs * x86 It is also misnamed, since it is following the kernel semid64_ds structure (QEMU doesn't support the legacy semid_ds structure at all). Rename t

[Qemu-devel] [PULL 2/5] linux-user: Fix memchr() argument in open_self_cmdline()

2016-08-04 Thread riku . voipio
From: Peter Maydell In open_self_cmdline() we look for a 0 in the buffer we read from /prc/self/cmdline. We were incorrectly passing the length of our buf[] array to memchr() as the length to search, rather than the number of bytes we actually read into it, which could be shorter. This was spotte

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 5:58 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on > > class base init name generation instead. Get rid of some leaks that way. > > > > Si

Re: [Qemu-devel] [Patch v1 26/29] qmp: add QMP interface "query-cpu-model-baseline"

2016-08-04 Thread Eduardo Habkost
On Thu, Aug 04, 2016 at 09:32:22AM +0200, David Hildenbrand wrote: > ## > > # @query-cpu-model-baseline: > > #

Re: [Qemu-devel] [Patch v1 25/29] qmp: add QMP interface "query-cpu-model-comparison"

2016-08-04 Thread Eduardo Habkost
On Thu, Aug 04, 2016 at 09:34:16AM +0200, David Hildenbrand wrote: > ## > > # @CpuModelCompareResult: > > #

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Copying the QGA maintainer. >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Free the list, not just the elements. >> > >> > Signed-off-by: Marc-André Lureau >> > --- >> > include/glib-compa

Re: [Qemu-devel] [PATCH for-2.7 v3 23/36] pc: keep gsi reference

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Further cleanup would need to call qemu_free_irq() at the appropriate > time, but for now this silences ASAN about direct leaks. > > Signed-off-by: Marc-André Lureau I looked into cleaning up the qemu_irq allocation mess long ago

Re: [Qemu-devel] [PATCH for-2.7 v3 35/36] ahci: fix sglist leak on retry

2016-08-04 Thread Markus Armbruster
John, can you review this one? marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) >

Re: [Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

2016-08-04 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Allows one to specify a destroy function for the test data. > > Signed-off-by: Marc-André Lureau > --- > tests/libqtest.c | 15 +++ > tests/libqtest.h | 7 ++- > 2 files changed, 21 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Copying the QGA maintainer. > >> > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > Free the list, not just the elements. > >> > > >> > Signed

Re: [Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

2016-08-04 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Allows one to specify a destroy function for the test data. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/libqtest.c | 15 +++ > > tests/libqtest.h | 7 ++-

Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

2016-08-04 Thread Ladi Prosek
On Wed, Aug 3, 2016 at 9:25 AM, Ladi Prosek wrote: > On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: >> On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang Z wrote: >>> > On Wed, Jul 06, 2016 at 12:49:06PM +, Li, Liang Z wrote: >>> > > > > > > After live migration, 'guest-stats' can

Re: [Qemu-devel] [PATCH for-2.7 v3 17/36] machine: use class base init generated name

2016-08-04 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 4, 2016 at 5:58 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Remove machine class name initialization from DEFINE_PC_MACHINE, rely on >> > class base init name generation instead. Ge

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-08-04 Thread Nish Aravamudan
On 04.08.2016 [10:49:47 -], Robie Basak wrote: > Uploaded to Xenial, thanks. Am I right in thinking that the new option > force_size is required to be used with the patch to fix the problem? > It's probably worth mentioning this in the Test Case in the bug > description; otherwise it will appea

Re: [Qemu-devel] [PATCH v2 for-2.7] Update ancient copyright string in -version output

2016-08-04 Thread Eric Blake
On 08/04/2016 05:14 AM, Peter Maydell wrote: > Currently the -version command line argument prints a string ending > with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some > eight years out of date; abstract it out of the several places that > print the string and update it to: > > Copy

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Jeff Cody
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH for-2.7 v2] block/qdev: Let 'drive' property fall back to node name

2016-08-04 Thread Eric Blake
On 08/04/2016 06:09 AM, Kevin Wolf wrote: > If a qdev block device is created with an anonymous BlockBackend (i.e. > a node name rather than a BB name was given for the drive property), > qdev used to return an empty string when the property was read. This > patch fixes it to return the node name i

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Daniel P. Berrange
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

2016-08-04 Thread Eric Blake
On 08/01/2016 01:47 PM, Kevin Wolf wrote: > Am 14.07.2016 um 21:48 hat Eric Blake geschrieben: >> On 07/14/2016 07:49 AM, Kevin Wolf wrote: >>> This allows to create an empty ide-cd device without manually creating a >>> BlockBackend. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> hw/ide/qdev.c |

Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status

2016-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 05:14:14PM +0200, Ladi Prosek wrote: > On Wed, Aug 3, 2016 at 9:25 AM, Ladi Prosek wrote: > > On Tue, Aug 2, 2016 at 2:11 AM, Michael S. Tsirkin wrote: > >> On Mon, Aug 01, 2016 at 11:59:31PM +, Li, Liang Z wrote: > >>> > On Wed, Jul 06, 2016 at 12:49:06PM +, Li, L

[Qemu-devel] [PATCH v4 for-2.7 0/7] Fixing i686 host / sparc64 guest crash

2016-08-04 Thread Richard Henderson
This is a revision of my "third" attempt, tweaked a bit for Aurelien's review. I've sort of lost track of where we are with the release process, so I'll understand if we've gone too far now. r~ Richard Henderson (7): tcg: Compress liveness data to 16 bits tcg: Reorg TCGOp chaining tcg: F

[Qemu-devel] [PATCH v4 for-2.7 1/7] tcg: Compress liveness data to 16 bits

2016-08-04 Thread Richard Henderson
This reduces both memory usage and per-insn cacheline usage during code generation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 58 ++ tcg/tcg.h | 16 ++-- 2 files changed, 32 insertions(+), 42

[Qemu-devel] [PATCH v4 for-2.7 2/7] tcg: Reorg TCGOp chaining

2016-08-04 Thread Richard Henderson
Instead of using -1 as end of chain, use 0, and link through the 0 entry as a fully circular double-linked list. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/optimize.c| 8 ++-- tcg/tcg-op.c | 2 +- tcg/tcg.c | 35

[Qemu-devel] [PATCH v4 for-2.7 3/7] tcg: Fold life data into TCGOp

2016-08-04 Thread Richard Henderson
Reduce the size of other bitfields to make room. This reduces the cache footprint of compilation. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 +++-- tcg/tcg.h | 26 ++ 2 files changed, 17 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH v4 for-2.7 6/7] tcg: Require liveness analysis

2016-08-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index b0a88ba..3c1f526 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -23,7 +23,6 @@ */ /* define it to use liveness analysis

  1   2   >