[Qemu-devel] [PATCH 0/5] POWER9 TCG enablement - part3

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH 1/5] target-ppc: add vector insert instructions

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 target

[Qemu-devel] [PATCH 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] [PATCH 2/5] target-ppc: add vector extract instructions

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

[Qemu-devel] [PATCH 5/5] target-ppc: add vector permute right indexed instruction

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.c | 18 ++ target-ppc/translate/vmx-ops.c |1 + 4 f

[Qemu-devel] [PATCH 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-01 Thread Rajalakshmi Srinivasaraghavan
Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.c |1 + target-ppc/translate/vmx-ops.c |1 + 4 files changed, 23 in

Re: [Qemu-devel] [PATCH v5 5/8] irq: Add a new irq device that allows the ORing of lines

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 03:21, Alistair Francis wrote: > On Tue, Jul 26, 2016 at 8:00 AM, Peter Maydell > wrote: >> The data in the memory pointed to by 'levels' is state, and you >> need to migrate it somehow. (Otherwise you'll give the wrong >> results the next time an input changes following a mi

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 00:35:35 + "kwangwoo@sk.com" wrote: > Hi Peter, > > Thanks a lot for your comments! I answered in line below. > > > -Original Message- > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > Sent: Saturday, July 30, 2016 3:10 AM > > To: 이광우(LEE KWANGWOO)

[Qemu-devel] [PATCH] vhost: don't set vring call if no vector

2016-08-01 Thread Jason Wang
We used to set vring call fd unconditionally even if guest driver does not use MSIX for this vritqueue at all. This will cause lots of unnecessary userspace access and other checks for drivers does not use interrupt at all (e.g virtio-net pmd). So check and clean vring call fd if guest does not use

Re: [Qemu-devel] [PATCH 0/3] qdist fixes

2016-08-01 Thread Paolo Bonzini
On 25/07/2016 17:03, Emilio G. Cota wrote: > While fixing the return of a NULL string when printing an empty > dist (patch 3) (see background here [*]), I noticed there was > a leak in qdist (patch 1). Patch 2 is trivial. > > Thanks, > > Emilio > > [*] https://lists.gnu.org/archi

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 08:46, Igor Mammedov wrote: > On Mon, 1 Aug 2016 00:35:35 + > "kwangwoo@sk.com" wrote: >> > > +/* 1GB alignment for hotplug memory region */ >> > > +#define ARCH_VIRT_HOTPLUG_MEM_ALIGN (1ULL << 30) >> > >> > Where does the 1GB alignment come from? Why do we need 1GB >

Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-08-01 Thread Paolo Bonzini
On 26/07/2016 11:03, Cao jin wrote: > My previous commit 2e2aa316 removed internal flag msi_in_use, which > exists in vmstate, use VMSTATE_UNUSED for migration compatibility. > > Reported-by: Amit Shah > Suggested-by: Amit Shah > Cc: Markus Armbruster > Cc: Marcel Apfelbaum > Cc: Paolo Bonzi

Re: [Qemu-devel] [PATCH for-2.7] wxx: Truncate files used for character devices

2016-08-01 Thread Paolo Bonzini
On 26/07/2016 19:11, Stefan Weil wrote: > On Windows, such files were not truncated like on all other hosts. > Now we also test whether truncation is needed when running on Windows. > > Reported-by: Benjamin David Lunt > Signed-off-by: Stefan Weil > --- > qemu-char.c | 11 ++- > 1 fil

Re: [Qemu-devel] [PATCH v2] i2c: fix migration regression introduced by broadcast support

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 14:39, Igor Mammedov wrote: > QEMU fails migration with following error: > > qemu-system-x86_64: Missing section footer for i2c_bus > qemu-system-x86_64: load of migration failed: Invalid argument > > when migrating from: > qemu-system-x86_64-v2.6.0 -m 256M rhel72.img -M pc-i440

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 00:07, John Snow wrote: > If one attempts to perform a system_reset after a failed IO request > that causes the VM to enter a paused state, QEMU will segfault trying > to free up the pending IO requests. > > These requests have already been completed and freed, though, so all > we

Re: [Qemu-devel] [PATCH] help: Update help to reflect that GTK is the default

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 18:21, Colin Lord wrote: > Updates the messages displayed in the help option to reflect that GTK is > the default display, not SDL. > --- > qemu-options.hx | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx

Re: [Qemu-devel] [PATCH] linux-user: Use correct alignment for long long on i386 guests

2016-08-01 Thread Riku Voipio
On Thu, Jul 28, 2016 at 12:57:59PM +0100, Peter Maydell wrote: > For i386, the ABI specifies that 'long long' (8 byte values) > need only be 4 aligned, but we were requiring them to be > 8-aligned. This meant we were laying out the target_epoll_event > structure wrongly. Add a suitable ifdef to abi

Re: [Qemu-devel] [PULL v2 for-2.7 02/15] qapi: change QmpInputVisitor to QSLIST

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 23:37, Laszlo Ersek wrote: > It seems to me that QEMU deadlocks when it tries to emit the > SPICE_DISCONNECTED event. > > (Note that I can't find "handle SPICE_DISCONNECTED" in the libvirtd log > even in the successful case (i.e., when QEMU is built at the parent of > 3d344c2aabb7)

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt: add hotplug memory support

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 09:13:34 +0100 Peter Maydell wrote: > On 1 August 2016 at 08:46, Igor Mammedov wrote: > > On Mon, 1 Aug 2016 00:35:35 + > > "kwangwoo@sk.com" wrote: > > >> > > +/* 1GB alignment for hotplug memory region */ > >> > > +#define ARCH_VIRT_HOTPLUG_MEM_ALIGN (1ULL << 30)

Re: [Qemu-devel] VM CPU/Disk unexplained increase in resize time

2016-08-01 Thread Chathura M. Sarathchandra Magurawalage
A kind reminder about the following email. Thanks! > On 29 Jul 2016, at 11:30, Chathura M. Sarathchandra Magurawalage > <77.chath...@gmail.com> wrote: > > Hi, > > Does anyone know the reason for, VM resizing time to increase faster if you > continuously increase CPU or DISK resources by +1 (

Re: [Qemu-devel] [PATCH 2/4] nbd: Limit nbdflags to 16 bits

2016-08-01 Thread Paolo Bonzini
On 21/07/2016 21:34, Eric Blake wrote: > Furthermore, upstream NBD has never passed the global flags to > the kernel via ioctl(NBD_SET_FLAGS) (the ioctl was first > introduced in NBD 2.9.22; then a latent bug in NBD 3.1 actually > tried to OR the global flags with the transmission flags, with > t

Re: [Qemu-devel] [PATCH 3/4] osdep: Document differences in rounding macros

2016-08-01 Thread Paolo Bonzini
On 21/07/2016 21:34, Eric Blake wrote: > Make it obvious which macros are safe in which situations. > > Useful since QEMU_ALIGN_UP and ROUND_UP both purport to do > the same thing, but differ on whether the alignment must be > a power of 2. > > Signed-off-by: Eric Blake > --- > include/qemu/o

Re: [Qemu-devel] [PATCH v2] i2c: fix migration regression introduced by broadcast support

2016-08-01 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > QEMU fails migration with following error: > > qemu-system-x86_64: Missing section footer for i2c_bus > qemu-system-x86_64: load of migration failed: Invalid argument > > when migrating from: > qemu-system-x86_64-v2.6.0 -m 256M rhel72.img -M pc-i44

Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 04:39, Eric Blake wrote: > On 07/27/2016 01:25 AM, Fam Zheng wrote: >> On Thu, 07/21 13:34, Eric Blake wrote: >>> +max_write_zeroes = max_write_zeroes / alignment * alignment; >> >> Not using QEMU_ALIGN_DOWN despite patch 3? > > Looks like I missed that on the rebase. Can fix i

[Qemu-devel] [PATCH v6 2/2] virtio-crypto: add conformance clauses

2016-08-01 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..915a9f0 100644 --- a/conformance.tex +++ b/conformance

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Daniel P. Berrange
On Sat, Jul 30, 2016 at 05:57:02PM +0900, Namhyung Kim wrote: > On Thu, Jul 28, 2016 at 02:22:39PM +0100, Daniel P. Berrange wrote: > > > +static void virtio_pstore_from_filename(VirtIOPstore *s, char *name, > > > +char *buf, size_t sz, > > > +

Re: [Qemu-devel] [PULL v2 for-2.7 02/15] qapi: change QmpInputVisitor to QSLIST

2016-08-01 Thread Marc-André Lureau
Hi - Original Message - > > > On 27/07/2016 23:37, Laszlo Ersek wrote: > > It seems to me that QEMU deadlocks when it tries to emit the > > SPICE_DISCONNECTED event. > > > > (Note that I can't find "handle SPICE_DISCONNECTED" in the libvirtd log > > even in the successful case (i.e., wh

[Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification

2016-08-01 Thread Gonglei
This is the specification (version 6) about a new virtio crypto device. After a big reconstruction, the spec (symmetric algos) is near to stabilize. This version fix some problems of formating and return value, etc. If you have any comments, please let me know, thanks :) CC: Michael S. Tsirkin C

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Daniel P. Berrange
On Sat, Jul 30, 2016 at 05:38:27PM +0900, Namhyung Kim wrote: > Hello, > > On Thu, Jul 28, 2016 at 02:08:41PM +0100, Daniel P. Berrange wrote: > > On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > > > > On Thu, Ju

Re: [Qemu-devel] [PULL v2 for-2.7 02/15] qapi: change QmpInputVisitor to QSLIST

2016-08-01 Thread Paolo Bonzini
On 01/08/2016 11:24, Marc-André Lureau wrote: > Hi > > - Original Message - >> >> >> On 27/07/2016 23:37, Laszlo Ersek wrote: >>> It seems to me that QEMU deadlocks when it tries to emit the >>> SPICE_DISCONNECTED event. >>> >>> (Note that I can't find "handle SPICE_DISCONNECTED" in the

[Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-01 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei CC: Michael

[Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages

2016-08-01 Thread Paul Durrant
VMs created on older versions on Xen will not have been provisioned with pages to support creation of non-default ioreq servers. In this case the ioreq server API is not supported and QEMU's only option is to fall back to using the default ioreq server pages as it did prior to commit 3996e85c ("Xen

Re: [Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages

2016-08-01 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 01 August 2016 10:16 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: Paul Durrant; Stefano Stabellini; Anthony Perard > Subject: [PATCH] xen: handle inbound migration of VMs without ioreq se

Re: [Qemu-devel] VM CPU/Disk unexplained increase in resize time

2016-08-01 Thread Igor Mammedov
On Fri, 29 Jul 2016 11:30:00 +0100 "Chathura M. Sarathchandra Magurawalage" <77.chath...@gmail.com> wrote: > Hi, > > Does anyone know the reason for, VM resizing time to increase faster if you > continuously increase CPU or DISK resources by +1 (e.g. 1-2, 2-3, 3-4, 4-5). > Whereas, when you inc

Re: [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract

2016-08-01 Thread Paolo Bonzini
On 29/07/2016 10:08, Laszlo Ersek wrote: > On 07/29/16 09:29, Markus Armbruster wrote: >> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem". >> >> Signed-off-by: Markus Armbruster >> --- >> hw/nvram/fw_cfg.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/nvram/fw

Re: [Qemu-devel] [PATCH v2] util/qemu-sockets: revert Yoda Conditions to normal

2016-08-01 Thread Paolo Bonzini
On 29/07/2016 11:20, Daniel P. Berrange wrote: > Reviewed-by: Daniel P. Berrange Queued, thanks for the patch and the review. Paolo

Re: [Qemu-devel] [PATCH] linux-user: Use correct alignment for long long on i386 guests

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 10:04, Riku Voipio wrote: > On Thu, Jul 28, 2016 at 12:57:59PM +0100, Peter Maydell wrote: >> For i386, the ABI specifies that 'long long' (8 byte values) >> need only be 4 aligned, but we were requiring them to be >> 8-aligned. This meant we were laying out the target_epoll_ev

Re: [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic

2016-08-01 Thread Paolo Bonzini
On 29/07/2016 15:55, Igor Mammedov wrote: > commit f6e98444 (apic: Use apic_id as apic's migration instance_id) > breaks migration when in kernel irqchip is used for 2.6 and older > machine types. > > It applies compat property only for userspace 'apic' type > instead of applying it to all apic

Re: [Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-01 Thread Daniel P. Berrange
The original mail didn't appear to hit the list, so I'm avoiding trimming any quoted text for benefit of others. On Sun, Jul 31, 2016 at 06:06:30PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads ca

Re: [Qemu-devel] [PATCH for-2.8] qtail: clean up direct access to tqe_prev field

2016-08-01 Thread Paolo Bonzini
On 25/07/2016 14:47, Igor Mammedov wrote: > instead of accessing tqe_prev field dircetly outside > of queue.h use macros to check if element is in list > and make sure that afer element is removed from list > tqe_prev field could be used to do the same check. > > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH v2 0/3] Remove the obsolete non-blocking connect

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 11:03, Cao jin wrote: > forget to cc maintainers in cover-letter.. Patches 1 and 2 look good, thanks! > On 07/28/2016 04:54 PM, Cao jin wrote: >> v2 changelog: >> 1. revert the yoda-condition in patch 2 (Daniel) >> >> Cao jin (3): >>util: remove the obsolete non-blocking conne

[Qemu-devel] [PATCHv3 RESEND] ppc: Rename #include'd .c files to .inc.c

2016-08-01 Thread Benjamin Herrenschmidt
Also while at it, group the #include statements in translate.c Signed-off-by: Benjamin Herrenschmidt --- target-ppc/translate.c | 40 +++--- .../translate/{dfp-impl.c => dfp-impl.inc.c} | 0 target-ppc/translate/{dfp-ops.c => dfp-ops.inc.c} |

Re: [Qemu-devel] [PATCH for 2.8 1/3] rules.mak: Don't extract libs from .mo-libs in link command

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 08:26, Fam Zheng wrote: > For module build, .mo objects are passed to LINK and consumed in > process-archive-undefs. The reason behind that is documented in the > comment above process-archive-undefs. > > Similarly, extract-libs should be called with .mo filtered out too. > Otherwi

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 08:26, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > Makefile.objs | 1 + > configure | 4 +-- > include/qemu/module.h | 2 ++ > include/ui/console.h | 5 ++-- > ui/Makefile.objs | 2 ++ > ui/sdl-init.c | 75 > +

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 07:17, Fam Zheng wrote: > On Wed, 07/27 19:23, Colin Lord wrote: >> On 07/27/2016 02:26 AM, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng >>> --- >>> Makefile.objs | 1 + >>> configure | 4 +-- >>> include/qemu/module.h | 2 ++ >>> include/ui/console.h | 5

Re: [Qemu-devel] [PATCH v2] x86: ioapic: conditionally upgrade IOAPIC version

2016-08-01 Thread Paolo Bonzini
On 26/07/2016 05:28, Peter Xu wrote: > IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well > together with some old Linux kernels (upstream before v4.0, or any > released RHEL kernels). This patch fixes it. > > The problem is that: some old linux kernels (with IR enabled) only > su

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-08-01 Thread Daniel P. Berrange
On Wed, Jul 27, 2016 at 02:26:17PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > Makefile.objs | 1 + > configure | 4 +-- > include/qemu/module.h | 2 ++ > include/ui/console.h | 5 ++-- > ui/Makefile.objs | 2 ++ > ui/sdl-init.c | 75 > ++

Re: [Qemu-devel] [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive

2016-08-01 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Since there in wrapper around madvise(), the virtio-balloon > code is able to work without the precompiled directive, the > directive can be removed. > > Signed-off-by: Liang Li > Suggested-by: Thomas Huth This one could be posted separately. Reviewed

Re: [Qemu-devel] R: [PATCH v2] Unbreak FreeBSD build after optionrom update.

2016-08-01 Thread Paolo Bonzini
On 26/07/2016 23:07, Sean Bruno wrote: > > Thanks for the pointer to the right fix. Confirmed that your changes > DTRT for FreeBSD. > > I still need the LD_EMULATION addition, which I have sent to the list as > a separate patch for review. Great, thanks! Paolo

Re: [Qemu-devel] [PATCH 1/1] ehci: faster frame index calculation for skipped frames

2016-08-01 Thread Denis V. Lunev
On 07/27/2016 06:55 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev ehci_update_frindex takes time linearly proportional to a number of uframes to calculate new frame index and raise FLR interrupts, which is a problem for large amounts of uframes. If we experience large delays between echi tim

Re: [Qemu-devel] [PATCH for 2.8?] x86: ioapic: ignore level irq during processing

2016-08-01 Thread Paolo Bonzini
On 31/07/2016 16:18, Peter Xu wrote: > For level triggered interrupts, we will get Remote IRR bit cleared after > guest kernel finished processing specific request. Before that, we > should ignore the same interrupt from triggering again. > > Signed-off-by: Peter Xu > --- > > I discovered this

[Qemu-devel] KVM call for agenda for 2016-08-02

2016-08-01 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

[Qemu-devel] [PATCH for-2.7 0/2] Fix spice audio crash regression

2016-08-01 Thread marcandre . lureau
From: Marc-André Lureau Hi, The monitor is being used atexit, during spice audio clean up, and this leads to a crash since the chardev are now being cleaned up at the end of main, before atexit handlers. Fix the crash by cleaning up the monitor when leaving, and restore the original event behav

[Qemu-devel] [PATCH for-2.7 2/2] audio: clean up before monitor clean up

2016-08-01 Thread marcandre . lureau
From: Marc-André Lureau Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu, before the atexit() handlers. audio_cleanup() may use the monitor to notify of changes. For compatibility reasons, let's clean up audio before the monitor so it keeps emitting monitor events. The audio_

Re: [Qemu-devel] [QEMU v2 7/9] bitmap: Add a new bitmap_move function

2016-08-01 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Sometimes, it is need to move a portion of bitmap to another place > in a large bitmap, if overlap happens, the bitmap_copy can't not > work correctly, we need a new function to do this work. > > Signed-off-by: Liang Li Reviewed-by: Dr. David Alan Gilbe

[Qemu-devel] [PATCH for-2.7 1/2] monitor: fix crash when leaving qemu with spice audio

2016-08-01 Thread marcandre . lureau
From: Marc-André Lureau Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu. However, the monitor has still references to them, which may lead to crashes when running atexit() and trying to send monitor events: #0 0x7fffdb18f6f5 in __GI_raise (sig=sig@entry=6) at ../sysde

Re: [Qemu-devel] [PATCH for-2.7 2/2] audio: clean up before monitor clean up

2016-08-01 Thread Paolo Bonzini
On 01/08/2016 13:23, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu, > before the atexit() handlers. audio_cleanup() may use the monitor to > notify of changes. For compatibility reasons, let's clean up audio

Re: [Qemu-devel] [PATCH for-2.7 2/2] audio: clean up before monitor clean up

2016-08-01 Thread Marc-André Lureau
Hi - Original Message - > From: Marc-André Lureau > > Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu, > before the atexit() handlers. audio_cleanup() may use the monitor to > notify of changes. For compatibility reasons, let's clean up audio > before the monitor so

Re: [Qemu-devel] [PATCH 2/4] nbd: Limit nbdflags to 16 bits

2016-08-01 Thread Eric Blake
On 08/01/2016 03:17 AM, Paolo Bonzini wrote: > > > On 21/07/2016 21:34, Eric Blake wrote: >> Furthermore, upstream NBD has never passed the global flags to >> the kernel via ioctl(NBD_SET_FLAGS) (the ioctl was first >> introduced in NBD 2.9.22; then a latent bug in NBD 3.1 actually >> tried to OR

Re: [Qemu-devel] [PATCH 0/3] trivial changes of timer & cpus

2016-08-01 Thread Paolo Bonzini
On 29/07/2016 13:05, Cao jin wrote: > Cc: Paolo Bonzini > Cc: Peter Maydell > Cc Peter Crosthwaite > Cc: Richard Henderson > > Cao jin (3): > timer: update comments > cpus: rename local variable to meaningful one > cpus: update comments > > cpus.c | 13 +++-- >

Re: [Qemu-devel] [PATCH 2/4] nbd: Limit nbdflags to 16 bits

2016-08-01 Thread Paolo Bonzini
On 01/08/2016 13:43, Eric Blake wrote: > On 08/01/2016 03:17 AM, Paolo Bonzini wrote: >> >> >> On 21/07/2016 21:34, Eric Blake wrote: >>> Furthermore, upstream NBD has never passed the global flags to >>> the kernel via ioctl(NBD_SET_FLAGS) (the ioctl was first >>> introduced in NBD 2.9.22; then

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-08-01 Thread Gerd Hoffmann
On Mi, 2016-07-27 at 14:26 +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng more verbose commit message please, especially for those (like me) who have not worked yet with modules. Will sdl be loaded unconditionally? Or only with -display sdl? What happens if the module is not present? The ma

Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-08-01 Thread Andrea Bolognani
On Fri, 2016-07-29 at 08:54 +0200, Andrew Jones wrote: > On Thu, Jul 28, 2016 at 11:38:16AM -0500, Wei Huang wrote: > >  > > This patch adds a pmu=[on/off] option to enable/disable vpmu support > > in guest vm. There are several reasons to justify this option. First > > vpmu can be problematic for

Re: [Qemu-devel] [PATCH v2 13/37] portio: keep references on portio

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 16:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The isa_register_portio_list() function allocates ioports > data/state. Let's keep the reference to this data on some owner. This > isn't enough to fix leaks, but at least, ASAN stops complaining of > direct

Re: [Qemu-devel] [PATCH v2 19/37] char: disconnect peer when qemu_chr_free()

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 16:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > chr_disconnect callback is used to cleanup server socket peer. This > removes some leaks when the chardev is freed. > > Signed-off-by: Marc-André Lureau > --- > qemu-char.c | 1 + > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH v2 20/37] char: free MuxDriver when closing

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 16:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Similarly to other chr_close callbacks, free char type specific data. > > Signed-off-by: Marc-André Lureau > --- > qemu-char.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/qemu-char.c

Re: [Qemu-devel] [PATCH v2 20/37] char: free MuxDriver when closing

2016-08-01 Thread Paolo Bonzini
On 01/08/2016 14:50, Paolo Bonzini wrote: > > > On 28/07/2016 16:37, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Similarly to other chr_close callbacks, free char type specific data. >> >> Signed-off-by: Marc-André Lureau >> --- >> qemu-char.c | 9 + >> 1 file

Re: [Qemu-devel] [PATCH v2 33/37] tests: add qtest_add_data_func_full

2016-08-01 Thread Eric Blake
On 07/29/2016 02:48 AM, Marc-André Lureau wrote: >>> +#if GLIB_CHECK_VERSION(2, 34, 0) >>> +gchar *path = g_strdup_printf("/%s/%s", qtest_get_arch(), str); >>> +g_test_add_data_func_full(path, data, fn, data_free_func); >>> +g_free(path); >>> +#else >>> +qtest_add_data_func(str, da

Re: [Qemu-devel] [PATCH 5/5] ppc: Improve generation of conditional traps

2016-08-01 Thread David Gibson
On Sun, Jul 31, 2016 at 03:13:13PM +1000, Benjamin Herrenschmidt wrote: > Translate most conditions to TCG conditions and avoid the helper > for most of the common cases. > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson The other patches in the series look good AFAICT, but I

Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-08-01 Thread Andrew Jones
On Mon, Aug 01, 2016 at 02:04:59PM +0200, Andrea Bolognani wrote: > On Fri, 2016-07-29 at 08:54 +0200, Andrew Jones wrote: > > On Thu, Jul 28, 2016 at 11:38:16AM -0500, Wei Huang wrote: > > >  > > > This patch adds a pmu=[on/off] option to enable/disable vpmu support > > > in guest vm. There are se

Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 14:08, Andrew Jones wrote: > Peter had a good suggestion for this. We need to wrap the property > addition in an arm_feature check like the has_el3 property. That will > remove it from all cpu types that don't support it. Then there's no > need for the enable_pmu && !has_pmu ch

Re: [Qemu-devel] [PATCH v4 01/11] block: Accept node-name for block-stream

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:04 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-stream to accept a node-name without lifting the restriction that > we're operating at a root node

Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-08-01 Thread Andrea Bolognani
On Mon, 2016-08-01 at 15:08 +0200, Andrew Jones wrote: > > I'm not sure a warning is enough: if I start a guest and > > explicitly ask for a PMU, I expect it to be there, or for > > the guest not to start at all. How does x86 behave in this > > regard? >  > Peter had a good suggestion for this. We

Re: [Qemu-devel] [PATCH v4 02/11] block: Accept node-name for block-commit

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:05 PM CEST, Kevin Wolf wrote: > -blk = blk_by_name(device); > -if (!blk) { > -error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, > - "Device '%s' not found", device); > +bs = qmp_get_root_bs(device, &local_err); > +if (!bs) { > +b

Re: [Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-08-01 Thread Peter Maydell
On 1 August 2016 at 14:26, Andrea Bolognani wrote: > On Mon, 2016-08-01 at 15:08 +0200, Andrew Jones wrote: >> > I'm not sure a warning is enough: if I start a guest and >> > explicitly ask for a PMU, I expect it to be there, or for >> > the guest not to start at all. How does x86 behave in this >

Re: [Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:07 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-mirror to accept a node-name without lifting the restriction > that we're operating at a root n

Re: [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:08 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-delete-internal-sync to accept a node-name without > lifting the restriction that we'r

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

2016-08-01 Thread Laszlo Ersek
On 08/01/16 04:53, Fam Zheng wrote: > This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to > drain IO requests), remove it. > > Suggested-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/bloc

Re: [Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

2016-08-01 Thread Paolo Bonzini
On 25/07/2016 13:43, Shmulik Ladkani wrote: > From: Shmulik Ladkani > > In cases where iov_copy() is passed with zero 'bytes' argument and a > non-zero 'offset' argument, nothing gets copied - as expected. > > However since no copy iterations are performed, 'offset' is left > unaltered, leadin

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 12:02, Roy Shterman wrote: > iSER is a new transport layer supported in Libiscsi, > iSER provides a zero-copy RDMA capable interface that can > improve performance. > > New API is introduced in abstracion of the Libiscsi transport layer. > In order to use the new iSER transport, on

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 10:45, Peter Lieven wrote: > > Furthermore I would suggest using LIBISCS_FEATURE_ISER and not the API > version in the > preprocessor commands. Actually I disagree with this suggestion. The new API could be used also if iSER is not used, can it? Thanks, Paolo

[Qemu-devel] [PATCH] MAINTAINERS: Add Host Memory Backends section

2016-08-01 Thread Eduardo Habkost
The hostmem code is closely related to the NUMA code, so I am willing to handle patches to those files and share the work with Igor (the original author of that code). Signed-off-by: Eduardo Habkost --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAIN

Re: [Qemu-devel] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:09 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-internal-sync to accept a node-name without lifting > the restriction that we're opera

[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This is a request to include a new block device protocol called vxhs in qemu. Following work items have been completed: (1) Rebase VxHS code to latest qemu master. (2) Removed all errors/warnings found by checkpatch.pl (3) Unit-tested qemu and qemu-io binaries to ensure that we are able to open a

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- block/Makefile.objs |1 + block/vxhs.c| 1460 ++

[Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI

2016-08-01 Thread Peter Xu
Some old Linux kernels (upstream before v4.0), or any released RHEL kernels has problem in sending APIC EOI when IR is enabled. Meanwhile, many of them only support explicit EOI for IOAPIC, which is only introduced in IOAPIC version 0x20. This patch provide a way to boost QEMU IOAPIC to version 0x2

Re: [Qemu-devel] [PATCH v2] x86: ioapic: conditionally upgrade IOAPIC version

2016-08-01 Thread Peter Xu
On Mon, Aug 01, 2016 at 12:38:58PM +0200, Paolo Bonzini wrote: > > > On 26/07/2016 05:28, Peter Xu wrote: > > IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well > > together with some old Linux kernels (upstream before v4.0, or any > > released RHEL kernels). This patch fixes it. >

[Qemu-devel] [PATCH RFC] Addition of Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This is a request to include a new block device protocol called vxhs in qemu. Following work items have been completed: (1) Rebase VxHS code to latest qemu master. (2) Removed all errors/warnings found by checkpatch.pl (3) Unit-tested qemu and qemu-io binaries to ensure that we are able to open a

Re: [Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:11 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-backup and the corresponding transaction action to accept a > node-name without lifting the restri

Re: [Qemu-devel] [PATCH for 2.8?] x86: ioapic: ignore level irq during processing

2016-08-01 Thread Peter Xu
On Mon, Aug 01, 2016 at 12:58:42PM +0200, Paolo Bonzini wrote: > > > On 31/07/2016 16:18, Peter Xu wrote: > > For level triggered interrupts, we will get Remote IRR bit cleared after > > guest kernel finished processing specific request. Before that, we > > should ignore the same interrupt from t

[Qemu-devel] [PATCH RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-08-01 Thread Ashish Mittal
This patch adds support for a new block device type called "vxhs". Source code for the library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- block/Makefile.objs |1 + block/vxhs.c| 1460 ++

Re: [Qemu-devel] [PATCH] vhost: don't set vring call if no vector

2016-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2016 at 04:07:58PM +0800, Jason Wang wrote: > We used to set vring call fd unconditionally even if guest driver does > not use MSIX for this vritqueue at all. This will cause lots of > unnecessary userspace access and other checks for drivers does not use > interrupt at all (e.g vir

Re: [Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file

2016-08-01 Thread Alberto Garcia
On Thu 14 Jul 2016 03:28:10 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > change-backing-file to accept a node-name without lifting the > restriction that we're operating at a ro

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Host Memory Backends section

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 10:52:42 -0300 Eduardo Habkost wrote: > The hostmem code is closely related to the NUMA code, so I am > willing to handle patches to those files and share the work with > Igor (the original author of that code). > > Signed-off-by: Eduardo Habkost > --- > MAINTAINERS | 7 +++

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Roy Shterman
On 8/1/2016 4:52 PM, Paolo Bonzini wrote: On 28/07/2016 10:45, Peter Lieven wrote: Furthermore I would suggest using LIBISCS_FEATURE_ISER and not the API version in the preprocessor commands. Actually I disagree with this suggestion. The new API could be used also if iSER is not used, can i

Re: [Qemu-devel] [PATCH] Fix bsd-user build errors after 8642c1b81e0418df066a7960a7426d85a923a253

2016-08-01 Thread Peter Maydell
On 29 July 2016 at 17:02, Sean Bruno wrote: > LINK sparc-bsd-user/qemu-sparc > bsd-user/main.o: In function `cpu_loop': > /home/sbruno/bsd/qemu/bsd-user/main.c:515: undefined reference to > `cpu_sparc_exec' > c++: error: linker command failed with exit code 1 (use -v to see invocation) > gmake

Re: [Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update the Xilinx maintainers

2016-08-01 Thread Peter Maydell
On 28 July 2016 at 17:55, Alistair Francis wrote: > Update the Xilinx maintainers documentation to simplify what we maintain > and cover all of our upstream code. > > Signed-off-by: Alistair Francis Mailing list seems not to have got this one second time around either -- maybe some spam filter d

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Host Memory Backends section

2016-08-01 Thread Markus Armbruster
Eduardo Habkost writes: > The hostmem code is closely related to the NUMA code, so I am > willing to handle patches to those files and share the work with > Igor (the original author of that code). > > Signed-off-by: Eduardo Habkost Thanks, Eduardo! Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI

2016-08-01 Thread Igor Mammedov
On Mon, 1 Aug 2016 21:59:19 +0800 Peter Xu wrote: > Some old Linux kernels (upstream before v4.0), or any released RHEL > kernels has problem in sending APIC EOI when IR is enabled. Meanwhile, > many of them only support explicit EOI for IOAPIC, which is only > introduced in IOAPIC version 0x20.

Re: [Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI

2016-08-01 Thread Paolo Bonzini
On 01/08/2016 16:43, Igor Mammedov wrote: > > To be compatible with old systems, 0x11 will still be the default IOAPIC > > version. Here 0x11 and 0x20 are the only versions to be supported. > > Is there a reason not to default to 0x20 for new machine types and > set 2.6 and older machine types t

  1   2   >