Re: [Qemu-devel] [PATCH RFC] spapr: disintricate core-id from DT semantics

2016-07-25 Thread David Gibson
On Fri, Jul 22, 2016 at 01:10:36PM +0200, Greg Kurz wrote: > The goal of this patch is to have a stable core-id which does not depend > on any DT related semantics, which involve non-obvious computations on > modern PowerPC server cpus. > > With this patch, the DT core id is computed on-demand as:

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

2016-07-25 Thread David Gibson
On Wed, Jul 20, 2016 at 09:01:11AM +0200, Peter Krempa wrote: > On Wed, Jul 20, 2016 at 11:00:05 +1000, David Gibson wrote: > > On Tue, Jul 19, 2016 at 01:52:40PM +0200, Peter Krempa wrote: > > > On Mon, Jul 18, 2016 at 19:19:19 +1000, David Gibson wrote: > > > > The spapr implementation of query-h

Re: [Qemu-devel] [RFC v4] virtio-crypto specification

2016-07-25 Thread Gonglei (Arei)
> -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Monday, July 25, 2016 2:20 PM > To: Gonglei (Arei); virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org > Cc: Hanweidong (Randy); Stefan Hajnoczi; Cornelia Huck; m...@redhat.com; > Lingli Deng; Jani Kokkonen; Luo

Re: [Qemu-devel] [PATCH for-2.7] fix qemu exit on memory hotplug when allocation fails at prealloc time

2016-07-25 Thread Igor Mammedov
On Fri, 22 Jul 2016 18:19:44 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Thu, 21 Jul 2016 10:36:40 +0200 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > [...] > >> > @@ -352,15 +352,14 @@ void os_mem_prealloc(int fd, char *area, size_t > >> > memory) > >

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

2016-07-25 Thread Igor Mammedov
On Mon, 25 Jul 2016 16:09:04 +1000 David Gibson wrote: > On Wed, Jul 20, 2016 at 09:01:11AM +0200, Peter Krempa wrote: > > On Wed, Jul 20, 2016 at 11:00:05 +1000, David Gibson wrote: > > > On Tue, Jul 19, 2016 at 01:52:40PM +0200, Peter Krempa wrote: > > > > On Mon, Jul 18, 2016 at 19:19:19 +

Re: [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-25 Thread Igor Mammedov
On Fri, 22 Jul 2016 17:46:40 -0300 Eduardo Habkost wrote: > On Fri, Jul 22, 2016 at 11:32:48AM +1000, David Gibson wrote: > > On Thu, Jul 21, 2016 at 05:54:33PM +0200, Igor Mammedov wrote: > > > Instead use QTAIL's tqe_prev field to detect if cpu's been > > > placed in list by cpu_exec_init() w

Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 03:41, Fam Zheng wrote: > On Fri, 07/22 10:46, Peter Maydell wrote: >> On 22 July 2016 at 02:13, Fam Zheng wrote: >> > On Thu, 07/21 11:45, Peter Maydell wrote: >> >> It failed on several of my test builds, not just one, but these >> >> things are tricky to avoid if they don't

Re: [Qemu-devel] [RFC v2 01/13] target-ppc: Introduce Power9 family

2016-07-25 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Sat, Jul 23, 2016 at 02:14:38PM +0530, Nikunj A Dadhania wrote: >> From: "Aneesh Kumar K.V" >> >> Signed-off-by: Aneesh Kumar K.V >> [ rebased and added POWER9 alias and POWER9 SPAPR core ] >> Signed-off-by: Nikunj A Dadhania > > I can'

Re: [Qemu-devel] [PATCH 1/1] Reorganize help output of '-display' option

2016-07-25 Thread Markus Armbruster
Robert Ho writes: > The '-display' help information is not very correct. This patch sort > it a little. > Also, in its help information, reveals what implicit display option > will be chosen if no definition. > > P.S. > Hi Markus, > > Sorry for late of sending out this patch. Really busy recently

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread T. Huth
Can you use "git bisect" to determine the exact commit that causes this problem to appear? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1603636 Title: Guest has not initialized the display yet on

Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-25 Thread Fam Zheng
On Mon, 07/25 09:38, Peter Maydell wrote: > On 25 July 2016 at 03:41, Fam Zheng wrote: > > On Fri, 07/22 10:46, Peter Maydell wrote: > >> On 22 July 2016 at 02:13, Fam Zheng wrote: > >> > On Thu, 07/21 11:45, Peter Maydell wrote: > >> >> It failed on several of my test builds, not just one, but t

[Qemu-devel] ppc: TCG and FP exceptions, is it right ?

2016-07-25 Thread Benjamin Herrenschmidt
Hi folks ! I could use a bit of help determining if something is quite right in TCG emulation of FP ops. Fabien, Tristan, you submitted a patch back in 2013: db72c9f256ae70b30c5d5985234f085df4226c55 "powerpc: correctly handle fpu exceptions" which effectively makes any of the exceptions generate

Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 10:37, Fam Zheng wrote: > Cool, so we do have that version, it's the -Werror=missing-braces option we > are > missing. Are there any other recommended gcc options I can add to > tests/docker/ (the criteria is simply "if this stops you from processing a > pull, it should be tes

[Qemu-devel] [PATCH v2 2/6] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-25 Thread Igor Mammedov
Instead use QTAIL's tqe_prev field to detect if cpu's been placed in list by cpu_exec_init() which is always set if QTAIL element is in list. Fixes SIGSEGV on failure path in case cpu_index is assigned by board and cpu.relalize() fails before cpu_exec_init() is called. In follow up patches, cpu_i

[Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug

2016-07-25 Thread Igor Mammedov
Changes from v1: - be conservative, drop QTAIL_*() macros hunks and do list element check/cleanup localy in cpu_exec_exit() - fix conflict caused by above - update Reviewed-bys fom v1 - drop spapr patches as they will be a bit different and depend on not yet applied to master patch:

[Qemu-devel] [PATCH v2 1/6] exec: reduce CONFIG_USER_ONLY ifdeffenery

2016-07-25 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: David Gibson --- bsd-user/qemu.h | 2 -- include/exec/exec-all.h | 12 linux-user/qemu.h | 2 -- exec.c | 17 +++-- 4 files changed, 15 insertions(+), 18 deletions(-) diff --git a/bsd-user/qemu.h

[Qemu-devel] [PATCH v2 3/6] exec: set cpu_index only if it's not been explictly set

2016-07-25 Thread Igor Mammedov
it keeps the legacy behavior for all users that doesn't care about stable cpu_index value, but would allow boards that would support device_add/device_del to set stable cpu_index that won't depend on order in which cpus are created/destroyed. While at that simplify cpu_get_free_index() as cpu_inde

[Qemu-devel] [PATCH v2 5/6] pc: init CPUState->cpu_index with index in possible_cpus[]

2016-07-25 Thread Igor Mammedov
It will enshure that cpu_index for a given cpu stays the same regardless of the order cpus has been created/deleted. No compat code is needed as for initial cpus index in possible_cpus[] matches cpu_index that's been auto-allocated in cpu_exec_init(). Tha same applies for hotplug with cpu-add com

[Qemu-devel] [PATCH v2 4/6] qdev: fix object reference leak in case device.realize() fails

2016-07-25 Thread Igor Mammedov
If device doesn't have parent assined before its realize is called, device_set_realized() will implicitly set parent to '/machine/unattached'. However device_set_realized() may fail after that point at several other points leaving not realized object dangling in '/machine/unattached' and as result

[Qemu-devel] [PATCH v2 6/6] Revert "pc: Enforce adding CPUs contiguously and removing them in opposite order"

2016-07-25 Thread Igor Mammedov
This reverts commit 4da7faaeb0c7dd3f7f233165d336c878f78fd1eb. However since commit: pc: init CPUState->cpu_index with index in possible_cpus[] cpu_index is stable regardless of the order cpus were created and QEMU instance stays migratable always so limitation added by 4da7faaeb could be safely

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread luigiburdo
Hi T, i can gave a try ... i never used "git bisect" i have to use it with the executable? with "git bisect log" or somthing else? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1603636 Title: Gues

Re: [Qemu-devel] [PATCH v2 2/6] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 11:59:20AM +0200, Igor Mammedov wrote: > Instead use QTAIL's tqe_prev field to detect if cpu's been > placed in list by cpu_exec_init() which is always set if > QTAIL element is in list. > > Fixes SIGSEGV on failure path in case cpu_index is assigned > by board and cpu.rela

Re: [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug

2016-07-25 Thread David Gibson
On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote: > Changes from v1: > - be conservative, drop QTAIL_*() macros hunks and do list element > check/cleanup localy in cpu_exec_exit() > - fix conflict caused by above > - update Reviewed-bys fom v1 > - drop spapr patches as they

Re: [Qemu-devel] [PATCH v3 0/2] vhost-user: Extend protocol to receive replies on any command.

2016-07-25 Thread Marc-André Lureau
Hi On Mon, Jul 25, 2016 at 10:41 AM, Prerna wrote: > > > On Thu, Jul 7, 2016 at 12:04 PM, Prerna Saxena > wrote: >> >> From: Prerna Saxena >> >> The current vhost-user protocol requires the client to send responses to >> only a >> few commands. For the remaining commands, it is impossible for Q

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread T. Huth
You initially have to specify a commit that is known to fail, and one that is known to work, so in this case it's likely: git bisect start master v2.6.0 It then checks out a revision inbetween. Compile it with "make" and run the built QEMU to check whether it is working or not. If it is not work

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-25 Thread luigiburdo
Hi T, thanks for the infos i will report ASAP -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1603636 Title: Guest has not initialized the display yet on ubuntu 16.10 PPC Status in QEMU: New Bug

Re: [Qemu-devel] [RFC v2 05/13] target-ppc: add modulo word operations

2016-07-25 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/23/2016 02:14 PM, Nikunj A Dadhania wrote: >> Adding following instructions: >> >> moduw: Modulo Unsigned Word >> modsw: Modulo Signed Word >> >> Signed-off-by: Nikunj A Dadhania >> --- >> target-ppc/helper.h | 2 ++ >> target-ppc/int_helper.c | 15 +++

Re: [Qemu-devel] [PATCH v3 4/9] tcg: Compress liveness data to 16 bits

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > This reduces both memory usage and per-insn cacheline usage > during code generation. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 58 ++ > tcg/tcg.h | 16 ++-- > 2 fil

Re: [Qemu-devel] [PATCH v3 1/9] tcg: Fix name for high-half register

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Reviewed-by: David Gibson > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index 254427b..154ffe8 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@

Re: [Qemu-devel] [PATCH v3 3/9] tcg: Require liveness analysis

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 20 > 1 file changed, 20 deletions(-) > Thanks for doing that. The code without liveness analysis is not really tested anymore and given the kind of optimisations we are doi

Re: [Qemu-devel] [PATCH v3 5/9] tcg: Reorg TCGOp chaining

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Instead of using -1 as end of chain, use 0, and link through the 0 > entry as a fully circular double-linked list. > > Signed-off-by: Richard Henderson > --- > include/exec/gen-icount.h | 2 +- > tcg/optimize.c| 8 ++-- > tcg/tcg-

Re: [Qemu-devel] Fw:qemu driver_mirror error "Operation not permitted"

2016-07-25 Thread lisiheng
I'm using the same logical device “/dev/vg_bc_local/test” and disabled SELinux!Please review carefully my debugging process! At 2016-07-25 11:14:12, "Fam Zheng" wrote: >On Fri, 07/22 15:41, lisiheng wrote: >> Hi All, >> I use libvirtd to call qemu drive_mirror return error message "Operation not

[Qemu-devel] [PATCH] x86: ioapic: upgrade emulated IOAPIC to ver 0x20

2016-07-25 Thread Peter Xu
IOMMU IR and IOAPIC legacy devices (e.g., e1000) cannot work well together with some old Linux kernels (upstream before v4.0, or any released RHEL kernels). This patch fixes it. The problem is that: some old linux kernels (with IR enabled) only support IOAPIC chips with version 0x20. New kernels a

Re: [Qemu-devel] Fw:qemu driver_mirror error "Operation not permitted"

2016-07-25 Thread Fam Zheng
On Mon, 07/25 19:04, lisiheng wrote: > I'm using the same logical device “/dev/vg_bc_local/test” and disabled > SELinux!Please review carefully my debugging process! Then, what is the output of $(ps aux | grep qemu) with libvirt? > At 2016-07-25 11:14:12, "Fam Zheng" wrote: > >On Fri, 07/22 15:4

Re: [Qemu-devel] [PATCH v3 0/2] vhost-user: Extend protocol to receive replies on any command.

2016-07-25 Thread Prerna Saxena
Hi Marc, Thank you for taking a look. On 25/07/16 3:57 pm, "Marc-André Lureau" wrote: >Hi > >On Mon, Jul 25, 2016 at 10:41 AM, Prerna wrote: >> >> >> On Thu, Jul 7, 2016 at 12:04 PM, Prerna Saxena >> wrote: >>> >>> From: Prerna Saxena >>> >>> The current vhost-user protocol requires the cl

Re: [Qemu-devel] [v5, 09/31] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()

2016-07-25 Thread Ilya Maximets
On 21.07.2016 11:57, Marc-André Lureau wrote: > From: Marc-André Lureau > > vhost_net_init() calls vhost_dev_init() and in case of failure, calls > vhost_dev_cleanup() directly. However, the structure is already > partially cleaned on error. Calling vhost_dev_cleanup() again will call > vhost_vir

[Qemu-devel] GNU ARM Eclipse QEMU: Display more Cortex-M registers in GDB server

2016-07-25 Thread Liviu Ionescu
Inspired by the J-Link GDB server, I added more specific Cortex-M registers to the list of registers published by the GDB server implemented by the GNU ARM Eclipse QEMU. Here is how the registers are seen by Eclipse: If someone is planing to make these registers visible in QEMU, my patches c

[Qemu-devel] GNU ARM Eclipse QEMU: Use BASEPRI to disable interrupts on Cortex-M

2016-07-25 Thread Liviu Ionescu
Most of the development of my µOS++ / CMSIS++ RTOS was done on GNU ARM Eclipse QEMU and/or as a 64-bits user process on macOS. However, on QEMU, initially I encountered some strange behaviour when configuring the critical sections to use BASEPRI; when using DI/EI everything was fine. These day

Re: [Qemu-devel] [v5, 09/31] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()

2016-07-25 Thread Marc-André Lureau
Hi - Original Message - > On 21.07.2016 11:57, Marc-André Lureau wrote: > > From: Marc-André Lureau > > > > vhost_net_init() calls vhost_dev_init() and in case of failure, calls > > vhost_dev_cleanup() directly. However, the structure is already > > partially cleaned on error. Calling vh

[Qemu-devel] [PATCH for-2.8] qtail: clean up direct access to tqe_prev field

2016-07-25 Thread Igor Mammedov
instead of accessing tqe_prev field dircetly outside of queue.h use macros to check if element is in list and make sure that afer element is removed from list tqe_prev field could be used to do the same check. Signed-off-by: Igor Mammedov --- The patch is split from as cleanup is not urgent [PA

Re: [Qemu-devel] [v5, 17/31] vhost-user: keep vhost_net after a disconnection

2016-07-25 Thread Ilya Maximets
On 21.07.2016 11:57, Marc-André Lureau wrote: > From: Marc-André Lureau > > Many code paths assume get_vhost_net() returns non-null. > > Keep VhostUserState.vhost_net after a successful vhost_net_init(), > instead of freeing it in vhost_net_cleanup(). > > VhostUserState.vhost_net is thus freed

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread felix
** Patch added: "Patch to fix the qemu-img issue (does NOT resolve the whole bug)" https://bugs.launchpad.net/qemu/+bug/1599539/+attachment/4707063/+files/make_vvfat_work_with_qemu-img.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [v5, 09/31] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()

2016-07-25 Thread Ilya Maximets
On 25.07.2016 15:45, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 21.07.2016 11:57, Marc-André Lureau wrote: >>> From: Marc-André Lureau >>> >>> vhost_net_init() calls vhost_dev_init() and in case of failure, calls >>> vhost_dev_cleanup() directly. However, the structure i

[Qemu-devel] [PATCH v2 0/2] Drop some useless functions

2016-07-25 Thread Cao jin
These functions are not used anymore, drop them first. Next step is to rip out NonBlockingConnectHandler as Daniel suggested. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Cc: Eric Blake Cao jin (2): util: Drop unused *_nonblocking_connect() functions util: Drop inet_listen()

[Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen()

2016-07-25 Thread Cao jin
Since commit e65c67e4, inet_listen() is not used anymore, and all inet listen operation goes through QIOChannel. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Cc: Eric Blake Signed-off-by: Cao jin --- include/qemu/sockets.h | 2 -- util/qemu-sockets.c| 28 -

[Qemu-devel] [PATCH v2 1/2] util: Drop unused *_nonblocking_connect() functions

2016-07-25 Thread Cao jin
Since commit e65c67e4 & d984464e, they are not used anymore, and all non-blocking connect now goes through inet_connect_addr(). Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Cc: Eric Blake Reviewed-by: Eric Blake Signed-off-by: Cao jin --- include/qemu/sockets.h | 6 -- u

Re: [Qemu-devel] [v5, 09/31] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()

2016-07-25 Thread Marc-André Lureau
Hi - Original Message - > On 25.07.2016 15:45, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> On 21.07.2016 11:57, Marc-André Lureau wrote: > >>> From: Marc-André Lureau > >>> > >>> vhost_net_init() calls vhost_dev_init() and in case of failure, calls > >>> vho

Re: [Qemu-devel] GNU ARM Eclipse QEMU: Use BASEPRI to disable interrupts on Cortex-M

2016-07-25 Thread Peter Maydell
On 25 July 2016 at 13:37, Liviu Ionescu wrote: > If someone is planing to properly implement BASEPRI in QEMU, > my patches can be used as a starting point. > (https://github.com/gnuarmeclipse/qemu/issues/21) I have a feeling this is addressed by Michael Davidsaver's NVIC overhaul patchset from la

Re: [Qemu-devel] [v5, 17/31] vhost-user: keep vhost_net after a disconnection

2016-07-25 Thread Marc-André Lureau
Hi - Original Message - > On 21.07.2016 11:57, Marc-André Lureau wrote: > > From: Marc-André Lureau > > > > Many code paths assume get_vhost_net() returns non-null. > > > > Keep VhostUserState.vhost_net after a successful vhost_net_init(), > > instead of freeing it in vhost_net_cleanup(

Re: [Qemu-devel] [v5, 09/31] vhost: fix calling vhost_dev_cleanup() after vhost_dev_init()

2016-07-25 Thread Ilya Maximets
On 25.07.2016 16:05, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 25.07.2016 15:45, Marc-André Lureau wrote: >>> Hi >>> >>> - Original Message - On 21.07.2016 11:57, Marc-André Lureau wrote: > From: Marc-André Lureau > > vhost_net_init() calls vhos

Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

2016-07-25 Thread Fam Zheng
On Mon, 07/25 10:48, Peter Maydell wrote: > On 25 July 2016 at 10:37, Fam Zheng wrote: > > Cool, so we do have that version, it's the -Werror=missing-braces option we > > are > > missing. Are there any other recommended gcc options I can add to > > tests/docker/ (the criteria is simply "if this

[Qemu-devel] [PATCH] fixup! fix qemu exit on memory hotplug when allocation fails at prealloc time

2016-07-25 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - add comment o exit(1) path --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index a60ac97..f2d4e9e 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -356,6 +356,7 @@ void os_mem_preallo

[Qemu-devel] [PATCH] docker: Add "--enable-werror" to configure command line

2016-07-25 Thread Fam Zheng
We don't have .git in the docker checkout, add this to enable -Werror explicitly. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/common.rc b/tests/docker/common.rc index 77069e1..0c6d8d5 100755 --- a/tests/docker/common.rc +++

Re: [Qemu-devel] [Xen-devel] [PATCH 02/19] xen: Create a new file xen_frontend.c

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:33PM +0300, Emil Condrea wrote: > Its purpose is to store frontend related functions. > > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea > --- > hw/block/xen_disk.c | 1 + > hw/display/xenfb.c| 1 + > hw/net/xen_nic.c | 1

Re: [Qemu-devel] [Xen-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:35PM +0300, Emil Condrea wrote: > The name of the functions moved: > * xen_be_evtchn_event > * xen_be_unbind_evtchn > * xen_be_send_notify > > Signed-off-by: Emil Condrea > --- > hw/xen/xen_backend.c | 37 + > hw/xen/xe

Re: [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:32PM +0300, Emil Condrea wrote: > The purpose of the new file is to store generic functions shared by frontend > and backends such as xenstore operations, xendevs. > > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea > --- > hw/xen/Makefile.objs | 2 +

Re: [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-25 Thread Colin Lord
On 07/23/2016 02:21 PM, Max Reitz wrote: > On 20.07.2016 16:30, Colin Lord wrote: >> Here's v5 of the modularization series. Since it seems the concensus is >> that modularizing the format drivers is unnecessary, this series no >> longer modularizes those and is thus much shorter than before. >> >>

Re: [Qemu-devel] [Xen-devel] [PATCH 07/19] xen: Rename xen_be_unbind_evtchn

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:38PM +0300, Emil Condrea wrote: > Prepare xen_be_unbind_evtchn to be shared with frontends: > * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn > > Signed-off-by: Emil Condrea > --- > hw/block/xen_disk.c| 2 +- > hw/char/xen_console.c | 2 +- > hw/display

Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?

2016-07-25 Thread Richard Henderson
On 07/25/2016 03:14 PM, Benjamin Herrenschmidt wrote: The code as writte will take the exception before the FPR is updated, I *think*, or am I missing something here ? You are correct, exceptions are raised from e.g. helper_fadd before the writeback to the fp register. What do you think is

Re: [Qemu-devel] [Xen-devel] [PATCH 08/19] xen: Rename xen_be_send_notify

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:39PM +0300, Emil Condrea wrote: > Prepare xen_be_send_notify to be shared with frontends: > * xen_be_send_notify -> xen_pv_send_notify > > Signed-off-by: Emil Condrea > --- > hw/block/xen_disk.c| 4 ++-- > hw/char/xen_console.c | 4 ++-- > hw/display/x

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Richard Henderson
On 07/25/2016 06:21 AM, Benjamin Herrenschmidt wrote: On Mon, 2016-07-25 at 10:46 +1000, Benjamin Herrenschmidt wrote: On Mon, 2016-07-25 at 06:06 +0530, Richard Henderson wrote: These functions would have to be always_inline for this to work. Otherwise you could get the helper's PC, not the T

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread T. Huth
Please send your patch to the qemu-devel (and qemu-block) mailing list. See http://qemu-project.org/Contribute/SubmitAPatch for details on how to submit a patch. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PATCH v3 6/9] tcg: Fold life data into TCGOp

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Reduce the size of other bitfields to make room. > This reduces the cache footprint of compilation. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 9 +++-- > tcg/tcg.h | 26 ++ > 2 files changed, 17 insertions

Re: [Qemu-devel] TCG problem with cpu_{st,ld}x_data ?

2016-07-25 Thread Richard Henderson
On 07/25/2016 10:45 AM, Benjamin Herrenschmidt wrote: On Mon, 2016-07-25 at 06:04 +0530, Richard Henderson wrote: I noticed a related problem recently, while working on the cmpxchg patch set. In my opinion, we should (1) merge GETRA and GETPC so there's no confusion between the two, (2) push al

Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)

2016-07-25 Thread Anthony PERARD
On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote: > Emil Condrea (19): > xen: Create a new file xen_pvdev.c > xen: Create a new file xen_frontend.c > xen: Move xenstore_update to xen_pvdev.c > xen: Move evtchn functions to xen_pvdev.c > xen: Prepare xendev qtail to be shared w

[Qemu-devel] [PATCH 1/3] hw/ppc: include fdt helper routine in a common file

2016-07-25 Thread Cédric Le Goater
spapr_pci would also be a good candidate but the macro _FDT is slightly different. It returns and does not exit. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c| 11 +-- hw/ppc/spapr_events.c | 11 +-- include/hw/ppc/fdt.h | 23 +++ 3 files changed

[Qemu-devel] [PATCH 2/3] hw/ppc: use error_report instead of fprintf

2016-07-25 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 12 ++-- hw/ppc/spapr_drc.c | 8 hw/ppc/spapr_iommu.c | 4 ++-- hw/ppc/spapr_rtas.c | 13 +++-- hw/ppc/spapr_vio.c | 3 ++- 5 files changed, 21 insertions(+), 19 deletions(-) diff --git a/hw/ppc/spapr.c b

[Qemu-devel] [PATCH 0/3] Add PowerNV skeleton

2016-07-25 Thread Cédric Le Goater
The patchset starts with two small cleanups which are used in the PowerNV skeleton. The PowerNV platform does not provide enough support yet to be useful but it is the first step to add the required chiplets missing in the model. This version only adds a few minor cleanups to the initial patch tha

[Qemu-devel] [PATCH 3/3] ppc/pnv: Add skeletton PowerNV platform

2016-07-25 Thread Cédric Le Goater
From: Benjamin Herrenschmidt No devices yet, not even an interrupt controller, just to get started. (Folded in Stewart Smith patch to add command lien support) Signed-off-by: Benjamin Herrenschmidt [clg: updated for qemu-2.7 replaced fprintf by error_report used a common definition

Re: [Qemu-devel] [PATCH] Add signal handling support for x86_64.

2016-07-25 Thread Peter Maydell
On 9 July 2016 at 21:07, Wirth, Allan wrote: > Note that x86_64 has only _rt signal handlers. This implementation > attempts to share code with the x86_32 implementation. > > Reported-by: Timothy Pearson > Suggested-by: Peter Maydell > Signed-off-by: Allan Wirth Thanks. This mostly looks good;

Re: [Qemu-devel] [RFC v2 05/13] target-ppc: add modulo word operations

2016-07-25 Thread Richard Henderson
On 07/25/2016 04:44 PM, Nikunj A Dadhania wrote: Modulo case: a % (b == 0 ? 1 : b) tcg_gen_trunc_tl_i32(t0, cpu_gpr[rA(ctx->opcode)]); tcg_gen_trunc_tl_i32(t1, cpu_gpr[rB(ctx->opcode)]); tcg_gen_setcondi_i32(TCG_COND_EQ, t2, t1, 0); tcg_gen_movi_i32(t3, 0); tcg_gen_movcond_i3

Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: > COLO block is the necessary prerequisite of COLO framework and COLO network, > what are blocked by these patchsets now. > > Since v19, Stefan said he had reviewed most part of this patchsets. So, this > series *REALLY* need more comm

[Qemu-devel] [PATCH 3/3] qdist: return "(empty)" instead of NULL when printing an empty dist

2016-07-25 Thread Emilio G. Cota
Printf'ing a NULL string is undefined behaviour. Avoid it. Reported-by: Peter Maydell Signed-off-by: Emilio G. Cota --- tests/test-qdist.c | 10 -- util/qdist.c | 6 -- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/test-qdist.c b/tests/test-qdist.c ind

[Qemu-devel] [PATCH 0/3] qdist fixes

2016-07-25 Thread Emilio G. Cota
While fixing the return of a NULL string when printing an empty dist (patch 3) (see background here [*]), I noticed there was a leak in qdist (patch 1). Patch 2 is trivial. Thanks, Emilio [*] https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg05494.html

[Qemu-devel] [PATCH 1/3] qdist: fix memory leak during binning

2016-07-25 Thread Emilio G. Cota
In qdist_bin__internal(), to->entries is initialized to a 1-element array, which we then leak when n == from->n. Fix it. Signed-off-by: Emilio G. Cota --- util/qdist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qdist.c b/util/qdist.c index 56f5738..eb2236c 100644 --

[Qemu-devel] [PATCH 2/3] qdist: use g_realloc_n instead of g_realloc

2016-07-25 Thread Emilio G. Cota
While at it, remove the unnecessary parentheses around dist->size. Signed-off-by: Emilio G. Cota --- util/qdist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qdist.c b/util/qdist.c index eb2236c..cc31140 100644 --- a/util/qdist.c +++ b/util/qdist.c @@ -62,8 +62,8

Re: [Qemu-devel] [PATCH 5/5] ast2400: add a memory controller device model

2016-07-25 Thread Peter Maydell
On 8 July 2016 at 17:06, Cédric Le Goater wrote: > The uboot in the previous release of the SDK was using a hardcoded > value for memory size. This is not true anymore, the value is now > retrieved from the memory controller. > > Below is a model for this device, only supporting unlock and > confi

Re: [Qemu-devel] [PATCH v3 7/9] tcg: Compress dead_temps and mem_temps into a single array

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > We only need two bits per temporary. Fold the two bytes into one, > and reduce the memory and cachelines required during compilation. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 118 > +++--

Re: [Qemu-devel] [PATCH v3 8/9] tcg: Include liveness info in the dumps

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 26 ++ > 1 file changed, 26 insertions(+) Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net

Re: [Qemu-devel] [PATCH v1 1/5] cadence_gem: QOMify Cadence GEM

2016-07-25 Thread Peter Maydell
On 12 July 2016 at 00:20, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > hw/net/cadence_gem.c | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index 8a4be1e..9d64644 100644 >

Re: [Qemu-devel] [PATCH v1 2/5] cadence_gem: Arrayify

2016-07-25 Thread Peter Maydell
On 12 July 2016 at 00:20, Alistair Francis wrote: > Arrayify the Cadence GEM device to prepare for adding priority queue support. > > Signed-off-by: Alistair Francis > --- > > This patch has no real effect, I used it to help debug some issues so I > figured I would leave it in. An expanded commi

Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?

2016-07-25 Thread Tristan Gingold
> On 25 Jul 2016, at 11:44, Benjamin Herrenschmidt > wrote: > > Hi folks ! > > I could use a bit of help determining if something is quite right in > TCG emulation of FP ops. > > Fabien, Tristan, you submitted a patch back in 2013: > > db72c9f256ae70b30c5d5985234f085df4226c55 "powerpc: corre

[Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

2016-07-25 Thread Shmulik Ladkani
From: Shmulik Ladkani In cases where iov_copy() is passed with zero 'bytes' argument and a non-zero 'offset' argument, nothing gets copied - as expected. However since no copy iterations are performed, 'offset' is left unaltered, leading to the final assert(offset == 0) to fail. Relax the asser

Re: [Qemu-devel] [PATCH] fixup! fix qemu exit on memory hotplug when allocation fails at prealloc time

2016-07-25 Thread Markus Armbruster
Igor Mammedov writes: > Signed-off-by: Igor Mammedov > --- > - add comment o exit(1) path > --- > util/oslib-posix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index a60ac97..f2d4e9e 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-po

Re: [Qemu-devel] [PATCH v1 3/5] cadence_gem: Add queue support

2016-07-25 Thread Peter Maydell
On 12 July 2016 at 00:20, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > There is a indentation error in this patch in the gem_transmit function. > I have written it like that to make it easier to see the changes. It is > fixed in the next patch. > > hw/net/cadence_gem.c

Re: [Qemu-devel] [PATCH v1 4/5] cadence_gem: Correct indentation

2016-07-25 Thread Peter Maydell
On 12 July 2016 at 00:20, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > hw/net/cadence_gem.c | 182 > +-- > 1 file changed, 91 insertions(+), 91 deletions(-) I assume this patch comes out empty if you use 'git show -w'; woul

Re: [Qemu-devel] [PATCH v1 5/5] xlnx-zynqmp: Set the number of priority queues

2016-07-25 Thread Peter Maydell
On 12 July 2016 at 00:20, Alistair Francis wrote: > Set the ZynqMP number of priority queues to 2. > > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-zynqmp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 23c7199..0d86ba3 10

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread felix
I noticed another bug in vvfat disk image generation. Applying the patch I attached earlier made testing easier. I'm less sure what the actual problem is. Steps to reproduce (you'll need to have cpio, md5sum and GNU GRUB 2.x installed): 0. Apply the patch and build qemu-img. 1. Create a directory

Re: [Qemu-devel] [PATCH 5/5] ast2400: add a memory controller device model

2016-07-25 Thread Cédric Le Goater
On 07/25/2016 05:12 PM, Peter Maydell wrote: > On 8 July 2016 at 17:06, Cédric Le Goater wrote: >> The uboot in the previous release of the SDK was using a hardcoded >> value for memory size. This is not true anymore, the value is now >> retrieved from the memory controller. >> >> Below is a model

Re: [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: >> img_open_file() and img_open_opts() were printing error messages with a >> duplicate part because of a wrong use of error_reportf_err() (e.g. >> qemu-img: Could not open 'foo': Could not open 'foo': No such

Re: [Qemu-devel] [RFC PATCH 3/3] hw/arm/virt: add nvdimm emulation support

2016-07-25 Thread Peter Maydell
On 20 July 2016 at 01:49, Kwangwoo Lee wrote: > This patch enables evaluating NVDIMM on aarch64 virt platform. The > option - nvdimm - passed after machine type is disabled by default. > > The command below has been used to test the feature: > > ./aarch64-softmmu/qemu-system-aarch64

Re: [Qemu-devel] [RFC PATCH 2/3] nvdimm: use configurable ACPI IO base and size

2016-07-25 Thread Peter Maydell
On 20 July 2016 at 01:49, Kwangwoo Lee wrote: > This patch uses configurable IO base and size to create NPIO AML for > ACPI NFIT. Since a different architecture like AArch64 does not use > port-mapped IO, a configurable IO base is required to create correct > mapping of ACPI IO address and size. >

Re: [Qemu-devel] [RFC PATCH 0/3] add nvdimm support on AArch64 virt platform

2016-07-25 Thread Peter Maydell
On 20 July 2016 at 01:49, Kwangwoo Lee wrote: > This patch series add an evaluation environment of NVDIMM on AArch64 > virt platform. Three parts need to be implemented to make this feature > working properly. > > 1. memory hotplug on arm virt platform > 2. configurable ACPI IO base and size both

Re: [Qemu-devel] [PATCH v3 8/9] tcg: Include liveness info in the dumps

2016-07-25 Thread Aurelien Jarno
On 2016-06-23 20:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index fd92b06..3e4bc99 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -1009,6 +1009,7 @

Re: [Qemu-devel] [RFC v2 05/13] target-ppc: add modulo word operations

2016-07-25 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/23/2016 02:14 PM, Nikunj A Dadhania wrote: [...] > Basically, we check for the offending cases and modify the divisor prior to > the > division. For unsigned: > > a / (b == 0 ? 1 : b) > > For signed: > > a / ((a == INT_MAX & b == -1) | (b == 0) ? :

Re: [Qemu-devel] [PATCH v1 4/5] cadence_gem: Correct indentation

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 8:48 AM, Peter Maydell wrote: > On 12 July 2016 at 00:20, Alistair Francis > wrote: >> Signed-off-by: Alistair Francis >> --- >> >> hw/net/cadence_gem.c | 182 >> +-- >> 1 file changed, 91 insertions(+), 91 deletions(-) >

Re: [Qemu-devel] [PATCH v1 1/5] cadence_gem: QOMify Cadence GEM

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 8:20 AM, Peter Maydell wrote: > On 12 July 2016 at 00:20, Alistair Francis > wrote: >> Signed-off-by: Alistair Francis >> --- >> >> hw/net/cadence_gem.c | 27 --- >> 1 file changed, 16 insertions(+), 11 deletions(-) >> >> diff --git a/hw/net/cade

Re: [Qemu-devel] [PATCH v4 3/8] STM32F2xx: Add the ADC device

2016-07-25 Thread Peter Maydell
On 23 July 2016 at 17:42, Alistair Francis wrote: > Add the STM32F2xx ADC device. This device randomly > generates values on each read. > > This also includes creating a hw/adc directory. > > Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v4 4/8] STM32F2xx: Add the SPI device

2016-07-25 Thread Peter Maydell
On 23 July 2016 at 17:42, Alistair Francis wrote: > Add the STM32F2xx SPI device. > > Signed-off-by: Alistair Francis > --- > +static uint64_t stm32f2xx_spi_read(void *opaque, hwaddr addr, > + unsigned int size) > +{ > +STM32F2XXSPIState *s = opaque; > +

Re: [Qemu-devel] [PATCH v1 1/5] cadence_gem: QOMify Cadence GEM

2016-07-25 Thread Alistair Francis
On Mon, Jul 25, 2016 at 9:38 AM, Alistair Francis wrote: > On Mon, Jul 25, 2016 at 8:20 AM, Peter Maydell > wrote: >> On 12 July 2016 at 00:20, Alistair Francis >> wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> >>> hw/net/cadence_gem.c | 27 --- >>> 1 file cha

  1   2   3   >