Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-14 Thread Matthew Garrett
Any feedback on this?

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2016-07-14 Thread Luke Kim
I'm so sorry that cmake still hang with my Ubuntu 12.04 and openSUSE 12.3 machine. and the hanging point has changed. cmake hung at select() with old qemu. but now cmake hang at pselect6() with new qemu. And also I could continue build by sending SIGCHLD to hanging qemu. but now cmake still hang

Re: [Qemu-devel] [PATCH v18 3/4] block/gluster: using new qapi schema

2016-07-14 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > this patch adds 'GlusterServer' related schema in qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever QAPI/QMP interface review only. > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ac8f5f6..f8b38bb 100644 > --- a/qapi/block-core.j

[Qemu-devel] [RFC 0/2] Fix some bugs in usermode cpu tracking

2016-07-14 Thread David Gibson
While investigating the mess we have with cpu_index and (possible) other cpu id values, I came across a couple of bugs in CONFIG_USER_ONLY mode. David Gibson (2): linux-user: Don't leak cpus on thread exit linux-user: Fix cpu_index generation exec.c | 19 --- li

[Qemu-devel] [RFC 1/2] linux-user: Don't leak cpus on thread exit

2016-07-14 Thread David Gibson
Currently linux-user does not correctly clean up CPU instances properly when running a threaded binary. On thread exit, do_syscall() removes the thread's CPU from the cpus list and calls object_unref(). However, the CPU still is still referenced from the QOM tree. To correctly clean up we need t

[Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-14 Thread David Gibson
With CONFIG_USER_ONLY, generation of cpu_index values is done differently than for full system targets. This method turns out to be broken, since it can fairly easily result in duplicate cpu_index values for simultaneously active cpus (i.e. threads in the emulated process). Consider this sequence

Re: [Qemu-devel] [RFC 13/13] snapshot: Remove page's write-protect and copy the content during setup stage

2016-07-14 Thread Hailiang Zhang
On 2016/7/14 1:52, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If we modify VM's RAM (pages) during setup stage after enable write-protect notification in snapshot thread, the modification action will get stuck because we only remove the page's write-pro

Re: [Qemu-devel] [PATCH v9 16/17] qapi: Tweak QmpInputVisitor to optionally do string conversion

2016-07-14 Thread Daniel P. Berrange
On Wed, Jul 13, 2016 at 09:50:27PM -0600, Eric Blake wrote: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative mode where a QString can a

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

2016-07-14 Thread Paolo Bonzini
On 13/07/2016 20:03, Sergey Fedorov wrote: > On 13/07/16 14:13, Paolo Bonzini wrote: >> >> On 12/07/2016 22:13, Sergey Fedorov wrote: >>> diff --git a/include/qemu/qht.h b/include/qemu/qht.h >>> index 70bfc68b8d67..5f633e5d8100 100644 >>> --- a/include/qemu/qht.h >>> +++ b/include/qemu/qht.h >>>

Re: [Qemu-devel] [PATCH v3 01/19] target-i386: cpu: use uint32_t for X86CPU.apic_id

2016-07-14 Thread Igor Mammedov
On Wed, 13 Jul 2016 18:13:59 -0400 Bandan Das wrote: > I know some of these have already been pulled. I just have some minor > questions/comments that shouldn't conflict. > > Igor Mammedov writes: > > > Redo 9886e834 (target-i386: Require APIC ID to be explicitly set before > > CPU realize) in

Re: [Qemu-devel] [PATCH v3 04/19] pc: cpu: consolidate apic-id validity checks in pc_cpu_pre_plug()

2016-07-14 Thread Igor Mammedov
On Wed, 13 Jul 2016 18:16:59 -0400 Bandan Das wrote: > Igor Mammedov writes: > > > Machine code knows about all possible APIC IDs so use that > > instead of hack which does O(n^2) complexity duplicate > > checks, interating over global CPUs list. > > As result duplicate check is done only once

[Qemu-devel] [PATCH] ppc/mmu-hash64: Remove duplicated #include statement

2016-07-14 Thread Thomas Huth
No need to include error-report.h twice here. Signed-off-by: Thomas Huth --- target-ppc/mmu-hash64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c index 82c2186..f6ffe35 100644 --- a/target-ppc/mmu-hash64.c +++ b/target-ppc/mmu-hash64.c @@ -

Re: [Qemu-devel] [PATCH v3 06/19] target-i386: add socket/core/thread properties to X86CPU

2016-07-14 Thread Igor Mammedov
On Wed, 13 Jul 2016 18:22:18 -0400 Bandan Das wrote: > Igor Mammedov writes: > > > these properties will be used by as address where to plug > > CPU with help -device/device_add commands. > > > > Signed-off-by: Igor Mammedov > > --- > > v3: > > - use %u for printing topo ids > > - add to e

Re: [Qemu-devel] [PATCH v18 3/4] block/gluster: using new qapi schema

2016-07-14 Thread Prasanna Kalever
On Thu, Jul 14, 2016 at 1:22 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> this patch adds 'GlusterServer' related schema in qapi/block-core.json >> >> Signed-off-by: Prasanna Kumar Kalever > > QAPI/QMP interface review only. > >> diff --git a/qapi/block-core.json b/qapi/blo

Re: [Qemu-devel] [PATCH 1/1] spapr: Ensure CPU cores are added contiguously and removed in LIFO order

2016-07-14 Thread Igor Mammedov
On Thu, 14 Jul 2016 10:51:27 +1000 David Gibson wrote: > On Wed, Jul 13, 2016 at 12:20:20PM +0530, Bharata B Rao wrote: > > If CPU core addition or removal is allowed in random order leading to > > holes in the core id range (and hence in the cpu_index range), migration > > can fail as migration

Re: [Qemu-devel] [PATCH] vl: exit if a bad property value is passed to -global

2016-07-14 Thread Igor Mammedov
On Thu, 14 Jul 2016 11:42:40 +1000 David Gibson wrote: > On Wed, Jul 13, 2016 at 08:05:03PM +0200, Greg Kurz wrote: > > When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo' > > on the command line, without this patch, we get the following warning per > > device (which means

Re: [Qemu-devel] [RFC v2 11/11] tcg: Make tb_flush() thread safe

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Use async_safe_run_on_cpu() to make tb_flush() thread safe. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > --- > > Changes in v2: > - stale comment about unsafe tb_flush() removed > --- > translate-all.c | 13 ---

[Qemu-devel] [PATCH 3/5] paravirt: read QEMU_CFG_NOGRAPHIC, store in etc/sercon-enable romfile

2016-07-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/fw/paravirt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c index 73a08f0..d18d247 100644 --- a/src/fw/paravirt.c +++ b/src/fw/paravirt.c @@ -201,6 +201,7 @@ qemu_platform_setup(void) #define QEMU_CFG_SIGNATURE

[Qemu-devel] [PATCH 2/5] kbd: make enqueue_key public, add ascii_to_keycode

2016-07-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/kbd.c | 17 - src/util.h | 2 ++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/kbd.c b/src/kbd.c index 61d9df0..7c43129 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -51,7 +51,7 @@ kbd_init(void) , x + FIELD_SIZE

[Qemu-devel] [PATCH 1/5] std: add cp437 to unicode map

2016-07-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile| 5 +- src/std/cp437.c | 275 src/std/cp437.h | 1 + 3 files changed, 279 insertions(+), 2 deletions(-) create mode 100644 src/std/cp437.c create mode 100644 src/std/cp437.h diff --gi

[Qemu-devel] [PATCH 0/5] serial console support

2016-07-14 Thread Gerd Hoffmann
Hi, Next round of serial console patches, Still not ready to merge. Headline feature of this version is split mode (i.e. output on both vga and serial). Have a initial working implementation now, logic is simliar to the vgabios timer hook (as suggested by Kevin). Also changed the output logi

[Qemu-devel] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-07-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- src/optionroms.c | 2 ++ src/romlayout.S | 39 ++ src/sercon.c | 99 +++- 3 files changed, 111 insertions(+), 29 deletions(-) diff --git a/src/optionroms.c b/src/optionroms.c index f9e9

[Qemu-devel] [PATCH 4/5] add serial console support

2016-07-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile | 2 +- src/clock.c | 1 + src/misc.c | 2 + src/optionroms.c | 7 +- src/sercon.c | 580 +++ src/util.h | 3 + 6 files changed, 593 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [RFC v2 11/11] tcg: Make tb_flush() thread safe

2016-07-14 Thread Sergey Fedorov
On 14/07/16 11:41, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> Use async_safe_run_on_cpu() to make tb_flush() thread safe. >> >> Signed-off-by: Sergey Fedorov >> Signed-off-by: Sergey Fedorov >> --- >> >> Changes in v2: >> - stale comment about unsafe tb_flush()

Re: [Qemu-devel] [RFC 1/1] linux-aio: consume events in userspace instead of calling io_getevents

2016-07-14 Thread Paolo Bonzini
On 12/07/2016 17:25, Roman Pen wrote: > AIO context in userspace is represented as a simple ring buffer, which > can be consumed directly without entering the kernel, which obviously > can bring some performance gain. QEMU does not use timeout value for > waiting for events completions, so we ca

Re: [Qemu-devel] [PATCH RFC 00/16] Rework SMP parameters

2016-07-14 Thread Andrew Jones
Eduardo, ping? I'd like to spin a v1 soon, but have been putting it off until I can get some input from you about this RFC. Thanks, drew On Fri, Jun 10, 2016 at 07:40:11PM +0200, Andrew Jones wrote: > This series is a first step in eliminating smp_* global > variables (the last patch gets rid

Re: [Qemu-devel] [PATCH v3 10/19] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug()

2016-07-14 Thread Igor Mammedov
On Wed, 13 Jul 2016 20:37:13 -0300 Eduardo Habkost wrote: > On Wed, Jul 13, 2016 at 06:59:21PM -0400, Bandan Das wrote: > > Eduardo Habkost writes: > > > > > On Wed, Jul 13, 2016 at 06:32:27PM -0400, Bandan Das wrote: > > >> Igor Mammedov writes: > > >> > > >> > consolidate possible_cpu

Re: [Qemu-devel] [RFC v2 11/11] tcg: Make tb_flush() thread safe

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > On 14/07/16 11:41, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> From: Sergey Fedorov >>> >>> Use async_safe_run_on_cpu() to make tb_flush() thread safe. >>> >>> Signed-off-by: Sergey Fedorov >>> Signed-off-by: Sergey Fedorov >>> --- >>> >>> Changes in v2: >>>

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2016-07-14 Thread Peter Maydell
Please can you (a) double check that you're definitely running the correct new QEMU and (b) provide exact reproduction instructions so I can investigate the hang. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

Re: [Qemu-devel] [RFC 1/2] linux-user: Don't leak cpus on thread exit

2016-07-14 Thread Peter Maydell
On 14 July 2016 at 08:57, David Gibson wrote: > Currently linux-user does not correctly clean up CPU instances properly > when running a threaded binary. > > On thread exit, do_syscall() removes the thread's CPU from the cpus list > and calls object_unref(). However, the CPU still is still refere

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > On 13/07/16 10:39, Paolo Bonzini wrote: >> On 12/07/2016 22:13, Sergey Fedorov wrote: >>> From: Sergey Fedorov >>> >>> Hi, >>> >>> This is my respin of Alex's v2 series [1]. >>> >>> The first 8 patches are preparation for the patch 9, the subject matter >>> of this seri

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-14 Thread Peter Maydell
On 14 July 2016 at 08:57, David Gibson wrote: > With CONFIG_USER_ONLY, generation of cpu_index values is done differently > than for full system targets. This method turns out to be broken, since > it can fairly easily result in duplicate cpu_index values for > simultaneously active cpus (i.e. th

[Qemu-devel] [PATCH 2/2] tests: Check serial output of firmware boot of some machines

2016-07-14 Thread Thomas Huth
Some of the machines that we have got a firmware image for write some output to the serial console while booting up. We can use this output to make sure that the machine is basically working, so this adds a test that checks the output of these machines for some well-known "magic" strings. Signed-o

[Qemu-devel] [PATCH 1/2] tests: Resort check-qtest entries in Makefile.include

2016-07-14 Thread Thomas Huth
The rather random list of check-qtest-xxx entries caused some confusion in the past, where to use "=" and where to use "+=" (see commits 0ccac16f59462b8e2b9afbc1 and 1f5c1cfbaec0792cd2e5da for example). Sorting the check-qtest-xxx entries by architecure instead and using some empty lines inbetween

[Qemu-devel] [PATCH 0/2] Sort tests by architecture and add a test for serial output

2016-07-14 Thread Thomas Huth
Since some of the machines that we support in QEMU sometimes get broken by other changes, and it then takes a while 'till somebody notices the breakage, it would be nice to get some more automatic test coverage for various machines during "make check". The second patch adds such a test for the mach

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu

2016-07-14 Thread Juergen Gross
On 13/07/16 14:31, Juergen Gross wrote: > Xenstore watches of the /local/domain//backend/ directories > are never removed. This can lead to a memory leak in xenstored, > especially when xenstored is running in another domain (this will be > the case either for a system with xenstore-stubdom, or wit

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-14 Thread Bharata B Rao
On Thu, Jul 14, 2016 at 3:24 PM, Peter Maydell wrote: > On 14 July 2016 at 08:57, David Gibson wrote: >> With CONFIG_USER_ONLY, generation of cpu_index values is done differently >> than for full system targets. This method turns out to be broken, since >> it can fairly easily result in duplicat

Re: [Qemu-devel] [RFC 00/13] Live memory snapshot based on userfaultfd

2016-07-14 Thread Hailiang Zhang
On 2016/7/14 2:02, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: For now, we still didn't support live memory snapshot, we have discussed a scheme which based on userfaultfd long time ago. You can find the discussion by the follow link: https://lists.nongn

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > These functions will be used to make translation block invalidation safe > with concurrent lockless lookup in the global hash table. > > Most targets don't use 'cs_base'; so marking TB as invalid is as simple > as assigning -1 to 'cs_base'. SPAR

Re: [Qemu-devel] [PULL 00/24] target-sparc improvements

2016-07-14 Thread Peter Maydell
On 12 July 2016 at 20:01, Richard Henderson wrote: > This is v4, rebased onto master, with Mark's Tested-by. > Mark asked me via private email to submit my branch for pull. > > This does *not* include the tcg fixes for the sparc windowed registers, > so an i686 host is expected to fail with or wit

[Qemu-devel] [PULL for-2.7] target-xtensa fix

2016-07-14 Thread Max Filippov
tags/20160714-xtensa for you to fetch changes up to 816344409f87a499741b387a954b172f39701b19: target-xtensa: xtfpga: fix FLASH interface width (2016-07-06 09:43:21 +0300) Xtensa-related fixes: - fix FLASH interface width for

Re: [Qemu-devel] [PATCH v18 3/4] block/gluster: using new qapi schema

2016-07-14 Thread Markus Armbruster
Prasanna Kalever writes: > On Thu, Jul 14, 2016 at 1:22 PM, Markus Armbruster wrote: >> Prasanna Kumar Kalever writes: >> >>> this patch adds 'GlusterServer' related schema in qapi/block-core.json >>> >>> Signed-off-by: Prasanna Kumar Kalever >> >> QAPI/QMP interface review only. >> >>> diff -

Re: [Qemu-devel] [PULL for-2.7] target-xtensa fix

2016-07-14 Thread Max Filippov
00) > > are available in the git repository at: > > git://github.com/OSLL/qemu-xtensa.git tags/20160714-xtensa > > for you to fetch changes up to 816344409f87a499741b387a954b172f39701b19: Ooops, sorry, wrong tag, wrong branch. -- Thanks. -- Max

[Qemu-devel] [PULL for-2.7] target-xtensa fix

2016-07-14 Thread Max Filippov
at: git://github.com/OSLL/qemu-xtensa.git tags/20160714-xtensa for you to fetch changes up to f9a555e4991b9ddc257ea8ce2e4acde672275097: target-xtensa: xtfpga: fix FLASH interface width (2016-07-14 13:59:44 +0300) Xtensa-rel

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

2016-07-14 Thread Sergey Fedorov
On 14/07/16 13:25, Alex Bennée wrote: > Sergey Fedorov writes: > >> > From: Sergey Fedorov >> > >> > These functions will be used to make translation block invalidation safe >> > with concurrent lockless lookup in the global hash table. >> > >> > Most targets don't use 'cs_base'; so marking TB as

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Sergey Fedorov
On 14/07/16 12:55, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 13/07/16 10:39, Paolo Bonzini wrote: >>> Have you measured performance with the series? In any case, it's nice >>> to see MTTCG finally taking shape! >> No, I didn't measured the performance. Maybe Alex can help me with >> thi

Re: [Qemu-devel] [RFC 00/13] Live memory snapshot based on userfaultfd

2016-07-14 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2016/7/14 2:02, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > > For now, we still didn't support live memory snapshot, we have discussed > > > a scheme which based on userfaultfd long time

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 13:10, Sergey Fedorov wrote: > > This has merge conflicts with the current state of master. Is there > > anyway to have a common implementation that is specialised only when > > needed? > > The point was to put the assumptions on invalid CPU TB state as close to > cpu_get_tb_cpu_sta

[Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb

2016-07-14 Thread Isaac Lozano
Added support for sending data larger than 4gb. Also implemented object properties so that Windows can receive >4gb files. Signed-off-by: Isaac Lozano <109loza...@gmail.com> --- hw/usb/dev-mtp.c | 196 +-- 1 file changed, 191 insertions(+), 5 de

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Alex Bennée
Paolo Bonzini writes: > On 12/07/2016 22:13, Sergey Fedorov wrote: >> From: Sergey Fedorov > > Have you measured performance with the series? In any case, it's nice > to see MTTCG finally taking shape! Here are some numbers on the multi-threaded pigz test: Before: retry.py called with ['./

Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

2016-07-14 Thread Alex Bennée
Paolo Bonzini writes: > On 14/07/2016 13:10, Sergey Fedorov wrote: >> > This has merge conflicts with the current state of master. Is there >> > anyway to have a common implementation that is specialised only when >> > needed? >> >> The point was to put the assumptions on invalid CPU TB state as

Re: [Qemu-devel] [PATCH v18 4/4] block/gluster: add support for multiple gluster servers

2016-07-14 Thread Markus Armbruster
Interface and error message review only. Prasanna Kumar Kalever writes: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 14:02, Alex Bennée wrote: > Looking at the perf data it looks like the hotest part of the code now > is cpu_get_tb_cpu_state which is required to get the initial hash to > search for the next tb. It should be possible to keep the flags up-to-date in a separate field of CPUARMState,

Re: [Qemu-devel] [PULL v2 00/34] Block layer patches

2016-07-14 Thread Peter Maydell
On 13 July 2016 at 13:50, Kevin Wolf wrote: > The following changes since commit ca3d87d4c84032f19478010b5604cac88b045c25: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-include-2016-07-12' > into staging (2016-07-12 16:04:36 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH 1/3] linux-user: complete omission of removing uses of strdup

2016-07-14 Thread Paolo Bonzini
On 07/04/2016 04:46, Wei Jiangang wrote: > The 900cfbc just removed two unchecked uses of strdup > in fill_psinfo and missed the rest in core_dump_filename. > This patch fixes it. > > Signed-off-by: Wei Jiangang > --- > linux-user/elfload.c | 7 ++- > 1 file changed, 2 insertions(+), 5 delet

Re: [Qemu-devel] [PATCH v3 03/11] tcg: Prepare safe tb_jmp_cache lookup out of tb_lock

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Ensure atomicity of CPU's 'tb_jmp_cache' access for future translation > block lookup out of 'tb_lock'. > > Note that this patch does *not* make CPU's TLB invalidation safe if it > is done from some other thread while the CPU is in its execution

Re: [Qemu-devel] [Qemu-block] [PATCH 01/17] block: Convert bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:50:58AM -0600, Eric Blake wrote: > Another step towards byte-based interfaces everywhere. Replace > the sector-based bdrv_co_discard() with a new byte-based > bdrv_co_pdiscard(), which silently ignores any unaligned head > or tail. Driver callbacks will be converted in

Re: [Qemu-devel] [Qemu-block] [PATCH 04/17] block: Convert bdrv_aio_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:01AM -0600, Eric Blake wrote: > Another step towards byte-based interfaces everywhere. Replace > the sector-based bdrv_aio_discard() with a new byte-based > bdrv_aio_pdiscard(), which silently ignores any unaligned head > or tail. Driver callbacks will be converted i

Re: [Qemu-devel] [Qemu-block] [PATCH 02/17] block: Convert bdrv_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:50:59AM -0600, Eric Blake wrote: > Another step towards byte-based interfaces everywhere. Replace > the sector-based bdrv_discard() with a new byte-based > bdrv_pdiscard(), which silently ignores any unaligned head > or tail. > > Signed-off-by: Eric Blake > --- > incl

Re: [Qemu-devel] [Qemu-block] [PATCH 15/17] raw_bsd: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:12AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake > --- > block/raw_bsd.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Descriptio

Re: [Qemu-devel] [Qemu-block] [PATCH 03/17] block: Switch BlockRequest to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:00AM -0600, Eric Blake wrote: > @@ -2204,14 +2203,15 @@ BlockAIOCB *bdrv_aio_discard(BlockDriverState *bs, > { > Coroutine *co; > BlockAIOCBCoroutine *acb; > +QEMUIOVector qiov = { .size = nb_sectors << BDRV_SECTOR_BITS, }; > > trace_bdrv_aio_disca

Re: [Qemu-devel] [Qemu-block] [PATCH 05/17] block: Convert BB interface to byte-based discards

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:02AM -0600, Eric Blake wrote: > Change sector-based blk_discard(), blk_co_discard(), and > blk_aio_discard() to instead be byte-based *_pdiscard() > functions. NBD gets a lot simpler now that ignoring the > unaligned portion of a byte-based discard request is handled

Re: [Qemu-devel] [Qemu-block] [PATCH 06/17] raw-posix: Switch paio_submit() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:03AM -0600, Eric Blake wrote: > The only remaining uses of paio_submit() were flush (with no > offset or count) and discard (which we are switching to byte-based); > furthermore, the similarly named paio_submit_co() is already > byte-based. > > Signed-off-by: Eric Bla

Re: [Qemu-devel] [PATCH v5 02/15] block/io: reuse bdrv_co_pwritev() for write compressed

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:13PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > For bdrv_pwrite_compressed() it looks like most of the code creating > coroutine is duplicated in bdrv_prwv_co(). So we can just add a flag > (BDRV_REQ_WRITE_COMPRESSED) and use bdrv_prwv_co() as a generic

Re: [Qemu-devel] [Qemu-block] [PATCH 09/17] block: Add .bdrv_co_pdiscard() driver callback

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:06AM -0600, Eric Blake wrote: > There's enough drivers with a sector-based callback that it will > be easier to switch one at a time. This patch adds a byte-based > callback, and then after all drivers are swapped, we'll drop the > sector-based callback. > > [checkpa

Re: [Qemu-devel] [Qemu-block] [PATCH 08/17] block: Convert .bdrv_aio_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:05AM -0600, Eric Blake wrote: > Another step towards byte-based interfaces everywhere. Replace > the sector-based driver callback .bdrv_aio_discard() with a new > byte-based .bdrv_aio_pdiscard(). Only raw-posix and RBD drivers > are affected, so it was not worth spli

Re: [Qemu-devel] [Qemu-block] [PATCH 07/17] rbd: Switch rbd_start_aio() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:04AM -0600, Eric Blake wrote: > The internal function converts to byte-based before calling into > RBD code; hoist the conversion to the callers so that callers > can then be switched to byte-based themselves. > > Signed-off-by: Eric Blake > --- > block/rbd.c | 18 +

Re: [Qemu-devel] [PATCH v5 08/15] block: remove BlockDriver.bdrv_write_compressed

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:19PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > There are no block drivers left that implement the old > .bdrv_write_compressed interface, so it can be removed. Also now we have > no need to use the bdrv_pwrite_compressed function and we can remove it >

Re: [Qemu-devel] [Qemu-block] [PATCH 11/17] gluster: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:08AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake > --- > block/gluster.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Desc

Re: [Qemu-devel] [Qemu-block] [PATCH 13/17] nbd: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:10AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > While at it, call directly into nbd-client.c instead of having > a pointless trivial wrapper in nbd.c. > > Signed-off-by: Eric Blake > --- > block/nbd-client.h | 3 +-- >

Re: [Qemu-devel] [Qemu-block] [PATCH 12/17] iscsi: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:09AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Unlike write_zeroes, where we can be handed unaligned requests > and must fail gracefully with -ENOTSUP for a fallback, we are > guaranteed that discard requests are always a

Re: [Qemu-devel] [Qemu-block] [PATCH v5 11/15] block: simplify blockdev-backup

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:22PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Now that we can support boxed commands, use it to greatly reduce the > number of parameters (and likelihood of getting out of sync) when > adjusting blockdev-backup parameters. > > Signed-off-by: Pavel But

Re: [Qemu-devel] [Qemu-block] [PATCH 17/17] block: Kill .bdrv_co_discard()

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:14AM -0600, Eric Blake wrote: > Now that all drivers have a byte-based .bdrv_co_pdiscard(), we > no longer need to worry about the sector-based version. We can > also relax our minimum alignment to 1 for drivers that support it. > > Signed-off-by: Eric Blake > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH 14/17] qcow2: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:11AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake > --- > block/qcow2.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Descriptio

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jul 13, 2016 at 09:57:09AM +0200, Roman Pen wrote: Please send each new revision of a patch series as a separate email thread. Do not thread revisions with Reply-To:, References:. See http://qemu-project.org/Contribute/SubmitAPatch for all the guidelines on submitting patches. > v1..v2:

Re: [Qemu-devel] [PATCH v5 14/15] qemu-iotests: test backup compression in 055

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:25PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Added cases to check the backup compression out of qcow2, raw in qcow2 > on drive-backup and blockdev-backup. > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Mark

Re: [Qemu-devel] [RFC v4] virtio-crypto specification

2016-07-14 Thread Stefan Hajnoczi
On Fri, Jul 08, 2016 at 07:27:59AM +, Gonglei (Arei) wrote: > I'd like to know what's the process of a new virtio device can be merged? > Anybody can tell me? Thanks a lot. > > Taking Virtio-gpu as an example, the virtio-gpu had been merged in Linux > kernel > And Qemu communities, but the c

Re: [Qemu-devel] [Qemu-block] [PATCH 16/17] sheepdog: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:13AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake > --- > block/sheepdog.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc

Re: [Qemu-devel] [PATCH 10/17] blkreplay: Switch .bdrv_co_discard() to byte-based

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jun 22, 2016 at 09:51:07AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake > --- > block/blkreplay.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Descript

Re: [Qemu-devel] [PATCH v9 0/7] trace: Per-vCPU tracing states

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 11, 2016 at 12:53:19PM +0200, Lluís Vilanova wrote: > NOTE: This series applies on top of "trace: [*-user] Add commandline arguments > to control tracing". > > Provides per-vCPU dynamic controls of the tracing state of events with the > "vcpu" property. > > A later series propos

Re: [Qemu-devel] [PATCHv2] OpenBIOS: switch over to official OpenBIOS git repo

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jul 12, 2016 at 08:22:49AM +0100, Mark Cave-Ayland wrote: > This update should preserve git history, and switches git.qemu-project.org > over to be a mirror of the new official git repo hosted at > https://github.com/openbios from a git-svn import of the old coreboot SVN > repository. All p

Re: [Qemu-devel] [virtio-dev][RFC v2 1/2] content: reserve virtio device ID

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 01:03:43PM +0200, Christian Pinto wrote: > Signed-off-by: Christian Pinto > Signed-off-by: Baptiste Reynal > > --- > v1 -> v2: > - removed edit including virtio-sdm specs text > --- > content.tex | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v5 09/15] block/io: turn on dirty_bitmaps for the compressed writes

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:20PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Previously was added the assert: > > commit 1755da16e32c15b22a521e8a38539e4b5cf367f3 > Author: Paolo Bonzini > Date: Thu Oct 18 16:49:18 2012 +0200 > block: introduce new dirty bitmap functional

Re: [Qemu-devel] [virtio-dev] RE: [RFC v4] virtio-crypto specification

2016-07-14 Thread Stefan Hajnoczi
On Fri, Jul 08, 2016 at 07:27:59AM +, Gonglei (Arei) wrote: > Ping... > > I'd like to know what's the process of a new virtio device can be merged? > Anybody can tell me? Thanks a lot. > > Taking Virtio-gpu as an example, the virtio-gpu had been merged in Linux > kernel > And Qemu communiti

Re: [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote: > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > index 73fa62d..d1c2e92 100644 > --- a/hw/acpi/memory_hotplug.c > +++ b/hw/acpi/memory_hotplug.c > @@ -239,11 +239,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplu

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 01:03:44PM +0200, Christian Pinto wrote: > This patch adds the specification of the Signal Dristribution Module virtio > device to the current virtio specification document. > > Signed-off-by: Christian Pinto > Signed-off-by: Baptiste Reynal > > --- > v1 -> v2: > - Fixed

Re: [Qemu-devel] [PATCH v5 00/15] backup compression

2016-07-14 Thread Stefan Hajnoczi
On Fri, Jul 08, 2016 at 04:13:24PM +0300, Denis V. Lunev wrote: > On 07/04/2016 03:28 PM, Denis V. Lunev wrote: > > The idea is simple - backup is "written-once" data. It is written block > > by block and it is large enough. It would be nice to save storage > > space and compress it. > > > > These

Re: [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 11, 2016 at 09:45:10PM +0800, Xiao Guangrong wrote: > This patchset is against commit 269fe4c3ab0c (vmw_pvscsi: remove unnecessary > internal msi state flag) on pci branch of Michael's git tree and can be found > at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v1 > > This

Re: [Qemu-devel] [virtio-dev][RFC v2 2/2] virtio-sdm: new device specification

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 01:03:44PM +0200, Christian Pinto wrote: > +\begin{lstlisting} > +struct virtio_sdm_config { > + u8master; The next field has 16-bit alignment so there is a hole in this struct. Three options: 1. Add an explicit u8 padding field. 2. Change master's type from u8 to

Re: [Qemu-devel] [PATCH v5 04/15] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:15PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Since the function became use a vector instead of a buffer there is no > sense to use a recursive code. > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Arm

Re: [Qemu-devel] [PATCH 4/8] nvdimm acpi: implement Read FIT function

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 11, 2016 at 09:45:14PM +0800, Xiao Guangrong wrote: > Read FIT whose function index is 0x is reserved by QEMU to read > the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for > detailed info > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 61 > +

[Qemu-devel] Confusing I/O throttling behavior with burst_length > 1 and max < avg

2016-07-14 Thread Stefan Hajnoczi
Hi Berto, The following throttling behavior was observed with bps=512000 bps_max=51200 throttling.bps-total-max-length=2: READ: io=512KB, aggrb=50KB/s, minb=50KB/s, maxb=50KB/s, mint=10061msec, maxt=10061msec If bps-total-max-length=1 then the result is different: READ: io=5056KB, aggrb=505

[Qemu-devel] [PATCH v6 1/6] ide: refactor retry_unit set and clear into separate function

2016-07-14 Thread Denis V. Lunev
From: Evgeny Yakovlev Code to set and clear state associated with retry in moved into ide_set_retry and ide_clear_retry to make adding retry setups easier. Signed-off-by: Evgeny Yakovlev Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini CC: Kevin Wolf CC: Max Reitz CC: Stefan Hajnocz

Re: [Qemu-devel] [PATCH v5 07/15] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:18PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Since the function became use a vector instead of a buffer there is no > sense to use a recursive code. > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Arm

Re: [Qemu-devel] [RFC 1/1] linux-aio: consume events in userspace instead of calling io_getevents

2016-07-14 Thread Stefan Hajnoczi
On Tue, Jul 12, 2016 at 05:25:39PM +0200, Roman Pen wrote: > @@ -101,6 +101,60 @@ static void qemu_laio_process_completion(struct > qemu_laiocb *laiocb) > } > } > > +/** > + * aio_ring buffer which is shared between userspace and kernel. > + */ Please extend the comment to explain that th

[Qemu-devel] Confusing I/O throttling behavior with burst_length > 1 and max < avg

2016-07-14 Thread Stefan Hajnoczi
Hi Berto, The following throttling behavior was observed with bps=512000 bps_max=51200 throttling.bps-total-max-length=2: READ: io=512KB, aggrb=50KB/s, minb=50KB/s, maxb=50KB/s, mint=10061msec, maxt=10061msec If bps-total-max-length=1 then the result is different: READ: io=5056KB, aggrb=505

[Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order

2016-07-14 Thread Denis V. Lunev
From: Evgeny Yakovlev Due to skipped flushes on bdrv_co_flush BLOCK_JOB_READY events for driver-mirror and active block-commit commands now arrives faster, before QMP send successfully returns to caller. This change expects for block job ready event to arrive before QMP send successfully returns

Re: [Qemu-devel] [PATCH v5 10/15] block: simplify drive-backup

2016-07-14 Thread Stefan Hajnoczi
On Mon, Jul 04, 2016 at 03:28:21PM +0300, Denis V. Lunev wrote: > From: Pavel Butsykin > > Now that we can support boxed commands, use it to greatly reduce the > number of parameters (and likelihood of getting out of sync) when > adjusting drive-backup parameters. > > Signed-off-by: Pavel Butsyk

Re: [Qemu-devel] [PATCH] qemu-img: add the 'dd' subcommand

2016-07-14 Thread Stefan Hajnoczi
On Thu, Jul 14, 2016 at 06:10:47AM +0200, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > s

Re: [Qemu-devel] [PATCH v4 0/6] virtio: Merge virtio-{blk, scsi} host notifier handling paths

2016-07-14 Thread Stefan Hajnoczi
On Wed, Jul 13, 2016 at 01:09:42PM +0800, Fam Zheng wrote: > v4: Drop patch 1. [Cornelia] > Add the last trivial patch. > > v3: Rebase to master. > Squash 4 into 3. [Paolo] > Add comment and commit message. [Stefan] > Add Stefan's r-b in patch 1 and 2. > > v2: Only convert virtio-

  1   2   3   4   5   >