Re: [Qemu-devel] [Qemu-ppc] [PULL 05/23] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-07-11 Thread Mark Cave-Ayland
On 11/07/16 04:09, Alfonso Gamboa wrote: > I removed OpenTransport and other extensions and control panels as well as > patched the System Suitcase on some of those iso's on the emaculation.com > forum. They are not stock images. Perhaps we still need further work. As > far as 9.0.4 booting, I

Re: [Qemu-devel] [Qemu-ppc] [PULL 05/23] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-07-11 Thread Mark Cave-Ayland
On 10/07/16 23:14, Cédric Le Goater wrote: > Mark, > > For OS 9, do you plan to commit these openbios patches soon ? > > https://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg02824.html > > as we just gave them a good test. Or may be, include them under > a github branch to make

Re: [Qemu-devel] [RFC PATCH V5 3/4] colo-compare: introduce packet comparison thread

2016-07-11 Thread Zhang Chen
On 07/08/2016 12:23 PM, Jason Wang wrote: On 2016年06月23日 19:34, Zhang Chen wrote: if packets are same, we send primary packet and drop secondary packet, otherwise notify COLO do checkpoint. More verbose please, e.g how to handle each case of exception (or maybe comment in the code). O

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread David Kiarie
On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: >> > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: >> >> On 2016-07-05 10:19, Peter Xu wrote: >> >> > Remove VT-d call

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: > >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: > >> > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrot

Re: [Qemu-devel] [RFC PATCH v2 2/5] cpu: Introduce CPUState::stable_cpu_id

2016-07-11 Thread Igor Mammedov
On Mon, 11 Jul 2016 09:05:07 +0530 Bharata B Rao wrote: > On Mon, Jul 11, 2016 at 01:22:37PM +1000, David Gibson wrote: > > On Fri, Jul 08, 2016 at 01:11:02PM +0200, Igor Mammedov wrote: > > > On Fri, 8 Jul 2016 15:19:58 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Jul 07, 2016 at

[Qemu-devel] [patch qemu] MAINTAINERS: release Scott from being a rocker maintainer

2016-07-11 Thread Jiri Pirko
From: Jiri Pirko As requested by Scott, removing him. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d0e2c3..5928f22 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -971,7 +971,6 @@ F: hw

Re: [Qemu-devel] [Qemu-ppc] [PULL 05/23] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-07-11 Thread Cédric Le Goater
On 07/11/2016 09:04 AM, Mark Cave-Ayland wrote: > On 10/07/16 23:14, Cédric Le Goater wrote: > >> Mark, >> >> For OS 9, do you plan to commit these openbios patches soon ? >> >> https://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg02824.html >> >> as we just gave them a good test. Or

Re: [Qemu-devel] [Qemu-ppc] [PULL 05/23] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-07-11 Thread Cédric Le Goater
On 07/11/2016 09:51 AM, Cédric Le Goater wrote: > On 07/11/2016 09:04 AM, Mark Cave-Ayland wrote: >> On 10/07/16 23:14, Cédric Le Goater wrote: >> >>> Mark, >>> >>> For OS 9, do you plan to commit these openbios patches soon ? >>> >>> https://lists.nongnu.org/archive/html/qemu-devel/2015-11/m

Re: [Qemu-devel] [RFC PATCH v2 2/5] cpu: Introduce CPUState::stable_cpu_id

2016-07-11 Thread Igor Mammedov
On Mon, 11 Jul 2016 13:22:37 +1000 David Gibson wrote: > On Fri, Jul 08, 2016 at 01:11:02PM +0200, Igor Mammedov wrote: > > On Fri, 8 Jul 2016 15:19:58 +1000 > > David Gibson wrote: > > > > > On Thu, Jul 07, 2016 at 08:20:22PM +0530, Bharata B Rao wrote: > > > > Add CPUState::stable_cpu_id

[Qemu-devel] [PULL 04/25] s390x/ipl: fix reboots for migration from different bios

2016-07-11 Thread Cornelia Huck
From: David Hildenbrand When migrating from a different QEMU version, the start_address and bios_start_address may differ. During migration these values are migrated and overwrite the values that were detected by QEMU itself. On a reboot, QEMU will reload its own BIOS, but use the migrated start

[Qemu-devel] [PULL 06/25] s390x/css: use define for "virtual-css-bridge" literal

2016-07-11 Thread Cornelia Huck
From: Sascha Silbe Introduce a TYPE_* define (like we already use for a couple of other QOM types) for the name of the virtual CSS bridge QOM type instead of sprinkling the same string literal over several source files. Signed-off-by: Sascha Silbe Signed-off-by: Cornelia Huck --- hw/s390x/s39

[Qemu-devel] [PULL 01/25] pc-bios/s390-ccw: Pass selected SCSI device to IPL

2016-07-11 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" There is ,bootindex=%d argument to specify the lookup order of boot devices. If a bootindex assigned to the device, then IPL Parameter Info Block is created for that device when it is IPLed from. If it is a mere SCSI device (not FCP), then IPIB is created with

[Qemu-devel] [PULL 03/25] s390x/ipl: Support IPL from selected SCSI device

2016-07-11 Thread Cornelia Huck
From: Alexander Yarygin If bootindex is specified for a device, we need to IPL from it. Currently it works for ccw devices, but not for SCSI. To be able to IPL from the specific device, pc-bios needs to know its address. For this reason we add special QEMU_SCSI IPL type into the IPLB structure, t

[Qemu-devel] [PULL 09/25] s390x/pci: fix failures of dma map/unmap

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao In commit d78c19b5cf4821d0c198f4132a085bdbf19dda4c, vfio code stores the IOMMU's offset_within_address_space and adjusts the IOVA before calling vfio_dma_map/vfio_dma_unmap. But s390_translate_iommu already considers the base address of an IOMMU memory region. Thus we use pal a

[Qemu-devel] [PULL 05/25] s390x/css: factor out some generic code from virtio_ccw_device_realize()

2016-07-11 Thread Cornelia Huck
From: Sascha Silbe A lot of what virtio_ccw_device_realize() does isn't specific to virtio; it would apply to emulated CCW as well. Factor it out to make it easier to implement emulated CCW devices later on. Signed-off-by: Sascha Silbe Reviewed-by: Dong Jia Shi Reviewed-by: Halil Pasic Signed

[Qemu-devel] [PULL 08/25] s390x/css: Unplug handler of virtual css bridge

2016-07-11 Thread Cornelia Huck
From: Jing Liu The previous patch moved virtual css bridge and bus out from virtio-ccw, but kept the direct reference of virtio-ccw specific unplug function inside css-bridge.c. To make the virtual css bus and bridge useful for non-virtio devices, this introduces a common unplug function pointer

[Qemu-devel] [PULL 02/25] pc-bios/s390-ccw.img: rebuild image

2016-07-11 Thread Cornelia Huck
Contains: - pc-bios/s390-ccw: Pass selected SCSI device to IPL Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw.img | Bin 26424 -> 26440 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index ea5fd9a4797530e79e88f591f66c4de8e93a60

[Qemu-devel] [PULL 14/25] s390x/pci: enforce zPCI state checking

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Current code uses some fields combinatorially to indicate the state of a s390 pci device. This patch introduces device states in order to make the code more readable and more logical. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s

[Qemu-devel] [PULL 21/25] s390x/pci: refactor s390_pci_find_dev_by_idx

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao s390_find_dev_by_idx() only indexes usable zpci devices. It implies that the index value of each zpci device is dynamic and may change if a new zpci device is plugged. So we have to use a constant index to look up the device. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre More

[Qemu-devel] [PULL 15/25] s390x/pci: introduce S390PCIBus

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao To enable S390PCIBusDevice as qdev, there should be a new bus to plug and manage all instances of S390PCIBusDevice. Due to this, S390PCIBus is introduced. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 10

[Qemu-devel] [PULL 17/25] s390x/pci: introduce S390PCIBusDevice qdev

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao To support definitions of s390 pci attributes in Qemu cmdline, we have to make current S390PCIBusDevice struct inherit DeviceState and add three properties for it. Currently we only support definitions of uid and fid. 'uid' is optionally defined by users, identifies a zpci devi

[Qemu-devel] [PULL 23/25] s390x/pci: fix stpcifc_service_call

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Firstly the function misses dmaas checking. This patch adds it. Secondly the function uses s390_pci_find_dev_by_fh() to look up the zpci device. This may fail if the guest provides a valid and disabled fh but fh of the associated zpci device is enabled. Thus we use s390_pci_fin

[Qemu-devel] [PULL 19/25] s390x/pci: enable zpci hot-plug/hot-unplug

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao We need to support hot-plug/hot-unplug for the new zpci devices as well. This patch enables the present hot-plug/hot-unplug handlers to support not only generic pci devices but also zpci devices. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Cornelia Huc

[Qemu-devel] [PULL 10/25] s390x/pci: acceleration for getting S390pciState

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao There are a number of places where the code needs to get the instance of S390pciState. It calls object_resolve_path() every time. This wastes a lot of time and leads to low performance. Thus we add s390_get_phb() to improve it. Because we always have a phb, we remove all return

[Qemu-devel] [PULL 20/25] s390x/pci: add checkings in CLP_SET_PCI_FN

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao The code in CLP_SET_PCI_FN case misses some checkings. Let's add them. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-inst.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/s390x/s390-pci

[Qemu-devel] [PULL 12/25] s390x/pci: unify FH_ macros

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Present code uses some macros to structure PCI Function Handle. But their names don't have a uniform format. Let's use FH_MASK_ as the unified prefix. While we're at it, differentiate the SHM bits: use different bits for vfio and emulated devices. Signed-off-by: Yi Min Zhao R

[Qemu-devel] [PULL 22/25] s390x/pci: refactor list_pci

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Because of the refactor of s390_pci_find_dev_by_idx(), list_pci() should be updated. We introduce a new function to get the next available zpci device. It simplifies the code of looking up zpci devices. Signed-off-by: Yi Min Zhao Acked-by: Pierre Morel Signed-off-by: Cornelia

[Qemu-devel] [PULL 24/25] s390x/pci: replace fid with idx in msg data of msix

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Present code uses fid as the part of message data of msix for looking up the specific zpci device. However it limits the usable range of fid, and the code looking up the zpci device may fail due to truncation of the fid. In addition, fh is composed of enabled bit, FH_VIRT and t

[Qemu-devel] [PULL 00/25] s390x patches for 2.7

2016-07-11 Thread Cornelia Huck
The following changes since commit 4f4a9ca4a4386c137301b3662faba076455ff15a: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160707' into staging (2016-07-07 14:49:38 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 13/25] s390x/pci: refactor s390_pci_find_dev_by_fh

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Because this function is called very frequently, we should use a more effective way to find the zpci device. So we use the FH's index to get the device directly. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c |

Re: [Qemu-devel] [RFC PATCH 1/2] qapi: Add vcpu id to query-hotpluggable-cpus output

2016-07-11 Thread Igor Mammedov
On Mon, 11 Jul 2016 13:30:38 +1000 David Gibson wrote: > On Fri, 8 Jul 2016 13:40:38 +0200 > Igor Mammedov wrote: > > > On Fri, 8 Jul 2016 12:18:55 +1000 > > David Gibson wrote: > > > > > On Thu, 7 Jul 2016 17:17:13 +0200 > > > Peter Krempa wrote: > > > > > > > Add 'vcpu index' to th

[Qemu-devel] [PULL 18/25] s390x/pci: enable uid-checking

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao The uid-checking facility guarantees uniqueness of the uid within the vm and exposes the real uid to the guest when listing pci devices. Let's always enable it and present it to the guest in the response to the list pci clp command. Signed-off-by: Yi Min Zhao Reviewed-by: Pier

Re: [Qemu-devel] [RFC PATCH v2 3/5] spapr: Set stable_cpu_id for threads of CPU cores

2016-07-11 Thread Igor Mammedov
On Mon, 11 Jul 2016 13:26:01 +1000 David Gibson wrote: > On Fri, Jul 08, 2016 at 12:59:59PM +0200, Igor Mammedov wrote: > > On Fri, 8 Jul 2016 17:39:52 +1000 > > David Gibson wrote: > > > > > On Fri, Jul 08, 2016 at 12:11:12PM +0530, Bharata B Rao wrote: > > > > On Fri, Jul 08, 2016 at 03:2

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 09:41, Peter Xu wrote: > As mentioned in previous email, before Marcel's patches, > vtd_host_dma_iommu() was named q35_host_dma_iommu(). At that time, I > need "find_add_as" to let Q35 codes get rid of direct calls to VT-d > (so that pc_q35.c will not need to include "intel_iommu.h"

[Qemu-devel] [PULL 11/25] s390x/pci: write fid in CLP_QUERY_PCI_FN

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao We forgot to write the fid; fix that. Signed-off-by: Yi Min Zhao Acked-by: Pierre Morel Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-inst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 479375f..2cd7d14 1

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 10:30:38AM +0200, Paolo Bonzini wrote: > > > On 11/07/2016 09:41, Peter Xu wrote: > > As mentioned in previous email, before Marcel's patches, > > vtd_host_dma_iommu() was named q35_host_dma_iommu(). At that time, I > > need "find_add_as" to let Q35 codes get rid of direct

[Qemu-devel] [PULL 16/25] s390x/pci: introduce S390PCIIOMMU

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao Currently each zpci device holds its own DMA address space and memory region. At the same time, all instances of zpci device are stored in S390pciState. So duirng the initialization of S390pciState, all zpci devices are created and then all DMA address spaces are created. Thus,

[Qemu-devel] [PULL 07/25] s390x/css: Factor out virtual css bridge and bus

2016-07-11 Thread Cornelia Huck
From: Jing Liu Currently, common base layers virtual css bridge and bus are defined in hw/s390x/virtio-ccw.c(h). In order to support multiple types of devices in the virtual channel subsystem, especially non virtio-ccw, refactoring work needs to be done. This work is just a pure code move withou

[Qemu-devel] [PULL 25/25] s390x/pci: make hot-unplug handler smoother

2016-07-11 Thread Cornelia Huck
From: Yi Min Zhao The current implementation of hot-unplug handler is abrupt. Any pci operation will be just rejected if pci device is unconfigured. Thus a pci device can not be reset or destroyed in a right, smooth and safe way. Improve this as follows: - Notify the guest via a HP_EVENT_DECONFI

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Jason Wang
On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index d0b9ff9..005162d 100644 --- a/vl.c +++ b/vl.c @@ -4327,9 +4327,6 @@ in

[Qemu-devel] [PATCH V4 0/6] coroutine: mmap stack memory and stack size

2016-07-11 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

[Qemu-devel] [PATCH V4 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-07-11 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/coroutine-sigaltstack.c +++

[Qemu-devel] [PATCH V4 2/6] coroutine: add a macro for the coroutine stack size

2016-07-11 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/qemu/coroutine

[Qemu-devel] [PATCH V4 6/6] coroutine: reduce stack size to 64kB

2016-07-11 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

Re: [Qemu-devel] [PATCH RFC v4 0/4] docker: Support building qemu-user powered docker test images

2016-07-11 Thread Alex Bennée
Fam Zheng writes: > Alex, > > This is the result of my fiddling around docker + qemu-user in the weekend. It > can do most of the work except the injection of qemu-user binary from host > build. We can try to integrate your "docker.py update" into Makefile to do > that, but an open question is

[Qemu-devel] [PATCH V4 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-11 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Signed-off-by: Peter Lieven --- include/sysemu/os-posix.h |

[Qemu-devel] [PATCH V4 5/6] oslib-posix: add a configure switch to debug stack usage

2016-07-11 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven --- configure | 19 +++ util/oslib-posix.c | 37 + 2 files changed, 56 insertions(+) diff --git a/configure b/configu

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread David Kiarie
On Mon, Jul 11, 2016 at 10:41 AM, Peter Xu wrote: > On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: >> On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: >> > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: >> >> On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: >> >> >

[Qemu-devel] [PATCH V4 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-07-11 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/coroutine-ucontext.c +++ b/util/cor

Re: [Qemu-devel] [PATCH RFC v4 3/4] docker: Support "QEMU_CHROOT" in dockerfiles

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 05:20, Fam Zheng wrote: > This allows a docker file to say "ENV QEMU_CHROOT /path/to/new/root" to > indicate that the test execution should be done in a chroot in the > container. > > Bind mount dev,sys,proc into QEMU_CHROOT to make them avaiable for > testing scripts. > > The SYS

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 11:06, Jason Wang wrote: > > > On 2016年07月08日 23:27, Paolo Bonzini wrote: >> Otherwise, vhost-user causes a use-after-free. >> >> Signed-off-by: Paolo Bonzini >> --- >> vl.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index

Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as()

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 12:11:10PM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 10:41 AM, Peter Xu wrote: > > On Mon, Jul 11, 2016 at 10:16:11AM +0300, David Kiarie wrote: > >> On Mon, Jul 11, 2016 at 9:49 AM, Peter Xu wrote: > >> > On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie w

Re: [Qemu-devel] [PATCH 13/15] exec: use mmap for PhysPageMap->nodes

2016-07-11 Thread Peter Lieven
Am 28.06.2016 um 12:43 schrieb Paolo Bonzini: On 28/06/2016 11:01, Peter Lieven wrote: this was causing serious framentation in conjunction with the subpages since RCU was introduced. The node space was allocated at approx 32kB then reallocted to approx 75kB and this a few hundred times at star

Re: [Qemu-devel] [PATCH 13/15] exec: use mmap for PhysPageMap->nodes

2016-07-11 Thread Peter Lieven
Am 11.07.2016 um 11:31 schrieb Peter Lieven: Am 28.06.2016 um 12:43 schrieb Paolo Bonzini: On 28/06/2016 11:01, Peter Lieven wrote: this was causing serious framentation in conjunction with the subpages since RCU was introduced. The node space was allocated at approx 32kB then reallocted to ap

Re: [Qemu-devel] [RFC PATCH V5 4/4] colo-compare: add TCP, UDP, ICMP packet comparison

2016-07-11 Thread Zhang Chen
On 07/08/2016 04:59 PM, Jason Wang wrote: On 2016年06月23日 19:34, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 171 +++-- trace-events | 6 ++ 2 files

Re: [Qemu-devel] [PATCH RFC v4 3/4] docker: Support "QEMU_CHROOT" in dockerfiles

2016-07-11 Thread Alex Bennée
Paolo Bonzini writes: > On 11/07/2016 05:20, Fam Zheng wrote: >> This allows a docker file to say "ENV QEMU_CHROOT /path/to/new/root" to >> indicate that the test execution should be done in a chroot in the >> container. >> >> Bind mount dev,sys,proc into QEMU_CHROOT to make them avaiable for >>

Re: [Qemu-devel] [PATCH] gtk: fix build

2016-07-11 Thread Peter Maydell
On 7 July 2016 at 08:29, Gerd Hoffmann wrote: > Commit "9d8256e virgl: pass whole GL scanout dimensions" missed the > opengl code path for gtk versions >= 3.16. Update that one too and > fix the build with recent gtk versions. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Gerd Hoffman

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2016-07-11 Thread Peter Maydell
On 7 July 2016 at 14:48, Peter Maydell wrote: > > This week's collection of target-arm bugfixes... > > thanks > -- PMM > > > The following changes since commit 5563168c530e2cde8e000ee7aa4afc0ea4d0b42e: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (201

Re: [Qemu-devel] [PATCH v10 27/26] intel_iommu: disallow kernel-irqchip=on with IR

2016-07-11 Thread David Kiarie
On Fri, Jun 24, 2016 at 10:10 AM, Peter Xu wrote: > When user specify "kernel-irqchip=on", throw error and then quit. > > Signed-off-by: Peter Xu > --- > > One more patch for this series. Without this one, guest kernel will > possibly hang. This is not user friendly. > > hw/i386/intel_iommu.c |

Re: [Qemu-devel] [PATCH 13/15] exec: use mmap for PhysPageMap->nodes

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 11:31, Peter Lieven wrote: > Am 28.06.2016 um 12:43 schrieb Paolo Bonzini: >> >> On 28/06/2016 11:01, Peter Lieven wrote: >>> this was causing serious framentation in conjunction with the >>> subpages since RCU was introduced. The node space was allocated >>> at approx 32kB then rea

Re: [Qemu-devel] [PATCH RFC v4 3/4] docker: Support "QEMU_CHROOT" in dockerfiles

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 12:08, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 11/07/2016 05:20, Fam Zheng wrote: >>> This allows a docker file to say "ENV QEMU_CHROOT /path/to/new/root" to >>> indicate that the test execution should be done in a chroot in the >>> container. >>> >>> Bind mount dev,

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-07-11 Thread David Hildenbrand
> Are there any further comments, especially on patches 23-25, introducing new > QOM interfaces? Ping, can somebody please have a look, especially on patches 23-25? We really want to know if we can proceed with this CPU model approach. David > > Also, if anybody is planning to look into this, p

[Qemu-devel] [PATCH v9 3/7] [trivial] trace: Cosmetic changes on fast-path tracing

2016-07-11 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- trace/control-internal.h |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/trace/control-internal.h b/trace/control-internal.h index 5e0a5ab..c5f5f3d 100644 --- a/trace/control-internal.h +++ b/trace/contr

[Qemu-devel] [PATCH v9 0/7] trace: Per-vCPU tracing states

2016-07-11 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: [*-user] Add commandline arguments to control tracing". Provides per-vCPU dynamic controls of the tracing state of events with the "vcpu" property. A later series proposes an optimization where tracing code can be elided for dynamically disabled e

[Qemu-devel] [PATCH v9 6/7] trace: Allow event name pattern in "info trace-events"

2016-07-11 Thread Lluís Vilanova
Homogenizes the command capabilities with QMP. Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- hmp-commands-info.hx |8 +--- hmp.h|1 + monitor.c| 31 ++- 3 files changed, 36 insertio

[Qemu-devel] [PATCH v9 1/7] trace: Identify events with the 'vcpu' property

2016-07-11 Thread Lluís Vilanova
A new event attribute 'cpu_id' is added to have a separate ID space ('TRACE_VCPU_*') for all events with the 'vcpu' property. These are later used to identify which events are enabled on each vCPU. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c

[Qemu-devel] [PATCH v9 4/7] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-07-11 Thread Lluís Vilanova
Each vCPU gets a 'trace_dstate' bitmap to control the per-vCPU dynamic tracing state of events with the 'vcpu' property. Signed-off-by: Lluís Vilanova --- bsd-user/main.c |1 + include/qom/cpu.h|6 + linux-user/main.c|1 + qom/cpu.c|1

[Qemu-devel] [PATCH v9 5/7] trace: Conditionally trace events based on their per-vCPU state

2016-07-11 Thread Lluís Vilanova
Events with the 'vcpu' property are conditionally emitted according to their per-vCPU state. Other events are emitted normally based on their global tracing state. Note that the per-vCPU condition check applies to all tracing backends. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v9 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-07-11 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster --- hmp-commands-info.hx |6 +- hmp-commands.hx |7 +- monitor.c| 17 +- qapi/trace.json | 33 ++- qmp-commands.hx | 35 +++- trace/qmp.c

[Qemu-devel] [PATCH v9 2/7] disas: Remove unused macro '_'

2016-07-11 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- disas/alpha.c |6 +++--- disas/arm.c |2 +- disa

Re: [Qemu-devel] [Qemu-block] [PULL 19/32] commit: Fix use of error handling policy

2016-07-11 Thread Kevin Wolf
Am 08.07.2016 um 23:36 hat Eric Blake geschrieben: > On 07/08/2016 11:21 AM, Kevin Wolf wrote: > > Commit implemented the 'enospc' policy as 'ignore' if the error was not > > Was there supposed to be a commit id in this sentence? Yes. Or well, I intended to put a commit id there, but it's really

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Jason Wang
On 2016年07月11日 17:18, Paolo Bonzini wrote: On 11/07/2016 11:06, Jason Wang wrote: On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 13:23, Jason Wang wrote: > > > On 2016年07月11日 17:18, Paolo Bonzini wrote: >> >> On 11/07/2016 11:06, Jason Wang wrote: >>> >>> On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl

Re: [Qemu-devel] [PATCH RFC v4 3/4] docker: Support "QEMU_CHROOT" in dockerfiles

2016-07-11 Thread Alex Bennée
Fam Zheng writes: > This allows a docker file to say "ENV QEMU_CHROOT /path/to/new/root" to > indicate that the test execution should be done in a chroot in the > container. > > Bind mount dev,sys,proc into QEMU_CHROOT to make them avaiable for > testing scripts. > > The SYS_ADMIN is a required

Re: [Qemu-devel] [PULL 19/32] commit: Fix use of error handling policy

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 13:22, Kevin Wolf wrote: >>> > > Commit implemented the 'enospc' policy as 'ignore' if the error was not >> > >> > Was there supposed to be a commit id in this sentence? > Yes. Or well, I intended to put a commit id there, but it's really since > live commit was first merged in 747

Re: [Qemu-devel] [PATCH trivial] Remove unused function declarations

2016-07-11 Thread Ladi Prosek
On Mon, Jun 13, 2016 at 4:20 PM, Ladi Prosek wrote: > Unused function declarations were found using a simple gcc plugin and > manually verified by grepping the sources. > > Signed-off-by: Ladi Prosek > --- > Posting as one trivial patch because no domain specific knowledge is > required to verify

Re: [Qemu-devel] [Qemu-block] [PULL 19/32] commit: Fix use of error handling policy

2016-07-11 Thread Max Reitz
On 11.07.2016 13:22, Kevin Wolf wrote: > Am 08.07.2016 um 23:36 hat Eric Blake geschrieben: >> On 07/08/2016 11:21 AM, Kevin Wolf wrote: >>> Commit implemented the 'enospc' policy as 'ignore' if the error was not >> >> Was there supposed to be a commit id in this sentence? > > Yes. Or well, I inte

Re: [Qemu-devel] [PATCH v2] Fix confusing argument names in some common functions

2016-07-11 Thread Sergey Sorokin
11.07.2016, 05:18, "David Gibson" : > I'm afraid your mailer has turned this into an unreadable HTML mess. It was just a ping. http://patchwork.ozlabs.org/patch/635235/

Re: [Qemu-devel] [RFC v2 05/11] cpus: Rename flush_queued_work()

2016-07-11 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > To avoid possible confusion, rename flush_queued_work() to > process_queued_cpu_work(). > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée > --- > cpus.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH v10 27/26] intel_iommu: disallow kernel-irqchip=on with IR

2016-07-11 Thread Peter Xu
On Mon, Jul 11, 2016 at 01:17:40PM +0300, David Kiarie wrote: > On Fri, Jun 24, 2016 at 10:10 AM, Peter Xu wrote: > > When user specify "kernel-irqchip=on", throw error and then quit. > > > > Signed-off-by: Peter Xu > > --- > > > > One more patch for this series. Without this one, guest kernel wi

Re: [Qemu-devel] [RFC v2 04/11] cpus: Wrap mutex used to protect CPU work

2016-07-11 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > This will be useful to enable CPU work on user mode emulation. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée > --- > cpus.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [RFC v2 06/11] linux-user: Use QemuMutex and QemuCond

2016-07-11 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Convert pthread_mutex_t and pthread_cond_t to QemuMutex and QemuCond. > This will allow to make some locks and conditional variables common > between user and system mode emulation. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedo

Re: [Qemu-devel] [PATCH] target-arm: Add missed AArch32 TLBI sytem registers

2016-07-11 Thread Sergey Sorokin
ping http://patchwork.ozlabs.org/patch/639688/

Re: [Qemu-devel] [PATCH RFC v4 3/4] docker: Support "QEMU_CHROOT" in dockerfiles

2016-07-11 Thread Alex Bennée
Fam Zheng writes: > This allows a docker file to say "ENV QEMU_CHROOT /path/to/new/root" to > indicate that the test execution should be done in a chroot in the > container. > > Bind mount dev,sys,proc into QEMU_CHROOT to make them avaiable for > testing scripts. > > The SYS_ADMIN is a required

Re: [Qemu-devel] [PATCH v4 5/5] x86: Set physical address bits based on host

2016-07-11 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Fri, Jul 08, 2016 at 04:01:39PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Add the host-phys-bits boolean property, if true, take phys-bits > > from the hosts physical bits value, overriding either the

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Christian Borntraeger
On 07/06/2016 11:14 PM, Sergey Fedorov wrote: > From: Alex Bennée > > CPUState is a fairly common pointer to pass to these helpers. This means > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the routine. For > the curr

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Sergey Fedorov
On 11/07/16 15:36, Christian Borntraeger wrote: > On 07/06/2016 11:14 PM, Sergey Fedorov wrote: >> From: Alex Bennée >> >> CPUState is a fairly common pointer to pass to these helpers. This means >> if you need other arguments for the async_run_on_cpu case you end up >> having to do a g_malloc to

Re: [Qemu-devel] [PULL 19/32] commit: Fix use of error handling policy

2016-07-11 Thread Kevin Wolf
Am 11.07.2016 um 13:40 hat Paolo Bonzini geschrieben: > > > On 11/07/2016 13:22, Kevin Wolf wrote: > >>> > > Commit implemented the 'enospc' policy as 'ignore' if the error was > >>> > > not > >> > > >> > Was there supposed to be a commit id in this sentence? > > Yes. Or well, I intended to put

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Marc-André Lureau
Hi - Original Message - > > > On 11/07/2016 13:23, Jason Wang wrote: > > > > > > On 2016年07月11日 17:18, Paolo Bonzini wrote: > >> > >> On 11/07/2016 11:06, Jason Wang wrote: > >>> > >>> On 2016年07月08日 23:27, Paolo Bonzini wrote: > Otherwise, vhost-user causes a use-after-free. > >>

Re: [Qemu-devel] [RFC v2 02/11] cpus: pass CPUState to run_on_cpu helpers

2016-07-11 Thread Christian Borntraeger
On 07/11/2016 02:38 PM, Sergey Fedorov wrote: > On 11/07/16 15:36, Christian Borntraeger wrote: >> On 07/06/2016 11:14 PM, Sergey Fedorov wrote: >>> From: Alex Bennée >>> >>> CPUState is a fairly common pointer to pass to these helpers. This means >>> if you need other arguments for the async_run_

Re: [Qemu-devel] [PATCH RFC v4 2/4] docker: Fix exit code if $CMD failed

2016-07-11 Thread Eric Blake
On 07/10/2016 09:20 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/docker/run | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/docker/run b/tests/docker/run > index 575e732..38ce789 100755 > --- a/tests/docker/run > +++ b/tests/docker/run > @@ -11,6 +11,8 @@ > #

Re: [Qemu-devel] [PATCH v4 5/5] x86: Set physical address bits based on host

2016-07-11 Thread Eduardo Habkost
On Mon, Jul 11, 2016 at 01:29:56PM +0100, Dr. David Alan Gilbert wrote: [...] > > Do you want me to repost just this patch or the whole set? You can use my x86-next branch as base (it already includes the other patches), so you can repost just this patch. git://github.com/ehabkost/qemu.git x86-

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 14:51, Marc-André Lureau wrote: > Hi > > - Original Message - >> >> >> On 11/07/2016 13:23, Jason Wang wrote: >>> >>> >>> On 2016年07月11日 17:18, Paolo Bonzini wrote: On 11/07/2016 11:06, Jason Wang wrote: > > On 2016年07月08日 23:27, Paolo Bonzini wrote: >

Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump()

2016-07-11 Thread Sergey Fedorov
On 08/07/16 23:52, Paolo Bonzini wrote: > > On 08/07/2016 22:24, Sergey Fedorov wrote: >> I remember, I've just found that we discussed it in this thread: >> >> http://thread.gmane.org/gmane.comp.emulators.qemu/401723/focus=406852 >> >> I was thinking of just doing 'tb_jmp_cache' lookup out of the

Re: [Qemu-devel] [PATCH] resize qcow2 with snapshot

2016-07-11 Thread Kevin Wolf
Am 24.06.2016 um 13:10 hat zhangzhiming geschrieben: > qcow2 can’t be resized while there is a snapshot in qcow2 image but in version > 3 image of qcow2, > each disk size of snapshot is stored in the image, so we can resize image even > through this are some snapshots > since version 3 image. the

[Qemu-devel] [PATCH] iotests: Make 157 actually format-agnostic

2016-07-11 Thread Max Reitz
iotest 157 pretends not to care about the image format used, but in fact it does due to the format name not being filtered in its output. This patch adds filtering and changes the reference output accordingly. Signed-off-by: Max Reitz --- tests/qemu-iotests/157 | 3 ++- tests/qemu-iotests/1

[Qemu-devel] [PATCH] VARIANT 1: reuse device compat logic to pick preffered CPU's migration instance_id

2016-07-11 Thread Igor Mammedov
this approach i I preffer as it uses less per machine migration glue and follows typical compat pattern for devices Signed-off-by: Igor Mammedov Signed-off-by: Bharata B Rao --- exec.c | 7 +-- hw/i386/pc.c| 10 +++--- include/hw/compat.h | 6 +- include/qom/c

[Qemu-devel] [PATCH] VARIANT 2: use machine specific callback to pick CPU's migration instance_id

2016-07-11 Thread Igor Mammedov
it uses less CPU only code but needs per machine glue (pc+q53 for x86) to keep migration instance_id == cpu_index for old machine types. Signed-off-by: Igor Mammedov Signed-off-by: Bharata B Rao --- exec.c| 8 ++-- hw/i386/pc.c | 16 hw/i386/pc_piix.c | 3

Re: [Qemu-devel] [PATCH v5 4/4] block: ignore flush requests when storage is clean

2016-07-11 Thread Evgeny Yakovlev
On 08.07.2016 21:44, John Snow wrote: On 07/04/2016 10:38 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on host when calling fsync/fdatasync. Thi

  1   2   3   >