Re: [Qemu-devel] [PATCH v3 2/7] ppc: move smp_threads sanity checks to spapr

2016-07-07 Thread Greg Kurz
On Thu, 07 Jul 2016 11:57:32 +1000 Benjamin Herrenschmidt wrote: > On Thu, 2016-07-07 at 11:12 +1000, David Gibson wrote: > > I'm not comfortable with this.  SMT may only be used for pseries at > > the moment, but the SMT possibilities are absolutely a constraint of > > the CPU itself, not the ma

[Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Gerd Hoffmann
This patch flips the default from gtk2 to gtk3. Sounds like a bigger change than it actually is as configure already uses gtk3 in case it doesn't find gtk2. So this changes behavior only in case both gtk2 and gtk3 devel packages are installed. Signed-off-by: Gerd Hoffmann --- configure | 8 +++

[Qemu-devel] [PATCH] vmdk: fix metadata write regression

2016-07-07 Thread Reda Sallahi
Commit "cde6361 vmdk: add bdrv_co_write_zeroes" causes a regression on writes. It writes metadata after every write instead of doing it only once for each cluster. vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch sets m_data as valid only when we have a new cluster whic

Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

2016-07-07 Thread Zhang Chen
Hi~~ Jason~ Have any comments? By the way this patch set depend on the patch [RFC PATCH V2] qemu-char: Fix context for g_source_attach() but no one review itany suggestion? Thanks Zhang Chen On 06/23/2016 07:34 PM, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to

[Qemu-devel] [PATCH] gtk: fix build

2016-07-07 Thread Gerd Hoffmann
Commit "9d8256e virgl: pass whole GL scanout dimensions" missed the opengl code path for gtk versions >= 3.16. Update that one too and fix the build with recent gtk versions. Reported-by: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 1 + ui/gtk-gl-area.c | 1 + 2

[Qemu-devel] [PATCH v3] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB

2016-07-07 Thread Stanislav Shmarov
In user-mode emulation Translation Block can consist of 2 guest pages. In that case QEMU also mprotects 2 host pages that are dedicated for guest memory, containing instructions. QEMU detects self-modifying code with SEGFAULT signal processing. In case if instruction in 1st page is modifying memor

Re: [Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

2016-07-07 Thread Jason Wang
On 2016年07月07日 15:47, Zhang Chen wrote: Hi~~ Jason~ Have any comments? By the way this patch set depend on the patch Will go through this tomorrow. [RFC PATCH V2] qemu-char: Fix context for g_source_attach() but no one review itany suggestion? I think you may want to ping the mainta

[Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Reda Sallahi
Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on writes. It writes metadata after every write instead of doing it only once for each cluster. vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch sets m_data as valid only when we have a new cluster whic

Re: [Qemu-devel] [PATCH v3 7/7] spapr: consolidate the logic of core cpu_dt_id

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 12:05:02 +1000 David Gibson wrote: > On Wed, Jul 06, 2016 at 02:14:59PM +0200, Greg Kurz wrote: > > POWER5 and newer cpus from IBM have a specific numbering scheme for > > DT ids. This is currently open coded in several places. > > > > This patch consolidates the logic in help

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Needs a rebase. The other one, too. Paolo Bonzini writes: > This saves a lot of memory compared to a statically-sized array. > > Signed-off-by: Paolo Bonzini Saves 24KiB - d*32B. That's "a lot" for an Atari ST or something, or if you're juggling hundreds of these things at the same time. Al

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > On 07/06/2016 06:43 AM, Paolo Bonzini wrote: >> This saves a lot of memory compared to a statically-sized array. >> >> Signed-off-by: Paolo Bonzini >> --- >> qapi/qmp-input-visitor.c | 53 >> >> 1 file changed, 26 insertion

Re: [Qemu-devel] [PATCH] qapi: change QmpOutputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > This saves a little memory compared to the doubly-linked QTAILQ. > > Signed-off-by: Paolo Bonzini The memory savings are trivial: we go from 160 + 24*d to 160 + 16*d, where d is the depth of the tree we visit, almost always in the single digits. But I like the simplicit

Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register quorum driver if SHA256 support is unavailable"

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 12:50:00 PM CEST, "Daniel P. Berrange" wrote: > The qcrypto hash APIs now guarantee that sha256 is available at > compile time, so skipping registration is rarely needed. A check > at time of open is kept to ensure good error reporting in the > (unlikely) case sha256 is runtime

Re: [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 12:49:59 PM CEST, "Daniel P. Berrange" wrote: > +cs = g_checksum_new(qcrypto_hash_alg_map[alg]); > + > +for (i = 0; i < niov; i++) { > +g_checksum_update(cs, iov[i].iov_base, iov[i].iov_len); > +} Not too important, but you could do this after checking the

Re: [Qemu-devel] [PATCH v3 5/7] ppc: each machine type to provide vcpu_dt_id

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 12:01:51 +1000 David Gibson wrote: > On Wed, Jul 06, 2016 at 02:14:36PM +0200, Greg Kurz wrote: > > This patch switches machine types to provide device-tree cpu ids. > > > > We have three cases to handle: > > > > - pseries < 2.7 call ppc_cpu_init() and should compute the DT i

Re: [Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Fam Zheng
On Thu, 07/07 10:42, Reda Sallahi wrote: > Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on > writes. It writes metadata after every write instead of doing it only once > for each cluster. > > vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch > sets

Re: [Qemu-devel] [PATCH v1 3/2] crypto: don't open-code qcrypto_hash_supports

2016-07-07 Thread Alberto Garcia
On Tue 05 Jul 2016 06:43:13 PM CEST, "Daniel P. Berrange" wrote: > Call the existing qcrypto_hash_supports method from > qcrypto_hash_bytesv instead of open-coding it again. > > Signed-off-by: Daniel P. Berrange "PATCH 3/2" ? :-) Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm

2016-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2016 at 08:53:56AM -0600, Eric Blake wrote: > On 07/06/2016 05:58 AM, Alberto Garcia wrote: > > On Tue 05 Jul 2016 12:49:59 PM CEST, "Daniel P. Berrange" > > wrote: > > > >> GLib >= 2.16 provides GChecksum API which is good enough > >> for md5, sha1, sha256 and sha512. Use this a

Re: [Qemu-devel] [PULL v2 0/4] tcg-ish updates

2016-07-07 Thread Peter Maydell
On 6 July 2016 at 17:18, Richard Henderson wrote: > Three tcg patches, and a build change so that we can still > use --cpu=i686 on a x86_64 host, now that linux-user has > the syscall assembly thunks. > > Change from v1 to v2 is a one-line revert to patch 3, the > spilling of constants, which affe

Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2016 at 09:34:47AM +0200, Gerd Hoffmann wrote: > This patch flips the default from gtk2 to gtk3. > > Sounds like a bigger change than it actually is as configure already > uses gtk3 in case it doesn't find gtk2. So this changes behavior > only in case both gtk2 and gtk3 devel pack

Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 10:29, Daniel P. Berrange wrote: > On Thu, Jul 07, 2016 at 09:34:47AM +0200, Gerd Hoffmann wrote: >> This patch flips the default from gtk2 to gtk3. >> >> Sounds like a bigger change than it actually is as configure already >> uses gtk3 in case it doesn't find gtk2. So this chan

[Qemu-devel] [PATCH] timer.h: fix typo

2016-07-07 Thread Cao jin
Signed-off-by: Cao jin --- include/qemu/timer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 309f3d0..41e8325 100644 --- a/include/qemu/timer.h +++ b/include/qemu/timer.h @@ -179,7 +179,7 @@ int64_t qemu_clock_deadline

Re: [Qemu-devel] [PATCH] timer.h: fix typo

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 11:15, Cao jin wrote: > Signed-off-by: Cao jin > --- > include/qemu/timer.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/qemu/timer.h b/include/qemu/timer.h > index 309f3d0..41e8325 100644 > --- a/include/qemu/timer.h > +++ b/include/qe

Re: [Qemu-devel] [PULL] Net patches

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 07:53, Jason Wang wrote: > The following changes since commit 91d35509903464c7f4b9ed56be223d7370d3597c: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160706' into > staging (2016-07-06 17:32:09 +0100) > > are available in the git repository at: > > https://gi

Re: [Qemu-devel] [PATCH v8 08/16] qapi: Implement boxed types for commands/events

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > Turn on the ability to pass command and event arguments in > a single boxed parameter, which must name a non-empty type > (although the type can be a struct with all optional members). > For structs, it makes it possible to pass a single qapi type > instead of a breakout of a

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-07-07 Thread Peter Maydell
On 4 July 2016 at 10:55, Peter Maydell wrote: > On 1 July 2016 at 18:49, Dmitry Osipenko wrote: >> On 01.07.2016 19:36, Peter Maydell wrote: >>> On 30 June 2016 at 20:01, Dmitry Osipenko wrote: On 30.06.2016 18:02, Peter Maydell wrote: > What I meant was: ptimer_get_count() is typically

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
On 07/07/2016 10:19, Markus Armbruster wrote: > Actually, you should either prove that untrusted input still cannot make > us allocated unbounded amounts of memory, or bring the limit right back. This is not where untrusted input can be blocked from allocating unbounded memory---that would be Qm

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
On 06/07/2016 17:39, Eric Blake wrote: > On 07/06/2016 06:43 AM, Paolo Bonzini wrote: >> This saves a lot of memory compared to a statically-sized array. >> >> Signed-off-by: Paolo Bonzini >> --- >> qapi/qmp-input-visitor.c | 53 >> >> 1 file ch

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user reconnect fixes

2016-07-07 Thread Marc-André Lureau
Hi On Thu, Jul 7, 2016 at 3:00 AM, wrote: > From: Marc-André Lureau > > Hi, > > Since 'vhost-user: simple reconnection support' was merged, it is > possible to disconnect and reconnect a vhost-user backend. However, > many code paths in qemu may trigger assert() when the backend is > disconnect

[Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Paolo Bonzini
This saves a lot of memory compared to a statically-sized array, or at least 24kb could be considered a lot on an Atari ST. It also makes the code more similar to QmpOutputVisitor. Signed-off-by: Paolo Bonzini --- v1->v2: leave assert in check_struct [Eric, Markus] qapi/qmp-input-visit

Re: [Qemu-devel] [PATCH v8 11/16] qapi-event: Reduce chance of collision with event data

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > When an unboxed event has accompanying data, we are exposing all > of its members alongside our local variables in the generated > qapi_event_send_FOO() function. So far, we haven't hit a > collision, but it may be a matter of time before someone wants > to name a QMP data e

[Qemu-devel] [PATCH V3 5/6] oslib-posix: add a configure switch to debug stack usage

2016-07-07 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven --- configure | 19 +++ util/oslib-posix.c | 37 + 2 files changed, 56 insertions(+) diff --git a/configure b/configu

[Qemu-devel] [PATCH V3 0/6] coroutine: mmap stack memory and stack size

2016-07-07 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

[Qemu-devel] [PATCH V3 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/coroutine-ucontext.c +++ b/util/cor

[Qemu-devel] [PATCH V3 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/coroutine-sigaltstack.c +++

[Qemu-devel] [PATCH V3 2/6] coroutine: add a macro for the coroutine stack size

2016-07-07 Thread Peter Lieven
Reviewed-by: Richard Henderson Signed-off-by: Peter Lieven --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/qemu/coroutine

Re: [Qemu-devel] [PATCH 1/3] linux-user: fd_trans_*_data() returns the length

2016-07-07 Thread Laurent Vivier
Le 30/06/2016 à 09:52, Riku Voipio a écrit : > > Hi, > > I've merged the netlink patches the que[1]. I'm waiting to see if > we'll get some fixup patches to the fairly substantial changes > linux-user has seen in this cycle. > > Riku > > [1] > https://git.linaro.org/people/riku.voipio/qemu.g

Re: [Qemu-devel] Qemu and PCI Interrupt Link?

2016-07-07 Thread Peter Lieven
Am 05.07.2016 um 22:53 schrieb Paolo Bonzini: On 05/07/2016 20:30, Laszlo Ersek wrote: On 07/04/16 15:14, Peter Lieven wrote: Hi, i noticed that newer guest kernels emit the following message at startup: ACPI: No IRQ available for PCI Interrupt Link [LNKS]. Try pci=noacpi or acpi=off Cmdlin

[Qemu-devel] [PATCH V3 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-07 Thread Peter Lieven
the allocated stack will be adjusted to the minimum supported stack size by the OS. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Suggested-by: Peter Maydell Signed-off-by: Peter Lieven --- include/sysemu/os-posix.h | 23 ++

[Qemu-devel] [PATCH V3 6/6] coroutine: reduce stack size to 64kB

2016-07-07 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added i

Re: [Qemu-devel] [PATCH] block/iscsi: precache the allocation status of a target

2016-07-07 Thread Peter Lieven
Am 30.06.2016 um 17:59 schrieb Paolo Bonzini: On 30/06/2016 13:08, Peter Lieven wrote: this fills up the allocationmap at iscsi_open. This helps to reduce the number of get_block_status requests during runtime significantly. Signed-off-by: Peter Lieven --- block/iscsi.c | 16 +++

Re: [Qemu-devel] [PATCH v3 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

2016-07-07 Thread Andrew Jones
On Mon, Jul 04, 2016 at 09:06:16AM +0200, Igor Mammedov wrote: > On Fri, 1 Jul 2016 14:30:12 +0200 > Andrew Jones wrote: > > On Fri, Jul 01, 2016 at 01:50:24PM +0200, Igor Mammedov wrote: > > > --- a/hw/arm/virt-acpi-build.c > > > +++ b/hw/arm/virt-acpi-build.c > > > @@ -426,11 +426,9 @@ build_sra

Re: [Qemu-devel] [PATCH v3] translate-all: Bugfix for user-mode self-modifying code in 2 page long TB

2016-07-07 Thread Sergey Fedorov
On 07/07/16 11:33, Stanislav Shmarov wrote: > In user-mode emulation Translation Block can consist of 2 guest pages. > In that case QEMU also mprotects 2 host pages that are dedicated for > guest memory, containing instructions. QEMU detects self-modifying code > with SEGFAULT signal processing. >

[Qemu-devel] [PATCH] disas: avoid including everything in headers compiled from C++

2016-07-07 Thread Paolo Bonzini
disas/arm-a64.cc is careful to include only the bare minimum that it needs---qemu/osdep.h and disas/bfd.h. Unfortunately, disas/bfd.h then includes qemu-common.h, which brings in qemu/option.h and from there we get the kitchen sink. This causes problems because for example QEMU's atomic macros co

[Qemu-devel] [PATCH v3 00/11] block: Accept node-name in all node level QMP commands

2016-07-07 Thread Kevin Wolf
As stated in the RFC I sent two weeks ago: * Node level commands: We need to complete the conversion that makes commands accept node names instead of BlockBackend names. In some places we intentionally allow only BlockBackends because we don't know if the command works in other p

[Qemu-devel] [PATCH v3 02/11] block: Accept node-name for block-commit

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-commit to accept a node-name without lifting the restriction that we're operating at a root node. As libvirt makes use of the DeviceNotFound error class, we m

[Qemu-devel] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-stream to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the G

[Qemu-devel] [PATCH v3 03/11] block: Accept node-name for blockdev-backup

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an in

[Qemu-devel] [PATCH v3 07/11] block: Accept node-name for change-backing-file

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts change-backing-file to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command return

[Qemu-devel] [PATCH v3 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the co

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Paolo Bonzini
> I've worried that if I only *call* these interfaces to set the MSR, then > the next (independent) use of the same interfaces would clear the MSR > through the INIT-SIPI-SIPI. That would have forced me to modify the > protocol / PPI implementations so that any use of them would reprogram > the MS

[Qemu-devel] [PATCH v3 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-snapshot-delete-internal-sync to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name,

[Qemu-devel] [PATCH v3 08/11] block: Accept node-name for drive-backup

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an inval

[Qemu-devel] [PATCH v3 04/11] block: Accept node-name for blockdev-mirror

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf --- blockdev.c | 10

Re: [Qemu-devel] [PATCH] block/iscsi: precache the allocation status of a target

2016-07-07 Thread Paolo Bonzini
On 07/07/2016 13:40, Peter Lieven wrote: >>> >> This can take a long time and the disks may not even be ever used. I >> don't think it's a good idea. > > Sure, the target might stay unused, but why do you suspect its slow? I don't suspect it's slow; it's just that it can be O(size of disk), an

[Qemu-devel] [PATCH v3 09/11] block: Accept node-name for drive-mirror

2016-07-07 Thread Kevin Wolf
In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the G

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-07-07 Thread Dmitry Osipenko
On 07.07.2016 13:53, Peter Maydell wrote: > On 4 July 2016 at 10:55, Peter Maydell wrote: >> On 1 July 2016 at 18:49, Dmitry Osipenko wrote: >>> On 01.07.2016 19:36, Peter Maydell wrote: On 30 June 2016 at 20:01, Dmitry Osipenko wrote: > On 30.06.2016 18:02, Peter Maydell wrote: >>

[Qemu-devel] [PATCH v3 11/11] nbd-server: Allow node name for nbd-server-add

2016-07-07 Thread Kevin Wolf
There is no reason why an NBD server couldn't be started for any node, even if it's not on the top level. This converts nbd-server-add to accept a node-name. Note that there is a semantic difference between using a BlockBackend name and the node name of its root: In the former case, the NBD server

[Qemu-devel] [PATCH v3 10/11] nbd-server: Use a separate BlockBackend

2016-07-07 Thread Kevin Wolf
The builtin NBD server uses its own BlockBackend now instead of reusing the monitor/guest device one. This means that it has its own writethrough setting now. The builtin NBD server always uses writeback caching now regardless of whether the guest device has WCE enabled. qemu-nbd respects the cach

Re: [Qemu-devel] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migration_id() for PowerPC CPUs

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 10:57:28 +1000 David Gibson wrote: > On Wed, Jul 06, 2016 at 07:51:01PM +0530, Bharata B Rao wrote: > > On Wed, Jul 06, 2016 at 02:01:14PM +0200, Igor Mammedov wrote: > > > On Wed, 6 Jul 2016 14:29:19 +0530 > > > Bharata B Rao wrote: > > > > > > > cpu_index is used as mi

Re: [Qemu-devel] [PATCH 0/3] fs/9p: fix setattr/getattr issues with open files

2016-07-07 Thread Dominique Martinet
Hi Greg, Greg Kurz wrote on Mon, Jul 04, 2016 at 05:08:49PM +0200: > On Mon, 4 Jul 2016 16:16:55 +0200 > Dominique Martinet wrote: > > > I *think* this introduces a race somewhere, I'm getting errors like: > > cat: f.05: No such file or directory > > cat: f.14: No such file or directory > > cat:

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Laszlo Ersek
On 07/07/16 14:12, Paolo Bonzini wrote: > >> I've worried that if I only *call* these interfaces to set the MSR, then >> the next (independent) use of the same interfaces would clear the MSR >> through the INIT-SIPI-SIPI. That would have forced me to modify the >> protocol / PPI implementations so

Re: [Qemu-devel] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID

2016-07-07 Thread Kevin Wolf
Am 05.07.2016 um 16:28 hat Alberto Garcia geschrieben: > Hi all, > > block jobs are currently identified by the name of the block backend > of the BDS where the job was started. > > The problem with this is that you cannot have block jobs on nodes > where there is no such name. > > This series t

Re: [Qemu-devel] [PATCH v8 14/16] net: Complete qapi-fication of netdev_add

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > We finally have all the required pieces for doing a type-safe > representation of netdev_add as a flat union, where the > discriminator 'type' now selects which additional members may > appear in the "arguments" JSON object sent over QMP, and exposes > those types through int

Re: [Qemu-devel] [PATCH] m25p80: Fix QIOR/DIOR handling for Winbond

2016-07-07 Thread Cédric Le Goater
Hello Marcin, On 07/06/2016 02:43 PM, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > Winbond also support continuous read mode, but as an opposite for other > flash type read mode clock cycles are included to dummy cycles number. > This path add proper handling of read mode byt

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Alberto Garcia
On Thu 07 Jul 2016 02:11:27 PM CEST, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > block-stream to accept a node-name without lifting the restriction that > we're operating at a root node

Re: [Qemu-devel] [PATCH] disas: avoid including everything in headers compiled from C++

2016-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > disas/arm-a64.cc is careful to include only the bare minimum that > it needs---qemu/osdep.h and disas/bfd.h. Unfortunately, disas/bfd.h > then includes qemu-common.h, which brings in qemu/option.h and from > there we get the kitchen sink. > > This causes problems because

Re: [Qemu-devel] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL

2016-07-07 Thread Paolo Bonzini
On 07/07/2016 14:44, Laszlo Ersek wrote: > Regarding MTRRs... that's a bit messy. PlatformPei only progams the > MTRRs only on the BSP. For the normal boot path, this is no problem, > because when EFI_MP_SERVICES_PROTOCOL starts up (in CpuDxe), the MTRR > settings are broad-cast to all APs. It is

[Qemu-devel] [PATCH] timer.h: fix inconsistency between comment and function prototype

2016-07-07 Thread Cao jin
Signed-off-by: Cao jin --- include/qemu/timer.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 41e8325..7fea97f 100644 --- a/include/qemu/timer.h +++ b/include/qemu/timer.h @@ -431,6 +431,7 @@ void timer_ini

Re: [Qemu-devel] [PATCH 0/3] fs/9p: fix setattr/getattr issues with open files

2016-07-07 Thread Greg Kurz
On Thu, 7 Jul 2016 14:35:40 +0200 Dominique Martinet wrote: > Hi Greg, > Hi Dominique, > Greg Kurz wrote on Mon, Jul 04, 2016 at 05:08:49PM +0200: > > On Mon, 4 Jul 2016 16:16:55 +0200 > > Dominique Martinet wrote: > > > > > I *think* this introduces a race somewhere, I'm getting errors li

Re: [Qemu-devel] [PATCH] m25p80: Fix QIOR/DIOR handling for Winbond

2016-07-07 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: Cédric Le Goater [mailto:c...@kaod.org] > Sent: Thursday, July 07, 2016 2:57 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > ; qemu-devel@nongnu.org > Cc: crosthwaitepe...@gmail.com; rfsw-patc...@mlist.nokia.com; > peter.mayd...@linaro.org; c...@fr.ibm.com

Re: [Qemu-devel] [PATCH for-2.7 v8 00/16] qapi netdev_add introspection (post-introspection cleanups subset F)

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > It's time to expose QMP 'netdev_add' through introspection, and > to add boxed commands/events so that we can drastically reduce > the number of C parameters needed to implement a command that > matches a large QAPI type. > > Prerequistes: > Markus' qapi-next branch (includin

[Qemu-devel] [PULL 0/6] target-arm queue

2016-07-07 Thread Peter Maydell
t repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20160707 for you to fetch changes up to 66542f639927bd1420db38a969d5fa8ad1c89ae1: i.MX: split the GPT timer implementation into per SOC definitions (2016-07-07

[Qemu-devel] [PULL 3/6] aux: fix break that wanted to break two levels out

2016-07-07 Thread Peter Maydell
From: Paolo Bonzini The last "ret = AUX_I2C_NACK;" is dead, because it is always overridden by AUX_I2C_ACK. What really the code wants is to jump out of the switch statement, and a "return" will not cut it because it would omit a debug printf. Change the logic so that we can break out of the wh

[Qemu-devel] [PULL 5/6] hw/block/m25p80: fix resource leak

2016-07-07 Thread Peter Maydell
From: Shannon Zhao These two are spot by Coverity 1357232 and 1357233. Signed-off-by: Shannon Zhao Message-id: 1467684998-12076-1-git-send-email-zhaoshengl...@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/block/m25p80.c | 6 -- 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL 4/6] aux: Rename aux.[ch] to auxbus.[ch] for the benefit of Windows

2016-07-07 Thread Peter Maydell
On Windows 'aux.*' is a reserved name and cannot be used for filenames; see https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247(v=vs.85).aspx This prevents cloning the QEMU git repo on Windows: C:\Java\sources\kvm> git clone https://github.com/qemu/qemu.git Cloning into 'qemu'...

[Qemu-devel] [PULL 1/6] target-arm/arm-semi.c: In SYS_HEAPINFO use correct type for 'limit'

2016-07-07 Thread Peter Maydell
In commit f5666418c4 most of the SYS_HEAPINFO implementation was fixed to use target_ulong rather than uint32_t, but the 'limit' variable was not changed. Reported-by: Laurent Desnogues Reviewed-by: Laurent Desnogues Signed-off-by: Peter Maydell Message-id: 1467650942-28706-1-git-send-email-pet

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-07-07 Thread Mark Cave-Ayland
Great news! AFAICT it's just convention that the first disk slice is used, and I've also proposed a patch for OpenBIOS to include this in the boot search path in future, hopefully in time for 2.7. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH v2 1/6] tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock'

2016-07-07 Thread Sergey Fedorov
I was not sure if the language I used in the source code comments is 100% correct. So it would be fine if someone could check if it is easy to understand ;) Thanks, Sergey On 05/07/16 19:18, Alex Bennée wrote: > From: Sergey Fedorov > > First, ensure atomicity of CPU's 'tb_jmp_cache' access by:

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migration_id() for PowerPC CPUs

2016-07-07 Thread Mark Cave-Ayland
On 07/07/16 02:00, David Gibson wrote: > On Wed, Jul 06, 2016 at 02:29:19PM +0530, Bharata B Rao wrote: >> cpu_index is used as migration_id by default. For machine type versions >> that set use-migration-id property, cpu_dt_it is returned. >> >> Signed-off-by: Bharata B Rao > > This seems ceonc

[Qemu-devel] [PULL 2/6] xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo

2016-07-07 Thread Peter Maydell
From: Paolo Bonzini xlnx_dp_aux_push_tx_fifo takes an immediate uint8_t and a buffer length, which must be 1 because that is how many uint8_t's fit in a uint8_t. Sure enough, that is what xlnx_dp_write passes to it, but the function is just weird. Therefore, make xlnx_dp_aux_push_tx_fifo look li

[Qemu-devel] [PULL 6/6] i.MX: split the GPT timer implementation into per SOC definitions

2016-07-07 Thread Peter Maydell
From: Jean-Christophe Dubois In various Freescale SOCs, the GPT timers can be configured to select its input clock. Depending on the SOC the set of available input clocks may vary. The actual single GPT definition was no good enough and because of it booting the sabrelite board with a i.MX6DL d

Re: [Qemu-devel] [PATCH v2 2/6] tcg: set up tb->page_addr before insertion

2016-07-07 Thread Sergey Fedorov
On 05/07/16 19:18, Alex Bennée wrote: > This ensures that if we find the TB on the slow path that tb->page_addr > is correctly set before being tested. > > Signed-off-by: Alex Bennée Reveiwed-by: Sergey Fedorov > --- > translate-all.c | 8 > 1 file changed, 4 insertions(+), 4 deletion

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Kevin Wolf
Am 07.07.2016 um 14:59 hat Alberto Garcia geschrieben: > On Thu 07 Jul 2016 02:11:27 PM CEST, Kevin Wolf wrote: > > In order to remove the necessity to use BlockBackend names in the > > external API, we want to allow node-names everywhere. This converts > > block-stream to accept a node-name withou

Re: [Qemu-devel] [PATCH v2 3/6] tcg: cpu-exec: remove tb_lock from the hot-path

2016-07-07 Thread Sergey Fedorov
On 05/07/16 19:18, Alex Bennée wrote: > Lock contention in the hot path of moving between existing patched > TranslationBlocks is the main drag in multithreaded performance. This > patch pushes the tb_lock() usage down to the two places that really need > it: > > - code generation (tb_gen_code) >

Re: [Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > This saves a lot of memory compared to a statically-sized array, > or at least 24kb could be considered a lot on an Atari ST. > > It also makes the code more similar to QmpOutputVisitor. > > Signed-off-by: Paolo Bonzini Does not apply to current master. Please rebase.

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/07/2016 10:19, Markus Armbruster wrote: >> Actually, you should either prove that untrusted input still cannot make >> us allocated unbounded amounts of memory, or bring the limit right back. > > This is not where untrusted input can be blocked from allocating > unbo

Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x

2016-07-07 Thread Gerd Hoffmann
Hi, > I'd further suggest that you might want to explicitly say that GTK-2.0 > support is deprecated, and set a date for its removal, as its days are > clearly numbered, and it'd let us take advantage of more advanced GTK > 3.0 features without piling on yet more #ifdefs. Good idea. > Perhaps

[Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Gerd Hoffmann
This patch drops gtk version detection. gtk3 is used unless you explicitly ask for gtk2. Additionally configure prints an error message in case it finds gtk2 but not gtk3. Old behavior: only gtk3 installed -- use gtk3 both gtk2+3 installed -- use gtk2 only gtk2 installed -- use g

Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2016 at 04:27:40PM +0200, Gerd Hoffmann wrote: > This patch drops gtk version detection. gtk3 is used unless you > explicitly ask for gtk2. Additionally configure prints an error > message in case it finds gtk2 but not gtk3. > > Old behavior: > only gtk3 installed -- use gt

Re: [Qemu-devel] [PATCH v2] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Eric Blake
On 07/07/2016 05:27 AM, Paolo Bonzini wrote: > This saves a lot of memory compared to a statically-sized array, > or at least 24kb could be considered a lot on an Atari ST. > > It also makes the code more similar to QmpOutputVisitor. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: leave

Re: [Qemu-devel] [PATCH] qapi: change QmpInputVisitor to QSLIST

2016-07-07 Thread Eric Blake
On 07/07/2016 02:42 AM, Markus Armbruster wrote: > Needs a rebase. The other one, too. > > Paolo Bonzini writes: > >> This saves a lot of memory compared to a statically-sized array. >> >> Signed-off-by: Paolo Bonzini > > Saves 24KiB - d*32B. That's "a lot" for an Atari ST or something, or i

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Alberto Garcia
On Thu 07 Jul 2016 04:17:21 PM CEST, Kevin Wolf wrote: >> > +static BlockDriverState *qmp_get_root_bs(const char *name, Error **errp) >> > +{ >> > +BlockDriverState *bs; >> > + >> > +bs = bdrv_lookup_bs(name, name, errp); >> > +if (bs == NULL) { >> > +return NULL; >> > +} >>

[Qemu-devel] [PATCH] linux-user: Handle short lengths in host_to_target_sockaddr()

2016-07-07 Thread Peter Maydell
If userspace specifies a short buffer for a target sockaddr, the kernel will only copy in as much as it has space for (or none at all if the length is zero) -- see the kernel move_addr_to_user() function. Mimic this in QEMU's host_to_target_sockaddr() routine. In particular, this fixes a segfault

Re: [Qemu-devel] [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream

2016-07-07 Thread Kevin Wolf
Am 07.07.2016 um 16:39 hat Alberto Garcia geschrieben: > On Thu 07 Jul 2016 04:17:21 PM CEST, Kevin Wolf wrote: > >> > +static BlockDriverState *qmp_get_root_bs(const char *name, Error **errp) > >> > +{ > >> > +BlockDriverState *bs; > >> > + > >> > +bs = bdrv_lookup_bs(name, name, errp); >

[Qemu-devel] [RFC PATCH v2 1/5] cpu, target-ppc: Move cpu_vmstate_[un]register calls to cpu_common_[un]realize

2016-07-07 Thread Bharata B Rao
Move vmstate_register() call to cpu_common_realize(). Introduce cpu_common_unrealize() and move vmstate_unregister() to it. Change those archs that implement their own CPU unrealize routine to mandatorily call CPUClass::unrealize(). TODO: Decide if we indeed want to move vmstate_[un]register() c

[Qemu-devel] [RFC PATCH v2 0/5] sPAPR: Fix migration when CPUs are removed in random order

2016-07-07 Thread Bharata B Rao
device_add/del based CPU hotplug and unplug support is upstream for sPAPR PowerPC and is under development for x86. Both of these will support CPU device removal in random order (and not necessarily in LIFO order). Random order removal will result in holes in cpu_index range which causes migration

[Qemu-devel] [RFC PATCH v2 2/5] cpu: Introduce CPUState::stable_cpu_id

2016-07-07 Thread Bharata B Rao
Add CPUState::stable_cpu_id and use that as instance_id in vmstate_register() call. Introduce has-stable_cpu_id property that allows target machines to optionally switch to using stable_cpu_id instead of cpu_index. This will help allow successful migration in cases where holes are introduced in cp

[Qemu-devel] [RFC PATCH v2 3/5] spapr: Set stable_cpu_id for threads of CPU cores

2016-07-07 Thread Bharata B Rao
Conditonally set stable_cpu_id for CPU threads that are created as part of spapr CPU cores. The use of stable_cpu_id is enabled for pseries-2.7 onwards. Signed-off-by: Bharata B Rao --- hw/ppc/spapr_cpu_core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/ppc/spapr_cpu_core.c b/h

Re: [Qemu-devel] [RfC PATCH] gtk: switch to gtk3 by default, depricate gtk2.

2016-07-07 Thread Peter Maydell
On 7 July 2016 at 15:27, Gerd Hoffmann wrote: > This patch drops gtk version detection. gtk3 is used unless you > explicitly ask for gtk2. Additionally configure prints an error > message in case it finds gtk2 but not gtk3. > > Old behavior: > only gtk3 installed -- use gtk3 > both gtk2+

  1   2   3   >