[Qemu-devel] [PATCH v3 21/32] blockdev: Separate parallels probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the parallels probe from the parallels driver. The parallels probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c

[Qemu-devel] [PATCH v3 28/32] blockdev: Separate vmdk probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vmdk probe from the vmdk driver. The vmdk probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1 + bl

[Qemu-devel] [PATCH v3 29/32] blockdev: Separate vpc probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vpc probe from the vpc driver. The vpc probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1 + block

[Qemu-devel] [PATCH v3 25/32] blockdev: Separate raw probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the raw probe from the raw driver. The raw probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1 + block/

[Qemu-devel] [PATCH v3 27/32] blockdev: Separate vhdx probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vhdx probe from the vhdx driver. The vhdx probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1 + bl

Re: [Qemu-devel] [PATCH v1 1/2] crypto: use glib as fallback for hash algorithm

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 09:03:26AM -0600, Eric Blake wrote: > On 07/05/2016 04:49 AM, Daniel P. Berrange wrote: > > GLib >= 2.16 provides GChecksum API which is good enough > > for md5, sha1, sha256 and sha512. Use this as a final > > fallback if neither nettle or gcrypt are available. This > > let

[Qemu-devel] [PATCH v3 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers

2016-07-05 Thread Colin Lord
This commit finalizes the separation of the block driver and probe function by removing the .bdrv_probe field from all BlockDrivers. Probing is now accomplished solely by iterating over the array of probe function pointers in the format_probes array. Signed-off-by: Colin Lord --- block.c

[Qemu-devel] [PATCH v3 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver

2016-07-05 Thread Colin Lord
This commit finalizes the separation of the BlockDriver from its device probing function. Now the accesses to these functions in block.c occur through the protocol_probes array, and each function returns a score and protocol name with which to find the corresponding driver. Signed-off-by: Colin Lo

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Laszlo Ersek (Red Hat)
I don't think this difference is intentional. I think we're seeing an interplay between the following two commits: * http://git.qemu.org/?p=qemu.git;a=commitdiff;h=4d2ffa08b601b * http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7685ee6abcb93 Referring to the message of the second commit above, the

Re: [Qemu-devel] [PATCH v4 07/11] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:28, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'blockdev-backup' > and 'drive-backup', allowing the user to specify the ID of the block > job to be created. > > The HMP 'drive_backup' command remains unchanged. > > Signed-off-by: Alberto Garcia

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Tom Hanson
So, in the original minimal command line above (#3) is the transport/bus missing? Or is mmio implied? Or? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594239 Title: After adding more scsi disks

[Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls

2016-07-05 Thread Peter Maydell
The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly defined as IOC_W rather than IOC_R, which meant we weren't correctly copying the information back from the kernel to the guest. The loop_info64 structure definition was also missing a member and using the wrong type for several 32-bi

[Qemu-devel] [PULL v2 03/30] hw/pci: delay bus_master_enable_region initialization

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Skip bus_master_enable region creation on PCI device init in order to be sure the IOMMU device (if present) would be created in advance. Add this memory region at machine_done time. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S.

Re: [Qemu-devel] failed kpartx on qemu-aarch64-static

2016-07-05 Thread Peter Maydell
On 5 July 2016 at 02:33, Chanho Park wrote: > Anyway, there is one more problem. > When I tries to detach the loop device using "kpartx -d" command, it was not > detached correctly. Below is my test sequence. Thanks. This turns out to be due to bugs in our handling of another couple of ioctls (wh

Re: [Qemu-devel] [PATCH v4 08/11] stream: Add 'job-id' parameter to 'block-stream'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:28, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'block-stream', > allowing the user to specify the ID of the block job to be created. > > The HMP 'block_stream' command remains unchanged. > > Signed-off-by: Alberto Garcia > Reviewed-by: Kevin Wol

[Qemu-devel] [PULL v2 04/30] q35: allow dynamic sysbus

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Allow adding sysbus devices with -device on Q35. At first Q35 will support only intel-iommu to be added this way, however the command line will support all sysbus devices. Mark with 'cannot_instantiate_with_device_add_yet' the ones causing immediate problems (e.g. crashes

Re: [Qemu-devel] [PATCH 2/2] cpu-exec: remove tb_lock from the hot-path

2016-07-05 Thread Sergey Fedorov
On 05/07/16 16:42, Paolo Bonzini wrote: > > On 05/07/2016 15:11, Alex Bennée wrote: >> Paolo Bonzini writes: >> >>> On 05/07/2016 13:14, Alex Bennée wrote: /* * Patch the last TB with a jump to the current TB. * * Modification of the TB has to be protected with tb_lock which

[Qemu-devel] [PULL v2 00/30] pc, pci, virtio: new features, cleanups, fixes

2016-07-05 Thread Michael S. Tsirkin
The following changes since commit e2c8f9e44e07d8210049abaa6042ec3c956f1dd4: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-07-04 10:49:17 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upst

Re: [Qemu-devel] [PATCH v4 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:28, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'blockdev-mirror' > and 'drive-mirror', allowing the user to specify the ID of the block > job to be created. > > The HMP 'drive_mirror' command remains unchanged. > > Signed-off-by: Alberto Garcia

[Qemu-devel] [PULL v2 07/30] piix: Set I440FXState member pci_info.w32 in one place

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range pci_info.w32 records the location of the PCI hole. It's initialized to empty when QOM zeroes I440FXState. That's a fine value for a still unknown PCI hole. i440fx_init() sets pci_info.w32.begin = below_4g_mem_size. Changes the PCI hole from empty to [below_4g_mem

Re: [Qemu-devel] [PATCH v4 09/11] commit: Add 'job-id' parameter to 'block-commit'

2016-07-05 Thread Max Reitz
On 05.07.2016 16:29, Alberto Garcia wrote: > This patch adds a new optional 'job-id' parameter to 'block-commit', > allowing the user to specify the ID of the block job to be created. > > Signed-off-by: Alberto Garcia > Reviewed-by: Kevin Wolf > --- > block/commit.c| 7 --- > b

[Qemu-devel] [PULL v2 09/30] virtio: revert host notifiers to old semantics

2016-07-05 Thread Michael S. Tsirkin
From: Cornelia Huck The host notifier rework tried both to unify host notifiers across transports and plug a possible hole during host notifier re-assignment. Unfortunately, this meant a change in semantics that breaks vhost and iSCSI+dataplane. As the minimal fix, keep the common host notifier

[Qemu-devel] [PULL v2 12/30] pci_register_bar: cleanup

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin place relevant code tegother, make the code easier to read Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini --- hw/pci/pci.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[Qemu-devel] [PULL v2 01/30] xen: fix ram init regression

2016-07-05 Thread Michael S. Tsirkin
From: Gerd Hoffmann Commit "8156d48 pc: allow raising low memory via max-ram-below-4g option" causes a regression on xen, because it uses a different memory split. This patch initializes max-ram-below-4g to zero and leaves the initialization to the memory initialization functions. That way they

[Qemu-devel] [PULL v2 05/30] hw/iommu: enable iommu with -device

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Use the standard '-device intel-iommu' to create the IOMMU device. The legacy '-machine,iommu=on' can still be used. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 16 hw/i3

[Qemu-devel] [PULL v2 15/30] range: Replace internal representation of Range

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range represents a range as follows. Member @start is the inclusive lower bound, member @end is the exclusive upper bound. Zero @end is special: if @start is also zero, the range is empty, else @end is to be interpreted as 2^64. No other empty ranges may occur. The ran

[Qemu-devel] [PULL v2 13/30] log: Clean up misuse of Range for -dfilter

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Range encodes an integer interval [a,b] as { begin = a, end = b + 1 }, where a \in [0,2^64-1] and b \in [1,2^64]. Thus, zero end is to be interpreted as 2^64. The implementation of -dfilter (commit 3514552) uses Range differently: it encodes [a,b] as { begin = a, end = b

[Qemu-devel] [PULL v2 02/30] hw/ppc: realize the PCI root bus as part of mac99 init

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Mac99's PCI root bus is not part of a host bridge, realize it manually. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/ppc/mac_newworld.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/mac_newworld.c

[Qemu-devel] [PULL v2 06/30] machine: remove iommu property

2016-07-05 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Since iommu devices can be created with '-device' there is no need to keep iommu as machine and mch property. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci-host/q35.h | 1 - hw/core/machine.c

[Qemu-devel] [PULL v2 17/30] tests: acpi: add CPU hotplug testcase

2016-07-05 Thread Michael S. Tsirkin
From: Igor Mammedov Test with: -smp 2,cores=3,sockets=2,maxcpus=6 to capture sparse APIC ID values that default AMD CPU has in above configuration. Signed-off-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/bi

[Qemu-devel] [PULL v2 23/30] megasas: change msi/msix property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Hannes

[Qemu-devel] [PULL v2 10/30] virtio: set low features early on load

2016-07-05 Thread Michael S. Tsirkin
virtio migrates the low 32 feature bits twice, the first copy is there for compatibility but ever since 019a3edbb25f1571e876f8af1ce4c55412939e5d: ("virtio: make features 64bit wide") it's ignored on load. This is wrong since virtio_net_load tests self announcement and guest offloads before the seco

[Qemu-devel] [PULL v2 08/30] pc: Eliminate PcPciInfo

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster PcPciInfo has two (ill-named) members: Range w32 is the PCI hole, and w64 is the PCI64 hole. Three users: * I440FXState and MCHPCIState have a member PcPciInfo pci_info, but only pci_info.w32 is actually used. This is confusing. Replace by Range pci_hole. * acpi_b

[Qemu-devel] [PULL v2 26/30] megasas: remove unnecessary megasas_use_msi()

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin megasas overwrites user configuration when msi_init fail to flag internal msi state, which is unsuitable. megasa_use_msi() is unnecessary, we can call msi_uninit() directly when unrealize, even no need to call msi_enabled() first. cc: Hannes Reinecke cc: Paolo Bonzini cc: Markus

[Qemu-devel] [PULL v2 19/30] change pvscsi_init_msi() type to void

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Nobody use its return value, so change the type to void. cc: Michael S. Tsirkin cc: Paolo Bonzini cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin Reviewed-by: Michael S

[Qemu-devel] [PULL v2 11/30] Revert "virtio-net: unbreak self announcement and guest offloads after migration"

2016-07-05 Thread Michael S. Tsirkin
This reverts commit 1f8828ef573c83365b4a87a776daf8bcef1caa21. Cc: qemu-sta...@nongnu.org Reported-by: Robin Geuze Tested-by: Robin Geuze Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 40 +--- 1 file changed, 17 insertions(+), 23 deletions(-) d

[Qemu-devel] [PULL v2 22/30] mptsas: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/s

[Qemu-devel] [PULL v2 24/30] pci bridge dev: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/pci_bridge_dev.c | 13 +++-- 1 f

[Qemu-devel] [PULL v2 14/30] range: Eliminate direct Range member access

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Users of struct Range mess liberally with its members, which makes refactoring hard. Create a set of methods, and convert all users to call them instead of accessing members. The methods have carefully worded contracts, and use assertions to check them. Signed-off-by: M

[Qemu-devel] [PULL 07/43] iscsi: Advertise realistic limits to block layer

2016-07-05 Thread Kevin Wolf
From: Eric Blake The function sector_limits_lun2qemu() returns a value in units of the block layer's 512-byte sector, and can be as large as 0x4000, which is much larger than the block layer's inherent limit of BDRV_REQUEST_MAX_SECTORS. The block layer already handles '0' as a synonym to the

[Qemu-devel] [PULL 00/43] Block layer patches

2016-07-05 Thread Kevin Wolf
The following changes since commit 60a0f1af07d685c88f4ffa09370da5bd7514823e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20160704-1' into staging (2016-07-05 12:46:18 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you t

[Qemu-devel] [PULL v2 29/30] e1000e: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal big flag E1000E_USE_MSI is unnecessary, also is the helper function: e1000e_init_msi(), e1000e_cleanup_msi(), so, remove them all. cc: Dmitry Fleytman cc: Jason Wang cc: Markus Armbruster cc: Marcel Apfelbaum cc: Michael S. Tsirkin Signed-off-by: Cao jin Reviewed-by

[Qemu-devel] [PULL v2 16/30] log: Permit -dfilter 0..0xffffffffffffffff

2016-07-05 Thread Michael S. Tsirkin
From: Markus Armbruster Works fine since the previous commit fixed the underlying range data type. Of course it filters out nothing, but so does 0..1,2..0x, and we don't bother rejecting that either. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Michael

[Qemu-devel] [PULL 17/43] block: Wording tweaks to write zeroes limits

2016-07-05 Thread Kevin Wolf
From: Eric Blake Improve the documentation of the write zeroes limits, to mention additional constraints that drivers should observe. Worth squashing into commit cf081fca, if that hadn't been pushed already :) Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- in

[Qemu-devel] [PULL 04/43] block: Fix harmless off-by-one in bdrv_aligned_preadv()

2016-07-05 Thread Kevin Wolf
From: Eric Blake If the amount of data to read ends exactly on the total size of the bs, then we were wasting time creating a local qiov to read the data in preparation for what would normally be appending zeroes beyond the end, even though this corner case has nothing further to do. Signed-off-

[Qemu-devel] [PULL v2 30/30] vmw_pvscsi: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal flag msi_used is uncesessary, msi_uninit() could be called directly, msi_enabled() is enough to check device msi state. But for migration compatibility, keep the field in structure. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster cc: Marcel Apfelbaum cc: M

[Qemu-devel] [PULL 08/43] scsi: Advertise limits by blocksize, not 512

2016-07-05 Thread Kevin Wolf
From: Eric Blake s->blocksize may be larger than 512, in which case our tweaks to max_xfer_len and opt_xfer_len must be scaled appropriately. CC: qemu-sta...@nongnu.org Reported-by: Fam Zheng Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- hw/scsi/scsi-generic

Re: [Qemu-devel] [PATCH v3 06/32] blockdev: Move luks probe to its own file

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 11:24:06AM -0400, Colin Lord wrote: > Isolates the luks probe function as part of the modularization process. > > Signed-off-by: Colin Lord > --- > block/Makefile.objs | 2 +- > block/crypto.c| 21 + > block/probe/luks.c| 23

[Qemu-devel] [PULL v2 20/30] usb xhci: change msi/msix property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From bit to enum OnOffAuto cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/usb/hcd-xhci.c | 16 +

[Qemu-devel] [PULL 13/43] raw-win32: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. In this case, raw_probe_alignment() already

[Qemu-devel] [PULL 03/43] block: Document supported flags during bdrv_aligned_preadv()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We don't pass any flags on to drivers to handle. Tighten an assert to explain why we pass 0 to bdrv_driver_preadv(), and add some comments on things to be aware of if we want to turn on per-BDS BDRV_REQ_FUA support during reads in the future. Also, document that we may want to

[Qemu-devel] [PULL 15/43] block: Set default request_alignment during bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Now that all drivers have been updated to su

[Qemu-devel] [PULL v2 18/30] tests: add APIC.cphp and DSDT.cphp blobs

2016-07-05 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cphp | Bin 0 -> 6435 bytes tests/acpi-test-data/q35/APIC.cphp | Bin 0 -> 160 bytes te

[Qemu-devel] [PULL v2 21/30] intel-hda: change msi property type

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin >From uint32 to enum OnOffAuto. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/audio/intel-hda.c | 9 +--

[Qemu-devel] [PULL 26/43] vvfat: Use BdrvChild for s->qcow

2016-07-05 Thread Kevin Wolf
vvfat uses a temporary qcow file to cache written data in read-write mode. In order to do things properly, this should show up in the BDS graph and I/O should go through BdrvChild like for every other node. Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi --- block/vvfat.c | 66 +

[Qemu-devel] [PULL 20/43] block: Split bdrv_merge_limits() from bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake During bdrv_merge_limits(), we were computing initial limits based on another BDS in two places. At first glance, the two computations are not identical (one is doing straight copying, the other is doing merging towards or away from zero) - but when you realize that the first ro

[Qemu-devel] [PULL 09/43] block: Give nonzero result to blk_get_max_transfer_length()

2016-07-05 Thread Kevin Wolf
From: Eric Blake Making all callers special-case 0 as unlimited is awkward, and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given our current block layer API limits. In the case of scsi, this means that we now always advertise a limit to the guest, even in cases where the underlying la

[Qemu-devel] [PULL v2 25/30] pci: Convert msi_init() to Error and fix callers to check it

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don't handle the failure, it might happen: when user want msi on, but he doesn

[Qemu-devel] [PULL 28/43] vhdx: Some more BlockBackend use in vhdx_create()

2016-07-05 Thread Kevin Wolf
This does some easy conversions from bdrv_* to blk_* functions in vhdx_create(). We should avoid bypassing the BlockBackend layer whenever possible. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/vhdx.c | 41 + 1 fil

[Qemu-devel] [PULL 21/43] block: Move request_alignment into BlockLimit

2016-07-05 Thread Kevin Wolf
From: Eric Blake It makes more sense to have ALL block size limit constraints in the same struct. Improve the documentation while at it. Simplify a couple of conditionals, now that we have audited and documented that request_alignment is always non-zero. Signed-off-by: Eric Blake Reviewed-by:

[Qemu-devel] [PULL 14/43] block: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Add a .bdrv_refresh_limits() to all four of

[Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin internal flag msi_in_use in unnecessary, msi_uninit() could be called directly, and msi_enabled() is enough to check device msi state. cc: Markus Armbruster cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Michael S. Tsirkin Reviewed-by: Markus Armbruster Signed-off-by: Cao jin Re

[Qemu-devel] [PULL 30/43] block: Convert bdrv_co_writev() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/crypto.c| 2 +- block/io.c| 6 +++--- block/parallels.c | 2 +- block/qcow.c | 2 +- block/vhdx.c | 2 +- include/block/block.h | 4 ++-- 6 files changed, 9 insertions(

[Qemu-devel] [PULL 25/43] block/qdev: Fix NULL access when using BB twice

2016-07-05 Thread Kevin Wolf
BlockBackend has only a single pointer to its guest device, so it makes sure that only a single guest device is attached to it. device-add returns an error if you try to attach a second device to a BB. In order to make the error message nicer, -device that manually connects to a if=none block devic

[Qemu-devel] [PULL 18/43] block: Switch discard length bounds to byte-based

2016-07-05 Thread Kevin Wolf
From: Eric Blake Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_discard and discard_alignment. Rename them, using 'pdiscard' as an aid to track which remaining discard interfaces need conversion, and so that the compiler will h

[Qemu-devel] [PULL v2 28/30] vmxnet3: remove unnecessary internal msi state flag

2016-07-05 Thread Michael S. Tsirkin
From: Cao jin Internal flag msi_used is unnecessary, it has the same effect as msi_enabled(). msi_uninit() could be called directly without risk. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster cc: Marcel Apfelbaum cc: Michael S. Tsirkin Reviewed-by: Markus Armbruster Signed-o

[Qemu-devel] [PULL 33/43] block: Convert bdrv_co_do_readv/writev to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/block/io.c b/block/io.c index e929521..d8b3c96 100644 --- a/block/io.c +++ b/block/io.c @@ -33,7 +33,7 @@

[Qemu-devel] [PULL 27/43] blkreplay: Convert to byte-based I/O

2016-07-05 Thread Kevin Wolf
The blkreplay driver only forwards the requests it gets, so converting it to byte granularity is trivial. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkreplay.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/

Re: [Qemu-devel] [PATCH v3 04/32] blockdev: Move bochs probe into separate file

2016-07-05 Thread Daniel P. Berrange
On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote: > This puts the bochs probe function into its own separate file as part of > the process of modularizing block drivers. Having the probe functions > separate from the rest of the driver allows us to probe without having > to potentially un

[Qemu-devel] [PULL 32/43] block: Convert bdrv_aio_writev() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-- block/io.c| 6 +++--- block/qed-table.c | 2 +- block/qed.c | 6 +++--- block/quorum.c| 4 ++-- include/block/block.h |

[Qemu-devel] [PULL 34/43] block: Move bdrv_commit() to block/commit.c

2016-07-05 Thread Kevin Wolf
No code changes, just moved from one file to another. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Acked-by: Stefan Hajnoczi --- block.c | 110 --- block/Makefile.objs | 3 +- block/commit.c | 111 +

[Qemu-devel] [PULL 24/43] block: fix return code for partial write for Linux AIO

2016-07-05 Thread Kevin Wolf
From: "Denis V. Lunev" Partial write most likely means that there is not space rather than "something wrong happens". Thus it would be more natural to return ENOSPC rather than EINVAL. The problem actually happens with NBD server, which has reported EINVAL rather then ENOSPC on the first error u

[Qemu-devel] [PULL 01/43] qemu-img: fix failed autotests

2016-07-05 Thread Kevin Wolf
From: "Denis V. Lunev" There are 9 iotests failed on Ubuntu 15.10 at the moment. The problem is that options parsing in qemu-img is broken by the following commit: commit 10985131e337a0c52c5bd1e191fd7867a6ff8d02 Author: Denis V. Lunev Date: Fri Jun 17 17:44:13 2016 +0300 qemu-i

[Qemu-devel] [PULL 19/43] block: Drop raw_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake The raw block driver was blindly copying all limits from bs->file, even though: 1. the main bdrv_refresh_limits() already does this for many of the limits, and 2. blindly copying from the children can weaken any stricter limits that were already inherited from the backing chain d

[Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Laszlo Ersek (Red Hat)
I'll try to come up with a patch, if for nothing more than illustration. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594239 Title: After adding more scsi disks for Aarch64 virtual machine, start

[Qemu-devel] [PULL 40/43] block: Convert bdrv_pwrite_zeroes() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/block-backend.c | 5 + block/io.c | 9 + block/parallels.c | 2 +- block/qcow2-cluster.c | 2 +- block/qcow2.c | 4 ++-- include/b

[Qemu-devel] [PULL 23/43] block: Use bool as appropriate for BDS members

2016-07-05 Thread Kevin Wolf
From: Eric Blake Using int for values that are only used as booleans is confusing. While at it, rearrange a couple of members so that all the bools are contiguous. Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 22 +++---

[Qemu-devel] [PULL 02/43] block: Tighter assertions on bdrv_aligned_pwritev()

2016-07-05 Thread Kevin Wolf
From: Eric Blake For symmetry with bdrv_aligned_preadv(), assert that the caller really has aligned things properly. This requires adding an align parameter, which is used now only in the new asserts, but will come in handy in a later patch that adds auto-fragmentation to the max transfer size, s

Re: [Qemu-devel] [PATCH 2/2] cpu-exec: remove tb_lock from the hot-path

2016-07-05 Thread Alex Bennée
Sergey Fedorov writes: > On 05/07/16 16:42, Paolo Bonzini wrote: >> >> On 05/07/2016 15:11, Alex Bennée wrote: >>> Paolo Bonzini writes: >>> On 05/07/2016 13:14, Alex Bennée wrote: > /* > * Patch the last TB with a jump to the current TB. > * > * Modification of the TB h

Re: [Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Tom Hanson
What would a device path look like for an MMIO backend? On Jul 5, 2016 9:35 AM, "Laszlo Ersek (Red Hat)" wrote: > I don't think this difference is intentional. I think we're seeing an > interplay between the following two commits: > > * http://git.qemu.org/?p=qemu.git;a=commitdiff;h=4d2ffa08b601b

[Qemu-devel] [PULL 31/43] block: Convert bdrv_aio_readv() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/blkdebug.c | 2 +- block/blkverify.c | 4 ++-- block/io.c| 6 +++--- block/qed-table.c | 2 +- block/qed.c | 6 +++--- block/quorum.c| 4 ++-- include/block/block.h |

[Qemu-devel] [PULL 05/43] nbd: Allow larger requests

2016-07-05 Thread Kevin Wolf
From: Eric Blake The NBD layer was breaking up request at a limit of 2040 sectors (just under 1M) to cater to old qemu-nbd. But the server limit was raised to 32M in commit 2d8214885 to match the kernel, more than three years ago; and the upstream NBD Protocol is proposing documentation that with

[Qemu-devel] [PULL 35/43] block: Use BlockBackend for I/O in bdrv_commit()

2016-07-05 Thread Kevin Wolf
Just like block jobs, the HMP commit command should use its own BlockBackend for doing I/O on BlockDriverStates. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/commit.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions

Re: [Qemu-devel] [PATCH v4 10/11] qemu-img: Set the ID of the block job in img_commit()

2016-07-05 Thread Max Reitz
On 05.07.2016 16:29, Alberto Garcia wrote: > img_commit() creates a block job without an ID. This is no longer > allowed now that we require it to be unique and well-formed. We were > solving this by having a fallback in block_job_create(), but now that > we extended the API of commit_active_start(

[Qemu-devel] [PULL 06/43] nbd: Advertise realistic limits to block layer

2016-07-05 Thread Kevin Wolf
From: Eric Blake We were basing the advertisement of maximum discard and transfer length off of UINT32_MAX, but since the rest of the block layer has signed int limits on a transaction, nothing could ever reach that maximum, and we risk overflowing an int once things are converted to byte-based r

[Qemu-devel] [PULL 12/43] qcow2: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric Blake Reviewed-by: Kevi

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-07-05 Thread Denis V. Lunev
On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qem

[Qemu-devel] [PULL 41/43] block: Convert bdrv_prwv_co() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/io.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/block/io.c b/block/io.c index 4e6e1c4..f702efc 100644 --- a/block/io.c +++ b/block/io.c @

[Qemu-devel] [PULL 10/43] blkdebug: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Note that when the user does not provide "al

Re: [Qemu-devel] [Bug 1594239] Re: After adding more scsi disks for Aarch64 virtual machine, start the VM and got Qemu Error

2016-07-05 Thread Peter Maydell
On 5 July 2016 at 16:20, Tom Hanson wrote: > So, in the original minimal command line above (#3) is the transport/bus > missing? Or is mmio implied? Or? The virt board creates a collection of virtio-mmio transports, so if you create just a backend on the command line (via "-device virtio-scsi-de

[Qemu-devel] [PULL 43/43] block/qcow2: Don't use cpu_to_*w()

2016-07-05 Thread Kevin Wolf
From: Peter Maydell Don't use the cpu_to_*w() functions, which we are trying to deprecate. Instead either just use cpu_to_*() to do the byteswap, or use st*_be_p() if we need to do the store somewhere other than to a variable that's already the correct type. Signed-off-by: Peter Maydell Message

[Qemu-devel] [PULL 11/43] iscsi: Set request_alignment during .bdrv_refresh_limits()

2016-07-05 Thread Kevin Wolf
From: Eric Blake We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. Signed-off-by: Eric Blake Reviewed-by: Kevi

[Qemu-devel] [Bug 1599214] [NEW] virtlogd: qemu 2.6.0 doesn't log boot message

2016-07-05 Thread Markus Zoeller (markus_z)
Public bug reported: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) che

[Qemu-devel] [PULL 16/43] block: Switch transfer length bounds to byte-based

2016-07-05 Thread Kevin Wolf
From: Eric Blake Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_transfer_length and opt_transfer_length. Rename them (dropping the _length suffix) so that the compiler will help us catch the change in semantics across any rebas

Re: [Qemu-devel] [PATCH] linux-user: Correct type for LOOP_GET_STATUS{, 64} ioctls

2016-07-05 Thread Laurent Vivier
Le 05/07/2016 à 17:36, Peter Maydell a écrit : > The LOOP_GET_STATUS and LOOP_GET_STATUS64 ioctls were incorrectly > defined as IOC_W rather than IOC_R, which meant we weren't > correctly copying the information back from the kernel to the guest. > The loop_info64 structure definition was also mi

Re: [Qemu-devel] [PULL v2 00/30] pc, pci, virtio: new features, cleanups, fixes

2016-07-05 Thread Peter Maydell
On 5 July 2016 at 16:46, Michael S. Tsirkin wrote: > The following changes since commit e2c8f9e44e07d8210049abaa6042ec3c956f1dd4: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2016-07-04 10:49:17 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PULL 22/43] block: Fix error message style

2016-07-05 Thread Kevin Wolf
From: Eric Blake error_setg() is not supposed to be used for multi-sentence messages; tweak the message to append a hint instead. Signed-off-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/raw-posix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [PATCH v2 4/6] tcg: cpu-exec: factor out TB patching code

2016-07-05 Thread Alex Bennée
This is going to be useful in the next patch when rolling up the locking on the slow path into the TB patching. Signed-off-by: Alex Bennée --- cpu-exec.c | 59 +-- 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/cpu-exec.c b

[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message

2016-07-05 Thread Daniel Berrange
** Changed in: qemu Assignee: (unassigned) => Daniel Berrange (berrange) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in Q

[Qemu-devel] [PULL 29/43] block: Convert bdrv_co_readv() to BdrvChild

2016-07-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Acked-by: Stefan Hajnoczi --- block/crypto.c| 2 +- block/io.c| 8 block/parallels.c | 2 +- block/qcow.c | 5 ++--- block/raw_bsd.c | 2 +- block/vhdx.c | 2 +- include/block/block.h | 4 +

<    1   2   3   4   5   >