Re: [Qemu-devel] Executed Host Instructions

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 02:13, Ayaz Akram wrote: > Hi all ! > I hope you wouldn't mind a quick clarification regarding this question . If > I do not take into account the exceptions and keep on adding number of > translated instructions inside a TB (found through -d out_asm) for each time > TB is seen

Re: [Qemu-devel] [PATCH 10/13] 9pfs: Wrap in vmstate

2016-06-30 Thread Greg Kurz
On Tue, 21 Jun 2016 20:14:04 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- Reviewed-by: Greg Kurz > hw/9pfs/virtio-9p-device.c | 1

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-06-30 Thread Jike Song
On 06/29/2016 09:51 PM, Xiao Guangrong wrote: > On 06/21/2016 12:31 AM, Kirti Wankhede wrote: >> +mutex_unlock(&parent_devices.list_lock); >> +return parent; >> +} >> + >> +static int mdev_device_create_ops(struct mdev_device *mdev, char >> *mdev_params) >> +{ >> +struct parent_device

[Qemu-devel] [PULL 6/7] qapi: Simplify use of range.h

2016-06-30 Thread Markus Armbruster
From: Eric Blake Calling our function g_list_insert_sorted_merged is a misnomer, since we are NOT writing a glib function. Furthermore, we are making every caller pass the same comparator function of range_merge(): any caller that would try otherwise would break in weird ways since our internal

[Qemu-devel] [PULL 4/7] qapi: Fix crash on missing alternate member of QAPI struct

2016-06-30 Thread Markus Armbruster
From: Eric Blake If a QAPI struct has a mandatory alternate member which is not present on input, the input visitor reports an error for the missing alternate without setting the discriminator, but the cleanup code for the struct still tries to use the dealloc visitor to clean up the alternate.

[Qemu-devel] [PULL 1/7] json-streamer: Don't leak tokens on incomplete parse

2016-06-30 Thread Markus Armbruster
From: Eric Blake Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the allocated data within eac

[Qemu-devel] [PULL 2/7] qobject: Correct JSON lexer grammar comments

2016-06-30 Thread Markus Armbruster
From: Eric Blake Fix the regex comments describing what we parse as JSON. No change to the lexer itself, just to the comments: - The "" and '' string construction was missing alternation between different escape sequences - The construction for numbers forgot to handle optional leading '-' - The

[Qemu-devel] [PULL 3/7] checkpatch: There is no qemu_strtod()

2016-06-30 Thread Markus Armbruster
From: Eric Blake Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironical

[Qemu-devel] [PULL 7/7] qapi: Fix memleak in string visitors on int lists

2016-06-30 Thread Markus Armbruster
From: Eric Blake Commit 7f8f9ef1 introduced the ability to store a list of integers as a sorted list of ranges, but when merging ranges, it leaks one or more ranges. It was also using range_get_last() incorrectly within range_compare() (a range is a start/end pair, but range_get_last() is for st

[Qemu-devel] [PULL 5/7] range: Create range.c for code that should not be inline

2016-06-30 Thread Markus Armbruster
From: Eric Blake g_list_insert_sorted_merged() is rather large to be an inline function; move it to its own file. range_merge() and ranges_can_merge() can likewise move, as they are only used internally. Also, it becomes obvious that the condition within range_merge() is already satisfied by it

[Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-06-30 Thread Peter Lieven
Suggested-by: Peter Maydell Signed-off-by: Peter Lieven --- include/sysemu/os-posix.h | 24 util/oslib-posix.c| 22 ++ 2 files changed, 46 insertions(+) diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h index 9c7dfdf..34d102c

[Qemu-devel] [PATCH 2/6] coroutine: add a macro for the coroutine stack size

2016-06-30 Thread Peter Lieven
Signed-off-by: Peter Lieven --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_

[Qemu-devel] [PULL 0/7] QAPI patches 2016-06-30

2016-06-30 Thread Markus Armbruster
The following changes since commit 3e904d6ade7f363c64b3c54c5d14372b8a9e6892: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160628' into staging (2016-06-29 10:43:08 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2016-06-30

Re: [Qemu-devel] [RFC 00/28] s390x CPU models: exposing features

2016-06-30 Thread David Hildenbrand
Are there any further comments, especially on patches 23-25, introducing new QOM interfaces? Also, if anybody is planning to look into this, please speak up :) Otherwise it might make sense to put this onto the next KVM call agenda. David > This is our second attempt to implement CPU models fo

Re: [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

2016-06-30 Thread Igor Mammedov
On Wed, 29 Jun 2016 22:50:06 +0200 Greg Kurz wrote: > This series is a sequel to the discussion on a patch from Ben's powernv > patchset: > > http://patchwork.ozlabs.org/patch/597153/ > > Indeed, since the DT is a machine abstraction, it should definitely sit > under hw/ppc and not in t

[Qemu-devel] [PATCH 4/6] coroutine-sigaltstack: use helper for allocating stack memory

2016-06-30 Thread Peter Lieven
Signed-off-by: Peter Lieven --- util/coroutine-sigaltstack.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 9c2854c..ccf4861 100644 --- a/util/coroutine-sigaltstack.c +++ b/util/coroutine-sigaltstack.c @

[Qemu-devel] [PATCH 0/6] coroutine: mmap stack memory and stack size

2016-06-30 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

[Qemu-devel] [PATCH 6/6] coroutine: reduce stack size to 64kB

2016-06-30 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. Signed-off-by: Peter

[Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Vladimir Sementsov-Ogievskiy
After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent and is no longer needed. It is better to free bitmap table and corresponding clusters from the image immediately after loading the bitmap than free them w

[Qemu-devel] [PATCH 3/6] coroutine-ucontext: use helper for allocating stack memory

2016-06-30 Thread Peter Lieven
Signed-off-by: Peter Lieven --- util/coroutine-ucontext.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..b7dea8c 100644 --- a/util/coroutine-ucontext.c +++ b/util/coroutine-ucontext.c @@ -82,7 +82,6

[Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Liang Li
After live migration, 'guest-stats' can't get the expected memory status in the guest. This issue is caused by commit 4eae2a657d. The value of 's->stats_vq_elem' will be NULL after live migration, and the check in the function 'balloon_stats_poll_cb()' will prevent the 'virtio_notify()' from execut

[Qemu-devel] [PATCH 5/6] oslib-posix: add a configure switch to debug stack usage

2016-06-30 Thread Peter Lieven
this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven --- configure | 15 +++ util/oslib-posix.c | 35 ++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/configure

Re: [Qemu-devel] [PATCH v6 0/1] Introduce "xen-load-devices-state"

2016-06-30 Thread Changlong Xie
Would any migration maintainer pick this patch or give some comments? Thanks -Xie On 06/03/2016 05:58 PM, Changlong Xie wrote: Changelog v6: 1. Fix channel open flag v5: 1. Introduce qio channel since 8925839f v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a

Re: [Qemu-devel] [PATCH 1/3] linux-user: fd_trans_*_data() returns the length

2016-06-30 Thread Riku Voipio
Hi, I've merged the netlink patches the que[1]. I'm waiting to see if we'll get some fixup patches to the fairly substantial changes linux-user has seen in this cycle. Riku [1] https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream On Tue, Jun 28, 2016 a

[Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4902ca5..e9df5ac 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Ladi Prosek
On Thu, Jun 30, 2016 at 9:31 AM, Liang Li wrote: > After live migration, 'guest-stats' can't get the expected memory > status in the guest. This issue is caused by commit 4eae2a657d. > The value of 's->stats_vq_elem' will be NULL after live migration, > and the check in the function 'balloon_stats

[Qemu-devel] [PATCH] spec/parallels: fix a mistake

2016-06-30 Thread Vladimir Sementsov-Ogievskiy
We have only one flag for now - Empty Image flag. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/parallels.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/parallels.txt b/docs/specs/parallels.txt index b4fe229..e9271eb 100644 --- a/docs/specs/parall

[Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

2016-06-30 Thread Igor Mammedov
27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore added -id suffix to property names but forgot to fix example in qmp-commands.hx Fix example to have 'core-id' instead of 'core' to match current code Signed-off-by: Igor Mammedov --- qmp-commands.hx | 4 ++-- 1 fil

[Qemu-devel] [PATCH 1/1] spec/parallels: fix a mistake

2016-06-30 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy We have only one flag for now - Empty Image flag. The patch fixes unused bits specification and marks bit 1 as usused. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi --- docs/specs/parallels.txt | 2 +- 1 file

Re: [Qemu-devel] [PATCH v2 8/8] ppc/xics: Split ICS into ics-base and ics class

2016-06-30 Thread Cédric Le Goater
On 06/28/2016 09:05 PM, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > The existing implementation remains same and ics-base is introduced. The > type name "ics" is retained, and all the related functions renamed as > ics_simple_* > > This will allow different implementations for th

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Fam Zheng
On Thu, 06/30 16:01, Changlong Xie wrote: > Otherwise, we could never trigger assert(!bitmap->successor) > > Signed-off-by: Changlong Xie > --- > block/dirty-bitmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index 4902ca5..e9df5ac 100

Re: [Qemu-devel] [RFC v3 0/6] SDM Interface

2016-06-30 Thread Christian Pinto
Ping... are there any comments? Thanks, Christian On Fri, Jun 17, 2016 at 5:54 PM, Christian Pinto < c.pi...@virtualopensystems.com> wrote: > This patch series introduces a new device to QEMU, the SDM (Signal > Distribution > Module), > intended to route inter-processor signals intra and inter

Re: [Qemu-devel] [PATCH 3/3] VFIO Type1 IOMMU: Add support for mediated devices

2016-06-30 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, June 29, 2016 10:46 AM > > On Tue, 28 Jun 2016 18:32:44 +0530 > Kirti Wankhede wrote: > > > On 6/22/2016 9:16 AM, Alex Williamson wrote: > > > On Mon, 20 Jun 2016 22:01:48 +0530 > > > Kirti Wankhede wrote: > > > > >

Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

2016-06-30 Thread Peter Krempa
On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote: > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct > CPUCore > added -id suffix to property names but forgot to fix example in > qmp-commands.hx > > Fix example to have 'core-id' instead of 'core' to match curre

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Li, Liang Z
> On Thu, Jun 30, 2016 at 9:31 AM, Liang Li wrote: > > After live migration, 'guest-stats' can't get the expected memory > > status in the guest. This issue is caused by commit 4eae2a657d. > > The value of 's->stats_vq_elem' will be NULL after live migration, and > > the check in the function 'bal

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.

[Qemu-devel] About the interaction between KVM and QEMU

2016-06-30 Thread Yunqiang Gao
Hi,alls, in Qemu 1.2.5,we can interact with kvm by kvm_vm_ioctl(),kvm_ioctl() and so on.But in Qemu1.5.3,I find that the function kvm_vm_ioctl() is not called. Anybody knows how to interect between Qemu and KVM in Qemu1.5.3 or higher version? Maybe you just tell me a function. Thanks

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-30 Thread Zhen Ning Lim
** Changed in: qemu Status: Fix Committed => Fix Released ** Changed in: qemu Status: Fix Released => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1588328 Title: Qemu 2.6 Solari

Re: [Qemu-devel] [virtio-dev] Re: [RFC v3 0/6] SDM Interface

2016-06-30 Thread Stefan Hajnoczi
On Thu, Jun 30, 2016 at 10:26:56AM +0200, Christian Pinto wrote: > Ping... > > are there any comments? Hi Christian, I will be away until Thursday and focussed on the virtio device specification first. Maybe others can give you feedback on the QEMU patches in the meantime. Stefan signature.as

Re: [Qemu-devel] [PATCH 1/1] spec/parallels: fix a mistake

2016-06-30 Thread Stefan Hajnoczi
On Thu, Jun 30, 2016 at 11:19:30AM +0300, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > We have only one flag for now - Empty Image flag. The patch fixes unused > bits specification and marks bit 1 as usused. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Deni

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for QEMU soft freeze

2016-06-30 Thread Peter Maydell
On 29 June 2016 at 16:23, Paolo Bonzini wrote: > The following changes since commit 1f3aba377d2a531453f018c70de2580a142c74c9: > > pc: acpi: drop intermediate PCMachineState.node_cpu (2016-06-24 08:34:47 > +0300) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PATCH] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Cornelia Huck
On Wed, 29 Jun 2016 14:23:42 +0200 Marc-André Lureau wrote: > Hi > > On Wed, Jun 29, 2016 at 2:17 PM, Cornelia Huck > wrote: > > When setting up host notifiers, virtio_bus_set_host_notifier() > > simply switches the handler. This will only work, however, if > > the ioeventfd has already been s

Re: [Qemu-devel] [PATCH] balloon: Fix failure of updating guest memory status

2016-06-30 Thread Ladi Prosek
On Thu, Jun 30, 2016 at 10:39 AM, Li, Liang Z wrote: >> On Thu, Jun 30, 2016 at 9:31 AM, Liang Li wrote: >> > After live migration, 'guest-stats' can't get the expected memory >> > status in the guest. This issue is caused by commit 4eae2a657d. >> > The value of 's->stats_vq_elem' will be NULL af

Re: [Qemu-devel] [PATCH v2] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-30 Thread Denis V. Lunev
On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: After loading bitmap from image and setting IN_USE flag in it's header, corresponding data (bitmap table and data clusters) becomes inconsistent and is no longer needed. It is better to free bitmap table and corresponding clusters from t

Re: [Qemu-devel] About the interaction between KVM and QEMU

2016-06-30 Thread Paolo Bonzini
On 30/06/2016 10:42, Yunqiang Gao wrote: > Hi,alls, > > in Qemu 1.2.5,we can interact with kvm by kvm_vm_ioctl(),kvm_ioctl() and so > on.But in Qemu1.5.3,I find that the function kvm_vm_ioctl() is not called. > > Anybody knows how to interect between Qemu and KVM in Qemu1.5.3 or higher > versio

Re: [Qemu-devel] [PATCH v2 22/23] vhost-user: wait until backend init is completed

2016-06-30 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Jun 24, 2016 at 03:51:09PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The chardev waits for an initial connection before starting qemu, > > vhost-user wants the backend negotiation to be completed. vhost-user is > > sta

Re: [Qemu-devel] [RFC v3 19/19] cpu-exec: remove tb_lock from the hot-path

2016-06-30 Thread Sergey Fedorov
On 29/06/16 19:08, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 29/06/16 17:47, Alex Bennée wrote: >>> Sergey Fedorov writes: >>> On 03/06/16 23:40, Alex Bennée wrote: (snip) > > static inline TranslationBlock *tb_find_fast(CPUState *cpu, > -

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-30 Thread Sergey Fedorov
On 29/06/16 19:17, Alex Bennée wrote: > So I think there is a deadlock we can get with the async work: > > (gdb) thread apply all bt > > Thread 11 (Thread 0x7ffefeca7700 (LWP 2912)): > #0 pthread_cond_wait@@GLIBC_2.3.2 () at > ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 > #1 0x

Re: [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

2016-06-30 Thread Greg Kurz
On Thu, 30 Jun 2016 09:34:35 +0200 Igor Mammedov wrote: > On Wed, 29 Jun 2016 22:50:06 +0200 > Greg Kurz wrote: > > > This series is a sequel to the discussion on a patch from Ben's powernv > > patchset: > > > > http://patchwork.ozlabs.org/patch/597153/ > > > > Indeed, since the DT is

[Qemu-devel] [PATCH] net: limit allocation in nc_sendv_compat

2016-06-30 Thread Peter Lieven
we only need to allocate enough memory to hold the packet. This might be less than NET_BUFSIZE. Additionally fail early if the packet is larger than NET_BUFSIZE. Signed-off-by: Peter Lieven --- net/net.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/

Re: [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191

2016-06-30 Thread Peter Maydell
On 29 June 2016 at 11:04, Gerd Hoffmann wrote: > Hi, > > Here comes the ipxe update for 2.7, rebasing the ipxe module to latest > master and also adding boot roms for e1000e and vmxnet3. > > please pull, > Gerd > > The following changes since commit c7288767523f6510cf557707d3eb5e78e519b90d: >

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-30 Thread Zhen Ning Lim
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1588328 Title: Qemu 2.6 Solaris 9 Sparc Segmentation Fault Status in QEMU: Fix Committed Bu

Re: [Qemu-devel] [PATCH v2 8/8] ppc/xics: Split ICS into ics-base and ics class

2016-06-30 Thread Nikunj A Dadhania
Cédric Le Goater writes: > On 06/28/2016 09:05 PM, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> The existing implementation remains same and ics-base is introduced. The >> type name "ics" is retained, and all the related functions renamed as >> ics_simple_* >> >> This will al

[Qemu-devel] [PATCH] vnc-enc-tight: use thread local storage for palette

2016-06-30 Thread Peter Lieven
currently the color counting palette is allocated from heap, used and destroyed for each single subrect. Use a static palette per thread for this purpose and avoid the malloc and free for each update. Signed-off-by: Peter Lieven --- ui/vnc-enc-tight.c | 23 --- 1 file changed

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-30 Thread Alex Bennée
Sergey Fedorov writes: > On 29/06/16 19:17, Alex Bennée wrote: >> So I think there is a deadlock we can get with the async work: >> >> (gdb) thread apply all bt >> >> Thread 11 (Thread 0x7ffefeca7700 (LWP 2912)): >> #0 pthread_cond_wait@@GLIBC_2.3.2 () at >> ../sysdeps/unix/sysv/linux/x86_64/p

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-30 Thread Sergey Fedorov
On 30/06/16 13:32, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 29/06/16 19:17, Alex Bennée wrote: >>> So I think there is a deadlock we can get with the async work: >>> >>> (gdb) thread apply all bt >>> >>> Thread 11 (Thread 0x7ffefeca7700 (LWP 2912)): >>> #0 pthread_cond_wait@@GLIBC_2.3.

Re: [Qemu-devel] [PATCH v2 1/2] trace: [linux-user] Commandline arguments to control tracing

2016-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2016 at 12:45:23PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Wed, Jun 22, 2016 at 12:04:35PM +0200, Lluís Vilanova wrote: > >> @@ -4047,6 +4064,12 @@ static const struct qemu_argument arg_table[] = { > >> "", "log system calls"}, > >> {"seed",

Re: [Qemu-devel] [PATCH 1/3] linux-user: fd_trans_*_data() returns the length

2016-06-30 Thread Laurent Vivier
Le 30/06/2016 à 09:52, Riku Voipio a écrit : > > Hi, > > I've merged the netlink patches the que[1]. I'm waiting to see if > we'll get some fixup patches to the fairly substantial changes > linux-user has seen in this cycle. Perfect. Thanks, Laurent > > Riku > > [1] > https://git.linaro.o

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix 64K pages support in full emulation

2016-06-30 Thread Anton Blanchard
Hi, > From: Benjamin Herrenschmidt > > We were always advertising only 4K & 16M. Additionally the code wasn't > properly matching the page size with the PTE content, which meant we > could potentially hit an incorrect PTE if the guest used multiple > sizes. > > Finally, honor the CPU capabiliti

Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source

2016-06-30 Thread Sascha Silbe
Dear Markus, Markus Armbruster writes: > --- > tests/header-test-template.c | 16 [...] Thanks, that helped, I get a bit further now. Is "make header-check" supposed to work on a host that doesn't have all optional dependencies installed? It fails for me because some OpenGL re

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-30 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > Something somewhere in qemu/ kernel/ firmware is already reading the number > > of physical bits to determine PCI mapping; if I do: > > > > ./x86_64-softmmu/qemu-system-x86_64 -m 4096,slots=16,maxmem=128T > > No, it's not the physbits. Yo

[Qemu-devel] [PATCH V4] block/iscsi: allow caching of the allocation map

2016-06-30 Thread Peter Lieven
until now the allocation map was used only as a hint if a cluster is allocated or not. If a block was not allocated (or Qemu had no info about the allocation status) a get_block_status call was issued to check the allocation status and possibly avoid a subsequent read of unallocated sectors. If a b

[Qemu-devel] [PATCH] block/iscsi: precache the allocation status of a target

2016-06-30 Thread Peter Lieven
this fills up the allocationmap at iscsi_open. This helps to reduce the number of get_block_status requests during runtime significantly. Signed-off-by: Peter Lieven --- block/iscsi.c | 16 1 file changed, 16 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0cdced

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix 64K pages support in full emulation

2016-06-30 Thread Benjamin Herrenschmidt
On Thu, 2016-06-30 at 20:56 +1000, Anton Blanchard wrote: > Hi, > > > From: Benjamin Herrenschmidt > > > > We were always advertising only 4K & 16M. Additionally the code wasn't > > properly matching the page size with the PTE content, which meant we > > could potentially hit an incorrect PTE if

Re: [Qemu-devel] [PATCH] MAINTAINERS: update email address for Greg Kurz

2016-06-30 Thread Cédric Le Goater
On 06/17/2016 04:35 PM, Greg Kurz wrote: > While here, also add a section for the tree I use for 9p. > > Signed-off-by: Greg Kurz I confirm this is Greg ! Acked-by: Cédric Le Goater C. > --- > MAINTAINERS |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAI

Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-06-30 Thread Cédric Le Goater
On 04/13/2016 03:15 PM, Greg Kurz wrote: > The system header doesn't exist on all host platforms. Code should > include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't > define CONFIG_IOVEC (like win32, if it is to support 9p one day). > > Signed-off-by: Greg Kurz Acked-by:

Re: [Qemu-devel] [virtio-dev] Re: [RFC v3 0/6] SDM Interface

2016-06-30 Thread Christian Pinto
Thanks a lot Stefan. Looking forward for your feedback. Christian On Thu, Jun 30, 2016 at 10:47 AM, Stefan Hajnoczi wrote: > On Thu, Jun 30, 2016 at 10:26:56AM +0200, Christian Pinto wrote: > > Ping... > > > > are there any comments? > > Hi Christian, > I will be away until Thursday and focus

Re: [Qemu-devel] [PATCH 01/13] 9p: synth: drop v9fs_ prefix

2016-06-30 Thread Cédric Le Goater
On 06/27/2016 11:41 AM, Greg Kurz wrote: > To have shorter lines and be consistent with other fs devices. > > Signed-off-by: Greg Kurz Acked-by: Cédric Le Goater > --- > hw/9pfs/9p-synth.c | 200 > ++-- > 1 file changed, 100 insertions(+), 1

[Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Cornelia Huck
When setting up host notifiers, virtio_bus_set_host_notifier() simply switches the handler. This will only work, however, if the ioeventfd has already been setup; this is true for dataplane, but not for vhost, and will completely break things if the ioeventfd is disabled for the device. Fix this b

Re: [Qemu-devel] [PATCH] MAINTAINERS: update email address for Greg Kurz

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 12:24, Cédric Le Goater wrote: > On 06/17/2016 04:35 PM, Greg Kurz wrote: >> While here, also add a section for the tree I use for 9p. >> >> Signed-off-by: Greg Kurz > > I confirm this is Greg ! > > Acked-by: Cédric Le Goater This would be more convincing if one or both of yo

Re: [Qemu-devel] [PATCH v2] virtio: Fix setting up host notifiers for vhost

2016-06-30 Thread Peter Lieven
Am 30.06.2016 um 13:52 schrieb Cornelia Huck: When setting up host notifiers, virtio_bus_set_host_notifier() simply switches the handler. This will only work, however, if the ioeventfd has already been setup; this is true for dataplane, but not for vhost, and will completely break things if the i

Re: [Qemu-devel] [PATCH] MAINTAINERS: update email address for Greg Kurz

2016-06-30 Thread Cédric Le Goater
On 06/30/2016 01:56 PM, Peter Maydell wrote: > On 30 June 2016 at 12:24, Cédric Le Goater wrote: >> On 06/17/2016 04:35 PM, Greg Kurz wrote: >>> While here, also add a section for the tree I use for 9p. >>> >>> Signed-off-by: Greg Kurz >> >> I confirm this is Greg ! >> >> Acked-by: Cédric Le Goat

Re: [Qemu-devel] [PATCH] MAINTAINERS: update email address for Greg Kurz

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 13:09, Cédric Le Goater wrote: > On 06/30/2016 01:56 PM, Peter Maydell wrote: >> On 30 June 2016 at 12:24, Cédric Le Goater wrote: >>> On 06/17/2016 04:35 PM, Greg Kurz wrote: While here, also add a section for the tree I use for 9p. Signed-off-by: Greg Kurz >>>

Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source

2016-06-30 Thread Markus Armbruster
Sascha Silbe writes: > Dear Markus, > > Markus Armbruster writes: > >> --- >> tests/header-test-template.c | 16 > [...] > > Thanks, that helped, I get a bit further now. > > Is "make header-check" supposed to work on a host that doesn't have all > optional dependencies installe

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-06-30 Thread Jason Wang
On 2016年06月29日 14:13, Zhang Chen wrote: On 06/29/2016 09:55 AM, Jason Wang wrote: On 2016年06月28日 14:33, Zhang Chen wrote: primary guest response pkt(seq=primary_seq+1,ack=client_seq+1+data_len,flag=ACK) secondary guest response pkt(seq=secondary_seq+1,ack=client_seq+1+data_len,flag=A

Re: [Qemu-devel] [PULL 0/7] QAPI patches 2016-06-30

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 08:29, Markus Armbruster wrote: > The following changes since commit 3e904d6ade7f363c64b3c54c5d14372b8a9e6892: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160628' > into staging (2016-06-29 10:43:08 +0100) > > are available in the git repository at:

[Qemu-devel] [PATCH 1/4] tests: acpi: add CPU hotplug testcase

2016-06-30 Thread Igor Mammedov
Test with: -smp 2,cores=3,sockets=2,maxcpus=6 to capture sparse APIC ID values that default AMD CPU has in above configuration. Signed-off-by: Igor Mammedov --- NOTE to maintainer: following table blobs should be added to git tree as poart of this commit after running ./tests/acpi-test-dat

[Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Igor Mammedov
fixes long standing issue where Linux kernel would assing hotplugged CPU to 1st numa node as it discards proximity for hotplugged CPUs after SRAT is parsed. Signed-off-by: Igor Mammedov --- hw/acpi/cpu.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c i

[Qemu-devel] [PATCH 4/4] tests: acpi: extend cphp testcase with numa check

2016-06-30 Thread Igor Mammedov
so it would be possible to verify _PXM generation in DSDT and SRAT tables. Signed-off-by: Igor Mammedov --- NOTE to maintainer: SRAT table is included in patch as it doesn't have any chance for conflicts compared to often changing DSDT following table blobs should be updated in git tree as part

[Qemu-devel] [PATCH 0/4] fix numa node mapping for hotplugged CPUs

2016-06-30 Thread Igor Mammedov
Series adds acpi tables tests for CPU hotplug and makes hotplugged CPUs assigned to correct numa nodes for Linux guests + extends CPU hotplug test with numa options Igor Mammedov (4): tests: acpi: add CPU hotplug testcase tests: DO NOT APPLY: add APIC.cphp and DSDT.cphp blobs acpi: provide

[Qemu-devel] [PATCH 2/4] tests: DO NOT APPLY: add APIC.cphp and DSDT.cphp blobs

2016-06-30 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cphp | Bin 0 -> 6435 bytes tests/acpi-test-data/q35/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/q35/DSDT.cphp | Bin 0 -> 9197 bytes 4 files changed, 0 insertions(+),

[Qemu-devel] REGRESSION: pcspk: convert "pit" property type from ptr to link

2016-06-30 Thread Peter Lieven
The above patch: commit 873b4d3f0571a1e415cf089a67a230ea8a12d059 Author: Efimov Vasily Date: Wed Jun 22 15:24:46 2016 +0300 pcspk: convert "pit" property type from ptr to link adds a regression (segfault). Was this patch actually tested? Cmdline: x86_64-softmmu/qemu-system-x86_64 -enabl

Re: [Qemu-devel] [PATCH] MAINTAINERS: update email address for Greg Kurz

2016-06-30 Thread Peter Maydell
On 30 June 2016 at 13:17, Greg Kurz wrote: > On Thu, 30 Jun 2016 14:09:23 +0200 > Cédric Le Goater wrote: > >> On 06/30/2016 01:56 PM, Peter Maydell wrote: >> > On 30 June 2016 at 12:24, Cédric Le Goater wrote: >> >> On 06/17/2016 04:35 PM, Greg Kurz wrote: >> >>> While here, also add a section

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-30 Thread Peter Maydell
On 20 June 2016 at 15:19, Markus Armbruster wrote: > Blue hasn't been active in the QEMU project for a long time. Drop his > last MAINTAINERS entries. > > As per Paolo's recommendation, downgrade status of "BSD user" from > Maintained to Orphan since the FreeBSD guys effectively forked it, and >

Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-06-30 Thread Michael Fritscher
> On 04/13/2016 03:15 PM, Greg Kurz wrote: >> The system header doesn't exist on all host platforms. Code >> should >> include "qemu/osdep.h" instead to avoid build breaks on plafforms that >> don't >> define CONFIG_IOVEC (like win32, if it is to support 9p one day). >> >> Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 1/4] tests: acpi: add CPU hotplug testcase

2016-06-30 Thread Marcel Apfelbaum
On 06/30/2016 03:23 PM, Igor Mammedov wrote: Test with: -smp 2,cores=3,sockets=2,maxcpus=6 to capture sparse APIC ID values that default AMD CPU has in above configuration. Signed-off-by: Igor Mammedov --- NOTE to maintainer: following table blobs should be added to git tree as poart of

Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Marcel Apfelbaum
On 06/30/2016 03:23 PM, Igor Mammedov wrote: fixes long standing issue where Linux kernel would assing hotplugged CPU to 1st numa node as it discards proximity for hotplugged CPUs after SRAT is parsed. Signed-off-by: Igor Mammedov --- hw/acpi/cpu.c | 9 + 1 file changed, 9 insertions

Re: [Qemu-devel] [PATCH 4/4] tests: acpi: extend cphp testcase with numa check

2016-06-30 Thread Marcel Apfelbaum
On 06/30/2016 03:23 PM, Igor Mammedov wrote: so it would be possible to verify _PXM generation in DSDT and SRAT tables. Signed-off-by: Igor Mammedov --- NOTE to maintainer: SRAT table is included in patch as it doesn't have any chance for conflicts compared to often changing DSDT following tab

[Qemu-devel] [PATCH RFC v3 2/5] tests: Make check-block a phony target

2016-06-30 Thread Markus Armbruster
Got lost in commit b93b63f. Signed-off-by: Markus Armbruster --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5def161..002f15f 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -

[Qemu-devel] [PATCH RFC v3 4/5] Include exec/hwaddr.h where hwaddr is used

2016-06-30 Thread Markus Armbruster
Don't bother with include/exec/memory-internal.h and include/hw/elf_ops.h, because those are somewhat special. Signed-off-by: Markus Armbruster --- hw/audio/lm4549.h | 1 + hw/cris/boot.h| 2 ++ hw/net/e1000e_core.h | 7 +++ hw/net/vmware_util

[Qemu-devel] [PATCH RFC v3 3/5] Include hw/irq.h where qemu_irq is used

2016-06-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/net/ne2000.h | 2 ++ hw/net/pcnet.h | 1 + include/hw/block/fdc.h | 1 + include/hw/char/escc.h | 2 ++ include/hw/char/pl011.h | 2 ++ include/hw/char/xilinx_uartlite.h

Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-06-30 Thread Markus Armbruster
Greg Kurz writes: > The system header doesn't exist on all host platforms. Code should > include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't > define CONFIG_IOVEC (like win32, if it is to support 9p one day). > > Signed-off-by: Greg Kurz > --- > fsdev/9p-iov-marshal.c

[Qemu-devel] [PATCH RFC v3 5/5] Add a few missing #include "qemu/queue.h"

2016-06-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- audio/audio_int.h| 2 ++ block/vhdx.h | 2 ++ hw/9pfs/9p-synth.h | 3 +-- include/hw/pci/pci_bus.h | 2 ++ 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index 9054747..38ff62e 100

Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Igor Mammedov
On Thu, 30 Jun 2016 15:48:54 +0300 Marcel Apfelbaum wrote: > On 06/30/2016 03:23 PM, Igor Mammedov wrote: > > fixes long standing issue where Linux kernel would assing > > hotplugged CPU to 1st numa node as it discards proximity > > for hotplugged CPUs after SRAT is parsed. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-30 Thread Alberto Garcia
On Wed 29 Jun 2016 07:20:55 PM CEST, Max Reitz wrote: I thought adding a new 'ID' field was simpler. The device name is still a device name (where it makes sense). The default ID is guaranteed to be valid and guaranteed not to clash with user-defined IDs. The API is (in my opini

Re: [Qemu-devel] [PATCH v2 22/23] vhost-user: wait until backend init is completed

2016-06-30 Thread Yuanhan Liu
On Thu, Jun 30, 2016 at 05:22:43AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Jun 24, 2016 at 03:51:09PM +0200, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > The chardev waits for an initial connection before starting qemu, >

[Qemu-devel] [PATCH RFC v3 0/5] Baby steps towards saner headers

2016-06-30 Thread Markus Armbruster
Some time ago, we discussed rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are needed

Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-06-30 Thread Greg Kurz
On Thu, 30 Jun 2016 14:57:58 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > The system header doesn't exist on all host platforms. Code > > should > > include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't > > define CONFIG_IOVEC (like win32, if it is to suppor

Re: [Qemu-devel] [PULL v2 00/35] Misc patches for QEMU soft freeze

2016-06-30 Thread Paolo Bonzini
On 30/06/2016 10:59, Peter Maydell wrote: > On 29 June 2016 at 16:23, Paolo Bonzini wrote: >> The following changes since commit 1f3aba377d2a531453f018c70de2580a142c74c9: >> >> pc: acpi: drop intermediate PCMachineState.node_cpu (2016-06-24 08:34:47 >> +0300) >> >> are available in the git re

Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

2016-06-30 Thread Marcel Apfelbaum
On 06/30/2016 04:01 PM, Igor Mammedov wrote: On Thu, 30 Jun 2016 15:48:54 +0300 Marcel Apfelbaum wrote: On 06/30/2016 03:23 PM, Igor Mammedov wrote: fixes long standing issue where Linux kernel would assing hotplugged CPU to 1st numa node as it discards proximity for hotplugged CPUs after SRA

  1   2   3   >