[Qemu-devel] [PATCH 0/8] pnv: more fixes to the exception model

2016-06-27 Thread Cédric Le Goater
Hello, Here are a couple more patches on the exception model and LPCR which are surrounding the pnv core patches. The first is a prereq for all the patches to apply, and it did not seem too much of a problem adding it. Cheers, C. Benjamin Herrenschmidt (8): ppc: Add a bunch of hypervisor SPRs

[Qemu-devel] [PATCH 7/8] ppc: LPCR is a HV resource

2016-06-27 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Don't allow access in guest mode Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target-ppc/translate_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_i

[Qemu-devel] [PATCH 6/8] ppc: Initial HDEC support

2016-06-27 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The current behaviour isn't completely right, as for the DEC, we don't properly re-arm when wrapping around, but I will fix this in a separate patch. Signed-off-by: Benjamin Herrenschmidt [clg: fixed checkpatch.pl errors ] Signed-off-by: Cédric Le Goater --- hw/pp

[Qemu-devel] [PATCH 4/8] ppc: Fix conditions for delivering external interrupts to a guest

2016-06-27 Thread Cédric Le Goater
From: Benjamin Herrenschmidt External interrupts can bypass the MSR_EE test if they occur in guest mode and LPES0 is clear. In that case they are directed to the hypervisor Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target-ppc/excp_helper.c | 19

[Qemu-devel] [PATCH 5/8] ppc: Enforce setting MSR:EE, IR and DR when MSR:PR is set

2016-06-27 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The architecture specifies that any instruction that sets MSR:PR will also set MSR:EE, IR and DR. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Cédric Le Goater --- target-ppc/helper_regs.h | 4 1 file changed, 4 insertions(+) diff --git a/target-ppc/

[Qemu-devel] [PATCH 8/8] ppc: Print HSRR0/HSRR1 in "info registers"

2016-06-27 Thread Cédric Le Goater
From: Benjamin Herrenschmidt They are generally useful when debugging HV mode stuff Signed-off-by: Benjamin Herrenschmidt [clg: fixed checkpatch.pl errors ] Signed-off-by: Cédric Le Goater --- target-ppc/translate.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-ppc/transla

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-27 Thread Amit Shah
On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: > Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", > 2016-06-16) changed the size of a migrated field. Split it in two > parts, and only migrate the second part in a new vmstate version. With this patch, the static che

Re: [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate

2016-06-27 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Tue) 21 Jun 2016 [20:13:54], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This series converts the outer most layer of virtio to > > use VMState macros; this is the easy bit, but I'm hoping that > > havin

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-27 Thread Paolo Bonzini
On 27/06/2016 09:20, Amit Shah wrote: > On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: >> Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", >> 2016-06-16) changed the size of a migrated field. Split it in two >> parts, and only migrate the second part in a new vmst

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-27 Thread Marc Zyngier
On 27/06/16 07:41, Andrew Jones wrote: > On Fri, Jun 24, 2016 at 06:27:20PM +0100, Peter Maydell wrote: >> On 24 June 2016 at 18:22, Andrew Jones wrote: >>> On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: KVM AArch32 is 4 CPUs per cluster: http://lxr.free-electrons.com/sou

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-27 Thread Daniel P. Berrange
On Sat, Jun 25, 2016 at 01:07:10AM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote: > > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin wrote: > > >> > Maybe what you want is a need_unlink feature. > > >> > Set it for unix sockets only, that

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-27 Thread Andrew Jones
On Mon, Jun 27, 2016 at 08:51:43AM +0100, Marc Zyngier wrote: > On 27/06/16 07:41, Andrew Jones wrote: > > On Fri, Jun 24, 2016 at 06:27:20PM +0100, Peter Maydell wrote: > >> On 24 June 2016 at 18:22, Andrew Jones wrote: > >>> On Fri, Jun 24, 2016 at 05:41:55PM +0100, Peter Maydell wrote: > K

Re: [Qemu-devel] [PATCH v2 1/1] spapr: Set compat type for CPUs of a core

2016-06-27 Thread Bharata B Rao
On Mon, Jun 27, 2016 at 04:51:34PM +1000, David Gibson wrote: > On Mon, Jun 27, 2016 at 11:49:46AM +0530, Bharata B Rao wrote: > > Compat CPU type is typically specified on -cpu cmdline option like: > > -cpu host,compat=power7 or -cpu POWER8E,compat=power7 etc. When > > compat is specified on -cpu

Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers

2016-06-27 Thread Markus Armbruster
Eric Blake writes: > On 06/24/2016 08:19 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> Reviewed-by: Peter Maydell > > Worth mentioning how you found the culprits in the commit message, so > that someone could repeat the task when backporting this patch or > dealing with fu

Re: [Qemu-devel] [RFC PATCH 5/7] block: Accept device model name for blockdev-open/close-tray

2016-06-27 Thread Kevin Wolf
Am 24.06.2016 um 22:39 hat Eric Blake geschrieben: > On 06/23/2016 08:36 AM, Kevin Wolf wrote: > > This is an example conversion of a QMP command that operates on the > > BlockBackend level to accept both the device model name (which is > > supposed to become the primary interface) and the BlockBac

Re: [Qemu-devel] [RFC 2/8] cpus: Move common code out of {async_, }run_on_cpu()

2016-06-27 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Move the code common between run_on_cpu() and async_run_on_cpu() into a > new function queue_work_on_cpu(). > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée > --- > cpus.c | 42 ++--

Re: [Qemu-devel] [PATCH 05/17] block: Convert bdrv_co_writev() to BdrvChild

2016-06-27 Thread Kevin Wolf
Am 25.06.2016 um 17:14 hat Max Reitz geschrieben: > On 21.06.2016 11:21, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > block/crypto.c| 2 +- > > block/io.c| 6 +++--- > > block/parallels.c | 2 +- > > block/qcow.c | 2 +- > > block/vhdx.c |

Re: [Qemu-devel] [PATCH v6 6/7] trace: Allow event name pattern in "info trace-events"

2016-06-27 Thread Lluís Vilanova
Eric Blake writes: > On 06/23/2016 09:21 AM, Lluís Vilanova wrote: >> Homogeinizes the command capabilities with QMP. > s/Homogeinizes/homogenizes/ >> >> Signed-off-by: Lluís Vilanova >> --- >> hmp-commands-info.hx |8 +--- >> hmp.h|1 + >> monitor.c| 31

Re: [Qemu-devel] [PATCH 05/24] vhost: change some assert() for error_report() or silent fail

2016-06-27 Thread Marc-André Lureau
Hi On Sat, Jun 25, 2016 at 12:38 AM, Michael S. Tsirkin wrote: > On Fri, Jun 24, 2016 at 03:25:30PM +0200, Marc-André Lureau wrote: >> On Thu, Jun 23, 2016 at 7:13 PM, Michael S. Tsirkin wrote: >> >> > If it's ok and we can recover, then why should we print errors? >> >> >> >> To me, the current

Re: [Qemu-devel] [RFC 4/8] linux-user: Rework exclusive operation mechanism

2016-06-27 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > A single variable 'pending_cpus' was used for both counting currently > running CPUs and for signalling the pending exclusive operation request. > > To prepare for supporting operations which requires a quiescent state, > like translation buffer

[Qemu-devel] [PATCH v7 0/7] trace: Per-vCPU tracing states

2016-06-27 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: [*-user] Add commandline arguments to control tracing". Provides per-vCPU dynamic controls of the tracing state of events with the "vcpu" property. A later series proposes an optimization where tracing code can be elided for dynamically disabled e

[Qemu-devel] [PATCH v7 5/7] trace: Conditionally trace events based on their per-vCPU state

2016-06-27 Thread Lluís Vilanova
Events with the 'vcpu' property are conditionally emitted according to their per-vCPU state. Other events are emitted normally based on their global tracing state. Note that the per-vCPU condition check applies to all tracing backends. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v7 3/7] [trivial] trace: Cosmetic changes on fast-path tracing

2016-06-27 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- trace/control-internal.h |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/trace/control-internal.h b/trace/control-internal.h index 5e0a5ab..c5f5f3d 100644 --- a/trace/control-internal.h +++ b/trace/contr

[Qemu-devel] [PATCH v7 4/7] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-27 Thread Lluís Vilanova
Each vCPU gets a 'trace_dstate' bitmap to control the per-vCPU dynamic tracing state of events with the 'vcpu' property. Signed-off-by: Lluís Vilanova --- bsd-user/main.c |1 + include/qom/cpu.h|6 + linux-user/main.c|1 + qom/cpu.c|1

[Qemu-devel] [PATCH v7 1/7] trace: Identify events with the 'vcpu' property

2016-06-27 Thread Lluís Vilanova
A new event attribute 'cpu_id' is added to have a separate ID space ('TRACE_VCPU_*') for all events with the 'vcpu' property. These are later used to identify which events are enabled on each vCPU. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c

[Qemu-devel] [PATCH v7 2/7] disas: Remove unused macro '_'

2016-06-27 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- disas/alpha.c |6 +++--- disas/arm.c |2 +- disa

[Qemu-devel] [PATCH v7 6/7] trace: Allow event name pattern in "info trace-events"

2016-06-27 Thread Lluís Vilanova
Homogenizes the command capabilities with QMP. Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake --- hmp-commands-info.hx |8 +--- hmp.h|1 + monitor.c| 31 ++- 3 files changed, 36 insertions(+), 4 deletions(-) diff --gi

[Qemu-devel] [PATCH v7 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-27 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- hmp-commands-info.hx |6 +- hmp-commands.hx |7 +- monitor.c| 17 +- qapi/trace.json | 32 +-- qmp-commands.hx | 35 +++- trace/qmp.c | 148 ++

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] blockdev: Add dynamic module loading for block drivers

2016-06-27 Thread Fam Zheng
On Fri, 06/24 11:37, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 11:04:43AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 22, 2016 at 05:35:54PM -0400, Colin Lord wrote: > > > > > > > > @@ -447,8 +466,15 @@ int get_tmp_filename(char *filename, int size) > > > static BlockDriver *find_hd

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-27 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Make CPU work core functions common between system and user-mode > emulation. User-mode does not have BQL, so flush_queued_work() is > protected by 'exclusive_lock'. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > --- > cp

Re: [Qemu-devel] [RFC 7/8] cpu-exec-common: Introduce async_safe_run_on_cpu()

2016-06-27 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > This patch is based on the ideas found in work of KONRAD Frederic [1], > Alex Bennée [2], and Alvise Rigo [3]. > > This mechanism allows to perform an operation safely in a quiescent > state. Quiescent state means: (1) no vCPU is running and (2)

Re: [Qemu-devel] [PATCH 0/2] crypto: add flexibility in TLS priority setup

2016-06-27 Thread Daniel P. Berrange
On Mon, Jun 13, 2016 at 01:13:51PM +0100, Daniel P. Berrange wrote: > This small series provides two new ways to customize the > default TLS priority QEMU uses, one at build time and one > at runtime. > > This means QEMU is no longer forced to use the lowest > common denominator crypto choices fro

Re: [Qemu-devel] [PATCH 0/2] Change QEMU crypto hash implementation

2016-06-27 Thread Daniel P. Berrange
On Wed, Jun 01, 2016 at 05:52:50PM +0100, Daniel P. Berrange wrote: > This series changes the QEMU crypto hash implementation to > use gcrypt/nettle directly instead of using gnutls abstraction. > This then lets us support several more hash algorithms that > gnutls does not expose itself. This is u

[Qemu-devel] [PATCH 00/13] 9p: reconcile virtfs with unlinked files

2016-06-27 Thread Greg Kurz
This series addresses a long standing issue in 9p, where most syscalls accessing file attributes out of file descriptor stop to work in the guest when the file gets unlinked: open("./test.txt", O_RDWR|O_CREAT, 0666) = 4 unlink("./test.txt")= 0 fstat(4, 0x3fffc22108d0)

[Qemu-devel] [PATCH 01/13] 9p: synth: drop v9fs_ prefix

2016-06-27 Thread Greg Kurz
To have shorter lines and be consistent with other fs devices. Signed-off-by: Greg Kurz --- hw/9pfs/9p-synth.c | 200 ++-- 1 file changed, 100 insertions(+), 100 deletions(-) diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c index 73c8be816bbb

[Qemu-devel] [PATCH 02/13] 9p: factour out duplicate code from local_fstat() and local_lstat()

2016-06-27 Thread Greg Kurz
This does not change functionality. Signed-off-by: Greg Kurz --- hw/9pfs/9p-local.c | 68 +++- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 3f271fcbd2c5..b363711fe2f0 100644 --- a/h

[Qemu-devel] [PATCH 04/13] 9p: getattr: use fstat if we have a fd

2016-06-27 Thread Greg Kurz
If we have an opened fd, it is better to call fstat() as the underlying file may have been unlinked and lstat() will fail. The fid_has_file() helper will be used by other file descriptor based ops. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 36 +--- 1 file cha

[Qemu-devel] [PATCH 03/13] 9p: introduce the v9fs_get_fd_fid() helper

2016-06-27 Thread Greg Kurz
This will be used by all file descriptor based ops. Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c | 12 ++-- hw/9pfs/9p-local.c | 12 ++-- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c| 13 + hw/9pfs/9p.h|2 ++ 5 files changed, 21

[Qemu-devel] [PATCH 10/13] 9p: introduce fchmod file op

2016-06-27 Thread Greg Kurz
This allows fchmod() in the guest to stay functional even if the file was unlinked. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |1 + hw/9pfs/9p-handle.c | 10 ++ hw/9pfs/9p-local.c | 21 + hw/9pfs/9p-proxy.c | 10 ++ hw/9pfs/9p-synth.c |

[Qemu-devel] [PATCH 08/13] 9p: add a fd argument to xattr helpers

2016-06-27 Thread Greg Kurz
This patch adds the plumbing to be able to use fgetxattr(), fsetxattr(), flistxattr() and fremovexattr(). It does not change any functionality. Signed-off-by: Greg Kurz --- hw/9pfs/9p-local.c | 44 +- hw/9pfs/9p-posix-acl.c | 80

[Qemu-devel] [PATCH 06/13] oslib: support futimens() if available

2016-06-27 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c |7 +-- include/sysemu/os-posix.h |1 + util/oslib-posix.c| 10 ++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c index e48e48a7145d..197c2c7efbb5 100644

[Qemu-devel] [PATCH 05/13] 9p: introduce ftruncate file op

2016-06-27 Thread Greg Kurz
This patch adds a ftruncate operation to the fsdev API. It is then used if we have an open fd, so that ftruncate() in the guest is functional even if the file was unlinked or its file permissions would cause truncate() to fail. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |1 + hw/9pfs/9

[Qemu-devel] [PATCH 07/13] 9p: introduce futimens file op

2016-06-27 Thread Greg Kurz
This allows futimens() in the guest to stay functional even if the file was unlinked. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |2 ++ hw/9pfs/9p-handle.c | 10 ++ hw/9pfs/9p-local.c | 10 ++ hw/9pfs/9p-proxy.c | 10 ++ hw/9pfs/9p-synth.c |8 ++

[Qemu-devel] [PATCH 11/13] 9p: xattr fid to reference file fid

2016-06-27 Thread Greg Kurz
The flistxattr() and fgetxattr() syscalls in the guest are implementend with XATTRWALK. In v9fs_xattrwalk(), we then create a xattr fid to hold the the file path, and retrieve the xattr from the fs backend with llistxattr() or lgetxattr(). This patch brings file descriptor support to fids with typ

[Qemu-devel] [PATCH 09/13] 9p: introduce fchown file op

2016-06-27 Thread Greg Kurz
This allows fchown() in the guest to stay functional even if the file was unlinked. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |1 + hw/9pfs/9p-handle.c | 10 ++ hw/9pfs/9p-local.c | 22 ++ hw/9pfs/9p-proxy.c | 10 ++ hw/9pfs/9p-synth.c |

[Qemu-devel] [PATCH 13/13] 9p: introduce flistxattr file op

2016-06-27 Thread Greg Kurz
This allows flistxattr() in the guest to stay functional even if the file was unlinked. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |2 ++ hw/9pfs/9p-handle.c | 10 ++ hw/9pfs/9p-local.c | 10 ++ hw/9pfs/9p-proxy.c | 10 ++ hw/9pfs/9p-synth.c |8

[Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Peter Lieven
Hi, with the above patch applied: commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa Author: Cornelia Huck Date: Fri Jun 10 11:04:12 2016 +0200 virtio-pci: convert to ioeventfd callbacks a Ubuntu 14.04 VM freezes at startup when blk-mq is set up - even if there is only one queue. Peter

[Qemu-devel] [PATCH 12/13] 9p: introduce fgetxattr file op

2016-06-27 Thread Greg Kurz
This allows fgetxattr() in the guest to stay functional even if the file was unlinked. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |2 ++ hw/9pfs/9p-handle.c | 11 +++ hw/9pfs/9p-local.c | 11 +++ hw/9pfs/9p-proxy.c | 12 hw/9pfs/9p-synth.c |9 +

Re: [Qemu-devel] [PATCH v1 10/11] ppc/xics: Add "native" XICS subclass

2016-06-27 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Thu, Jun 23, 2016 at 11:17:29PM +0530, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> This provides MMIO based ICP access as found on POWER8 >> >> Signed-off-by: Benjamin Herrenschmidt >> Signed-off-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

2016-06-27 Thread Peter Maydell
On 27 June 2016 at 07:34, Markus Armbruster wrote: > Peter Maydell writes: >> This is third-party code. We're not going to change it, so >> we should avoid scanning it rather than adding tags which >> will get lost next time we do an update to a new upstream >> version... > > I can revive v1's bl

Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers

2016-06-27 Thread Peter Maydell
On 27 June 2016 at 09:50, Markus Armbruster wrote: > To spice up things, we > also name a few of our headers just like system headers we use > elsewhere, e.g. "util.h" in net/ vs. in util/qemu-openpty.c. That would be nice to fix at some point I think, it's pretty brittle. (We had one issue rece

Re: [Qemu-devel] [PATCH v1 09/11] ppc/xics: Split ICS into ics-base and ics class

2016-06-27 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > David Gibson writes: > >> [ Unknown signature status ] >> On Thu, Jun 23, 2016 at 11:17:28PM +0530, Nikunj A Dadhania wrote: >>> From: Benjamin Herrenschmidt >>> >>> The existing implementation remains same and ics-base is introduced. >>> >>> This will allow differ

[Qemu-devel] [PATCH] target-mips: replace MIPS64R6-generic with the real I6400 CPU model

2016-06-27 Thread Leon Alrae
MIPS64R6-generic gradually gets closer to I6400 CPU, feature-wise. Rename it to make it clear which MIPS processor it is supposed to emulate. Signed-off-by: Leon Alrae --- target-mips/translate_init.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/targe

Re: [Qemu-devel] Regression: virtio-pci: convert to ioeventfd callbacks

2016-06-27 Thread Cornelia Huck
On Mon, 27 Jun 2016 11:44:47 +0200 Peter Lieven wrote: > Hi, with the above patch applied: > > commit 9f06e71a567ba5ee8b727e65a2d5347fd331d2aa > Author: Cornelia Huck > Date: Fri Jun 10 11:04:12 2016 +0200 > > virtio-pci: convert to ioeventfd callbacks > > a Ubuntu 14.04 VM freezes at

[Qemu-devel] [PATCH] slirp: Remove superfluous memset() calls from the TFTP code

2016-06-27 Thread Thomas Huth
Commit fad7fb9ccd8013ea03 ("Add IPv6 support to the TFTP code") refactored some common code for preparing the mbuf into a new function called tftp_prep_mbuf_data(). One part of this common code is to do a "memset(m->m_data, 0, m->m_size);" for the related buffer first. However, at two spots, the m

Re: [Qemu-devel] [PULL] qemu-sparc update

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 18:41, Mark Cave-Ayland wrote: > Hi Peter, > > This request just contains Artyom's fix for the Solaris 9 regression > introduced > by the previous register window changes. Please pull. > > > ATB, > > Mark. > > > The following changes since commit a01aef5d2f96c334d048f43f0d3573a

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-27 Thread Juergen Gross
On 17/06/16 13:14, Juergen Gross wrote: > The qdisk implementation is using the native xenbus protocol only in > case of no protocol specified at all. As using the explicit 32- or > 64-bit protocol is slower than the native one due to copying requests > not by memcpy but element for element, this i

Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-27 Thread Felipe Franciosi
> On 24 Jun 2016, at 23:43, Michael S. Tsirkin wrote: > > On Fri, Jun 24, 2016 at 01:17:07AM -0700, Prerna Saxena wrote: >> From: Prerna Saxena >> >> The current vhost-user protocol requires the client to send responses to >> only few commands. For the remaining commands, it is impossible for

[Qemu-devel] [PATCH] hw/ppc/spapr: Add some missing hcall function set strings

2016-06-27 Thread Thomas Huth
Add "hcall-sprg0" (for H_SET_SPRG0), "hcall-copy" (for H_PAGE_INIT) and "hcall-debug" (for H_LOGICAL_CI_LOAD/STORE) to the property "ibm,hypertas-functions" to indicate that we support these hypercalls. Signed-off-by: Thomas Huth --- hw/ppc/spapr.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-27 Thread Marc-André Lureau
Hi On Mon, Jun 27, 2016 at 12:45 PM, Felipe Franciosi wrote: > >> On 24 Jun 2016, at 23:43, Michael S. Tsirkin wrote: >> I would like this structured like this: >> >> 1. fix races by sending GET_FEATURES and waiting for it > > We can still add this first if you think it will help. But is it wort

Re: [Qemu-devel] [PULL 00/10] target-mips queue

2016-06-27 Thread Peter Maydell
On 26 June 2016 at 14:38, Leon Alrae wrote: > Hi, > > This pull request contains patches from Aleksandar which unlock > the IEEE 754-2008 support for MIPS. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit c7288767523f6510cf557707d3eb5e78e519b90

Re: [Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors

2016-06-27 Thread Paolo Bonzini
On 26/06/2016 00:15, Eric Blake wrote: > > +/* Send an error reply. > + * Return -errno to kill connection, 0 to continue negotiation. */ > +static int GCC_FMT_ATTR(4, 5) > +nbd_negotiate_send_rep_err(QIOChannel *ioc, uint32_t type, > + uint32_t opt, const char

Re: [Qemu-devel] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-06-27 Thread Paolo Bonzini
On 26/06/2016 00:15, Eric Blake wrote: > diff --git a/block/nbd.c b/block/nbd.c > index 8d57220..049d1bd 100644 > --- a/block/nbd.c > +++ b/block/nbd.c > @@ -357,6 +357,7 @@ static int nbd_co_flush(BlockDriverState *bs) > static void nbd_refresh_limits(BlockDriverState *bs, Error **errp) > { >

[Qemu-devel] [RFC PATCH] scripts: Add a script to check for bug URLs in the git log

2016-06-27 Thread Thomas Huth
Basic idea of this script is to check the git log for URLs to the QEMU bugtracker at launchpad.net and to figure out whether the related bug has been marked there as "Fix released" (i.e. closed) already. So this script can e.g. be used after each public release of QEMU to check whether there are an

Re: [Qemu-devel] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LIST

2016-06-27 Thread Paolo Bonzini
On 26/06/2016 00:15, Eric Blake wrote: > +/* Return -1 if unrecoverable error occurs > , 0 if NBD_OPT_LIST is unsupported, These two should return errp != NULL and negative errno. > 1 if iteration is done > 2 to keep looking, > and 3 if * this entry matches @want. */ These three should return

Re: [Qemu-devel] [PATCH 2/2] raw_bsd: Convert to byte-based interface

2016-06-27 Thread Paolo Bonzini
On 24/06/2016 05:58, Eric Blake wrote: > Since the raw format driver is just passing things through, we can > do byte-based read and write if the underlying protocol does > likewise. > > There's one tricky part - if we probed the image format, we document > that we restrict operations on the ini

Re: [Qemu-devel] [PATCH 1/2] nbd: Convert to byte-based interface

2016-06-27 Thread Paolo Bonzini
On 24/06/2016 05:58, Eric Blake wrote: > The NBD protocol doesn't have any notion of sectors, so it is > a fairly easy convertion to use byte-based read and write. > > Signed-off-by: Eric Blake > --- > block/nbd-client.h | 8 > include/block/nbd.h | 1 - > block/nbd-client.c | 30

Re: [Qemu-devel] [PATCH v2 09/10] tests: acpi: add CPU hotplug testcase

2016-06-27 Thread Igor Mammedov
On Sat, 25 Jun 2016 00:58:14 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 24, 2016 at 08:00:20AM +0200, Igor Mammedov wrote: > > On Fri, 24 Jun 2016 08:53:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 23, 2016 at 03:47:36PM +0200, Igor Mammedov wrote: > > > > On Thu, 23

Re: [Qemu-devel] [PATCH 00/24] vhost-user reconnect fixes

2016-06-27 Thread Marc-André Lureau
On Sat, Jun 25, 2016 at 12:19 AM, Michael S. Tsirkin wrote: >> On Thu, Jun 23, 2016 at 6:31 AM, Michael S. Tsirkin wrote: >> > >> > OK so if it's ok for read or write to fail, then I think >> > the callback should just return success. >> > This will make sure backends such as vhost net in kernel

Re: [Qemu-devel] Qemu and heavily increased RSS usage

2016-06-27 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 12:45:49PM +0200, Peter Lieven wrote: > Am 24.06.2016 um 11:58 schrieb Peter Maydell: > > On 24 June 2016 at 10:37, Stefan Hajnoczi wrote: > >> On Wed, Jun 22, 2016 at 09:56:06PM +0100, Peter Maydell wrote: > >>> On 22 June 2016 at 20:55, Peter Lieven wrote: > What ma

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] blockdev: Add dynamic module loading for block drivers

2016-06-27 Thread Stefan Hajnoczi
On Fri, Jun 24, 2016 at 11:37:56AM +0100, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 11:04:43AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 22, 2016 at 05:35:54PM -0400, Colin Lord wrote: > > > > > > > > @@ -447,8 +466,15 @@ int get_tmp_filename(char *filename, int size) > > > static

Re: [Qemu-devel] [PATCH 2/2] raw_bsd: Convert to byte-based interface

2016-06-27 Thread Eric Blake
On 06/27/2016 06:19 AM, Paolo Bonzini wrote: > > > On 24/06/2016 05:58, Eric Blake wrote: >> Since the raw format driver is just passing things through, we can >> do byte-based read and write if the underlying protocol does >> likewise. >> >> There's one tricky part - if we probed the image forma

Re: [Qemu-devel] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-06-27 Thread Eric Blake
On 06/27/2016 06:13 AM, Paolo Bonzini wrote: > > > On 26/06/2016 00:15, Eric Blake wrote: >> diff --git a/block/nbd.c b/block/nbd.c >> index 8d57220..049d1bd 100644 >> --- a/block/nbd.c >> +++ b/block/nbd.c >> @@ -357,6 +357,7 @@ static int nbd_co_flush(BlockDriverState *bs) >> static void nbd_r

Re: [Qemu-devel] Question about a qemu Aarch64 error when adding several SCSI disks

2016-06-27 Thread Kevin Zhao
Hi Cole, On 24 June 2016 at 19:35, Cole Robinson wrote: > On 06/24/2016 12:58 AM, Kevin Zhao wrote: > > Hi Peter, > > Follow your advice, I have complied the Qemu v2.6. > > stack@u202158:~$ kvm --version > > QEMU emulator version 2.6.50 (v2.6.0-1280-g6f1d2d1-dirty), Copyright (c) > > 2003-2

Re: [Qemu-devel] [PATCH] linux-user: convert sockaddr_ll from host to target

2016-06-27 Thread Peter Maydell
On 26 June 2016 at 23:18, Laurent Vivier wrote: > As we convert sockaddr for AF_PACKET family for sendto() (target to > host) we need also to convert this for getsockname() (host to target). > > arping uses getsockname() to get the the interface address and uses > this address with sendto(). > > T

Re: [Qemu-devel] [PATCH] linux-user: convert sockaddr_ll from host to target

2016-06-27 Thread Laurent Vivier
Le 27/06/2016 à 15:09, Peter Maydell a écrit : > On 26 June 2016 at 23:18, Laurent Vivier wrote: >> As we convert sockaddr for AF_PACKET family for sendto() (target to >> host) we need also to convert this for getsockname() (host to target). >> >> arping uses getsockname() to get the the interfa

Re: [Qemu-devel] [PATCH] linux-user: convert sockaddr_ll from host to target

2016-06-27 Thread Peter Maydell
On 27 June 2016 at 14:12, Laurent Vivier wrote: > > > Le 27/06/2016 à 15:09, Peter Maydell a écrit : >> Do we need the new include? We already use struct sockaddr_ll >> without it. > > we already use target_sockaddr_ll, not sockaddr_ll. Oh yes; I got confused with sockaddr_nl I think. thanks --

Re: [Qemu-devel] [PATCH 11/17] block: Convert bdrv_read() to BdrvChild

2016-06-27 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c| 4 ++-- > block/qcow2-cluster.c | 6 +++--- > block/vdi.c | 4 ++-- > block/vvfat.c | 2 +- > include/block/block.h | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) Revi

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-27 Thread Peter Maydell
On 25 June 2016 at 13:35, Dmitry Osipenko wrote: > Software should see timer counter wrap around only after IRQ being triggered. > Change returned counter value to "1" for the expired timer and avoid returning > wrapped around counter value in periodic mode for the timer that has > bottom-half >

Re: [Qemu-devel] Qemu and heavily increased RSS usage

2016-06-27 Thread Peter Lieven
> Am 27.06.2016 um 14:39 schrieb Stefan Hajnoczi : > >> On Fri, Jun 24, 2016 at 12:45:49PM +0200, Peter Lieven wrote: >>> Am 24.06.2016 um 11:58 schrieb Peter Maydell: On 24 June 2016 at 10:37, Stefan Hajnoczi wrote: > On Wed, Jun 22, 2016 at 09:56:06PM +0100, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH v3 1/3] hw/misc: Add a model for the ASPEED System Control Unit

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 05:58, Andrew Jeffery wrote: > The SCU is a collection of chip-level control registers that manage the > various functions supported by ASPEED SoCs. Typically the bits control > interactions with clocks, external hardware or reset behaviour, and we > can largly take a hands-off

[Qemu-devel] [Bug 1586611] Re: usb-hub can not be detached when detach usb device from VM

2016-06-27 Thread Forest Lee
The usb-hub device should be deleted when the usb device was detached. When do you fix this bug? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1586611 Title: usb-hub can not be detached when detach

Re: [Qemu-devel] [PATCH 12/17] block: Convert bdrv_write() to BdrvChild

2016-06-27 Thread Max Reitz
On 27.06.2016 15:44, Max Reitz wrote: > On 21.06.2016 11:21, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- >> block/io.c | 5 +++-- >> block/qcow.c | 10 +- >> block/qcow2-cluster.c | 2 +- >> block/qcow2-refcount.c | 2 +- >> block/qcow2.c | 10

Re: [Qemu-devel] [PATCH v3 0/3] Add ASPEED SCU device

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 05:58, Andrew Jeffery wrote: > Hi all, > > These are three patches implementing minimal functionality for the ASPEED > System > Control Unit device and integrating it into the AST2400 SoC model/palmetto-bmc > machine. The device is critical for initialisation of u-boot and the

Re: [Qemu-devel] [PATCH 12/17] block: Convert bdrv_write() to BdrvChild

2016-06-27 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c | 5 +++-- > block/qcow.c | 10 +- > block/qcow2-cluster.c | 2 +- > block/qcow2-refcount.c | 2 +- > block/qcow2.c | 10 +- > block/vdi.c| 4 ++--

Re: [Qemu-devel] [PATCH v3 01/10] m25p80: Replace JEDEC ID masking with function.

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 09:07, wrote: > From: Marcin Krzeminski > > Instead of always reading and comparing jededc ID, > replace it by function. > > Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3 00/10] m25p80: Add new 512Mbit and 1Gbit devices

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 09:07, wrote: > From: Marcin Krzeminski > > This series adds support for new flash devices. > > V3: > * Add ReadMode handling in Dual/Quad readd for Spansion > * Macronix/Spansion are tested with the same tests as real HW > > V2: > * Move fast read command family handling to f

Re: [Qemu-devel] [PATCH v3 1/3] hw/misc: Add a model for the ASPEED System Control Unit

2016-06-27 Thread Andrew Jeffery
On Mon, 2016-06-27 at 14:42 +0100, Peter Maydell wrote: > On 24 June 2016 at 05:58, Andrew Jeffery wrote: > > > > The SCU is a collection of chip-level control registers that manage the > > various functions supported by ASPEED SoCs. Typically the bits control > > interactions with clocks, extern

Re: [Qemu-devel] [PATCH v3 0/3] Add ASPEED SCU device

2016-06-27 Thread Andrew Jeffery
On Mon, 2016-06-27 at 14:47 +0100, Peter Maydell wrote: > On 24 June 2016 at 05:58, Andrew Jeffery wrote: > > > > Hi all, > > > > These are three patches implementing minimal functionality for the ASPEED > > System > > Control Unit device and integrating it into the AST2400 SoC > > model/palme

Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers

2016-06-27 Thread Eric Blake
On 06/27/2016 02:50 AM, Markus Armbruster wrote: > With an ugly Perl script, of course %-/ > > I'm afraid my script and its usage is too brittle to be of much use > later on. I attach it anyway. A zero byte file map-include-to-header.pl~. Infinite compression :) -- Eric Blake eblake redha

Re: [Qemu-devel] [PATCH v8 2/8] register: Add Register API

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 16:42, Alistair Francis wrote: > This API provides some encapsulation of registers and factors out some > common functionality to common code. Bits of device state (usually MMIO > registers) often have all sorts of access restrictions and semantics > associated with them. This A

Re: [Qemu-devel] [PATCH v8 6/8] register: Add block initialise helper

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 16:42, Alistair Francis wrote: > From: Peter Crosthwaite > > Add a helper that will scan a static RegisterAccessInfo Array > and populate a container MemoryRegion with registers as defined. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > --- a/

Re: [Qemu-devel] [PATCH] qdev: Workaround for an issue caused by noglob option of shell for -device ?

2016-06-27 Thread Eric Blake
On 06/27/2016 12:29 AM, Markus Armbruster wrote: > Lin Ma writes: > >> If there is any filename in current path matching wildcard ?, This filename >> will >> be passed into -device ? while 'pathname expansion' isn't disabled by noglob >> of >> shell built-in option, qemu reports error in this c

Re: [Qemu-devel] [PATCH v8 7/8] dma: Add Xilinx Zynq devcfg device model

2016-06-27 Thread Peter Maydell
On 24 June 2016 at 16:42, Alistair Francis wrote: > Add a minimal model for the devcfg device which is part of Zynq. > This model supports DMA capabilities and interrupt generation. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > +REG32(CFG, 0x08) > +FIELD(CFG

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2016-06-27 Thread Kai Storbeck
That patch does not apply cleanly on qemu (2.0.0+dfsg, from trusty). There are changes in "kvmclock_pre_save" and "kvmclock_post_save", there's only "kvmclock_vm_state_change" in 2.0.0. Peeking at the 4 referenced patches on https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786789 the code change

[Qemu-devel] [PULL 16/18] m25p80: Fast read commands family changes.

2016-06-27 Thread Peter Maydell
From: Marcin Krzeminski Support for Spansion and Macronix flashes. Additionally Numonyx(Micron) moved from default in fast read commands family. Also moved fast read command decoding to functions. Signed-off-by: Marcin Krzeminski Reviewed-by: Cédric Le Goater Message-id: 1466755631-25201-9-git

[Qemu-devel] [PULL 15/18] m25p80: Introduce configuration registers.

2016-06-27 Thread Peter Maydell
From: Marcin Krzeminski Configuration registers for Spansion and Macronix devices. Signed-off-by: Marcin Krzeminski Reviewed-by: Cédric Le Goater Message-id: 1466755631-25201-8-git-send-email-marcin.krzemin...@nokia.com Signed-off-by: Peter Maydell --- hw/block/m25p80.c | 47

[Qemu-devel] [PULL 00/18] target-arm queue

2016-06-27 Thread Peter Maydell
Collection of patches before softfreeze: * some minor bug fixes * ASPEED SCU * the m25p80 patchset The following changes since commit aa8151b7df6b1c521b46583badfec504715018c5: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160627' into staging (2016-06-27 12:5

[Qemu-devel] [PULL 09/18] m25p80: Replace JEDEC ID masking with function.

2016-06-27 Thread Peter Maydell
From: Marcin Krzeminski Instead of always reading and comparing jededc ID, replace it by function. Signed-off-by: Marcin Krzeminski Message-id: 1466755631-25201-2-git-send-email-marcin.krzemin...@nokia.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/block/m25p80.c | 49 +++

[Qemu-devel] [PULL 17/18] m25p80: New flash devices.

2016-06-27 Thread Peter Maydell
From: Marcin Krzeminski Macronix: mx66u51235f and mx66u1g45g Micron: mt25ql01g and mt25qu01g Spansion: s25fs512s and s70fs01gs Signed-off-by: Marcin Krzeminski Reviewed-by: Cédric Le Goater Message-id: 1466755631-25201-10-git-send-email-marcin.krzemin...@nokia.com Signed-off-by: Peter Maydell

  1   2   3   4   >