Re: [Qemu-devel] [PATCH v4 2/3] target-i386: add migration support for Intel LMCE

2016-06-20 Thread Paolo Bonzini
On 20/06/2016 04:11, Haozhong Zhang wrote: >>> > > Does that mean we can automatically enable LMCE for "-cpu host"? >> > >> > We can automatically enable LMCE for "-cpu host" if and only if >> > the host kernel supports LMCE. >> > > According to our discussion for KVM Patch 3, we may have to dis

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

2016-06-20 Thread Paolo Bonzini
On 19/06/2016 05:36, Michael S. Tsirkin wrote: > > Making the guest's phys-bits larger than host-phys-bits would be okay if > > you reserve the area in the e820 and assume the guest doesn't touch it. > > How would it touch it if there's no RAM there? > PCI BARs is the only thing that comes to min

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 08:35 +1000, Benjamin Herrenschmidt wrote: > , > Ok so Darwin uses some of the HSPRG etc... that we don't emulate on > the 970 so I suspect it never worked. I've added them but something > else breaks, I'll dig, I have the kernel source so it shouldn't be > too hard > ;-) Wel

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Alexander Graf
On 20.06.16 09:08, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-20 at 08:35 +1000, Benjamin Herrenschmidt wrote: >> , >> Ok so Darwin uses some of the HSPRG etc... that we don't emulate on >> the 970 so I suspect it never worked. I've added them but something >> else breaks, I'll dig, I have

Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup()

2016-06-20 Thread Dmitry Fleytman
> On 20 Jun 2016, at 05:45 AM, Jason Wang wrote: > > > > On 2016年06月17日 01:17, Peter Maydell wrote: >> This patchset converts a handful of network devices to use >> ld*_p() and st*_p() instead of cpu_to_*w() and *_to_cpup(). >> >> This is the last lot of conversion patches; I have the "delet

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-20 Thread Haozhong Zhang
On 06/20/16 08:56, Paolo Bonzini wrote: > > > On 20/06/2016 05:09, Haozhong Zhang wrote: > > In the current nested VMX implementation in QEMU, setup > > MSR_IA32_FEATURE_CONTROL is left to guest. So I think, for LMCE which > > is another feature involving MSR_IA32_FEATURE_CONTROL, we may follow >

Re: [Qemu-devel] [PATCH] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU

2016-06-20 Thread Dmitry Fleytman
> On 18 Jun 2016, at 13:24 PM, KarimAllah Ahmed wrote: > > When a PCI device lives behind an IOMMU, it should use 'pci_dma_*' family of > functions when any transfer from/to guest memory is required while > 'cpu_physical_memory_*' family of functions completely bypass any MMU/IOMMU in > the syste

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Markus Armbruster
Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova > Reviewed-by: Stefan Hajnoczi > --- > monitor.c |4 +- > qapi/trace.json | 20 ++-- > qmp-commands.hx | 17 ++- > trace/qmp.c | 143 > --- > 4 files changed,

Re: [Qemu-devel] [PATCH RFC 2/4] range: Eliminate direct Range member access

2016-06-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:48PM +0200, Markus Armbruster wrote: >> Users of struct Range mess liberally with its members, which makes >> refactoring hard. Create a set of methods, and convert all users to >> call them instead of accessing members. The methods h

Re: [Qemu-devel] [PATCH v4 2/3] target-i386: add migration support for Intel LMCE

2016-06-20 Thread Haozhong Zhang
On 06/20/16 08:58, Paolo Bonzini wrote: > > > On 20/06/2016 04:11, Haozhong Zhang wrote: > >>> > > Does that mean we can automatically enable LMCE for "-cpu host"? > >> > > >> > We can automatically enable LMCE for "-cpu host" if and only if > >> > the host kernel supports LMCE. > >> > > > Accor

Re: [Qemu-devel] [PATCH RFC 3/4] range: Drop the previous commit's trickery

2016-06-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:49PM +0200, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > Agree with Eric about squashing this. Sanity check since Eric wrote "may": I assume you prefer this patch be squashed into the previous one for the non-RFC r

Re: [Qemu-devel] [PATCH RFC 4/4] range: Replace internal representation of Range

2016-06-20 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Jun 15, 2016 at 10:41:50PM +0200, Markus Armbruster wrote: >> Range represents a range as follows. Member @start is the inclusive >> lower bound, member @end is the exclusive upper bound. Zero @end is >> special: if @start is also zero, the range is empty,

Re: [Qemu-devel] [PATCH v8 11/12] vfio: register aer resume notification handler for aer resume

2016-06-20 Thread Zhou Jie
ping On 2016/6/12 10:38, Zhou Jie wrote: Hi, Alex It seems like we have a number of questions open in the thread with MST from the previous version, particularly whether we should actually drop the resume notifier and block the reset in the kernel. The concern being that it's not very well sp

Re: [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error

2016-06-20 Thread Markus Armbruster
Eduardo Habkost writes: > qdev_prop_set_globals_for_type() stops applying global properties > on the first error. It is a leftover from when QEMU exited on any > error when applying global property. Now we print a warning about > the first error, bug ignore all other global properties after it.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Thomas Huth
On 20.06.2016 08:17, Cédric Le Goater wrote: > On 06/20/2016 04:19 AM, David Gibson wrote: >> On Mon, Jun 20, 2016 at 07:12:38AM +1000, Benjamin Herrenschmidt wrote: >>> On Sun, 2016-06-19 at 19:23 +0200, Cédric Le Goater wrote: > You can run a 32-bit OS or firmware on ppc64, but it needs to kn

[Qemu-devel] [PATCH v3 0/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Juergen Gross
In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as the request structure in the ring have different layouts for different word size. Correct this by copying the request structure in case of different word size element by element

[Qemu-devel] [PATCH v3 1/2] xen: fix style of hw/block/xen_blkif.h

2016-06-20 Thread Juergen Gross
Fix hw/block/xen_blkif.h to match qemu coding style. Signed-off-by: Juergen Gross --- hw/block/xen_blkif.h | 151 +++ 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/hw/block/xen_blkif.h b/hw/block/xen_blkif.h index e3b133b..7ccf92e

[Qemu-devel] [PATCH v3 2/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Juergen Gross
In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as the request structure in the ring have different layouts for different word size. Correct this by copying the request structure in case of different word size element by element

Re: [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global

2016-06-20 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties.c | 7 --- > vl.c | 21 ++--- > 2 files

Re: [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals

2016-06-20 Thread Markus Armbruster
Eduardo Habkost writes: > The same Error* will be used in an error_propagate() call in the > future, so prepend a "can't apply global" prefix to it. What future? A future patch? > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties.c | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 17:08 +1000, Benjamin Herrenschmidt wrote: >  > That fixed, it dies elsewhere in something related to page faults, > still digging. >  Next problem: Darwin kernel assumes DSISR is 0 on a 0x380 exception ! qemu was leaving it to whatever value it had before. Kaboom. Now it cr

Re: [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output

2016-06-20 Thread Fam Zheng
On Mon, 06/20 12:50, Changlong Xie wrote: > For this patch, i think you forget to add qemu-version.h and/or > qemu-version.h.tmp in .gitignore > > changlox ~/w/qemu/qemu% gs > On branch master > Your branch is up-to-date with 'origin/master'. > > Untracked files: > (use "git add ..." to include

Re: [Qemu-devel] [PATCH 0/2] tcg: Fix i686 booting sparc64 openbios

2016-06-20 Thread Thomas Huth
On 18.06.2016 07:03, Richard Henderson wrote: > There's a minor typo here that affects dumping of 64-bit > registers on 32-bit hosts. Kind of embarrasing that this > hasn't been seen previously. > > The main change takes care of cases wherein there's overlap > between the indirect base register a

Re: [Qemu-devel] [PATCH 05/10] qdev: GlobalProperty.errp field

2016-06-20 Thread Markus Armbruster
Eduardo Habkost writes: > The new field will allow error handling to be configured by > qdev_prop_register_global() callers: &error_fatal and > &error_abort can be used to make QEMU exit or abort if any errors > are reported when applying the properties. > > Suggested-by: Paolo Bonzini > Signed-

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 08:10 +0200, Cédric Le Goater wrote: > That is how I feel also. So, why don't we just remove the op code in the  > instruction sets from the 32bit CPUs instead of leaving it and testing  > for PPC_SEGMENT_64B ? or is there some reasons we want to keep it around ?  Ah no Ben.

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Thomas Huth
On 18.06.2016 06:02, Anton Blanchard wrote: > Hi, > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, do you have a better idea how to fix it? >>> >>> Please try the following. >> >> Thanks! This passes my tests. Feel free to add: >> >> Tested-by: Anton Blanchard

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 09:47 +0200, Thomas Huth wrote: > > Linux ppc behaves the same on a 970. So we will need to fix the 'rfi's > > there also.  > > Really? Wow, that surprises me. That OpenBIOS code likely never ran on a > real 970 hardware, so that's not too much surprising that the "rfi" > sne

[Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

2016-06-20 Thread Zhang Chen
We want to poll and handle chardev in another thread other than main loop. But qemu_chr_add_handlers() can only work for global default context other than thread default context. So we use g_souce_attach(xx, g_main_context_get_thread_default()) replace g_source_attach(xx, NULL) to attach g_source.

Re: [Qemu-devel] [PULL 00/42] Tracing patches

2016-06-20 Thread Peter Maydell
On 17 June 2016 at 16:59, Stefan Hajnoczi wrote: > The following changes since commit 585fcd4b11070b3220685fc54ecca1991cdeb161: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-06-16 17:58:45 +0100) > > are available in the git repository at: > > git:/

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Cédric Le Goater
On 06/20/2016 09:47 AM, Thomas Huth wrote: > On 20.06.2016 08:17, Cédric Le Goater wrote: >> On 06/20/2016 04:19 AM, David Gibson wrote: >>> On Mon, Jun 20, 2016 at 07:12:38AM +1000, Benjamin Herrenschmidt wrote: On Sun, 2016-06-19 at 19:23 +0200, Cédric Le Goater wrote: >> You can run a 3

Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

2016-06-20 Thread Paolo Bonzini
On 20/06/2016 10:23, Zhang Chen wrote: > We want to poll and handle chardev in another thread > other than main loop. Can you explain this better? Paolo > But qemu_chr_add_handlers() can only > work for global default context other than thread default context. > So we use g_souce_attach(xx, g_

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Peter Maydell
On 20 June 2016 at 09:21, Thomas Huth wrote: > Would it maybe make sense to add some tests for this stuff to the > tests/tcg/ folder to make sure that such regressions do not sneak back > in in the future? Wouldn't help very much, because tests/tcg doesn't get run. (The underlying problem is "how

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Thomas Huth
On 20.06.2016 10:56, Peter Maydell wrote: > On 20 June 2016 at 09:21, Thomas Huth wrote: >> Would it maybe make sense to add some tests for this stuff to the >> tests/tcg/ folder to make sure that such regressions do not sneak back >> in in the future? > > Wouldn't help very much, because tests/t

[Qemu-devel] [PULL 00/01] seccomp branch queue

2016-06-20 Thread Eduardo Otubo
ll-seccomp-20160620 for you to fetch changes up to 3e684455032a748be261e5a2524147940af9b6d9: seccomp: Add support for ppc/ppc64 (2016-06-20 11:04:09 +0200) seccomp br

[Qemu-devel] [PULL 01/01] seccomp: Add support for ppc/ppc64

2016-06-20 Thread Eduardo Otubo
From: Michael Strosaker Support for ppc/ppc64 is official in libseccomp 2.3.0, so modify the configuration script to allow qemuu to enable seccomp for those platforms. Signed-off-by: Michael Strosaker Acked-by: Eduardo Otubo --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

2016-06-20 Thread Zhang Chen
On 06/20/2016 04:52 PM, Paolo Bonzini wrote: On 20/06/2016 10:23, Zhang Chen wrote: We want to poll and handle chardev in another thread other than main loop. Can you explain this better? For example, we use this in codes: +qemu_chr_add_handlers(s->chr_sec_in, compare_chr_can_read, +

[Qemu-devel] [PATCH] iscsi: fix assertion in is_sector_request_lun_aligned

2016-06-20 Thread Peter Lieven
Commit 94d047a added an assertion the the request alignment check. This introduced 2 issues: a) A off-by-one error since a request of BDRV_REQUEST_MAX_SECTORS is actually allowed. b) The bdrv_get_block_status call in the read path to check the allocation status requests up to INT_MAX sect

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 08:17 +0200, Cédric Le Goater wrote: >  > The current patch does not need fixing. I will send the OpenBIOS > patch  > shortly after I have looked at the FPU exception. > > Linux ppc behaves the same on a 970. So we will need to fix the > 'rfi's there also.  What do you mean

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2016, Juergen Gross wrote: > On 17/06/16 18:10, Stefano Stabellini wrote: > > On Fri, 17 Jun 2016, Paul Durrant wrote: > >>> -Original Message- > >>> From: Juergen Gross [mailto:jgr...@suse.com] > >>> Sent: 17 June 2016 11:40 > >>> To: Paul Durrant; Jan Beulich > >>> Cc: Anth

Re: [Qemu-devel] [PATCH v3 1/2] xen: fix style of hw/block/xen_blkif.h

2016-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2016, Juergen Gross wrote: > Fix hw/block/xen_blkif.h to match qemu coding style. > > Signed-off-by: Juergen Gross Acked-by: Stefano Stabellini > hw/block/xen_blkif.h | 151 > +++ > 1 file changed, 81 insertions(+), 70 deletions

[Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d"

2016-06-20 Thread Laurent Vivier
Display an exception number, generally defined as an hexadecimal number (for instance, EXCP_HLT is 0x10001). Signed-off-by: Laurent Vivier --- Resent to fix qemu-trivial email address. linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/main.c b/linu

Re: [Qemu-devel] [PATCH v3 2/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2016, Juergen Gross wrote: > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layouts for different word size. > > Correct this by copying the request structur

Re: [Qemu-devel] [PATCH v3 0/2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2016, Juergen Gross wrote: > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layouts for different word size. > > Correct this by copying the request structur

[Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

2016-06-20 Thread Peter Maydell
Fix missing includes of qemu/log.h, which broke compilation with the simple trace backend (the default backend pulls in log.h implicitly via trace.h). Signed-off-by: Peter Maydell --- In particular, this broke travis builds. --- hw/intc/arm_gicv3_dist.c | 1 + hw/intc/arm_gicv3_redist.c | 1 +

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Add missing break

2016-06-20 Thread Peter Maydell
On 20 June 2016 at 02:55, Shannon Zhao wrote: > From: Shannon Zhao > > These are spotted by coverity 1356936 and 1356937. > > Signed-off-by: Shannon Zhao Oops. Thanks, applied to target-arm.next. -- PMM

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-06-20 Thread Benjamin Herrenschmidt
On Mon, 2016-06-20 at 18:02 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-20 at 17:08 +1000, Benjamin Herrenschmidt wrote: > >   > > That fixed, it dies elsewhere in something related to page faults, > > still digging. > >   > Next problem: Darwin kernel assumes DSISR is 0 on a 0x380 excep

Re: [Qemu-devel] [PATCH v6 8/9] target-mips: Add nan2008 flavor of ..

2016-06-20 Thread Aleksandar Markovic
This patch is about NaN-2008 flavor of Mips instructions CEIL, CVT, FLOOR, ROUND, TRUNC only (its title is "Add nan2008 flavor..."). Legacy-NaN flavors of the same Mips instructions already operate correctly, and there is nothing to be fixed. The commit message is not description of another bug

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

2016-06-20 Thread Sergey Fedorov
On 20/06/16 12:57, Peter Maydell wrote: > Fix missing includes of qemu/log.h, which broke compilation with the > simple trace backend (the default backend pulls in log.h implicitly > via trace.h). > > Signed-off-by: Peter Maydell Tested-by: Sergey Fedorov Reviewed-by: Sergey Fedorov Thanks, Se

Re: [Qemu-devel] [Qemu-block] [PATCH] linux-aio: Cancel BH if not needed

2016-06-20 Thread Stefan Hajnoczi
On Fri, Jun 17, 2016 at 12:24:11PM +0200, Kevin Wolf wrote: > Am 17.06.2016 um 12:13 hat Stefan Hajnoczi geschrieben: > > On Wed, Jun 15, 2016 at 01:16:42PM +0200, Kevin Wolf wrote: > > > linux-aio uses a BH in order to make sure that the remaining completions > > > are processed even in nested eve

Re: [Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 07, 2016 at 05:28:24PM +0100, Stefan Hajnoczi wrote: > v3: > * Drop Patch 1 to batch guest notify for non-dataplane > >The Linux AIO completion BH and the virtio-blk batch notify BH changed > order >in the AioContext->first_bh list as a side-effect of moving the BH from >

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-20 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 17/06/2016 10:14, Chao Peng wrote: > > Basically: > > - it removes old ISA devices and support only PCI devices; > > I think you need to keep at least the RTC, otherwise where does Linux > get the time of day from? > > > - it removes 8259, i

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

2016-06-20 Thread Igor Mammedov
On Sun, 19 Jun 2016 19:13:17 +0300 Marcel Apfelbaum wrote: > On 06/17/2016 07:07 PM, Laszlo Ersek wrote: > > On 06/17/16 11:52, Igor Mammedov wrote: > >> On Fri, 17 Jun 2016 11:17:54 +0200 > >> Gerd Hoffmann wrote: > >> > >>> On Fr, 2016-06-17 at 10:43 +0200, Paolo Bonzini wrote: > > O

[Qemu-devel] [PATCH-Block] rbd:disable we if rbd cache is off

2016-06-20 Thread 张欢
rbd: disable wce if rbd cache is off wce will be enabled when cachemode is 'none', disable wce will NOT impact data consistency but will extremely improve the guest os db workload (write/fsync) performance since fsync will wait all in-flight io to complete introduced by

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Stefan Hajnoczi >> --- >> monitor.c |4 +- >> qapi/trace.json | 20 ++-- >> qmp-commands.hx | 17 ++- >> trace/qmp.c | 143 >>

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Signed-off-by: Lluís Vilanova >> Reviewed-by: Stefan Hajnoczi >> --- >> monitor.c |4 +- >> qapi/trace.json | 20 ++-- >> qmp-commands.hx | 17 ++- >> trace/qmp.c | 143 >>

Re: [Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set

2016-06-20 Thread Marcel Apfelbaum
On 06/20/2016 01:42 PM, Igor Mammedov wrote: On Sun, 19 Jun 2016 19:13:17 +0300 Marcel Apfelbaum wrote: On 06/17/2016 07:07 PM, Laszlo Ersek wrote: On 06/17/16 11:52, Igor Mammedov wrote: On Fri, 17 Jun 2016 11:17:54 +0200 Gerd Hoffmann wrote: On Fr, 2016-06-17 at 10:43 +0200, Paolo Bonzi

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2016-06-20 Thread T. Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/r

[Qemu-devel] [Bug 1079080] Re: ARM instruction "srs" wrong behaviour

2016-06-20 Thread T. Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1079080 Title: ARM instruction "srs" wrong behaviour Status in QEMU: Fix Released

[Qemu-devel] [Bug 1191457] Re: broken build without sdl

2016-06-20 Thread T. Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1191457 Title: broken build without sdl Status in QEMU: Fix Released Bug descripti

Re: [Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

2016-06-20 Thread Paolo Bonzini
On 20/06/2016 12:36, Stefan Hajnoczi wrote: > On Tue, Jun 07, 2016 at 05:28:24PM +0100, Stefan Hajnoczi wrote: >> v3: >> * Drop Patch 1 to batch guest notify for non-dataplane >> >>The Linux AIO completion BH and the virtio-blk batch notify BH changed >> order >>in the AioContext->first

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend

2016-06-20 Thread Peter Maydell
On 20 June 2016 at 11:22, Sergey Fedorov wrote: > On 20/06/16 12:57, Peter Maydell wrote: >> Fix missing includes of qemu/log.h, which broke compilation with the >> simple trace backend (the default backend pulls in log.h implicitly >> via trace.h). >> >> Signed-off-by: Peter Maydell > > Tested-b

[Qemu-devel] Any topics for today's MTTCG sync-up call?

2016-06-20 Thread Alex Bennée
Hi, We missed the last call (sorry I was travelling). Have we any topics we would like to cover this week? -- Alex Bennée

Re: [Qemu-devel] [PATCH 02/10] qdev: Eliminate qemu_add_globals() function

2016-06-20 Thread Igor Mammedov
On Wed, 15 Jun 2016 17:32:45 -0300 Eduardo Habkost wrote: > The function is just a helper to handle the -global options, it > can stay in vl.c like most qemu_opts_foreach() calls. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > hw/core/qdev-properties-system.c | 21 +---

Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-20 Thread Stefan Hajnoczi
On Fri, Jun 17, 2016 at 10:16:25PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote: > >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv) > >> gdbserver_start (gdbstub_port); > >> gdb_handlesig(cpu, 0); > >> } > >> +

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/17] block: Tighter assertions on bdrv_aligned_pwritev()

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:23PM -0600, Eric Blake wrote: > For symmetry with bdrv_aligned_preadv(), assert that the caller > really has aligned things properly. This requires adding an align > parameter, which is used now only in the new asserts, but will > come in handy in a later patch that ad

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv()

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:24PM -0600, Eric Blake wrote: > We don't pass any flags on to drivers to handle. Tighten an > assert to explain why we pass 0 to bdrv_driver_preadv(), and add > some comments on things to be aware of if we want to turn on > per-BDS BDRV_REQ_FUA support during reads in

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/17] block: Fix harmless off-by-one in bdrv_aligned_preadv()

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:25PM -0600, Eric Blake wrote: > If the amount of data to read ends exactly on the total size > of the bs, then we were wasting time creating a local qiov > to read the data in preparation for what would normally be > appending zeroes beyond the end, even though this co

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-06-20 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2016年06月14日 19:15, Zhang Chen wrote: > > We will rewrite tcp packet secondary received and sent. > > More verbose please. E.g which fields were rewrote and why. > > > Signed-off-by: Zhang Chen > > Signed-off-by: Li Zhijian > > Signed-off-by:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:26PM -0600, Eric Blake wrote: > The NBD layer was breaking up request at a limit of 2040 sectors > (just under 1M) to cater to old qemu-nbd. But the server limit > was raised to 32M in commit 2d8214885 to match the kernel, more > than three years ago; and the upstream

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/17] nbd: Advertise realistic limits to block layer

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:27PM -0600, Eric Blake wrote: > We were basing the advertisement of maximum discard and transfer > length off of UINT32_MAX, but since the rest of the block layer > has signed int limits on a transaction, nothing could ever reach > that maximum, and we risk overflowing

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Signed-off-by: Lluís Vilanova >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> monitor.c |4 +- >>> qapi/trace.json | 20 ++-- >>> qmp-commands.hx | 17 ++- >>> trace/qmp.c | 143 >>> +++

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Signed-off-by: Lluís Vilanova >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> monitor.c |4 +- >>> qapi/trace.json | 20 ++-- >>> qmp-commands.hx | 17 ++- >>> trace/qmp.c | 143 >>> +++

Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/17] iscsi: Advertise realistic limits to block layer

2016-06-20 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:30:28PM -0600, Eric Blake wrote: > The function sector_limits_lun2qemu() returns a value in units of > the block layer's 512-byte sector, and can be as large as > 0x4000, which is much larger than the block layer's inherent > limit of BDRV_REQUEST_MAX_SECTORS. The bl

Re: [Qemu-devel] [PULL 00/01] seccomp branch queue

2016-06-20 Thread Peter Maydell
available in the git repository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-20160620 > > for you to fetch changes up to 3e684455032a748be261e5a2524147940af9b6d9: > > seccomp: Add support for ppc/ppc64 (2016-06-20 11:04:09 +0200) > > --

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2016 at 08:54:10AM +0200, Paolo Bonzini wrote: > I wonder if Linux could run as a multiboot-compliant ELF file, and what > the performance would be... Multiboot omits the real mode stub. The Linux boot protocol does not require real mode. I think "64-bit BOOT PROTOCOL" in Documen

Re: [Qemu-devel] [PATCHv1] rtl8139: save/load RxMulOk counter (again)

2016-06-20 Thread Stefan Hajnoczi
On Fri, Jun 17, 2016 at 05:31:30PM +0100, David Vrabel wrote: > Commit 9d29cdeaaca3a0383af764000b71492c4fc67c6e (rtl8139: port > TallyCounters to vmstate) introduced in incompatibility in the v4 > format as it omitted the RxOkMul counter. > > There are presumably no users that were impacted by the

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- monitor.c |4 +- qapi/trace.json | 20 ++-- qmp-commands.hx | 17 ++- >

Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-20 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Jun 17, 2016 at 10:16:25PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote: >> >> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv) >> >> gdbserver_start (gdbstub_port); >> >> gdb_

Re: [Qemu-devel] RE-SEND: [PATCH 0/7] Enable multimedia applications on x86_64 guests

2016-06-20 Thread Stefan Hajnoczi
On Sat, Jun 18, 2016 at 07:14:56PM -0500, Timothy Pearson wrote: > Note: This is a resend due to my prior messages being word-wrapped > accidentally. > Apologies for the duplicates! > -- Please use git config format.thread=sh

Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-20 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: [...] diff --git a/qapi/trace.json b/qapi/trace.json index 01b0a52..25d8095 100644 --- a/qapi/trace.json +++ b/qapi/trace.json @@ -1,6 +1,6 @@ # -*- mode:

Re: [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global

2016-06-20 Thread Igor Mammedov
On Wed, 15 Jun 2016 17:32:46 -0300 Eduardo Habkost wrote: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Signed-off-by: Eduardo Habkost You are removing check that's used by tests, I'm getting after applying this pa

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-20 Thread Paolo Bonzini
On 20/06/2016 14:31, Stefan Hajnoczi wrote: > On Mon, Jun 20, 2016 at 08:54:10AM +0200, Paolo Bonzini wrote: > > I wonder if Linux could run as a multiboot-compliant ELF file, and what > > the performance would be... Multiboot omits the real mode stub. > > The Linux boot protocol does not requir

Re: [Qemu-devel] Any topics for today's MTTCG sync-up call?

2016-06-20 Thread alvise rigo
Hi Alex, I'm looking into the worries that Sergey issued in his review of the last LL/SC series. The target is to reduce the TLB flushes by using an exclusive history of dynamic length. I don't have anything ready yet though. Best regards, alvise On Mon, Jun 20, 2016 at 1:57 PM, Alex Bennée wro

Re: [Qemu-devel] [RFC 1/8] cpus: pass CPUState to run_on_cpu helpers

2016-06-20 Thread Alex Bennée
Sergey Fedorov writes: > From: Alex Bennée > > CPUState is a fairly common pointer to pass to these helpers. This means > if you need other arguments for the async_run_on_cpu case you end up > having to do a g_malloc to stuff additional data into the routine. For > the current users this isn't

Re: [Qemu-devel] [RFC 1/8] cpus: pass CPUState to run_on_cpu helpers

2016-06-20 Thread Sergey Fedorov
On 20/06/16 16:02, Alex Bennée wrote: > Sergey Fedorov writes: > >> > From: Alex Bennée >> > >> > CPUState is a fairly common pointer to pass to these helpers. This means >> > if you need other arguments for the async_run_on_cpu case you end up >> > having to do a g_malloc to stuff additional dat

Re: [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking

2016-06-20 Thread Igor Mammedov
On Wed, 15 Jun 2016 17:32:43 -0300 Eduardo Habkost wrote: > This series includes multiple changes to the way errors are > handled by the global property system. Could you fix "make check", by the end of series it breaks at compile time. > > The series is based on my machine-next branch, availab

[Qemu-devel] [Bug 1585008] Re: Windows 7 guests hang on bootup when qxl video is used

2016-06-20 Thread Laszlo Ersek (Red Hat)
This is a dupe of LP#1581936 and LP#1591724. The issue is fixed by upstream QEMU commit 94ef4f337fb6. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1585008 Title: Windows 7 guests hang on bootup wh

Re: [Qemu-devel] [PATCH 05/19] block: Add bdrv_default_refresh_protocol_filename

2016-06-20 Thread Alberto Garcia
On Tue 26 Apr 2016 11:32:04 PM CEST, Max Reitz wrote: > Split off the default code for protocol BDS from bdrv_refresh_filename() > into an own function, just as it has been done for format BDS. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 04/19] block: Add bdrv_default_refresh_format_filename

2016-06-20 Thread Alberto Garcia
On Tue 26 Apr 2016 11:32:03 PM CEST, Max Reitz wrote: > Split off the default code for format BDS from bdrv_refresh_filename() > into an own function, first because it is nicer this way, and second > because this will allow block drivers to reuse this function in their > own specific implementation

Re: [Qemu-devel] [PATCH 1/7] Add initial x86_64 signal handlers

2016-06-20 Thread Peter Maydell
On 19 June 2016 at 01:11, Timothy Pearson wrote: > Note that x86_64 systems only offer the _rt signal handler variants, > so the legacy signal handlers remain unimplemented on this platform. > > Signed-off-by: Timothy Pearson > --- > linux-user/signal.c | 302 > ++

Re: [Qemu-devel] [PATCH v6 02/22] qapi: Add lock-mode in blockdev-add options

2016-06-20 Thread Kevin Wolf
Am 18.06.2016 um 13:16 hat Fam Zheng geschrieben: > On Fri, 06/17 11:17, Kevin Wolf wrote: > > Am 03.06.2016 um 10:48 hat Fam Zheng geschrieben: > > > To allow overriding the default locking behavior when opening the image. > > > > > > Signed-off-by: Fam Zheng > > > --- > > > qapi/block-core.jso

Re: [Qemu-devel] [PATCH 2/7] QEMU does not currently support host pages that are larger than guest pages, likely due to glibc using fixed mmap requests.

2016-06-20 Thread Peter Maydell
On 19 June 2016 at 19:24, Richard Henderson wrote: > On 06/19/2016 02:46 AM, Peter Maydell wrote: >> This is supposed to work -- for instance the linux-user/mmap.c >> code has support for host pages and target pages not being the same. >> In particular for ARM guests TARGET_PAGE_SIZE is 1K but the

Re: [Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

2016-06-20 Thread Roman Penyaev
Hi, Stefan. On Mon, Jun 20, 2016 at 12:36 PM, Stefan Hajnoczi wrote: > On Tue, Jun 07, 2016 at 05:28:24PM +0100, Stefan Hajnoczi wrote: >> v3: >> * Drop Patch 1 to batch guest notify for non-dataplane >> >>The Linux AIO completion BH and the virtio-blk batch notify BH changed >> order >>

Re: [Qemu-devel] [PATCH 4/7] This patch adds initial user-virtualization support for the DRM (type 'd') IOCTLs in linux. With it and a corresponding architecture chroot (say aarch64), I am able to suc

2016-06-20 Thread Peter Maydell
On 19 June 2016 at 01:11, Timothy Pearson wrote: > 1. It will only work with open drivers as their IOCTLs are documented. > 2. i965+ is only supported. That is any haswell, ivybridge, etc. GPU > will work. > 3. X doesn't start yet, though this patch eliminates all the visible > unsupported DRM IOC

Re: [Qemu-devel] [PATCH 10/10] machine: Skip global registration for non-existing classes

2016-06-20 Thread Eduardo Habkost
On Sun, Jun 19, 2016 at 07:50:56PM +0300, Marcel Apfelbaum wrote: > On 06/19/2016 07:39 PM, Marcel Apfelbaum wrote: > > On 06/15/2016 11:32 PM, Eduardo Habkost wrote: > > > MachineClass::compat_props may point to class names that are not > > > compiled into the QEMU binary. Skip registering those a

Re: [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals

2016-06-20 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 10:02:38AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > The same Error* will be used in an error_propagate() call in the > > future, so prepend a "can't apply global" prefix to it. > > What future? A future patch? > > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH] build: Use $(CC) for compiling .S files

2016-06-20 Thread Peter Maydell
On 18 June 2016 at 07:47, Richard Henderson wrote: > We fail to pass to AS all of the different flags that > may be required for a given set of CFLAGS. Rather than > figuring out the host-specific mapping, it's better to > allow the compiler driver to do that. > > This fixes e.g. ../configure --c

Re: [Qemu-devel] [PATCH 08/19] block: Make path_combine() return the path

2016-06-20 Thread Alberto Garcia
On Tue 26 Apr 2016 11:32:07 PM CEST, Max Reitz wrote: > Besides being safe for arbitrary path lengths, after some follow-up > patches all callers will want a freshly allocated buffer anyway. > > In the meantime, path_combine_deprecated() is added which has the same > interface as path_combine() had

Re: [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking

2016-06-20 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 03:11:00PM +0200, Igor Mammedov wrote: > On Wed, 15 Jun 2016 17:32:43 -0300 > Eduardo Habkost wrote: > > > This series includes multiple changes to the way errors are > > handled by the global property system. > Could you fix "make check", > by the end of series it breaks

Re: [Qemu-devel] [PATCH 05/10] qdev: GlobalProperty.errp field

2016-06-20 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 10:14:55AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: [...] > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > > index 24aa0a7..16e7cc0 100644 > > --- a/include/hw/qdev-core.h > > +++ b/include/hw/qdev-core.h > > @@ -256,6 +256,9 @@ struct Pro

  1   2   3   4   >