Re: [Qemu-devel] [PATCH v3 0/4] enable iommu with -device

2016-06-14 Thread Marcel Apfelbaum
On 06/13/2016 11:51 PM, Michael S. Tsirkin wrote: On Mon, Jun 13, 2016 at 05:36:56PM +0300, Marcel Apfelbaum wrote: Create the iommu device with '-device intel-iommu' instead of '-machine,iommu=on'. The device is part of the machine properties because we wanted to ensure is created before any

[Qemu-devel] [PATCH v4 0/4] enable iommu with -device

2016-06-14 Thread Marcel Apfelbaum
Create the iommu device with '-device intel-iommu' instead of '-machine,iommu=on'. The device is part of the machine properties because we wanted to ensure is created before any other PCI device. The alternative is to skip the bus_master_enable_region at the time the device is created. We can cr

[Qemu-devel] [PATCH v4 1/4] hw/pci: delay bus_master_enable_region initialization

2016-06-14 Thread Marcel Apfelbaum
Skip bus_master_enable region creation on PCI device init in order to be sure the IOMMU device (if present) would be created in advance. Add this memory region at machine_done time. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 41 - inclu

[Qemu-devel] [PATCH v4 3/4] hw/iommu: enable iommu with -device

2016-06-14 Thread Marcel Apfelbaum
Use the standard '-device iommu' to create the IOMMU device. The legacy '-machine,iommu=on' can still be used. Signed-off-by: Marcel Apfelbaum --- hw/i386/intel_iommu.c | 16 hw/i386/pc_q35.c | 1 - hw/pci-host/q35.c | 17 + 3 files changed, 17 insertio

[Qemu-devel] [PATCH v4 2/4] q35: allow dynamic sysbus

2016-06-14 Thread Marcel Apfelbaum
Allow adding sysbus devices with -device on Q35. At first Q35 will support only intel-iommu to be added this way, however the command line will support all sysbus devices. Mark with 'cannot_instantiate_with_device_add_yet' the ones causing immediate problems (e.g. crashes). Signed-off-by: Marcel

[Qemu-devel] [PATCH] qom/object: fix comment typo

2016-06-14 Thread Changlong Xie
Signed-off-by: Changlong Xie --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 99de539..925c279 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -901,7 +901,7 @@ GSList *object_class_get_li

[Qemu-devel] [PATCH v4 4/4] machine: remove iommu property

2016-06-14 Thread Marcel Apfelbaum
Since iommu devices can be created with '-device' there is no need to keep iommu as machine and mch property. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 20 hw/pci-host/q35.c | 12 include/hw/pci-host/q35.h | 1 - qemu-options.hx

Re: [Qemu-devel] [PATCH] qom/object: fix comment typo

2016-06-14 Thread Laurent Vivier
On 14/06/2016 09:27, Changlong Xie wrote: > Signed-off-by: Changlong Xie Reviewed-by: Laurent Vivier > --- > include/qom/object.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qom/object.h b/include/qom/object.h > index 99de539..925c279 100644 > --- a/incl

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-06-14 Thread Thomas Huth
On 02.06.2016 05:17, David Gibson wrote: > On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: >> On 01/06/16 03:15, David Gibson wrote: >> >>> On Tue, May 31, 2016 at 11:28:49PM +0100, Mark Cave-Ayland wrote: [...] Note that there is also another regression that has recently lan

[Qemu-devel] [PATCH v20 Resend 02/10] Backup: clear all bitmap when doing block checkpoint

2016-06-14 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c | 18 ++ include/block/block_backup.h | 3 +++ 2 files changed, 21 insertions(+) create mode 100644 include/block

[Qemu-devel] [PATCH v20 Resend 03/10] Backup: export interfaces for extra serialization

2016-06-14 Thread Changlong Xie
Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_co_writev bdrv_co_writev ... bdrv_aligned_pwritev notifier_with_return_list_notify -> backup_do_cow bdrv_driver_pwritev // write new contents step 2. drive-backup s

[Qemu-devel] [PATCH v20 Resend 01/10] unblock backup operations in backing file

2016-06-14 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 736432f..dcf63f4 100644 --- a/block.c +++ b/block.c @@ -1310,6 +1310,23 @@ void bdrv_set_backing_hd(BlockDriver

[Qemu-devel] [PATCH v20 Resend 00/10] Block replication for continuous checkpoints

2016-06-14 Thread Changlong Xie
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt You can get the patc

[Qemu-devel] [PATCH v20 Resend 06/10] auto complete active commit

2016-06-14 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v20 Resend 04/10] Link backup into block core

2016-06-14 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v20 Resend 10/10] support replication driver in blockdev-add

2016-06-14 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/q

[Qemu-devel] [PATCH v20 Resend 05/10] docs: block replication's description

2016-06-14 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode 100644 docs/block-replication.txt

[Qemu-devel] [PATCH v20 Resend 08/10] Implement new driver for block replication

2016-06-14 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 657 2 files changed, 658 insertions(+) create mode 100

[Qemu-devel] [PATCH v20 Resend 07/10] Introduce new APIs to do replication operation

2016-06-14 Thread Changlong Xie
This commit introduces six replication interfaces(for block, network etc). Firstly we can use replication_(new/remove) to create/destroy replication instances, then in migration we can use replication_(start/stop/do_checkpoint /get_error)_all to handle all replication operations. More detail please

[Qemu-devel] [PATCH v20 Resend 09/10] tests: add unit test case for replication

2016-06-14 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + tests/Makefile | 4 + tests/test-replication.c | 555 +++ 3 files changed, 560 insertions(+) create mode 100644 tests/test-replication.c diff -

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-14 Thread Cédric Le Goater
>> #4 0x7fa81c6694ac in bdrv_aligned_pwritev (bs=0x7fa81d4dd050, >> req=, offset=30878208, >> bytes=512, qiov=0x7fa7f47fee60, flags=0) >> at /home/legoater/work/qemu/qemu-ast2400-mainline.git/block/io.c:1243 >> #5 0x7fa81c669ecb in bdrv_co_pwritev (bs=0x7fa81d4dd050, offset=8,

Re: [Qemu-devel] [PATCH 5/5] block: Move request_alignment into BlockLimit

2016-06-14 Thread Kevin Wolf
Am 14.06.2016 um 06:39 hat Eric Blake geschrieben: > On 06/07/2016 04:08 AM, Kevin Wolf wrote: > > >> Found it; squash this in (or use it as an argument why we don't want > >> request_alignment in bs->bl after all): > > > > This hunk doesn't make sense to me. For the correctness of the code it >

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

2016-06-14 Thread Wei Xu
On 2016年06月09日 05:48, Aaron Conole wrote: Flavio Leitner writes: Adding Aaron who is fixing exactly that on the OVS side. Aaron, please see the last question in the bottom of this email. On Wed, Jun 08, 2016 at 06:07:29AM -0400, Amnon Ilan wrote: - Original Message - From: "Micha

Re: [Qemu-devel] [PATCH v8 15/17] vmw_pvscsi: remove unnecessary internal msi state flag

2016-06-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jun 10, 2016 at 05:54:36PM +0800, Cao jin wrote: >> Internal flag msi_used is uncesessary, msi_uninit() could be called >> directly, msi_enabled() is enough to check device msi state. >> >> cc: Paolo Bonzini >> cc: Dmitry Fleytman >> cc: Markus Armbruster

Re: [Qemu-devel] [RFC v2 3/3] Remove unnecessary variables for function return value

2016-06-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Jun 13, 2016 at 01:29:47PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Use Coccinelle script to replace 'ret = E; return ret' with >> > 'return E'. The script will do the substitution only when the >> > function return type and variable t

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables

2016-06-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Jun 13, 2016 at 08:49:37PM +0200, Markus Armbruster wrote: >> Eric Blake writes: > [...] >> >> >> >> See, e.g.: >> >> >> >> void qmp_guest_suspend_disk(Error **errp) >> >> { >> >> Error *local_err = NULL; >> >> GuestSuspendMode *mode = g_new(GuestSuspe

Re: [Qemu-devel] [PULL 16/32] pci core: assert ENOSPC when add capability

2016-06-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > From: Cao jin > > ENOSPC is programming error, assert it for debugging. > > cc: Michael S. Tsirkin > cc: Marcel Apfelbaum > cc: Markus Armbruster > > Reviewed-by: Markus Armbruster > Reviewed-by: Marcel Apfelbaum > Signed-off-by: Cao jin > Reviewed-by: Markus

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

2016-06-14 Thread Daniel P. Berrange
On Tue, Jun 14, 2016 at 04:03:43PM +0800, Wei Xu wrote: > On 2016年06月09日 05:48, Aaron Conole wrote: > > Flavio Leitner writes: > > > > > Adding Aaron who is fixing exactly that on the OVS side. > > > > > > Aaron, please see the last question in the bottom of this email. > > > > > > On Wed, Jun

Re: [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init

2016-06-14 Thread Paolo Bonzini
On 13/06/2016 22:35, Andrew Jones wrote: > On Mon, Jun 13, 2016 at 07:04:01PM +0200, Paolo Bonzini wrote: >> On 10/06/2016 19:40, Andrew Jones wrote: >>> +if (sockets == -1 || cores == -1 || threads == -1 || >>> +maxcpus == -1 || cpus == -1) { >>> +error_report("cpu topology:

Re: [Qemu-devel] [PATCH 3/5] block: Switch transfer length bounds to byte-based

2016-06-14 Thread Kevin Wolf
Am 12.06.2016 um 00:06 hat Eric Blake geschrieben: > On 06/07/2016 06:45 AM, Kevin Wolf wrote: > > Am 03.06.2016 um 19:03 hat Eric Blake geschrieben: > >> Sector-based limits are awkward to think about; in our on-going > >> quest to move to byte-based interfaces, convert max_transfer_length > >> an

Re: [Qemu-devel] [PATCH] target-i386: kvm: cache KVM_GET_SUPPORTED_CPUID data

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 07:01, Chao Peng wrote: >> > >> > Which are the CPUID leaves for which KVM_GET_SUPPORTED_CPUID is not >> > stateless? I cannot find any. > I have though leaf 0xd, sub leaf 1 is not stateless, as the size of > xsave buffer(EBX) is based on XCR0 | IA32_XSS. But after looking KVM > c

Re: [Qemu-devel] [PULL 00/32] pc, pci, virtio: new features, cleanups, fixes

2016-06-14 Thread Peter Maydell
On 13 June 2016 at 21:38, Michael S. Tsirkin wrote: > The following changes since commit c02d7030c3c538312c7f464cb79b72c29a20df74: > > virtio: move bi-endian target support to a single location (2016-06-07 > 15:39:28 +0300) > > are available in the git repository at: > > git://git.kernel.org/

Re: [Qemu-devel] [PATCHv2 2/2] MAINTAINERS: remove Blue Swirl as SPARC maintainer

2016-06-14 Thread Markus Armbruster
Mark Cave-Ayland writes: > Blue is no longer active in the QEMU project, so remove him from the list of > SPARC maintainers. > > Signed-off-by: Mark Cave-Ayland > CC: Blue Swirl > --- > MAINTAINERS |1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 081

Re: [Qemu-devel] [RFC 02/10] softmmu_llsc_template.h: Move to multi-threading

2016-06-14 Thread Alex Bennée
Alex Bennée writes: > Sergey Fedorov writes: > >> On 26/05/16 19:35, Alvise Rigo wrote: >>> Using tcg_exclusive_{lock,unlock}(), make the emulation of >>> LoadLink/StoreConditional thread safe. >>> >>> During an LL access, this lock protects the load access itself, the >>> update of the exclusi

Re: [Qemu-devel] [PATCH 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 06:39:46PM +0200, Lluís Vilanova wrote: > Paolo Bonzini writes: > > > On 13/06/2016 14:15, Lluís Vilanova wrote: > >> > That said, I am skeptical about the benefit of the interfaces you are > >> > adding. They add a lot of complication and overhead (especially > >> > regar

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-14 Thread Kevin Wolf
Am 14.06.2016 um 10:02 hat Cédric Le Goater geschrieben: > >> #4 0x7fa81c6694ac in bdrv_aligned_pwritev (bs=0x7fa81d4dd050, > >> req=, offset=30878208, > >> bytes=512, qiov=0x7fa7f47fee60, flags=0) > >> at /home/legoater/work/qemu/qemu-ast2400-mainline.git/block/io.c:1243 > >> #5 0x

Re: [Qemu-devel] [PATCH] target-i386: kvm: cache KVM_GET_SUPPORTED_CPUID data

2016-06-14 Thread Chao Peng
On Tue, Jun 14, 2016 at 10:21:41AM +0200, Paolo Bonzini wrote: > > > On 14/06/2016 07:01, Chao Peng wrote: > >> > > >> > Which are the CPUID leaves for which KVM_GET_SUPPORTED_CPUID is not > >> > stateless? I cannot find any. > > I have though leaf 0xd, sub leaf 1 is not stateless, as the size

Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers

2016-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 05:40:42PM -0400, John Snow wrote: > On 05/09/2016 08:47 AM, Stefan Hajnoczi wrote: > > v2: > > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > > > This patch series eliminates code duplication in libqos virtio. > > include/standard-headers/ contains the Linu

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-14 Thread Kevin Wolf
Am 14.06.2016 um 10:34 hat Denis V. Lunev geschrieben: > On 06/08/2016 02:23 PM, Kevin Wolf wrote: > >Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: > >>From: Vladimir Sementsov-Ogievskiy > >> > >>Acquire aio context before run command, this is mandatory for unit tests. > >> > >>Signed-off

Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers

2016-06-14 Thread Stefan Hajnoczi
On Mon, May 09, 2016 at 01:47:33PM +0100, Stefan Hajnoczi wrote: > v2: > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define ou

Re: [Qemu-devel] [PATCH v3 2/3] error: Remove unnecessary local_err variables

2016-06-14 Thread Markus Armbruster
Eduardo Habkost writes: > This patch simplifies code that uses a local_err variable just to > immediately use it for an error_propagate() call. > > Coccinelle patch used to perform the changes added to > scripts/coccinelle/remove_local_err.cocci. > > Reviewed-by: Eric Blake > Acked-by: Cornelia

Re: [Qemu-devel] [PATCH] libqos: add qvirtqueue_cleanup()

2016-06-14 Thread Stefan Hajnoczi
On Thu, May 05, 2016 at 04:53:35PM +0100, Stefan Hajnoczi wrote: > qvirtqueue_setup() allocates the vring and virtqueue state. So far > there has been no function to free it. Callers have been using > guest_free() for the vring but forgot to free the QVirtQueue state. > > This patch solves the m

Re: [Qemu-devel] [PATCH 0/5] libqos: add ability to pop buffers from virtqueue

2016-06-14 Thread Stefan Hajnoczi
On Thu, May 05, 2016 at 09:32:12AM +0100, Stefan Hajnoczi wrote: > The libqos virtio framework currently offers no way to pop buffers off the > virtqueue. Existing test cases are trivial and therefore get away without > reclaiming buffers. More extensive tests really do need to pop buffers and do

Re: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-06-14 Thread Kevin Wolf
Am 31.05.2016 um 16:26 hat Eric Blake geschrieben: > On 05/31/2016 05:36 AM, Cédric Le Goater wrote: > > commit 243e6f69c129 ("m25p80: Switch to byte-based block access") > > replaced blk_read() calls with blk_pread() but return values are > > different. > > Shoot, I completely missed that when I

Re: [Qemu-devel] [PATCH v3 3/3] coccinelle: Remove unnecessary variables for function return value

2016-06-14 Thread Markus Armbruster
Eduardo Habkost writes: > Use Coccinelle script to replace 'ret = E; return ret' with > 'return E'. The script will do the substitution only when the > function return type and variable type are the same. > > Sending as RFC because the patch looks more intrusive than the > others. Probably better

Re: [Qemu-devel] [PATCH 0/6] block: Enable byte granularity I/O

2016-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 03:43:06PM +0200, Kevin Wolf wrote: > Am 13.06.2016 um 15:27 hat Stefan Hajnoczi geschrieben: > > On Wed, Jun 08, 2016 at 04:10:05PM +0200, Kevin Wolf wrote: > > > Previous series have already converted some block drivers to byte-based > > > rather > > > than sector-based i

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-14 Thread Denis V. Lunev
On 06/14/2016 11:44 AM, Kevin Wolf wrote: Am 14.06.2016 um 10:34 hat Denis V. Lunev geschrieben: On 06/08/2016 02:23 PM, Kevin Wolf wrote: Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: From: Vladimir Sementsov-Ogievskiy Acquire aio context before run command, this is mandatory for u

Re: [Qemu-devel] [PATCH v3 0/3] coccinelle: Clean up error checks and return value variables

2016-06-14 Thread Markus Armbruster
Eduardo Habkost writes: > Changes v1 -> v2: > * The Coccinelle scripts were simplified by using "when" > constraints to detect when a variable is not used elsewhere > inside the function. > * Added script to remove unnecessary variables for function > return value. > * Coccinelle scripts ad

Re: [Qemu-devel] [Qemu-block] [PATCH] macio: Use blk_drain instead of blk_drain_all

2016-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 11:39:48AM +0200, Kevin Wolf wrote: > Am 12.06.2016 um 08:56 hat Fam Zheng geschrieben: > > We only care about the associated backend, so blk_drain is more > > appropriate here. > > > > Signed-off-by: Fam Zheng > > [ Cc: John ] > > > --- > > hw/ide/macio.c | 2 +- > > 1

Re: [Qemu-devel] [PATCH v2 2/2] block: Assert that flags are in range

2016-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 12:56:35PM -0600, Eric Blake wrote: > Add a new BDRV_REQ_MASK constant, and use it to make sure that > caller flags are always valid. > > Tested with 'make check' and with qemu-iotests on both '-raw' > and '-qcow2'; the only failure turned up was fixed in the > previous com

Re: [Qemu-devel] [PATCH v3 3/3] coccinelle: Remove unnecessary variables for function return value

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 10:57, Markus Armbruster wrote: >> diff --git a/scripts/coccinelle/return_directly.cocci >> b/scripts/coccinelle/return_directly.cocci >> > new file mode 100644 >> > index 000..c52f4fc >> > --- /dev/null >> > +++ b/scripts/coccinelle/return_directly.cocci >> > @@ -0,0 +1,21 @@

Re: [Qemu-devel] [PATCH 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 10:39, Stefan Hajnoczi wrote: > On Mon, Jun 13, 2016 at 06:39:46PM +0200, Lluís Vilanova wrote: >> Paolo Bonzini writes: >> >>> On 13/06/2016 14:15, Lluís Vilanova wrote: > That said, I am skeptical about the benefit of the interfaces you are > adding. They add a lot of com

[Qemu-devel] [PATCH 2/7] doc: sync help descriprion for --trace with man for qemu.1

2016-06-14 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 1f9b390..f28abd3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

2016-06-14 Thread Denis V. Lunev
Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 2 +- qemu-

[Qemu-devel] [PATCH v5 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

2016-06-14 Thread Denis V. Lunev
Changes from v4: - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 - moved @findex from qemu-option-trace.texi Changes from v3: - fixed difference in help/man for qemu-img/qemu-nbd - created separate .texi to contain trace description, proper dependency is added to

[Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file

2016-06-14 Thread Denis V. Lunev
This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 3 ++- qemu-option-trace.texi | 25 + qemu-options.hx| 27

[Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing

2016-06-14 Thread Denis V. Lunev
This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo Bonzini CC

[Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c

2016-06-14 Thread Denis V. Lunev
The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo B

Re: [Qemu-devel] [PATCH v8 15/17] vmw_pvscsi: remove unnecessary internal msi state flag

2016-06-14 Thread Cao jin
On 06/14/2016 04:12 PM, Markus Armbruster wrote: "Michael S. Tsirkin" writes: @@ -1222,7 +1215,6 @@ static const VMStateDescription vmstate_pvscsi = { VMSTATE_STRUCT_TEST(parent_obj, PVSCSIState, pvscsi_vmstate_test_pci_device, 0,

[Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io

2016-06-14 Thread Denis V. Lunev
Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-io.c | 17 + 1 file changed, 13 insertions

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

2016-06-14 Thread Denis V. Lunev
The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev Suggested by: Daniel P. Berrange CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 2 +- qemu-img.c| 18 +- qemu-img

Re: [Qemu-devel] [PATCH v8 00/17] Add param Error ** for msi_init()

2016-06-14 Thread Cao jin
On 06/14/2016 04:31 AM, Michael S. Tsirkin wrote: On Mon, Jun 13, 2016 at 10:45:18PM +0300, Michael S. Tsirkin wrote: Thanks! I applied 1-12. And reverted most of them except 1-2: make check fails. Sorry for that. It is actually not a bug, I changed the order of adding pci capability in i

Re: [Qemu-devel] [RFC 02/10] softmmu_llsc_template.h: Move to multi-threading

2016-06-14 Thread Sergey Fedorov
On 14/06/16 11:37, Alex Bennée wrote: > Alex Bennée writes: > >> Sergey Fedorov writes: >> >>> On 26/05/16 19:35, Alvise Rigo wrote: Using tcg_exclusive_{lock,unlock}(), make the emulation of LoadLink/StoreConditional thread safe. During an LL access, this lock protects the lo

Re: [Qemu-devel] [PULL 0/8] ppc-for-2.7 queue 20160614

2016-06-14 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160614 > > for you to fetch changes up to d0e5a8f2937de66778d94c20a8fc5cf43501fa04: > > spapr: Ensure all LMBs are represented in ib

[Qemu-devel] [PATCH] qemu-img bench: Fix uninitialised writethrough mode

2016-06-14 Thread Kevin Wolf
If no -t option is specified, bool writethrough stayed uninitialised. Initialise it as false, which makes cache=writeback the default cache mode. Signed-off-by: Kevin Wolf --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 251386b..14

Re: [Qemu-devel] [PATCH v2 1/3] linux-user: add rtnetlink(7) support

2016-06-14 Thread Peter Maydell
On 22 May 2016 at 17:56, Laurent Vivier wrote: > rtnetlink is needed to use iproute package (ip addr, ip route) > and dhcp client. > > +static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh, > + size_t len, > +

[Qemu-devel] [PATCH] migration: Trace improvements

2016-06-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A couple of improvements to tracing that have come out of helping people with migration problems: * vmstate_n_elems trace the count/name - for when you have problems getting array counts right * vmstate_subsection_load_bad - add the idstr, for when you recei

Re: [Qemu-devel] [PATCH v2 0/2] Fix incomplete aio_preadv byte conversion in mirroring

2016-06-14 Thread Kevin Wolf
Am 13.06.2016 um 20:56 hat Eric Blake geschrieben: > v2: Split the bug fix from the addition of assertions, add a > BDRV_REQ_MASK constant [famz], stick assertions at the more > common entry points Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 5/5] linux-user: Create a hostdep.h for each host architecture

2016-06-14 Thread Peter Maydell
In commit 4d330cee37a21 a new hostdep.h file was added, with the intent that host architectures which needed one could provide it, and the build system would automatically fall back to a generic version if there was no version for the host architecture. Although this works, it has a flaw: if a subs

[Qemu-devel] [PATCH 1/5] configure: Don't override ARCH=unknown if enabling TCI

2016-06-14 Thread Peter Maydell
At the moment if configure finds an unknown CPU it will set ARCH to 'unknown', and then later either bail out or set it to 'tci' (depending on whether the user passed configure the --enable-tcg-interpreter switch). This is unnecessarily confusing, because we could be using TCI in two cases: * a kn

[Qemu-devel] [PATCH 3/5] user-exec: Delete now-unused hppa and m68k cpu_signal_handler() code

2016-06-14 Thread Peter Maydell
Now that configure blocks attempts to build user-mode code on hppa and m68k hosts, we can delete the cpu_signal_handler() implementations for those architectures. Signed-off-by: Peter Maydell --- user-exec.c | 60 1 file changed, 60 de

[Qemu-devel] [PATCH 2/5] configure: Don't allow user-only targets for unknown CPU architectures

2016-06-14 Thread Peter Maydell
For the user-only targets, we need to know something about the host CPU architecture even if we are using the TCI interpreter rather than TCG. (In particular user-exec.c has code for handling signals that needs to know about that host's context structures.) Specifically forbid building the user-on

[Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-14 Thread Prasanna Kalever
Hello, Can someone please help me in tracking the QAPI changes for union discriminator addition, the below [1] gluster related patches are awaiting from very long, because of the dependency with QMP design changes. These patches [1] also stuck changes in libvirt/vdsm. It will be really helpful fo

Re: [Qemu-devel] [PATCH 1/5] configure: Don't override ARCH=unknown if enabling TCI

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:52, Peter Maydell a écrit : > At the moment if configure finds an unknown CPU it will set > ARCH to 'unknown', and then later either bail out or set it > to 'tci' (depending on whether the user passed configure the > --enable-tcg-interpreter switch). This is unnecessarily > con

Re: [Qemu-devel] [PATCH 1/5] configure: Don't override ARCH=unknown if enabling TCI

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:57, Laurent Vivier a écrit : > > > Le 14/06/2016 à 11:52, Peter Maydell a écrit : >> At the moment if configure finds an unknown CPU it will set >> ARCH to 'unknown', and then later either bail out or set it >> to 'tci' (depending on whether the user passed configure the >> -

[Qemu-devel] [PATCH 0/5] linux-user: fix dependencies, forbid unknown host arch

2016-06-14 Thread Peter Maydell
The main aim of this patchset is to fix a problem with the dependency handling of the hostdep.h files added in in commit 4d330cee37a21. It needs to be applied before we add any more architecture-specific hostdep.h files (ie before rth's patchset for ppc/arm/i386/s390/etc). The intent of commit 4d

Re: [Qemu-devel] [PATCH 4/5] user-exec: Remove unused code for OSX hosts

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:52, Peter Maydell a écrit : > Since we dropped darwin-user support many years ago, the code in > user-exec to support hosts which define __APPLE__ is unused; delete it. > > Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier > --- > user-exec.c | 47 +

Re: [Qemu-devel] [PATCH 2/5] configure: Don't allow user-only targets for unknown CPU architectures

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:52, Peter Maydell a écrit : > For the user-only targets, we need to know something about the host CPU > architecture even if we are using the TCI interpreter rather than TCG. > (In particular user-exec.c has code for handling signals that needs > to know about that host's conte

[Qemu-devel] [Bug 1592336] [NEW] mouse is defunct when grabbed

2016-06-14 Thread Jirislaby
Public bug reported: I run qemu as follows: qemu-system-x86_64 -machine accel=kvm -k en-us -smp 4 -m 2371 -usb \ -device virtio-rng-pci \ -drive file=/home/new/suse-fact.img,format=raw,discard=unmap,if=none,id=hd -device virtio-scsi-pci,id=scsi -device scsi-hd,drive=hd \ -soundhw hda \ -

[Qemu-devel] [PATCH 4/5] user-exec: Remove unused code for OSX hosts

2016-06-14 Thread Peter Maydell
Since we dropped darwin-user support many years ago, the code in user-exec to support hosts which define __APPLE__ is unused; delete it. Signed-off-by: Peter Maydell --- user-exec.c | 47 +-- 1 file changed, 1 insertion(+), 46 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/5] linux-user: Create a hostdep.h for each host architecture

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:52, Peter Maydell a écrit : > In commit 4d330cee37a21 a new hostdep.h file was added, with the intent > that host architectures which needed one could provide it, and the > build system would automatically fall back to a generic version if > there was no version for the host ar

[Qemu-devel] [PATCH 2/7] doc: sync help descriprion for --trace with man for qemu.1

2016-06-14 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 1f9b390..f28abd3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file

2016-06-14 Thread Denis V. Lunev
This text will be included to qemu-nbd/qemu-img mans in the next patches. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 3 ++- qemu-option-trace.texi | 25 + qemu-options.hx| 27

Re: [Qemu-devel] [PATCH 3/5] user-exec: Delete now-unused hppa and m68k cpu_signal_handler() code

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:52, Peter Maydell a écrit : > Now that configure blocks attempts to build user-mode code on hppa > and m68k hosts, we can delete the cpu_signal_handler() implementations > for those architectures. > > Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier > --- > user-e

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-14 Thread Denis V. Lunev
On 06/08/2016 02:23 PM, Kevin Wolf wrote: Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: From: Vladimir Sementsov-Ogievskiy Acquire aio context before run command, this is mandatory for unit tests. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Kevin W

[Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c

2016-06-14 Thread Denis V. Lunev
The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo B

[Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing

2016-06-14 Thread Denis V. Lunev
This is necessary to enable creation of common qemu-img options which will be specified before command. The patch also enables '-V' alias to '--version' (exactly like in other block utilities) and documents this change. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo Bonzini CC

Re: [Qemu-devel] [PATCH v2 1/3] linux-user: add rtnetlink(7) support

2016-06-14 Thread Laurent Vivier
Le 14/06/2016 à 11:34, Peter Maydell a écrit : > On 22 May 2016 at 17:56, Laurent Vivier wrote: >> rtnetlink is needed to use iproute package (ip addr, ip route) >> and dhcp client. >> >> +static abi_long target_to_host_for_each_nlmsg(struct nlmsghdr *nlh, >> +

[Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd

2016-06-14 Thread Denis V. Lunev
Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 2 +- qemu-

[Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io

2016-06-14 Thread Denis V. Lunev
Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-io.c | 17 + 1 file changed, 13 insertions

[Qemu-devel] [PATCH v6 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

2016-06-14 Thread Denis V. Lunev
Changes from v5: - added missed hunk into patch #7 Changes from v4: - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 - moved @findex from qemu-option-trace.texi Changes from v3: - fixed difference in help/man for qemu-img/qemu-nbd - created separate .texi to contain

[Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img

2016-06-14 Thread Denis V. Lunev
The command will work this way: qemu-img --trace qcow2* create -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev Suggested by: Daniel P. Berrange CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- Makefile | 2 +- qemu-img.c| 18 +- qemu-img

[Qemu-devel] [PATCH 1/1] cpu: report hyperv feature words through qom

2016-06-14 Thread Denis V. Lunev
From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required featured words are set in cpuid leaf 4003 through qom request. Currently qemu does not report hyperv feature words which pr

Re: [Qemu-devel] [PATCH v5 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img

2016-06-14 Thread Denis V. Lunev
On 06/14/2016 12:16 PM, Denis V. Lunev wrote: Changes from v4: - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 - moved @findex from qemu-option-trace.texi Changes from v3: - fixed difference in help/man for qemu-img/qemu-nbd - created separate .texi to contain tra

[Qemu-devel] [Bug 1592351] [NEW] mouse pointer offset with gtk, gl=on

2016-06-14 Thread Jirislaby
Public bug reported: When I turn gl=on for -display gtk, some Y offset is added to the mouse pointer coordinates. That is, when I click on an icon, an icon _above_ the one I clicked triggers. Using xev, it seems to be offset of 10-12 pixels. It happens with all ps/2 mouse, -usbdevice mouse and -

[Qemu-devel] [PATCH v2 0/2] Report format specific info for LUKS block driver

2016-06-14 Thread Daniel P. Berrange
This is a followup to: v1: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg01723.html The 'qemu-img info' tool has ability to print format specific information, eg with qcow2 it reports two extra items: $ qemu-img info ~/VirtualMachines/demo.qcow2 image: /home/berrange/VirtualMach

[Qemu-devel] [PATCH v2 2/2] block: export LUKS specific data to qemu-img info

2016-06-14 Thread Daniel P. Berrange
The qemu-img info command has the ability to expose format specific metadata about volumes. Wire up this facility for the LUKS driver to report on cipher configuration and key slot usage. $ qemu-img info ~/VirtualMachines/demo.luks image: /home/berrange/VirtualMachines/demo.luks file f

[Qemu-devel] [PATCH v2 1/2] crypto: add support for querying parameters for block encryption

2016-06-14 Thread Daniel P. Berrange
When creating new block encryption volumes, we accept a list of parameters to control the formatting process. It is useful to be able to query what those parameters were for existing block devices. Add a qcrypto_block_get_info() method which returns a QCryptoBlockInfo instance to report this data.

[Qemu-devel] [PATCH] ppc / sparc: Add a tester for checking whether OpenBIOS runs successfully

2016-06-14 Thread Thomas Huth
Since the mac99 and g3beige PowerPC machines recently broke without being noticed, it would be good to have a tester for "make check" that detects such issues immediately. A simple way to test the firmware of these machines is to use the "-prom-env" parameter of QEMU. This parameter can be used to

Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type

2016-06-14 Thread Vijay Kilari
On Mon, Jun 13, 2016 at 3:40 PM, Peter Maydell wrote: > On 13 June 2016 at 10:43, Peter Maydell wrote: >> On 13 June 2016 at 10:08, wrote: >>> +/* >>> + * Holds TARGET_AARCH_64_PAGE_BITS or TARGET_ARM_PAGE_BITS >>> + * based on the the cpu type emulated at runtime. >>> + */ >>> +static uint32_t

  1   2   3   4   5   6   >