Re: [Qemu-devel] [PATCH v4 2/2] trace: [all] Add "guest_mem_before" event

2016-06-09 Thread Richard Henderson
On 05/27/2016 09:01 AM, Lluís Vilanova wrote: -void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg idx, TCGMemOp memop) +static inline void do_tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg idx, + TCGMemOp memop) { memop = tcg_canonicalize_

[Qemu-devel] [PATCH v5 00/15] Add clone visitor

2016-06-09 Thread Eric Blake
[First half of v4 00/28 Add qapi-to-JSON and clone visitors: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg03220.html] No hard prerequisites; applies to master Soft prerequisites (for valgrind to be happy with all touched tests): My fix for memleak in range.h (still waiting for other r

[Qemu-devel] [PATCH v5 14/15] sockets: Use new QAPI cloning

2016-06-09 Thread Eric Blake
Rather than rolling our own clone via an expensive conversion in and back out of QObject, use the new clone visitor. Signed-off-by: Eric Blake --- v5: no change v4: completely drop qapi_copy_SocketAddress(), rebase to earlier changes v3: new patch --- include/io/task.h| 2 +- inclu

[Qemu-devel] [PATCH v5 03/15] qapi: Add parameter to visit_end_*

2016-06-09 Thread Eric Blake
Rather than making the dealloc visitor track of stack of pointers remembered during visit_start_* in order to free them during visit_end_*, it's a lot easier to just make all callers pass the same pointer to visit_end_*. The generated code has access to the same pointer, while all other users are

[Qemu-devel] [PATCH v5 13/15] qapi: Add new clone visitor

2016-06-09 Thread Eric Blake
We have a couple places in the code base that want to deep-clone one QAPI object into another, and they were resorting to serializing the struct out to QObject then reparsing it. A much more efficient version can be done by adding a new clone visitor. Since cloning is still relatively uncommon, e

[Qemu-devel] [PATCH v5 08/15] string-output-visitor: Favor new visit_free() function

2016-06-09 Thread Eric Blake
Now that we have a polymorphic visit_free(), we no longer need string_output_visitor_cleanup(); however, we still need to expose the subtype for string_output_get_string(). Signed-off-by: Eric Blake --- v5: blank line after declaration v4: new patch --- include/qapi/string-output-visitor.h | 1

[Qemu-devel] [PATCH v5 05/15] opts-visitor: Favor new visit_free() function

2016-06-09 Thread Eric Blake
Now that we have a polymorphic visit_free(), we no longer need opts_visitor_cleanup(); which in turn means we no longer need to return a subtype from opts_visitor_new() nor a public upcast function. Signed-off-by: Eric Blake --- v5: blank line after declaration v4: new patch --- include/qapi/op

[Qemu-devel] [PATCH v5 02/15] qemu-img: Don't leak errors when outputting JSON

2016-06-09 Thread Eric Blake
If our JSON output ever encounters an error, we would just silently leak the error object. Instead, assert that our usage won't fail. Signed-off-by: Eric Blake --- v5: commit message wording tweak v4: new patch (split out from v3 14/18) --- qemu-img.c | 10 -- 1 file changed, 4 inserti

[Qemu-devel] [PATCH v5 10/15] tests: Clean up test-string-output-visitor

2016-06-09 Thread Eric Blake
Use &error_abort and error_free_or_abort() in more places, use the generated qapi_free_intList() instead of open-coding it, reduce the scope of some variables, avoid code duplication during test setup with visitor_output_setup_internal(), and copy the visitor_reset() concept from the qmp-output tes

[Qemu-devel] [PATCH v5 12/15] qapi: Add new visit_complete() function

2016-06-09 Thread Eric Blake
Making each output visitor provide its own output collection function was the only remaining reason for exposing visitor sub-types to the rest of the code base. Add a polymorphic visit_complete() function which is a no-op for input visitors, and which populates an opaque pointer for output visitor

[Qemu-devel] [PATCH v1 13/40] trace: split out trace events for hw/misc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/misc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/misc/trace-events | 77 trace-events | 51 -- 3 files ch

[Qemu-devel] [PATCH v1 08/40] trace: split out trace events for hw/char/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/char/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/char/trace-events | 74 trace-events | 48 -- 3 files ch

[Qemu-devel] [PATCH v5 01/15] qapi: Improve use of qmp/types.h

2016-06-09 Thread Eric Blake
'qjson.h' is not a QObject subtype; include this file directly in .c files that are using it, rather than abusing qmp/types.h for that purpose. Meanwhile, for files that include a list of individual QObject subtypes, it's easier to just use qmp/types.h for that purpose. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v1 03/40] trace: split out trace events for crypto/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the crypto/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + crypto/trace-events | 44 trace-events| 18 -- 3 files changed, 45 insertions(+), 18

[Qemu-devel] [PATCH v1 11/40] trace: split out trace events for hw/virtio/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/virtio/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/virtio/trace-events | 41 + trace-events | 14 -- 3 files changed, 42 insertions(+)

[Qemu-devel] [PATCH v5 04/15] qapi: Add new visit_free() function

2016-06-09 Thread Eric Blake
Making each visitor provide its own (awkwardly-named) FOO_cleanup() is unusual, when we can instead have a polymorphic visit_free() interface. Over the next few patches, we can use the polymorphic functions to eliminate the need for a FOO_get_visitor() function for accessing specific visitor funct

[Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-09 Thread Daniel P. Berrange
Switch make rules over to use trace-events-all as the master trace events input file. Add rule that will construct trace-events-all from $(trace-events-y). Signed-off-by: Daniel P. Berrange --- .gitignore | 1 + Makefile| 2 +- Makefile.objs | 4 Makefile.targe

[Qemu-devel] [PATCH v1 12/40] trace: split out trace events for hw/audio/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/audio/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/audio/trace-events | 44 trace-events | 18 -- 3 files changed, 45 insertions

[Qemu-devel] [PATCH v1 33/40] trace: split out trace events for ui/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the ui/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + trace-events| 47 - ui/trace-events | 73 + 3 files changed, 74 in

[Qemu-devel] [PATCH v5 11/15] tests: Factor out common code in qapi output tests

2016-06-09 Thread Eric Blake
Create a new visitor_get() function to capture common actions taken in collecting output from an output visitor, to make it easier to refactor the output visitors in a later patch. Signed-off-by: Eric Blake --- v5: split out independent cleanups v4: new patch --- tests/test-qmp-output-visitor.c

[Qemu-devel] [PATCH v1 04/40] trace: split out trace events for io/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the io/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + io/trace-events | 88 + trace-events| 62 3 files changed, 89

[Qemu-devel] [PATCH v1 16/40] trace: split out trace events for hw/nvram/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/nvram/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/nvram/trace-events | 35 +++ trace-events | 9 - 3 files changed, 36 insertions(+), 9 deletions(-

[Qemu-devel] [PATCH v1 06/40] trace: split out trace events for block/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the block/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + block/trace-events | 141 + trace-events | 115 --- 3 fil

[Qemu-devel] [PATCH v1 18/40] trace: split out trace events for hw/input/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/input/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/input/trace-events | 50 ++ trace-events | 24 3 files changed, 5

[Qemu-devel] [PATCH v5 07/15] qmp-input-visitor: Favor new visit_free() function

2016-06-09 Thread Eric Blake
Now that we have a polymorphic visit_free(), we no longer need qmp_input_visitor_cleanup(); which in turn means we no longer need to return a subtype from qmp_input_visitor_new() nor a public upcast function. Generated code changes to qmp-marshal.c look like: |@@ -52,11 +52,10 @@ void qmp_marshal

[Qemu-devel] [PATCH v1 05/40] trace: split out trace events for migration/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the migration/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + migration/trace-events | 233 + trace-events | 207 --

[Qemu-devel] [PATCH v1 29/40] trace: split out trace events for hw/vfio/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/vfio/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/vfio/trace-events | 141 +++ trace-events | 116 --

[Qemu-devel] [PATCH v5 15/15] replay: Use new QAPI cloning

2016-06-09 Thread Eric Blake
Rather than rolling our own clone via an expensive conversion in and back out of QObject, use the new clone visitor. Signed-off-by: Eric Blake --- v5: no change v4: rebase to earlier changes v3: new patch --- replay/replay-input.c | 30 +++--- 1 file changed, 3 insertion

[Qemu-devel] [PATCH v1 09/40] trace: split out trace events for hw/intc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/intc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/intc/trace-events | 107 +++ trace-events | 81 -- 3 fi

[Qemu-devel] [PATCH v5 06/15] string-input-visitor: Favor new visit_free() function

2016-06-09 Thread Eric Blake
Now that we have a polymorphic visit_free(), we no longer need string_input_visitor_cleanup(); which in turn means we no longer need to return a subtype from string_input_visitor_new() nor a public upcast function. Signed-off-by: Eric Blake --- v5: blank line after declaration v4: new patch ---

[Qemu-devel] [PATCH v1 28/40] trace: split out trace events for hw/s390x/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/s390x/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/s390x/trace-events | 39 +++ trace-events | 13 - 3 files changed, 40 insertions(+), 13 de

[Qemu-devel] [PATCH v5 09/15] qmp-output-visitor: Favor new visit_free() function

2016-06-09 Thread Eric Blake
Now that we have a polymorphic visit_free(), we no longer need qmp_output_visitor_cleanup(); however, we still need to expose the subtype for qmp_output_get_qobject(). Signed-off-by: Eric Blake --- v5: blank line after declaration v4: new patch --- include/qapi/qmp-output-visitor.h | 1 - bloc

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: [...] > + > +if (local_err) { > +error_propagate(errp, local_err); > } error_propagate() already ignores local_err==NULL so you don't need to check it first. I can change this while applying the patch, if you're OK.

[Qemu-devel] [PATCH v1 20/40] trace: split out trace events for hw/dma/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/dma/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/dma/trace-events | 57 + trace-events| 31 - 3 files changed, 5

[Qemu-devel] [PATCH v1 30/40] trace: split out trace events for hw/acpi/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/acpi/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/acpi/trace-events | 43 +++ trace-events | 17 - 3 files changed, 44 insertions(+), 1

[Qemu-devel] [PATCH v1 00/40] Split up the trace-events file

2016-06-09 Thread Daniel P. Berrange
To quote Peter today: pm215: "trace-events: causing merge conflicts since 2010" There's really no good reason why we should continue to suffer from this. Even if the trace tool generator can't yet generate multiple independant output files, we can still trivially have multiple independant input

[Qemu-devel] [PATCH v1 17/40] trace: split out trace events for hw/display/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/display/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/display/trace-events | 147 trace-events| 121 ---

[Qemu-devel] [PATCH v5 1/2] exec: [tcg] Track which vCPU is performing translation and execution

2016-06-09 Thread Lluís Vilanova
Information is tracked inside the TCGContext structure, and later used by tracing events with the 'tcg' and 'vcpu' properties. The 'cpu' field is used to check tracing of translation-time events ("*_trans"). The 'tcg_env' field is used to pass it to execution-time events ("*_exec"). Signed-off-by

[Qemu-devel] [PATCH v1 31/40] trace: split out trace events for hw/arm/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/arm/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/arm/trace-events | 29 + trace-events| 3 --- 3 files changed, 30 insertions(+), 3 deletions(-) create mode 10064

[Qemu-devel] [PATCH v1 02/40] trace: split out trace events for util/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the util/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + trace-events | 12 util/trace-events | 38 ++ 3 files changed, 39 insertions(+), 12 deletions(-) create

[Qemu-devel] [PATCH v1 22/40] trace: split out trace events for hw/sd/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/sd/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/sd/trace-events | 30 ++ trace-events | 4 3 files changed, 31 insertions(+), 4 deletions(-) create mode 100644

[Qemu-devel] [PATCH v1 38/40] trace: split out trace events for target-ppc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the target-ppc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + target-ppc/trace-events | 30 ++ trace-events| 4 3 files changed, 31 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v2 3/6] [trivial] trace: Cosmetic changes on fast-path tracing

2016-06-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- trace/control-internal.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/trace/control-internal.h b/trace/control-internal.h index c78a45a..d1f99e3 100644 --- a/trace/control-internal.h +++ b/trace/cont

[Qemu-devel] [PATCH v1 07/40] trace: split out trace events for hw/block/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/block/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/block/trace-events | 42 ++ trace-events | 16 3 files changed, 43 insertions(+),

[Qemu-devel] [PATCH v1 32/40] trace: split out trace events for hw/alpha/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/alpha/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/alpha/trace-events | 29 + trace-events | 3 --- 3 files changed, 30 insertions(+), 3 deletions(-) create mo

[Qemu-devel] [PATCH v2 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-06-09 Thread Lluís Vilanova
Each vCPU gets a 'trace_dstate' bitmap to control the per-vCPU dynamic tracing state of events with the 'vcpu' property. Signed-off-by: Lluís Vilanova --- Makefile.objs|1 + bsd-user/main.c |2 + include/qom/cpu.h|6 linux-user/main.c|2 +

[Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Igor Mammedov
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v1: - fix error handling in of +-feat, Igor Mammedov - rebase on top of "target-i386: Remove xlevel & hv-spinlocks option fixups" v2: - move er

[Qemu-devel] [PATCH v1 39/40] trace: split out trace events for qom/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the qom/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + qom/trace-events | 30 ++ trace-events | 4 3 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 qom/trac

[Qemu-devel] [PATCH v2 5/6] arm: virt: parse cpu_model only once

2016-06-09 Thread Igor Mammedov
considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only

[Qemu-devel] [PATCH v1 19/40] trace: split out trace events for hw/timer/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/timer/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/timer/trace-events | 76 +++ trace-events | 50 - 3 files

Re: [Qemu-devel] [PATCH v7 1/3] loader: Allow ELF loader to auto-detect the ELF arch

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > If the caller didn't specify an architecture for the ELF machine > the load_elf() function will auto detect it based on the ELF file. > > Signed-off-by: Alistair Francis > --- > V7: > - Fix typo > > hw/core/loader.c | 10 ++ > 1 file ch

Re: [Qemu-devel] [PATCH v7 3/3] docs: Add a generic loader explanation document

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > V6: > - Fixup documentation > V4: > - Re-write to be more comprehensive > > docs/generic-loader.txt | 54 > + > 1 file changed, 54 insertions(+) > create

[Qemu-devel] [PATCH v2 6/6] pc: parse cpu features only once

2016-06-09 Thread Igor Mammedov
considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only

Re: [Qemu-devel] [PATCH v4 2/2] trace: [all] Add "guest_mem_before" event

2016-06-09 Thread Lluís Vilanova
Richard Henderson writes: > On 05/27/2016 09:01 AM, Lluís Vilanova wrote: >> -void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg idx, TCGMemOp >> memop) >> +static inline void do_tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg >> idx, >> + TCGMe

[Qemu-devel] [PATCH v2 2/6] target-i386: print obsolete warnings if +-features are used

2016-06-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 947cf18..3f886a5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1979,9 +1979,15 @@ static void x86_cpu_parse_featurestr(CPUState *cs

Re: [Qemu-devel] [PATCH] hw/timer: Add value matching support to aspeed_timer

2016-06-09 Thread Peter Maydell
On 27 May 2016 at 06:08, Andrew Jeffery wrote: > Value matching allows Linux to boot with CONFIG_NO_HZ_IDLE=y on the > palmetto-bmc machine. Two match registers are provided for each timer. > > Signed-off-by: Andrew Jeffery > --- > > The change pulls out ptimer in favour of the regular timer infr

Re: [Qemu-devel] [PATCH v7 2/3] generic-loader: Add a generic loader

2016-06-09 Thread Peter Maydell
On 25 May 2016 at 19:49, Alistair Francis wrote: > Add a generic loader to QEMU which can be used to load images or set > memory values. > > Signed-off-by: Alistair Francis > --- > V7: > - Rebase > V6: > - Add error checking > V5: > - Rebase > V4: > - Allow the loader to work with every archi

[Qemu-devel] [PATCH v1 26/40] trace: split out trace events for hw/ppc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/ppc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/ppc/trace-events | 64 + trace-events| 38 --- 3 files changed,

[Qemu-devel] [PATCH v2 5/6] trace: Conditionally trace events based on their per-vCPU state

2016-06-09 Thread Lluís Vilanova
Events with the 'vcpu' property are conditionally emitted according to their per-vCPU state. Other events are emitted normally based on their global tracing state. Note that the per-vCPU condition check applies to all tracing backends. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-06-09 Thread Jason J. Herne
On 06/09/2016 12:31 PM, Stefan Hajnoczi wrote: On Mon, May 23, 2016 at 7:54 PM, Jason J. Herne wrote: Libvirt migration command: virsh migrate --live --persistent --copy-storage-all --migrate-disks vdb kvm1 qemu+ssh://dev1/system I guess that this is the same scenario as a manual drive_mirror

Re: [Qemu-devel] [PATCH V9 0/9] Xilinx DisplayPort.

2016-06-09 Thread Peter Maydell
On 7 June 2016 at 22:39, Alistair Francis wrote: > On Tue, Jun 7, 2016 at 1:30 PM, wrote: >> From: KONRAD Frederic > > Hey Peter, > > These are all reviewed by Xilinx, this is ready to merge from our point of > view. This series breaks 'make check'. Specifically, the patch "i2c: implement bro

[Qemu-devel] [PATCH v1 27/40] trace: split out trace events for hw/pci/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/pci/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/pci/trace-events | 34 ++ trace-events| 8 3 files changed, 35 insertions(+), 8 deletions(-) create

Re: [Qemu-devel] [PATCH 00/17] some ARM platform QOM'ify work

2016-06-09 Thread Peter Maydell
On 7 June 2016 at 11:34, xiaoqiang zhao wrote: > This patch series QOM'ify ARM platform related devices. > Where we drop the sysbus init function if possible and use > instance_init and DeviceClass::realize function. > > xiaoqiang zhao (17): > hw/i2c: QOM'ify bitbang_i2c.c > hw/i2c: QOM'ify ex

[Qemu-devel] [PATCH] Makefile: Fix tag file generation targets

2016-06-09 Thread Sergey Fedorov
From: Sergey Fedorov "ctags" produces a file named "tags", not "ctags". It doesn't look reasonable to use phony target name as a file name to remove. Just use exact file names to remove in "ctags" and "TAGS" target receipts. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov --- Make

Re: [Qemu-devel] [PATCH 2/5] hw/arm/virt: set is_default

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Make the latest machine type (currently only one) the > default. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index a0d35d0826590..09afbafde025d 100644

[Qemu-devel] [PATCH v1 25/40] trace: split out trace events for hw/9pfs/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/9pfs/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/9pfs/trace-events | 72 trace-events | 46 - 3 files cha

Re: [Qemu-devel] [PATCH 1/5] hw/arm/virt: separate versioned type-init code

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Rename machvirt_info (which is specifically for 2.6 TypeInfo) > to machvirt_2_6_info, and separate the type registration of the > abstract machine type from the versioned type. > > Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell thanks -- P

[Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Peter Maydell
Should be fixed by http://patchwork.ozlabs.org/patch/633105/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1590336 Title: qemu-arm does not reject vrintz on non-v8 cpu Status in QEMU: New Bug d

[Qemu-devel] [PATCH v1 10/40] trace: split out trace events for hw/net/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/net/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/net/trace-events | 297 trace-events| 271 ---

Re: [Qemu-devel] [PATCH v6 01/13] bitops: Add MAKE_64BIT_MASK macro

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > Add a macro that creates a 64bit value which has length number of ones > shifted acrros by the value of shift. "across" > > Signed-off-by: Alistair Francis > Reviewed-by: Alex Bennée > --- > V5: > - Re-write to a 64-bit mask instead of ONES()

[Qemu-devel] [PATCH v2 0/6] cpus: make "-cpu cpux, features" global properties

2016-06-09 Thread Igor Mammedov
Changelog: since v1: - rebase on top of x86-next tree, which shaves off already applied several patches and fixed deps on wrong tree (v1 was against my device_add_cpu tree) - add TODO comments - set cpu_globals_initialized = true early - move error_propagate() to the end of

[Qemu-devel] [PATCH v1 14/40] trace: split out trace events for hw/usb/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/usb/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/usb/trace-events | 293 trace-events| 267 ---

[Qemu-devel] [PATCH v1 15/40] trace: split out trace events for hw/scsi/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/scsi/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/scsi/trace-events | 229 +++ trace-events | 203

[Qemu-devel] [PATCH v2 3/6] target-sparc: cpu: use sparc_cpu_parse_features() directly

2016-06-09 Thread Igor Mammedov
make SPARC target use sparc_cpu_parse_features() directly so it won't get in the way of switching other propertified targets to handling features as global properties. Signed-off-by: Igor Mammedov --- SPARC target could be switched to features properties later but that would need quite a bit of r

Re: [Qemu-devel] [PATCH 3/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Use DEFINE_VIRT_MACHINE to generate versioned machine type info. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 40 +++- > 1 file changed, 23 insertions(+), 17 deletions(-) Checkpatch complains about a l

[Qemu-devel] [PATCH v1 34/40] trace: split out trace events for audio/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the audio/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + audio/trace-events | 42 ++ trace-events | 16 3 files changed, 43 insertions(+), 16 deletion

[Qemu-devel] [PATCH v5 0/2] trace: Add event for vCPU memory accesses

2016-06-09 Thread Lluís Vilanova
This series adds an event to track information related to memory accesses performed by the guest CPUs ("guest_mem_before"). A future series might extend this to contain the physical address and memory value (e.g., "guest_mem_after"). Signed-off-by: Lluís Vilanova --- Changes in v5 -

Re: [Qemu-devel] [QEMU RFC PATCH v4 0/6] migration: ensure hotplug and migration work together

2016-06-09 Thread Jianjun Duan
Yesterday I got delivery failure for all the recipients with email address at @redhat.com. Can somebody from Red Hat confirm if you have received the patches? If not I will resend them. Thanks, Jianjun On 06/08/2016 04:06 PM, Jianjun Duan wrote: > v4: - Introduce a way to set customized instance_

[Qemu-devel] [PATCH v1 24/40] trace: split out trace events for hw/i386/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/i386/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + hw/i386/trace-events | 37 + trace-events | 11 --- 3 files changed, 38 insertions(+), 11 deletions(

[Qemu-devel] [PATCH v1 40/40] trace: split out trace events for linux-user/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the linux-user/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + linux-user/trace-events | 37 + trace-events| 11 --- 3 files changed, 38 insertions(+), 1

[Qemu-devel] [PATCH v1 21/40] trace: split out trace events for hw/sparc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/sparc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/sparc/trace-events | 36 trace-events | 10 -- 3 files changed, 37 insertions(+), 10 deletion

[Qemu-devel] [PATCH v1 36/40] trace: split out trace events for target-sparc/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the target-sparc/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + target-sparc/trace-events | 53 +++ trace-events | 27 3 fil

[Qemu-devel] [PATCHv20/6] trace: Per-vCPU tracing states

2016-06-09 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: Show vCPU info in guest code events" Provides per-vCPU dynamic controls of the tracing state of events with the "vcpu" property. A later series proposes an optimization where tracing code can be elided for dynamically disabled events (it uses multiple v

[Qemu-devel] [PATCH v5 2/2] trace: [all] Add "guest_mem_before" event

2016-06-09 Thread Lluís Vilanova
The event is described in "trace-events". Note that the "MO_AMASK" flag is not traced, since it does not seem to affect the visible semantics of instructions. Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h | 25 include/exec/cpu_ldst_useronly_templ

[Qemu-devel] [PATCH v2 4/6] cpu: use CPUClass->parse_features() as convertor to global properties

2016-06-09 Thread Igor Mammedov
Currently CPUClass->parse_features() is used to parse -cpu features string and set properties on created CPU instances. But considering that features specified by -cpu apply to every created CPU instance, it doesn't make sence to parse the same features string for every CPU created. It also makes

Re: [Qemu-devel] [PATCH v6 03/13] register: Add Memory API glue

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > Add memory io handlers that glue the register API to the memory API. > Just translation functions at this stage. Although it does allow for > devices to be created without all-in-one mmio r/w handlers. > > This patch also adds the RegisterInfoArra

[Qemu-devel] [PATCH] target-arm: Don't permit ARMv8-only Neon insns on ARMv7

2016-06-09 Thread Peter Maydell
The Neon instructions VCVTA, VCVTM, VCVTN, VCVTP, VRINTA, VRINTM, VRINTN, VRINTP, VRINTX, and VRINTZ were only introduced with ARMv8, so they need a guard to make them UNDEF if the CPU only supports ARMv7. (We got this right for all the other new-in-v8 insns, but forgot it for these Neon 2-reg-misc

[Qemu-devel] [PATCH v1 23/40] trace: split out trace events for hw/isa/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the hw/isa/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + hw/isa/trace-events | 34 ++ trace-events| 8 3 files changed, 35 insertions(+), 8 deletions(-) create

Re: [Qemu-devel] [PATCH 4/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST

2016-06-09 Thread Peter Maydell
On 8 June 2016 at 19:24, Andrew Jones wrote: > Create two variants of DEFINE_VIRT_MACHINE. One, just called > DEFINE_VIRT_MACHINE, that does not set properties that only > the latest machine type should have, and another that does. > This will hopefully reduce potential for errors when adding > ne

[Qemu-devel] [PATCH v2 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-06-09 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- monitor.c |4 +- qapi/trace.json | 20 ++-- qmp-commands.hx | 18 ++- trace/qmp.c | 143 --- 4 files changed, 147 insertions(+), 38 deletions(-) diff --g

Re: [Qemu-devel] [PATCH v1 00/40] Split up the trace-events file

2016-06-09 Thread Lluís Vilanova
Daniel P Berrange writes: > To quote Peter today: > pm215: "trace-events: causing merge conflicts since 2010" [...] Silly note. You can skip the documentation header on all trace-events file and just reference a single global one (is /trace-events gonna survive for some events?). Otherwise it's

Re: [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check to realize time

2016-06-09 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 05:16:45PM +0200, Igor Mammedov wrote: > it will allow to drop custom cpu_x86_init() and use > cpu_generic_init() insteadi, reducing cpu_x86_create() > to a simple 3-liner. > > Signed-off-by: Igor Mammedov > Eduardo Habkost This triggers an assert when trying to use -cpu

[Qemu-devel] [PATCH v1 35/40] trace: split out trace events for net/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the net/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs| 1 + net/trace-events | 29 + trace-events | 3 --- 3 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 net/trace-

[Qemu-devel] [PATCH v2 1/6] trace: Identify events with the 'vcpu' property

2016-06-09 Thread Lluís Vilanova
A new event attribute 'cpu_id' is added to have a separate ID space ('TRACE_VCPU_*') for all events with the 'vcpu' property. These are later used to identify which events are enabled on each vCPU. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c

[Qemu-devel] [PATCH v2 2/6] disas: Remove unused macro '_'

2016-06-09 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova --- disas/alpha.c |6 +++--- disas/arm.c |2 +- disas/i386.c|2 +- dis

[Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2016-06-09 Thread Eduardo Habkost
error_propagate() already ignores local_err==NULL, so there's no need to check it before calling. Done using the following Coccinelle patch: @@ identifier L; expression E; @@ -if (L) { error_propagate(E, L); -} Signed-off-by: Eduardo Habkost --- block.c | 20 ++

[Qemu-devel] [PATCH v1 37/40] trace: split out trace events for target-s390x/ directory

2016-06-09 Thread Daniel P. Berrange
Move all trace-events for files in the target-s390x/ directory to their own file. Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + target-s390x/trace-events | 46 ++ trace-events | 21 - 3 files c

Re: [Qemu-devel] [PATCH] target-arm: Don't permit ARMv8-only Neon insns on ARMv7

2016-06-09 Thread Christophe Lyon
On 9 June 2016 at 19:15, Peter Maydell wrote: > The Neon instructions VCVTA, VCVTM, VCVTN, VCVTP, VRINTA, VRINTM, > VRINTN, VRINTP, VRINTX, and VRINTZ were only introduced with ARMv8, > so they need a guard to make them UNDEF if the CPU only supports ARMv7. > (We got this right for all the other n

Re: [Qemu-devel] [PATCH v6 02/13] register: Add Register API

2016-06-09 Thread Peter Maydell
On 12 May 2016 at 23:45, Alistair Francis wrote: > This API provides some encapsulation of registers and factors our some "out" > common functionality to common code. Bits of device state (usually MMIO > registers), often have all sorts of access restrictions and semantics spurious comma > ass

[Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Christophe Lyon
I confirm your patch does fix the problem. You may still want to fix the disassembler such that it dumps the right instruction, but that would be a separate fix. Thanks for your quick support. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

<    1   2   3   >