Re: [Qemu-devel] Question about vNVDIMM file format

2016-05-18 Thread Xiao Guangrong
Hi Rich, On 05/17/2016 02:25 AM, Richard W.M. Jones wrote: On Mon, May 16, 2016 at 09:53:36AM -0700, Stefan Hajnoczi wrote: On Mon, May 16, 2016 at 04:04:01PM +0100, Richard W.M. Jones wrote: I'm playing with ext4 and DAX. I'm using: -object memory-backend-file,id=mem1,share,mem-path=/v

[Qemu-devel] [PATCH v4 2/6] pc: Postpone SMBIOS table installation to post machine init

2016-05-18 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c inde

[Qemu-devel] [PATCH v4 1/6] ipmi: rework the fwinfo to be fetched from the interface

2016-05-18 Thread minyard
From: Corey Minyard Instead of scanning IPMI devices from a fwinfo list, allow the fwinfo to be fetched from the IPMI interface class. Then the code looking for IPMI fwinfo can scan devices on a bus and look for ones that implement the IPMI class. This will let the ACPI scope be defined by the c

[Qemu-devel] [PATCH v4 0/6] Add IPMI to firmware tables

2016-05-18 Thread minyard
Ok, I think I have this right now. This changes the code to scan the busses for the IPMI devices. I was kind of stuck on the SMBIOS, since there's really no bus to scan there, but for that I just scan the entire system. This required some rework of the IPMI code to fetch the firmware info from a

[Qemu-devel] [PATCH v4 3/6] smbios: Move table build tools into an include file.

2016-05-18 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

[Qemu-devel] [PATCH v4 4/6] ipmi: Add SMBIOS table entry

2016-05-18 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- hw/smbios/Makefile.objs | 2 + hw/smbios/ipmi.c | 104 +++ hw/smbios/noipmi.c | 14 +++ hw/smbios/smbios.c

[Qemu-devel] [PATCH v4 5/6] acpi: Add IPMI table entries

2016-05-18 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

Re: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-18 Thread Sebastian Färber
> > There's no need to reset the librados state, so connections to the > cluster can stick around. I'm a bit unclear on the bdrv_reopen_* > functions though - what is their intended use and semantics? My motivation for implementing this basic reopen support is getting active block commit in qemu

Re: [Qemu-devel] [PATCH] block/iscsi: allow caching of the allocation map

2016-05-18 Thread Fam Zheng
On Tue, 05/17 15:59, Peter Lieven wrote: > until now the allocation map was used only as a hint if a cluster > is allocated or not. If a block was not allocated (or Qemu had > no info about the allocation status) a get_block_status call was > issued to check the allocation status and possibly avoid

Re: [Qemu-devel] [PATCH 0/2] block/nfs: add support for libnfs pagecache

2016-05-18 Thread Fam Zheng
On Tue, 05/17 16:11, Peter Lieven wrote: > this adds support for the upcoming libnfs cachepage to Qemu. > While at it neglect to use readahead if cache.direct is on. > > Peter Lieven (2): > block/nfs: add support for libnfs pagecache > block/nfs: refuse readahead if cache.direct is on > > bl

Re: [Qemu-devel] [PATCH] Fix QEMU PPC e500v1 efscmp* instructions

2016-05-18 Thread Imran, Talha
With more information at hand with the reference manual from Freescale http://cache.nxp.com/files/32bit/doc/ref_manual/SPEPEM.pdf , I was able to revisit my patch and figure out what is actually going on. Before applying any patch, efscmp* instructions in QEMU set crD values as (0b0100 << 2) = 0b1

Re: [Qemu-devel] [PATCH 30/33] acpi: cpuhp: add cpu._OST handling

2016-05-18 Thread Igor Mammedov
On Tue, 17 May 2016 09:29:15 -0600 Eric Blake wrote: > On 05/17/2016 08:43 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/cpu.c | 83 > > +++ > > hw/acpi/ich9.c| 3 ++ > > hw/acpi/piix4.c | 3

Re: [Qemu-devel] Question about vNVDIMM file format

2016-05-18 Thread Zhang, Haozhong
Hi Richard, On 05/18/16 15:04, Xiao Guangrong wrote: [..] > >There are a few possible problems / questions I have: > > > >(a) How necessary is the ACPI dependency? We disable ACPI because it > >is quite slow, adding something like 150-200ms to the boot process > >(every millisecond counts for us!

Re: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-18 Thread Kevin Wolf
Am 17.05.2016 um 20:48 hat Josh Durgin geschrieben: > On 05/17/2016 03:03 AM, Sebastian Färber wrote: > >Hi Kevin, > > > >>A correct reopen implementation must consider all options and flags that > >>.bdrv_open() looked at. > >> > >>The options are okay, as both "filename" and "password-secret" are

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Cornelia Huck
On Mon, 16 May 2016 17:35:32 +0200 Paolo Bonzini wrote: > I compiled this on x64 Linux (all patches) and 32-bit ARM > Linux, and I will compile it on Win32 before sending a pull > request. I would appreciate people compile-testing it on s390 > and PPC. The changes are available in the git repos

[Qemu-devel] [PATCH 1/3] blockdev-backup: Don't move target AioContext if it's attached

2016-05-18 Thread Fam Zheng
If the BDS is attached, it will want to stay on the AioContext where its BlockBackend is. Don't call bdrv_set_aio_context in this case. Signed-off-by: Fam Zheng --- blockdev.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 1892b8e..

[Qemu-devel] [PATCH 0/3] Drop virtio-{blk,scsi} op blockers

2016-05-18 Thread Fam Zheng
We are ready to get rid of dataplane's op blockers altogether. Most operations are already unblocked in virtio-blk, and those remained for virtio-scsi only because we haven't got around to add counterpart unblocking code. The first patch fixes an existing bug with blockdev-backup. Then the op bloc

[Qemu-devel] [PATCH 2/3] virtio-blk: Remove op blocker for dataplane

2016-05-18 Thread Fam Zheng
Block layer is prepared to unspecialize dataplane, an evidence is this almost complete list of unblocked operations. It has all types except two (actually three if DATAPLANE itself counts but blockdev.c makes sure attaching twice is not possible): MIRROR_TARGET and BACKUP_TARGET. blockdev-mirror r

[Qemu-devel] [PATCH 3/3] virtio-scsi: Remove op blocker for dataplane

2016-05-18 Thread Fam Zheng
The previous patch dropped all op blockers from virtio-blk data plane. The situation of virtio-scsi is exactly the same it can drop them too. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi.c | 62 - include/hw/virtio/virtio-scsi.h | 11

Re: [Qemu-devel] [PATCH 0/3] Drop virtio-{blk,scsi} op blockers

2016-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 04:24:07PM +0800, Fam Zheng wrote: > We are ready to get rid of dataplane's op blockers altogether. Most operations > are already unblocked in virtio-blk, and those remained for virtio-scsi only > because we haven't got around to add counterpart unblocking code. > > The fir

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi: Remove op blocker for dataplane

2016-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 04:24:10PM +0800, Fam Zheng wrote: > The previous patch dropped all op blockers from virtio-blk data plane. > The situation of virtio-scsi is exactly the same it can drop them too. > > Signed-off-by: Fam Zheng Acked-by: Michael S. Tsirkin > --- > hw/scsi/virtio-scsi.c

Re: [Qemu-devel] [PATCH 2/3] virtio-blk: Remove op blocker for dataplane

2016-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 04:24:09PM +0800, Fam Zheng wrote: > Block layer is prepared to unspecialize dataplane, an evidence is this > almost complete list of unblocked operations. It has all types except > two (actually three if DATAPLANE itself counts but blockdev.c makes sure > attaching twice is

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Cornelia Huck
On Wed, 18 May 2016 10:21:47 +0200 Cornelia Huck wrote: > On Mon, 16 May 2016 17:35:32 +0200 > Paolo Bonzini wrote: > > > I compiled this on x64 Linux (all patches) and 32-bit ARM > > Linux, and I will compile it on Win32 before sending a pull > > request. I would appreciate people compile-tes

Re: [Qemu-devel] [kvm-unit-tests PATCH 00/10] arm/arm64: add gic framework

2016-05-18 Thread Christoffer Dall
Hi Drew, Thanks for doing this. I'm happy to see some tests for the GIC. I've been pondering with how to write unit tests for all the MMIO implementations. If you have some thoughts on how that could be easily fitted into this framework, that would probably be a good place to do it ;) -Christo

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-05-18 Thread Changlong Xie
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: +static void replication_close(BlockDriverState *bs) +{ +BDRVReplicationState *s = bs->opaque; + +if (s->mode == REPLICATION_MODE_SECONDARY) { +g_free(s->top_id); +}

[Qemu-devel] [RFC] backup: export interfaces for extra serialization

2016-05-18 Thread Changlong Xie
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: Did you run stress tests where the primary is writing to the disk while the secondary reads from the same sectors? I thought about this some more and I'm wondering about the following scenario: NBD writes to secondary_disk and the guest reads from

[Qemu-devel] [PATCH] coccinelle: add g_assert_cmp* to macro file

2016-05-18 Thread Paolo Bonzini
This helps applying semantic patches to unit tests. Signed-off-by: Paolo Bonzini --- scripts/cocci-macro-file.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h index eceb4be..9f2e72e 100644 --- a/scripts/cocci-macro-file.h +++ b/s

Re: [Qemu-devel] Regression with windows 7 VMs and VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

2016-05-18 Thread Denis V. Lunev
On 05/15/2016 02:13 AM, Thomas Lamprecht wrote: Hi all, I recently ran into Problems when trying to install some Windows VMs this was after an update to QEMU 2.5.1.1, the VM shows Windows loading files for the installation, then the "Starting Windows" screen appears here it hangs and never conti

Re: [Qemu-devel] [PULL 09/20] s390x/ipl: Remove redundant usage of gr7

2016-05-18 Thread Paolo Bonzini
On 17/05/2016 16:46, Cornelia Huck wrote: > From: Alexander Yarygin > > We don't need to pass device address for pc-bios using gr7 anymore as > the pcbios completely relies on diag308 now, so we can remove it from > qemu. devno, ssid and cssid are migrated but the value was never reused, > so w

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 10:59, Cornelia Huck wrote: >> > >> > That's on one of my s390x systems; on another one (where I don't test), >> > it builds. But something's wrong :) > Ah, that's because the functioning one used --disable-kvm. > > Should the call to kvm_check_extension() be moved to target-s390x

Re: [Qemu-devel] [PULL 09/20] s390x/ipl: Remove redundant usage of gr7

2016-05-18 Thread Christian Borntraeger
On 05/18/2016 12:01 PM, Paolo Bonzini wrote: > > > On 17/05/2016 16:46, Cornelia Huck wrote: >> From: Alexander Yarygin >> >> We don't need to pass device address for pc-bios using gr7 anymore as >> the pcbios completely relies on diag308 now, so we can remove it from >> qemu. devno, ssid and cs

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Some more write_zeroes tests

2016-05-18 Thread Kevin Wolf
Am 17.05.2016 um 22:35 hat Eric Blake geschrieben: > No test of crossing a cluster boundary at this point? I would probably do: > > $QEMU_IO -c "write -z 27k 2k" "$TEST_IMG" | _filter_qemu_io > > then check that the map shows an allocation starting at 24k for 8192 bytes > What you have looks fi

[Qemu-devel] [PATCH] migration: regain control of images when migration fails to complete

2016-05-18 Thread Greg Kurz
We currently have an error path during migration that can cause the source QEMU to abort: migration_thread() migration_completion() runstate_is_running() > true if guest is running bdrv_inactivate_all() > inactivate images qemu_savevm_state_complete_pr

Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

2016-05-18 Thread xiaoqiang zhao
在 2016年05月17日 20:51, Paolo Bonzini 写道: I'm sorry, this is not enough. You need to learn how to test this device. CRIS images are available athttp://wiki.qemu.org/Testing. You have not added a replacement for the call to qemu_char_get_next_serial(). The board code in hw/cris/axis_dev88.c need

Re: [Qemu-devel] [PULL 09/20] s390x/ipl: Remove redundant usage of gr7

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 12:09, Christian Borntraeger wrote: >> > This probably breaks reboot after migration from 2.6. >> > >> > If that's fine, all the better. :) > Our BIOS is in RAM and usually overwritten by the guest. > On reboot this is reloaded from whatever BIOS is on the target, > so migration sh

[Qemu-devel] [PATCH v3 0/2] trace: Add event for vCPU memory accesses

2016-05-18 Thread Lluís Vilanova
This series adds an event to track information related to memory accesses performed by the guest CPUs ("guest_mem_before"). A future series might extend this to contain the physical address and memory value (e.g., "guest_mem_after"). Signed-off-by: Lluís Vilanova --- Changes in v3 -

[Qemu-devel] [PATCH v3 1/2] exec: [tcg] Track which vCPU is performing translation and execution

2016-05-18 Thread Lluís Vilanova
Information is tracked inside the TCGContext structure, and later used by tracing events with the 'tcg' and 'vcpu' properties. The 'cpu' field is used to check tracing of translation-time events ("*_trans"). The 'tcg_env' field is used to pass it to execution-time events ("*_exec"). Signed-off-by

[Qemu-devel] [PATCH v3 2/2] trace: [all] Add "guest_mem_before" event

2016-05-18 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h | 25 include/exec/cpu_ldst_useronly_template.h | 22 ++ tcg/tcg-op.c | 32 ++-- trace-events | 22 +++

Re: [Qemu-devel] Question about vNVDIMM file format

2016-05-18 Thread Richard W.M. Jones
On Wed, May 18, 2016 at 03:04:52PM +0800, Xiao Guangrong wrote: > On 05/17/2016 02:25 AM, Richard W.M. Jones wrote: > >(a) How necessary is the ACPI dependency? We disable ACPI because it > >is quite slow, adding something like 150-200ms to the boot process > >(every millisecond counts for us!).

[Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE

2016-05-18 Thread Cao jin
Replace tab with 4 spaces; brace the indented statement. Signed-off-by: Cao jin --- hw/nvram/fw_cfg.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 999f480..826181a 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 10:59, Cornelia Huck wrote: >> That's on one of my s390x systems; on another one (where I don't test), >> it builds. But something's wrong :) > > Ah, that's because the functioning one used --disable-kvm. > > Should the call to kvm_check_extension() be moved to target-s390x/kvm.c?

Re: [Qemu-devel] [PATCH] migration: regain control of images when migration fails to complete

2016-05-18 Thread Dr. David Alan Gilbert
* Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > We currently have an error path during migration that can cause > the source QEMU to abort: Hmm, wasn't there something similar recently, sorry I can't remember the details, but cc'ing some block people who might remember. Dave > > migration_threa

[Qemu-devel] [PATCH v3 0/4] migration: skip scanning and migrating ram pages released by virtio-balloon driver.

2016-05-18 Thread Jitendra Kolhe
While measuring live migration performance for qemu/kvm guest, it was observed that the qemu doesn’t maintain any intelligence for the guest ram pages released by the guest balloon driver and treat such pages as any other normal guest ram pages. This has direct impact on overall migration time for

[Qemu-devel] [PATCH v3 1/4] balloon: maintain bitmap for pages released by guest balloon driver.

2016-05-18 Thread Jitendra Kolhe
The ramblock for balloon bitmap is initialized as part of virtio-balloon device realize itself. The bitmap represents entire guest ram memory till last_ram_offset(). The bit in the balloon bitmap represents a page of size (1UL << VIRTIO_BALLOON_PFN_SHIFT). Guest ram pages returned by virtio-balloon

[Qemu-devel] [PATCH v3 2/4] balloon: add balloon bitmap migration capability and setup bitmap migration status.

2016-05-18 Thread Jitendra Kolhe
Add “skip-balloon” migration capability. The balloon bitmap optimization will get disabled as a part of migration setup if the “skip-balloon” migration capability is disabled or if the guest balloon driver has not set VIRTIO_BALLOON_F_MUST_TELL_HOST feature. In case the balloon bitmap optimization

[Qemu-devel] [PATCH v3 3/4] balloon: reset balloon bitmap ramblock size on source and target.

2016-05-18 Thread Jitendra Kolhe
In case migration fails or gets aborted, the source guest will continue to run on source host in which case the balloon bitmap ramblock is resized back to maximum if it is set to zero as a part of migration setup. On target the balloon bitmap size is always resized to maximum after migration. Sign

[Qemu-devel] [PATCH v3 4/4] migration: skip scanning and migrating ram pages released by virtio-balloon driver.

2016-05-18 Thread Jitendra Kolhe
During live migration, byte offset within memory region of the start of a dirty page is checked against the balloon bitmap, if the bit is set in the balloon bitmap, the corresponding ram page will be excluded from scanning and sending header information during migration. In case TARGET_PAGE_BITS >

[Qemu-devel] [PATCH v3 4/4] migration: skip scanning and migrating ram pages released by virtio-balloon driver.

2016-05-18 Thread Jitendra Kolhe
During live migration, byte offset within memory region of the start of a dirty page is checked against the balloon bitmap, if the bit is set in the balloon bitmap, the corresponding ram page will be excluded from scanning and sending header information during migration. In case TARGET_PAGE_BITS >

Re: [Qemu-devel] [PATCH] migration: regain control of images when migration fails to complete

2016-05-18 Thread Kevin Wolf
Am 18.05.2016 um 13:13 hat Dr. David Alan Gilbert geschrieben: > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > We currently have an error path during migration that can cause > > the source QEMU to abort: > > Hmm, wasn't there something similar recently, sorry I can't remember the > details,

Re: [Qemu-devel] Regression with windows 7 VMs and VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

2016-05-18 Thread Gerd Hoffmann
Hi, > we have (may be) similar stuff with win2k3. With these patches merged > we have win2k3 crashed with the bug check below. > We are using qemu-kvm-2.3.0-31.2.13 > > There are a bunch of VMs in this state and semi-reliable reproduction. Does https://patchwork.ozlabs.org/patch/622965/ help?

[Qemu-devel] [PULL 08/13] ipack: Update e-mail address

2016-05-18 Thread Michael Tokarev
From: Alberto Garcia I'm not really using the old one anymore. Signed-off-by: Alberto Garcia Signed-off-by: Michael Tokarev --- hw/char/ipoctal232.c | 2 +- hw/ipack/ipack.c | 2 +- hw/ipack/tpci200.c | 2 +- include/hw/ipack/ipack.h | 2 +- 4 files changed, 4 insertions(+),

[Qemu-devel] [PULL 13/13] Fix some typos found by codespell

2016-05-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- audio/mixeng.c | 2 +- audio/ossaudio.c| 2 +- contrib/ivshmem-server/ivshmem-server.h | 2 +- docs/specs/rocker.txt

Re: [Qemu-devel] [PATCH v2] qdev: Clean up around properties

2016-05-18 Thread Cao jin
Hi Michael, I guess you missed this one:) On 05/11/2016 04:24 PM, Cao jin wrote: For mjt`s information: it has been Reviewed-by: Markus Armbruster On 05/10/2016 08:52 PM, Paolo Bonzini wrote: Just comments, so Cc: qemu-triv...@nongnu.org On 17/04/2016 09:45, Cao jin wrote: include: 1.

Re: [Qemu-devel] [PATCH] pci_register_bar: cleanup

2016-05-18 Thread Cao jin
I guess maybe this one is more suitable for trivial. mjt, could you help to pick it up? On 05/18/2016 09:38 AM, Cao jin wrote: ping? On 05/12/2016 09:39 AM, Cao jin wrote: Hi, Since it has been Reviewed-by: Paolo Bonzini for almost 2 months, is it forgot to put into upstream? On

[Qemu-devel] [PULL 05/13] Fix typo in variable name (found and fixed by codespell)

2016-05-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Fam Zheng Signed-off-by: Michael Tokarev --- scripts/dump-guest-memory.py | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/scripts/dump-guest-memory.py b/scripts/dump-gu

[Qemu-devel] [PULL 11/13] smbios: fix typo

2016-05-18 Thread Michael Tokarev
From: Cao jin The spec says: "on paragraph (16-byte) boundaries" Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- include/hw/smbios/smbios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h index 76ccf70..ba36

[Qemu-devel] [PULL 00/13] Trivial patches for 2016-05-18

2016-05-18 Thread Michael Tokarev
This is first pull request in quite a while. Accumulating only relatively old stuff which hasn't been applied to other trees. More to follow. Please consider applying. Thanks, /mjt The following changes since commit a257c741491ff1c3c192d13a89c136dd6401c54d: Merge remote-tracking branch 're

[Qemu-devel] [PULL 04/13] vl: fix comment about when parsing cpu definitions

2016-05-18 Thread Michael Tokarev
From: Wei Jiangang machine->init() was replaced with machine_class->init() in 958db90cd54823c33345000c995453a8c9b7a005. Signed-off-by: Wei Jiangang Signed-off-by: Michael Tokarev --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 5fd22cb..e789ce7 10

[Qemu-devel] [PULL 06/13] qdict: fix unbounded stack warning for qdict_array_entries

2016-05-18 Thread Michael Tokarev
From: Peter Xu Here we use one g_strdup_printf() to replace the two stack allocated array, considering it's more convenient, safe, and as long as it's called rarely only when quorum device opens. This will remove the unbound stack warning when compiling with "-Wstack-usage=100". Reviewed-by:

Re: [Qemu-devel] [PATCH] pci_register_bar: cleanup

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 14:16, Cao jin wrote: > I guess maybe this one is more suitable for trivial. No, it's not trivial. I guess it missed soft freeze. Michael Tsirkin will pick it up. Thanks, Paolo > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index e67664d..f0f41dc 100644 > --- a/hw/pci/

[Qemu-devel] [PULL 12/13] 9p: drop unused declaration from coth.h

2016-05-18 Thread Michael Tokarev
From: Greg Kurz Commit "ebac1202c95a virtio-9p: use QEMU thread pool" dropped function v9fs_init_worker_threads. Signed-off-by: Greg Kurz Signed-off-by: Michael Tokarev --- hw/9pfs/coth.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/coth.h b/hw/9pfs/coth.h index 209fc6a..a911cbb

Re: [Qemu-devel] [PATCH] pci_register_bar: cleanup

2016-05-18 Thread Cao jin
Ok, I see. Thanks Paolo Cao. On 05/18/2016 08:17 PM, Paolo Bonzini wrote: On 18/05/2016 14:16, Cao jin wrote: I guess maybe this one is more suitable for trivial. No, it's not trivial. I guess it missed soft freeze. Michael Tsirkin will pick it up. Thanks, Paolo diff --git a/hw/pci/pci

[Qemu-devel] [PULL 03/13] loader: fix potential memory leak

2016-05-18 Thread Michael Tokarev
From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- hw/core/loader.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index c049957..53e0e41 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -914,10 +914,16 @@ int rom_add_f

[Qemu-devel] [PULL 10/13] accel: make configure_accelerator return void

2016-05-18 Thread Michael Tokarev
From: Wei Jiangang Return the negated value of accel_initialised is meaningless, and the caller vl doesn't check it. Signed-off-by: Wei Jiangang Signed-off-by: Michael Tokarev --- accel.c| 4 +--- include/sysemu/accel.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 01/13] s390: remove misleading comment

2016-05-18 Thread Michael Tokarev
The comment talks about a non-ELF object while the example gives ELF object. Signed-off-by: Michael Tokarev --- hw/s390x/ipl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 5786b5e..e6bf7cf 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl

[Qemu-devel] [PULL 02/13] remove comment for nonexistent structure member

2016-05-18 Thread Michael Tokarev
From: Cao jin Signed-off-by: Cao jin Signed-off-by: Michael Tokarev --- include/sysemu/hostmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/sysemu/hostmem.h b/include/sysemu/hostmem.h index a19801d..4d6617e 100644 --- a/include/sysemu/hostmem.h +++ b/include/sysemu/hostmem.h @@

Re: [Qemu-devel] [PATCH] migration: regain control of images when migration fails to complete

2016-05-18 Thread Greg Kurz
On Wed, 18 May 2016 13:42:08 +0200 Kevin Wolf wrote: > Am 18.05.2016 um 13:13 hat Dr. David Alan Gilbert geschrieben: > > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > > We currently have an error path during migration that can cause > > > the source QEMU to abort: > > > > Hmm, wasn't th

[Qemu-devel] [PULL 09/13] configure: Use uniform description for devel packages

2016-05-18 Thread Michael Tokarev
From: Stefan Weil As all other devel packages are written in the form "name devel", use this form for libcap devel and libattr devel, too. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/co

Re: [Qemu-devel] [PATCH] pci_register_bar: cleanup

2016-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 02:17:20PM +0200, Paolo Bonzini wrote: > On 18/05/2016 14:16, Cao jin wrote: > > I guess maybe this one is more suitable for trivial. > > No, it's not trivial. I guess it missed soft freeze. Michael Tsirkin > will pick it up. > > Thanks, > > Paolo Yes - please repost w

[Qemu-devel] [PULL 07/13] util: fix comment typos

2016-05-18 Thread Michael Tokarev
From: Wei Jiangang Signed-off-by: Wei Jiangang Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- util/buffer.c | 4 ++-- util/qemu-sockets.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/util/buffer.c b/util/buffer.c index a6118bf..33e94d1 100644 --- a/

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some more write_zeroes tests

2016-05-18 Thread Kevin Wolf
This covers some more write_zeroes cases which are relevant for the recent qcow2 optimisations that check the allocation status of the backing file for partial cluster write_zeroes requests. This needs to be separate from 034 because we can only support qcow2 in this test case for multiple reasons

[Qemu-devel] [PATCH trivial] s390x/virtio-ccw: fix spelling

2016-05-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/s390x/virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index d51642d..5e77b27 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -1475,7 +1475,7 @@ static void virtio

[Qemu-devel] [PATCH trivial] hw/ipmi: fix spelling

2016-05-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/ipmi/ipmi_bmc_extern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index fe12112..157879e 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -190,7 +190,7 @@

Re: [Qemu-devel] [PATCH trivial] s390x/virtio-ccw: fix spelling

2016-05-18 Thread Christian Borntraeger
On 05/18/2016 02:43 PM, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > hw/s390x/virtio-ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index d51642d..5e77b27 100644 > --- a/hw/s390x/virtio-ccw.c > +++

[Qemu-devel] [PATCH trivial] docs: "specify" spell fix

2016-05-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- docs/qapi-code-gen.txt | 2 +- qemu-options.hx| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index d7d6987..eff2075 100644 --- a/docs/qapi-code-gen.txt +++ b/docs/qapi-code-gen.txt

Re: [Qemu-devel] [Qemu-block] [PATCH] block: clarify error message for qmp-eject

2016-05-18 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 05/18 07:36, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Tue, 05/17 20:42, John Snow wrote: >> >> If you use HMP's eject but the CDROM tray is locked, you may get a >> >> confusing error message informing you that the "tray isn't open." >> >> >> >> As t

Re: [Qemu-devel] [PATCH trivial] s390x/virtio-ccw: fix spelling

2016-05-18 Thread Cornelia Huck
On Wed, 18 May 2016 15:43:17 +0300 Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > hw/s390x/virtio-ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index d51642d..5e77b27 100644 > --- a/hw/s390x/virti

[Qemu-devel] [PATCH trivial 1/2] qga: spelling fix

2016-05-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qga/commands-posix.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 2ae3725..f0057f5 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1242,8 +1242,8 @@ int64_t qm

[Qemu-devel] [PATCH trivial 2/2] fsdev: spelling fix

2016-05-18 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- fsdev/virtfs-proxy-helper.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi index 6eb2d50..f4cbb60 100644 --- a/fsdev/virtfs-proxy-helper.texi +++ b/fsdev/virtfs-proxy-helper.

Re: [Qemu-devel] [PATCH 2/2] block/nfs: refuse readahead if cache.direct is on

2016-05-18 Thread Jeff Cody
On Tue, May 17, 2016 at 04:11:55PM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/nfs.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/block/nfs.c b/block/nfs.c > index 975510f..8b73a35 100644 > --- a/block/nfs.c > +++ b/block/nfs.c > @@ -331,6 +331,11 @@ s

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread Jeff Cody
On Wed, May 18, 2016 at 01:53:27PM +0800, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. > > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Fa

[Qemu-devel] [PATCH v2] migration: regain control of images when migration fails to complete

2016-05-18 Thread Greg Kurz
We currently have an error path during migration that can cause the source QEMU to abort: migration_thread() migration_completion() runstate_is_running() > true if guest is running bdrv_inactivate_all() > inactivate images qemu_savevm_state_complete_pr

[Qemu-devel] [Bug 1477538] Re: Windows QEMU Guest Agent VSS Provider service stops during qemu backup

2016-05-18 Thread Joop Martens
Hello Ravi, You can find it at the Fedora Windows VirtIO Drivers wiki page that I provided in my first post. Here's a direct link to the latest 7.2.1 guest agent: https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-qemu-ga/qemu-ga-win-7.2.1-1/ -- You received this bug notif

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Cornelia Huck
On Wed, 18 May 2016 13:11:08 +0200 Paolo Bonzini wrote: > On 18/05/2016 10:59, Cornelia Huck wrote: > >> That's on one of my s390x systems; on another one (where I don't test), > >> it builds. But something's wrong :) > > > > Ah, that's because the functioning one used --disable-kvm. > > > > Sh

[Qemu-devel] [PATCH v2] sysemu: support up to 1024 vCPUs

2016-05-18 Thread Greg Kurz
Some PowerPC systems can already provide more than 255 hardware threads. Igor also posted a patch recently, to increase the the maxcpus limit to 288 for x86 targets. This patch bumps the limit to 1024: - 1024 is already the limit for PowerPC KVM in several distros - it has no visible overhead in t

Re: [Qemu-devel] [PATCH V2 0/4] pci: better support for 64-bit MMIO allocation

2016-05-18 Thread Igor Mammedov
On Sun, 15 May 2016 22:23:30 +0300 Marcel Apfelbaum wrote: > Hi, > > First two patches allocate (max_reserved_ram - max_addr_cpu_addressable) > range for PCI hotplug > (for PC Machines) instead of the previous 64-bit PCI window that included only > the ranges allocated by the firmware. > > The

[Qemu-devel] [Bug 1477538] Re: Windows QEMU Guest Agent VSS Provider service stops during qemu backup

2016-05-18 Thread Joop Martens
Hello Ravi, Just noticed that you are looking for a RHEL 7 guest agent instead of the Windows version. Not sure what the latest Linux release is but the standard repos currently provide release 2.3.0. If you need a newer version you need to search for a 3th party rpm or compile it yourself from

Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 15:46, Cornelia Huck wrote: > On Wed, 18 May 2016 13:11:08 +0200 > Paolo Bonzini wrote: > >> On 18/05/2016 10:59, Cornelia Huck wrote: That's on one of my s390x systems; on another one (where I don't test), it builds. But something's wrong :) >>> >>> Ah, that's because t

Re: [Qemu-devel] [PATCH v5 07/18] qemu-thread: add simple test-and-set spinlock

2016-05-18 Thread Sergey Fedorov
On 18/05/16 02:18, Emilio G. Cota wrote: > On Tue, May 17, 2016 at 23:35:57 +0300, Sergey Fedorov wrote: >> On 17/05/16 22:38, Emilio G. Cota wrote: >>> On Tue, May 17, 2016 at 20:13:24 +0300, Sergey Fedorov wrote: On 14/05/16 06:34, Emilio G. Cota wrote: >> (snip) > +while (atomic

Re: [Qemu-devel] [PATCH V2 2/4] pci: reserve 64 bit MMIO range for PCI hotplug

2016-05-18 Thread Igor Mammedov
On Sun, 15 May 2016 22:23:32 +0300 Marcel Apfelbaum wrote: > Using the firmware assigned MMIO ranges for 64-bit PCI window > leads to zero space for hot-plugging PCI devices over 4G. > > PC machines can use the whole CPU addressable range after > the space reserved for memory-hotplug. > > Signe

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread John Snow
On 05/18/2016 01:53 AM, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. > Tch, mea culpa. > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. > > Cc: qemu-sta...@nongnu.org > Signed-off-by:

Re: [Qemu-devel] [PATCH trivial] docs: "specify" spell fix

2016-05-18 Thread Eric Blake
On 05/18/2016 06:48 AM, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev > --- > docs/qapi-code-gen.txt | 2 +- > qemu-options.hx| 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt vir

Re: [Qemu-devel] [PATCH v5 07/18] qemu-thread: add simple test-and-set spinlock

2016-05-18 Thread Paolo Bonzini
On 18/05/2016 15:59, Sergey Fedorov wrote: > > But actually (cf include/qemu/atomic.h) we can have: > > #define atomic_read(ptr) \ > ({\ > QEMU_BUILD_BUG_ON(sizeof(*ptr) > sizeof(void *)); \ >

Re: [Qemu-devel] [PATCH V2 2/4] pci: reserve 64 bit MMIO range for PCI hotplug

2016-05-18 Thread Marcel Apfelbaum
On 05/16/2016 05:19 PM, Igor Mammedov wrote: On Mon, 16 May 2016 13:14:51 +0300 Marcel Apfelbaum wrote: On 05/16/2016 11:24 AM, Igor Mammedov wrote: On Sun, 15 May 2016 22:23:32 +0300 Marcel Apfelbaum wrote: Using the firmware assigned MMIO ranges for 64-bit PCI window leads to zero space

Re: [Qemu-devel] [PATCH V2 0/4] pci: better support for 64-bit MMIO allocation

2016-05-18 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 03:53:08PM +0200, Igor Mammedov wrote: > On Sun, 15 May 2016 22:23:30 +0300 > Marcel Apfelbaum wrote: > > > Hi, > > > > First two patches allocate (max_reserved_ram - max_addr_cpu_addressable) > > range for PCI hotplug > > (for PC Machines) instead of the previous 64-bit

Re: [Qemu-devel] [PATCH V2 2/4] pci: reserve 64 bit MMIO range for PCI hotplug

2016-05-18 Thread Laszlo Ersek
On 05/18/16 15:59, Igor Mammedov wrote: > On Sun, 15 May 2016 22:23:32 +0300 > Marcel Apfelbaum wrote: > >> Using the firmware assigned MMIO ranges for 64-bit PCI window >> leads to zero space for hot-plugging PCI devices over 4G. >> >> PC machines can use the whole CPU addressable range after >>

Re: [Qemu-devel] [PATCH V2 2/4] pci: reserve 64 bit MMIO range for PCI hotplug

2016-05-18 Thread Marcel Apfelbaum
On 05/18/2016 04:59 PM, Igor Mammedov wrote: On Sun, 15 May 2016 22:23:32 +0300 Marcel Apfelbaum wrote: Using the firmware assigned MMIO ranges for 64-bit PCI window leads to zero space for hot-plugging PCI devices over 4G. PC machines can use the whole CPU addressable range after the space r

Re: [Qemu-devel] [PATCH v5 07/18] qemu-thread: add simple test-and-set spinlock

2016-05-18 Thread Sergey Fedorov
On 18/05/16 17:05, Paolo Bonzini wrote: > > On 18/05/2016 15:59, Sergey Fedorov wrote: >> But actually (cf include/qemu/atomic.h) we can have: >> >> #define atomic_read(ptr) \ >> ({\ >> QEMU_BUILD_BUG_O

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some more write_zeroes tests

2016-05-18 Thread Eric Blake
On 05/18/2016 06:27 AM, Kevin Wolf wrote: > This covers some more write_zeroes cases which are relevant for the > recent qcow2 optimisations that check the allocation status of the > backing file for partial cluster write_zeroes requests. > > This needs to be separate from 034 because we can only

Re: [Qemu-devel] [PATCH V2 4/4] hw/apci: handle 64-bit MMIO regions correctly

2016-05-18 Thread Michael S. Tsirkin
On Sun, May 15, 2016 at 10:23:34PM +0300, Marcel Apfelbaum wrote: > In build_crs(), the calculation and merging of the ranges already happens > in 64-bit, but the entry boundaries are silently truncated to 32-bit in the > call to aml_dword_memory(). Fix it by handling the 64-bit MMIO ranges > sepa

  1   2   3   >