[Qemu-devel] [PATCH v14 1/3] Add new block driver interface to add/delete a BDS's child

2016-05-10 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c

[Qemu-devel] [PATCH v14 0/3] qapi: child add/delete support

2016-05-10 Thread Changlong Xie
ChangLog: v14: 1. Address commets from Betro and Max p2: introduce bdrv_drained_begin/end, rename last_index, remove redundant assert codes v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and rewri

[Qemu-devel] [PATCH v14 3/3] qmp: add monitor command to add/remove a child

2016-05-10 Thread Changlong Xie
From: Wen Congyang The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Sig

[Qemu-devel] [PATCH v14 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-10 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78 +-- include/block/block.h | 4 +++ 3 files chang

Re: [Qemu-devel] [PATCH v14 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-10 Thread Alberto Garcia
On Tue 10 May 2016 09:36:38 AM CEST, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-10 Thread Jike Song
On 05/05/2016 05:27 PM, Tian, Kevin wrote: >> From: Song, Jike >> >> IIUC, an api-only domain is a VFIO domain *without* underlying IOMMU >> hardware. It just, as you said in another mail, "rather than >> programming them into an IOMMU for a device, it simply stores the >> translations for use by l

Re: [Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 10:50:40AM +0800, Fam Zheng wrote: > +int qemu_lock_fd(int fd, int64_t start, int64_t len, bool readonly) I find this new API to be very unintuitive. When I was reading the other code in block/raw-posix.c I had to refer back to this file to find out what all the integers m

Re: [Qemu-devel] [RFC 0/4] APIC, IOMMU, KVM: add x2APIC interface

2016-05-10 Thread Peter Xu
On Mon, May 09, 2016 at 04:35:24PM +0200, Radim Krčmář wrote: > 2016-05-09 13:36+0800, Peter Xu: > > On Fri, May 06, 2016 at 10:53:44PM +0200, Radim Krčmář wrote: > >> This series bases on Peter's IR v6 and depends on patches that were just > >> posted to kvm-list, "[RFC 0/9] KVM: x86: break the xA

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-10 Thread Peter Maydell
On 10 May 2016 at 01:16, Alistair Francis wrote: > It is actually a u-boot problem. I originally just assumed it was a > Linux problem, but it happens before u-boot hands off to Linux. OK, that makes sense. u-boot tends to be a bit lower level and less hardware-agnostic. I just wanted to check it

Re: [Qemu-devel] [PATCH v6 24/26] kvm-irqchip: i386: add hook for add/remove virq

2016-05-10 Thread Peter Xu
On Thu, May 05, 2016 at 11:25:59AM +0800, Peter Xu wrote: > Adding two hooks to be notified when adding/removing msi routes. On x86 > platform, one list is maintained for all existing msi routes. > > Signed-off-by: Peter Xu > --- > include/sysemu/kvm.h | 6 ++ > kvm-all.c| 2 ++

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 10:50:32AM +0800, Fam Zheng wrote: > v4: Don't lock RO image. [Rich] I applied this on top of HEAD and added some debugging messages to block/raw-posix.c so I can see when files are being opened and locked, and it does appear to do the right thing for read-only and write-ex

Re: [Qemu-devel] [PATCH v16A 17/24] qmp: Don't reuse qmp visitor after grabbing output

2016-05-10 Thread Markus Armbruster
Eric Blake writes: > The testsuite was the only client that attempted to reuse a > QmpOutputVisitor for a second visit after encountering an > error and/or calling qmp_output_get_qobject() on a first > visit. The next patch is about to tighten the semantics to > be one-shot usage of the visitor,

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional fields: "runnable" and "unavailable-features". >> > "runnable" will tell if

Re: [Qemu-devel] [PATCH RFC 0/3] qdev: order devices by priority before creating them

2016-05-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > This series aims to allow more devices to be used with '-device' > by sorting the devices based on a predefined creation order flag > before creating them. > > Devices like IOMMU need to be created before others, so they can leverage > the DeviceCreationPriority flag in

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Jiri Denemark
On Tue, May 10, 2016 at 10:23:16 +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > >> > Extend query-cpu-definitions schema to allow it to return two new > >> > optional

Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 05:23 hat Fam Zheng geschrieben: > On Fri, 05/06 09:49, Kevin Wolf wrote: > > Am 05.05.2016 um 02:32 hat Fam Zheng geschrieben: > > > On Wed, 05/04 12:12, Kevin Wolf wrote: > > > > Am 19.04.2016 um 03:42 hat Fam Zheng geschrieben: > > > > > Currently we only inactivate the top BDS.

Re: [Qemu-devel] [PATCH v5 0/6] qemu-io: UI enhancements

2016-05-10 Thread Kevin Wolf
Am 09.05.2016 um 20:23 hat Max Reitz geschrieben: > On 08.05.2016 05:35, Eric Blake wrote: > > On 05/07/2016 09:16 PM, Eric Blake wrote: > >> While working on NBD, I found myself cursing the qemu-io UI for > >> not letting me test various scenarios, particularly after fixing > >> NBD to serve at by

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-10 Thread Kevin Wolf
Am 09.05.2016 um 17:52 hat Alberto Garcia geschrieben: > On Wed 13 Apr 2016 10:33:08 AM CEST, Changlong Xie wrote: > > Sorry for the late reply! > > The patch looks good, I have some additional comments on top of what Max > Wrote, nothing serious though :) > > > @@ -67,6 +68,9 @@ typedef struct

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 08:19:38AM +0200, Petr Tesarik wrote: > On Mon, 9 May 2016 17:32:50 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, May 09, 2016 at 06:20:22PM +0200, Petr Tesarik wrote: > > > On Mon, 9 May 2016 17:13:07 +0100 > > > "Daniel P. Berrange" wrote: > > > > > > > On Mon, May

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > However I didn't test the write-shareable case (the libvirt > flag which should map to a shared lock -- is that right Dan?). To Dan (mainly): I think setting the flag in libvirt only sets cache=unsafe on the qemu drive (it may

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-10 Thread Alberto Garcia
On Tue 10 May 2016 10:39:21 AM CEST, Kevin Wolf wrote: >>s->children = g_renew(BdrvChild *, s->children, ++s->num_children); >>s->children[s->num_children] = child; > > Without having checked the context, this code is not equivalent. You > need to access s->children[s->num_children

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: > On Mon, 9 May 2016 09:52:28 -0600 > Eric Blake wrote: > > > On 05/07/2016 05:32 PM, Nan Li wrote: > > > When running the command "dump-guest-memory", we usually need a large > > > space > > > of storage to save the dumpfile into dis

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote: > On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > > However I didn't test the write-shareable case (the libvirt > > flag which should map to a shared lock -- is that right Dan?). > > To Dan (mainly): I think

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-10 Thread Kevin Wolf
Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: > Sector-based blk_aio_readv() and blk_aio_writev() should die; switch > to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. > > As part of the cleanup, scsi_init_iovec() no longer needs to return > a value, and reword a comment. > > Si

Re: [Qemu-devel] [PATCH v7 00/19] block: kill sector-based blk_write/read

2016-05-10 Thread Kevin Wolf
Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: > 2.7 material, depends on Kevin's block-next: > git://repo.or.cz/qemu/kevin.git block-next > > Previously posted as part of a larger NBD series [1] and as v6 [3]. > Mostly orthogonal to Kevin's recent work to also kill sector > interfaces from th

Re: [Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 10:50:40AM +0800, Fam Zheng wrote: > They are wrappers of POSIX fcntl file locking, with the additional > interception of open/close (through qemu_open and qemu_close) to offer a > better semantics that preserves the locks across multiple life cycles of > different fds on th

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-10 Thread Paolo Bonzini
On 10/05/2016 08:09, Peter Xu wrote: > On Mon, May 09, 2016 at 01:58:48PM +0200, Paolo Bonzini wrote: >> Is this enough too? >> >> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c >> index 378e663..2443a35 100644 >> --- a/hw/intc/ioapic.c >> +++ b/hw/intc/ioapic.c >> @@ -72,6 +72,7 @@ static void

Re: [Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 09:57:48AM +0100, Daniel P. Berrange wrote: > On Tue, May 10, 2016 at 10:50:40AM +0800, Fam Zheng wrote: > > They are wrappers of POSIX fcntl file locking, with the additional > > interception of open/close (through qemu_open and qemu_close) to offer a > > better semantics t

[Qemu-devel] [PATCH] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..f406cc1 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -50,6 +50,7 @@ void rfifolock_lock(RFifoLock *r) if (r->nesting > 0 &&

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 10:50 hat Daniel P. Berrange geschrieben: > On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote: > > On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > > > However I didn't test the write-shareable case (the libvirt > > > flag which should map to

Re: [Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 10:06:35AM +0100, Richard W.M. Jones wrote: > On Tue, May 10, 2016 at 09:57:48AM +0100, Daniel P. Berrange wrote: > > On Tue, May 10, 2016 at 10:50:40AM +0800, Fam Zheng wrote: > > > They are wrappers of POSIX fcntl file locking, with the additional > > > interception of ope

Re: [Qemu-devel] [virtio-dev] [PATCH] Add virtio input device specification.

2016-05-10 Thread Gerd Hoffmann
Hi, > > +To query a specific piece of information the driver MUST set > > +\field{select} and \field{subsel} accordingly, then check \field{size} > > +to see and how much information is available. \field{size} can be > > +zero if no information is available. > > Is there a particular write ord

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 11:14:22AM +0200, Kevin Wolf wrote: > Am 10.05.2016 um 10:50 hat Daniel P. Berrange geschrieben: > > On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote: > > > On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > > > > However I didn't test th

Re: [Qemu-devel] [PATCH v2] vl: change runstate only if new state is different from current state

2016-05-10 Thread Paolo Bonzini
On 14/04/2016 05:25, Li Zhijian wrote: > Previously, qemu will abort at following scenario: > (qemu) stop > (qemu) system_reset > (qemu) system_reset > (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate > transition: 'prelaunch' -> 'prelaunch' > > Signed-off-by: Li Zhijian >

Re: [Qemu-devel] [Qemu-block] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext

2016-05-10 Thread Stefan Hajnoczi
On Mon, May 09, 2016 at 06:31:44PM +0200, Paolo Bonzini wrote: > On 19/04/2016 11:09, Stefan Hajnoczi wrote: > >> > This has better performance because it executes fewer system calls > >> > and does not use a bottom half per disk. > > Each aio_context_t is initialized for 128 in-flight requests in

Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend

2016-05-10 Thread Stefan Hajnoczi
On Mon, May 09, 2016 at 06:48:12PM +0200, Paolo Bonzini wrote: > > > On 11/04/2016 16:14, Stefan Hajnoczi wrote: > > 1. BlockBackend falls back to the QEMU main loop AioContext when there > >is no root BlockDriverState. This means the drive loses its > >AioContext during media change and

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 11:23 hat Daniel P. Berrange geschrieben: > On Tue, May 10, 2016 at 11:14:22AM +0200, Kevin Wolf wrote: > > Am 10.05.2016 um 10:50 hat Daniel P. Berrange geschrieben: > > > On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote: > > > > On Tue, May 10, 2016 at 09:14:26A

Re: [Qemu-devel] [PATCH] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Denis V. Lunev
On 05/10/2016 12:16 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..f406cc1 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -50,6 +50,7 @@ void rfifolock

Re: [Qemu-devel] [Qemu-block] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 11:30 hat Stefan Hajnoczi geschrieben: > On Mon, May 09, 2016 at 06:31:44PM +0200, Paolo Bonzini wrote: > > On 19/04/2016 11:09, Stefan Hajnoczi wrote: > > >> > This has better performance because it executes fewer system calls > > >> > and does not use a bottom half per disk. > >

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Petr Tesarik
On Tue, 10 May 2016 09:48:48 +0100 "Daniel P. Berrange" wrote: > On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: > > On Mon, 9 May 2016 09:52:28 -0600 > > Eric Blake wrote: > > > > > On 05/07/2016 05:32 PM, Nan Li wrote: > > > > When running the command "dump-guest-memory", we usu

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 11:35:14AM +0200, Kevin Wolf wrote: > Am 10.05.2016 um 11:23 hat Daniel P. Berrange geschrieben: > > On Tue, May 10, 2016 at 11:14:22AM +0200, Kevin Wolf wrote: > > > Am 10.05.2016 um 10:50 hat Daniel P. Berrange geschrieben: > > > > On Tue, May 10, 2016 at 09:43:04AM +0100,

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-05-10 Thread Changlong Xie
On 05/06/2016 11:46 PM, Stefan Hajnoczi wrote: On Fri, Apr 15, 2016 at 04:10:37PM +0800, Changlong Xie wrote: +static void replication_close(BlockDriverState *bs) +{ +BDRVReplicationState *s = bs->opaque; + +if (s->mode == REPLICATION_MODE_SECONDARY) { +g_free(s->top_id); +}

Re: [Qemu-devel] [PATCH 0/2] Dump: add a Filesystem in Userspace and command "fuse-mount"

2016-05-10 Thread Stefan Hajnoczi
On Sun, May 08, 2016 at 07:32:46AM +0800, Nan Li wrote: > These two patches introduce a Filesystem in Userspace (FUSE) and add a > "fuse-mount" command to support this filesystem. > > (1) > When running the command "dump-guest-memory", we usually need a large space > of storage to save the dumpfi

Re: [Qemu-devel] [PATCH] usb:xhci: no DMA on HC reset

2016-05-10 Thread Denis V. Lunev
On 05/04/2016 08:53 PM, Roman Kagan wrote: This patch is a rough fix to a memory corruption we are observing when running VMs with xhci USB controller and OVMF firmware. Specifically, on the following call chain xhci_reset xhci_disable_slot xhci_disable_ep xhci_set_ep_state QEMU

Re: [Qemu-devel] [PATCH] sm501: Remove support for DEPTH != 32

2016-05-10 Thread Sagar Ghuge
Gentle Reminder !!! is this correct patch or need to change anything ? On Wed, May 4, 2016 at 12:12 PM, Sagar Ghuge wrote: > Gentle Reminder ! > > Any comments on patch ? > > On Thu, Apr 28, 2016 at 3:24 PM, Sagar Ghuge wrote: > >> Forgot to CCing Paolo Bonzini. >> >> Added. >> >> -- F

Re: [Qemu-devel] [PATCH 0/2] Dump: add a Filesystem in Userspace and command "fuse-mount"

2016-05-10 Thread Stefan Hajnoczi
On Sun, May 08, 2016 at 07:32:46AM +0800, Nan Li wrote: > These two patches introduce a Filesystem in Userspace (FUSE) and add a > "fuse-mount" command to support this filesystem. > > (1) > When running the command "dump-guest-memory", we usually need a large space > of storage to save the dumpfi

Re: [Qemu-devel] [PATCH] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
On 05/10/2016 05:38 PM, Denis V. Lunev wrote: On 05/10/2016 12:16 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..f406cc1 100644 --- a/util/rfifolock.c +++ b/ut

[Qemu-devel] [PATCH v2] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..084c2f0 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -58,9 +58,9 @@ void rfifolock_lock(RFifoLock *r) }

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Stefan Hajnoczi
On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: > On Mon, 9 May 2016 09:52:28 -0600 > Eric Blake wrote: > > > On 05/07/2016 05:32 PM, Nan Li wrote: > > > When running the command "dump-guest-memory", we usually need a large > > > space > > > of storage to save the dumpfile into dis

Re: [Qemu-devel] [RESEND PATCH v3 0/8] libqos: use standard virtio headers

2016-05-10 Thread Stefan Hajnoczi
On Mon, May 09, 2016 at 03:57:13PM +0200, Paolo Bonzini wrote: > > > On 09/05/2016 14:47, Stefan Hajnoczi wrote: > > v2: > > * Fix missing s/X/(1u << X)/ conversion in Patch 3 [Marc] > > > > This patch series eliminates code duplication in libqos virtio. > > include/standard-headers/ contains t

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 11:14:22AM +0200, Kevin Wolf wrote: > Am 10.05.2016 um 10:50 hat Daniel P. Berrange geschrieben: > > On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote: > > > On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > > > > However I didn't test t

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 11:43 hat Daniel P. Berrange geschrieben: > On Tue, May 10, 2016 at 11:35:14AM +0200, Kevin Wolf wrote: > > Am 10.05.2016 um 11:23 hat Daniel P. Berrange geschrieben: > > > On Tue, May 10, 2016 at 11:14:22AM +0200, Kevin Wolf wrote: > > > > Am 10.05.2016 um 10:50 hat Daniel P. Berr

Re: [Qemu-devel] [virtio-dev] [PATCH] Add virtio gpu device specification.

2016-05-10 Thread Gerd Hoffmann
On Mo, 2016-05-09 at 15:43 +0100, Stefan Hajnoczi wrote: > On Wed, May 04, 2016 at 03:05:34PM +0200, Gerd Hoffmann wrote: > > Resuming the effort to get the gpu device specs merged. > > > > Support for 2d mode (3d/virgl mode is not covered by this patch) has > > been added to the linux kernel vers

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-10 Thread Peter Xu
On Tue, May 10, 2016 at 10:58:02AM +0200, Paolo Bonzini wrote: > > > On 10/05/2016 08:09, Peter Xu wrote: > > On Mon, May 09, 2016 at 01:58:48PM +0200, Paolo Bonzini wrote: > >> Is this enough too? > >> > >> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > >> index 378e663..2443a35 100644 > >>

[Qemu-devel] [PATCH v2] target-arm: Avoid unnecessary TLB flush on TCR_EL2, TCR_EL3 writes

2016-05-10 Thread Peter Maydell
The TCR_EL2 and TCR_EL3 regdefs wer incorrectly using the vmsa_tcr_el1_write function for writes. Since these registers don't have the A1 bit that TCR_EL1 does, we don't need to do a tlb_flush() when they are written. Remove the unnecessary .writefn and also the harmless but unneeded .raw_writefn a

[Qemu-devel] [PATCH] configure: fix error messages

2016-05-10 Thread Wei Jiangang
spice-server-devel is required, not spice-protocol-devel. "spice-protocol(>=0.12.3) devel" maybe mislead user. when configure isn't able to find the required usb-redir, It's better to explicitly output version requirement. Signed-off-by: Wei Jiangang --- configure | 4 ++-- 1 file changed, 2 in

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 12:07:06PM +0200, Kevin Wolf wrote: > I'm surprised how low the standards seem to be when we're talking about > data integrity. If occasionally losing data is okay, the qemu block > layer could be quite a bit simpler. I welcome this patch because it fixes a real data integr

[Qemu-devel] [PATCH 2/2] ioapic: clear remote irr bit for edge-triggered interrupts

2016-05-10 Thread Peter Xu
This is to better emulate IOAPIC version 0x1X hardware. Linux kernel leveraged this "feature" to do explicit EOI since EOI register is still not introduced at that time. This will also fix the issue that level triggered interrupts failed to work when IR enabled (tested with Linux kernel version 4.5

[Qemu-devel] [PATCH 0/2] IOAPIC: clear remote IRR for edge interrupts

2016-05-10 Thread Peter Xu
These two patches are seperated from v6 series of Intel IOMMU IR support. Existing read-only bits of IOAPIC registers are writable. We'd better follow the spec to make it read-only. The first patch did this. The 2nd patch emulated real IOAPIC behavior that remote IRR bits are cleared when configu

[Qemu-devel] [PATCH 1/2] ioapic: keep RO bits for IOAPIC entry

2016-05-10 Thread Peter Xu
Currently IOAPIC RO bits can be written. To be better aligned with hardware, we should let them read-only. Reviewed-by: Radim Krčmář Signed-off-by: Peter Xu --- hw/intc/ioapic.c | 4 include/hw/i386/ioapic_internal.h | 5 + 2 files changed, 9 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v2] rfifolock: no need to get thread identifier when nesting

2016-05-10 Thread Denis V. Lunev
On 05/10/2016 12:59 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- util/rfifolock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/rfifolock.c b/util/rfifolock.c index c22f5fe..084c2f0 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -58,9 +58,9 @@

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 12:07:06PM +0200, Kevin Wolf wrote: > Am 10.05.2016 um 11:43 hat Daniel P. Berrange geschrieben: > > On Tue, May 10, 2016 at 11:35:14AM +0200, Kevin Wolf wrote: > > > Am 10.05.2016 um 11:23 hat Daniel P. Berrange geschrieben: > > > > On Tue, May 10, 2016 at 11:14:22AM +0200,

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

2016-05-10 Thread Will Deacon
On Mon, May 09, 2016 at 01:44:11PM +, Catalin Marinas wrote: > On Mon, May 09, 2016 at 12:21:08PM +0100, Peter Maydell wrote: > > On 9 May 2016 at 11:59, Suzuki K Poulose wrote: > > > Well, we have been waiting for a use case, like this, before we merge > > > the series. > > > > This isn't a

[Qemu-devel] [PATCH v2] qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices

2016-05-10 Thread Peter Maydell
If qdev_try_create() is passed NULL for the bus, it will automatically put the newly created device onto the default system bus. However if the device is not actually a SysBusDevice then this will result in later crashes (for instance when running the monitor "info qtree" command) because code reas

Re: [Qemu-devel] [Qemu-block] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext

2016-05-10 Thread Paolo Bonzini
On 10/05/2016 11:40, Kevin Wolf wrote: > > Regarding performance, I'm thinking about a guest with 8 disks (queue > > depth 32). The worst case is when the guest submits 32 requests at once > > but the Linux AIO event limit has already been reached. Then the disk > > is starved until other disks

Re: [Qemu-devel] [PATCH v2] target-arm: Avoid unnecessary TLB flush on TCR_EL2, TCR_EL3 writes

2016-05-10 Thread Sergey Fedorov
On 10/05/16 13:11, Peter Maydell wrote: > The TCR_EL2 and TCR_EL3 regdefs wer incorrectly using the s/wer/were/ otherwise: Reviewed-by: Sergey Fedorov Kind regards, Sergey > vmsa_tcr_el1_write function for writes. Since these registers don't > have the A1 bit that TCR_EL1 does, we don't need

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-10 Thread Edgar E. Iglesias
On Tue, May 10, 2016 at 09:09:55AM +0100, Peter Maydell wrote: > On 10 May 2016 at 01:16, Alistair Francis wrote: > > It is actually a u-boot problem. I originally just assumed it was a > > Linux problem, but it happens before u-boot hands off to Linux. > > OK, that makes sense. u-boot tends to b

Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend

2016-05-10 Thread Paolo Bonzini
On 10/05/2016 11:33, Stefan Hajnoczi wrote: >> > >> > I'm not sure I agree with #2, as we should move away for the >> > super-coarse AioContext lock (it is heavyweight and it doesn't play well >> > with multiqueue). Atomics can be used for statistics, while the >> > time-based accounting probab

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-05-10 Thread Sergey Fedorov
On 09/05/16 15:49, Paolo Bonzini wrote: > > On 22/04/2016 10:08, Cornelia Huck wrote: However, to solve this problem, it would be enough to export ${cross_prefix} from configure to config-host.mak and do like this: $(CROSS_PREFIX)strip <...> >> I agree. This would probably b

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Nan Li
>>> On 5/10/2016 at 5:56 PM, Stefan Hajnoczi wrote: > On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: >> On Mon, 9 May 2016 09:52:28 ‑0600 >> Eric Blake wrote: >> >> > On 05/07/2016 05:32 PM, Nan Li wrote: >> > > When running the command "dump‑guest‑memory", we usually need a large

Re: [Qemu-devel] [PATCH RFC 0/3] qdev: order devices by priority before creating them

2016-05-10 Thread Marcel Apfelbaum
On 05/10/2016 11:28 AM, Markus Armbruster wrote: Marcel Apfelbaum writes: This series aims to allow more devices to be used with '-device' by sorting the devices based on a predefined creation order flag before creating them. Devices like IOMMU need to be created before others, so they can le

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 12:16 hat Richard W.M. Jones geschrieben: > On Tue, May 10, 2016 at 12:07:06PM +0200, Kevin Wolf wrote: > > I'm surprised how low the standards seem to be when we're talking about > > data integrity. If occasionally losing data is okay, the qemu block > > layer could be quite a bit

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 12:29 hat Daniel P. Berrange geschrieben: > On Tue, May 10, 2016 at 12:07:06PM +0200, Kevin Wolf wrote: > > Am 10.05.2016 um 11:43 hat Daniel P. Berrange geschrieben: > > > On Tue, May 10, 2016 at 11:35:14AM +0200, Kevin Wolf wrote: > > > > Am 10.05.2016 um 11:23 hat Daniel P. Berr

Re: [Qemu-devel] [virtio-dev] [PATCH] Add virtio gpu device specification.

2016-05-10 Thread Gerd Hoffmann
Hi, > > > Rendered versions are available here: > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.pdf > > > > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.html#x1-287 > > I guess a non-fenced command only completes when the operation has > > finished, too

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Nan Li
>>> On 5/10/2016 at 5:42 PM, Petr Tesarik wrote: > On Tue, 10 May 2016 09:48:48 +0100 > "Daniel P. Berrange" wrote: > >> On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: >> > On Mon, 9 May 2016 09:52:28 ‑0600 >> > Eric Blake wrote: >> > >> > > On 05/07/2016 05:32 PM, Nan Li wrote:

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-05-10 Thread Greg Kurz
On Mon, 9 May 2016 11:12:51 +0200 "Michael Fritscher" wrote: > Hello Greg, > Hi Michael ! > I commented your comments :-) > > To summerize: > * I didn't know where to put the win32 specific functions/wrappers - > thanks showing me the locations! > * Binary mode is needed by Windows - else

Re: [Qemu-devel] [PATCH 2/2] Dump: add command "fuse-mount"

2016-05-10 Thread Nan Li
>>> On 5/10/2016 at 12:48 AM, Eric Blake wrote: > On 05/07/2016 05:32 PM, Nan Li wrote: >> Add a "fuse-mount" command to support the Filesystem in Userspace (FUSE). >> It can mount or unmount the filesystem with both hmp and qmp commands. >> It calls the API function qemu_fuse_main(int argc, char

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
On Tue, May 10, 2016 at 01:08:49PM +0200, Kevin Wolf wrote: > Are you saying that libguestfs only allows operations like df on live > images, but not e.g. copying files out of the VM? [...] virt-copy-out will let you copy out files from a live VM. There's no difference between "safe" and "unsafe"

Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace

2016-05-10 Thread Petr Tesarik
On Tue, 10 May 2016 10:56:42 +0100 Stefan Hajnoczi wrote: > On Tue, May 10, 2016 at 07:59:41AM +0200, Petr Tesarik wrote: > > On Mon, 9 May 2016 09:52:28 -0600 > > Eric Blake wrote: > > > > > On 05/07/2016 05:32 PM, Nan Li wrote: > > > > When running the command "dump-guest-memory", we usually

Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Eduardo Habkost
On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > >> > Extend query-cpu-definitions schema to allow it to return two new > >> > option

Re: [Qemu-devel] [PATCH] qemu/kvm_stat: Powerpc related fixes

2016-05-10 Thread Paolo Bonzini
On 19/04/2016 05:29, Hemant Kumar wrote: > kvm_stat script is failing to execute on powerpc : > # ./kvm_stat > Traceback (most recent call last): > File "./kvm_stat", line 825, in > main() > File "./kvm_stat", line 813, in main > providers = get_providers(options) > File "./kvm_stat

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 13:46 hat Richard W.M. Jones geschrieben: > On Tue, May 10, 2016 at 01:08:49PM +0200, Kevin Wolf wrote: > > Are you saying that libguestfs only allows operations like df on live > > images, but not e.g. copying files out of the VM? > [...] > > virt-copy-out will let you copy out f

Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Eduardo Habkost
On Tue, May 10, 2016 at 08:32:53AM +0200, David Hildenbrand wrote: > > > > Yes, I think so. However to really make good hints, upper layers would > > > most > > > likely need more information about the exact problem with a property - > > > maybe something like an enum value per problematic proper

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Richard W.M. Jones
At no point did I say that it was safe to use libguestfs on live VMs or that you would always get consistent data out. But the fact that it can fail is understood, the chance of failure is really tiny (it has literally only happened twice that I've read corrupted data, in years of daily use), and

Re: [Qemu-devel] [PATCH v2 13/13] block: Don't check throttled reqs in bdrv_requests_pending()

2016-05-10 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:42 PM CEST, Kevin Wolf wrote: > Checking whether there are throttled requests requires going to the > associated BlockBackend, which we want to avoid. All users of > bdrv_requests_pending() already call bdrv_parent_drained_begin() > first, There's a couple of assert(!bdrv_

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Daniel P. Berrange
On Tue, May 10, 2016 at 01:11:30PM +0100, Richard W.M. Jones wrote: > At no point did I say that it was safe to use libguestfs on live VMs > or that you would always get consistent data out. > > But the fact that it can fail is understood, the chance of failure is > really tiny (it has literally o

Re: [Qemu-devel] [PATCH] target-i386: implement CPUID[0xB] (Extended Topology Enumeration)

2016-05-10 Thread Radim Krčmář
2016-05-09 22:49+0200, Radim Krčmář: > I looked at a dozen Intel CPU that have this CPUID and all of them > always had Core offset as 1 (a wasted bit when hyperthreading is > disabled) and Package offset at least 4 (wasted bits at <= 4 cores). > > QEMU uses more compact IDs and it doesn't make muc

Re: [Qemu-devel] [PATCH v2 05/13] block: Move throttling fields from BDS to BB

2016-05-10 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:34 PM CEST, Kevin Wolf wrote: > typedef struct BlockBackendPublic { > -/* I/O throttling */ > +/* I/O throttling. > + * throttle_state tells us if this BDS has I/O limits configured. > + * io_limits_disabled tells us if they are currently being enforced */

Re: [Qemu-devel] [PATCH v2 10/13] block: Decouple throttling from BlockDriverState

2016-05-10 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:39 PM CEST, Kevin Wolf wrote: > This moves the throttling related part of the BDS life cycle management > to BlockBackend. The throttling group reference is now kept even when no > medium is inserted. > > With this commit, throttling isn't disabled and then re-enabled any m

Re: [Qemu-devel] [PATCHv2 0/3] Better 'Force Unit Access' handling

2016-05-10 Thread Kevin Wolf
Am 04.05.2016 um 00:39 hat Eric Blake geschrieben: > I noticed some inconsistencies in FUA handling while working > with NBD, then Kevin pointed out that my initial attempt wasn't > quite right for iscsi which also had problems, so this has > expanded into a series rather than a single patch. > >

Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening

2016-05-10 Thread Kevin Wolf
Am 10.05.2016 um 14:22 hat Daniel P. Berrange geschrieben: > On Tue, May 10, 2016 at 01:11:30PM +0100, Richard W.M. Jones wrote: > > At no point did I say that it was safe to use libguestfs on live VMs > > or that you would always get consistent data out. > > > > But the fact that it can fail is u

Re: [Qemu-devel] KVM call for agenda for 2016-05-10

2016-05-10 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. No agenda, no call. See you in two weeks. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Summit, we are goi

Re: [Qemu-devel] [PATCH v2] qdev: Clean up around properties

2016-05-10 Thread Paolo Bonzini
Just comments, so Cc: qemu-triv...@nongnu.org On 17/04/2016 09:45, Cao jin wrote: > include: > 1. remove unnecessary declaration of static function > 2. fix inconsistency between comment and function name, and typo OOM->QOM > 2. update comments of functions, use uniform format(GTK-Doc style) > >

Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access

2016-05-10 Thread Eric Blake
On 05/10/2016 02:55 AM, Kevin Wolf wrote: > Am 06.05.2016 um 18:26 hat Eric Blake geschrieben: >> Sector-based blk_aio_readv() and blk_aio_writev() should die; switch >> to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. >> >> As part of the cleanup, scsi_init_iovec() no longer needs to

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

2016-05-10 Thread Catalin Marinas
Cc'ing Ramana to get some input from the toolchain side. On Tue, May 10, 2016 at 11:24:04AM +0100, Will Deacon wrote: > On Mon, May 09, 2016 at 01:44:11PM +, Catalin Marinas wrote: > > On Mon, May 09, 2016 at 12:21:08PM +0100, Peter Maydell wrote: > > > On 9 May 2016 at 11:59, Suzuki K Poulose

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

2016-05-10 Thread Paolo Bonzini
On 25/04/2016 13:55, Dominik Dingel wrote: > While in the anonymous ram case we already take care of the right alignment > such an alignment gurantee does not exist for file backed ram allocation. > > Instead, pagesize is used for alignment. On s390 this is not enough for gmap, > as we need to s

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Enable EL2 for the A53s and A57s

2016-05-10 Thread Peter Maydell
On 10 May 2016 at 11:36, Edgar E. Iglesias wrote: > On Tue, May 10, 2016 at 09:09:55AM +0100, Peter Maydell wrote: >> Edgar, do you have the list of what we're still missing before we >> can turn on EL2? > > We're missing the Data Abort ISS:s, we're missing modelling of a few registers > (like HST

[Qemu-devel] [PATCH] Fix QEMU PPC e500v1 efscmp* instructions

2016-05-10 Thread Imran, Talha
Hi Everyone, Please find attached a patch which fixes handling in QEMU PPC e500v1 for efscmp* instructions. This was the cause of over 400 FAILs for this CPU while running GCC testsuite, which have been fixed. Value for Condition Registers (CR) being set in QEMU was different from the value obser

Re: [Qemu-devel] [PATCH 03/23] target-arm: Define new arm_is_el3_or_mon() function

2016-05-10 Thread Shannon Zhao
On 2016年05月10日 01:29, Peter Maydell wrote: > The GICv3 system registers need to know if the CPU is AArch64 > in EL3 or AArch32 in Monitor mode. This happens to be the first > part of the check for arm_is_secure(), so factor it out into a > new arm_is_el3_or_mon() function that the GIC can also use.

Re: [Qemu-devel] [PATCH for-2.7 v3 00/12] vl: graphics stubs + #ifdef cleanup + DT_NOGRAPHIC cleanup

2016-05-10 Thread Paolo Bonzini
On 19/04/2016 21:55, Eduardo Habkost wrote: > * Clean up the graphics initialization code to reduce the > number of #ifdefs; > * Remove the display_type == DT_NOGRAPHIC checks from hardware > emulation code; > * Make the display_type global variable a local variable on > main(); > * Make th

  1   2   3   >