Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-06 Thread Greg Kurz
On Fri, 6 May 2016 08:01:09 +0200 Pradeep Kiruvale wrote: > On 4 May 2016 at 17:40, Greg Kurz wrote: > > > On Mon, 2 May 2016 17:49:26 +0200 > > Pradeep Kiruvale wrote: > > > > > On 2 May 2016 at 14:57, Greg Kurz wrote: > > > > > > > On Thu, 28 Apr 2016 11:45:41 +0200 > > > > Pradeep Kiruvale

Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c

2016-05-06 Thread Markus Armbruster
Peter Maydell writes: > On 5 May 2016 at 04:04, xiaoqiang zhao wrote: >> * Drop the old SysBus init function and use instance_init >> * Move tmu2_glx_init into realize stage >> >> Signed-off-by: xiaoqiang zhao > > Reviewed-by: Peter Maydell > >> +static void milkymist_tmu2_realize(DeviceState

Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices

2016-05-06 Thread Markus Armbruster
Peter Maydell writes: > On 5 May 2016 at 11:38, 赵小强 wrote: >> At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote: >>>This patch set trys to QOM'ify hw/char files, see commit messages >>>for more details >>> >>>Changes in v2: >>>* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is suggested

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-06 Thread Pradeep Kiruvale
On 6 May 2016 at 09:02, Greg Kurz wrote: > On Fri, 6 May 2016 08:01:09 +0200 > Pradeep Kiruvale wrote: > > > On 4 May 2016 at 17:40, Greg Kurz wrote: > > > > > On Mon, 2 May 2016 17:49:26 +0200 > > > Pradeep Kiruvale wrote: > > > > > > > On 2 May 2016 at 14:57, Greg Kurz wrote: > > > > > > >

Re: [Qemu-devel] [PATCH 2/6] hw/char: QOM'ify etraxfs_ser.c

2016-05-06 Thread Edgar E. Iglesias
On Thu, Mar 17, 2016 at 05:20:26PM +0800, xiaoqiang zhao wrote: > Drop the old SysBus init function and use instance_init > > Signed-off-by: xiaoqiang zhao Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias > --- > hw/char/etraxfs_ser.c | 11 +-- > 1 file changed, 5 inserti

Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 02:32 hat Fam Zheng geschrieben: > On Wed, 05/04 12:12, Kevin Wolf wrote: > > Am 19.04.2016 um 03:42 hat Fam Zheng geschrieben: > > > Currently we only inactivate the top BDS. Actually bdrv_inactivate > > > should be the opposite of bdrv_invalidate_cache. > > > > > > Recurse into

Re: [Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init

2016-05-06 Thread Catalin Vasile
Yes it is. Thanks From: Stefan Hajnoczi Sent: Thursday, May 5, 2016 9:00:33 PM To: Catalin Vasile Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] virtio-net and vhost-net init, virtio-scsi and vhost-scsi init On Thu, May 05, 2016 at 11:05:27AM +,

Re: [Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

2016-05-06 Thread Igor Mammedov
On Thu, 31 Mar 2016 14:09:19 +0530 Bharata B Rao wrote: > Set up device tree entries for the hotplugged CPU core and use the > exising RTAS event logging infrastructure to send CPU hotplug notification > to the guest. perhaps you could reuse: [RFC,20/42] machine: add cpu-hotplug machine option

[Qemu-devel] seabios does not support booting from usb-uas with nec-usb-xhci

2016-05-06 Thread Tom Yan
Strangely, seabios supports booting from usb-uas with usb-ehci: https://drive.google.com/open?id=0B50PCxfm5KU1dUFTUG9HU0pEcXc and usb-bot with nec-usb-xhci: https://drive.google.com/open?id=0B50PCxfm5KU1QnVzdTBIdEFzZW8 but not usb-uas with nec-usb-xhci: https://drive.google.com/open?id=0B50PCx

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-05-06 Thread Fam Zheng
On Tue, 05/03 02:43, Janne Karhunen wrote: > From: Janne Karhunen > > Vmdk images have metadata to indicate the vmware virtual > hardware version image was created/tested to run with. > Allow users to specify that version via new 'hwversion' > option. > > Signed-off-by: Janne Karhunen > --- >

Re: [Qemu-devel] seabios does not support booting from usb-uas with nec-usb-xhci

2016-05-06 Thread Tom Yan
On 6 May 2016 at 17:00, Tom Yan wrote: > > This makes me wonder if it is just a missing feature of a bug. > I meant "or" instead of "of".

Re: [Qemu-devel] [PATCH COLO-Frame v16 23/35] COLO failover: Don't do failover during loading VM's state

2016-05-06 Thread Changlong Xie
On 04/08/2016 02:26 PM, zhanghailiang wrote: We should not do failover work while the main thread is loading VM's state, otherwise it will destroy the consistent of VM's memory and device state. Here we add a new failover status 'RELAUNCH' which means we should relaunch the process of failover.

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-05-06 Thread Fam Zheng
On Fri, 05/06 08:15, Janne Karhunen wrote: > Fam, > > Any objections to this one? Looks good to me. I've left my reviewed-by in direct reply to the patch. Cc'ing block layer maintainers and qemu-block list. Fam

Re: [Qemu-devel] [PATCH v18 7/8] Implement new driver for block replication

2016-05-06 Thread Changlong Xie
On 04/15/2016 04:10 PM, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 625 +++ t

Re: [Qemu-devel] [PATCH 02/14] block: Cancel jobs first in bdrv_close_all()

2016-05-06 Thread Alberto Garcia
On Wed 04 May 2016 11:39:13 AM CEST, Kevin Wolf wrote: > void bdrv_close_all(void) > { > -BlockDriverState *bs; > -AioContext *aio_context; > +block_job_cancel_sync_all(); > > /* Drop references from requests still in flight, such as canceled block > * jobs whose AIO con

Re: [Qemu-devel] seabios does not support booting from usb-uas with nec-usb-xhci

2016-05-06 Thread Tom Yan
Sorry, I forgot to mention that I am using qemu 2.5.1 and seabios 1.9.2. On 6 May 2016 at 17:04, Tom Yan wrote: > On 6 May 2016 at 17:00, Tom Yan wrote: >> >> This makes me wonder if it is just a missing feature of a bug. >> > > I meant "or" instead of "of".

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
When I bootstrap gcc with the qemu built from your 680x0-master-dev branch I get a bootstrap comparison failure for a lot of files. Rerunning the stage1 compiler in aranym then produces object files that are identical to what the stage2 compiler produced, thus some insn (or combination thereof) onl

[Qemu-devel] [PATCH v3 2/3] xen: write information about supported backends

2016-05-06 Thread Juergen Gross
Add a Xenstore directory for each supported pv backend. This will allow Xen tools to decide which backend type to use in case there are multiple possibilities. The information is added under /local/domain//device-model//backends before the "running" state is written to Xenstore. Using a directory

[Qemu-devel] [PATCH v3 0/3] usb, xen: add pvUSB backend

2016-05-06 Thread Juergen Gross
This series adds a Xen pvUSB backend driver to qemu. USB devices connected to the host can be passed through to a Xen guest. The devices are specified via Xenstore. Access to the devices is done via host-libusb.c I've tested the backend with various USB devices (memory sticks, keyboard, ...). Cha

[Qemu-devel] [PATCH v3 1/3] xen: introduce dummy system device

2016-05-06 Thread Juergen Gross
Introduce a new dummy system device serving as parent for virtual buses. This will enable new pv backends to introduce virtual buses which are removable again opposed to system buses which are meant to stay once added. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD --- V2: NOT changed, ev

[Qemu-devel] [PATCH v3 3/3] xen: add pvUSB backend

2016-05-06 Thread Juergen Gross
Add a backend for para-virtualized USB devices for xen domains. The backend is using host-libusb to forward USB requests from a domain via libusb to the real device(s) passed through. Signed-off-by: Juergen Gross --- V3: multiple small changes as requested by Anthony Perard check for full ri

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Laurent Vivier
Le 06/05/2016 à 11:35, Andreas Schwab a écrit : > When I bootstrap gcc with the qemu built from your 680x0-master-dev > branch I get a bootstrap comparison failure for a lot of files. > Rerunning the stage1 compiler in aranym then produces object files that > are identical to what the stage2 comp

Re: [Qemu-devel] [PATCH v9 05/11] block: allow block jobs in any arbitrary node

2016-05-06 Thread Alberto Garcia
On Fri 29 Apr 2016 05:00:57 PM CEST, Kevin Wolf wrote: >> - Block jobs can now be identified by the node name of their >> BlockDriverState in addition to the device name. Since both device >> and node names live in the same namespace there's no ambiguity. > > Careful, we know this is a part of our

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Alexander Graf
On 04.05.16 22:11, Laurent Vivier wrote: > This series is an update of the series I sent last year: > > https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg01049.html > > Based on the series sent by Richard Henderson: > > https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg0179

Re: [Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

2016-05-06 Thread Bharata B Rao
On Fri, May 06, 2016 at 10:57:21AM +0200, Igor Mammedov wrote: > On Thu, 31 Mar 2016 14:09:19 +0530 > Bharata B Rao wrote: > > > Set up device tree entries for the hotplugged CPU core and use the > > exising RTAS event logging infrastructure to send CPU hotplug notification > > to the guest. > >

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
Laurent Vivier writes: > BTW, Adrian is using this branch (680x0-master-dev) for months to build > Debian packages. I don't trust it yet until it can bootstrap gcc. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And

[Qemu-devel] [PATCH] MAINTAINERS: update M68K entry

2016-05-06 Thread Laurent Vivier
Add myself to be the M68K maintainer. Signed-off-by: Laurent Vivier --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81e7fac..c79404c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -131,7 +131,8 @@ F: include/hw/lm32/ F: tests/

Re: [Qemu-devel] [PATCH v6 02/20] block: Drop private ioctl-only members of BlockRequest

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > I was thrown by the fact that the public type BlockRequest had > an anonymous union, but no obvious discriminator. Turns out > that the only client of the second branch of the union was code > internal to io.c, and that with a slight abuse of QE

Re: [Qemu-devel] [PATCH v1 0/6] A migration performance testing framework

2016-05-06 Thread Amit Shah
On (Thu) 05 May 2016 [15:27:54], Daniel P. Berrange wrote: > This series of patches provides a framework for testing migration performance > characteristics. The motivating factor for this is planning that is underway > in OpenStack wrt making use of QEMU migration features such as compression, > a

[Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-06 Thread Zhang Chen
Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 net/net.c | 56 ++ net/socket.c| 71 +

Re: [Qemu-devel] [RFC PATCH v2.1 10/12] spapr: CPU hotplug support

2016-05-06 Thread Igor Mammedov
On Fri, 6 May 2016 15:44:10 +0530 Bharata B Rao wrote: > On Fri, May 06, 2016 at 10:57:21AM +0200, Igor Mammedov wrote: > > On Thu, 31 Mar 2016 14:09:19 +0530 > > Bharata B Rao wrote: > > > > > Set up device tree entries for the hotplugged CPU core and use the > > > exising RTAS event logging

[Qemu-devel] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c

2016-05-06 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/jazz_led.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c i

[Qemu-devel] [PATCH v2 5/5] hw/display: QOM'ify pl110.c

2016-05-06 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/pl110.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.

[Qemu-devel] [PATCH v2 0/5] QOM'ify hw/display devices

2016-05-06 Thread xiaoqiang zhao
This patch set trys to QOM'ify hw/display files, see commit messages for more details. v1 -> v2: * fix a version variable override problem in pl110.c * remove the trailing punctuation in error_setg message xiaoqiang zhao (5): hw/display: QOM'ify exynos4210_fimd.c hw/display: QOM'ify jazz_le

[Qemu-devel] [PATCH v2 1/5] hw/display: QOM'ify exynos4210_fimd.c

2016-05-06 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/exynos4210_fimd.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/displ

[Qemu-devel] [PATCH v2 4/5] hw/display: QOM'ify milkymist-vgafb.c

2016-05-06 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/milkymist-vgafb.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/display/milkymist-vgafb.c b/hw/display/

[Qemu-devel] [PATCH v2 3/5] hw/display: QOM'ify milkymist-tmu2.c

2016-05-06 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Move tmu2_glx_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/milkymist-tmu2.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/display/milkymist-tmu2.c b/hw/display/

Re: [Qemu-devel] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c

2016-05-06 Thread Peter Maydell
On 6 May 2016 at 11:59, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Move graphic_console_init into realize stage > > Signed-off-by: xiaoqiang zhao > --- > hw/display/jazz_led.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 11:04 hat Fam Zheng geschrieben: > On Tue, 05/03 02:43, Janne Karhunen wrote: > > From: Janne Karhunen > > > > Vmdk images have metadata to indicate the vmware virtual > > hardware version image was created/tested to run with. > > Allow users to specify that version via new 'hwve

Re: [Qemu-devel] [PATCH COLO-Frame v16 23/35] COLO failover: Don't do failover during loading VM's state

2016-05-06 Thread Hailiang Zhang
On 2016/5/6 17:09, Changlong Xie wrote: On 04/08/2016 02:26 PM, zhanghailiang wrote: We should not do failover work while the main thread is loading VM's state, otherwise it will destroy the consistent of VM's memory and device state. Here we add a new failover status 'RELAUNCH' which means we

Re: [Qemu-devel] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c

2016-05-06 Thread xiaoqiang zhao
在 2016年05月06日 19:05, Peter Maydell 写道: On 6 May 2016 at 11:59, xiaoqiang zhao wrote: * Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao --- hw/display/jazz_led.c | 18 +++--- 1 file changed, 1

Re: [Qemu-devel] qcow2 resize with snapshots

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 07:57 hat zhangzhiming geschrieben: > hi, i want to implement the function of qcow2 resize which has snapshots. > each snapshot of qcow2 will have a separate total size, and when apply a > snapshot, > the image can be shrunk, and the total size of image will change after apply >

Re: [Qemu-devel] [RFC v2 03/11] docs: new design document multi-thread-tcg.txt (DRAFTING)

2016-05-06 Thread Sergey Fedorov
On 05/04/16 18:32, Alex Bennée wrote: > This is a current DRAFT of a design proposal for upgrading TCG emulation > to take advantage of modern CPUs by running a thread-per-CPU. The > document goes through the various areas of the code affected by such a > change and proposes design requirements for

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread John Paul Adrian Glaubitz
On 05/06/2016 11:54 AM, Laurent Vivier wrote: >> When I bootstrap gcc with the qemu built from your 680x0-master-dev >> branch I get a bootstrap comparison failure for a lot of files. That is odd. Both gcc-5 [1] and gcc-6 [2] build fine for me. > Yes, I know this is not perfect, but keeping all t

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread John Paul Adrian Glaubitz
On 05/06/2016 12:15 PM, Andreas Schwab wrote: > Laurent Vivier writes: > >> BTW, Adrian is using this branch (680x0-master-dev) for months to build >> Debian packages. > > I don't trust it yet until it can bootstrap gcc. How are you bootstrapping gcc? I'm surprised it doesn't work for you. Adr

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Alexander Graf
On 06.05.16 13:40, John Paul Adrian Glaubitz wrote: > On 05/06/2016 11:54 AM, Laurent Vivier wrote: >>> When I bootstrap gcc with the qemu built from your 680x0-master-dev >>> branch I get a bootstrap comparison failure for a lot of files. > > That is odd. Both gcc-5 [1] and gcc-6 [2] build fine

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Laurent Vivier
Le 06/05/2016 à 13:45, Alexander Graf a écrit : > > > On 06.05.16 13:40, John Paul Adrian Glaubitz wrote: >> On 05/06/2016 11:54 AM, Laurent Vivier wrote: When I bootstrap gcc with the qemu built from your 680x0-master-dev branch I get a bootstrap comparison failure for a lot of files

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Max Reitz
On 27.04.2016 15:20, Kevin Wolf wrote: > When block job errors were introduced, we assigned the iostatus of the > target BDS "just in case". The field has never been accessible for the > user because the target isn't listed in query-block. > > Before we can allow the user to have a second BlockBac

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Peter Maydell
On 6 May 2016 at 12:57, Laurent Vivier wrote: > Le 06/05/2016 à 13:45, Alexander Graf a écrit : >> Awesome, do you think you could port risu to 68k? >> >> https://git.linaro.org/people/peter.maydell/risu.git/ >> >> I was amazed by the quality the aarch64 emulation received once it was >> properl

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-06 Thread Jike Song
On 05/05/2016 05:06 PM, Tian, Kevin wrote: >> From: Kirti Wankhede >> >> >> + * @validate_map_request: Validate remap pfn request >> >> + * @vdev: vgpu device structure >> >> + * @virtaddr: target user address to start >> at >> >>

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-05-06 Thread Alberto Garcia
On Fri 06 May 2016 09:39:13 AM CEST, Pradeep Kiruvale wrote: >> The throttling API is currently only used by block devices, and the >> only documentation out-there is the code itself... > > Thanks, I will have a look and get back to you if I have any further > questions regarding this. As I said

Re: [Qemu-devel] [PATCH v6 02/20] block: Drop private ioctl-only members of BlockRequest

2016-05-06 Thread Eric Blake
On 05/06/2016 04:37 AM, Kevin Wolf wrote: > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: >> I was thrown by the fact that the public type BlockRequest had >> an anonymous union, but no obvious discriminator. Turns out >> that the only client of the second branch of the union was code >> inte

Re: [Qemu-devel] [PATCH v2 5/9] block: Remove bdrv_aio_multiwrite()

2016-05-06 Thread Eric Blake
On 04/27/2016 07:20 AM, Kevin Wolf wrote: > Since virtio-blk implements request merging itself these days, the only > remaining users are test cases for the function. That doesn't make the > function exactly useful any more. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block/b

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

2016-05-06 Thread Markus Armbruster
Eric Blake writes: > On 05/04/2016 09:45 AM, Markus Armbruster wrote: >> +void json_output_visitor_reset(JsonOutputVisitor *v); > > Hmm. Why is "reset" not a Visitor method? > > I think this would let us put the things enforced by your "qmp: Tighten > output visitor rules

Re: [Qemu-devel] [PATCH v6 05/20] block: Introduce byte-based aio read/write

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > blk_aio_readv() and blk_aio_writev() are annoying in that they > can't access sub-sector granularity, and cannot pass flags. > Also, they require the caller to pass redundant information > about the size of the I/O. > > Add new blk_aio_preadv()

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Max Reitz
On 06.05.2016 14:01, Max Reitz wrote: > On 27.04.2016 15:20, Kevin Wolf wrote: >> When block job errors were introduced, we assigned the iostatus of the >> target BDS "just in case". The field has never been accessible for the >> user because the target isn't listed in query-block. >> >> Before we

[Qemu-devel] [PATCH v3 0/5] postcopy (& 1 test) patch for 2.7

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This is a small set of postcopy changes, the largest of which is an x86 test for postcopy. Andrea's libqtest change came about from running my test under very heavy load. The test includes a self contained migration workload that rapidly changes RAM in a pre

[Qemu-devel] [PATCH v3 2/5] Migration: Split out ram part of qmp_query_migrate

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The RAM section of qmp_query_migrate is reasonably complex and repeated 3 times. Split it out into a helper. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Reviwed-by: Denis V. Lunev --- migration/migration.c | 57 ---

[Qemu-devel] [PATCH v3 3/5] Postcopy: Add stats on page requests

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" On the source, add a count of page requests received from the destination. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev --- hmp.c | 4 include/migration/migration.h | 2 ++ migration/migr

[Qemu-devel] [PATCH v3 4/5] test: Postcopy

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a postcopy test (x86 only) that actually runs the guest and checks the memory contents. The test runs from an x86 boot block with the hex embedded in the test; the source for this is: ... .code16 .org 0x7c00 .file "fill.s" .text

[Qemu-devel] [PATCH v3 5/5] tests: fix libqtest socket timeouts

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: Andrea Arcangeli I kept getting timeouts and unix socket accept failures under high load, the patch fixes it. Signed-off-by: Andrea Arcangeli Reviewed-by: Marcel Apfelbaum --- tests/libqtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/l

[Qemu-devel] [PATCH v3 1/5] Postcopy: Avoid 0 length discards

2016-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The discard code in migration/ram.c would send request for zero length discards in the case where no discards were needed. It doesn't appear to have had any bad effect. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Denis V. Lunev --- migration/ram.c | 4 +++

Re: [Qemu-devel] [PATCH v2 4/5] test: Postcopy

2016-05-06 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > > > > > > +int main(int argc, char **argv) > > > > > > +{ > > > > > > +char template[] = "/tmp/postcopy-test-XX"; > > > > > > > > > > I would not explicitly use /tmp/ > > > > > > > > The ivshmem-test, vhost-user-test and test-qga seem to do

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
John Paul Adrian Glaubitz writes: > On 05/06/2016 12:15 PM, Andreas Schwab wrote: >> Laurent Vivier writes: >> >>> BTW, Adrian is using this branch (680x0-master-dev) for months to build >>> Debian packages. >> >> I don't trust it yet until it can bootstrap gcc. > > How are you bootstrapping g

Re: [Qemu-devel] [PATCH v6 07/20] scsi-disk: Switch to byte-based aio block access

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > Sector-based blk_aio_readv() and blk_aio_writev() should die; switch > to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. > > Signed-off-by: Eric Blake > --- > hw/scsi/scsi-disk.c | 31 +++ > 1 file chang

Re: [Qemu-devel] [PATCH v2 7/9] block: Avoid bs->blk in bdrv_next()

2016-05-06 Thread Max Reitz
On 27.04.2016 15:20, Kevin Wolf wrote: > We need to introduce a separate BdrvNextIterator struct that can keep > more state than just the current BDS in order to avoid using the bs->blk > pointer. > > Signed-off-by: Kevin Wolf > --- > block.c| 34 ++-- > b

Re: [Qemu-devel] [PATCH v2 08/13] block: Introduce BdrvChild.opaque

2016-05-06 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:37 PM CEST, Kevin Wolf wrote: > BlockBackends use it to get a back pointer from BdrvChild to > BlockBackend in any BdrvChildRole callbacks. Hmmm... can anyone else use this, other than BlockBackend? If not, why is it opaque? Berto

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread John Paul Adrian Glaubitz
On 05/06/2016 02:44 PM, Andreas Schwab wrote: > You are cheating, you override BOOT_CFLAGS. I'm not doing anything. I'm building the package as Matthias has provided it and it builds fine. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie U

Re: [Qemu-devel] [PATCH 1/2] migration: Move qjson.[ch] to migration/

2016-05-06 Thread Markus Armbruster
Eric Blake writes: > On 05/04/2016 10:49 AM, Markus Armbruster wrote: >> Type QJSON lets you build JSON text. Its interface mirrors (a subset >> of) abstract JSON syntax. >> >> QAPI output visitors also produce JSON text. They assert their >> preconditions and invariants, and therefore abort o

Re: [Qemu-devel] [PATCH v6 17/20] nbd: Switch to byte-based block access

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > Sector-based blk_read() should die; switch to byte-based > blk_pread() instead. > > Signed-off-by: Eric Blake > --- > qemu-nbd.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > in

Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, clean up

2016-05-06 Thread Markus Armbruster
Eric Blake writes: > On 05/04/2016 10:49 AM, Markus Armbruster wrote: >> qjson.[ch] is a JSON writer used by migration. Eric proposed to >> replace it by common code in his "Add qapi-to-JSON and clone visitors" >> series. David's review led to the conclusion that migration would >> prefer to ke

Re: [Qemu-devel] [PATCH v6 00/20] block: kill sector-based blk_write/read

2016-05-06 Thread Kevin Wolf
Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > 2.7 material, depends on Kevin's block-next: > git://repo.or.cz/qemu/kevin.git block-next > > Previously posted as part of a larger NBD series [1] and as v5 [2]. > Mostly orthogonal to Kevin's recent work to also kill sector > interfaces from th

Re: [Qemu-devel] [PATCH v2 08/13] block: Introduce BdrvChild.opaque

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 14:54 hat Alberto Garcia geschrieben: > On Fri 22 Apr 2016 07:42:37 PM CEST, Kevin Wolf wrote: > > BlockBackends use it to get a back pointer from BdrvChild to > > BlockBackend in any BdrvChildRole callbacks. > > Hmmm... can anyone else use this, other than BlockBackend? If not, w

Re: [Qemu-devel] [PATCH v8 1/3] block: add support for --image-opts in block I/O tests

2016-05-06 Thread Max Reitz
On 18.04.2016 14:21, Daniel P. Berrange wrote: > Currently all block tests use the traditional syntax for images > just specifying a filename. To support the LUKS driver without > resorting to JSON, the tests need to be able to use the new > --image-opts argument to qemu-img and qemu-io. > > This

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
John Paul Adrian Glaubitz writes: > On 05/06/2016 02:44 PM, Andreas Schwab wrote: >> You are cheating, you override BOOT_CFLAGS. > > I'm not doing anything. Yes, you do. See the build log. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3

Re: [Qemu-devel] [PATCH v8 2/3] block: add support for encryption secrets in block I/O tests

2016-05-06 Thread Max Reitz
On 18.04.2016 14:21, Daniel P. Berrange wrote: > The LUKS block driver tests will require the ability to specify > encryption secrets with block devices. This requires using the > --object argument to qemu-img/qemu-io to create a 'secret' > object. > > When the IMGKEYSECRET env variable is set, it

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 14:32 hat Max Reitz geschrieben: > On 06.05.2016 14:01, Max Reitz wrote: > > On 27.04.2016 15:20, Kevin Wolf wrote: > >> When block job errors were introduced, we assigned the iostatus of the > >> target BDS "just in case". The field has never been accessible for the > >> user beca

Re: [Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests

2016-05-06 Thread Max Reitz
On 18.04.2016 14:21, Daniel P. Berrange wrote: > This adds support for testing the LUKS driver with the block > I/O test framework. > >cd tests/qemu-io-tests >./check -luks > > A handful of test cases are modified to work with luks > > - 004 - whitelist luks format > - 012 - use TEST_I

Re: [Qemu-devel] [PATCH v2 4/9] blockjob: Don't touch BDS iostatus

2016-05-06 Thread Max Reitz
On 27.04.2016 15:20, Kevin Wolf wrote: > Block jobs don't actually make use of the iostatus for their BDSes, but > they manage a separate block job iostatus. Still, they require that it > is enabled for the source BDS and they enable it automatically for the > target and set the error handling mode

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Max Reitz
On 06.05.2016 15:31, Kevin Wolf wrote: > Am 06.05.2016 um 14:32 hat Max Reitz geschrieben: >> On 06.05.2016 14:01, Max Reitz wrote: >>> On 27.04.2016 15:20, Kevin Wolf wrote: When block job errors were introduced, we assigned the iostatus of the target BDS "just in case". The field has ne

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread John Paul Adrian Glaubitz
On 05/06/2016 03:24 PM, Andreas Schwab wrote: > John Paul Adrian Glaubitz writes: > >> On 05/06/2016 02:44 PM, Andreas Schwab wrote: >>> You are cheating, you override BOOT_CFLAGS. >> >> I'm not doing anything. > > Yes, you do. See the build log. As I have said before, the gcc package is being

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
John Paul Adrian Glaubitz writes: > On 05/06/2016 03:24 PM, Andreas Schwab wrote: >> John Paul Adrian Glaubitz writes: >> >>> On 05/06/2016 02:44 PM, Andreas Schwab wrote: You are cheating, you override BOOT_CFLAGS. >>> >>> I'm not doing anything. >> >> Yes, you do. See the build log. >

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread John Paul Adrian Glaubitz
On 05/06/2016 03:48 PM, Andreas Schwab wrote: > It doesn't matter what you changed, fact is that you are not building an > unoptimized stage1 compiler, so you are comparing apples with oranges. Well, I know Matthias Klose well enough in that regard that I think I can trust him to produce a usable

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Laurent Vivier
Le 06/05/2016 à 12:15, Andreas Schwab a écrit : > Laurent Vivier writes: > >> BTW, Adrian is using this branch (680x0-master-dev) for months to build >> Debian packages. > > I don't trust it yet until it can bootstrap gcc. I will try to debug that. What is the version of gcc? what are your c

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
Laurent Vivier writes: > What is the version of gcc? It doesn't matter, any version. > what are your configure parameters? Nothing special. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something compl

Re: [Qemu-devel] [PATCH v3 07/18] qapi: Add json output visitor

2016-05-06 Thread Eric Blake
On 05/06/2016 06:31 AM, Markus Armbruster wrote: >> So all that's left are the two output functions. Can we get rid >> of those, and make Visitor* the only public interface, rather than >> making every caller have to do upcasts? > > The two output functions are > > QObject *qmp_output_get_q

Re: [Qemu-devel] [PATCH v6 05/20] block: Introduce byte-based aio read/write

2016-05-06 Thread Eric Blake
On 05/06/2016 06:31 AM, Kevin Wolf wrote: >> +++ b/include/sysemu/block-backend.h >> @@ -110,9 +110,15 @@ int64_t blk_nb_sectors(BlockBackend *blk); >> BlockAIOCB *blk_aio_readv(BlockBackend *blk, int64_t sector_num, >>QEMUIOVector *iov, int nb_sectors, >>

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 15:40 hat Max Reitz geschrieben: > On 06.05.2016 15:31, Kevin Wolf wrote: > > Am 06.05.2016 um 14:32 hat Max Reitz geschrieben: > >> On 06.05.2016 14:01, Max Reitz wrote: > >>> On 27.04.2016 15:20, Kevin Wolf wrote: > When block job errors were introduced, we assigned the iost

[Qemu-devel] [PATCH] nbd: fix trim/discard commands with a length bigger than NBD_MAX_BUFFER_SIZE

2016-05-06 Thread Quentin Casasnovas
When running fstrim on a filesystem mounted through qemu-nbd with --discard=on, fstrim would fail with I/O errors: $ fstrim /k/spl/ice/ fstrim: /k/spl/ice/: FITRIM ioctl failed: Input/output error and qemu-nbd was spitting these: nbd.c:nbd_co_receive_request():L1232: len (94621696) is larg

Re: [Qemu-devel] [PATCH v6 07/20] scsi-disk: Switch to byte-based aio block access

2016-05-06 Thread Eric Blake
On 05/06/2016 06:50 AM, Kevin Wolf wrote: > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: >> Sector-based blk_aio_readv() and blk_aio_writev() should die; switch >> to byte-based blk_aio_preadv() and blk_aio_pwritev() instead. >> >> @@ -343,8 +343,9 @@ static void scsi_do_read(SCSIDiskReq *r,

Re: [Qemu-devel] [PATCH v6 17/20] nbd: Switch to byte-based block access

2016-05-06 Thread Eric Blake
On 05/06/2016 07:08 AM, Kevin Wolf wrote: > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: >> Sector-based blk_read() should die; switch to byte-based >> blk_pread() instead. >> >> Signed-off-by: Eric Blake >> --- >> qemu-nbd.c | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH v6 00/20] block: kill sector-based blk_write/read

2016-05-06 Thread Eric Blake
On 05/06/2016 07:11 AM, Kevin Wolf wrote: > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: >> 2.7 material, depends on Kevin's block-next: >> git://repo.or.cz/qemu/kevin.git block-next >> >> Previously posted as part of a larger NBD series [1] and as v5 [2]. >> Mostly orthogonal to Kevin's rece

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
Here is a testcase: when compiling tlink.c from the gcc sources with gcc-6 r234449 (which was bootstrapped in aranym): $ g++ -fno-PIE -c -fomit-frame-pointer -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-f

Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

2016-05-06 Thread Eric Blake
On 05/06/2016 07:31 AM, Kevin Wolf wrote: >> >> Maybe I need to take that back. Using e.g. blockdev-backup, you can >> indeed see the target in query-block. >> >> Where mnt is a file system and test.qcow2 is large enough such that an >> ENOSPC will occur. > > Hm... Let's pretend we didn't notice.

Re: [Qemu-devel] [PATCH 00/52] 680x0 instructions emulation

2016-05-06 Thread Andreas Schwab
Andreas Schwab writes: > Here is a testcase: > > when compiling tlink.c from the gcc sources with gcc-6 r234449 (which > was bootstrapped in aranym): > > $ g++ -fno-PIE -c -fomit-frame-pointer -O2 -DIN_GCC -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing >

Re: [Qemu-devel] [PATCH v6 07/20] scsi-disk: Switch to byte-based aio block access

2016-05-06 Thread Kevin Wolf
Am 06.05.2016 um 16:18 hat Eric Blake geschrieben: > On 05/06/2016 06:50 AM, Kevin Wolf wrote: > > Am 05.05.2016 um 01:55 hat Eric Blake geschrieben: > >> @@ -1730,13 +1730,11 @@ static void scsi_write_same_complete(void *opaque, > >> int ret) > >> if (data->iov.iov_len) { > >> block

Re: [Qemu-devel] [PATCH v2 08/13] block: Introduce BdrvChild.opaque

2016-05-06 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:37 PM CEST, Kevin Wolf wrote: > BlockBackends use it to get a back pointer from BdrvChild to > BlockBackend in any BdrvChildRole callbacks. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 09/13] block: Drain throttling queue with BdrvChild callback

2016-05-06 Thread Alberto Garcia
On Fri 22 Apr 2016 07:42:38 PM CEST, Kevin Wolf wrote: > This removes the last part of I/O throttling from block/io.c and moves > it to the BlockBackend. > > Instead of having knowledge about throttling inside io.c, we can call a > BdrvChild callback .drained_begin/end, which happens to drain the >

Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-05-06 Thread Max Reitz
On 13.04.2016 10:33, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > --- > block.c | 8 +++--- > block/quorum.c| 78 > +++

Re: [Qemu-devel] [PATCH v4 2/6] qemu-io: Use bool for command line flags

2016-05-06 Thread Max Reitz
On 05.05.2016 05:42, Eric Blake wrote: > We require a C99 compiler; let's use it to express what we > really mean. > > Signed-off-by: Eric Blake > --- > qemu-io-cmds.c | 94 > +- > 1 file changed, 47 insertions(+), 47 deletions(-) Reviewe

  1   2   3   >